From nobody Tue Dec 2 02:32:18 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B483353893 for ; Wed, 19 Nov 2025 16:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570637; cv=none; b=uCnsL4oUulwXu+Pyag60RGJW/1pIe6qzfdIgMqzSs/5JuDxPJzEXUXPEjayETtBZv24OmfaxxtN3lAtq7oYiy7XFtl0Is7w5JxD4ONsEgWNVb+hQ8K77zCrsVpqdTdWzXYWkF5Y05qGAtuMJybiEvOGEDNBfxzulu03BcWoJV/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763570637; c=relaxed/simple; bh=CEmcZWtzamDWjENYpUehIz1+b4VZ/P2WrnLYFaTHfSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HKemUXw2djzeq8adoEMmjrXhSPeeo6v8MCSu9wYFn03oqmjvbikWtPGLlyZySi2zsIsopZx+t+xtjOxYyq/oxTp/guuXxfn9CokESAGlu67s/zNgGrIB6Xp/Bec86uwv2OmM2L3FrhCeItvlE434k6tYoKj6CNr0Gn2iNmwf7Vo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Xuh0iiRR; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Xuh0iiRR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763570627; bh=CEmcZWtzamDWjENYpUehIz1+b4VZ/P2WrnLYFaTHfSk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xuh0iiRRFdaBv8cA/48i22SS6gx7eFkLmTTFEHcyIcrT54PykoyCk1PeMYHLMm655 Fc8mKWoMRjtiDcFr3kXyWIfS9ZPLGQvtlQVyA/zuVnuoTPVc68XfDgEBEP3r8dp3GI DOsnQc4oKUeZKFxBaZ0ZSckSpYsSYyWOIq7f5QPbAbwv9Ift69OUJ/WkDeTJEwE60u TMAbe73XAiOtWdjbk0psY5NxHPchRzIG9T3nPkQQo2zJ9PHjb98TwSH9plxlv0LFcS FmTiJI10IAiHzWOJfvNvYatrE4vx2zvYZPcWJ6DJKsddkFhmo7rC8TV1k/zDNLI+aE uOVwnS1Dpjpuw== Received: from localhost.localdomain (unknown [92.206.121.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: gerddie) by bali.collaboradmins.com (Postfix) with ESMTPSA id 52D8417E13C1; Wed, 19 Nov 2025 17:43:47 +0100 (CET) From: gert.wollny@collabora.com To: Christian Gmeiner Cc: Lucas Stach , Russell King , David Airlie , Daniel Vetter , Marek Vasut , etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Gert Wollny , Christian Gmeiner Subject: [PATCH v5 5/5] drm/etnaviv: Add module parameter to force PPU flop reset Date: Wed, 19 Nov 2025 17:45:51 +0100 Message-ID: <20251119164624.9297-6-gert.wollny@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251119164624.9297-1-gert.wollny@collabora.com> References: <20251110144625.18653-1-gert.wollny@collabora.com> <20251119164624.9297-1-gert.wollny@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Gert Wollny v2: Check for feature PIPE_3D when forcing PPU flop reset (Lucas) v3: - drop use of ppu_flop_reset enum (Christian Gmeiner) - don't initialize module parameter to zero (checkpatch) - avoid multi-line string in warning message (checkpatch) Signed-off-by: Gert Wollny Reviewed-by: Christian Gmeiner --- drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c b/drivers/gpu/drm= /etnaviv/etnaviv_flop_reset.c index 6ed2471f3..a78119e0a 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_flop_reset.c @@ -15,6 +15,9 @@ =20 #include "etnaviv_flop_reset.h" =20 +static int etnaviv_force_flop_reset; +module_param_named(force_flop_reset, etnaviv_force_flop_reset, int, 0); + #define PPU_IMAGE_STRIDE 64 #define PPU_IMAGE_XSIZE 64 #define PPU_IMAGE_YSIZE 6 @@ -150,6 +153,19 @@ bool etnaviv_flop_reset_ppu_require(const struct etnav= iv_chip_identity *chip_id) return true; } =20 + if (etnaviv_force_flop_reset) { + if (!(chip_id->features & chipFeatures_PIPE_3D)) { + pr_warn("Etnaviv: model: 0x%04x, revision: 0x%04x does not support PIPE= _3D\n", + chip_id->model, chip_id->revision); + pr_warn("Request to force PPU flop reset ignored.\n"); + return false; + } + + pr_info("Force PPU flop reset for model: 0x%04x, revision: 0x%04x\n", + chip_id->model, chip_id->revision); + return true; + } + return false; } =20 --=20 2.51.0