From nobody Tue Dec 2 02:20:00 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6E1F32D0ED for ; Wed, 19 Nov 2025 14:49:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563781; cv=none; b=GrTFI6PqUGhiceWyEcJajOVjoGsCOZgcMsO08KqmrdvNv67Dota89QtpG2ZPP8eEvIEayQoceIyGmxMIKybxZMOwBNXw/FMk4w4num1Y6HFRvcIjkzuVJtQmEoghjZa0ub+Elz5ofO9T9CrUCoys1yxWsBJrR1w0KqpBmShzbbo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763563781; c=relaxed/simple; bh=3oYyxo/eiHHMiZgQI94sg65seo7XfkQSAjlKIt7w93g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=j+vYnMNndMayzajQmk/ntvvMa8dAceh/q2BXEeMhIOPokGFL+XNv7/81xYDA7iL/+fndnFX5wtLAdgpWxXpNe98R5CL6ViDm5RU8nZTeGJdDORsK3nJwisYs/vW/y7uOBxGalCfOGmLFXkImMYMtXYE+Sndkp3pgGSb71qDi1Rk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gCe3tRgu; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gCe3tRgu" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3c965df5so3969455f8f.1 for ; Wed, 19 Nov 2025 06:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763563778; x=1764168578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5ysI+6IOL7sqeQ8on1/EuP2SEU7hi9xtgLviKdqSFWY=; b=gCe3tRguWCAS094e8Li4y5yUlrV+Z3sQ6sp2LN7TQtRfuy0xX+NRzu9pnTa8s2uWJ6 T94N++pUI8C2cxfrdaNfUAeCi3oSAkCHS2AUj5G8mxnfJ8GyMzYAB31smrtEjcpYVxRz mAqbYc35guvfRxLmoVeHB2q75gzoF8T/dChpQIfJKkl0+vUgGbODCy4OVOxmNLv1wBXc M6FdurEfO3QG2Ijrwhg5VIv9n+r5mGB2Li5kPZQ5W3o5jpHUh/dOWwMJUxnt1aQvdGgN OOxCyEoGIk3xrdqAiwcdUxfT//46TAKzGXaGMHxnxgYSHwVW+IhAFSa8OtxNwX2A0Vsc VKJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763563778; x=1764168578; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ysI+6IOL7sqeQ8on1/EuP2SEU7hi9xtgLviKdqSFWY=; b=Osdkt1nMehImSaXIwWUKwJRJ+71Bt2wQGv8yQYPeb5SEJ7wraIUlT0UicHzpgMq3F8 TNqSibLs61HhXbJrm5UfEriPmXOWycXKJ4i87L9OgZuufJtodvWghSyZVv8NWc129w95 gGYh2wts1Mgv35ZWlrVjPjDbIwa2y9e+N+2vXZAXZUgi7XaY7GqvUDb9RKAhYF3w96PZ Pm+ORYsFUTNhN5rv1zeRS6chb2l52sJTD+ATKfiAt9/YMNTdKiIvft008xsPIPoa2y8l NXIZzEC9ZKlkQomAoomv1/gpBAZ90cd4AdphQKgB6fq08ePAN7166vlDz79kl9j0bOQx tTBQ== X-Forwarded-Encrypted: i=1; AJvYcCXL27ovN6lFcFqdO90VDaEayE1oCtx9Lmigmt1TU3KcFqDgdJ7y5QudzfOLy7HmpPVqBIKtumWLvz6aR9M=@vger.kernel.org X-Gm-Message-State: AOJu0YwiIGDx1sRdDOGgf3FbUO0M4oHzrgteP6vhv6/5foeeNB5nzlMh qkzCJhRn9OyiEy9NdI/aTBGzjMin3r4yVJkL3vaGoK1jUPoeT8fNxsSE X-Gm-Gg: ASbGncu0wnG5ldq5swwInFSPjj+xwW6fDvYO4AiH+A06fkUUSg1Px7ZgBAK7zvl8RNN AG8kVM2DDdN2MfO7NqfIDEEOv4gUwMFu0LOM3xFWnKrQY3bxiz9tDiX9HzTsNdR9NOM0vNSxFBU 9KliUuL799TS9/YfrMNKY1cm9zgeJQk1XpatiJihYSPHStFBOLICHc7/Gcn01CAIwsQJ1heVx3E xjmpBFkKCtOBDgn//3xZsMWcP5ezAieeMyHvyahrxXG7qLfCr3SkJWy2700Hy6p9UguBny/AhVA oIMFHIGsZ3E/UcxuYe9bVegGuBJwayYgdOH2fr+L1OnShip1pKXzZxNJIrVpAcn3eeungsetLS1 bCqfPmgBuduW2d77mQvwkDZNeK1xq/C0Ua7bCQPewhMQ49U4+yosiBr23c3Ruk+DEQqVfk5SA7L i1Vd/J62qefk0WwN9DfBZLNao6uAFA3goongnYVobqc2RneurQGeZosSrukHM= X-Google-Smtp-Source: AGHT+IFyDFdHzHB9hzSqqAYdxi42ocjcvoYYE9cbVjQE3BDzr31CF+y74/qmoYF7TkWC7LWPSHx5Rg== X-Received: by 2002:a05:6000:4020:b0:42b:3ee9:4771 with SMTP id ffacd0b85a97d-42b593503ffmr20237249f8f.23.1763563777835; Wed, 19 Nov 2025 06:49:37 -0800 (PST) Received: from f.. (cst-prg-14-82.cust.vodafone.cz. [46.135.14.82]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e85cc0sm39590390f8f.17.2025.11.19.06.49.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 06:49:36 -0800 (PST) From: Mateusz Guzik To: brauner@kernel.org Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Mateusz Guzik Subject: [PATCH] fs: mark lookup_slow() as noinline Date: Wed, 19 Nov 2025 15:49:30 +0100 Message-ID: <20251119144930.2911698-1-mjguzik@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Otherwise it gets inlined notably in walk_component(), which convinces the compiler to push/pop additional registers in the fast path to accomodate existence of the inlined version. Shortens the fast path of that routine from 87 to 71 bytes. Signed-off-by: Mateusz Guzik --- The intent is to get to a point where I can inline walk_component and step_into. This is probably the last patch of the sort before I write a patchset + provide bench results. fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 11295fcf877c..667360deef48 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -1863,7 +1863,7 @@ static struct dentry *__lookup_slow(const struct qstr= *name, return dentry; } =20 -static struct dentry *lookup_slow(const struct qstr *name, +static noinline struct dentry *lookup_slow(const struct qstr *name, struct dentry *dir, unsigned int flags) { --=20 2.48.1