From nobody Tue Dec 2 02:29:10 2025 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A02B3369969 for ; Wed, 19 Nov 2025 13:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763557766; cv=none; b=NAecd/OxI/LVOvxTsOEjWP8h+7UZQzDT9DK0DXy0xBizNyNK2EkhhhRkd+CpnTaPn5lYD/5Bwn/r+Gct6wvGEEHARM7WBD6uaXCJTfZ0wuPToTDgTd3fIhFiJm+/iJJOO027pZDsebX8z2lk16RZcN94FZK9UGu8MJqnVCyQADU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763557766; c=relaxed/simple; bh=NENJ76xybs+hvpDu5LJAnhejEWZeDsuvfrEqnXX6oVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NPcB5EwsQctG8sO+/wbaI4bh5BAFywDrOSbgWKXcff6RkKzDMMKyFeTKkTUH2E0SAo+j5A67JuqFeWSaM1moGetn+wUAef6Dv0bon4PV7jwLAxomquSoHmZBrRkFpel4wd9dv6xThnjXgoyaqlO8dK1PzPHfUADqJN/8tPKpSm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bbhI+mwU; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bbhI+mwU" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7b9a98b751eso5097411b3a.1 for ; Wed, 19 Nov 2025 05:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763557764; x=1764162564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fC/QdmI3jNw4W9z6Eomd9eORRY4agyuexEsQOqxsWWA=; b=bbhI+mwUuGBcooA/n4+Z4FViS+xACvHQE+brpNTVo7ISsZCGlwmOwQAE4fH4Spj8o0 xQtGS74aEAH5Frzrh/uRmonwksR/R7nR7zHf/Dqjmi31szei4MOpeHc+jXu/LW918gzl Pn4PyXE2G9tSwrxRy+2BIJX8c6XpzqdNXwgjL2mhIcnMd2jtF8UEDsSJjSWLrSKJ91BR Dgb+TYnpHApzy0LmLTH7C6hhpNf+Bh8D2y1Y8gLD9EnbnlBWApc/P7wZ2UcDTY17VhQV RUPHick36gqCsAaZOeLWkb79QecQzDtpEFPyHQU4U5qqSUBvQM+j8Zjt4q5Etz6kjlOq 47aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763557764; x=1764162564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fC/QdmI3jNw4W9z6Eomd9eORRY4agyuexEsQOqxsWWA=; b=fDsLX0Z4xgFjcz27ykscL8M16ZQNOT0c6FGOX91kgMQMJ0RT/qOAr8B1qYef/kNQxH wsnc0Vqaj/MmLAliHAsiEr1i7A+Kc5FynGcQjIJpAuyXbNRPkjeOB3nvooeMvVDvkjpX rv/9LStF5V0vC09VNLYePlIcMMrCTugoh+bCCbMlWOxPVUhntOsdDrujF+is6lIKsSiX RbUEwS07iXhx/jt6yOjGXyjvKBS2BF+0ZMdbvHHW7MfiZPhnAVfD7UDrZP8iU3T+k17B X4x9TeH6Cr0LXEKUsQgShvi93skudEaYkiDHT2c53l0HPOLpBwJrCgGHlzeVTtzDcX91 a1/Q== X-Forwarded-Encrypted: i=1; AJvYcCWX9DjYXGaQbZzK0/pRvXj2lii1Nx6ltfGRCLOzdHpPfhy64qZlPsaCcMo16GKEWr+Jm3TTV1awd5zLdBw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZ6B6VUqs1oVhMk1emW4v1gnl4IsUy3YpWQRmrBfXtsxONe9Me CQctbwt3cPG9jdPK1syyqyAiktdKcVYFU71JdIcYbvkTk63oia6xGEHO X-Gm-Gg: ASbGncudQXR43JNtCKZoILp465phmGidCgwwwdll6jU1HpFVO6xNXOljTluOr/2n1/8 8dZeLjyuT+7p7zYYpoq8Q3VgKtl4/UK8xVVzQyeiWz5dk+QXJlZbvOOsVXcIz6ZqZD3CiEjrA6E kR/vO0M/IgHdYNtNdmKUrCmYUNL7ZlZ/wKqTI+PfwW8lBVraYscymlLOD0tOTFJexjjpbmxYazR tz2hKTAyqrd0LHma4i3ySbwqqLTjgEzk8aAkxaZLE6WKcjxNF4aYIktS4ClkPA9IJvWZLVKOpSW LHv8RfIvQ69e0VRFh3LWHXiWjD+rwGLF7BLAVoQ/2vWxEpY3tsTuHtTqSaT717xa/RvHFFBWr9v 55YpuHJIh2WZxBo+ePQqo+npW92++NvGQa/YnErunh5m6fHJuOL+p608xtn69zZNrGeSuafFAnQ GnlN7yFfkqeUHsX1S9E1U2a6d183x8hmQaiLCeDy7pyQ0dsw== X-Google-Smtp-Source: AGHT+IGGI52YQzm3rmkb0PCKU2qx/iGnZ4itIPwV6h00f9wx34QXLSkuVhuOMBARGGuXkrKrRWhFng== X-Received: by 2002:a05:6a20:6a1f:b0:35f:fafa:a198 with SMTP id adf61e73a8af0-35ffafaa648mr14108360637.10.1763557763956; Wed, 19 Nov 2025 05:09:23 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.183.150]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9250cd969sm19692422b3a.23.2025.11.19.05.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 05:09:23 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH 8/8] usb: gadget: dummy_hcd: fix miscellaneous coding style warnings Date: Wed, 19 Nov 2025 18:38:40 +0530 Message-ID: <20251119130840.14309-9-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119130840.14309-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch addresses several minor coding style warnings in dummy_hcd.c: - Avoid multiple line dereference (e.g, ep0->maxpacket) - Remove unnecessary parentheses - Remove unnecessary line continuations (\) Signed-off-by: Clint George --- drivers/usb/gadget/udc/dummy_hcd.c | 33 +++++++++++++++--------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 1114dfe61..5b791ce2e 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -1423,7 +1423,7 @@ static int transfer(struct dummy_hcd *dum_hcd, struct= urb *urb, int rescan =3D 0; =20 if (dummy_ep_stream_en(dum_hcd, urb)) { - if ((urb->stream_id !=3D req->req.stream_id)) + if (urb->stream_id !=3D req->req.stream_id) continue; } =20 @@ -2222,8 +2222,7 @@ static int dummy_hub_control( USB_PORT_STAT_HIGH_SPEED; break; case USB_SPEED_LOW: - dum_hcd->dum->gadget.ep0-> - maxpacket =3D 8; + dum_hcd->dum->gadget.ep0->maxpacket =3D 8; dum_hcd->port_status |=3D USB_PORT_STAT_LOW_SPEED; break; @@ -2434,20 +2433,20 @@ static inline ssize_t show_urb(char *buf, size_t si= ze, struct urb *urb) break; } s; }), ep, ep ? (usb_urb_dir_in(urb) ? "in" : "out") : "", - ({ char *s; \ - switch (usb_pipetype(urb->pipe)) { \ - case PIPE_CONTROL: \ - s =3D ""; \ - break; \ - case PIPE_BULK: \ - s =3D "-bulk"; \ - break; \ - case PIPE_INTERRUPT: \ - s =3D "-int"; \ - break; \ - default: \ - s =3D "-iso"; \ - break; \ + ({ char *s; + switch (usb_pipetype(urb->pipe)) { + case PIPE_CONTROL: + s =3D ""; + break; + case PIPE_BULK: + s =3D "-bulk"; + break; + case PIPE_INTERRUPT: + s =3D "-int"; + break; + default: + s =3D "-iso"; + break; } s; }), urb->actual_length, urb->transfer_buffer_length); } --=20 2.43.0