From nobody Tue Dec 2 02:29:10 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB80A35CB98 for ; Wed, 19 Nov 2025 13:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763557750; cv=none; b=g1i7kzBPCTSUnJvXtOdvnh/tGzdSU9h8zgGUiXZlfPYmTNAZnWAvB2pgKa4ILIZDaTLoXk1h2TnYRFLntOeUsWbV+hxdI27e8HLjDFduPej2DfuvlK1IdiQthlQjbsy0QZxaZqd5PJ/HoquaZt/3fSNXPMDP64zWGsSwHgrHvH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763557750; c=relaxed/simple; bh=1n9/lEWo+wlou68RzRk35UwfcIXZXKtYR2L3bmc6SqE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OEoI6hkHJ9EqnwL/fKdIpIooXeJK6MGTAOLHULzjKtDFAA62oyB4H+bdT7vB4u4gqfUjFGNlR9b/sBKtj7tm1s4CKKaRPYuYTvAqZk+XzxKcf3tWB9giKu8P6M7j2bpoCkwdoi5ifQzvCNPryy1Zq6RAr6wlcDujf/GGd7+kHmk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lJDEa5oE; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lJDEa5oE" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7b89c1ce9easo6839219b3a.2 for ; Wed, 19 Nov 2025 05:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763557747; x=1764162547; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+wcMr6TKB52Xs6/sfp3QhKkSt8CaaPtbf58WfUe+edo=; b=lJDEa5oE4yJsH4gtaQLBF84Y9f2+kfMHxcbdaCnNHyWPGdaubMj8IFhi9UId919+13 ezD9pRauXxkPPqIqMHNmYAKP4/CHWWsDDKk0KAeOoy5IVM7SsAHubHTtLAH/YT+NR8DX NHjcN6URyZz1QhL+VxQ1kUlAaWbWUr5RCb7o3NGmrmnABCFkSLqYgNMk3dX+0zWMcZZG nvHji4BIA4oSkVT+qzlTuj5lWfJ6rO/B1A1lB5CXckZkjzKAAAX/6dAF5zQvOnX8N0d9 NXoX3wmZQAK4iJhe7BCfLnOA8Mj9R3infgQ8x651vraondPXlODGakBJ1S3jIavYHI/1 deHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763557747; x=1764162547; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+wcMr6TKB52Xs6/sfp3QhKkSt8CaaPtbf58WfUe+edo=; b=gzav/8nY+Z2E/oRs91lexh/Wgu52A914NJ5p/KnpVFcA8u9Wz/j1doR6FmE5jhFPKi fvRygswLW8nuGqFUpt3XLrXDyS+N9jBQghNlsegxvGxCTvB5bwcX2qoBgJIVyfa/3PIU wGQ6xCjsuWoabI5mf2ostjS/ZrkOTQStsB7kLsXzXMiJ8TZP0DisWJ49PAcBaklT2D5t 8J1DgV2dfdsDb/D8A8HecXNegLhZKemUTFKeZvnHym5okchXO8Y/cRQ3zo7WLXJ+nAGR IOHhDPh9oiLlG3W/G15lqrXEyHXPakEotZY5B/da/fm4AB1owex41h81In2p2KY1lpoO 3I+A== X-Forwarded-Encrypted: i=1; AJvYcCV+7kJvWZNnxea+Nte+RDbSZM5Sz89u2Koya/jHThZU+387tyX4F2qyHGF67n4gFTjTMq8NQoJ/QpQql08=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1sIerX2yHNySoc2F1GupwW4za8sY32ti2Sc2LefLCjsTn4rt1 If2DhVODx1e2DgKNFrXCaiFMxWi/U9e8fMGtIbJdWfhOmouu/pv62kZP X-Gm-Gg: ASbGncvmUG6FD2oAw7D36uKz4gbw9RO6Zzo+z8zvfkHCKEsFz7WjP0M9qzKrCissrYP SjB2o6xCAq5c8qvrMsVjGVf525MTiCvqmyX4Ip5BuhfzK33XnMYb60lyrNFg4cYddTSdwAdNqdU m9ylbhL23C+95Xoo0Aqv8EEoPfiYObC7RxLfv3wlCizYo0H3p9MD7IO7Wc+k9crMXGxpxU3dSxF 1LkqU26VVmPyN5KZP5LJaD4Ctdf5adjjAcKJcTkidtJ0bcrbEoDqLbnDrGTkxMTQb/MiLH4AtdF /5PCaYYvE0OqkQmXCUhyFuuSv3/ogpNVYe47mEUk7EyZLf7zY40Yb4ypVfb+3PzxyKA3ZedhBm4 88PH/aWZf3Jl9RCprRjpllRm4WKDUyyDqP/yINzLixC5RGsSOchX/uISzPdXxuwiO0NqaE5bGC1 72wwVIzkqr7AwwleeoPZBnJOJJ4NdjuVPxTew= X-Google-Smtp-Source: AGHT+IFpgqVfTAaZmkbRivx6m6qi5k0vr4XAZes6wYiI171aYeHdU1uRz1U4vf0NMwRIcqyrSw83RA== X-Received: by 2002:a05:6a00:2444:b0:7b2:1fb0:6da3 with SMTP id d2e1a72fcca58-7ba3c478451mr24723715b3a.24.1763557746861; Wed, 19 Nov 2025 05:09:06 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.183.150]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9250cd969sm19692422b3a.23.2025.11.19.05.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 05:09:06 -0800 (PST) From: Clint George To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, khalid@kernel.org, Clint George Subject: [PATCH 4/8] usb: gadget: dummy_hcd: fix block comments, blank lines and function braces Date: Wed, 19 Nov 2025 18:38:36 +0530 Message-ID: <20251119130840.14309-5-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119130840.14309-1-clintbgeorge@gmail.com> References: <20251119130840.14309-1-clintbgeorge@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch updates dummy_hcd.c to follow the Linux kernel coding style: - Align block comment asterisks properly. - Add blank lines after variable declarations where needed. - Remove unnecessary spaces before semicolons. - Move opening braces of function definitions to the next line. These changes improve readability, maintain consistency, and make the code easier to maintain. Signed-off-by: Clint George --- drivers/usb/gadget/udc/dummy_hcd.c | 49 ++++++++++++++++-------------- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c b/drivers/usb/gadget/udc/du= mmy_hcd.c index 6ad366640..d4b2dcbc4 100644 --- a/drivers/usb/gadget/udc/dummy_hcd.c +++ b/drivers/usb/gadget/udc/dummy_hcd.c @@ -151,11 +151,11 @@ static const struct { EP_INFO("ep2out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), /* - EP_INFO("ep3in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep4out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ + * EP_INFO("ep3in-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), + * EP_INFO("ep4out-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), + */ EP_INFO("ep5in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), EP_INFO("ep6in-bulk", @@ -163,11 +163,11 @@ static const struct { EP_INFO("ep7out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), /* - EP_INFO("ep8in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep9out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ + * EP_INFO("ep8in-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), + * EP_INFO("ep9out-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), + */ EP_INFO("ep10in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), EP_INFO("ep11in-bulk", @@ -175,11 +175,11 @@ static const struct { EP_INFO("ep12out-bulk", USB_EP_CAPS(USB_EP_CAPS_TYPE_BULK, USB_EP_CAPS_DIR_OUT)), /* - EP_INFO("ep13in-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), - EP_INFO("ep14out-iso", - USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), -*/ + * EP_INFO("ep13in-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_IN)), + * EP_INFO("ep14out-iso", + * USB_EP_CAPS(USB_EP_CAPS_TYPE_ISO, USB_EP_CAPS_DIR_OUT)), + */ EP_INFO("ep15in-int", USB_EP_CAPS(USB_EP_CAPS_TYPE_INT, USB_EP_CAPS_DIR_IN)), =20 @@ -314,6 +314,7 @@ static inline struct dummy *ep_to_dummy(struct dummy_ep= *ep) static inline struct dummy_hcd *gadget_to_dummy_hcd(struct usb_gadget *gad= get) { struct dummy *dum =3D container_of(gadget, struct dummy, gadget); + if (dum->gadget.speed =3D=3D USB_SPEED_SUPER) return dum->ss_hcd; else @@ -388,7 +389,7 @@ static void set_link_state_by_speed(struct dummy_hcd *d= um_hcd) } else { /* device is connected and not suspended */ dum_hcd->port_status |=3D (USB_PORT_STAT_CONNECTION | - USB_PORT_STAT_SPEED_5GBPS) ; + USB_PORT_STAT_SPEED_5GBPS); if ((dum_hcd->old_status & USB_PORT_STAT_CONNECTION) =3D=3D 0) dum_hcd->port_status |=3D @@ -613,8 +614,8 @@ static int dummy_enable(struct usb_ep *_ep, _ep->maxpacket =3D max; if (usb_ss_max_streams(_ep->comp_desc)) { if (!usb_endpoint_xfer_bulk(desc)) { - dev_err(udc_dev(dum), "Can't enable stream support on " - "non-bulk ep %s\n", _ep->name); + dev_err(udc_dev(dum), "Can't enable stream support on non-bulk ep %s\n", + _ep->name); return -EINVAL; } ep->stream_en =3D 1; @@ -1042,7 +1043,8 @@ static int dummy_udc_stop(struct usb_gadget *g) #undef is_enabled =20 /* The gadget structure is stored inside the hcd structure and will be - * released along with it. */ + * released along with it. + */ static void init_dummy_udc_hw(struct dummy *dum) { int i; @@ -1264,7 +1266,8 @@ static int dummy_urb_enqueue( struct usb_hcd *hcd, struct urb *urb, gfp_t mem_flags -) { +) +{ struct dummy_hcd *dum_hcd; struct urbp *urbp; unsigned long flags; @@ -1323,7 +1326,8 @@ static int dummy_urb_dequeue(struct usb_hcd *hcd, str= uct urb *urb, int status) int rc; =20 /* giveback happens automatically in timer callback, - * so make sure the callback happens */ + * so make sure the callback happens + */ dum_hcd =3D hcd_to_dummy_hcd(hcd); spin_lock_irqsave(&dum_hcd->dum->lock, flags); =20 @@ -2109,7 +2113,8 @@ static int dummy_hub_control( u16 wIndex, char *buf, u16 wLength -) { +) +{ struct dummy_hcd *dum_hcd; int retval =3D 0; unsigned long flags; --=20 2.43.0