From nobody Tue Dec 2 02:20:17 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEEA424677B for ; Wed, 19 Nov 2025 12:04:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763553866; cv=none; b=ZoLAt5qaq1T4yZRybLDjXEkZxSk3yromlpM3Ka39Y73XjjBGGCFEXLyQn+01YhcyEjV9+OP8uUV02yMURtq+r28DjpRoZwuY2xmhg7wPamrvEVHhSBaSOfAcNX1Ou5VvvLVkPWQhDwp6+uXTdqQqiuo1JYfzUmp4b11SgcPeyRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763553866; c=relaxed/simple; bh=j3tNWfRl9BS7NiuInYLBL8XKsdb1qibHsq5qM8AVQSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z7Wptd2G8hIWZ1zgvxKFdhBPdZygWiYklKb+WlD9U/rnTPp67wakGci5xGf3Ya/f4w92KF3BiOix9PX3iF3MOduOc3AtLiHWOU5/vURPrD12WvWBfGnKP7nvR4woRFizqEq3+GcutxloSEW5uaAt9Pyxbo7CVN6I/hY2ezCprkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=jCNbTy+a; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="jCNbTy+a" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b38693c4dso2994626f8f.3 for ; Wed, 19 Nov 2025 04:04:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1763553863; x=1764158663; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0aY2gFv7ygvSVsf1zlQJN5LYC9AoQYaQyEQzxhKb3Tw=; b=jCNbTy+artW/vGQRzqYrxYp7LxxIEVdyFdlkWHfsR0bwZ1HLH0myiOhdNY2Ofy18aq 2kjTJ1n1vkkoPWtNmcY5BAi6PlREiTVgt6KCvtfewWUUyhfwz39n8kjyOliv0vi1Ei+W N9j5n3sHZmKvmGdomoCdxZe+VbaJOtQ+5rOwxcIdtaehqjtZQPmsUOYNvWPdC42iWaCB gDI69uNs3S05E20J61qoBYtPD8Xtu9nhCfVfd8Almc384C+yOMdgLFZu23f9mZp1xhlY 5wx4ZH6iNKP+otAv3AGFtIi4Bc9DwTslIE3yKp+Gptb7QXf84GYIaQWwSTJMzelb1637 saAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763553863; x=1764158663; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0aY2gFv7ygvSVsf1zlQJN5LYC9AoQYaQyEQzxhKb3Tw=; b=eKd/5Ru6fwciQXmqiq0kRt/TbA8QhXJssq2n/qB07lm4cDg4yUN3jqdR8tKRIE3vP9 lEbwNV7UrUiyN9lynPiv/B1Hr8zywUoJxHiMWMk1h6BzGAYzTaaEyz2WyQ/ZLqbmlCWV bKAuuGpnpZqwmEuTmd+NywT11ginm5bxySLQv0PFmFHVVAdLbdtwN0GkMPGgWDoexnCl LCAJI9vSOE0M+KSqwTiyic4f2FtBQTHQVMEfxiucQZ2Z5uYEASZCByFGqEuVnxvaxrJW D7iw53lF8Lgedzb5tgggoqDgpts6PE4ZsrZ/CFtwKnMDc5Ds0p+hzr20R/GfpJLbMCk9 ZV6Q== X-Forwarded-Encrypted: i=1; AJvYcCV8yolxfGrbNodaLitGR/JTSco/YCvI3JIc9ayuRvGb+y1wjroZ7bqIt/DITbkQTQKGu+RZ4Ftghi7TzbU=@vger.kernel.org X-Gm-Message-State: AOJu0YxhqKwFqI4omVS+qoK8XnqOWUDNtQnZKN7bHwfRASnAj+vknqQS fTsmYUed15GHAy+Sn2tfMamn/R9oWGv6UMNwsnUYmbrACLGbNk0B1vcGo8YqeJxxcik= X-Gm-Gg: ASbGncu12oZyFcIb3CX1gygFa1zUsW9u3Jpnv6DZr9bnTaYV3TvfoiEZKNX1SzT5rdY F9mZLIlqhxDT9XoFyOBUHvr/B9LFv50kMmfY98BXtfghISm33/4/a45r0Ghf6o39yAGCHtTeJo7 ZZNypl97Sk5b2qXuAuTcdkXqsHJBnYs8MYO7vpPUgjvL9MOwsBPuaE2GtQ0RtKR0P4Rhxt2V4fv GtxfuO4U9TrRdqmt8TBwwq40QeQXlSVEAL2H0SmJCkIFT3iHJIGOhFqBXBtVpISgZphzfI1296T 3C4e0C0hzGxAi0qDWT03zlJQ0xK4p3LXHMpZvju5U5ia7dK5C/leRMbp+oWTBxUuMuGUY6bDmBL Q5hJ+Sc+QL4ZgY+/ZRjjt+b5Oq9WRv1LE8d77QRGQ//8mw/6H5PmR5FeqgzmPg2A/IhN8rQbduU ro9DZTWE1GgwFZRG/+PlzIEC6SK0cuKGoTxzm2XFcx2tEB9AP5EfA= X-Google-Smtp-Source: AGHT+IG5kDWW9dEEuHX258Qk4WTXIkyTFBNiIBUZhWRXkgD1Aeggk6N6ts0khJchzedGqhwdb2H5Vw== X-Received: by 2002:a05:6000:1a8e:b0:42b:3e0a:64b8 with SMTP id ffacd0b85a97d-42b593505bamr18557552f8f.24.1763553862994; Wed, 19 Nov 2025 04:04:22 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f2084dsm38431132f8f.42.2025.11.19.04.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 04:04:22 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: yoshihiro.shimoda.uh@renesas.com, vkoul@kernel.org, kishon@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v2 1/2] phy: renesas: rcar-gen3-usb2: Move phy_data->init_bus check Date: Wed, 19 Nov 2025 14:04:17 +0200 Message-ID: <20251119120418.686224-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> References: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Move the check of phy_data->init_bus from rcar_gen3_phy_usb2_init_bus() to rcar_gen3_phy_usb2_probe() to avoid having it duplicated in both the probe path and the upcoming resume code. This is a preparatory patch. Signed-off-by: Claudiu Beznea Reviewed-by: Neil Armstrong --- Changes in v2: - none; this patch is new drivers/phy/renesas/phy-rcar-gen3-usb2.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas= /phy-rcar-gen3-usb2.c index a38ead7c8055..b9d5bb52e02c 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -782,6 +782,9 @@ static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3= _chan *channel) int ret; u32 val; =20 + if (!channel->phy_data->init_bus) + return 0; + rstc =3D devm_reset_control_array_get_shared(dev); if (IS_ERR(rstc)) return PTR_ERR(rstc); @@ -861,11 +864,9 @@ static int rcar_gen3_phy_usb2_probe(struct platform_de= vice *pdev) platform_set_drvdata(pdev, channel); channel->dev =3D dev; =20 - if (channel->phy_data->init_bus) { - ret =3D rcar_gen3_phy_usb2_init_bus(channel); - if (ret) - goto error; - } + ret =3D rcar_gen3_phy_usb2_init_bus(channel); + if (ret) + goto error; =20 spin_lock_init(&channel->lock); for (i =3D 0; i < NUM_OF_PHYS; i++) { --=20 2.43.0 From nobody Tue Dec 2 02:20:17 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1FC3559F5 for ; Wed, 19 Nov 2025 12:04:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763553867; cv=none; b=hxAdhJYaxK3inXL4uf743Vo3IuR+uhRm95DlXLKgeIh/D66j7w0WRPXgFSso7G+4zZPD+t9Z4k6xksdPV2n77QXYUtKirUodEymgoj2RD67iLTQ2s+Lm7wbd+Niww/g+WGMJ+vPbv+vWJ0w4w5roedXpgbyzEK4XFrDWkcZGB8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763553867; c=relaxed/simple; bh=ScX7aNG3Yn6BF5Fit9YEuAm9dWTD7Qc+POSQ7oChQKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HkYtw7xMonZBvmT4gZuDt0lWE+rV/vxRKAQgL/P0pLFQMzM+AGQ4O8xlWd+MZugxNKvKWUUyX+pC9xj3tOEXyKpl3pu/KyUiG0mGm8Mcmi0pmiNrPtsZ1vsQVj4mIvcfRqUmHaxCulLk0X0XmqL6R1dLVD+zCFlfC3K+hU/b2I4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=bCGqh6G7; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="bCGqh6G7" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779cc419b2so45268235e9.3 for ; Wed, 19 Nov 2025 04:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1763553864; x=1764158664; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7kwbvw6xT/0cK8yOWBaAQdvYuRJNVtp1fhMHHc54Yto=; b=bCGqh6G7jFwUVEg4IJtAgHkD4cSK6pZ2zImN6F20DkZ9LUMDcB10nUqlF9abGVVwVD APXiPqKSMVyi+636Rl0mTa5NiTWgwu7qblyyLG3EIgZcRKTziGQjmS8nzSx8s/trQIHp doZEa+kcT0yKcS3ANhp8cHzZWKNZ9WmDhH80nZZ3NBp91efGxrs8PWNFL8uRdoqrdyUf nOO/phxIY/ESGsIvuGdbTQ7+ixoctZWDearKyFEfe1LujQbIH+YnZq2Uar3SmlpPyvCg RPy9kc5oXIxOr8SHXW/qvZe5MSr2X2OgACtvO+hgOfQyTiPjVGCUoHctuTbLUCVa7iVE cJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763553864; x=1764158664; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7kwbvw6xT/0cK8yOWBaAQdvYuRJNVtp1fhMHHc54Yto=; b=XIibKjZcOSALH0DVOy9e9z9vHHomLJ0Ys0hff15KyhJwrQLqqLM4tzyFwqzPZpGsSz 9vqNb0/g3OWjp3wpRB0pHmxwq6ZYdtIYNnOuqc73m/Lgem3sq8NW9D6BA7ufPe71jC3Q IIgeNuqfk00AU3l/o5Cm8cU0aaF0ONFfHDHTJyYFTQKk5GUmVznNGeo+XtTqVN3rHMeO G9VXE2zqrRGMVtif8+xZEDwSHD2qa+MslWRo/6774jSFE1fVfYjodXuhY2HXM4yGFU3H wk3A2CLtWTqJmYIvvqxqO/JQDlyQShpapNK2tN0r7ODV2ZZuyy9PoRiPBSJi/Y3lzCOI e83A== X-Forwarded-Encrypted: i=1; AJvYcCXambM8S4dmbBu9DY9t717g6u3qWtw7QEW8OZ4O3UdkQizWDwtqBKxGqKa2QN6W8AIiIBpo842Vzx+nQJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YwC5LSSYOB3zC72S83b9ihM8FqzNVf2DfnmDHifL28Zg34FlHgE YyVyf+lwF33DLow8t35qVu5XbYhWwbXDHgO8Pw8X8QkYiEz6w/MD63QTRtnvqmfmGeA= X-Gm-Gg: ASbGncuK1lLyeaGnw4psL03nNFs1GGjgEyxsl89d3wEaAUISiG8NYSupYTVDjITsjHq JNwTVcJaH48PWy9HmLNuon3Km5/L/bb+UNzSfDRo4/uG/wLfV+fb+SeYLqeERY9dcjFUmucWrkp MzgIXIgGAU6Eb+fEQl+PApger8WoR/E6aymHuT5tnre6tvfb0BfpnvyYGuCaEbYigNFz1z6bGr9 P5xWmIPrTcRMRvEzdaYa8hGUN6522tjSohB7N7Tv+fu4bHSrVKwtaYpc87sRegj+Th6ofz0V9VY bRIzvL2CJvY+9uc85vufxFir8JrV78yGUQ/XX3VYBOMnlTdIG/zCeAUzox5o0xw2pJ4MjYF5Phs JZBusvBoi8wPH3GlvYDb2Y8CYOf3M3DIcByvnawWu336LfS53fervh/WRI1xYgZqCFGyIULQBp4 8ViTBdK6fE3DtWc31KHWE5SWyCJZ8nONx3A2df3iAXEUMaeoswxKyra3HXzqonVg== X-Google-Smtp-Source: AGHT+IEmXDrq9U/gnjMPnQaZ2zqrfwsQlLLhP0qnBZZKkxXXUtOmxvmAkh4F6KqAQGo+GJlfdl6iXA== X-Received: by 2002:a05:600c:8b4b:b0:477:63a4:88fe with SMTP id 5b1f17b1804b1-4778fe50df1mr184268975e9.2.1763553864413; Wed, 19 Nov 2025 04:04:24 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f2084dsm38431132f8f.42.2025.11.19.04.04.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 04:04:23 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: yoshihiro.shimoda.uh@renesas.com, vkoul@kernel.org, kishon@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, p.zabel@pengutronix.de Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Claudiu Beznea Subject: [PATCH v2 2/2] phy: renesas: rcar-gen3-usb2: Add suspend/resume support Date: Wed, 19 Nov 2025 14:04:18 +0200 Message-ID: <20251119120418.686224-3-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> References: <20251119120418.686224-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The Renesas RZ/G3S supports a power saving mode where power to most of the SoC components is turned off. The USB PHY is among these components. Because of this the settings applied in driver probe need to be executed also on resume path. On suspend path only reset signal need to be asserted. Add suspend/resume support. Signed-off-by: Claudiu Beznea Reviewed-by: Neil Armstrong --- Changes in v2: - dropped the changes that were integrated in patch 1/2 drivers/phy/renesas/phy-rcar-gen3-usb2.c | 57 +++++++++++++++++------- 1 file changed, 42 insertions(+), 15 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c b/drivers/phy/renesas= /phy-rcar-gen3-usb2.c index b9d5bb52e02c..3c063e4dea41 100644 --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c @@ -132,6 +132,7 @@ struct rcar_gen3_chan { struct device *dev; /* platform_device's device */ const struct rcar_gen3_phy_drv_data *phy_data; struct extcon_dev *extcon; + struct reset_control *rstc; struct rcar_gen3_phy rphys[NUM_OF_PHYS]; struct regulator *vbus; struct work_struct work; @@ -778,38 +779,24 @@ static void rcar_gen3_reset_assert(void *data) static int rcar_gen3_phy_usb2_init_bus(struct rcar_gen3_chan *channel) { struct device *dev =3D channel->dev; - struct reset_control *rstc; int ret; u32 val; =20 if (!channel->phy_data->init_bus) return 0; =20 - rstc =3D devm_reset_control_array_get_shared(dev); - if (IS_ERR(rstc)) - return PTR_ERR(rstc); - ret =3D pm_runtime_resume_and_get(dev); if (ret) return ret; =20 - ret =3D reset_control_deassert(rstc); - if (ret) - goto rpm_put; - - ret =3D devm_add_action_or_reset(dev, rcar_gen3_reset_assert, rstc); - if (ret) - goto rpm_put; - val =3D readl(channel->base + USB2_AHB_BUS_CTR); val &=3D ~USB2_AHB_BUS_CTR_MBL_MASK; val |=3D USB2_AHB_BUS_CTR_MBL_INCR4; writel(val, channel->base + USB2_AHB_BUS_CTR); =20 -rpm_put: pm_runtime_put(dev); =20 - return ret; + return 0; } =20 static int rcar_gen3_phy_usb2_probe(struct platform_device *pdev) @@ -849,6 +836,18 @@ static int rcar_gen3_phy_usb2_probe(struct platform_de= vice *pdev) } } =20 + channel->rstc =3D devm_reset_control_array_get_optional_shared(dev); + if (IS_ERR(channel->rstc)) + return PTR_ERR(channel->rstc); + + ret =3D reset_control_deassert(channel->rstc); + if (ret) + return ret; + + ret =3D devm_add_action_or_reset(dev, rcar_gen3_reset_assert, channel->rs= tc); + if (ret) + return ret; + /* * devm_phy_create() will call pm_runtime_enable(&phy->dev); * And then, phy-core will manage runtime pm for this device. @@ -937,10 +936,38 @@ static void rcar_gen3_phy_usb2_remove(struct platform= _device *pdev) pm_runtime_disable(&pdev->dev); }; =20 +static int rcar_gen3_phy_usb2_suspend(struct device *dev) +{ + struct rcar_gen3_chan *channel =3D dev_get_drvdata(dev); + + return reset_control_assert(channel->rstc); +} + +static int rcar_gen3_phy_usb2_resume(struct device *dev) +{ + struct rcar_gen3_chan *channel =3D dev_get_drvdata(dev); + int ret; + + ret =3D reset_control_deassert(channel->rstc); + if (ret) + return ret; + + ret =3D rcar_gen3_phy_usb2_init_bus(channel); + if (ret) + reset_control_assert(channel->rstc); + + return ret; +} + +static DEFINE_SIMPLE_DEV_PM_OPS(rcar_gen3_phy_usb2_pm_ops, + rcar_gen3_phy_usb2_suspend, + rcar_gen3_phy_usb2_resume); + static struct platform_driver rcar_gen3_phy_usb2_driver =3D { .driver =3D { .name =3D "phy_rcar_gen3_usb2", .of_match_table =3D rcar_gen3_phy_usb2_match_table, + .pm =3D pm_ptr(&rcar_gen3_phy_usb2_pm_ops), }, .probe =3D rcar_gen3_phy_usb2_probe, .remove =3D rcar_gen3_phy_usb2_remove, --=20 2.43.0