From nobody Tue Dec 2 02:29:50 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 616D2337115 for ; Wed, 19 Nov 2025 09:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763543995; cv=none; b=lADemaT99yjbvkv1OgTWkA490XO60h+nf3xVxPJ+WZ67UqVvQM1K8xwOELdsl+MCXHr+zB4DmWytUyKzqrf51G1gbgwQI86MDEMr2pqWLOh/sK/0Y9zOT/Gdfvq4vZ56u04AHANTuN0eXyy3ZFMVFS7K8UkArfuG5bvkKhbLevY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763543995; c=relaxed/simple; bh=+twEGSWVkU24dJT6HixJJ1t7rYB4ynDjp6p5U/hZqH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UEnCojxm0ed0XnH7R96uhQW0NwI8BCvA+iUWIbCopmBVp+OfSzw9Hy2YeIBnzCaFzL49W/RnQ8ATieAU61oQDr0SgCQeSm5iQrywZndRpVHm7tA0QlssFaerZDPxxGDCjhtpCx8FA99gbEm2D5WypjRfchsdkeFcSiYydgXbRPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U0KNHSTu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U0KNHSTu" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF17DC2BCB7; Wed, 19 Nov 2025 09:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763543995; bh=+twEGSWVkU24dJT6HixJJ1t7rYB4ynDjp6p5U/hZqH4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U0KNHSTuMIHApax5my+qC6fTC2BId+urIca4CKMs2dSw/xe2/sbUm0Yg65gkJElUM 3nj8Yytvndf8MuzgrbFUMzzBREZZFW1CGGRKA6F+2TWuDpfotq1na2PqVWitjvP/wr wyCwv6EV7HsA9fG6oD18dRV/+P3NzG1oJf2Q+pnWsEiQ1wjT8vEc9SstrwsmEiHBB9 6MZ21h+pZ8ZP3WhykkBoxn4ruxijaIL3921bu3owuDJtT28KmAMW5VxrIfqML04p4c 1RAO2xNmJTuso75dEpdhi0FYHuJNdgLzakq4FeeFP3FinOnQ5GL1RYXyi3Qh0QvWl3 SEujPuIYjp+Rg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 1/6] char/mwave: remove dead code Date: Wed, 19 Nov 2025 10:19:44 +0100 Message-ID: <20251119091949.825958-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251119091949.825958-1-jirislaby@kernel.org> References: <20251119091949.825958-1-jirislaby@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mwave, there is a lot of commented code for a long time. Drop it. Signed-off-by: Jiri Slaby (SUSE) --- drivers/char/mwave/3780i.c | 29 ---------------- drivers/char/mwave/mwavedd.c | 67 ------------------------------------ drivers/char/mwave/smapi.c | 22 ------------ 3 files changed, 118 deletions(-) diff --git a/drivers/char/mwave/3780i.c b/drivers/char/mwave/3780i.c index 4a8937f80570..321dbd03d007 100644 --- a/drivers/char/mwave/3780i.c +++ b/drivers/char/mwave/3780i.c @@ -140,35 +140,6 @@ static void dsp3780I_WriteGenCfg(unsigned short usDspB= aseIO, unsigned uIndex, =20 } =20 -#if 0 -unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO, - unsigned uIndex) -{ - DSP_ISA_SLAVE_CONTROL rSlaveControl; - DSP_ISA_SLAVE_CONTROL rSlaveControl_Save; - unsigned char ucValue; - - - PRINTK_3(TRACE_3780I, - "3780i::dsp3780i_ReadGenCfg entry usDspBaseIO %x uIndex %x\n", - usDspBaseIO, uIndex); - - MKBYTE(rSlaveControl) =3D InByteDsp(DSP_IsaSlaveControl); - rSlaveControl_Save =3D rSlaveControl; - rSlaveControl.ConfigMode =3D true; - OutByteDsp(DSP_IsaSlaveControl, MKBYTE(rSlaveControl)); - OutByteDsp(DSP_ConfigAddress, (unsigned char) uIndex); - ucValue =3D InByteDsp(DSP_ConfigData); - OutByteDsp(DSP_IsaSlaveControl, MKBYTE(rSlaveControl_Save)); - - PRINTK_2(TRACE_3780I, - "3780i::dsp3780i_ReadGenCfg exit ucValue %x\n", ucValue); - - - return ucValue; -} -#endif /* 0 */ - int dsp3780I_EnableDSP(DSP_3780I_CONFIG_SETTINGS * pSettings, unsigned short *pIrqMap, unsigned short *pDmaMap) diff --git a/drivers/char/mwave/mwavedd.c b/drivers/char/mwave/mwavedd.c index 11272d605ecd..86e33c28beac 100644 --- a/drivers/char/mwave/mwavedd.c +++ b/drivers/char/mwave/mwavedd.c @@ -492,42 +492,6 @@ static const struct file_operations mwave_fops =3D { =20 static struct miscdevice mwave_misc_dev =3D { MWAVE_MINOR, "mwave", &mwave= _fops }; =20 -#if 0 /* totally b0rked */ -/* - * sysfs support - */ - -struct device mwave_device; - -/* Prevent code redundancy, create a macro for mwave_show_* functions. */ -#define mwave_show_function(attr_name, format_string, field) \ -static ssize_t mwave_show_##attr_name(struct device *dev, struct device_at= tribute *attr, char *buf) \ -{ \ - DSP_3780I_CONFIG_SETTINGS *pSettings =3D \ - &mwave_s_mdd.rBDData.rDspSettings; \ - return sprintf(buf, format_string, pSettings->field); \ -} - -/* All of our attributes are read attributes. */ -#define mwave_dev_rd_attr(attr_name, format_string, field) \ - mwave_show_function(attr_name, format_string, field) \ -static DEVICE_ATTR(attr_name, S_IRUGO, mwave_show_##attr_name, NULL) - -mwave_dev_rd_attr (3780i_dma, "%i\n", usDspDma); -mwave_dev_rd_attr (3780i_irq, "%i\n", usDspIrq); -mwave_dev_rd_attr (3780i_io, "%#.4x\n", usDspBaseIO); -mwave_dev_rd_attr (uart_irq, "%i\n", usUartIrq); -mwave_dev_rd_attr (uart_io, "%#.4x\n", usUartBaseIO); - -static struct device_attribute * const mwave_dev_attrs[] =3D { - &dev_attr_3780i_dma, - &dev_attr_3780i_irq, - &dev_attr_3780i_io, - &dev_attr_uart_irq, - &dev_attr_uart_io, -}; -#endif - /* * mwave_init is called on module load * @@ -540,17 +504,6 @@ static void mwave_exit(void) =20 PRINTK_1(TRACE_MWAVE, "mwavedd::mwave_exit entry\n"); =20 -#if 0 - for (i =3D 0; i < pDrvData->nr_registered_attrs; i++) - device_remove_file(&mwave_device, mwave_dev_attrs[i]); - pDrvData->nr_registered_attrs =3D 0; - - if (pDrvData->device_registered) { - device_unregister(&mwave_device); - pDrvData->device_registered =3D false; - } -#endif - if ( pDrvData->sLine >=3D 0 ) { serial8250_unregister_port(pDrvData->sLine); } @@ -667,26 +620,6 @@ static int __init mwave_init(void) } /* uart is registered */ =20 -#if 0 - /* sysfs */ - memset(&mwave_device, 0, sizeof (struct device)); - dev_set_name(&mwave_device, "mwave"); - - if (device_register(&mwave_device)) - goto cleanup_error; - pDrvData->device_registered =3D true; - for (i =3D 0; i < ARRAY_SIZE(mwave_dev_attrs); i++) { - if(device_create_file(&mwave_device, mwave_dev_attrs[i])) { - PRINTK_ERROR(KERN_ERR_MWAVE - "mwavedd:mwave_init: Error:" - " Failed to create sysfs file %s\n", - mwave_dev_attrs[i]->attr.name); - goto cleanup_error; - } - pDrvData->nr_registered_attrs++; - } -#endif - /* SUCCESS! */ return 0; =20 diff --git a/drivers/char/mwave/smapi.c b/drivers/char/mwave/smapi.c index f8d79d393b69..f586752ec463 100644 --- a/drivers/char/mwave/smapi.c +++ b/drivers/char/mwave/smapi.c @@ -513,28 +513,6 @@ int smapi_set_DSP_power_state(bool bOn) return bRC; } =20 -#if 0 -static int SmapiQuerySystemID(void) -{ - int bRC =3D -EIO; - unsigned short usAX =3D 0xffff, usBX =3D 0xffff, usCX =3D 0xffff, - usDX =3D 0xffff, usDI =3D 0xffff, usSI =3D 0xffff; - - printk("smapi::SmapiQUerySystemID entry\n"); - bRC =3D smapi_request(0x0000, 0, 0, 0, - &usAX, &usBX, &usCX, &usDX, &usDI, &usSI); - - if (bRC =3D=3D 0) { - printk("AX=3D%x, BX=3D%x, CX=3D%x, DX=3D%x, DI=3D%x, SI=3D%x\n", - usAX, usBX, usCX, usDX, usDI, usSI); - } else { - printk("smapi::SmapiQuerySystemID smapi_request error\n"); - } - - return bRC; -} -#endif /* 0 */ - int smapi_init(void) { int retval =3D -EIO; --=20 2.51.1