From nobody Tue Dec 2 02:19:23 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F5CC32E142 for ; Wed, 19 Nov 2025 08:59:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763542769; cv=none; b=T8vaZ3Q+Kn+BRY+42oCEHIIH5MShwbHO3ejT5wBxdFIojAGeIubp/jFTe2xLIr4rpRYsjjJkaz5jVZItWq4pLNAwjLYdUpYzlExEdGAY7mXZ8EN41vyo9IieLaMNpIX+r38/XdvaSjYLdiWiKMmJawcxiU734Wukc/gfd5HYmrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763542769; c=relaxed/simple; bh=RKLxG41FnFXQIfi8o1s4opveJYqoL6GYWWf8XO/U/7s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=toOmaG8NrI6cwIeVVjXN/tMa5utBJ5cSJJG4BH/lV1/e8x+jujST43BBSTDhljNYpAgRZRRamuL/ydZrzt6z4FzSELFK52r7qOezS74VFvqFbNBpJwpwNcAk9xW4O48HnLl+2oVlfah6jIP+MV+513YmXk7406T8r8BrDCUvxEg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aerlync.com; spf=pass smtp.mailfrom=aerlync.com; dkim=fail (0-bit key) header.d=aerlync.com header.i=@aerlync.com header.b=OuH49swb reason="key not found in DNS"; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=aerlync.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aerlync.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=aerlync.com header.i=@aerlync.com header.b="OuH49swb" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3436a97f092so8231832a91.3 for ; Wed, 19 Nov 2025 00:59:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aerlync.com; s=google; t=1763542766; x=1764147566; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=mox5WyuD4uLfefjWS7CS2rqtyuV+iYJhhA9qwxlBVzI=; b=OuH49swbAMXq2ckyL+ZeZGIpb+DN4fij4DBMjeL2j6IXHXJkspMJO0BmGEm79uMF9y vJBp8O/Y1EWE72V1E8jYcWPl4UJeAoTiPyxsWEnEeVwFvRvxhwV655B5l6DiDuJRnjYn mP1pITAvfDf9joV/gSBQJl1RNFAGCksVzEaNPDNUvgXvF2mQVXun/rRDmnWCuYQ22O8H /o3IZUXjkYAMDTUF6X4tSzC4RnV095pk3fMxt2K0652XL9RruaaVpE1NqQ8sLiOIhto2 rCY5/BxE7V9ErNwPSgnTwioVkuxxEeDAG/6IDucjPO8A0uhdQyFY4n80YW8pqf/jAlmz 1ZhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763542766; x=1764147566; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mox5WyuD4uLfefjWS7CS2rqtyuV+iYJhhA9qwxlBVzI=; b=KFe0gr2ijILp5VuvS7gdkkWLNJw7HC+hK/F/x5JHD4oubP296nQTZ9e13ZpyyXyJD8 R+F8mgOjJrGo5eNFqGvUyaZnOPMZFD4J7dyyMftrmhAhSCxKg8E8D/lu+8aWlPJs085j COjDf2hwTyd2qgn5G8sIm//K4ouSDj+w5w8HoJaM3LUR2xkMyrUSexU86Lh/4HTWHv8l KNsLB9j1M8CB8pMYnGVwyc4UDHFBREiAuMBeKqMjKSjYQJrRpAxtv7LBeJunc2/lVUeg tkFkYdbAXeXYzynYgdp1flWHWlyAhJIN9q9qT6pKFkNLRX7EonWUstDQocx69152+LqP yhXA== X-Forwarded-Encrypted: i=1; AJvYcCUZ6MYSAfIhNQkBmGy/G5MEXeGEhX97RXTGerlm6TWG8L1YrHLoVySVGj3AzRruCHvt3H+AZPAnMPm/E+I=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1dh00tM23CfGzPbb7UHTcKM7HtDNpX8SRvcH2eAcJq8DrkmrK GTkFGoi6hH8IqdgPYuPIoEg/y2RjyD5f+6sOopj+uiSgcRJZlynyCImnmdJMXqZG/OI= X-Gm-Gg: ASbGncteX7WdrKXsOm6EzjU8sqhlRgt9cQWgjpKsflCHGCTPpLNYIVwP8h/JYe0B9TV lNLLSy13GiV1+/4OpeRqWbVdLIjKFMYoL8k+jEXren76wsiM+uFrW79OE6vO2uFOOyvBBvESPsK W2yCsLTw48LliiUk3BOVx4aK7rv5cWwcFCBWtel5pPpLwo2a400m6Y0DdccPO84lnaQnvk7gcpC yfuOptf9O05/eeAJrWGQMiHzP6loevN7SFd2XVfUSJT/eHXWf1LEzgvnHplgEBihfhMmu1f7spr AaG3VzFEDyP0ukYw0na1wDZ7QSHVDn1MdsFQtAvN9sryeV/c1+Q+SDLyEYO+Klgo7rC3TMDvqGT CDX7dyu6f7r0V8p0UJZG8jxYL5ObfSSh4uwosLOnuAgrz/IGakKE9YYfCYfeBiUDrI7UbT/xmW6 BibRN2OoLQHNcqj17NKKrwGMwnu0BmMdKs/mbuIMe1KKdgBmqp0tWq X-Google-Smtp-Source: AGHT+IHpf/cvIVYj+8zZr8hTZ+FrOoI5zW7ZMpL53W7VWVFV14N/Wk+FfGc2+kOiUFyMKQjkc5ih2Q== X-Received: by 2002:a17:90b:4c4c:b0:341:133:e13d with SMTP id 98e67ed59e1d1-343f9d91d64mr19751848a91.5.1763542765852; Wed, 19 Nov 2025 00:59:25 -0800 (PST) Received: from localhost.localdomain ([103.82.77.153]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2348afsm197918535ad.3.2025.11.19.00.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 00:59:25 -0800 (PST) From: Sayooj K Karun To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chas Williams <3chas3@gmail.com> Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sayooj K Karun Subject: [PATCH] net: atm: fix incorrect cleanup function call in error path Date: Wed, 19 Nov 2025 14:27:47 +0530 Message-ID: <20251119085747.67139-1-sayooj@aerlync.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In atm_init(), if atmsvc_init() fails, the code jumps to out_atmpvc_exit label which incorrectly calls atmsvc_exit() instead of atmpvc_exit(). This results in calling the wrong cleanup function and failing to properly clean up atmpvc_init(). Fix this by calling atmpvc_exit() in the out_atmpvc_exit error path. Signed-off-by: Sayooj K Karun --- net/atm/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/atm/common.c b/net/atm/common.c index 881c7f259..c4edc1111 100644 --- a/net/atm/common.c +++ b/net/atm/common.c @@ -881,7 +881,7 @@ static int __init atm_init(void) out_atmsvc_exit: atmsvc_exit(); out_atmpvc_exit: - atmsvc_exit(); + atmpvc_exit(); out_unregister_vcc_proto: proto_unregister(&vcc_proto); goto out; --=20 2.43.0