From nobody Tue Dec 2 02:33:06 2025 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55BAF22D780 for ; Wed, 19 Nov 2025 06:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763533639; cv=none; b=Ace5lY/5Hjw7t1jJ1qPm2yeyfBMSgXB5GxBQuaAgjiADZKalhVL5j7tlxGEEl7bbH+MMrRRRAIgKhP88/aA+dhW4gkrDbNPSYRFbtPUz3VOx+r6aliSEd0GpUwJh72q5yrlxY25f3C5B19/iVJcAzSSW6HIhQglk18frHaEJ+bo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763533639; c=relaxed/simple; bh=few/recAdOcfW53vblM7KJ+tt/5ju8Co/TBjXPZG9dU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Phf6D4s02Lwy91BW8B8K1y40u8vWYkla/glFYdyRRZChR6jiNXPyIIlv5oeNCfto3nYys1dxES3aQA0SuwFLOd8+AKEO+B112ROA5XCi5x0Am91jDFT7S18G0g+0Ej7cr46LNcOpWAS/HjeM8tRxtyjRTD/lap2Vz9bTTK7GszU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FkSwesVk; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FkSwesVk" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3437c093ef5so6525776a91.0 for ; Tue, 18 Nov 2025 22:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763533636; x=1764138436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kSik/hqJY6uQJXt0ntFdhTi0p+xzQjXt/XbyHMNi+hw=; b=FkSwesVkz/LJA1wOeErMTHaC9T+x2rk0SIWmFPH7BPdXXNazio6zYoirqoF/Qf8aWY dpVVkMEnEaIECTn2Fc7MrcnNHyNGsk6JjJLm2korNdW7lLFReIP77q00y/q5OAQenX3+ 4i0ZSd/bdt2vRbXZgngujJi5P9nZUZgBYRNhc7YJTZzRPomw+8WDRa1rUGuKXz+VEWmt u9YJGPbgeoEIoxrGevaFQntfoOiBC9A7cfPEkO+qP11wQs/9xhsOyl/MGwGDOzw5PUvR s5SLmVp6sLkBBVfjScICa1G93C3TEQ1W6MoUxu3k3XRl1SXVVXoCA0dvfQ2FsumCjArH KHoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763533636; x=1764138436; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kSik/hqJY6uQJXt0ntFdhTi0p+xzQjXt/XbyHMNi+hw=; b=WTRmQgRJ8E8ITUl1KCCQvSFnrJ/tJDYTzhYYNh6Hk5J5i+UWFErCJxEv3xmka42LVR M6FKdm5CEycLAYFxmsNZcXkBxAedfA2ct3pM79vuSMUnYMJ/FafWyYdUb/1Uc+5gvwoC m3fAenqDBrCyrFTqgDh2UIRlY+UoRjrmv4R7CcbfuJVVmDgYzYDgGXKIR2SZW/oLa6CG 2XbOTf2lqXNM9Mjm4y+Jc6sPctqs9YLvuI/3ww5b2yMr8lbDxmUbq+etxL4Hh52z7qXY qGkhNyWOoqexX5S8cziM48l7m5fQQcC6m679e/LL3ysdmlV3W24L22qF0g1/e9+cu8B1 lrKQ== X-Forwarded-Encrypted: i=1; AJvYcCVeaAa7YcVkYLEU0Autf4YoPW+HOJvDc4N1hWs77fr/1TkTSIZApUwINbLj5CiT6FHkn2tl9w0PSF8BMCk=@vger.kernel.org X-Gm-Message-State: AOJu0YylZ4rUtLq56ZRVF1+zvePUCy6JxrTgk6Otq3Fs1VBGUsxq4nRf g91uQLs01LRhHT9ucwG1NqcTY0E2XZ48m6BEHwhJiKY2BBAmJcnDgwGPFK2o8hdU X-Gm-Gg: ASbGncsxlmTXSeLUB3i2yZ0+7QLxuzFaqNmTS3lRwtC7hi8fv4o0ayCSVdBHe/kDFnG c02WHJg65dUPsXcRJXJVTWI1IbRgv9sdm1eP1dJ5KUYhpIq/XOvUTO37SVpjRcs24LXpWE3j+yn 1I+woTwNxa30b8tiEdOPMhRbxIhvnc7VHgA8JoczNKD0HMJG0gzLWf04F54DJE0SVznjM13k5PC oVYql8cqyHKLzS4U4YcJi5SEYrEbcnTwW98OQNuafHPEPLWo2Q9IBu397lCbts6Kv7Ig2pt/qyG 23rba1gHn1cAN4SvQnsLr6NBuYPhQV7tPlsCIQcS8sqrg2k0BKSi42IOSrdn3LjEDyEqiioY4z0 kY8W4WRsE8ZdGbsOvqf29wpbWV81W09fl9wPzskkNoNlnTVkWzxmWTnMZeQIQvNxYzTP7+FLuBc dIhPZC4wn/vp2mwA3Nc1ypV2RmCuYeWBGDU+QpuWhrNAYOA5uqsvRmEhgt8LKhZ3hzdX5+ojii0 bsZgTnCGREgbDlHPS+IJsJIl/RpZtErqdtohwIYpA== X-Google-Smtp-Source: AGHT+IHu9kCY2nVl01ucwCzHU+ppI6/17K10GvjoyFkmg42G4zI90nikifbreC3DcgzrOwW8FLfpGA== X-Received: by 2002:a17:90b:17cc:b0:340:d511:e167 with SMTP id 98e67ed59e1d1-343f99c41d7mr20731166a91.0.1763533636292; Tue, 18 Nov 2025 22:27:16 -0800 (PST) Received: from main.. (c-76-146-85-33.hsd1.wa.comcast.net. [76.146.85.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-345b03971fcsm2322705a91.5.2025.11.18.22.27.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 22:27:15 -0800 (PST) From: Artur Stupa To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Artur Stupa Subject: [PATCH] staging: rtl8723bs: core: fix block comment style issues Date: Tue, 18 Nov 2025 22:26:40 -0800 Message-ID: <20251119062701.38279-1-arthur.stupa@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix the following checkpatch warnings for block comments: * Block comments should align the * on each line * Block comments use * on subsequent lines No functional changes. Signed-off-by: Artur Stupa --- .../staging/rtl8723bs/core/rtw_ieee80211.c | 4 +- drivers/staging/rtl8723bs/core/rtw_io.c | 48 ++++++----- drivers/staging/rtl8723bs/core/rtw_mlme.c | 70 ++++++++-------- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 70 ++++++++-------- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 10 +-- drivers/staging/rtl8723bs/core/rtw_security.c | 82 +++++++++---------- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 8 +- .../staging/rtl8723bs/core/rtw_wlan_util.c | 17 ++-- 8 files changed, 153 insertions(+), 156 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 027b2dd0a4b9..a5234fdbf984 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -133,8 +133,8 @@ u8 *rtw_set_ie(u8 *pbuf, } =20 /*------------------------------------------------------------------------= ---- -index: the information element id index, limit is the limit for search ---------------------------------------------------------------------------= ---*/ + * index: the information element id index, limit is the limit for search + *------------------------------------------------------------------------= --*/ u8 *rtw_get_ie(u8 *pbuf, signed int index, signed int *len, signed int lim= it) { signed int tmp, i; diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8= 723bs/core/rtw_io.c index 79d543d88278..5d3b6d810aac 100644 --- a/drivers/staging/rtl8723bs/core/rtw_io.c +++ b/drivers/staging/rtl8723bs/core/rtw_io.c @@ -5,25 +5,23 @@ * *************************************************************************= *****/ /* - -The purpose of rtw_io.c - -a. provides the API - -b. provides the protocol engine - -c. provides the software interface between caller and the hardware interfa= ce - - -Compiler Flag Option: - -1. CONFIG_SDIO_HCI: - a. USE_SYNC_IRP: Only sync operations are provided. - b. USE_ASYNC_IRP:Both sync/async operations are provided. - -jackson@realtek.com.tw - -*/ + * The purpose of rtw_io.c + * + * a. provides the API + * + * b. provides the protocol engine + * + * c. provides the software interface between caller and the hardware inte= rface + * + * + * Compiler Flag Option: + * + * 1. CONFIG_SDIO_HCI: + * a. USE_SYNC_IRP: Only sync operations are provided. + * b. USE_ASYNC_IRP:Both sync/async operations are provided. + * + * jackson@realtek.com.tw + */ =20 #include =20 @@ -135,10 +133,10 @@ int rtw_init_io_priv(struct adapter *padapter, void (= *set_intf_ops)(struct adapt } =20 /* -* Increase and check if the continual_io_error of this @param dvobjprive i= s larger than MAX_CONTINUAL_IO_ERR -* @return true: -* @return false: -*/ + * Increase and check if the continual_io_error of this @param dvobjprive = is larger than MAX_CONTINUAL_IO_ERR + * @return true: + * @return false: + */ int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj) { int error_count =3D atomic_inc_return(&dvobj->continual_io_error); @@ -150,8 +148,8 @@ int rtw_inc_and_chk_continual_io_error(struct dvobj_pri= v *dvobj) } =20 /* -* Set the continual_io_error of this @param dvobjprive to 0 -*/ + * Set the continual_io_error of this @param dvobjprive to 0 + */ void rtw_reset_continual_io_error(struct dvobj_priv *dvobj) { atomic_set(&dvobj->continual_io_error, 0); diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index c06d990350e6..16b130d8fe5b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -214,10 +214,10 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlme= priv, struct wlan_network * } =20 /* - return the wlan_network with the matching addr - - Shall be called under atomic context... to avoid possible racing conditio= n... -*/ + * return the wlan_network with the matching addr + * + * Shall be called under atomic context... to avoid possible racing condit= ion... + */ struct wlan_network *_rtw_find_network(struct __queue *scanned_queue, u8 *= addr) { struct list_head *phead, *plist; @@ -319,10 +319,10 @@ void rtw_free_network_nolock(struct adapter *padapter= , struct wlan_network *pnet } =20 /* - return the wlan_network with the matching addr - - Shall be called under atomic context... to avoid possible racing conditio= n... -*/ + * return the wlan_network with the matching addr + * + * Shall be called under atomic context... to avoid possible racing condit= ion... + */ struct wlan_network *rtw_find_network(struct __queue *scanned_queue, u8 *a= ddr) { struct wlan_network *pnetwork =3D _rtw_find_network(scanned_queue, addr); @@ -477,8 +477,8 @@ static void update_current_network(struct adapter *adap= ter, struct wlan_bssid_ex } =20 /* -Caller must hold pmlmepriv->lock first. -*/ + * Caller must hold pmlmepriv->lock first. + */ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid= _ex *target) { struct list_head *plist, *phead; @@ -844,8 +844,8 @@ static void find_network(struct adapter *adapter) } =20 /* -*rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock -*/ + * rtw_free_assoc_resources: the caller has to lock pmlmepriv->lock + */ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_qu= eue) { struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; @@ -880,8 +880,8 @@ void rtw_free_assoc_resources(struct adapter *adapter, = int lock_scanned_queue) } =20 /* -*rtw_indicate_connect: the caller has to lock pmlmepriv->lock -*/ + * rtw_indicate_connect: the caller has to lock pmlmepriv->lock + */ void rtw_indicate_connect(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -909,8 +909,8 @@ void rtw_indicate_connect(struct adapter *padapter) } =20 /* -*rtw_indicate_disconnect: the caller has to lock pmlmepriv->lock -*/ + * rtw_indicate_disconnect: the caller has to lock pmlmepriv->lock + */ void rtw_indicate_disconnect(struct adapter *padapter) { struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; @@ -1543,9 +1543,9 @@ void rtw_wmm_event_callback(struct adapter *padapter,= u8 *pbuf) } =20 /* -* _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss -* @adapter: pointer to struct adapter structure -*/ + * _rtw_join_timeout_handler - Timeout/failure handler for CMD JoinBss + * @adapter: pointer to struct adapter structure + */ void _rtw_join_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, @@ -1586,9 +1586,9 @@ void _rtw_join_timeout_handler(struct timer_list *t) } =20 /* -* rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey -* @adapter: pointer to struct adapter structure -*/ + * rtw_scan_timeout_handler - Timeout/Failure handler for CMD SiteSurvey + * @adapter: pointer to struct adapter structure + */ void rtw_scan_timeout_handler(struct timer_list *t) { struct adapter *adapter =3D timer_container_of(adapter, t, @@ -1704,10 +1704,10 @@ void rtw_set_scan_deny(struct adapter *adapter, u32= ms) } =20 /* -* Select a new roaming candidate from the original @param candidate and @p= aram competitor -* @return true: candidate is updated -* @return false: candidate is not updated -*/ + * Select a new roaming candidate from the original @param candidate and @= param competitor + * @return true: candidate is updated + * @return false: candidate is not updated + */ static int rtw_check_roaming_candidate(struct mlme_priv *mlme , struct wlan_network **candidate, struct wlan_network *competitor) { @@ -1785,10 +1785,10 @@ int rtw_select_roaming_candidate(struct mlme_priv *= mlme) } =20 /* -* Select a new join candidate from the original @param candidate and @para= m competitor -* @return true: candidate is updated -* @return false: candidate is not updated -*/ + * Select a new join candidate from the original @param candidate and @par= am competitor + * @return true: candidate is updated + * @return false: candidate is not updated + */ static int rtw_check_join_candidate(struct mlme_priv *mlme , struct wlan_network **candidate, struct wlan_network *competitor) { @@ -1829,11 +1829,11 @@ static int rtw_check_join_candidate(struct mlme_pri= v *mlme } =20 /* -Calling context: -The caller of the sub-routine will be in critical section... -The caller must hold the following spinlock -pmlmepriv->lock -*/ + * Calling context: + * The caller of the sub-routine will be in critical section... + * The caller must hold the following spinlock + * pmlmepriv->lock + */ =20 int rtw_select_and_join_from_scanned_queue(struct mlme_priv *pmlmepriv) { diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 8fe0555ab033..86d117dd2534 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -19,8 +19,8 @@ static struct mlme_handler mlme_sta_tbl[] =3D { {WIFI_PROBERSP, "OnProbeRsp", &OnProbeRsp}, =20 /*---------------------------------------------------------- - below 2 are reserved - -----------------------------------------------------------*/ + * below 2 are reserved + *--------------------------------------------------------*/ {0, "DoReserved", &DoReserved}, {0, "DoReserved", &DoReserved}, {WIFI_BEACON, "OnBeacon", &OnBeacon}, @@ -51,8 +51,8 @@ static struct action_handler OnAction_tbl[] =3D { static u8 null_addr[ETH_ALEN] =3D {0, 0, 0, 0, 0, 0}; =20 /************************************************** -OUI definitions for the vendor specific IE -***************************************************/ + * OUI definitions for the vendor specific IE + *************************************************/ unsigned char RTW_WPA_OUI[] =3D {0x00, 0x50, 0xf2, 0x01}; unsigned char WMM_OUI[] =3D {0x00, 0x50, 0xf2, 0x02}; unsigned char WPS_OUI[] =3D {0x00, 0x50, 0xf2, 0x04}; @@ -65,8 +65,8 @@ unsigned char WMM_PARA_OUI[] =3D {0x00, 0x50, 0xf2, 0x02,= 0x01, 0x01}; static unsigned char REALTEK_96B_IE[] =3D {0x00, 0xe0, 0x4c, 0x02, 0x01, 0= x20}; =20 /******************************************************** -ChannelPlan definitions -*********************************************************/ + * ChannelPlan definitions + *******************************************************/ static struct rt_channel_plan_2g RTW_ChannelPlan2G[RT_CHANNEL_DOMAIN_2G_MA= X] =3D { {{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13}, /* 0x00, RT_CHANNEL_= DOMAIN_2G_WORLD , Passive scan CH 12, 13 */ {{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13}, 13}, /* 0x01, RT_CHANNEL_= DOMAIN_2G_ETSI1 */ @@ -188,10 +188,10 @@ int rtw_ch_set_search_ch(struct rt_channel_info *ch_s= et, const u32 ch) } =20 /*************************************************************************= *** - -Following are the initialization functions for WiFi MLME - -**************************************************************************= ***/ + * + * Following are the initialization functions for WiFi MLME + * + *************************************************************************= **/ =20 int init_hw_mlme_ext(struct adapter *padapter) { @@ -508,10 +508,10 @@ void mgt_dispatcher(struct adapter *padapter, union r= ecv_frame *precv_frame) } =20 /*************************************************************************= *** - -Following are the callback functions for each subtype of the management fr= ames - -**************************************************************************= ***/ + * + * Following are the callback functions for each subtype of the management= frames + * + *************************************************************************= **/ =20 unsigned int OnProbeReq(struct adapter *padapter, union recv_frame *precv_= frame) { @@ -1951,10 +1951,10 @@ inline struct xmit_frame *alloc_mgtxmitframe(struct= xmit_priv *pxmitpriv) } =20 /*************************************************************************= *** - -Following are some TX functions for WiFi MLME - -**************************************************************************= ***/ + * + * Following are some TX functions for WiFi MLME + * + *************************************************************************= **/ =20 void update_mgnt_tx_rate(struct adapter *padapter, u8 rate) { @@ -3798,10 +3798,10 @@ unsigned int send_beacon(struct adapter *padapter) } =20 /*************************************************************************= *** - -Following are some utility functions for WiFi MLME - -**************************************************************************= ***/ + * + * Following are some utility functions for WiFi MLME + * + *************************************************************************= **/ =20 void site_survey(struct adapter *padapter) { @@ -4393,10 +4393,10 @@ static void process_80211d(struct adapter *padapter= , struct wlan_bssid_ex *bssid } =20 /*************************************************************************= *** - -Following are the functions to report events - -**************************************************************************= ***/ + * + * Following are the functions to report events + * + *************************************************************************= **/ =20 void report_survey_event(struct adapter *padapter, union recv_frame *precv= _frame) { @@ -4693,10 +4693,10 @@ void report_add_sta_event(struct adapter *padapter,= unsigned char *MacAddr, int } =20 /*************************************************************************= *** - -Following are the event callback functions - -**************************************************************************= ***/ + * + * Following are the event callback functions + * + *************************************************************************= **/ =20 /* for sta/adhoc mode */ void update_sta_info(struct adapter *padapter, struct sta_info *psta) @@ -4864,7 +4864,7 @@ void mlmeext_joinbss_event_callback(struct adapter *p= adapter, int join_res) rtw_sta_media_status_rpt(padapter, psta, 1); =20 /* wakeup macid after join bss successfully to ensure - the subsequent data frames can be sent out normally */ + * the subsequent data frames can be sent out normally */ rtw_hal_macid_wakeup(padapter, psta->mac_id); } =20 @@ -4941,10 +4941,10 @@ void mlmeext_sta_del_event_callback(struct adapter = *padapter) } =20 /*************************************************************************= *** - -Following are the functions for the timer handlers - -**************************************************************************= ***/ + * + * Following are the functions for the timer handlers + * + *************************************************************************= **/ void _linked_info_dump(struct adapter *padapter) { int i; diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 7b643ac320f0..0ef788abf403 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -999,11 +999,11 @@ inline void rtw_set_ips_deny(struct adapter *padapter= , u32 ms) } =20 /* -* rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend -* @adapter: pointer to struct adapter structure -* @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup -* Return _SUCCESS or _FAIL -*/ + * rtw_pwr_wakeup - Wake the NIC up from: 1)IPS. 2)USB autosuspend + * @adapter: pointer to struct adapter structure + * @ips_deffer_ms: the ms will prevent from falling into IPS after wakeup + * Return _SUCCESS or _FAIL + */ =20 int _rtw_pwr_wakeup(struct adapter *padapter, u32 ips_deffer_ms, const cha= r *caller) { diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index b2c783ada49b..45dc1e1a56a9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -31,8 +31,8 @@ const char *security_type_str(u8 value) /* WEP related =3D=3D=3D=3D=3D */ =20 /* - Need to consider the fragment situation -*/ + * Need to consider the fragment situation + */ void rtw_wep_encrypt(struct adapter *padapter, u8 *pxmitframe) { /* exclude ICV */ union { @@ -343,23 +343,23 @@ static const unsigned short Sbox1[2][256] =3D { = /* Sbox for hash (can be in R } }; =20 - /* -********************************************************************** -* Routine: Phase 1 -- generate P1K, given TA, TK, IV32 -* -* Inputs: -* tk[] =3D temporal key [128 bits] -* ta[] =3D transmitter's MAC address [ 48 bits] -* iv32 =3D upper 32 bits of IV [ 32 bits] -* Output: -* p1k[] =3D Phase 1 key [ 80 bits] -* -* Note: -* This function only needs to be called every 2**16 packets, -* although in theory it could be called every packet. -* -********************************************************************** -*/ +/* + ********************************************************************** + * Routine: Phase 1 -- generate P1K, given TA, TK, IV32 + * + * Inputs: + * tk[] =3D temporal key [128 bits] + * ta[] =3D transmitter's MAC address [ 48 bits] + * iv32 =3D upper 32 bits of IV [ 32 bits] + * Output: + * p1k[] =3D Phase 1 key [ 80 bits] + * + * Note: + * This function only needs to be called every 2**16 packets, + * although in theory it could be called every packet. + * + ********************************************************************** + */ static void phase1(u16 *p1k, const u8 *tk, const u8 *ta, u32 iv32) { signed int i; @@ -386,28 +386,28 @@ static void phase1(u16 *p1k, const u8 *tk, const u8 *= ta, u32 iv32) =20 =20 /* -********************************************************************** -* Routine: Phase 2 -- generate RC4KEY, given TK, P1K, IV16 -* -* Inputs: -* tk[] =3D Temporal key [128 bits] -* p1k[] =3D Phase 1 output key [ 80 bits] -* iv16 =3D low 16 bits of IV counter [ 16 bits] -* Output: -* rc4key[] =3D the key used to encrypt the packet [128 bits] -* -* Note: -* The value {TA, IV32, IV16} for Phase1/Phase2 must be unique -* across all packets using the same key TK value. Then, for a -* given value of TK[], this TKIP48 construction guarantees that -* the final RC4KEY value is unique across all packets. -* -* Suggested implementation optimization: if PPK[] is "overlaid" -* appropriately on RC4KEY[], there is no need for the final -* for loop below that copies the PPK[] result into RC4KEY[]. -* -********************************************************************** -*/ + ********************************************************************** + * Routine: Phase 2 -- generate RC4KEY, given TK, P1K, IV16 + * + * Inputs: + * tk[] =3D Temporal key [128 bits] + * p1k[] =3D Phase 1 output key [ 80 bits] + * iv16 =3D low 16 bits of IV counter [ 16 bits] + * Output: + * rc4key[] =3D the key used to encrypt the packet [128 bits] + * + * Note: + * The value {TA, IV32, IV16} for Phase1/Phase2 must be unique + * across all packets using the same key TK value. Then, for a + * given value of TK[], this TKIP48 construction guarantees that + * the final RC4KEY value is unique across all packets. + * + * Suggested implementation optimization: if PPK[] is "overlaid" + * appropriately on RC4KEY[], there is no need for the final + * for loop below that copies the PPK[] result into RC4KEY[]. + * + ********************************************************************** + */ static void phase2(u8 *rc4key, const u8 *tk, const u16 *p1k, u16 iv16) { signed int i; diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging= /rtl8723bs/core/rtw_sta_mgt.c index d1f6030799cb..2014998245db 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c @@ -385,10 +385,10 @@ u32 rtw_free_stainfo(struct adapter *padapter, struct= sta_info *psta) rtw_release_macid(pstapriv->padapter, psta); =20 /* - spin_lock_bh(&pstapriv->asoc_list_lock); - list_del_init(&psta->asoc_list); - spin_unlock_bh(&pstapriv->asoc_list_lock); -*/ + * spin_lock_bh(&pstapriv->asoc_list_lock); + * list_del_init(&psta->asoc_list); + * spin_unlock_bh(&pstapriv->asoc_list_lock); + */ spin_lock_bh(&pstapriv->auth_list_lock); if (!list_empty(&psta->auth_list)) { list_del_init(&psta->auth_list); diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 74d3f2de360d..186a982cb99e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1021,9 +1021,9 @@ void HTOnAssocRsp(struct adapter *padapter) =20 /* handle A-MPDU parameter field */ /* - AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k - AMPDU_para [4:2]:Min MPDU Start Spacing - */ + * AMPDU_para [1:0]:Max AMPDU Len =3D> 0:8k , 1:16k, 2:32k, 3:64k + * AMPDU_para [4:2]:Min MPDU Start Spacing + */ max_AMPDU_len =3D pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x03; =20 min_MPDU_spacing =3D (pmlmeinfo->HT_caps.u.HT_cap_element.AMPDU_para & 0x= 1c) >> 2; @@ -1691,12 +1691,11 @@ void adaptive_early_32k(struct mlme_ext_priv *pmlme= ext, u8 *pframe, uint len) /* pmlmeext->bcn_delay_ratio[delay_ms] =3D (pmlmeext->bcn_delay_cnt[dela= y_ms] * 100) /pmlmeext->bcn_cnt; */ =20 /* - - for (i =3D 0; i<9; i++) - { - pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]); - } -*/ + * for (i =3D 0; i<9; i++) + * { + * pmlmeext->bcn_delay_cnt[i] , i, pmlmeext->bcn_delay_ratio[i]); + * } + */ =20 /* dump for adaptive_early_32k */ if (pmlmeext->bcn_cnt > 100 && (pmlmeext->adaptive_tsf_done =3D=3D true))= { --=20 2.43.0