From nobody Tue Dec 2 02:37:43 2025 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 142AF2EA168; Wed, 19 Nov 2025 03:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763523236; cv=none; b=QoKavRmMpvW4FuEiYONbLVYOoIGuxjJznpx4mkSu60EEpWUWq/usE11f7hO9zMRbu5GHkkuTqXzopKW3tmrzdAd+lEXoBMmQhmEUrm5tUnL+rWLUPFk0nInV3OWw/lC1v5k15epRR9UXB07zip/9coa4ny3HnnmyQsotfnomFVM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763523236; c=relaxed/simple; bh=BLeftu38KzjQnnk41VX3i8vvwKECGoRjHeSmzF32jyk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ok1YvHi576SRfBEzoeF+04rRekgIwPbg2Mt1UN+N7Znqhjtb9yjpuJdw9KbYyySDVJj3PYZvjW8W7ldIBKipVd1o2STHrQcD8XiQpRKdjDcb/ExmWRhtE8mmJ8NrmseKNzVjVusmagcH6yK0hm7QQcoi6+iphxAurYwddasabBE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-03 (Coremail) with SMTP id rQCowAAXpdeUOh1pnpc_AQ--.34112S2; Wed, 19 Nov 2025 11:33:42 +0800 (CST) From: Haotian Zhang To: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org Cc: robh@kernel.org, bhelgaas@google.com, michal.simek@amd.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] PCI: xilinx: Fix INTx IRQ domain leak when MSI allocation fails Date: Wed, 19 Nov 2025 11:33:01 +0800 Message-ID: <20251119033301.518-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAXpdeUOh1pnpc_AQ--.34112S2 X-Coremail-Antispam: 1UD129KBjvJXoWxJr4UXr17Cr4DWw1kCFyDJrb_yoW8Jw4DpF WDGw17uF4DJFW5WF4UC3W5ua43Wa9Fyryqy3yIgwnrZF13u3yjkF1jgFyFvF1rJF48Jr1U Zr18t3WrZF15CF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB014x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26F 4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv 7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r 1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02 628vn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCY02Avz4vE14v_Gr4l42xK82IYc2Ij64 vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8G jcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2I x0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK 8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU1GQDUUUUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAULA2kdElRw1gABsU Content-Type: text/plain; charset="utf-8" In xilinx_pcie_init_irq_domain(), if xilinx_allocate_msi_domains() fails after pcie->leg_domain has been successfully created via irq_domain_create_linear(), the function returns directly without cleaning up the allocated IRQ domain, resulting in a resource leak. Add irq_domain_remove() call in the error path to properly release the IRQ domain before returning the error. Fixes: 699ca3016268 ("PCI: xilinx: Check for __get_free_pages() failure") Signed-off-by: Haotian Zhang --- drivers/pci/controller/pcie-xilinx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-xilinx.c b/drivers/pci/controller/= pcie-xilinx.c index 937ea6ae1ac4..e8cf320f3764 100644 --- a/drivers/pci/controller/pcie-xilinx.c +++ b/drivers/pci/controller/pcie-xilinx.c @@ -480,8 +480,10 @@ static int xilinx_pcie_init_irq_domain(struct xilinx_p= cie *pcie) phys_addr_t pa =3D ALIGN_DOWN(virt_to_phys(pcie), SZ_4K); =20 ret =3D xilinx_allocate_msi_domains(pcie); - if (ret) + if (ret) { + irq_domain_remove(pcie->leg_domain); return ret; + } =20 pcie_write(pcie, upper_32_bits(pa), XILINX_PCIE_REG_MSIBASE1); pcie_write(pcie, lower_32_bits(pa), XILINX_PCIE_REG_MSIBASE2); --=20 2.50.1.windows.1