From nobody Tue Dec 2 02:41:47 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C54A2E62C3 for ; Wed, 19 Nov 2025 03:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763521994; cv=none; b=N22b7MJ0Vdjjs660Es/ONx72HpNr/lCSvlOgreJt3WPKosSgjCY7VEmWE+nCVlfXHMvY4WkbVisxM4A9ctYaSY+Jif8Gu2WQFo4SVriZ86N31pUSpCfxFHyujugRghDrL7XNo2m49yUSLpCdPzzhzVzBALSv8YPJmQU9k2qS2GY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763521994; c=relaxed/simple; bh=7Md/k+VoRlUWEhPZsj1MCCE357Fw8kLPt8Vdk/s++fs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X/JJI/3XDQeEIWQW6ARY5nO5WN6Met1IfQVxO16qx1bdE4mM+l9NPO+X3MCQCISvelzqm/7xtdq2wGS6y3H+5UJI5uCZhc8lRK6ddz+iED/nuPC66dG5wk8HBg04QRDd1NCb6dpmC49WX7pdceb2wlzaf5/Fg0gbvDG5lMoJ1I0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XXkbIfAi; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XXkbIfAi" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-8b22b1d3e7fso611294885a.3 for ; Tue, 18 Nov 2025 19:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763521992; x=1764126792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wYjjMFDyj3II80FDbJo2VUAYgYCaimv8i5nmMzAY3mQ=; b=XXkbIfAi1RBT+7RkjxQzz4CD5fhvTPZM7cWE7niMWkGzif6TVK547esgvqXH0B8yGi 3mCm0k3JPT90JM9BasV7N6ad5lmMpXNMyJE+4QmfUJHxgDYrhv5N6n+LUT6owkncxHVm if/EGtmsw+61eOl0XsD2kf7qkTo1/gX0JIbs1kZ5ItXBfhAWeSCoArasqa2JJLZ8Y42f bh+GB2lbcVqFeICNIXZQvU+G0CP5mmfM5tk3tjEGdeNc0jLfpK/guhUPrZy9rOe5PuhN nmpn6SCpDIyxMVkXr2mgVpICRsnZsQ60zGrK+Ml8gvS2Nzfaa+HBjR/FwNG6pUH8hyyA hyCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763521992; x=1764126792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wYjjMFDyj3II80FDbJo2VUAYgYCaimv8i5nmMzAY3mQ=; b=EeyFqf6w/dZGYMkwlfz9JrfuOkZFKiw5z39OI1Y1PTSOoX5EO/KJkdBHcMznYjMkSt N0W2EZwQBJOPG/NKVUii/IrtlsjM0PAO7vkv+m3EJrk1IPXp5n/BIl33vBCQHTw0Zkbg 6Q52N5yG1fbburNctK8FfBxokmNJz5NcnI/uYLELo+smSxYR/PoBubzxTEymOR/F+foT NYQfr8j8rkxcm2AFBeyuOqrJ52t8h09C8CJGfYKs1oo9bQH+LwQLmGQXA4tKnv/RS5jw aL4EQXwWZsCqpd/zn/Hz0WYoselNmOrWiVT4nVOtPqTEXathCEcQByIUjBoGmk0c9m8Q 2wbg== X-Forwarded-Encrypted: i=1; AJvYcCU5kdJxz5YIKF1s7y9KJ8QHlU3tvMUVjP5BIlMJ1UQjeQUlgjHusb+n/19QeCd2ZdMwyc7F7TVNrVhJweA=@vger.kernel.org X-Gm-Message-State: AOJu0YwpLhfMg5c/UQ5eqHxOgi1/3Az+XPADK3GXEFk1hAPVC/EBqk3s dthGejKgwbXi+q43z53E+hAkXr1NLl+PPSpI4r44ZuPIbKIDA3B7yGds X-Gm-Gg: ASbGncvpe9jdJCCbXmCVRyZFUOfstDuTui3tm/Ch52t1dhzK1xn85IoSdzzLOXTSOfa nF4dSNZkWbDpwNJAB1HLf/Nk6uFGZezrKa0u4JqPXaIdQWk6EM3eLm7gHEqfmaPkIA28D8NF+/u cV6aGFPm/BkSH5axZGjDdWTNzg5YWwHUXSWNvEJvHBYzKw5IA9o80b2TJdI3mG8wkK009yMtkAR kBUvYjKiHURwvmoAeGuDa8xX79UErI4aOY0JaUCrX52cCTgRb8C8jUD8LCsTUs4o4GZ+y2u3joo UGq11wfXeOhEhtwFmiwuY2P4325/hBB0YVXVZKL8AvZQC2x5SdVsEYdJdfSGl4eZzDDTH6nns8Y DzuqKXPbIxq2BfhXB834cB/8mWYoEkWRL+PZlYETQXaihpMXyOJ2jem2jnF42mbEyJuiNrZGYiu raZRFBj3o= X-Google-Smtp-Source: AGHT+IFd6zw/6k0xiGo7nDDstLjYtFjZ3rqIqq8KbhxzG+jcE1x4N3uRVhhNGtqMHccqX+axXLmcWw== X-Received: by 2002:a05:620a:4091:b0:8b2:a3a9:f770 with SMTP id af79cd13be357-8b2c31e4bdcmr2429017585a.83.1763521992160; Tue, 18 Nov 2025 19:13:12 -0800 (PST) Received: from localhost ([12.22.141.131]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8b2af041e55sm1338774185a.42.2025.11.18.19.13.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 19:13:11 -0800 (PST) From: "Yury Norov (NVIDIA)" To: Andrew Morton , Thomas Gleixner Cc: "Yury Norov (NVIDIA)" , Rasmus Villemoes , linux-kernel@vger.kernel.org Subject: [PATCH 2/3] group_cpus: don't call cpumask_weight() prematurely Date: Tue, 18 Nov 2025 22:13:04 -0500 Message-ID: <20251119031306.644129-3-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251119031306.644129-1-yury.norov@gmail.com> References: <20251119031306.644129-1-yury.norov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" alloc_nodes_groups() and __group_cpus_evenly() call cpumask_weight() unconditionally in the for_each() loops. cpumask_weight() is O(N), so the complexity of the functions become O(MAX_NUMNODES * nr_cpu_ids). This call may be avoided if the nmsk is empty. Signed-off-by: Yury Norov (NVIDIA) --- lib/group_cpus.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/lib/group_cpus.c b/lib/group_cpus.c index 6d08ac05f371..6aae1560b796 100644 --- a/lib/group_cpus.c +++ b/lib/group_cpus.c @@ -142,15 +142,11 @@ static void alloc_nodes_groups(unsigned int numgrps, } =20 for_each_node_mask(n, nodemsk) { - unsigned ncpus; - - cpumask_and(nmsk, cpu_mask, node_to_cpumask[n]); - ncpus =3D cpumask_weight(nmsk); - - if (!ncpus) + if (!cpumask_and(nmsk, cpu_mask, node_to_cpumask[n])) continue; - remaining_ncpus +=3D ncpus; - node_groups[n].ncpus =3D ncpus; + + node_groups[n].ncpus =3D cpumask_weight(nmsk); + remaining_ncpus +=3D node_groups[n].ncpus; } =20 numgrps =3D min_t(unsigned, remaining_ncpus, numgrps); @@ -294,11 +290,10 @@ static int __group_cpus_evenly(unsigned int startgrp,= unsigned int numgrps, continue; =20 /* Get the cpus on this node which are in the mask */ - cpumask_and(nmsk, cpu_mask, node_to_cpumask[nv->id]); - ncpus =3D cpumask_weight(nmsk); - if (!ncpus) + if (!cpumask_and(nmsk, cpu_mask, node_to_cpumask[nv->id])) continue; =20 + ncpus =3D cpumask_weight(nmsk); WARN_ON_ONCE(nv->ngroups > ncpus); =20 /* Account for rounding errors */ --=20 2.43.0