From nobody Tue Dec 2 02:30:08 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19B3B302CB9 for ; Wed, 19 Nov 2025 18:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763575835; cv=none; b=qxzf49+RJBoVBZtxnF6DK+EFxTDRyiBHmPPpkAk+FtGwSVgsjlkG4Ipn7zRqGJLr27iiYQYRclUz8npFEYEAy4njBbFr7+coBa1TZ2iD63naGL/O59kVgopIH/lgafNCKMbb0D8LpsaE7k/u7dmgEzxHGJ04oK3S5FsfPEe1Iug= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763575835; c=relaxed/simple; bh=aB8AQU5T79GE8yEjbX3yEliqZgfm3QNVjb6a8THRBX4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZdXV/PywKzQHJXnT1/DB+UAEQ2KUdJaxJj6gwnMOnOg2E2J/OWVUMsFdnmEFibj1mAefqz3bEy+guNUpU43SPUDqGJLHOx1C00HF1Sh9uHXxem6aMSd1XeXRfKIm+pnjqk0HFx1It/gIMkrh1e+DQcFApSFfYNbdFNfXCUlA21o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZNdcde/H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=FmBt7nJr; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZNdcde/H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="FmBt7nJr" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AJFkPXI2061048 for ; Wed, 19 Nov 2025 18:10:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M13z2nhJ5XNNt8OBEkRgQFiRfSl+F/tnKBCTf6qisp4=; b=ZNdcde/Hv4gTLz0i qagLhtLdd8qfSoQA9bdy3IT1DNzeNom0L6tzmK3uVTUOqz7Layo1L8GUa+C3+887 95IwVoRFqaF+7CkN48W3m++4O77PPGk13WHKmcv2DpDS/S3jCTEtiZRnukxtQtMm o55GtzE/N0HeBacYmy77nrzkxdxqQ58NRWVaT26lo0ixlKObJZheKQ6c6yglyfEv oFDNkmbSHpSkYh0GnMAvnDJ289yxGtRaJEuNxHf9oXKY5IdRLPX2UvbwxO1yv05T jtQF14G+ivgPDPtftN6q8ewpqFfPcpj7VKgGfww1TgM7If2nEYQMo7VfD5NWK/jw HcMLcw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ah9fu9ym6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Nov 2025 18:10:23 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-297f48e81b8so163215ad.0 for ; Wed, 19 Nov 2025 10:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763575823; x=1764180623; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=M13z2nhJ5XNNt8OBEkRgQFiRfSl+F/tnKBCTf6qisp4=; b=FmBt7nJrAyrpxmpjHVTozMqJPiB+DJBY8RKEWjcI7gC/FrcHr0w3/xAUnBSe6Q80an JtawBYwTZ2XO2pkI7jvlJcv2XH2dO3rYfh+Y0Bup0TgWi7jVeI+ermTSU9SRaSmkCuhL zbke4HnqklVOgPzftx1Yd4lxNcHCzTZYoiqHZB4RlMANXx2I/rS3jmuoIz5C/3pV2Z7O Yazi4SnZpkIBUxc1u2SfrDHhcf4zCvOvNc8gmpDoBEk2QRmfeD+RgFl0wVBp2xNsodWw hEuYxA6MnYEYPIs25v88UQZx/F/RqB/BfR/e5LLMnTqp7E8JNhhVsZD3820sHFrDaw0L emxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763575823; x=1764180623; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=M13z2nhJ5XNNt8OBEkRgQFiRfSl+F/tnKBCTf6qisp4=; b=TH9QK5rz0d6NmnkTj6druK3f11XZCi2QabMhEMtWNr9BCzXS36+YY4LUAa4C7pCQ02 kWT03/0YOORJwGtg68V9M3ae2fTDw5u5qSMcsMquT9K0GFia+5AONldSbCSwx1KBtNXV YH1nj6DTSX9AGanL8yiXJsEpcAjTrEdx+PczLKm8lHKfcFnEanu6NXVyb6N3aeN4V2QP VRXXfxNPtYPUNTQsGQwmCfp7Lwz/LVGp4uoo/nLDIZch6STxoQHn2xcNK3l9GkXSkGNw rI7nEe3+mwbgbzv+C96y9Z6VM6t+2/6mh5P/1+DkPzeWedGBXQOiKCeBLBPOTHVVATs4 Djjw== X-Forwarded-Encrypted: i=1; AJvYcCXptIW1ErLIc/ZPoApbdRte7bs3SDrbiOcsrOJKJUGbcERY11e8/i/4YqPxDHPHvVAJoYoAmvAWF/BPAkY=@vger.kernel.org X-Gm-Message-State: AOJu0YzstUDFl2TIelNdMQn6/KHt2wtjSAiTiZr5CJRep6U7qdGGMYJ0 GY+M4JdIFhGkgzyx9xf0UIOE9v1NEBwXy4nlrDzYiwC9NCHNSzEroS2msMm1Bjs2t6mFx0e3btu lPvInav/CNMnIM3eOFdLV8Yn13lo4KL3Tnpd+yvRdrkEyUX6YqFkQSfeFninQEODqg88= X-Gm-Gg: ASbGncuaQ6DigC+ls3WZGPVvdfzoKsSd9ntNdmk1W81Dt0o9MCmlCMYpW0I2wyP+7+d 7OG/cO9tBJnfteh+NZkP9C+SPrqZMU/OywIxQPc8y+96tyAU+PbqUAhSkivdSNZjVsUn2VbjAUh 1NlystXXIgGJ9955tUFXkDh+IwQfZrOrvwLiylD69ijbi/kNHutBAEkabAE5Lh9Zs3ujHtOh7FL ISD84rUHRIQu+w08lObJW48QHfsSPX4r6c54HCRTzC1OBugZg0W0ajK7OYWc62GI+1zPkyQlXbP 9RiLCKwudZvJcoT6JeoRIRG1Uu6MdOrruaV3Js44vFQToT7z/ZL4vSGQns5ikQS3vKznx/HUYvT F87mEx7kc+QviZcMK7Z9Jkj+YvMXDcg96zEOAoak= X-Received: by 2002:a17:903:1a90:b0:269:b2e5:900d with SMTP id d9443c01a7336-29b5c0b3ca9mr918585ad.5.1763575822644; Wed, 19 Nov 2025 10:10:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IH7ZN9s2BxP3STc5lsVm3YHhRFutnEWOCIP3ZR8jYDADQVNljE4X6IilASjwkOZu5k9soId1g== X-Received: by 2002:a17:903:1a90:b0:269:b2e5:900d with SMTP id d9443c01a7336-29b5c0b3ca9mr918165ad.5.1763575822195; Wed, 19 Nov 2025 10:10:22 -0800 (PST) Received: from [192.168.1.102] ([120.56.197.63]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b111016sm1408865ad.6.2025.11.19.10.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 10:10:21 -0800 (PST) From: Manivannan Sadhasivam Date: Wed, 19 Nov 2025 23:40:07 +0530 Subject: [PATCH 1/2] PCI: dwc: Skip PME_Turn_Off broadcast and L2/L3 transition during suspend if link is not up Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-pci-dwc-suspend-rework-v1-1-aad104828562@oss.qualcomm.com> References: <20251119-pci-dwc-suspend-rework-v1-0-aad104828562@oss.qualcomm.com> In-Reply-To: <20251119-pci-dwc-suspend-rework-v1-0-aad104828562@oss.qualcomm.com> To: Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, vincent.guittot@linaro.org, zhangsenchuan@eswincomputing.com, Manivannan Sadhasivam X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1100; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=aB8AQU5T79GE8yEjbX3yEliqZgfm3QNVjb6a8THRBX4=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBpHggDw7uT50wCuHAJeUJpbSYo00637n44xxTrW qCCA3gYjZmJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaR4IAwAKCRBVnxHm/pHO 9RIyB/0eWUbFMn4mUD4N851/q3ujQ8LdgHgJhkb49RcDa2GLr4w653BIi2hEXIQGwCEMKclTn92 8T0/OwibDSct5/qwZeTuqU9WIJeK2B+NuTfCkkkSSROuvPVKlBTYR8aC/HmtQG6skiDZ+PPAhhQ UgpE9lQNP+gYCgSqhUR/BZeuXnW1YP64KEJKRM27siyKpcn/1gjfrvnRoXaFrhrbDksaeN/jCq7 CUxd0i58XbOTyrTerOyFdplxX7yOrA9U0u5qtPa+IRDG0yk3fYANuUAoComfRgekR9i3Q75jChY LK1//zeGVzzga6lsXC1leSORSqGvFnlfHBhMwE1/Lc7ax6bb X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE5MDE0NCBTYWx0ZWRfX3WUSWJbjJl3O jjRgLznRuvIVt3u0fC1P9gAJozwflAndFbXb50hrfXHLsJ88xrx1jC1IDJEf6GV+I2TyUDCD9gL dQVoSvOZkSWSrKJD5iSOQLoJFo5hvim4yyGZlMESxjzLGoUACowQ6/vN7gVJP525RgrrL+riPXd mqN93Wa8yARPTgudI9k2kWXVGob+KP70SZ5ZcfBSI2zslv+sgUxCu0plsAYYP0Q12bqihn44A5u 2rn6HNTzwK+gwzqFSOaqyxo5cLjFuj2SPI/xdySVX17IF+10UNXS07WEFORSJ6xdtdvKnoo+ZIS +chjlrRbB6Y4qaljJDp/wDwHU+Ff9BAByrKVdP4tg== X-Authority-Analysis: v=2.4 cv=KZTfcAYD c=1 sm=1 tr=0 ts=691e080f cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=xeX0Tm50+WxWVv+NCdhSGA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=aqWwvIXvDE_FxjdaEBsA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: A328wAkzfhiGoY5b1E7qyNPnazyCwTwS X-Proofpoint-GUID: A328wAkzfhiGoY5b1E7qyNPnazyCwTwS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-19_05,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511190144 During system suspend, if the PCIe link is not up, then there is no need to broadcast PME_Turn_Off message and wait for L2/L3 transition. So skip them. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Frank Li Tested-by: Vincent Guittot --- drivers/pci/controller/dwc/pcie-designware-host.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pc= i/controller/dwc/pcie-designware-host.c index 20c9333bcb1c..8fe3454f3b13 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -1129,6 +1129,9 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) u32 val; int ret; =20 + if (!dw_pcie_link_up(pci)) + goto stop_link; + /* * If L1SS is supported, then do not put the link into L2 as some * devices such as NVMe expect low resume latency. @@ -1162,6 +1165,7 @@ int dw_pcie_suspend_noirq(struct dw_pcie *pci) */ udelay(1); =20 +stop_link: dw_pcie_stop_link(pci); if (pci->pp.ops->deinit) pci->pp.ops->deinit(&pci->pp); --=20 2.48.1