From nobody Tue Dec 2 02:19:50 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1051D1ADC7E for ; Thu, 20 Nov 2025 00:15:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763597735; cv=none; b=Vmyg4QfJlws5LsAgHFLLN2H7wGVTO4jDm9FCZwnd4EKh0jzG6EY+WJ2IzScE6jB7dc29a9Dt+7qPdqVxyW9b4apfbX/uLJoeOpz072ETaJiBx0hoUGThFOmHv/PU2jmX1rknMS2hNYUdC4kjm3UezM3qEQ3Tsn7pWBolC69lJSY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763597735; c=relaxed/simple; bh=OJ5QWhtiskGythM7vc6Jd6M853ak+vqQdxx02P1aSSg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f7+r32gFA+8eFwArmEvvKI2+P/E1laEEuQbYz2aGZkLJ1zv7lABWVhxeKFc0K1r5ucfs3n5udnNl+Dm5ooVN+l8Wd+WeztwkOCTcR9RNXNJOyTWbKOl55XQDKz+64l/iGM3cC9O/8vCdVz1Wquxg1pAPa6BaIpkIFEZqHMuz3NE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MDyG4RTk; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MDyG4RTk" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779b49d724so561125e9.0 for ; Wed, 19 Nov 2025 16:15:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763597732; x=1764202532; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SayxfPvE/g0bojag9Jh1IjbEk4cTOITTJ9rniJCmzdw=; b=MDyG4RTkla1NVM2/ZkWxecCIwg68QHNaq5SRT2t3FXNxMMC92WvTSSGn1hgcz68pCl 7q1tmID5BPsVDC8Dy6yG9tdClOV+c6LjwNAr4DkSyCr1arey10jrRVcASfJAMNh3YLed VwWFVph2PH6I7BWQZDmQhWYT9/vWS3kBE0q5c/sagrGv+WJc5h98bW7MlYBmN9PDAR+C /2NkFmgdlIKPfLv7HgZqaYjMK4FcpB7kKC9JEfzx5WaXRLhhnCIE9H+rZwlM90LceYvh 42aCqzSrAwxG30cp1dzNFiHlJpgHtbMcHGSmyVVGdj5HAJlwFsug/ZE1CoAL88FEFEIJ Kfaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763597732; x=1764202532; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=SayxfPvE/g0bojag9Jh1IjbEk4cTOITTJ9rniJCmzdw=; b=lO1njXsU8hbUgszgp+c2P9u/xGPKiVlM9gJ7qbMbcsLyfsbejoRmbFSq70FkIMrMKF BZBL95/BKptkR6nJaUj7lAtmoOw9nHlSwY9fZpM0/QNv9+d564ouNb7Eg6DdIJVeETjD OWucHPZv+ZJQEEj+6jqCOpwy8MDuJlaeTKSKBi4xOgg5HlZWf+krrpWLvCnNcTRZ9C24 GVWDT4/JxIwur2DLZE1w208GElndC3BpaxcpEQ6itzUg+suGpMI+2VefhnnuxRKwiAUp P/qlrPmGOxYqqL84FPB8409oWHtXjtSIkqAi/5M8wYpoDkY1RGVWRjzuRWr2zfS4kXd8 NrQw== X-Forwarded-Encrypted: i=1; AJvYcCU0edYi9h3BHcLwhUwPQSnl+tBX5Wz0Q8PdNbrhSSdYdu+AlbOhzrlnRXDTIGCQPOIfIeUotG2EPjvhgu8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0XTUur6/iuxM38ixSPOpoR4YRiIAPqxiJOhmTHhnqyID5iTgF C8T0fjIFi0cLgF8pqBLlyn6bnAfn9MBKQcEr76o75KT50vKApcU0+T0e X-Gm-Gg: ASbGnctPJcKCET6KSZmhYmxiXC9Ey73Ic0HufMcz+pfiCEx9DBub5N8CXjTEuTTOFLG BbbtWn++QdZX8ltODu6tgHWYU2CzKaGJa6WEwz4LxZH/1WOsHBOa0TNaPD25JdqqWOqFLS9apd5 qQSDT52AksYakgwxXFqilTxcmqlL7rOUaHxzqE6u0fZ3P46vVbloHnu/4Xc0EwxNluE8f+AV3yz fDIILftOdr4vDLM55znvwnk2GzfFGcLHeiEErTP9OyOZmylDGeimkgPrb2lpQg9eg+kxOiQX3f7 dh/0t7oeyUTp0fl75WLuVjkOcbNgG8DQ43O8UfjB+0VCEwxxCrSJ7TErg0tZTQBKNlTQn8qV9oN Rbm0PtQ6D5we2iBeRS2gdreHBQU20191jPovVzE/LFWnhmH5rOoFZ+QEE3d0re7wYsdnsIwcqho /rIUSv5L5MAZ8vnVex82z21C1/5smWMD7ROAzeOg== X-Google-Smtp-Source: AGHT+IEzBZnPtD+MWg+C98wu/ohpL3j6Un+ABjFCUid0HHBT6AkRjqh+tjh65yJWqV45+5XdzYdJ2Q== X-Received: by 2002:a5d:584f:0:b0:429:bc3b:499d with SMTP id ffacd0b85a97d-42cb9a6a91emr262740f8f.6.1763597732189; Wed, 19 Nov 2025 16:15:32 -0800 (PST) Received: from localhost ([2a03:2880:31ff:43::]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42cb7f2e574sm1897907f8f.3.2025.11.19.16.15.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 16:15:31 -0800 (PST) From: Gustavo Luiz Duarte Date: Wed, 19 Nov 2025 16:14:52 -0800 Subject: [PATCH net-next v3 4/4] netconsole: Increase MAX_USERDATA_ITEMS Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-netconsole_dynamic_extradata-v3-4-497ac3191707@meta.com> References: <20251119-netconsole_dynamic_extradata-v3-0-497ac3191707@meta.com> In-Reply-To: <20251119-netconsole_dynamic_extradata-v3-0-497ac3191707@meta.com> To: Breno Leitao , Andre Carvalho , Simon Horman , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Gustavo Luiz Duarte X-Mailer: b4 0.13.0 Increase MAX_USERDATA_ITEMS from 16 to 256 entries now that the userdata buffer is allocated dynamically. The previous limit of 16 was necessary because the buffer was statically allocated for all targets. With dynamic allocation, we can support more entries without wasting memory on targets that don't use userdata. This allows users to attach more metadata to their netconsole messages, which is useful for complex debugging and logging scenarios. Also update the testcase accordingly. Signed-off-by: Gustavo Luiz Duarte Reviewed-by: Breno Leitao --- drivers/net/netconsole.c | 2 +- tools/testing/selftests/drivers/net/netcons_overflow.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 0b350f82d9156..9cb4dfc242f5f 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -50,7 +50,7 @@ MODULE_LICENSE("GPL"); /* The number 3 comes from userdata entry format characters (' ', '=3D', '= \n') */ #define MAX_EXTRADATA_NAME_LEN (MAX_EXTRADATA_ENTRY_LEN - \ MAX_EXTRADATA_VALUE_LEN - 3) -#define MAX_USERDATA_ITEMS 16 +#define MAX_USERDATA_ITEMS 256 #define MAX_PRINT_CHUNK 1000 =20 static char config[MAX_PARAM_LENGTH]; diff --git a/tools/testing/selftests/drivers/net/netcons_overflow.sh b/tool= s/testing/selftests/drivers/net/netcons_overflow.sh index 29bad56448a24..06089643b7716 100755 --- a/tools/testing/selftests/drivers/net/netcons_overflow.sh +++ b/tools/testing/selftests/drivers/net/netcons_overflow.sh @@ -15,7 +15,7 @@ SCRIPTDIR=3D$(dirname "$(readlink -e "${BASH_SOURCE[0]}")= ") =20 source "${SCRIPTDIR}"/lib/sh/lib_netcons.sh # This is coming from netconsole code. Check for it in drivers/net/netcons= ole.c -MAX_USERDATA_ITEMS=3D16 +MAX_USERDATA_ITEMS=3D256 =20 # Function to create userdata entries function create_userdata_max_entries() { --=20 2.47.3