From nobody Tue Dec 2 02:29:11 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BA7B36CE15 for ; Wed, 19 Nov 2025 16:18:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763569110; cv=none; b=IBtV0w89Wh6dwgPUBrX4RgE14JFfE8HImiyZrFoEqpcBNjOPSlw9Z0T4dZu61cUrmVi398yW6tGoDH7TV+LoYOc7e+KYZXyGdOrstyV0H6yZ8TvnUxvnSTFX35UGL+iP70mneQXMuIVto4i0G7qbbkiykWaUZozrvk9ej9BKTlc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763569110; c=relaxed/simple; bh=TNcEQrNzvvULvrZwY1bi1KT31/DfIBlyOCzRtRN9s5s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qWe6O+knl+8mRBCYxJ1ZTgehIDjb6e5sphhlbdzDLBeHLy+TpKy/UJTxsphYBl2wgUg2V4StEXDMVX6bHs4pGwQeDDPrec7CN8i/LUaedTeWuz3HOkw1k7KVjzgic2HVJVmtLrrcjOqUCsvfs2Reld2z1Y81n2YOfpSPEsBVi98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hYNBGJIJ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hYNBGJIJ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso18230545e9.1 for ; Wed, 19 Nov 2025 08:18:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763569107; x=1764173907; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tm65IZSOvcLW22I95NQ1DesGTVpSHNfrfkgnxYh1pRw=; b=hYNBGJIJECxC/TAbaTduMZf/SDNBavclDjlt5/Kw+H2aytvzAxhAfniyGD/E6OHtZq HPs0X0c+8tpZBjXHeMNopNuwSH8JV7OD7zzrgAH8KD8q12lqQ0OcW/f8miz7NnXrIMEG nFZWWkvkwXMeFWO2Rr6pEaxepn0UvlvIvGkCor1E1xSYE9lpn8YWNJEOzSwa6w1zqrv+ j0jwYOsKbp9W9y9T6oM9KLDxon0W0x26XEx/bDAnb3cBF6bA1dNzmAk+eTBfowgF0kOw 5iLfjURiXL5ay818UG9E/sFSc6XAK1rHZesGJBWVcdqc9kL/h7ZLv+smN/bhrpUC9BKD lnRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763569107; x=1764173907; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tm65IZSOvcLW22I95NQ1DesGTVpSHNfrfkgnxYh1pRw=; b=afI0dBQ51SGtqazSGGDlCXQzwZOc8ZCFJUh0vZI+NKZ886NT/FJPNeWWrQTpODPBWJ jBSFytfVhmIfL7qUrwXyJcg02tkVE2zM+uVdq4mYelp+XrZbjR3fSzu2SuEtB1ctvHVn uXcQTSdocebpFLDqfyfXXBhIu0554i4wx3DCSxZA8kV+MXAjwkUpUbBTfAcWaFw5/4cM Hr8QUpetPfpImkDPEgKpTJpnGdmaV1Ve6aZxZcQMxe4kpBA7WgJih25XjJal70iEWzBh LNwJEGnZSNoUZ4WmHrAsxlpkNVP7gXtjgfhzBxZFxiSA92mQSdIF0UueE93Z6KHwlv9a sbcA== X-Forwarded-Encrypted: i=1; AJvYcCUp9+Gll8VZsjXsQLDZlpWiYHYz2e9viyeew9TTfEc7Gnd8ZxnxhYORT+fG2tkbjRaOd5eBb2FDe15HSbY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3poWyM5IAKC6JFVyYd6V97siuh0Qrgt1VWi9dy6ZmiH24QhMj sPRiCwxw7fqOsKhs2cyT8CzFdervsOi7VS4nqJMFAw4MDyh95Q5SQnHF9/rCsbvmHHE= X-Gm-Gg: ASbGnctw21XCaSfRB0FfnT2rIsJ+6r1XRxBPDd2n4ozp4e3mamYOA/P7wiCuNeZjtu8 jpkUBA3jGqGrdSdxb1JlL8OtjV9/5ldp+juZ9rIsAjtnNeAQY2XtTwcvNhI4HbOAoS/qAyNPOPe HmQagSeoJm47U5xWxkue7EMJjUPA4CmRD+3mLl075YvyPjUGbY0P+EiqdVx0sT0iOU8YikEMxf3 gu7PXkxL9f24IHWTsthS5zn1JQKxYqQM/yKLZYN/E/RuEmd6lcTmJ5DFmSLkZ4E4H/5bAt+8ye/ Qi8JuYhrjY0lNrZ/EIZM8LU9HBWBiBZiMT6otHeElkBE6c0PXQrEAN775Y1eNQ+96H9BZR5dY+2 Bagc9J32hBKcwWNONqZgnoAGFLHhb7bNn+p6M5onGd4Vgqh2fOyjA0zs97DRMSfgwkBeVPOF1u7 sLYe2hBILdx3Pv05EDHqEV X-Google-Smtp-Source: AGHT+IFFA2/5WMyi43JL9wYl1E+HXHvpaVVjq0ooJOqK0iATycUimsaSxmDoPtbjIuyl7D1kIpWgmw== X-Received: by 2002:a05:600c:8b8a:b0:477:952d:fc11 with SMTP id 5b1f17b1804b1-47795418dcbmr192758345e9.16.1763569106515; Wed, 19 Nov 2025 08:18:26 -0800 (PST) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477b10142d3sm63205425e9.5.2025.11.19.08.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Nov 2025 08:18:26 -0800 (PST) From: James Clark Date: Wed, 19 Nov 2025 16:18:04 +0000 Subject: [PATCH v6 08/13] coresight: Interpret perf config with ATTR_CFG_GET_FLD() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-james-cs-syncfreq-v6-8-740d24a29e51@linaro.org> References: <20251119-james-cs-syncfreq-v6-0-740d24a29e51@linaro.org> In-Reply-To: <20251119-james-cs-syncfreq-v6-0-740d24a29e51@linaro.org> To: Suzuki K Poulose , Mike Leach , Alexander Shishkin , Jonathan Corbet , Leo Yan , Randy Dunlap Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 The "config:" string construction in format_attr_contextid_show() can be removed because it either showed the existing context1 or context2 formats which have already been generated, so can be called themselves. The other conversions are straightforward replacements. Signed-off-by: James Clark --- drivers/hwtracing/coresight/coresight-etm-perf.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwt= racing/coresight/coresight-etm-perf.c index bf4b105e0f41..3c8a6f795094 100644 --- a/drivers/hwtracing/coresight/coresight-etm-perf.c +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c @@ -77,10 +77,9 @@ static ssize_t format_attr_contextid_show(struct device = *dev, struct device_attribute *attr, char *page) { - int pid_fmt =3D ETM_OPT_CTXTID; - - pid_fmt =3D is_kernel_in_hyp_mode() ? ETM_OPT_CTXTID2 : ETM_OPT_CTXTID; - return sprintf(page, "config:%d\n", pid_fmt); + if (is_kernel_in_hyp_mode()) + return contextid2_show(dev, attr, page); + return contextid1_show(dev, attr, page); } =20 static struct device_attribute format_attr_contextid =3D @@ -319,7 +318,7 @@ static bool sinks_compatible(struct coresight_device *a, static void *etm_setup_aux(struct perf_event *event, void **pages, int nr_pages, bool overwrite) { - u32 id, cfg_hash; + u32 sink_hash, cfg_hash; int cpu =3D event->cpu; cpumask_t *mask; struct coresight_device *sink =3D NULL; @@ -332,13 +331,12 @@ static void *etm_setup_aux(struct perf_event *event, = void **pages, INIT_WORK(&event_data->work, free_event_data); =20 /* First get the selected sink from user space. */ - if (event->attr.config2 & GENMASK_ULL(31, 0)) { - id =3D (u32)event->attr.config2; - sink =3D user_sink =3D coresight_get_sink_by_id(id); - } + sink_hash =3D ATTR_CFG_GET_FLD(&event->attr, sinkid); + if (sink_hash) + sink =3D user_sink =3D coresight_get_sink_by_id(sink_hash); =20 /* check if user wants a coresight configuration selected */ - cfg_hash =3D (u32)((event->attr.config2 & GENMASK_ULL(63, 32)) >> 32); + cfg_hash =3D ATTR_CFG_GET_FLD(&event->attr, configid); if (cfg_hash) { if (cscfg_activate_config(cfg_hash)) goto err; --=20 2.34.1