From nobody Tue Dec 2 02:37:43 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010040.outbound.protection.outlook.com [52.101.84.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5CA12F7AC1; Wed, 19 Nov 2025 04:22:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526135; cv=fail; b=t7AUP4y3uQXU2x50jhdGEHZKybqPN/qaI4bPd+GPpFYoMyIDtpbemADrOn4flw8P+eEldF+ZfwhFMh/ppd7zXeSVcREdaYj+hZ1OxecTkAH0pXCfn5AvnrvUJuLOz9HZ/JtRjnRmn8nRgqea/ha7BwGYHaGn0zW9l3rmyOKZeKw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526135; c=relaxed/simple; bh=KeI567OKUvAlmPOT1KzJdpkec9P/E1kAZ+S2e1GFxZ4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=N9KqVKJ7LD3uTBhmTCPjvNua1SjC9XX94acoFWJ/o9mNvv8/NxwyXTkkHolNqxABRl+uXG1j2Qkl824S+Zb/d3Bt3eqCYWANkHsCOd8VykOf7ribsKwk4DBWisgo+GT9seKxImDRKZZefuXmvErZiO83EbaHI2DhAO9NhKFbO9A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=AFVcR5qC; arc=fail smtp.client-ip=52.101.84.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="AFVcR5qC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TZ+PpAbDcCa2mlx2CIMeDSlcG6iuLj7US6qdgw1spFEhOuPT2+8Y3VNFCxBlv/tGJRkUQcWIW/3JhxF23D71cmB8EhESEPqwoYxNGUFOkBkCJ17R0URSbn+E6Wv//yUtgCVEbBg60g0TdPrOg0EuEymsJ+RyUbXax7qBxCEpgVpIR+qMaSvDthJIO6ldi/UE45m7v/1PwDTu70RWiIjpOu3KFeHwzjEhj1KGWOMtMHLl4x8YfPsqFjxsw8GGna0WVx8qmdqJaacg9SY/QpnA2W5SG9R1Jz8d4C93kcnp898G+UUmSZ2+7JYcU+rQNg2RD/dJ6MxQ+PeVmh8dBGFwJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VrPgNiKvSX9jsS3EDBsOZuKIMOD/ncgnQkk6gizsFQ4=; b=hRLH4bWUD45PtLJRHfbquLQIPu6DNMJY6JL+vkWtlOvgbiaxXfsELSrXVTkuOxxBGJ5q1e9Vln+pvpskVdaOAGmIaWBGun3p/zUkuhNZK2ktkrkLTVaa5W45Y2jAGWsF7s50/JBFQVT2rjcHp/ec+GJIeJAoz6qOcI8oE3Npjyev9BwXxKOxgKErKuh7ZFYG9hZQcKlEUtgdpAwQdADiha8r3AMpqxiTuAHRdl0DqkxKXcR4lQYuhyTill06Mes6AlJm1E/lMNvJbufoAYHHkt2nnhuwbMkylAG5hPZFV83+O+k3MqE8eoCWT/i8ClegWqhGeI8m9BQ/tND8UwziGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VrPgNiKvSX9jsS3EDBsOZuKIMOD/ncgnQkk6gizsFQ4=; b=AFVcR5qCuyEKiIBloiLK6eWUHAX9fBsy9HhcoO4dwajZxx9jjk/bx55zjBmLZuDDNNSLQYO9ZWaED+Mer8V1E/TISgKqdGUtsLvii1SrOPHav+OjAVv6S+j3R9vjzFXtE6PUcDBOcU/XsabEQe4NusxrE4GwwD9yVX0AGNp9hvCnN+wFnvFgZiUbTpS+e5KWpS60dEdzLeKDKSv74bgs5IlEwUT7DhC8W6Ub9vb4A/jKIXEuquo58xnUDzspyIgpHe+bTC9j+NIS287Mt3gc5nqWUs2T8mbZpa879LGNMgTra1V5nvx37T8BbGebmCoYu4N/xTEBp7jX8VTEUe02SA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:07 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:07 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:46 +0800 Subject: [PATCH v4 01/12] remoteproc: imx_dsp_rproc: simplify power domain attach and error handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-1-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 471efa9d-e181-4647-e3d2-08de2723334f X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bitma0VRSFY3RTJBUk4rL3IvSWk1WUlmb1ZObGs4ZHYrWXVoRXh3cEhGY3Bs?= =?utf-8?B?NVI5cjZ0SkhCRm5KaGJDSnBlbU5ZYnFZZkphWDhvYXpyYWlFY2dPQ0NXWktt?= =?utf-8?B?WnJYWkdNNHVyMDl5RlpNbUthMVhVc1ZvY25uaTl1RnR1c2JqV1IvMGJBcHNI?= =?utf-8?B?QzZDNUl4a3R5bzcrcHN3SlNCalZnRVBGODhUZXl4dFFIVTBtTHh4eTN1VDNp?= =?utf-8?B?NXdXdVRSUDVMV2hOd09qL25lMVhhdEJobWJ6NkJHWC9CSXBBSk9KeVBkVGov?= =?utf-8?B?QS95QVdXSmJIZG1zcVRHSnFkWmY5ZXNuSXJFUlJJdXBXVU1xNmdhUG9rWDU1?= =?utf-8?B?YnhFR2xTOExoOE0rdEtzMzBiR0ZDY2VHOG1PQys3OC94bkV1T3owM3d4ZTYy?= =?utf-8?B?WCtuZE9udTZ3QzdxdUM4UXB0SzU5RnY2Q0poZ21odzNjWDhZczFmZ2ROUWtQ?= =?utf-8?B?RHF0Ny9FS0w3YUpUTWRYTUR3cVFMQW1UOEVpMmVsMituRGswRW5iZzNWUmcx?= =?utf-8?B?cEh6ZXZNYlZMWlZXRVRTdXVKNWFzV1lqdjlBODJEb2QyRTNJVlR3eEpncERH?= =?utf-8?B?ZEJoU2ZURWxKNGZrNTY4aWZqM1lmRkVQa0lYR3RHSUZoeGt1WUxpTXVCNGdY?= =?utf-8?B?eC94UzJUendKK0FCT2FmSnZEcHIzY2xTL3RhUDZvbE5KSnhheXNQdW5rWFJW?= =?utf-8?B?SlJIUHhYRVlNWGRHclRHZmRzU1h2SWlSc1dOVGpRb3BnQmJVa245TVVQdnE1?= =?utf-8?B?eEdENjRhbHNpUFhKUHBXQnlRZTllQjBoSUptU1lQdDJBV24yK0t6ZU11YkN0?= =?utf-8?B?UW9PcEtCTFc0dHRXNjEwNEo5b1U1YzNyWWxyd3UxQUhTaEw1UHkvUlVJNk1o?= =?utf-8?B?YW9QMFdxekt3bjVoSVFHOGNBNkxqcktoaXQ2Z0pEZkFZOUdkcStLTW1VQlJJ?= =?utf-8?B?SmZGNzJPU1NhUXo3Y3FNZ2hHSHFjRGJZTTAveTkyc1gvRWh3bllVNWpMM2xy?= =?utf-8?B?K0VCU01rUDJ6TDN2aVNMeFNvbGx5MyttOGtNWnVCT1VnVEYwTTFTVHI3Qlh5?= =?utf-8?B?ckZ6WFlPbUltdlhnTVB3ckNHdEVYU0FrYk9YVFVoVndxdDFKa0dKUWtKR0Qz?= =?utf-8?B?ckRzbk1GM0tLM0V2WURKYWVuc0lrZjVZNkN1SDBpSURsU0lWekl3TWFXMjcx?= =?utf-8?B?TmIzeE9GUjVyUlVlbThNaGptWklLaWZDbnBEM3pCOVlmZjRmQmdDZWw4TzVG?= =?utf-8?B?Q05KMWZYajRxM0JqeEF3bUJYSjhxaUZieEd0WkVYYWI3bncwN3BJRjQ2ZHFz?= =?utf-8?B?WEFEUm95RjFtUlZnWStmQ0Z3ajkraUNJZUFNL010V1I5aGF6ODR3STZBeFNK?= =?utf-8?B?WjBzYzlxSnVZZ3o0a1B5YWd2NWtFZEh6dmFyUWVjWFpxT1hyYTdBa0ZNRFRC?= =?utf-8?B?WHBjMW1JbThveXJWWVBRb29YMHY1SjBDVVFuVnFCRGpubkpLZXRScG82NWI5?= =?utf-8?B?QXBJM1B1TllmaGE1SUE4Vk5oT3dJd1hTTkFIeFZjcEFJYnpBUE5NZjFxeVZ4?= =?utf-8?B?Z0hELzhEN0t0MTBKaFBJUmVoZlZSZHZUVGduS1d3TlRwOEdYREhodmlja2Zw?= =?utf-8?B?ak93ZTdUdHovNWp4NzJXdGpjekRIYkNRR1l4SXkzN2NYdHRPMTZBd0xJK1dy?= =?utf-8?B?RjNPN2YwVkh3UXBuM2diR0h5aHpyUllxd3h6SExWNjRMY1JlMFd5dzM0MHIw?= =?utf-8?B?QS9NNE9uSmdWUTVXQzV1YmhZL0REWTR5Y3pkU2dibDJqc1V1dHhRQzVySlNo?= =?utf-8?B?NDdMemxFT2tWSlVQQUd0RVNLOGppMFhMbUR4YkJCY2ZpbWdNOEN4UUtmV3cv?= =?utf-8?B?VGdpNnZqd0g1QlozdzM2OG83TnlmNUViV1VDV1lRKzdNdURFZWoxWVJHYnBz?= =?utf-8?B?NkdTUHgrM04zdk1KRGNSYXZNTElxeVkzSm5lTVM4L3BTRGZZR08wdE40QU9p?= =?utf-8?B?eVBVSHFnNGNRdGVUalBHZ3REVi84YkREK0JtTkUyKzMrc29mOG1DRzBNQ2dk?= =?utf-8?B?d0JUd3RpYVo1czNDTXVNdXN0dFZwWWNlMlVRZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHRBZXc4RW5XT2NmK29PVHhWQTFvc3ZGK0JpRDZKTGVXMlVPVVlFVDZwYXdI?= =?utf-8?B?cHVSaFJpcnAvUVdtSmQvdHdtZjlJRUVZYVFxT1VxcVZCaGVpR291Yy9GRTJN?= =?utf-8?B?akVJUjJ0dFBmQjIwMVVwRzhhOFJ5Q2ROb2hPaVFhQ0E3alFNV0VPMnNHanA2?= =?utf-8?B?RVVPdVc1NFZ6bkgxbnBCN2NaRk1UVlNzdjEvOWRoN1BSUjFrWEY1bmE4akIr?= =?utf-8?B?aUhFeStPaHo0MTY1Q2tEWFppMHhvZFdWUi9wbGh3SWJGeEhlSnNRMTZWalBr?= =?utf-8?B?YkdOTmZBWjVFMmFaUW9rUDJkMnVQcXAyNkNXY0VrUVVaUWx4Tk1odWxQc1I3?= =?utf-8?B?T2JCVXEvS0E0MjI0WWZDY0l1WVBEM1h1QnZkOGt6MTIrQk9DbnB3TG9kNHFj?= =?utf-8?B?d2ovQU5Ya0crRW1tdHhaV0kzc1lKWlNpanBSZmZsYytWR3E2Q3lqaEJhZTV3?= =?utf-8?B?bXFHRWZXOE5DdmgwK3FHazR2akZCYzJBeTJ1NVpEell5UG1remg2YUNyTm15?= =?utf-8?B?Rm45WGlKWXo4b0ozZnRpU29nMzdFQktYZFJlcFAyZVhDREUySndqOTc2VWZF?= =?utf-8?B?bnoycGtqblFqb2pKNU04M1EvNWpwcjkxY1lVY21sNUt1ek5PV09GVnNFSjZD?= =?utf-8?B?WjBGOGZSbXNtZVB2UllBK3YybVNwWWdZT25DZm10WjN6VVdFdFk1UmdROVh3?= =?utf-8?B?SmFYNFJPRU1ZdFNndXkvNjVFVTN1T3I1SzVyR01aaFhoWk40eCt4czJGSGVF?= =?utf-8?B?Y0FGSUJYaHVnYnVuZFRDbVJwUEdLTzJGS0FNYWVTdG1xcFpBdGk0MkJNWlFh?= =?utf-8?B?Qlh2ZldLS0dBV0JqeHJJNDg0VzZWQ2dnVHJienNEYW1QSmxxWUxPMnJxVmhH?= =?utf-8?B?eWNVUElxb0s3VkhXZlNQQ0FrRm0yRmUxVTVlMW9VbUN3TytOMFdLU0RwMW9V?= =?utf-8?B?YzlXK20xZnB2bW9oYlpvRDRIMy9UNzBxYkV5Z0pPUEVTTUs5V1RXaU43Z1Bp?= =?utf-8?B?VDJlN2VmM0tRai9nTk9QVVBGOER0RDRNRklUb1VwTFFiY3YvSTY0MEVTWC82?= =?utf-8?B?Wk5NTzY4Y1ZadnNjRUxodVFFWG0rMDN1bEtxc3UvZkQycXdjQjluK3IwMFBE?= =?utf-8?B?L1czUVd5MlhOZWdQcUZwRDFaWmJtUUt2bmxzYkdxZ0FDNnNpZ2NzT2Y5WkN4?= =?utf-8?B?UTFiNFJ5R2lJTjZxMmhreU0yZ1BIVUpCSHUyb2RJNGZOSzdYcUdUTXdXOXBS?= =?utf-8?B?dGZSbU5wWnZEMVNsVHpJK0s5VHVSM0tNMU43TkpuLzhmMXAxVjVYcXlpOGpj?= =?utf-8?B?N21PQ0YvMDcyd3hlQTFqUHQ3L3NuWWVtQWJyc01TazhBQmxWVk5zeEJJanBV?= =?utf-8?B?NzZDRURUSGZDS1NiLzdVb0wyRm53Yk5HTmc3UWlScG45bjRwbHZIQ29ieVN6?= =?utf-8?B?cGt1OEZTUFlBRS82VzlaUW1xYmRsR0paVjZKS0JXaDBhbi9GKzYvL2ZMUW95?= =?utf-8?B?M0pPS01haUNMeDU1OFVrV1FzU0lwNDVxQ3JPVExWVzNxYUhGYVNwOVNBQk1p?= =?utf-8?B?SjZXYmJHRkRPeExJRTVONzFiSVEwZVdWUmxYdlFhUE1zMG9veUoxQkdHc2lq?= =?utf-8?B?eGR3b2NUL2ZORXpmQ1B0YXlSSTU3T1VJbzZNd2RZdjhCdEdENUx5UUg2L05P?= =?utf-8?B?b21jcmpRQTNXc0R5dHNSZ0lTZVNJRnA4THRLdlNlbDltMzYvNzRSdGZFb2U3?= =?utf-8?B?aFFXeUJ4blVLd0ZGc3R6amljTnhZUldrcEhqNVBWaXowZ2IwODFFdUVQTjJo?= =?utf-8?B?WnlqZFV1WDZ1alBrMUpib252eGsrRE9sdlpVZENrVkhkNHkzMmUrV2JoSDRr?= =?utf-8?B?WGhaTi8rTnk2cmhZWHg0WENHVVRDQldnUFZpU3VjM09zbDhXeGwrV0g1czBS?= =?utf-8?B?djhCbzdpbUVaakNHaEJZRWltOGFPS21vL3NLeGoxRUpyYkthSzR0RFdsZS9G?= =?utf-8?B?bXZTa0pkd3lpNjkzcTRyQ1ZTKzJoMi9kZ0ZlbFI0OHN0UW52TnM1eUxxU2dO?= =?utf-8?B?MGdLVHJPNUJsT3FQS0VwUkxlZng1RXUxQ0lqMDVnMmFTQ3htMFY3ZWZLNVdM?= =?utf-8?Q?rbKm9+lRIa3GIT4HYF9czni1i?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 471efa9d-e181-4647-e3d2-08de2723334f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:07.3389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M3dCdN8P3RfkCbGYIeGzdVmiR+mvZvYcjhaMxcwy6k08f6nlAkck0FDQ1awfi+a+oPhsGI7n8JLEjB0zWnlGRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Refactor imx_dsp_attach_pm_domains() to use devm_pm_domain_attach_list() directly, removing manual detach logic and simplifying resource management. Also replace verbose error handling in imx_dsp_rproc_probe() with dev_err_probe() for cleaner and more consistent error reporting. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 30 ++++++++---------------------- 1 file changed, 8 insertions(+), 22 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 6e78a01755c7bdc28cd93f00fe6f74affc3d96b0..1f7d15227ce4fad46ab4c6d7177= 4cf0560b9529e 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1062,14 +1062,12 @@ static const struct rproc_ops imx_dsp_rproc_ops =3D= { static int imx_dsp_attach_pm_domains(struct imx_dsp_rproc *priv) { struct device *dev =3D priv->rproc->dev.parent; - int ret; =20 /* A single PM domain is already attached. */ if (dev->pm_domain) return 0; =20 - ret =3D dev_pm_domain_attach_list(dev, NULL, &priv->pd_list); - return ret < 0 ? ret : 0; + return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 /** @@ -1186,45 +1184,33 @@ static int imx_dsp_rproc_probe(struct platform_devi= ce *pdev) =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_attach_pm_domains\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "failed on imx_dsp_attach_pm_domains\n"); + /* Get clocks */ ret =3D imx_dsp_rproc_clk_get(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_clk_get\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_clk_get\n"); =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; ret =3D rproc_add(rproc); - if (ret) { - dev_err(dev, "rproc_add failed\n"); - goto err_detach_domains; - } + if (ret) + return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 pm_runtime_enable(dev); =20 return 0; - -err_detach_domains: - dev_pm_domain_detach_list(priv->pd_list); - - return ret; } =20 static void imx_dsp_rproc_remove(struct platform_device *pdev) { struct rproc *rproc =3D platform_get_drvdata(pdev); - struct imx_dsp_rproc *priv =3D rproc->priv; =20 pm_runtime_disable(&pdev->dev); rproc_del(rproc); - dev_pm_domain_detach_list(priv->pd_list); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010040.outbound.protection.outlook.com [52.101.84.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41BD52F60D8; Wed, 19 Nov 2025 04:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526137; cv=fail; b=N8e8/6iO8lZG+GDZ+za0TidZJiAxUxs3cCnb7E+MarDx2x4WouEttWYFKC88Rh54RWLWSzA30gNei61Z3IlaJNbivkHgXRFD0mxIFPQudqOMuU30UtzgkTg7iVolKscHJfesAvTaKVwUBWerSY4y8ExIj7/0XjwdQO2oIVNi+2s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526137; c=relaxed/simple; bh=Vhuis2mToNrchHcktbwpXyjtMrhNLfRhe1IY8rr5nG0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UfOM+ShSQtPGVFwHwar854NBqwSLNJjpYqkX2OrfQcZmaUDW7huFZT61SbtkB+YschG+6H4o5loM+O3Dlx1+Qjv389KnXkHTRfiC9bHVMg6yXLGUmerOKUdbBuRjTwfO/cZJpPwE6XJdsCi/nRCGQ3HoT/uyiMEQFlYmrMzvluM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=b3euZhiI; arc=fail smtp.client-ip=52.101.84.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="b3euZhiI" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XL/uEwLw8yB7RFVh5rHU7C2q0VQWhzNGbVHwutQ52asnVK+1CyBdMN7B4+h0EYZtFoBzyHamNnhWLikqtsKQmc0AWDpNwfxFNtYmllKbXCwd6PjnS4dfRpB3NSeFW2uor2VZVRGYhl1DUd6dT22FacYOpcE/0oN/pCe/kfI9HKfhXHUH6tqLLBAscnEbqfQJ42LW5GT4DBP3Z9Ke3pPV2YcWxW0ibWEyoYFeF++uEVbhg7hkXa+gQau+fXFCJ8J8Otlvt8RAyK/10uPaEaK0AqvYrmmJeWAZ6HhlBl9yucTdgD8NftWX+WtsBAEq968350fzJsqnyHwr/8Pvr5njHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eaJ+k/bAIClz7A3WiwX6LJBZCtuZ9IDwbtZNSR+mmgM=; b=oxLg6iYeEHxFJy4Ve90K7I7wBB9yUZTbLWK/uEE3ffPyowX6R91/G0d9NYpQA+ALDPKOw7zDW/qQe2sL+aRBXluYSClFWP0TF8AHdctzkXwY9Cr1FRKpin6895HyanmFIpfJh6N4zLAHXCsXn/xS5rjsHUKOz+lKwiqQp9Ox6Bsxdv8vNMI5vw7yGiATAUFHUUCZU7bsukN0TuAtWYOtwQ7RcuNkZ2/yAmR3i74/yZDTWpepSV3aAp4VL0KT6LmTtsBjdaY7NoPJACt4ciJUac1rn0UXH0wkZx9RVFv2JQt2uAZtI17pGSJxMhk0r5bPCoJ1w6VWgyD+3aPY7DvgGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eaJ+k/bAIClz7A3WiwX6LJBZCtuZ9IDwbtZNSR+mmgM=; b=b3euZhiIraacIXtc6uwECsOujolQOzPvCyLctB+H+hhCm1sBNE9lbjtU4JDCZjF/xspTVv5enWZ2N8ss/fs8NIvs5TMnRgqw27WcbJ7ToAInPL1P2Fk+OTC5jvA3Rpgnbpdvlmj3gIqxsBW356Hoo5taGjvivgReLN5dIjgRFLYb2ypvXdkVhXdQN+ic24WJqQRL7sd+5fKeq0kVnSZABqajqRgYIGPPYxiK7MtV1yzyg3EhDb8JLvB/8HIxVPZ68U23aCTVe1sZnvLOTxokO0Mt50w4a0SADVDVIn5G0csDga9wT+58wyvkPJmucEHsbo+yisSv93FlP1zqcqlwgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:12 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:12 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:47 +0800 Subject: [PATCH v4 02/12] remoteproc: imx_dsp_rproc: Use devm_rproc_add() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-2-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d20f972-9258-440e-fe42-08de27233611 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?UGFaVE9zWmEyaHp6dmdkSjhUbVZLWktmcGJDWUN0UC9zTm9rZ0UxYXF6ZEQ3?= =?utf-8?B?Z2RGekNFcW15S3V1NFNKKzlib0VCTVV2YWhUUWFRKzREVGhBV3lBbk96a0ht?= =?utf-8?B?VjcxTXpHQ1pwTUhCQzZPMzZGNXJQb2xWNkxKWGZBajIrYWZYVTNaOTV2OHpo?= =?utf-8?B?ZGdVVDlGaC9JdEdhdjBTY3ZmTTBQUlVMSzBvOW5pRzNzTWptTi9JY29MQzFm?= =?utf-8?B?Q3BzZndDemZUem9BY2R5YzhjVFAxSWdNQzJTbFNlWU5Tb0FKbFdSRkJGMDYr?= =?utf-8?B?dkQ0cHh1b3JLN1RCTzV2UkZvYVhFWmVaUFNNZWZpUU5ERHFqclU3Q1RocTQw?= =?utf-8?B?M3ZKS3h1bUZJR3FxK3Q5aStLeXRXOFAyKzg2UTNwaWh2TWRwVm54b2swNkps?= =?utf-8?B?QkFselhib1lHODY5UTdseU50Y0tKbUlQaWU0QjFIblRJeVNuNElYOWwweG9l?= =?utf-8?B?WmlNZ2RYMll4T2gvNlBCTHZEdzdRYmp2NFI0M1lTcGJKYURXQXpWNHoxQWxa?= =?utf-8?B?eXo4SGo0clJRQ3YrK1RLTkhsUUFIR24wSm5zcTdvVkJhS1hLZ3pqdnJFZklP?= =?utf-8?B?UlZEc1dNU3k2N2NoaGFmMzA5U0RVRDlWaXFpWkpQWDlMellNT0h3cXk1eWU0?= =?utf-8?B?SFpKRFM3OTUweUJlcm9zQUZSS2wramVYakNIMzlFVXEweE4wNGNiN3hqL2lX?= =?utf-8?B?cWhMcVloTGhPei9XYnRYbUJHQnp1OENKNmFsOTRrMU9ITWEwZ0pEazVnd0Jk?= =?utf-8?B?R1ZCSTdvVnBYWVJQZGdaYWhnMCs0b3ZPUWY0RVdNRlNFbCtaNHJQUGt5a2lz?= =?utf-8?B?TEdzOElCN3Y1YTFYcGNpTGZ1M2p5VnFabXdjOVU0N2pNYnNla3orNFVYRzlJ?= =?utf-8?B?aUM2WEM5WUtrVVRIYk1TczRJVFpjYVFMNzFYbml2ZGxZcEFYR3NKRy9oaHd2?= =?utf-8?B?Q0tyRFdQZm90eDlxMzNGTm83TkFGNTR3NWFlQlRVRFZwd2pKaXFud2xORzZa?= =?utf-8?B?Q2M0aDdOUERXTFNPZmN6bG9YckNGMGRtSDRGQThtTkJsaU5UTUprWWVoNml1?= =?utf-8?B?enFrSzEyMmkzeG9vSG56MHNPNERwZHl5akVnUlNwWHl5RUFOREZOY3gxWUpu?= =?utf-8?B?YjUrSlYwb3c2Wm9ISWFMa21uT0xQVTd6TFh5NVl4WkNuckFpNGVqa3JQRnhl?= =?utf-8?B?V3Q2U1h0RTl4dHlnZ0dPTUNUMWREbnVKMU5sbjRXOWpCeWdCUU85R016TmdE?= =?utf-8?B?Y05OTStDTkZCN3JoOENkTmpZK1lOODJlNEhYWVJSYklpZ3RMWFJ4L2x3K2Zy?= =?utf-8?B?TmxzdnlYR0xNOURYNFJ6b2Rob3MrSDNkREFqR1R6L3JaSkV1RXdOZUNJTmR6?= =?utf-8?B?V2cvR1dzNWROcjRsTlB2OHdqdHBZamlnSjRqWFJENUp3NGRRMThwS2Yrc2t4?= =?utf-8?B?UGFSeGtURlZ0c2plNVJiUlhkZ09iU0htdC9NSFpwMzRxdkdGa1ZtY3JMV2JC?= =?utf-8?B?NnM3OVhsYU9KaElvVUFEM0hDekNYQ0R2Qm9neC9UNnhiQWdqbWZnbEFFbmRD?= =?utf-8?B?Y0tDa1VXVjJDTVc0czZRaFQ1ejlKUkVBYTluK2Rub1NLNFlaZXdpM3ZFUGtZ?= =?utf-8?B?VGluWUMyT1JLMS9XYkJjYnRhUk1jOG9lNW9nVVBDNUNqVzc5QUhIOGlnY3pP?= =?utf-8?B?N1cxVTJwdjVMTVJKRk5UM0tHTEh5TlQ0Si9YWjVLTVZtcUordHU4Y09VLzNz?= =?utf-8?B?L1pnUU84THhJWlhON2IrU3FneWxUb1Bzeko2S0Y2Ukw1dUNxanY1clcvR0Ji?= =?utf-8?B?TW5HdXh5d0ZFMUZDVlVnQ2toUWdESE9kNEJXTWRXVWlzbTFScHdNblVsVnJ0?= =?utf-8?B?ZjVvb01qOTlSeExQN2xkb0hnOFJQV3FobnpsaVo2SzNxTTJqR0NIZUswSkgv?= =?utf-8?B?ZUlENlIvK25UajlhdzZoNzFIemF3QVJLTitNYUdpTmdPWGRZWXZ1Z2xYN1Bs?= =?utf-8?B?cHp3K0pmNkxEVzZINVpwUVhvYSs1VFFFb2dSUlZGSmRJZDU5TmN3NTNTOFFy?= =?utf-8?B?dm05WFJubmlKeHF6ZDhXem5saGpyNTkzSEhiZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTFNOFhOWXozZEx3VXRjOXdBSXVjeHZ1OUFmZWlMeFVMdkYvN2VPQXI1bWhD?= =?utf-8?B?LzBYd3AzUFgrZnE3YTMvMElzbmIzNG1xU2kxdjBJeWJUYlNhcGdndzhuYUp2?= =?utf-8?B?SkQrcElOQjZidjIrMTExZDhlSUpobWpHUHF0TEdwTi9xcTBoRldnSkVUS3cx?= =?utf-8?B?ZVVpOVVPVU5mckNEV2FSRkRBY1FVc2pUUmVvWmRkOW5vWUNybjdMclR1Ym9F?= =?utf-8?B?NGtnQ1VoR0swOUNBbGtHeXUvd09FVGZXOUYrdTB3WTRKbkhyR1VMdmxWVGVW?= =?utf-8?B?UTJiRkUrY0l1dTBGUEVPcll0S2dFQytVSnNXYm1aK01MSnVkSS9XTzF2c1lp?= =?utf-8?B?bysrY1lHTUdkNzVuK1NUK2gvd09xQzJlTzNmbndpQmJvODRIVDJkcWpMeklB?= =?utf-8?B?bTVOR2xYeTUvajRIL3FuVC9VZjhpT2w2SGRLQnBkSlZBZDFTZExpcVJTUGxV?= =?utf-8?B?YlFmSWpuYlMrM0xVa1dWVUkwOC9lR3dTdEp1ekdsRzBnSW02MHcvYWpyVzd1?= =?utf-8?B?WGd0K1ZqQXhVUUxmV2dXazFhakZhR051Q0JQZUErbXhXYWlxM2RJY0d6b1pm?= =?utf-8?B?SWxqSHpCdi9EbVVFYUNDTjlXZ21LbSt0NkdtT0FBRjJyeDJiN2ZYZmk1Ni9P?= =?utf-8?B?SC9Wa2xTd3dPTitRU29BMXlsZFdnUG9UbWd5SGtpUS9RaUJVeHVrcnoxMS9v?= =?utf-8?B?bHJxWXZkL01Lekh3dEJIaUtMMm1DVmEzd2t5aW5UV3VBTVMxeHJRaVJCZEF4?= =?utf-8?B?Q094TlNXdlRPRnNpY29WNEdjNHd5ckZGd1BjQ2VSb1A4dmg0Ynk0aXdwcHF1?= =?utf-8?B?OEN2OGJ3NDRDVXhLbUpxZ00zWjhZYTVYdys5RnpXd3hHMFVtdHRUTDhxR2NJ?= =?utf-8?B?V2dQSFFJKzg3L0ZBRmkvME02dFVPVEJYWjRyYTJhWldjaVpoQ085eG5IWDRp?= =?utf-8?B?ei80a0x2dHVRTTFaMnBoRFFNVi9lQkdkV1BVdTg5M2hwM2tIdkJ5YUxrMXV5?= =?utf-8?B?RnJLWURVd2NGUE54bm5yUTR2OTZ4VFdvWk96Sy9ySG9lSDQ1SXRjVUk3UFRj?= =?utf-8?B?NzJqanhDbkJQZGExbSt3dUVCQ0kxTHVJOHBFK2xNckNheFdhb1ZkV2ZIWGl3?= =?utf-8?B?S3Y3bm9RQ1R4RTlsWGZaajNsSzAwUHVOVHhOMzVJR01OYUE5ZU84cHBZa1dQ?= =?utf-8?B?Rk5hU0dOczd0R3dYcDhkOS9NZFFBcUpxS0JHSnpzQ1V0MHorOWl4S1ByTnZN?= =?utf-8?B?WWw4V3hwdWVWZEVsQ1g1QndzeFdmU1BpN2JWdi83RGNEaHp2QlROaktGNzIw?= =?utf-8?B?Vjk3WktOZ1N4ckduZS9IUEtiaXpTdTJTNEVwTlRqZmtKK0d1a3BYTWRGUWRE?= =?utf-8?B?Z1Rmdm1UOHhrYU14K0xtV0swRWJMWW5xaklOdG1ocGk1UWE0MHppakV0b1NQ?= =?utf-8?B?S1RXQlBoU3hVSFZ6dWxIRm80UUVuTzVyWDFPZ01WZU9kM2E0OUtJVmhob2pp?= =?utf-8?B?T3VMSVo4RXhpQXQxd1NXUUlzSUtSYTROdlZmeXlncVZyRHRONXdabmxONDlR?= =?utf-8?B?WDZ3QUo2cDNhTXgwZFBVR2taWnFic1ZGR1V5dnYrT2d4TXBFSzl3bFBiK1k0?= =?utf-8?B?ekFsWmdzandpVkV6OFVFbllnNEN0YzhqaEg5NHVpR0c5Y3oyTUFJMEh2Wnp2?= =?utf-8?B?T0NlSXoxbjZQSTl4WHNYU1JZQzhoeEljNHB6Q3FsOUxTNHpUc0xraW14ODM2?= =?utf-8?B?b21nekFWUzc5YVRGaDZRVXNRR2cvT01nV3NybDZJcWJ6ZUJqaW5tcFpSdEpT?= =?utf-8?B?MUV1TFluK2EzWEh4ZWt1Mk4wOElVWjZtSzZSM1hxYkxEdUtMTmpjUTdvbllI?= =?utf-8?B?Tkk4SHNodEVFK0dscm5RMmROYkdBTjRoYUkwYUQ5eEFKQ05IN2diWS9IQjli?= =?utf-8?B?bFVJZWVRU3IyV3d2Z21HMWprcFowYnpQaEpvZG1FUHlZMzJNeVBITWxHaDdH?= =?utf-8?B?YmdOZ1R5b1RUajFYYlpDaU14M1VwY0RmTkI2amZic2dleVlISE9xa05sc1V5?= =?utf-8?B?MWhhdFgrQTA1eE9SaTN5Q3RCOWpGNEhVOTB4SXhUcEF2aWZ4TTM3R3RWeHpu?= =?utf-8?Q?XwN1kUweLODS2+aAhjXog1pMF?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d20f972-9258-440e-fe42-08de27233611 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:11.9027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g9LxfSZdSLqspaEwxhmD2NQorGYgt3k3XG5cB9B0lbWIBHmAtG58TVmzKcW6iCR7fhJ0XlbKMbY2VEUsCQuonw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Replace manual rproc_add() and cleanup logic with devm_rproc_add(), which ties the remoteproc lifecycle to the device's lifecycle. This simplifies error handling and ensures proper cleanup. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 1f7d15227ce4fad46ab4c6d71774cf0560b9529e..418bd3ac70a4aa294b89c5d646a= 89e4da5ad2c35 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1194,7 +1194,7 @@ static int imx_dsp_rproc_probe(struct platform_device= *pdev) =20 init_completion(&priv->pm_comp); rproc->auto_boot =3D false; - ret =3D rproc_add(rproc); + ret =3D devm_rproc_add(dev, rproc); if (ret) return dev_err_probe(dev, ret, "rproc_add failed\n"); =20 @@ -1207,10 +1207,7 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) =20 static void imx_dsp_rproc_remove(struct platform_device *pdev) { - struct rproc *rproc =3D platform_get_drvdata(pdev); - pm_runtime_disable(&pdev->dev); - rproc_del(rproc); } =20 /* pm runtime functions */ --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11010044.outbound.protection.outlook.com [52.101.84.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E3392FB99C; Wed, 19 Nov 2025 04:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.84.44 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526141; cv=fail; b=K3bsSgJjNlLPGS+QIxPRPsEGx2cFm0BXRk+fEf5WuM+2/qbvZmeiRiivFp+QdKr7jwVWsJWX+uQh2K00xDkh/ObauAFiq5Qo1CbUgvWgvcRMLyWXGnU9Hovpi8bOVYN6M8zXA+IUdnFW0VrGB4tLAv/JBgE3nzRYxyZxrrCTZWQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526141; c=relaxed/simple; bh=MgXsFBwAXtEnkDjCeFNXntHYYKuCev1DCwCB/glEwtw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=MISaKXOYAn4apT1mU5sMrObJITJwWCHVV40ps3irkMWsOlLV9QXJcDnHFfslM3aS7ixKXyvq0FbRiTpOH9inqnZF2t+2N+B1696VClMEvvrloC0gDXRhooLMGC41npc1XeyciRccj1y7GBsukUuexVRjPXmWi7Vr7O2tzHTIQXU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Hu/0wOz6; arc=fail smtp.client-ip=52.101.84.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Hu/0wOz6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gPxNAJQ3ffH17X/DBrkH/2ApBw4hMDOt5pfec0VcyYBiXEDValgdhan43I+jgEdwX9B0mC1R9oc5Ic/yly+aR0RRCg7kecbebwoMQwPE3V7t4jz4HGUY8FUNHRkykPL8NywImbISpm55FD0vD6TIRUuns91hlBTLSQjsFOOSIBD4qKBsjKsXWYo1UgJCxkZGN9RCWD3rmHTWfUDHjhqHpsujGQ5iOY94Fx7y6zyd1cuFgReY/T5q2glF6ZDTFgRp6RDPE9hTaT1166jOWGmDDT1wVzAaLIcrOTEfHcp8j8MPfgg5t4wshe3nialMqQx9IfRYpGzWcT9yUTFWrgbzew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wu+O5LbRRHVB5lna9JDhXW/lbLEYPcYkle6TCANR8hY=; b=Ok5NXQRiM2TUXtpxuPg3/OAWo1LpB9QDOOCqjjb47cii2j04nUVFaimx4WHwz/GzJlRmNib1rEEUVQe6URQPbPtjpoDSVwLi0FckiGD6VmbBhoPfGZLwAWw7z+wxqjstlgiMN+tJR6YjbNanDEC39tHVL6gIqbzBi+fIlsqWXnF8SkhkbTEIGjH29FRDoOHryOo+Jq0PdTGiGuUuHe5+w9kgT3+sB9VsXgN0dIkbpqUQt9XKK8ZtEVic8EfBQkX6cDj/muqLoFBkfN2U7U8zXb9lKl17OlYETsqOAYyxaJhUwBbcYaubgbvpCciXedcXiLh7IsNLS6oFPTpU5ybhng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wu+O5LbRRHVB5lna9JDhXW/lbLEYPcYkle6TCANR8hY=; b=Hu/0wOz6tKUqpRVuVKpBtpftoa0oGkJcPZPlgmeCGb9yuZOPhjY8s9qYlvwr6X7ZiL+jmIYUupiaaP8QWKwVVm2eI+J8UM4eI01IGw8khOyXFdteGkMfSi8LyIZlBaJvE7a+DdxETsXedfHljoF2pwh/9wPncConf39C8kVgJexIhC6sB2VDjd8DB9bYo6e1VB/aIVBeE4qV9J2dNt6gBFcVFB3j2Di2s9xt9F7Z775C0g9lBiA/wQXVYd1yvuPg4+kTKud4j+XgRIJsplzl5eqQvzLk6GRTW2+56baRNnPKL38T+UHe++ql9JwmTx0KAvyzZ8BzfaEDAhS8dbzJ+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:16 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:16 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:48 +0800 Subject: [PATCH v4 03/12] remoteproc: imx_dsp_rproc: Use devm_pm_runtime_enable() helper Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-3-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: a0899237-34ad-4e61-aaa0-08de272338c7 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VVN5Vlo0NjhhbFJqOTlIckFDbzNOdzhNTWYyTVNIMmVBcHpCNUNBeVJQTkRX?= =?utf-8?B?UTBlUkJoRjF2dE1iNTJOMk9YMjkwL3FkNnpGYjVPQlNSbjJLZE5CS0pGVmR4?= =?utf-8?B?QlRyREF0M2tZRFhVM0RsdmM3VXRqd0hzcTNLV2MyK0dITWRjbmR2RXE2a0Ew?= =?utf-8?B?djU4Qm1yUFllTGs1enZKZlRTSFJVbWhBZlNRa0kyUFcrRFBCSGRHOGNaSVVZ?= =?utf-8?B?emFLVC9qcVpxNk9XUkdDVmtrVndVcXd1cTRmY1VjZnZsT04zL3R1MEVTR2VZ?= =?utf-8?B?dEptcTYwQXU0QmwyV1JPOTlyMkdkQ3ZGUloycVB3OHF1ZnIvN016N0RmVVlE?= =?utf-8?B?cm5WN2VBZXFNUE5qNk1ZUXVqOFk0S1ZjRVg4U3U5NFRjbDYwb2lOMEppVmlK?= =?utf-8?B?QzlmWlhja1psdWQyN2twUlR0dkJyOGFLZW1WUVo0RGdVOHNIeVlIS1JNTWFh?= =?utf-8?B?VWtUUk5ocElzd2ZSL1ZPSEI1WFVtT3FtK0w3R2Nwd25STmxURWpqSzlJM0Zt?= =?utf-8?B?NlBtM3hDcUNBaFlSMHlmeFpvRFBlMmpuTUw3N2dGZ0paY0tOS2NBSVkxL3Vo?= =?utf-8?B?OXFIUzZOejJyWUhhZUtFTUZLSk9CRnZqQnYvMFNCMmZ0YW1YWkVEcWt5b2Iv?= =?utf-8?B?dDBEd0hCQ1p5Q3dXUmkzVG4wWFpyL0Ztblk1RHZpbnI2d01yamZxYVhUSWdU?= =?utf-8?B?VmJpRmthcU5YWTZJK0xqWHZyQXVnbkhOV29vVlZicHZFSHZkUHNZZGpQQVlu?= =?utf-8?B?N1lwekFtMjhSQWYveDY4dk5TTmV0TEFXZjdLWThuMnB6M29qMlVFUm01cjJi?= =?utf-8?B?N2UwNlQyQitIUFI5T3FSZXpNS0JGbW93cjRVdHAvU1NTM1JqQlZ6cDAvc0sv?= =?utf-8?B?c2k3TjhvVmxHOEgwMy9mWEc4SmMyK0hJbld6eFo0a3doWXRVazVRUVNycjBU?= =?utf-8?B?WTF6LzVYNTZ2SDZmL0NDMkFLRG9BeEl2M0E5QmlvVTJlSzN4bnpIMkJhYkQ3?= =?utf-8?B?MHQyaE5BQWxjL3JZSElCeVczNjlZNW91aFhEQ1RxK0hNZ3pvN001NFl1UU0w?= =?utf-8?B?ZXgySWNWc1RBdm1YbFFBR1BCTWlzb3d0M3hjWVZlYTRMdSt6N1BacktGa1dX?= =?utf-8?B?U3QxTUxnWEFmUVJTSFJpZDV6OWVJajhYZXAyVnd3Z1psV2RLYnRGUHkwY2ZZ?= =?utf-8?B?cEdqaXU0aFhJSG5HNjIybXF5VXRZOHN5OFoxaUh0L1hnWnZ2TThqRFNnaVJQ?= =?utf-8?B?dHB2VGVkdzdyNnE0di93Q2xmRk4yaVVxWXM2bDFrREJCaWRmYzlJMFpOL3Y2?= =?utf-8?B?UVQ5dzF0bndydTlSWmNpanNRWW4yRE5idXpOVTh4RGlwcWJVUGpuZHBlNmN6?= =?utf-8?B?NUtSNmhtNURhemFCdUtVVGMrNmZZY0hscEd3WmNIRGtVM29qb1FIbHB2d0RF?= =?utf-8?B?VWI3b1grYXdSSlR1M01IOTRuTERUREdvRTZOOU1vNlZjUGlmemVoKzk2eEZD?= =?utf-8?B?c3pYSVhNb2UrWnBscEYzUGlXclZWZmlBU0xlZEdWd2IxTHFnL0FhTEcvc1BJ?= =?utf-8?B?ZnptRmRHcGVGZHhIVEJpTm9Hb001RlpPRkl5YjI1bDZPK05HNjVvMjQ3Vkd2?= =?utf-8?B?dXZXUFlCQktmdm8xSWNSYm4wNTV0bWRIbWROR0xVSFNqMXV6VHd3blgyay9O?= =?utf-8?B?MFg4VHR2MkZLTkVFbWhsT0JQS2tEeDVsSHZZbm5VaUFzV2w1bXgycXkxMXBF?= =?utf-8?B?VlZWN0o2TGN5QUovVGdGTEVBZWZBbThXaUtXOCswdjVaVEpPMW4xZk9YaEwy?= =?utf-8?B?ak4zUHdFS25HQXRsVVRQUGh3OUlkS1duZVFRQ3Jtb1RZeXlXOTIyQjhCYytj?= =?utf-8?B?cVJ4NWtMdnpHZU9qTm1UUzdiY1pGdXkxTjg1RmVOOXExT1ZlV2ZlbWFzUjFq?= =?utf-8?B?NDN2NkZJaFI4OStsTlJNWkRPYUozYWJrMm9raVNPT0N2bURvczJwanQ5Tmg0?= =?utf-8?B?WjlGczRLbzhxUVh3aG9oOFZTU05XSjkzUDNySitCbkdEMklyb1FVa1JYV2dB?= =?utf-8?B?UnBqYnV6c1FGcTlJVElJUnN5WlVaVk9KR2ZlZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2lLbVBFeEplcEgrendGTDBTUG9yZ1VocnpGVjdxeFpCM1FNbkNodnV6WUJX?= =?utf-8?B?OVRjaWlZcUQ0OEl0LzJVb0ZnVm9VeU5ROUVacG5kc2NzRGQrRDFVSy9tQnVs?= =?utf-8?B?d05PbnBXVVhqRTJzaTNVczRQbkdFQ2ltNXYxNU9BM3V2d1lBVUJzZXhjckdi?= =?utf-8?B?bFNURXRtcGhVTTBKa2FVc3l0MWU5SGF2Y3FNNFRMamU4WEN3MnRYaGt6NEdu?= =?utf-8?B?OVRWaHJGTUViMjNqUjAzRFBDU3dmMzk5bFp3WjU1TDdkOGhpTTMzVFg2UndD?= =?utf-8?B?OXdkLzZleE9GaFcwR0U1UnJoSXpqclNsbTFIcERrbWZ0V0c0UFgwQWFvb2JP?= =?utf-8?B?MGEwMkpJcTd1dGxzNmRQMjZLL2NIT2Q1R3lvbjRqNXlJRE9ieGhIOEVDNzR0?= =?utf-8?B?OWUzWXRBem1tTVMzcU14TmZYWnBzaklqeVcwMkFvV0pyKythekRkdU0zRXVs?= =?utf-8?B?YXdRUTZVSWVOWmU1U2xFeCtjSU5wQzZQVnB4UXdjRndHZTFkZUJ5S0tsQUVB?= =?utf-8?B?VngvWXNCakNwc3o4QUhJNWxxYk5ZTWdHc25tdDFybW9aaGd2dWJkNzNTSnJR?= =?utf-8?B?UGNUUHhNNndvYmwzd2JwcVlHeVVVYlpKOTBjQ3h5ZnpxVGdQYUpmRWMzS2RU?= =?utf-8?B?dlRhOG1XOWtMekJlVmRTc3ZCd2hhV1lKbUdFK3UwbG41Z2JtcDB5MkV5eFVi?= =?utf-8?B?dFNDVktrT1Vobi9DV3MzN3R4YVIvWDVoSGUvT0lueXFhVm9pZS9KajZENDEx?= =?utf-8?B?cFJmZWd4ZWEvdTNSNytBT0Rjdk85MDFxUjVTUUFIenZUV3ZXNWt2RFZxRjQ1?= =?utf-8?B?Q01YUkpNcENYTy85eDBMWXl2dkZrUjdJWGhhM0c0RURkbE9hZitnOFBQb0VI?= =?utf-8?B?azZJdnJ2SDE4alpVcGt3dU1RV1BWejlFdFA2b0phVk15QzFTdEtoMDlSUFpi?= =?utf-8?B?Y1h0MXh1bmF0T0xzQjJzODB5R3ozTkVRV0Y4dlF1TXhqOUhlZVBSeDJQcGtH?= =?utf-8?B?N3NXUUJJNlFOSU1abVJTTStTczJNMDNxOTRVY1FjSmcrL2YzTUVCSzdiOFdT?= =?utf-8?B?UlBPWFJKUElvZEZPWHdiTGZpcVZFbGttYnZoV2UyR3l2dlJ1WGpzWlVKRFIy?= =?utf-8?B?VjMweHJNd0I0TlJVbWc2TkdCcHRUSFBCUU9UT1ZLbUZ4Ymp1VEc5ZkRNQ2JO?= =?utf-8?B?WjkvL3hiTGhiUkRrMUVWMStYOFcrWjlTbHBUc0tVSUdxeTVlcG9HMXpqQ1d6?= =?utf-8?B?K05RYitmVGxOK1NJY2V0QTl4WHd1WW1XcTN6TER0N000QW15MkIzYmtJemVV?= =?utf-8?B?THF5N1E4U3FCN2QxZFh3Uzg3Q01nMFc3QUpGVUJYdS8xTmkwWlhiQW15UGZo?= =?utf-8?B?VmJNcGc1MFRHZ3k2VEEyOHZpeFoycnRpQ0N3M3lnbUJmOW1lM3JPOC9IWldo?= =?utf-8?B?OExYcndVeVJDTnFCODFVSSt3UW5PM0habURYVUljVnN3eXNjYU5PRHA4K1ll?= =?utf-8?B?bjZ3R2VtK0lHSU1nZ2VlMFJOSVNqcFlvOU0yWFhCYWhHVmZ0S0FNdS9XMmJw?= =?utf-8?B?QktBTDZTWHJFbENmNkROalduVE9tWEQ2M3NRQ1ZqWkI2ZHJsSUYxOFVMa2F1?= =?utf-8?B?Ym4wWTBzd0FYcTRZbEdFM2xRUjJEbUpvclNDK1JnSmlRY0RUMkovRnhwaHlp?= =?utf-8?B?V2hNN09pRjVnckZRN1VEaDVlREhFM0lNL1hqVnpibHpQWmNyNjdhSmhjZ3Qz?= =?utf-8?B?clBQVHFmbEFTbUZFUTFweTBpTnFoYVB0dVdyS1pGYWUrd2piVXpZWkcyRGFZ?= =?utf-8?B?VGNRN0pDaGU5WDJpRzNHV0trL1hXM0ZFc29vTnpMWjlReUtGNy9mR0wvOHYy?= =?utf-8?B?SzQ4UHhkc2gvSlRoNjNuZ0VDQ2IvcHZoTVBCTW1XYWlGWi9nNkwxM2RxWERi?= =?utf-8?B?QzhKaWZTZkc4YnpHZjhnTTZNbnZIbTNTMERDbExSL0VDSFVCdTJIMHNVNy9l?= =?utf-8?B?a0g0dThGR3EyMzJjNE95Z01DOGs2TEUxdEhDOGdRSHgzL3Jab1Z0QzRzMnBI?= =?utf-8?B?L05wL1pZc3E1Y3RaTFhycjVTUERRd3pkcTcwOUFOcEtFYUhFbmQ3b0VkMWUx?= =?utf-8?Q?NnjYMLUu/a63UCVQOvM7ggPnF?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0899237-34ad-4e61-aaa0-08de272338c7 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:16.5196 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cdm/IUrjGP6JR3UTObAyezJyDCnLizPUGsui/T9YVp1O+OxhFMi6M5CDYDu0Dhirw+9/OqghwCOaJqcIQe7pdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Current code on the cleanup path just disables runtime PM for a device. Using resource managed version devm_pm_runtime_enable() registers a cleanup callback that sets autosuspend to false and then disables runtime PM for a device. So, basically the same functionality as we don't use autosuspend anyway. As a result, the .remove callback is no longer needed, reducing boilerplate code. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 418bd3ac70a4aa294b89c5d646a89e4da5ad2c35..f5d0aec52c56664d6074272e276= edb0c4175c9ea 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1200,14 +1200,7 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) =20 rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_XTENSA); =20 - pm_runtime_enable(dev); - - return 0; -} - -static void imx_dsp_rproc_remove(struct platform_device *pdev) -{ - pm_runtime_disable(&pdev->dev); + return devm_pm_runtime_enable(dev); } =20 /* pm runtime functions */ @@ -1358,7 +1351,6 @@ MODULE_DEVICE_TABLE(of, imx_dsp_rproc_of_match); =20 static struct platform_driver imx_dsp_rproc_driver =3D { .probe =3D imx_dsp_rproc_probe, - .remove =3D imx_dsp_rproc_remove, .driver =3D { .name =3D "imx-dsp-rproc", .of_match_table =3D imx_dsp_rproc_of_match, --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011054.outbound.protection.outlook.com [40.107.130.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC094503B; Wed, 19 Nov 2025 04:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526146; cv=fail; b=TZ8B0K56khaJIKU7iuAFNu8+enttsmMx6vVzcnBgA4E6ZKAsuS0pUtfJEyXNWMR3WcPILCMAc6g0ElPsO9FL2ShN/wDzGR8jy/4ibpB/tCq1+vggmph/roGVWrfgTuDl4UYP+b6msNN2P/SzceRUVVG1XXaZ9lGlBPmcEO1xPaw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526146; c=relaxed/simple; bh=Vqrh/03oImNJGbrVYfSWncHfRMjM3jNhUlrxDZUXCH8=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=LM2bFcU7OsKbmStsR0e8uNACTOxliMIOrSkAL65WjGmCSzd8H+ra25DHanW37+jck+WODv2XCROTim9Ywl8FTInxdtZQgy6KvfNh8BE80RqRDzLsQSU9ItbI/UaFKXmbWoCu08oMiqjJ1jCrOlUccAsaQAZaqgvDav0JlUKjENM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=GjLXUrVw; arc=fail smtp.client-ip=40.107.130.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="GjLXUrVw" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KMVKa5QKhvDDNGc2TT8NBl0rSAvjeMOCG7KLfL9sAGtVSHHOtp7L8ErnH4/+BkGEpZW48e46yaKj9PmSSQBtXIbgRqir7Pu3U4YajKtDSlEagDTxS+JuD41RwALiMMAFdlwkpKVpDMnwvPVWkAoZ5lJtBkOBfcgLYW5qwY1IGYNZgq0CX0hxroyC++u4R3PxulUAoIAwtW7ZJXKJrn+qNkOdEPKH4jdsBo5xHwsQF7z5IZ5QjGzT5G5pMw4b2g+X8SEE4lVnBlkEItJUKi3KrL+pB9Vi+o73rthiCFJDOZeoUZqM0K0kvCGqA3FnD+ym5tRLLuPs/Pyuxv8UK6FyWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FF9wzgzA5tls1xyRgt0klG+tb70lux6hYToUdgXJTb8=; b=k+UCJW2kuBiQ1R6urilWDaU/A90PNW5ZvgqoPaeELbBjY7WdScRRPK9MtMev0loRGGeu5zP4nS3yTVXOuH+Q/D4YYjXEEdgnhtoP52kVloXZtHtcEs7YTsDlbfzCvn8JsGzsRDu1GN2b9x3MGEunjCgg2Pu1XOCGVPUWCjUnUXwgENumxVXSmZ4mz5KJnie7Tan3BFWPWI3e0qwvRKBHa9WeZq8SSQfLYCZ8N5E/I7Bxe5DHXI5ViVwM4J32Q/hFJbmVX+h/2EhB+l51GAjy4RXYbjXEtfFJ8V9l37xIOJAR1SxHu1Z+LXcmRIbkWEaajA1KDZG0ikiEAdDwMsBb+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FF9wzgzA5tls1xyRgt0klG+tb70lux6hYToUdgXJTb8=; b=GjLXUrVw3Rp9daGtWoqv544MlDSXl3M94znyndMGsnI1P8r043/6vFTtnUPiebkRkX8nyUIrRFrjiOiW/g80BKzhI0m6wxnA7CmDkOuVDqu0SF8AaxrDJH080SRJwiiaoaNqi8Go3lCnm7jWAZXTwKWaxLEYq+4jVw9tAwIz3xUsWQSisbaqcWjBK6wH0PMNJwLTDxEoOX1tUfkqFiVrYye2gYGh60F5/yjsrqnsLFI7yrqmNhf5jaayMTLmf/0DXog9lxekWFFOcY5XJDeEnMW8K5zRLB9JbackgCdcKM/483ZwkpFeYuo6/o269/ImIjTN/44G08Kce2ve5zzm+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:21 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:21 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:49 +0800 Subject: [PATCH v4 04/12] remoteproc: imx_dsp_rproc: Use dev_err_probe() for firmware and mode errors Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-4-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f8feccc-d5ca-4bf8-0ff5-08de27233ba2 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZkZZT1VTQmlMeUxmbnE5Qlh1eTRwd3lialR4REY2WVRhRDB5UTcyaWYybTJG?= =?utf-8?B?UDVmRWRhWHByWGRzMDBuTWM4RzlXQWJzenNWSzRFS2t0MUk2REFBREUyQ0dx?= =?utf-8?B?YmVGbnorNHRvMmVjRER1NE1nMEhZc04vaFFqN3ZCaGxiQWpQSmlOWFEwZG13?= =?utf-8?B?MWhaS2JmaVB4V3NuYk1XQnVIUzQyc2VRU3hUYWtMVlozMHNoRTdoMlRMZFNG?= =?utf-8?B?d0FoVnVSRzYxbHNWdXVlK2ZiRGpVcTNDTEVYcTNtNUk4SDJneElLUUJDeDVH?= =?utf-8?B?KzBUZjRDc0JDYkhhVnphSXBCTHBLaFpkNHNVQk1HcXNHWHpFTmNNRWlxS2VV?= =?utf-8?B?YWdwV3gvNWZmbkhKMmFFbGM1SXhSZUN3a3NDSmQ5c0xRRHpKNGpWN3FLbWZp?= =?utf-8?B?UDVWR2ZadVZkdVgwVVJiOTdQd1BNdnB5d21zYzZpRE9rNFprbGpoYTNuRDVu?= =?utf-8?B?UFVIUkw4TFVNckhQTGtTcUdxTGx0SWljWUJGWURGRVRXMkJvdGxSVUZyd0p1?= =?utf-8?B?aktQWjBaWmRVQzBMamljbXl1SGxtdXBDQzh5T3ZBSSttdmF2VWdQOFZFTDVn?= =?utf-8?B?Z0lScFFQVlR6d05hejR2ZFlWTlNDRzQ1emRvR1cwRmF4VTdqRHpiNTdPOU1O?= =?utf-8?B?L1BwMTdGTlMzOUlRRFJkeFEzOVd5cXUwWnVwNUpJd2M3MDZJUmV0MFpTYk9Q?= =?utf-8?B?NHVmUTBxUXl0dkQ5d0hWZC9zUm9QNHhSTDFYSS9pT01hWnhuK09ZVWNpcEx4?= =?utf-8?B?S0RHUVE5N3p6RVNwVDVFSDk5L2dLTG1UVWhOUjNHenByM3N5aE9JYnkyMkR6?= =?utf-8?B?UHMyT3lDZVZuaWh1djhjK0wxWnJlTGNMK2o0aXR0T0xLM3JFeWxXN3F3WHVK?= =?utf-8?B?SlpOUTJLYXdycTlLVXhETjRwQ2I2cjJzbFlNU1NYK3VsZGo2b3N2M2JWR283?= =?utf-8?B?UDVhZ3JlbjJlTExKdk8zWXBmM0NxRGRVOUFpOWVXK0l5OVlidzNtd2k4WE8y?= =?utf-8?B?NCtOWjduWEZKNTg4WW9SQ2s5ajI3N3JxVGliU2V1TERVZzdsU0hWSmNZOE5G?= =?utf-8?B?VUdjQTlEZ0dlS0F5eVdHeitqaHJDTnlwS2d3NCt5NnpMMWNQVEordGM0MHJh?= =?utf-8?B?bDFPbnRVT3JnaFRwdWFvbmp2cTVGVUZwcjJ3OWw3ZC9oelErL3JrdnRHNXhG?= =?utf-8?B?dkhVcm8yME05S3h4dyt2V1JZRUwzMUNKTlc1VEQwanBDaUhvNnNUNGRzV296?= =?utf-8?B?cUo5RkE5aEU1ZkVVSG5CY0JNN00xa0pGTUdnZDZ6YVRyL0ZUbzRTRXorYy83?= =?utf-8?B?KzBhSkY3eE90UGFNcXRtU2YrTWEzUWNBTFlYdnU0VXhGMk9QWHNCOFRJV1VN?= =?utf-8?B?dmhKSmxmWHRWVUpjMHFQZDhianU4YklnR0R6dWFaRUVkcXRKK1ZpWTNsUGdO?= =?utf-8?B?Q2hRd2dLUmpZUVFjZElCYnFoQTFvY293SW1WZkxyeDUwcDBsQngrVndFNFZQ?= =?utf-8?B?dTBQYjRWRFJ3UXAwTDVUVnNuQ3VMOUgvck0zZk5yQlZjbDNvRjZybUtPVy9h?= =?utf-8?B?OXVIZVNSazFTTGRiVHdpZEhkdm1OcXFXUDA1T2J0VGhnRVNKMHdnWENMV1BO?= =?utf-8?B?UUlYbVE2RUZZeEpIN01KcmNZdGNvcm9QbW5WZ3R6ZHRXZFU4Z2EwTFJNdHF1?= =?utf-8?B?Wno4SkRYUlIyaFljV2xzN1R0M0VCdFdJRkxFUXhPSzdKbDErdHhqckJhSU9q?= =?utf-8?B?VFRRTHJhN1k2WE1oUlBLRXgyOERrZnFuWFVpQUlyVVpyQWoveDVjK0NYamEy?= =?utf-8?B?blhUaXhDZVVkUGQ0RnZpUXZLQVBwYm91cWFlRFVjamhBS2dKS3FmUkxjbCtj?= =?utf-8?B?ZHNneCtsdytpNXdNcnBvL0xVVDk0U0hBSS94VktwR1M0UFErUG5zM2lZWTRY?= =?utf-8?B?U3pyeHpmRE01cTlTeWxzN2Z5NkNpMjlCWi9GQzB6NFBCWUdhaEJVZmJPSWw2?= =?utf-8?B?QlhzVks0WWhwbGNkZzdDaDJOdTJjbGpaUEdNUklueSttT3RiSEl6RVNrb09W?= =?utf-8?B?NithbVVQL3Q4T1NlNEtDWk8vMHJ1MzJuOTIwZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OE1sUkJSbGFUZGh0bnYweXdVMUd3TDhycG9CbUV5Y0hpb1plVHpYQXM4cGk4?= =?utf-8?B?SGZkWFdjck0zNDczNjhweS9WdkwyaDFBZUJmanJCZVR0VE8wZkppVkFKNnpZ?= =?utf-8?B?UWd6WHVJdXpOMEl5MEtPajM1eTJSaHpvNjMwVjlnZGU5S2Y1bE1xanppdFQ2?= =?utf-8?B?OUpxdFpDdlRGWUQyK3dxK3BNSDhqc0tqY3BKc1BPbWRIc2VmYlZ4dkVqRW5D?= =?utf-8?B?RlpWT1lMNTJiVTY5MXpESFRjNVJkRGhSYTA1S2ZKN3h4dlFuRzNRVU44VXBM?= =?utf-8?B?c2VOSUh4a1llWkp1TXB1UlV4T3N6VThrREQ3c0V1cjVlRFRlcEczRGZsTkZM?= =?utf-8?B?eEt2SDF5TWpvdkpGV05UaU8wc21Ec2JRSkNUcks0bXZjd2dnK1E4aDB0Umlx?= =?utf-8?B?N0V6NmFTUnFCNlhkUVczUGJ0V0MvTUtGOHRkRngrSXp4Tm01WUd6b3VoNWxn?= =?utf-8?B?ZWZIdEg4aUNiVDVNOThIRGYrQU5ieUxSciszZVR5cWoveGNQMS9FaktnSS9t?= =?utf-8?B?ODNvUXk2bzBPbzlIc242QUNjOGxrZ1NoSGVlMXNZaTc5TkMwUHFmZ0ExL2xq?= =?utf-8?B?b0FkOG1TbEVaRFpiK2U1WnBJUGJaNzRKcEE2S2VmVFFJU2E5YU50UEQ5d0Vv?= =?utf-8?B?U1phSmRaS3JZU2xlS1liVjA2bzFGZE9QZ3FFdjJMWVBMNW1tVVFmRXB0WDZY?= =?utf-8?B?dTFlV2ttbEtuc2ZXbDRrQURqai9RZTMwakt1bWdCaVR3WGRVdEhsOXhJZGw1?= =?utf-8?B?ZTk0ZFJRY1dlcU9lRTgvQ1JvaEgvNlBNeVg4Z0dXN0d4bUU5bCtRaE9KL21n?= =?utf-8?B?OVNZZWFDYXlWcmpLaGxlVzJjU0RjSjMvNDNFR0VjdkI1Y0pkc3gveVBJcVEv?= =?utf-8?B?VFlxZHZPUEI4ZStpTFUvRVBQSUh3WXBZbkgvNnZ2SzhCS3RteTFjOFl2a2FF?= =?utf-8?B?NFFlV0VQTGdkSHRGbHlFMVdLYWVlSDRtWm55bVlLeTg2a1krWjhQZG1pbHZt?= =?utf-8?B?WUg1OFlob2dYcGVWb1A5N2pFeERYL1YralZFSk5sLytZRng0dXExam5Ycmp2?= =?utf-8?B?QTZZVGlWdTVmYXVUcCs0RUJTbG5idjdXd09HYmgwanIvR0F6aUhiSDRsYlBR?= =?utf-8?B?RW9PaGdqTXRxNW03KzNob3k2OVQzV0dxeWlEZTdPandkcUlUWG5qdXpSeHdp?= =?utf-8?B?K3VVRUdvNGEwVENSSnhsZzdRRDJwYksvMGRtbXN1TXRLOWhjdDB1ZmlZOUtG?= =?utf-8?B?bjNTZWJpb2I0Vitna25URlM3eDdZblduRUNJb3REemp5SStYWHJvM3FQb2xm?= =?utf-8?B?Sm5yQ2J1RHJZeloxTW56R3huMGE0VEkrbmp5eklOcnN2SEptSEE0WVVnOHE2?= =?utf-8?B?bXFQUWxkWUowOHRYb2YyWkZYTzYvdWpkUlBMQ3dWYStlSE5PTFFXeW05QVA0?= =?utf-8?B?RlczUmhQTkpnSittbDJoNVJ4V0UrREtMakZFeHRjQ1pUcE1wdVFEN2NoVmRY?= =?utf-8?B?RDAwNGY4NldqODFxcVY3d2owQXl2UkM3YVVkSGxjbGxrV0IweHFUQ0d3OTBL?= =?utf-8?B?RW5yUGUrQitwbnpqai85V1lDLzV1M0ovckErSWJJZGZFN05NV2lnQXVHQ1Rt?= =?utf-8?B?R003aDRKNERudHdZcVdmYnZFeE5aRFZkVUZkSFdwdHNWZ1loUnhob2I5Z2Vi?= =?utf-8?B?d29lS3hmUHlwR2o5b3JqV1VKakZiRlBkMkwwUU9Kc3RkR3FURXJtWElUZjN5?= =?utf-8?B?QXNNNjR1M0M1V2R6MDBVakFpc25WQk9sb2xkMGdESk93cVJLZ3BEYVB1b3lz?= =?utf-8?B?WjJIcE5mT2pZWFlJaFFSaWkvaGs3UzZlYXlzWWM1UU15dkRjdmZIaXFQRlNX?= =?utf-8?B?eGQzanVMUmdlcEdEb0IzSVlDSllZN2ZZSEpHb2ZRUmNXcjRuMGJnNDZLUzlm?= =?utf-8?B?WHdlaHNqMWx5WmZ6RDlNeWhBaUxEWnp2NGI1eVZiTG81VFN1U2dhMSs0RXVm?= =?utf-8?B?b1lrRUdkNHFKUkRjRmtMZ1d4Z21RWmZrdHZ2bDF0bWY2a1RRTEp5dWMvaFRi?= =?utf-8?B?WEh1VWlMakkxNDRHeGVVUCs3a0xLVTBYV1dOd1JTVk8wdHo1V0F3MEZMMEw4?= =?utf-8?Q?J2ZlySqhhprNCC8SO2cSLpnZ3?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f8feccc-d5ca-4bf8-0ff5-08de27233ba2 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:21.3767 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vSpE/E7UsIHNvpJMZgtJ4d04fCdNKiSVn/5mCHCZDJtstjaxfiKJZAI/J+6cV1VKf5wTbrXZD35p05CZJafo7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Use dev_err_probe() to simplify the code. No functional change. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f5d0aec52c56664d6074272e276edb0c4175c9ea..87f4a026c05fbf1c9371058290b= 2d33cb94b9e54 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -1150,11 +1150,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) return -ENODEV; =20 ret =3D rproc_of_parse_firmware(dev, 0, &fw_name); - if (ret) { - dev_err(dev, "failed to parse firmware-name property, ret =3D %d\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to parse firmware-name property\n= "); =20 rproc =3D devm_rproc_alloc(dev, "imx-dsp-rproc", &imx_dsp_rproc_ops, fw_name, sizeof(*priv)); @@ -1177,10 +1174,8 @@ static int imx_dsp_rproc_probe(struct platform_devic= e *pdev) INIT_WORK(&priv->rproc_work, imx_dsp_rproc_vq_work); =20 ret =3D imx_dsp_rproc_detect_mode(priv); - if (ret) { - dev_err(dev, "failed on imx_dsp_rproc_detect_mode\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed on imx_dsp_rproc_detect_mode\n"); =20 /* There are multiple power domains required by DSP on some platform */ ret =3D imx_dsp_attach_pm_domains(priv); --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013031.outbound.protection.outlook.com [40.107.162.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 374B42FD1B6; Wed, 19 Nov 2025 04:22:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.31 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526151; cv=fail; b=sp2sioQn1ZsdGUgXC60kQur8zD154LTkJAryI2j3RkamGDvEngsOkZIllfAQZqNI+qGLBinCfdpyhVHJc2o7hCPrcJzyYvk6/caoQdNPRF7LfFn6hDtSzkZkoo9qzyXAicXGpGrBF2AG5X2PBXJnn4M7AouSmTWhgOvU6aAuN14= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526151; c=relaxed/simple; bh=mPGPxJqPqmmLuzMzEFe0Wl9LgE09XDIAW1ygFEeDodQ=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=IUvTwkbWyVN15ZNrGZ/luWgkPgU0H+MkhdpDsRbjwO0wdEwmqwCUROyZa6DsdgLDXB1AnePig88qQOzXIZD26fb2ns/16MIGMcvfzqJoP5sg7qZ/s7lsd20y/EojjuGiNQEDQQDVaKhotMoXgWzzA934YtbCGrpmUm6Hl9yCnT0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bqf2IHMn; arc=fail smtp.client-ip=40.107.162.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bqf2IHMn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ml7o3yw+sCIM6JPO7Fq/V416U7PTsWkHVhWVo81kqwfJkjR9oCw4TUweHJ4g02kw8qasM6VRHEnUcaWP7Hryis9uBu671xcCs1qFi2VU+N+6QclGo/LBzzOROJMsU4gxoIKF41jrPxZWP0+j9ln5VdlPta29SS4Vevb5qoARGWUP0Wa5/qia5RR55qhGJaYnAd/rbC0XarOSjgijbkWQRz7ay2Y96qfAyjWf27ZfGb3HuYxAQLUBmqOICSpbLVrIJvBZ7XzW57zF528QdacG2mgSArhCIKNoGWw1SEXaraQmpO5U+6QnXjAeDZXjhv8keNFgBZGZ+ShuYbdt3xlUdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAt33bTwiNEMaYQqQD10RAl6/XaD904OgUxTZkUw1zE=; b=voAEEswx33ym/00iA/YDrQ/3WzRQ/hF9NPNS7r+WVsGTrzqZ1P+rb3x4MeLHjZisYM6W4EEbnmGnsbi67s/XYcATiSzRLDxvmm6RV3cQxA6jqcA6xG7JhW+02Sh4pm1yCGywV0lakyys+ZWzLIBmRgSMX16SMnH+zqF7uZN6cwZd8ePUDd6QBqYX5JLK39G6kLCwD8doUwd8nzw2fPm448uGjgDVWDT3ki/JQNmJxcRxuRrvyRgclpC7IngyaUxIAb8nxQZuuCxIMTgz3V6rfbKHy22NUASmxpFVneIdrQWto8RdAUPROF3kxeKlG8Y/VcEki268xbZijSPv4ou/Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fAt33bTwiNEMaYQqQD10RAl6/XaD904OgUxTZkUw1zE=; b=bqf2IHMn7JvqFVhx5zRVqUCgg2SVc9Tt2t4ozyVIG4Uk0HYIWJm6XY/VhCRHQkaTYgih2MZrQvOOn7oq2nUU5dG6CxLAA+Y9LlCiGVR+0ckkT3Ybn8VVojl6acaUwHRuEuk8Bp9lHWioFdmKRcMGOWpjK43gkLLd8/sUYHbWnzNs7jv7xjxlULYv5x7pjvWnjJIvRcvRgH1RIqKfRaiGyLsc8EsFUUWooPuly3JoKwLJbMpp7goOdTuPZ/O3UQcTcUHFdE2JZ20Fr3LlJyQo9SksXCcCuo6oTWL6JCmVcZ8nLGPWvF07fXnpVEvBDSzf7lgWg0o2cTCywVsGaEws7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:26 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:26 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:50 +0800 Subject: [PATCH v4 05/12] remoteproc: imx_dsp_rproc: Drop extra space Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-5-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: c0f1c1c3-a05e-42ac-cf84-08de27233e6b X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bjRmYUJUODN6djRWbG1icWtleHBWRGZlT1V1bmZVSVZFNlJrWXdkUzE3ZjJn?= =?utf-8?B?NGRWSXpHQW5xOWk2NTVFMkNEYVNrMVlTYU1wNTRNc3Z4ejgwK3Y5TlM3NDhy?= =?utf-8?B?aVh5amRNeU1VUm54Yk5TRGw1ZXdjOFVabjR3WXk1cWNYS3UrZHFXMGV4K1Rh?= =?utf-8?B?ZDZnQjExWTYxam9idG5DS1ptNzhHRmJVbmx2RGNDamZvaFNGZG9hMTZLZTdY?= =?utf-8?B?bXpROXlqdmdaNWh1L29iYTdIVVltMTFYUDhzUzRCOTJWUDVaenhqbDg1ZjZk?= =?utf-8?B?enhBbEJ5ZzJJN2N5V3h2RTBVcVY2WUszRHFjbmNEQmtLeUZ6bXBLTmVkL1cw?= =?utf-8?B?UjhsNWJmVWNVeUl3bHJtSVorL2ZYWmRxS0NwYUs5SFFla3FBUHY2eTBDNm1P?= =?utf-8?B?eTNXRGJNOXVsaXhGbEhON29wRGNYRmdiZ0UwUGRReXZ3a2F1eFgvaTkwWTlW?= =?utf-8?B?TTd5M1NtTmJENExkRkszOEREL2g1cEZGeUNHbll0aHBoVzhEb2JZODRsRGlQ?= =?utf-8?B?bVFJdUlOSVlLRm5DaWErLzgvK3QyOHBoTFVSTnNESEZLR29uVE9seXRoemhp?= =?utf-8?B?REZGOHAyUjQ4SVRxeXB2K29kNkxJREdCdXBjUHdTbmcyUGNMc1hEcHdyZzgz?= =?utf-8?B?Skw3ejFKSEc2YTU4SEs1TUM2alEwL1Vpd1ZGc3o4ZmFhYW43NTN5OVdhR1dj?= =?utf-8?B?NElIYUVJY0RXd2tFSW9Vdy92cjZSVzJKWHV6RWNuOXBrVG4zNHp6V0RmcHRu?= =?utf-8?B?QXNXSDY5MkpmbWhOalNOVXNSSk43VDgvOUVWbkVFMFUxdWM4UzFuME14dGV4?= =?utf-8?B?OWFJY2FYWDVzcGZxQ05DQ21yQVFENHAzVHJHd3JLOXBoY0pxRytpNFRQMHhi?= =?utf-8?B?dXNleTF5WVZnZ05ycEMwV21FbHBhdm9DOSs2NW9iWFpTamlPNzdPUVp4OG12?= =?utf-8?B?STJiTHFCaEgvNFk4SFpOcWxZR2h3YUF1bWZqSVk1N09BOFZ1U1d6S1RRdzhQ?= =?utf-8?B?YWtWR3FPc3U3Z1c5L1NGVzJ4OStoemY5bmY5R2JIQUVjWWlaQm8zTDlNeHFG?= =?utf-8?B?MkJJQ3M5aDd2dWhvWmdyUnlvY0NJUDVDUHY4V0ZEcDZFMW5DZWNETUZoaDVQ?= =?utf-8?B?WC9ucWRWRFBta2JWODZpMmxhZnVpYUl6dG1FTUdaa3Juamx5cjNYMCt1eHVx?= =?utf-8?B?REZDS1VWVVJzNlBBVFN5dlBOcjdYZGIxUUxCbm1FTUVNNVdFUjYzQlI4VGJj?= =?utf-8?B?cmVxM1VkVXAyYVYwQzlBRExTNnlSSEtFSzNTd0F4czYwTTU2V1NJYkdMNkhy?= =?utf-8?B?UFZ2OVNOdUhmNzBZa3dYNWFtTjB4bmxFVFRoSmRhRGZ4M0NDTThMYVBKOXFZ?= =?utf-8?B?WGxXT2g1YkY5QjVpVC9JNUF4cG5LR0JXREVRWEc1S1oxcHZGYUZwZHJJUFBu?= =?utf-8?B?VXVUNlJOQ2VDY05IS0hkYmhreUNPbEFnellEL1hzNVlPWHZweUlKZU9jYkdM?= =?utf-8?B?Szh2cldWeUh0N2lHY3lNZGxSeHZ6RTlFVXd5N1k0S0FrSjJEb0dUbEtFaFcw?= =?utf-8?B?dEFNUXlGWVU3VnlrMVBEcWhmbGFqR20yTzdiQXlITm1zUFpFbW04TTQwTnN0?= =?utf-8?B?eEJaQ1hDM0VVOXdCODRicE4zS1ZycUtocVV2bkUvRWVRcU1MK1Y1NTNpZ2VI?= =?utf-8?B?NS9kVDB5c2ErZ3REYmh6bDBIV2FUb1FpZysrbk9jOGh1bkI4QTR2SmFRY1Ar?= =?utf-8?B?eG5yT2oyZnBZdU9RQ01qNmE5eTM4TDQzSWpzVzYyVjZzTUU1WWMvUjc0NnBG?= =?utf-8?B?TXNRWmlYVG9xejk2aFEyMEtFNGFOeGl5VjdpYWhSQVIydWpCdCt5dUFuOU9s?= =?utf-8?B?dG8rVitISjBYTWhwRUdyQmx5cnR3NG5iY1BxVWdsMWdnYVFqMDkwTUNwZmF0?= =?utf-8?B?REFDeVZhZXpwdDVJYVZoOGlmOGs0cW96NE9WTmt0ek4zWHVsRmJranAzQUVh?= =?utf-8?B?STgxaU1qdE9TZldqQkJpVjczWU4rWTl1OWRRL1ZNZmpXYlBTbWJhMS9SYmRS?= =?utf-8?B?aFRaRUlzUDhCSXE3ODJQWUw5ZFdDdVF4K3lIQT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHo2WDdBMk5Lc0FKMWowTzlselJQbE5JcE9BME1GSHhTTW5ZMWNUZGtvemR2?= =?utf-8?B?YldqRjVpRWVwSzRZNDdMNTB3djAyNnpySndkanlzMm5kQ1lZbysxLzdPVWMx?= =?utf-8?B?UlhSbUpuNjZyWEd2UTMra3pQTmxVQlJRclBPaEZWU3NKblZpTUp0SXFUUXBF?= =?utf-8?B?OVR3cUM0S05HS3BLbVIySVd5bFVKd3Y1WFc0V0dyTHpkNERCNXlzbW1VaFJp?= =?utf-8?B?UnRLR2FhU2ZLd3VUUEQ1U1NkSnI5TmRNYWFTZmdIQllhSUIwMGFjV0dIYlpP?= =?utf-8?B?ZFA0YkhMbE1BVEJRM2g0WmdVenhRM203RFF2cFhabDRZa0hObTdndU1qcWJC?= =?utf-8?B?ZWpsK2hFRHIwU2tOUnFRWm5uUHZtV012Tis0WkowbjcyRW5QL0ROcFFIaVBZ?= =?utf-8?B?YTBYM3IxdEgrSkNRSkM0M3IwN0RueXlmUlU0UUw5SjFFb1NoWmw4K3AvZTJ2?= =?utf-8?B?WDBuVThIY0lJVW9ZTWljYXB6clBjSW5YRDJMTUlVRjRjSmlWd2J6STd2RE9T?= =?utf-8?B?ZC8rem1kOTJCdEdscWovRXFPanlkV2Z6bldUV1ZRa3kxcktTcEcvc0VQY3FE?= =?utf-8?B?Wjl4VzZPcEFmNEJRWWszRW84Mm5ITXc5NklEa0YxMkNjUnZJb2pIYVBEb2NN?= =?utf-8?B?K3ZpMjh3bk5WQWtyd0QwNVlpVnhnTVJ4S1BHSU04dEl6Z2hJYzAzYW9uUHJR?= =?utf-8?B?cnpUenlvbmZZbVRTTDVYU2JoMFVuNGlXVHpNaEs1TWtIakY0Z3gyTGluVGhE?= =?utf-8?B?ZGtDRHRVNG12T1NDVjEvaGd0TjhnZEprczVNRDdNb0M1YTlVdmZDWENpQUhh?= =?utf-8?B?d0FYQ25hbzhpRE1zWEtEVXRVd2NRazRacXdYVzRDOGcvdUxCUjdjS1ByZUp3?= =?utf-8?B?N3NUU2hZMUxNdGhaN3VLYVNRZVVmd0l6SG40d09jMDdTNzFyRjFEOFJZRHBy?= =?utf-8?B?eUZiZUVQaW50bnlaWWQ0Vm5ONGFmYUNJWXJvdlJOTmx2SktmVEw0ZEpQNzkw?= =?utf-8?B?RzNhd3gvZnU3NlMvR0FGQWNmcXVSTWhManE5dmxjR1RoSzVUd1F5NkpwTG9u?= =?utf-8?B?ZzNRK1BLNHRYTnk1Q0JvcDlHUUJwMlBwbys2bllIOTFaYkI2Z1Q4Z3oxL3Jy?= =?utf-8?B?N2swNGU5U2w3MU5EWE5hOWd0RTNOankvZkMwdGx0YWJaRWhpVXR0bDVMV1R1?= =?utf-8?B?RkRXK1czcDh3OC9RSlZISmVQTFBCTXZ1MmhoSXl1bGJKVExyUEVYUmlSNTIw?= =?utf-8?B?TXk2U1Q3ZG0rNmp6YWhQVkppdXcwVW5mYnhsY2FqNnF3RDlUSzN0YnYrY0NE?= =?utf-8?B?SEdUcnU2OUcyRUZBYkNTbHFCQXllS1dETlU2NWk2UTdqRjJVbUU4V013SzNa?= =?utf-8?B?Rmd6dnQwcm9iaUVFaFBzYVlncHFFMU9QczgyMFU5eTl1aHR1R3NrYTU3YVpt?= =?utf-8?B?dDFGRjljMHNvODB0WWx6REZubDhTaVVhSXFUallRWGdvMlpNZnFBSUNucDRO?= =?utf-8?B?azRIb0lwUWhISVMzK3ZreTRHZElRdzJpaWJEZXhRUloxM1loSUhJOWNUK1dR?= =?utf-8?B?NlRRY2FpTm1uQUkrV2czd3lKL1crdlN2dk8waHArL1l3cEF3QTZHREZxT2VS?= =?utf-8?B?bm5acWRMSy9ZTlpQV1NGeWVoTlhHMC8xVysvS0tJaHlMQjl6eXFiNjZScmlW?= =?utf-8?B?eGtxa2JCWHpLWjRCSWVBMWpucDNDeDEvb2hpRWo1WjBWM0dsTlVKcWlxTzFG?= =?utf-8?B?dGM3TC9hTUhTcHVQYnZXRUFnNE1nOWVzM3JFd05sTURYZnRPdVkxUFk4SlJM?= =?utf-8?B?WWJHTHp5aEd4bzQ1ZkdRcTQ1bEw0TW9kMlFQNWppTlQ3UkdPdnFackV4SG90?= =?utf-8?B?SGJsUTQyazBZRkRHODhRNGkrL2VDdjNYNHdic3hrR3ViaDZpUXNMa0dyTVcw?= =?utf-8?B?a1pUczh6OS8yNXZJZ3NnVFZ4ckRyZFUrTTJ2WmlxUnF5c1I3V1pIL2xVcnpq?= =?utf-8?B?eFdQWlNlemRrYmpQMUtvM08zNWwwM0Z1Yjl4YmtDOGFzcFpTMEhaZ3Z2Rkdq?= =?utf-8?B?K1IrclUvQ0J0ZzY4b0NIMnQ5QlBkcVBwZitwKy91Ny84cmVyYS9PMkxubWRV?= =?utf-8?Q?tJ8xu4D/d3J9EFBhYqXihj8l8?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0f1c1c3-a05e-42ac-cf84-08de27233e6b X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:25.9530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C4nc53OBPsAnjv9nn+puv+7EVhdp6w6GUW+9otOvUU8tJlZfvgmDhwjvoE2CUIIU5PXtYmUH30sRl0v3OmwEXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Drop extra space between return and zero. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 87f4a026c05fbf1c9371058290b2d33cb94b9e54..1726aaa1eafb9ac1a913e3e2cae= a73801b86dc09 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -784,7 +784,7 @@ static int imx_dsp_rproc_prepare(struct rproc *rproc) =20 pm_runtime_get_sync(dev); =20 - return 0; + return 0; } =20 /* Unprepare function for rproc_ops */ @@ -792,7 +792,7 @@ static int imx_dsp_rproc_unprepare(struct rproc *rproc) { pm_runtime_put_sync(rproc->dev.parent); =20 - return 0; + return 0; } =20 /* Kick function for rproc_ops */ --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011058.outbound.protection.outlook.com [40.107.130.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B69C52FE06E; Wed, 19 Nov 2025 04:22:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526156; cv=fail; b=tFMb2jky/nq4fIUxvYO5yYWQseHw9uMFFJ2DfKw8Bm9aNfgCPGC1FEWsHFZCf4JrPEeZnxpz6vNtbFVY0onm/QhRwjHOLvtzgYVyw3xDNm+GBffBDAcv/Jl+YT5+yYRQJk2ZpxQynKjuzvlav60l+evv+DY0/iFFNMGFniz6FSo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526156; c=relaxed/simple; bh=0fVi+DXNDnvp75NR5ct9+nbWfZyNiBunVDNskhHjUH4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=C8O5+HSmcZeN5QClq7IYwuL4+kD5tnxNTtcKZqS4trXrDcWobLkAZXz7SCS8xuVDc8UVTQfqSQ6znFYFnCpUxRFsGlTsNz1UxrZLL8e+pK2rW8Dp5qKvMHiZRuu/J8DmmS3lXwoah25AFuDORPPd2YucVJXvce7VT1QlWUVnltw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=FI3pZT54; arc=fail smtp.client-ip=40.107.130.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="FI3pZT54" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hUVqMwvjp1aHRXjTm6uGgOpYpOx9aV80dBPoUhgYgZ7OUmfQ4HLHtXeYBnFco+NO1FXcXUx5JeK0yklhSmQsZtcwxVY4LaZOIKbju/2UK2LVbek10ANcJpEJCD1XQvI87MivincyDcfMiyqe1ABWdjH5qO4mHu0HE4HJ+ymYSihZ6e8ZHH+iKJXQpBH0OORj07KL6JuE4aixoi2tPbqYW4n5AseSTIZb2gUb7P49C33CSWluJiTfAXV5ag9Ec/k/Pc9hjUoI6RBBou1U2g5Kytk9WnCwFaPJWqh/GLYhcmr/FpRnX3T9LhWdfpdjPUA8jgC4L5SpJL8P5dhWXjan+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Y7SYcudo63ECcgyg+VBfGXG8L6Yowci40fwsz//UYs=; b=rGuJwIzWawgd5CemwcTlz8Vmc/HBEz1sjvry/bbYhFRp/wCwbcgU7GKeBVg4pS5WWsR1UDeTdY0yPsXxGQmQ6bRdyf0YbRkxaOLQa7nrRTajjymhz4GfOp+ESyBwtCyq36yUPf5IYylIyHnJBcT5ZQlJAGXTE0b/mMO5yTI2h4DRK2ZiqAkwjGN4hXGCebZVoo4zj6vC/E087SCgs4GxhXmUjsM8M5XK84wCOyM6bRM9qtaqzdWml14ltxQGy+1vpwhHV7l7hNXvQebQps5Zfeoc5Vw+5dY/6wrXggmbrrsvTHnq9QKtGYUwJhuATkE2mtcM64zYINf2c/QkGIi5IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Y7SYcudo63ECcgyg+VBfGXG8L6Yowci40fwsz//UYs=; b=FI3pZT54OlXAsYhuGwTxHicDreijdwZ6KgBxStwQ3lWMRGEkGPBJq+V570Mojnaj3P8lXyu15nJWsgcUkCooF+x9YoeYkw+DCh0wHXC9ZYSrts6hqxCbgmL4KiLZju+zd0om274aV4epIeQYpKokd0NH43dJAy2lQfxMvzqECLc64EsdB5+LlckfvApeMcn215/OIErltx02w7n8V9R4mf4x5h4TR4M1mnc9gij5GUXBgxce3RVxkMAi9GW7g8Q2Cgt9Cs0p/MuL6ZRBec74uv6k31DLb0RdM/4wvLfA1yXrCIkeY6MSR+6akARQKLHhhIQqy6DFss0tO2/hlp2UFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:30 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:30 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:51 +0800 Subject: [PATCH v4 06/12] remoteproc: imx_dsp_rproc: Use start/stop/detect_mode ops from imx_rproc_dcfg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-6-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: a7f7cd7d-74b0-4c4e-4868-08de27234121 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ODlTQlhjK2RSRWRwcmhnQll5NlBBN093RVJsVUVDTHlmQ0E3V3Vob0NuN21m?= =?utf-8?B?ZlR6ZStSdFRMaDVJVjgya1JHOGpuc0ljcGo0cXVXVjBaSDhvWDBVUWpKM21w?= =?utf-8?B?NFB1eXFOM2hkWFpJQk5FOHF1SFVaWFRtbFhPNUZqS3FtNVFwd2tISDRwZEx0?= =?utf-8?B?OGY5bk9hQ0hPRVBVTXU0NDZWakttMFppRWNKWks4Y2dRY3FNb01jWWpvSlZk?= =?utf-8?B?TnBFVEVUZEpkanhxRTVIUXV6ZzdlY0c2V1VUZ25tZm1Ma0wyY291ZXBsK1NL?= =?utf-8?B?bHRSZWE4RC8veFBJUGNrUjNXL0NZSkRDVHZ5U2krOHNhMDZzK2RLREM3ekJi?= =?utf-8?B?cEhrSWx2VmNaeTNkbHpYdnk3SVdLaVZkR0pYd2RhTTNWYjBRUEErK0V3YUxD?= =?utf-8?B?NW5zZnRKNmlSN3BvYm1PdGVUMWxBRlVDVUloRzB3UkhSWFNkaDZ1U0srQ01R?= =?utf-8?B?SEIvYzkwcERJSllhWDRxZW5GY2taSVVVdFdZUDJZVU5UQlhTZ2R5bWYxcEU2?= =?utf-8?B?dUZYSklOOFlFMVVwKzlJcFFpVXRDdE9aL0xmOGhBbUVHRjB5c3E3V2t0QXpE?= =?utf-8?B?Q2VkWTFscGlQNk9VWDNkVTdKcnpLN1Z6VzJhODRpbjZad1dmUnJJQjZGdjR3?= =?utf-8?B?RkFPS0N0Q2tQMDM3LzNhRnZKNzZIaWN5bXRld3pnUVYrZXBDVDdnYmpoS1o1?= =?utf-8?B?b2ZKWWE0SlQwVjJlbERQcldXMjJMZDl1WmgwNkhIUzZXcS9yNVlWN1hWWGNZ?= =?utf-8?B?WnFJSkx2cmF4Zk4wekFiMzc0d2UzN1lnTEllNVpKTzRNdWZ1TEV5UzJPb0di?= =?utf-8?B?Ylc4K1RQU2U4a0IvUWhtaFRLVTBvNlBXYVAvNkxlSzJiWUJzdFR5THJ5TVFa?= =?utf-8?B?cUVzek0xamk3RFZTYms0UUtHSHJFbmpDemU0TGVkcE44eTBKQm5NbDhCNDN1?= =?utf-8?B?V21HRU1UUjR4U2F5VWZxOThSNlhsWjVVa0E0S0lxTnhrK3BIUUpUUDRuTWNJ?= =?utf-8?B?UHpMUHpIdlF5SWFmV0p1MTNLdGFLVTFNRmNRNDlPOVl2ekpsdW8zZVUvaWU5?= =?utf-8?B?U3Z1OFU1VWsvdVFLMnI1WjNXOUNXNWttVjZZRm12SlBjbFYyYkZnaTV1V1NR?= =?utf-8?B?dHdHaDMxc3haNnlseXdXUHhqOEtjWElHdWVhdytjY2hOb0dUeFMrNWRnOXQ1?= =?utf-8?B?VHFNWjNjOHZQMlhEY0hFR2RQenZuNGRzZ0NMNlJNd2VkclJTRVVvYk5LSER5?= =?utf-8?B?MVZ2MndoeWl4U2ZZMnpDNUlNK2h6dmJjeHFWVlVKcS9RYXlRb2k1enlOcGtj?= =?utf-8?B?dDhqbmxHa2hDVmxmSFJWUGlmcVB6eG5JRHltQkU4OHdiWXFqYVV2SXlraXMz?= =?utf-8?B?U05wcnFWS1NjSW1naUxVRGY2M3VudlBBdjh1dURoZ0wzVmVRSEYvazh2VVZN?= =?utf-8?B?ZXk0TXpMMVYxUDdBUW1XbytEaCsxT0Nib043bCttUFZRYkdXNGFTK3BLWExo?= =?utf-8?B?eEtxclowOVdsV09UWkFveEsvSEVDQWtPMXhpc0xmWnhrZndwWmVQMVlJM3Jq?= =?utf-8?B?Z1dHNmJ0ejdTMnlBTC9ZMnR2cWRtay9aNjhRZE9OUTVZbHhpakpxeFBqeDln?= =?utf-8?B?TGE3eHVFbXA5cHNrQzZKWHh2TnRrY09XRi91aVZvRTlMZGVGRy81SGFabjYv?= =?utf-8?B?NVg2TkwrendSQko4bU9oR09WWVBQaGlHSzNSWmJ4ZjhrSmpWVkNsWDE0LzNn?= =?utf-8?B?WWZlSzVheXhLYWhuR2JCRWJNNFlrU1lmQmtXZ09HWENhWmQ4UjV2alVQaGx0?= =?utf-8?B?cFczbUZGOGhVakVZMzhlNVlzMzhlc0tuaC9CM2krM200ZW5OR2lnQWllSVVK?= =?utf-8?B?SXFkd1UwY28rNDZJdEZINFFKdi85Um9UMm96dTBaTDVsUnI5NFgvTTA4QkVL?= =?utf-8?B?dGlFYk14bnQ1UjhWOFdaVnVZZ3UrKzdKSVl5MXJBdEtIRWhma3dZVFVGSm03?= =?utf-8?B?YUNwZk1vVnlPU1VaUXU2aklYZFVUOEFJNUNscGRRL2J1NDQ5Yk5LdktpU3BO?= =?utf-8?B?Z3JkMmZQYVJQNXBxamV0N1ZMVVhkMDRpbU9MZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STdkL2c0Y2hvc0d1U0RIVjBsbWZsSnJkRjA1RnUrZnpPMjRSZzJZSVFQQlEw?= =?utf-8?B?Q3g1TGZSL0ZxUVJIZmZwLzJnOStWRmx6ZTR6ZHNzczY4RWYwMWJab3N1cW9q?= =?utf-8?B?Z1puREdjdUVYM1RPU0FCSFlCY0RQZkhuUisxZU9reWRBbTIxWDU4bnZ6Y0Nj?= =?utf-8?B?YlNtTXphTkhSeEVGbVh5KzhCUjR5Y3Niczh6WnFueEJPMGJhV0pXVk5DUkpq?= =?utf-8?B?SUlJbjlPTDZKREhUbXB5TGtNb2FBbC9CYUwzYWxFMnV3Qm1HeXpicmh3aXI1?= =?utf-8?B?V3drYU5sTTFMOXFkNTcwQS91dGtjTURmWFpRWDFOc2pIRnI1VHN2L0hVMFUy?= =?utf-8?B?NXEzSll6SW16U3dEaVg4YnJvc0RuM2JrM0lZK241TXdHckpwaEZrQUJYN3Zo?= =?utf-8?B?MjVQVzV2K2p2VlpSR0RZeWc3NmVPUi9aSlg5U3dsaklSVEE1QU5rem0zcG1B?= =?utf-8?B?R2xhZUdFRVZEc3QzbGhTdjRQZ1pORnFsQTdsRUJFbXo4RjFsdzlrTm1wQ1NN?= =?utf-8?B?cmNsbFB4bmplZHkxYzhERDZLcDJhYUh4Rkp2TjZqV0NQZkhOWFpYaXNHQ0s0?= =?utf-8?B?L25JV3lDb3M0VHFyaGhnNTNHMEFjQTFCMlV6aXphZDB1UWxFcklSVEM5TDhQ?= =?utf-8?B?MmdwdXlOQ3ZEODZTUnNvSFV0NHlHa3o2UGZtWkpkWmdlZWlwOGhoYVc0clRT?= =?utf-8?B?VVF5VWpWaEZNSkVzejNBZzQzYVBOYXBySEhYVWhRU3hJQVNNOEI1Q0FDTHEw?= =?utf-8?B?M1l3WldOWmtiUnE0QXZTSHpZNlVlME1NZS9ySWFSSXdrS05iY3RQYTZUSWF5?= =?utf-8?B?eVFCM0ZaZVVRQXN5empaVm5OSlBIME82RTkzdHNDUTNpRTE4QzBpK250VWlz?= =?utf-8?B?M1EzZ2tWYU9UTzBFN2FPN0NDS2NRQnFpNSs1NmN1N2xyL1BuL1ZCeUwzeG52?= =?utf-8?B?SDc4QXcrZzl6MHpjMGFDaFpLVjdkMHd4NWN0bzdQelZXa2MxV2hQRWFNSjJF?= =?utf-8?B?eVJnMGpFTS9vcUVZdHU2YmFvMGFqSzB6MEg4SFFac1J4bEh5Zms1M1BuMEM3?= =?utf-8?B?ZC9XOFdzaFpUUk80WUcyQVI4VzloUjcvWkx1UXN6Lzh2Q25uMThCWU5JM251?= =?utf-8?B?U1NOOXA0SWs1SWo2MXNKZkt0b2NhOWdCUmpoTDRzSEhXL0ZEU3NsaCtlQktC?= =?utf-8?B?RmNLSmZ2SDd3bU9td1h6eEhWT3k1WGxRZExKTm0wRUZJN0pSZjQzdVVhZzI0?= =?utf-8?B?VnNBUU9PWnQrRkFZWWNNT3p2Um5VcXROMTFRWWdiNlFMZ0h0eVJSa3lxazBu?= =?utf-8?B?bmZRMXZGV3Mra0V0blJ3VVhEMFZGSXJWS3llaDBPakdKUTgxSWd3Q2Y3TjRv?= =?utf-8?B?TFJ0UkNMTEpWVGJ0anlmS3p1VlBTVjAwa3o1cXM3bm9DemNPNm9CT1Fidmdp?= =?utf-8?B?djJTcFYrUklVVUh3VDBZTVlGY3RPWGV1M0c4dmxTRHRCeDd6aUtwMHh5S3Mw?= =?utf-8?B?aG0yLzZPa0t5RXZ6a0RTMVE2RVNxSXlVc0cvbXVVVzhrS2ZocXpnc3FNN3lV?= =?utf-8?B?QVp2eExTczVYSllteDhvQWhuU2F6aFk2clZKeUtKeGxkYjRrVmtTdGI4SXhU?= =?utf-8?B?U0J2TUM5ZXlSK1Y1MXlHdVRWclIvdUovbEdFR09MMEJHU3ozcEljK0Z6ajRm?= =?utf-8?B?ZGU3WjFoTTdGWWFGYmVmck9WMHgzdkFXWXJvSENtaENXeTNQSFdYSGsrQllF?= =?utf-8?B?TzF2R3FNNFNGUlpQQURSYkJXdXVLalVyM2dSa1EyZGFuZGN2UnBjcVFYaW9C?= =?utf-8?B?L2tuVXRlY2VkUTBBSjZ4ekZScGhISHBlNWwvNGs3cWRTY3g5OGlsV3Z5YVVI?= =?utf-8?B?K3p3VG81ZFZJcGovRXBFYUp5aTJEaHdNVngrTSsyK3VUUEd1S1hTZTlscHNr?= =?utf-8?B?eThQbFp4d245eVZxNEZzaEVvL0xXencyUXJUL053MzRQNXYrWWJxblVoUkhx?= =?utf-8?B?WE5uWU5DUHRoYUJXVzBXS3ptMlE0ZzdML0JSc0lvY2VsTGVBVDRiakJqK3JV?= =?utf-8?B?UlNUb1UreHkyZUlJa3ordTYwN1dXTDNQRlcvTm5oM1JlYTNNMzkyUTFodEZN?= =?utf-8?Q?euEYS46h7rc+S4a46Ls+yvM4b?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7f7cd7d-74b0-4c4e-4868-08de27234121 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:30.5065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2VIUIvSK/n+vk3d6jlXnadtVRES7JcPAGyEcEI2kQtpEeZZP4UB2fBSdyk8gYb0FnaPIOt/uVm6If/czmhgR7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Allow each platform to provide its own implementation of start/stop/ detect_mode operations, and prepare to eliminate the need for multiple switch-case statements. Improve code readability and maintainability by encapsulating platform-specific behavior. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 1726aaa1eafb9ac1a913e3e2caea73801b86dc09..833b1bd4019614157f0bedf09bd= 348caab802eef 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -404,6 +404,11 @@ static int imx_dsp_rproc_start(struct rproc *rproc) struct device *dev =3D rproc->dev.parent; int ret; =20 + if (dcfg->ops && dcfg->ops->start) { + ret =3D dcfg->ops->start(rproc); + goto start_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, @@ -424,6 +429,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return -EOPNOTSUPP; } =20 +start_ret: if (ret) dev_err(dev, "Failed to enable remote core!\n"); else if (priv->flags & WAIT_FW_READY) @@ -449,6 +455,11 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return 0; } =20 + if (dcfg->ops && dcfg->ops->stop) { + ret =3D dcfg->ops->stop(rproc); + goto stop_ret; + } + switch (dcfg->method) { case IMX_RPROC_MMIO: ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, @@ -467,6 +478,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return -EOPNOTSUPP; } =20 +stop_ret: if (ret) dev_err(dev, "Failed to stop remote core\n"); else @@ -1085,10 +1097,14 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp= _rproc *priv) static int imx_dsp_rproc_detect_mode(struct imx_dsp_rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; + const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; struct regmap *regmap; int ret =3D 0; =20 + if (dcfg->ops && dcfg->ops->detect_mode) + return dcfg->ops->detect_mode(priv->rproc); + switch (dsp_dcfg->dcfg->method) { case IMX_RPROC_SCU_API: ret =3D imx_scu_get_handle(&priv->ipc_handle); --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011058.outbound.protection.outlook.com [40.107.130.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 277DE2FE05B; Wed, 19 Nov 2025 04:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526160; cv=fail; b=OFs4f8MgfFUUq9/s6R1tAODdShv7htXIbzhDykjn7SP0exMNooDxXotUaa/hMY6SCAdD/ED/BypkEFLNBgRfr4rKhbsK595I0ZPiMDUseeVVIoyheL1wcTPk/d11uLW8LAlM2Hp9uCtdxjt/o/TiL3ARskXDR96f/EzVA4Jt78g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526160; c=relaxed/simple; bh=QMSGnVxfDPECm8WbjDpJd9a/t3yuczbQZTSWKtScg0Y=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=nzvQnYR7YJYngYmlr1Hi2Un1GaU8dnYKIkBmsfd/rjh8KKRR5U0DVla3jcL/PuGdID/fggmiDmKqgIJrhgZMoLxalgMsfGr/tK/1+NRTS/X5DVTbs4yIs5TaJWKiFMvxGB3afnLogj1sUeJXgMdWI6OPzUbbqDVF9Ydcdnble8Y= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jkZkMg8d; arc=fail smtp.client-ip=40.107.130.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jkZkMg8d" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FwkdPvgL0Uxxkt7wQYzeF/sRDWJVuZftbS6lx4fM7lLiT9ijvojbyMLaLh43x7wLdMUBY5YRME4SKHS7SIqmqsNi9R+x9kvfR7IlysUFOLgFX7ABaGonney93izdifim7vWoEz7oM8/RNsjKZZu8VaCDQ2nBAvT+t0nrhngQ+O0UmZuWPt2rhU9avWxkw4ei6vt26GGm7AeFy+htqpakRew1AmvvOazalvg1jkC+7g1cSbEm2D0APtFzPqwPhV47q7Uk5dr5Yw3aXnFIt19zdQCwApwOX9VXMbkaSKMoIHcV+rTe0ExVCgtAWA2vbjqEWyNKbvXOinUzwbN4WsDp6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sdWWra0WXUAVz44fhyU5es6nvF78K7iJ17lQCba/XwY=; b=qe+wI/HBZUYGbl+oJmBMui5k6GC0j9FTLAD4F210zPXD8vX4xmJ7l78SqoGSV6a2p6kSkIp+kdlHrGAl06FLIAMlRWTcvDAQPGCspD8MYfrbHC1XQ/HhfZiMBicT4zeP9gVrbKcBd/gNX2dhm/SyGk3QRct7T2bfhl3bgw+zebzCTtjoF7Zyyi+3IA6QE1jmpQx4Z++abQFaIJUAkVh8Cc8kvkvM9SBX3Pe7M42Bn4vV99epOvg0oXCRZJ8uRnIweqD63bDWGJw5aFSvEFq+ilgVbTp7RB8vbGXNB8kcbFB+Eh8hKUkb4/3xaXybpyWNNPL7jU/esruetUvl2cssNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sdWWra0WXUAVz44fhyU5es6nvF78K7iJ17lQCba/XwY=; b=jkZkMg8dHgV4GgmjLaZc30Fo1US3rsHwYJoE/lUs2Rsw1dob+4y7EYugWvQHf/Vf8wsBwW/jauY/ZHIeD5KJQBI88hK4JuIBqG7/5DqxcO2OmiMWKKC8vrWi7owyjsx5tEods3H5Nw6eJYhIk6ULaRb/tRHQ6ke4ff6LtQ4NEwMuwmqXIPIlKk1MsoVHhLQU5Jc/en27lNUgKB8tJmBho/uRi+4mayh8yXJI4ReQK8d2NsXsBfo4YabzzZ8GJ3Qu9ovT1Vqm3hsYtxztZhOaXAQKYJ3b0Lcw98lwgGmQ37FNi9NmdoK9PiqSIUBrvW988IYvpx9YluF6LyYvL/mbeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:35 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:35 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:52 +0800 Subject: [PATCH v4 07/12] remoteproc: imx_dsp_rproc: Move imx_dsp_rproc_dcfg closer to imx_dsp_rproc_of_match Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-7-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: b61a3ff1-8d78-4831-9bcd-08de272343de X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?WERaTDh6T3JiZng1NExSYXJyMlVjczdIa3EvUUdZY041ZHpDcXpsL1NvLzBC?= =?utf-8?B?V2RENWMySGk0K1FWd3ovZytBdndScmd6aHpjbHVobk4yMmZLM09zbGQ0bndV?= =?utf-8?B?NGhXWEFVeFNrYXh3V1FFUVVieUdndmMwVXN6QlgzTUxvY2JPc1dXNVdFWit2?= =?utf-8?B?c2ZBTDdHTXF6bjh6WC9YYi9rZ0plYlVLN2VVYWhMa1dnV1NpcndNU0pkQ25v?= =?utf-8?B?czE2bjZ2NElQYWl3Mk5taW9MU2RDeXp4Y2lJNWxIWmRkcmtDaXRIbHdnRC8y?= =?utf-8?B?UjV4Ni9Mak82dk83bUxsMXlNSWFEWkVqWTRYZkNpeGxZZE5QL3IydlQ2ZGZC?= =?utf-8?B?cUxwM3hveUMwcUN0UU1Pa0N1T3hjc0I4dEdGcVNlWlJQVERpRTY0Y2lwNzVR?= =?utf-8?B?Um5CMk9pc082cHd0Z1hHKzlGUUxZOW5aV3R0R1daNXJyanhvUkNURlZzaFJF?= =?utf-8?B?elgxNXdJcmxzMFIyZGRBeGFlYTk2QVRFeUdnenJoREJhUmhGQU1hSnB1T25i?= =?utf-8?B?SVZCQ0VPM01YcHJDUCttZE40bWVaNXlIVEJFQk43eWhJK3ZTWFc2L0UydEtu?= =?utf-8?B?NVVBcC9mRWxRVjBoTitEc0pXYWVNQWsxYS9yV0wwN3Zjd2tYMERyR0JWVzB3?= =?utf-8?B?Z1dxQ1ZwWmkxb0dqU3FsRjRCZnZVOSttNHQxTUFnazZNRnRkbG5MZEZ4U2t0?= =?utf-8?B?b0xjNVNLeFNUM1UxZjByL0hZNWZMZjlaL2JnWTZrN0d6ZXpra0R2VDNTQm0r?= =?utf-8?B?ODloaDhFMUtaL2U5VnVIVnQ4ZnRWOWlzdkRNNkhGMk5ZTWJuZGNERkpuS3V3?= =?utf-8?B?WE12d3U4WUZnNTdZM3RlV3Q1b0lLYytNN3RITDI2NFB0NnNoYzJFaW1IZzlK?= =?utf-8?B?ektnYklGVWY5OWpjdUJRbldJTHFTb0IwbVZIc29DQzdWY21pL0FKMnRaMUtq?= =?utf-8?B?QTJzbzRkRnRtS3p0cjBJNzRGSEV2dHZrVlhmbjdPSGpsOUI0QWlKVTRTSVdC?= =?utf-8?B?N2hOWGc2MUUxcXlldjQrdDJSdzlNeG1FUkJPWHB6S1d0RDU2dVVHdnNEL3Vt?= =?utf-8?B?ZWIvSktXVjBrdkt6V25ES3h0QUlGb0t6eUxtekVPZjhDSEZYa3pPQjFaVU1U?= =?utf-8?B?SWVYTFFKRmIwTmYwb0ZFdWhPeU1OeWdRazA4RGR2Vy81alowaWJaejAvNHhy?= =?utf-8?B?UVlwck52UUdRUjJqMXF5MS9CZ09wcGhhWE94MlBVVWQycHZ1eGJDNEpncy9P?= =?utf-8?B?REs4c1doZ0dUMTYrWWxnNEwzSytrQ0pvK1BveW52SWJvdlkwd3RCeDlqaDNE?= =?utf-8?B?OWZnSGZkbndEK2E5SUpPOWQrWE9BSmJhaFl4ay9Gd3hwdmlsVjBLVHJoUHBl?= =?utf-8?B?eHZ5SkR5eGhVNmJrKy8zeTFaVmtZUlNDeEZsYUpLZDlBeDh3SWRWVzM5ejZZ?= =?utf-8?B?S05ONE5xYldpVTdka1prZ3lPdUNSVWd2ZVgxQkR2RG1kQS9SeXhaWHFTQ3R2?= =?utf-8?B?Z0J1VXp0KzJrZ2RlZ3VLK25zNXk4ZkZZMi9VOGdEbGxoMDc0R1M4dnluRm16?= =?utf-8?B?NVJCS0lNbng5UWZZbnVLblRidW5HaHNyTUNLdnNvR3h4Y29KbzJzai8wSlBS?= =?utf-8?B?d2psdG9lRlA5aHc3M3djMCtYSm1veUN2Z0pOWlZOUHVmZXpxMU9sUzU4anZE?= =?utf-8?B?MHJ0S1dIdlUwTHFLaCt3d1o0ZzRtS2ZNTGxSaGJLZjBaSEJCU1RKMTh5SFVU?= =?utf-8?B?K0dLbVI0VFJRekdNeHNoQWFGR0ZpcG9oeXNWOHViTW84TVY4TDVOdWhFVUkr?= =?utf-8?B?eloxSEhwTzJkWVJMV3JXTzhUUmNzVkV1ZFRXd3FTeEpKS1M4eXUweVVDUjZ1?= =?utf-8?B?RWJTT2lXeERtam9lT0NqK1R5VzEvOW81T01kdWVValhhT2RHZG9VakU5TXVh?= =?utf-8?B?ZGFZNWkxUjJLSk9FWEVSdFFSaHBHSEo4TDV4cy8rYkNRaXJCUXJkaDcxVkRN?= =?utf-8?B?cmVXVlZ6WnNRU2R2WC9TS2RjUU8yWWxZdHgyME1UNDZFakhOQXRacDZyV1NU?= =?utf-8?B?clA2RVVnejNhRGhlVjZza1NlRXFhZU5mSHdBdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3VOc1BOMVRvSjNGS29aczY0czBkQ0RWRDhoMmwrYll6RkUxT0l6TTVudDUy?= =?utf-8?B?eE9JRFAxQkR0MFhPaFZTaVlDcFJzckU2dVRkb1NBODFTNWQzbmFhcXMrZ2tJ?= =?utf-8?B?bGhlN3RPNVlMK3BiMlBOSFN5TE04cCttZzBoM0UxQzhvTVlmSm5acUJaOWQ1?= =?utf-8?B?YWt3ek9qak5CUUQvb0NJci9ibS9MeDltcno2MlZ6YW01bDRINFJnYzdLeXQw?= =?utf-8?B?bmIwNDBkaHRFc3ZIRlBnaWJSL3Y3NVlZSDM1U1VOK3VLNE1Kb3Y2VFJVVCtI?= =?utf-8?B?aWhKcE93RnIxT1hjVkR1SmI1SzNEemdqZWp4S3VVanpLY3JveWhIenJ1Sm41?= =?utf-8?B?akRuSGhLRVZGMW1XWFcxQzlTZVJwdFhYZDl5ZHhmNUxjd0xiRFlNN29ZRzBD?= =?utf-8?B?Z1NMYXdYRkZIVnpoMEtYc2lkUmdWekFCak04Uzd0YTZPWGNub0lwc3M1OTZ5?= =?utf-8?B?RDIzaENQelhBRXNUSGN1MnJVVTU4MHRqUEYySGUwNmRYOGxLaWxqUmZNa3hx?= =?utf-8?B?Wll6aFA1NURsTkpPdGl1RFVmSVpFQkI1SXFYOWVqcnNJYzhoMkUyb1NVK2p2?= =?utf-8?B?RmdOaW5tVTA4NUNoTG5hWnhOb0JrVG5Qd1p4MzQrVHF3ZjJDMDd2a3JKR0hI?= =?utf-8?B?M1hQeERlSHFLNFJYNXA0ZGRRaERobE91V3VwdzkvZ05MaDVXYzFvcDY4MGxq?= =?utf-8?B?MHpWOGJTOXJCSzJ0OVpKUmUzc0hqNEN4c0xnSXZOT2FETnorV25Rdk1Tenoz?= =?utf-8?B?aDN6T0pQQ3ErQmhCS3h4cWszUWEyM2dEMGg0TlN4VVRmekZEWFEvVzhIaTRx?= =?utf-8?B?VHlaOHpaaEZDMC9EY1Y4OFUvVDU2QVZKaDhFdjFwTFpRM1RhclhHeWJUYnc0?= =?utf-8?B?azJ0YUwzam52bXhDcGFDTGltV1N0L1FLcExLb2ZuZjlmZGJCT29TdlFuWkpB?= =?utf-8?B?b0xHdkdhRi91U2JmMytqY2h1U0pHUDdMRXlCYWp0YmNQKzFGNVpCamRNaVM2?= =?utf-8?B?YUNjeGR6Q1pVWUhGdUtWM042ZFdJcktLejNtNjNLNUxKVGUvYmlubTIxRERK?= =?utf-8?B?LzJ3Tjg0SXRiNVdua2JOeE5LRUpmcVROMHdwcE02Y1pmMzZBK2ZnK2c0NFZS?= =?utf-8?B?d3B3RTFVcjl5bTQ1eFRuckpzSjJmZDc2cHRpWXBkZCtUU0hESVRmNzZmM0dS?= =?utf-8?B?YzNVRTBXWXVJWDlDME9yZ3huYWRjVTZmQkVIaytqTnNWWllxWWc0emlrdHhj?= =?utf-8?B?bHY0UW5vVE45azFESDNhU2pWblpkdURpREp3MDUrSHVVNE9yalp2aFRaMHhV?= =?utf-8?B?OU8zSFVTU1dSRGkrUUNIaTNCZ0dSUVF4bC9zQXdLT05BRFZ1NndlVjhwNkdu?= =?utf-8?B?U0FKdzd3M1B1QUJZTHFlMXRjMW9ZWkZzeUtxRkJqK2QrTHptTWsrMzFFdVdu?= =?utf-8?B?YTF3dm5GSXhTcHRmd3Y4MTNpWnpWT1A1UzR2WWk4dFIzUXdVTVh0bVZVSk11?= =?utf-8?B?U2hXUXl0RlhiTmhYV2V5V3dyWTZBVG9MZ0JGRUg5dFlSY2VqMlVNRnlBbVVG?= =?utf-8?B?VUR5ZmVna2dlNWV2WnEwNlZkNVc5K0ZScHdPK3V4Q3ROY3IxUDU1VUlTNUFq?= =?utf-8?B?L2NUWG44QnpXc0VYUUc0NGptSXRMUko1RGpsZk9QSitUeXZWSjcxV0F4QXVQ?= =?utf-8?B?dzBpTVl5bXdOMUcrMWkyUUlNNDJVUSs3c3phV3dSZXUvbUJtT0djQ3VQMXQ3?= =?utf-8?B?TkFpWmZ2cVNvUVg4WEpjQ044NE9ib0pRTXI3ZG13c3ovbG9EcndJL1M1RHpH?= =?utf-8?B?aEp2cjNXYXVNbEJobWNMUCtRQ0NsZzBzdTFiZUVnVCtvMnJvWklZZFJtZDFy?= =?utf-8?B?MS85dXN6VGFoVWppc3FYb2VaVFQrV09LYktacS9CRmRpUFZmL1NuMk5acU82?= =?utf-8?B?Ri9ZRXdJM0M4cDBWN0lzVGZYZ1dqcis5ZnhNdXAwS25Xc2JlUUxSS2djMlYv?= =?utf-8?B?Sno5WG9MTGRxM1gzSWtBLzFuSEE2TnUzRXlSeXJGZ3Y2NEk0SWp5Z0hVK0sv?= =?utf-8?B?RnFvTDcwQ0JzbDl5V0tiVU1IK1pjcVQyRXpQLzJ5SWlQRVFoZG1NYTMwTE8r?= =?utf-8?Q?9IghR8rG1vCZKyFs2yP8hi5Js?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b61a3ff1-8d78-4831-9bcd-08de272343de X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:35.0402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1/5/6K7a2dGF9NhUSlEAAcx19+5TOSIaKzk9TkDmsWfeOuLIakvDz6TrDEDZ071TE6t29vYpGeix9eUxYFl1EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Move the imx_dsp_rproc_dcfg structure definitions closer to imx_dsp_rproc_of_match to prepare for adding start/stop/detect_mode ops for each i.MX variant. Avoids the need to declare function prototypes such as 'static int imx_dsp_rproc_mbox_init(struct imx_dsp_rproc *priv)' at the beginning of the file, improving code organization and readability. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 100 ++++++++++++++++++---------------= ---- 1 file changed, 50 insertions(+), 50 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 833b1bd4019614157f0bedf09bd348caab802eef..f28d25cab3f1d89e5cde37a04b5= 28870a59abeed 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -261,56 +261,6 @@ static int imx8ulp_dsp_reset(struct imx_dsp_rproc *pri= v) return 0; } =20 -/* Specific configuration for i.MX8MP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { - .att =3D imx_dsp_rproc_att_imx8mp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8mp, - .reset =3D imx8mp_dsp_reset, -}; - -/* Specific configuration for i.MX8ULP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { - .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, - .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .src_start =3D 0, - .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, - .att =3D imx_dsp_rproc_att_imx8ulp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8ulp, - .reset =3D imx8ulp_dsp_reset, -}; - -/* Specific configuration for i.MX8QXP */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { - .att =3D imx_dsp_rproc_att_imx8qxp, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qxp, -}; - -/* Specific configuration for i.MX8QM */ -static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { - .att =3D imx_dsp_rproc_att_imx8qm, - .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, -}; - -static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { - .dcfg =3D &dsp_rproc_cfg_imx8qm, -}; - static int imx_dsp_rproc_ready(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1351,6 +1301,56 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +/* Specific configuration for i.MX8MP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { + .att =3D imx_dsp_rproc_att_imx8mp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), + .method =3D IMX_RPROC_RESET_CONTROLLER, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8mp, + .reset =3D imx8mp_dsp_reset, +}; + +/* Specific configuration for i.MX8ULP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8ulp =3D { + .src_reg =3D IMX8ULP_SIM_LPAV_REG_SYSCTRL0, + .src_mask =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .src_start =3D 0, + .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, + .att =3D imx_dsp_rproc_att_imx8ulp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), + .method =3D IMX_RPROC_MMIO, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8ulp, + .reset =3D imx8ulp_dsp_reset, +}; + +/* Specific configuration for i.MX8QXP */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { + .att =3D imx_dsp_rproc_att_imx8qxp, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qxp, +}; + +/* Specific configuration for i.MX8QM */ +static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { + .att =3D imx_dsp_rproc_att_imx8qm, + .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), + .method =3D IMX_RPROC_SCU_API, +}; + +static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { + .dcfg =3D &dsp_rproc_cfg_imx8qm, +}; + static const struct of_device_id imx_dsp_rproc_of_match[] =3D { { .compatible =3D "fsl,imx8qxp-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= xp }, { .compatible =3D "fsl,imx8qm-hifi4", .data =3D &imx_dsp_rproc_cfg_imx8q= m }, --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011033.outbound.protection.outlook.com [40.107.130.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33D372FE06E; Wed, 19 Nov 2025 04:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526165; cv=fail; b=eeU074jLvsgf3ThPKihlNLfqFOFzxoH0a8CuBLdV9ZVfWyYZfXEzXITPy4ctrmkGsfw09lyOQ5B4CMnVmQeEzyQviDvMTuGpC5+k/aVxESi+uYUdRouz6gYnC/m2CPjEYzeq8kG0ilemBaGE8f3nxr8rkdsMtOAkeYFJrrMSjMI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526165; c=relaxed/simple; bh=05nCVQQrlixRb9SgxB7/ptAj2YaE9uRzzg91PGheW7E=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=b8z/ynf5UYYTk9G+fMoqUyfUDV43oe/IXSPBmV4y3bXirOwE4kcMZODQYOQ6F9O8IXj8phAykwQ7GZEl+FXwtDr0KOaT6Qc6hHVM6f9nVTMhwzcZc0J3ysFUMshkZ2vhPu+1a1dEzTDWqJhnm4arlnDOixXdEn3gaJ5hXLq80l8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=P1wnxS62; arc=fail smtp.client-ip=40.107.130.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="P1wnxS62" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uEupa2epKiJCwjn/y1OAqnZ2xJ6j152yJHJYmanN7AlycNLFcVBPTZ8bVwgVtz4KkrTIzAXaE8a8EtkBudQ+vqGNy2v9DmNYqq8LthX1gXuifB1ped2UV8L+bBeGZZjpX4bSOZQ450fboyKsdmEqqkKLd6v0bRbCkVXpAEkJVV9oE1ugV8fBnpmmhDR4Rr73sqrK3fazHCAo19XIZX21A/i6cDRclKrfIY1i+x+VTFliCsa1A8tpJujCoQMeksZKMxgGi+JEWBK1eRPnBwO+vkQxw2VoA7dbIzvflcNDjUwkiMM41RgJQcwqTxeH89l/z+sxcMdVN+j5iyxQIuTsfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XbBVaJ7YReJ/X7A171JjoBProBjbDKamT6rt1r4ns8A=; b=HoFaDItLRDQZBcEMYqlFUWAXnEC9pbcCbxWnVzbD/EzAr0/6rREbkBsWPSVam6kloORf06sC9UX+gWFiOHr3L6kWCC0e5YhzDdFd4PsT4CDGepe2c8ugFXWM5RyoKV6saMgtuiTR/6oxb6Au/kmX2V3k6W5NCLJlHx8B1hMWhIIJslxy58NWazsZnxK1ZDi1XuJx2JWMY5xmJGRkJGBVSVOo8+LSEywhWUdcvS1f47dmKGZrM2jmmzLoZbyx8JpBKyd/amGnvmz+8TJDpyibXCX3E8wZKEStvoSszZ4i+dJ2f7QQMJQqkVNJDi6U+3IRm5Sm7DH7jBlIzYng66YCBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XbBVaJ7YReJ/X7A171JjoBProBjbDKamT6rt1r4ns8A=; b=P1wnxS62oawu3oJXlI2uvyrzcu6UBKV/+ySkAGLsVE87UEkOTr/FSGcMRVyJdXx/zuQZ01xieaLwHnAURWpg5EhXYfdjn8Mz904vsQrw2eVS4gE0aKZ6Blif0KcKOagkvYcShMvC+ALuVjY2/T3PadaCzmWFV48VbhzNfrnIvz/9yPf82wuGKrbE6aIYLOuZKYmOB3wItYR0/T5859N434wCON07b5mHoDlcPncQS5Bd1k+gJolJNwoO6fZQpc80IaFGZ/sfS0qG7aP5S6xzNcRgm+Mv7/op8ak7+h7vdjflvwH3mAoy2bUaGsuphgRrW4sCOkWnYUUScPlWJt2jzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9319.eurprd04.prod.outlook.com (2603:10a6:102:2a6::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:40 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:40 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:53 +0800 Subject: [PATCH v4 08/12] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_MMIO switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-8-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 6be71720-c419-43a3-335f-08de272346ae X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|19092799006|1800799024|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bW1BTmt1T1pBTTZ2TFVabzRrcGEvVWR1TGlPMm0zdWlqVGI5b0J1VWMvZ1BX?= =?utf-8?B?TVhML3ZjL0tYTlFxc3hxNExYeHJHTm9WRVNPb0tsY3c5MFBTeUJCZVNzT2Fj?= =?utf-8?B?OWV2WHRORWdYaEFiVGJUMU9aU0NsNEVQVE04SmEwOTE5L1VPU3NYS0JkVzho?= =?utf-8?B?RU9VMGpkbGRmNE5aV213RWxIVEUvK2lzei9VQkFnelp5WndwZVVlQ3F1UXlu?= =?utf-8?B?UHlqQW0wUnUzNlhRTEFFQjJqZ1hoR0VVWjdPTnFpekZBTDBxTmc4OHkzcUJm?= =?utf-8?B?aUV2SnEyS2VBWWlxaG83TnFTU2t6TU10TUtFRjVpVEJ3WSt2NGZvYk9EL2ZS?= =?utf-8?B?SUoybjdwSU4yVUx3QW1BR1hjZ3NkMC9paWM5eHA3YVJjcmlmZVlGOXRaTnJZ?= =?utf-8?B?VjlQM3ZRY1RwK1VaU0t0QWhZcm9zK2dick9QeTF4UTFpTEpPNTZXZ2M0K1Q5?= =?utf-8?B?SFRJMVdaR001OVVRZWJENEE1WE5EaDJEbUZHcFRZNk4zYUVGVFdXTUhmeWFT?= =?utf-8?B?K1MxWG1YUGVPY3h6Z1ZOYmdUN2lUdDBBYjRMMkxJaDRlT2RDOTM4aGFHeGMz?= =?utf-8?B?aHlJcU9ML3VwVzlxU3VuOExlVEdwcWtVWmlXMWp6bWRlbUNCVVFrSEozZmND?= =?utf-8?B?RkViVEdiWjZnRnZHUUtMdFdOZkIvMmZtbk5FZVEvK3VicEp2TXhHaUJYaGlM?= =?utf-8?B?N2pscFNlVWRqLzVqelU3ZGREQlRKWjhNbUtGb1lHWFEzK2RZZ0xMcDhSRnNX?= =?utf-8?B?Ung1VjRwa1JORXFqNXRGaCtXMnFOR05VZ2lHMVFiamRZUk9FVGlZOUFTV1Yy?= =?utf-8?B?WngwRHVYeDRhbXBiNVR4aXlQRGpDbzJDUUw0eVA4ZlFNVG52bXhidGEweTUx?= =?utf-8?B?cTh0RWo3dWc5ZjNiMitSR1oyWlBQVm5BYlhRV05DRVlNcUk5QzRBTThKejNH?= =?utf-8?B?TWNBVkpLSnRlb3VXTldPdGdVNVRSOFhXc011NDFrRnJ6Z2pqM3l1ZEpzTTZJ?= =?utf-8?B?RjBDd2hlcWw4YzJyaGoveTduam11UEcvZllXR2hvN0pvZlhUemZ4QkorU3Zy?= =?utf-8?B?eFJoTUlBcGFDeVkyTERHTFpBdEZQSEpremY1ZlFnZGloc2t2Y0I5V1ZUamwr?= =?utf-8?B?T3VUQkR5YVNtaFYvZ1pwRkRtYnpUeE1KTW1iY1Q2azhvNDVPSGFPaUtQSVph?= =?utf-8?B?TEZsQVAwVFV0d1l4eXJYcHM2c2tZVkJyQ1FKV0JnSUhlaURqZmtxcW4yZzds?= =?utf-8?B?WlNsVS9DdnU2QnFMWlFKd0ZEbE1uRHlSSlcyNmlUeWh4SlNYWnN2ZE9WL3p0?= =?utf-8?B?bHBLWVVBK283K1B6TENvY0ZhZHkvMlUwMTkzUnNBaWRCSzBlK05DSXpFYWo2?= =?utf-8?B?KzAvcjBkY1BEaFlrTmtmRnkxcGY1TW5nVkRBclRFV2grTHBUclBRZkZZcEEy?= =?utf-8?B?UHVmbTNMbU5ud0cyUXpnMmRaQnlHekxZZHF4RC9JVTFVeUIzMWpCZTlRS1h1?= =?utf-8?B?N05na241VXhSdVZwcVpJcmptc3JDZGJSMFF1dWE4b1pjclN6OVllV1NMUnJm?= =?utf-8?B?YVA1V2JvMTJDUWZGdWxrU05UUmQ4Y2srRC9ra3kvSitldU96T1VTcktaSFpK?= =?utf-8?B?VDVqME1ueGUyUmx5d2d0UHRjWW9hNVpEcW5sL2JVZEtEbFBqek9GTmd1emsz?= =?utf-8?B?S2JjSnNHbU9ydGpabXR4Vk5PNTVnL3lpQzJ6Rm1ka0tUalJKdS8xN3g5dTlu?= =?utf-8?B?M2ZGOE9NOEgvT01kR0J4QkJta0dadDV3L1BiOStpWmlyS0tlNlA3ZW4rc2Iz?= =?utf-8?B?UnV4VTN3Z2t0VGhaalFVYjVLWGNhVjc0bSs3NDRHUG1MdWNidTFSdnI1NVV1?= =?utf-8?B?YVMrcjVZc29UNVhVTjUxaEZCcjRZV0xjSW5UTHJKUklKdHgxYU9zdS9oa3VK?= =?utf-8?B?U2hDS3FTRmllaTI2MlRJNkpncEd2ZjEzU0s5NDB3VUQ2WVdpMUxVUXFWbEpp?= =?utf-8?B?S0M0eWZDbzV5TmNGZFpncGJ1WjM5bXk2S1A3NEJ2WWorK0dUWFNaeldtUGM3?= =?utf-8?B?ZTdjRXVST21uMjJMbVk2OUZzK0E5Y00xbXRPUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(19092799006)(1800799024)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkVFay9jSFg3ano1NEREYlVWaTNtYno5cHpGVjAxdW1LaWgzSnQzR1pkZGd6?= =?utf-8?B?NUJ2SWdybVAzOVlVdTEyZklSVUZXaU1SZ0s5cGJFeWpZcVpLcTVGMlczTnh4?= =?utf-8?B?TXhmMGw3NzNGczloOWFQcExoMHBlK3F0VGVvd0N5alpMYTlseGFreEFNWDBM?= =?utf-8?B?aDJDRnRBMG0xSGU5YnNCdWx1YmNTeVorV3p6MUdWWU9yZGZqUEgxWVFFYTdz?= =?utf-8?B?elF0VkMyZXlzdWVZVDdRbDdFclR3RStRM0Rpa0hiUHFjNVZrRUdHRXE3WXJP?= =?utf-8?B?cXdCWVVPcmxaNnhkSnpiYWgxRTMxYTZzQzhkRXEvUHRZL3U2SWplbGtONE84?= =?utf-8?B?MXRXT2pES2dFVzZqMEgxVnJUenNxT0VIblAxNXZub0dqZmQ4TEJrWlRDRVBj?= =?utf-8?B?VVk2MzBwRW1hOXJURVlneDdsUGo0a3phNkU4dVRKMVZCaDdqWEFCWGZWcDFw?= =?utf-8?B?M1lvc0JFMEZ6Y2RjNUEyb1JWUkN0Ti9JQ01mMXV5OGQ1bFhMbkFNdHEyT2dO?= =?utf-8?B?aGd2RUFNZDJMZStFYk1TQ2c2bER2L2Z1K0ZGaHBzZkdyV2NpTDhtbUtqc0FK?= =?utf-8?B?ZkVyWFFzam0wdWhZdmtYZGRBcGxzQ2Y0Smoxa2ZIYm5FZWZONy8zNDFsNURp?= =?utf-8?B?UFVHR1FiMnNsV0pMdDI1bEdnQlZJZEVLTy92Y0ZKWkhlQzVWRE84S2dMTm94?= =?utf-8?B?YUdZeEoySXNUdU92WDROTnArMmlUcDNHcTROeTBCenYvVjR0ajdKVHNUdllF?= =?utf-8?B?UkJ4ejRUUnpzYlVzTXk2ck5aWmliaU44NUNRYVE2QytsTlRhRVJQVFBsUWRO?= =?utf-8?B?NWJnb2Z6eHdmT3hUNG5UcWI4VktZMG82KzNpZlBaSVpXL2JGSzlsNXpVYXhk?= =?utf-8?B?S2l5TzVFUDVwa3RuNXhHQUNlWVgyMU0wY09Pdk5lSW5QdXpmVzI5NFdYc3NP?= =?utf-8?B?dG9hWkRXV3V6dXB6dWxCN2x0cW01NWlkdmoxMnRsNEtWN1RneDlIbDdMRFdi?= =?utf-8?B?WUk4U2RvZTBCNXhOWFltM3Jac0JteXV6V1U4U3dFbjFtZDhVVjZvSkUyV0xu?= =?utf-8?B?bk5KL1JCcTdRWWlpNEIxQUhkN2RUZDlYdTJrbG1QemIxZUdzVTA3a1FHMHN5?= =?utf-8?B?SzQwOXAxOFZkRFhDYkZ5UER3RVlJdi9zVjhOT1A1VUgyRDVFWEtVclZINVJJ?= =?utf-8?B?SExRTEtLZVRWU1BxZ3VPdEt3Qk9yV0pHK2ZwT1cxbzJWVnhjWkVaem5tRjJr?= =?utf-8?B?anBrMGkrckVOTXZKOExqVm1UU3hoQ2Q2cHJiZEVRcXFyTmZnZWxYTTNYdXJx?= =?utf-8?B?aVA2STFnZFQzS0dFU1JhcnUrRTY3YlhsVXVXQXI3Zk1LcFJ3VHR2T2QrM2k5?= =?utf-8?B?TllOOUhiSUpTUm5EZ2ZXNnAzL3E0RllsQUY3cjR4RTYzdllDZTEycnNJa3BO?= =?utf-8?B?RERvcE91RWR2R2VkUkJIcjk0T0MxQ1h0Nk5qK0JVZ0pERTQvUlBFZVFwNmFX?= =?utf-8?B?OE1yeE5OUERpb3JVZVJkZlh0dEVUVHNRdlc2ckFOekFPK1dyMkh2TGM1OVlZ?= =?utf-8?B?dGF2RGtOK3g2RExzY0ZmMDNkWjJybzdaOXFDRDRzdHE2ZnFvMy82R0p5WWVl?= =?utf-8?B?ZEZHQW1RUWJ3VkRMZGVIWkdERWVUU2wyK1lmVTFtME1oYm9telBLUVcyTE02?= =?utf-8?B?bm94bUZ1TGFLNGNRLzNiZWdpTXNmaEZheGc0TkF6YXVPKzl1TUlsNHZXSkFV?= =?utf-8?B?S0JXbHNaRGF2Z2tyOTBaTTFZRmp6UlBCYnQzVytMeGN2OVgza1BQVW91UEp6?= =?utf-8?B?Q05SNnQwU0JkRUhqcHlWazVjcUhaUEduU3B5S0RaZmRqVmFjR0JUUVdCVnM2?= =?utf-8?B?RDM1OE9COVFTR1BsMGxaeS9YZWhRNExOb3Uya3dFTWF1cDMzUGFaU0NxQllw?= =?utf-8?B?Zk9yTERVZjNqdnpiTDNXbmQrcE45R1NWRDNaYlJyZTR2M0ZBRFpkY1FCelpj?= =?utf-8?B?QWx6eDVNdGZrK0ExYnJMcGsxTVdIS0xxSXBmMGErMkhjbmEzMUNBQnBKdjNu?= =?utf-8?B?cEEyeTZuYy83TnBOZTRYWnJoN0wxdlh5VTlOU0lJblZMZDYrbHdLcVExbThy?= =?utf-8?Q?2GJCECMXZLTRkdvq1aor+6Zn0?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6be71720-c419-43a3-335f-08de272346ae X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:39.9037 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: et7vUBgZmvNwQPPtA5EbrA2DzInNRzrXj6ube7dyi4Ya+AhQuuhXcw9zZSt+h5Ehy6eB5Ajjx6iKqqdHQ2rXtw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9319 From: Peng Fan Introduce imx_dsp_rproc_mmio_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_MMIO to manage remote processors. Allows the removal of the IMX_RPROC_MMIO switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Frank Li Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 61 +++++++++++++++++++++++++---------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 40 insertions(+), 23 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index f28d25cab3f1d89e5cde37a04b528870a59abeed..71776816c3508a86bf7b8a09ac4= 5827a83a7bb3a 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -338,6 +338,14 @@ static int imx_dsp_rproc_handle_rsc(struct rproc *rpro= c, u32 rsc_type, return RSC_HANDLED; } =20 +static int imx_dsp_rproc_mmio_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); +} + /* * Start function for rproc_ops * @@ -360,12 +368,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, - dcfg->src_reg, - dcfg->src_mask, - dcfg->src_start); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -388,6 +390,14 @@ static int imx_dsp_rproc_start(struct rproc *rproc) return ret; } =20 +static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + const struct imx_rproc_dcfg *dcfg =3D priv->dsp_dcfg->dcfg; + + return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -411,10 +421,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_MMIO: - ret =3D regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, - dcfg->src_stop); - break; case IMX_RPROC_SCU_API: ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, @@ -1032,6 +1038,23 @@ static int imx_dsp_attach_pm_domains(struct imx_dsp_= rproc *priv) return devm_pm_domain_attach_list(dev, NULL, &priv->pd_list); } =20 +static int imx_dsp_rproc_mmio_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + struct regmap *regmap; + + regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); + if (IS_ERR(regmap)) { + dev_err(dev, "failed to find syscon\n"); + return PTR_ERR(regmap); + } + + priv->regmap =3D regmap; + + return 0; +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1049,7 +1072,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_r= proc *priv) const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; struct device *dev =3D priv->rproc->dev.parent; - struct regmap *regmap; int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) @@ -1061,15 +1083,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) if (ret) return ret; break; - case IMX_RPROC_MMIO: - regmap =3D syscon_regmap_lookup_by_phandle(dev->of_node, "fsl,dsp-ctrl"); - if (IS_ERR(regmap)) { - dev_err(dev, "failed to find syscon\n"); - return PTR_ERR(regmap); - } - - priv->regmap =3D regmap; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1301,6 +1314,12 @@ static const struct dev_pm_ops imx_dsp_rproc_pm_ops = =3D { RUNTIME_PM_OPS(imx_dsp_runtime_suspend, imx_dsp_runtime_resume, NULL) }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_mmio =3D { + .start =3D imx_dsp_rproc_mmio_start, + .stop =3D imx_dsp_rproc_mmio_stop, + .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1321,7 +1340,7 @@ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8= ulp =3D { .src_stop =3D IMX8ULP_SYSCTRL0_DSP_STALL, .att =3D imx_dsp_rproc_att_imx8ulp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8ulp), - .method =3D IMX_RPROC_MMIO, + .ops =3D &imx_dsp_rproc_ops_mmio, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8ulp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index aeed08bdfb5619c7afd7201589f417cfd6745818..912827c39c0dedeed76c13740ef= d42a8e7cf9c45 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -18,8 +18,6 @@ struct imx_rproc_att { /* Remote core start/stop method */ enum imx_rproc_method { IMX_RPROC_NONE, - /* Through syscon regmap */ - IMX_RPROC_MMIO, /* Through ARM SMCCC */ IMX_RPROC_SMC, /* Through System Control Unit API */ --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011047.outbound.protection.outlook.com [52.101.65.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED5EE2FB094; Wed, 19 Nov 2025 04:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526170; cv=fail; b=bsZj9aUF8cCwXpTq28bEiBUi5sVh4Y2sYoZT0OSzIofvWBuX8y81rdcN58EKi/Yc9FJpXrkzOT9NUlx38S6qUZ65EKjJwt1rFMHxprKrjl32G59ccSc5YXtk6Rro6unkJwld5VY6n9wqPoMytKJll5An+L642kgMCAy2aJ/fB6s= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526170; c=relaxed/simple; bh=20bvPCn1BIpf1Wg1pzFM659Gz0cAUYExqPmZ29/1Jmc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=dXfndYqxHodGCNYujgkmrrbKzxlY1+f1YiYAmN0hhHfVt3Vl+v2qHXNLvThctxQQ4PBZf2XhwBYCUcvRBcLpaSfnUCn2zpRMrD4jRVyV3Saj3J4zJ0dLjFtXA0X6/JrcO6SLZVW3nRb7yl8kcDBRA5vgZ1N0py+p7xzBgpuywks= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=X0j0VVcG; arc=fail smtp.client-ip=52.101.65.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="X0j0VVcG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X4u03Rq4oV+LaHXg5l9w28Nkq/fmEjkl3gPE8pdF7yNjJ/BmJkFqEQDdMF/RrwUm7Sjuh2E4PWUDywgqN1pK0A5MyqWwGafKLvXJTYhXpNCiOn0h3RDjZzayeBgBWEbr4mYGBkGKJ72KxJ68D+hcoPiEv7cm0fXpRv97lpP+EUi30krCIgFIg+8p5+xp/iGV58JCnxrGonHiXCeUqunhLIcl+/ZNiQAGvQ0FwkM7inEslJrWY8CBwny3FpYapM592meNoRkOZnxDEZ26G9hIcOcmVb+Qby84dzJgwYuqpxKeIR8EtaDnBJWHCBb4IUS7X4XH61VFS9wvyX/IA9aLMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/p/yqsMHZhWKnZlfANxUcEBPdqNnSFo8xIg8MPc61i8=; b=kxXV1sMmR2XMRo1o0PiOoFk6YvCy4cLG+0mCBDhpcMhX9D5bcWgXd9AuQBKGyFeEWMRO1SO+E6r7qFkjrQTuPRkkjLYbKOETKRlPz8JLZxJ/Mu+0jBjBm+AQmYjRfbOPUHzWaZt34sHWT2apqxd1xMJhYeK2zojda90VGwMFm0snGN/O9NrzI3exOT8HWS0fDoIT9avjdbZY7WwnbKtRyjWVy6f+nSCDHT8YV5zXEANS0cR552KxuS0ZD61RMhhZbhhKooJNqXYwbm0B6qFu+CnaB4Q8QwgF1fvZTUt+Z4TnJzDtixKYVndPuNygyof9mDjhXlNIX+KafXXIUvqKfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/p/yqsMHZhWKnZlfANxUcEBPdqNnSFo8xIg8MPc61i8=; b=X0j0VVcGYndmSaV9dMQxpQ/pd2npsZxYrOD36Gt1jijGlNMWibrPER5pvWwPkELT6Ahcwys+LP9Os/iO53p+9sjvI/LXoei2JdoBZFQFWJRXiKr+pfWRHCgQ8G0TdZns0uuvNZmC+NNWWOzaERXMJbXAv2iQGGrj7FfD5sX/iATN5HWyg1lhRXg/por6RYxCT3SeQddrOfm9fnU4k09VCIlJTawik5FcOGHeN5xE8UyCQAnpcnrlxhVN89sLQdPHRTM1LgwBuOseYNNBUOh7Y4hQNpleUotAyV9XXtFj/1EaSORF5Hx4lXlNzMrubSGYurJAcbBIJOavH/3zjy0NzA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA6PR04MB11949.eurprd04.prod.outlook.com (2603:10a6:102:514::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:45 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:44 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:54 +0800 Subject: [PATCH v4 09/12] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_SCU_API switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-9-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA6PR04MB11949:EE_ X-MS-Office365-Filtering-Correlation-Id: b71530ec-88ba-4dc7-4e72-08de27234970 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?S0FXdWEvWXZJN0ZBMkdDWmZoN0YyS2ZQdnhuK1ZyUkxsZ1RsdWlFREFpSWdR?= =?utf-8?B?UGlISjFHY3pBR2NWSFM5UUZjY0FNcWJueDFNcHNXRENMSFpYcTMxemRIbHpI?= =?utf-8?B?bDdTS0UwY0lsSVBGWDBsQnFBbVBTd05NVGJuNmsrb0JFM1g1T2puMUl0QWdX?= =?utf-8?B?QXBtb25QSEJnWHZjYWxaVjBSNlBiYnBhVU4rb1k1OXI4N3NXN0NobWxyN2Fh?= =?utf-8?B?bkpGSnVLSXZlZThjTGpSNmhuTVdBZDhOenpmS1lBM0MxTTIxN2ZDMmtlY3VN?= =?utf-8?B?WDFZa0htbk9YSjhFR0RZQ3lZR3V1cjUrTElNanNzRFcrZzZGMkpFenplZE93?= =?utf-8?B?Y2k2YVJWZmtPa0lzTXdheThQUlZRYm4zYkoySnBzMU5TZmR5WnFQQUJwL1hm?= =?utf-8?B?b202Zzh6TWtYK0wvRS9la1p4NGh4eXA0ZkgrNGRhOUxvMW1sRXRjT3dMUkRM?= =?utf-8?B?WEpaYXF4VTI0UDJERTZJanR4UytRRDJKTTdxc2t1QVg5T3duTmp3eWRmRjc4?= =?utf-8?B?czFhZFV1cDUxSmpUSHZwak8raXpyQzB0WmxDV1I3ZGZNZnFZZFVad3pycTlk?= =?utf-8?B?ejVrZHp5TVZJQzhRMUxjQkd5NWRJV2pSZ1pZRm15d2I2MHlrTW9xVWxXTU05?= =?utf-8?B?a1lNeTJRUllUcTB1Qktwc0hZL2RpYUhiNE9iTTRweFltNlZsNjFVRzJxZmRw?= =?utf-8?B?dW9qdkFXY0RVWU42aGtybzBmSUJzZTNBdHRlaktaWHhXOUF2SkdZbTZEdXI2?= =?utf-8?B?WksxZG15b2hxbUlDeGdTYXA5WnFRbTNLYzRGTGR1TGtoS3NheEpqOGNaVFFG?= =?utf-8?B?SjJrT1pUNzRpYlFaSmRUWDVaU3o5L0FoMTFOaFB1QUtZQ241Z3V3SXlwRUtQ?= =?utf-8?B?V1lNZWk2Y2U5UExtRU8wMWkxdUl1Um8xbkJGMWhYTXljckx4enJzSHJCOVhp?= =?utf-8?B?QjRudTh2ZzlwZ3ppa2NUQXc1VVRoL3pYL3F1V1ZWMllrUWE3NWIrdXUrdnlG?= =?utf-8?B?RFZTTjhOd2pKWmQzdytqOTJtLzhOcXlRbDRjSnpBb0p5TExLMW1Bb05VdEpS?= =?utf-8?B?bHZiRFluQ2xYZWxzRzlTRWxxYUJHMVYxZm5jRmR3Tk8xaUNJOVhDa052N0lx?= =?utf-8?B?dURzRFl6M2VVOHZ6TEcrQ3E3Ty9aZkg5M0QrQTZnSk1RTGk0TkhHTzliSlB5?= =?utf-8?B?L1h3ZEFMSjVDQ0wvWHZuVFFCczhyV0Q4SEd3YXB4MWE1ZGdIaDhGRDhkZFll?= =?utf-8?B?bGJJMTh1NEEwYU9hdnR3N0F6RXBZcEV1TkpEelZzRmwxYnpJVGMvbTA4K2Ro?= =?utf-8?B?eXIvdm5rQXYxY3JDdmNQOU1jTWoxd2F4c2lTbjBRWjBudmR5RSs1d2d1RDJP?= =?utf-8?B?dWpaUVRsb2hMTUtXak9LaGl4eFF6bE5wbzBKa1pYajgzeThMVzdtQW5oc3li?= =?utf-8?B?UUJpQ1p2L3JpRDd0RUZHVmxBczl2ckV6b1YvMENsQXlMUEQ1Q0FrL010aGhK?= =?utf-8?B?V1Q3dlJhSnVtSWZFQ2plVWxEYkYxSnF1akVVbUNCRmF6WGJzc0pVUkNzcE9t?= =?utf-8?B?cTN6b1FFRG03WGFpeHZYRmFRa29mSzZva2JFZFprbk5hN0k3a0lUclUyc0lY?= =?utf-8?B?cXdGck9qeHlGOGc2ajZQc2Vzc1plbUVId01NSFA4Q3ZGMzg3MlBvaE1pOGli?= =?utf-8?B?MVlwVEhhUXZ2b1czQWY5d1RWU3NDdTRLL0tKTkJ1WUNjdG55ckdlU01FQ2g4?= =?utf-8?B?RFhBb3ZtQ3hKaXhpd2VzY2xuY0taV0dZZzEvdnlZcUJReHk3NG9qU1pxNUNP?= =?utf-8?B?YzB2OUVYV0lkRlNTQjZiL2EySlJYRGpqZmVwMXEwZnlwOVFjWnNDMUErVGdI?= =?utf-8?B?RmFqSkVzSVFZa05najUxQmtsM3hLK0dha29JQVh5bUFZSHFTOE5FU0ZYdDhJ?= =?utf-8?B?ekl2cDlLVEM1Yk83ak1iRVhBTVM0YWRxOFVvTEFCaXZuY2xjdCs4TW9NODZZ?= =?utf-8?B?ekluNnFMMktzRERjZ3I0ZlQwVHNJZW1VSDVvMWkrNUIzQjVNcUtjLzhOR3g2?= =?utf-8?B?SUYvVnZEd2ZwU1pwUFRldnQrYXBLWXM2N3oyUT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFV0alR4YkppVUZFV3BtZ2MyTTcwNnVYc0dpdy9RSlRDeXVQUUdIeXYyU1VT?= =?utf-8?B?SW5SbkFwdnRzUkM3a2luSzR4MjNrNXVlYmt4NWlhQlNMU3FDdTM0YndkeGdn?= =?utf-8?B?ZFNoZW9GTWNFdDlFcXBWSkxneWtIRXpTbThJbzEvR2tXL3drMzI4d2VKbzdE?= =?utf-8?B?VDlaRkg2Z2YvbEE1MVJaVXVTa3VyM0QyTWJRWG40NTNqQTJVUzNOdkZzYXVx?= =?utf-8?B?ZGdxSFhRYVdvQkdSN3RvU3VpOUNKaDRzdldLSVRDdDRDRVRkaHU5a3ROSmYw?= =?utf-8?B?UnFCOEF5enlZS3pJVjA4M2FSbVp1ODkrcHZscjdjNHhwS1ZNb3BqTWpZMHBa?= =?utf-8?B?blcvb1V4WjBSNWlEajErMlRHY0NWMzVLeWVpZzAyME1kaWhMWld5eGhRZ3M1?= =?utf-8?B?dWNhU2gwc21YY0N1emxTMDZYSFBuZHJlZkpYL21XSG1ZSmlUOFlPRm4xQW9l?= =?utf-8?B?R0VtcWYzeTh1blNSb0svakZqMGtOWmlQVzU1TEtZZ3V3WkluekI4c1ZUNEE2?= =?utf-8?B?b0lVOC9UMDRVWVNPbGtaU2xPc2Ztak1wSlFINm5uOTdqOWx5dGttTEQxSXZK?= =?utf-8?B?VU5TMkRjWkdMOTRiWjlXTm9KUUxGNWdHN2E3cjFQM3NyaWhabDM0R2hhV3Q3?= =?utf-8?B?d0VpTG4vQk9pWGJWTk1IUk8zUlBOL2NJSU5ZMnpydCtxYmJiSmpTR0F5c0g4?= =?utf-8?B?OXZPSnZPanJqcUFxUStkMi9SOVVSeTBESUZMOEo5UkdUVFpOVGg0cHJ4NVY1?= =?utf-8?B?SUFpUW9udlB0dGZFNk9Zbmt5S3VqU2FCRTM5VTNOaVpaVHlwWUdSaFdrR21w?= =?utf-8?B?NjdkN1dWeFRYek5zQW5ZVGxpOWVsd0d2TXVBTFFWL25HQ2NiMkh3VWJ0SWl1?= =?utf-8?B?TGM3OE8xWTZXWXkxKzBta0h1RkxwNjd1QXJjQU5WeUFPRnhGeHJIOVVjM3JI?= =?utf-8?B?WjUzMjdkYk56TTljUElBVFhBRVd2UXRvNGpJV0dFR3lPeCs5YVRNeTlSMzIy?= =?utf-8?B?V3dyb2hicnNRT0UvRkk0dFNqZ0FnV0dWNmJka29Zem53ZnNIRnVEamFKeTZq?= =?utf-8?B?QllBS0puVWZOcVllQ2ozRzIwRkRLSTRrY0svZmxFTmp4blNmL3lpaHlxNlov?= =?utf-8?B?QVFQVE1ERkl1RjZ0NitGZXRrOGEvcmUxcWVyOHF0dlhMOWF3STRDalBoVlVU?= =?utf-8?B?ckw0eTUvK1Z2L1U4S055dkdhQVdEcWYxQklEL29lR2pETGgwWGROS20xWEUw?= =?utf-8?B?VEdkdXpLY08zc3FEeFJuTlpFMmJHY3Y1UWxYWXd4QzV4R1VSdlJTZ29TNU9y?= =?utf-8?B?TnpqdzZYUlY5b2hraklNVEJxL2dGOW5HMXo2cTdBZnFxVWZuMUlHTzl4L2Zv?= =?utf-8?B?QXppQTJYeExkRGtnRGV1Tzdza09nTG5lQnQ1SzJSR2k1R2RPb0NsSzRscSsr?= =?utf-8?B?b1J5NUlvU3NkWXViRnV3Q0trd3hWSlJkOXphWEhoWmZYTmFxNWhJRUdENkJM?= =?utf-8?B?ZU1Sem81ZVNnZ1c5ZHJkaEVrWmlBZjQyYXVwZTRHaFFWaXMyZ1JYd2E3Q3Fy?= =?utf-8?B?bERxTC82L2lPRU4vVkVpS2VBQVluQWxtOHUzUmRVRDViZFd1cGYxdkQ5aFNM?= =?utf-8?B?ZFVXem9rZ29MNk9sTDJ4UlRBbmNUS2ozU0lQdmRqeFkzaGthR25RNWc0bEpN?= =?utf-8?B?NEJwUURhR1AwVzlVRTZsRFVsZnByZjJmSzdyVEJGR2xxQ1M1QXR5eTJCQ1Uz?= =?utf-8?B?aFAybHFzVkI3NmtuRnd6VWRzVkZBRElYa2diaDByQXBkemRWdW9yYVJVNVNQ?= =?utf-8?B?QTJBbkVWVlpCK2NadFBGY1Y2RDdGRHVySW03K2syQjFPc0lwOHBVVWZ4OTVJ?= =?utf-8?B?S00rZWtWK0ZZMGJocVlRZnVYNE1QYzR5YlZCa0JlRkJnclJmbTFnNjlXV0h6?= =?utf-8?B?NHdjZU56NjMxakF3TlVvZG9PckhnODZDM3dHVEIxdlc3N285NU4xeXRQZmRU?= =?utf-8?B?ZVZzNHJmeVk3M1VFbEY1NU5aRy9NNWFLVzEwSGh3Z1NSUVhISXlsQ2Y1MytV?= =?utf-8?B?UXA2LzNnSHROVzVGbTZHRGxhb1RWWkRaVHBKQUppQnBGWUF3ek9IWGl3Y04v?= =?utf-8?Q?ulnMw2CE44GQNsm3VpBQAyGse?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b71530ec-88ba-4dc7-4e72-08de27234970 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:44.5548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AEk4PzmZ+b5JxfW/L7wyoPycbBnYL9DSWk6uf6G0yfl1guH0M3M7D4GurwJhpFvpFZfMh86JKTI906MykjgpcQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR04MB11949 From: Peng Fan Introduce imx_dsp_rproc_scu_api_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_SCU_API to manage remote processors. Allows the removal of the IMX_RPROC_SCU_API switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 48 +++++++++++++++++++++++-----------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 71776816c3508a86bf7b8a09ac45827a83a7bb3a..91d041c15ac19f527f48c818942= 1f71fb7c9745e 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, true, rproc->b= ootaddr); +} + /* * Start function for rproc_ops * @@ -368,12 +375,6 @@ static int imx_dsp_rproc_start(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - true, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_deassert(priv->run_stall); break; @@ -398,6 +399,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_sc_pm_cpu_start(priv->ipc_handle, IMX_SC_R_DSP, false, rproc->= bootaddr); +} + /* * Stop function for rproc_ops * It clears the REMOTE_IS_READY flags @@ -421,12 +429,6 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) } =20 switch (dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_sc_pm_cpu_start(priv->ipc_handle, - IMX_SC_R_DSP, - false, - rproc->bootaddr); - break; case IMX_RPROC_RESET_CONTROLLER: ret =3D reset_control_assert(priv->run_stall); break; @@ -1055,6 +1057,13 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return imx_scu_get_handle(&priv->ipc_handle); +} + /** * imx_dsp_rproc_detect_mode() - detect DSP control mode * @priv: private data pointer @@ -1078,11 +1087,6 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp_= rproc *priv) return dcfg->ops->detect_mode(priv->rproc); =20 switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_SCU_API: - ret =3D imx_scu_get_handle(&priv->ipc_handle); - if (ret) - return ret; - break; case IMX_RPROC_RESET_CONTROLLER: priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); if (IS_ERR(priv->run_stall)) { @@ -1320,6 +1324,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { + .start =3D imx_dsp_rproc_scu_api_start, + .stop =3D imx_dsp_rproc_scu_api_stop, + .detect_mode =3D imx_dsp_rproc_scu_api_detect_mode, +}; + /* Specific configuration for i.MX8MP */ static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, @@ -1352,7 +1362,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8ulp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qxp =3D { .att =3D imx_dsp_rproc_att_imx8qxp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qxp), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qxp =3D { @@ -1363,7 +1373,7 @@ static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_= cfg_imx8qxp =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8qm =3D { .att =3D imx_dsp_rproc_att_imx8qm, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8qm), - .method =3D IMX_RPROC_SCU_API, + .ops =3D &imx_dsp_rproc_ops_scu_api, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8qm =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 912827c39c0dedeed76c13740efd42a8e7cf9c45..a6b4625e8be76c6eb6a5d8ef45e= b5f3aec5fe375 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through System Control Unit API */ - IMX_RPROC_SCU_API, /* Through Reset Controller API */ IMX_RPROC_RESET_CONTROLLER, }; --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013052.outbound.protection.outlook.com [52.101.72.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7712FB61B; Wed, 19 Nov 2025 04:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.52 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526174; cv=fail; b=uTu0DTqTua4S07U3XI0Anw/Nppe1ovsPMUiZJKsa7gL9n007MnOC5TA7ojThai2/wFM0gpvZdniMI6Z7Eor/or+ipDb81wrthVSBfmF78BWDP32u8YpwD4O/hUuCEb9tsU28dvU/2fJOD7knDkB//QQAN374mxFDTaHSO6s1wYg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526174; c=relaxed/simple; bh=Yr82yOdm66SgSJ2YaH9OM+lBu/ijq+WL8xF/DLYxr18=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=g5SIWBMKyvOqSoZVyEG+Rhh+FhEHmTLq4bWm+XgbtXAv7r1dnS32bn3V6BB+yENY1hFnYGm0ln6Mbvc8yQeTJ7jmseXLFZIgbaXf3GvxuWElJrOA8lgwp+zld/HnHuZC+Rewlwi4OJZ78VZ5FE991Fd0drBfNhtus21fyEL29Uo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=AZCP82UU; arc=fail smtp.client-ip=52.101.72.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="AZCP82UU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NyzsAymxK+oO7syX5st33d14wGMEcs154gDfikwgPbAi0JzrIrK2xhv8hTCz/Il+gr5bKEVScWW4V7UcE8w7rUIk0nTbd14L1D1QYjoQZCzt3GCWJLtR4W2w/FxWpVzFeYKK6mX/9fdK1dsE7mavwZRmzLDGlkHoKswce0M4cwCvpggxcJosEia93LvQdqof2wdrg+VOQ7VBVEFIuy9+JVUAfFpgnsLUWM/vJJs0BS+2gobFzGaJUR/hkKeDhreUvLvpAcQP1R+/Z/UChg7z+I3NYHFGd9SoL3D528ZORQHJIhCCYHL/8/diK8eZ4FDgi8hpDsnqJdvmwE6qF2kMLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ns7yXApjNzw68k2vxHh/3oBG6f8suEGqwf/pfzBi+yA=; b=wjbLKC9tMf8Izn9qKF3HuwG6FYKgFFUfJRlREvQwBUgGVtIb+FzqZukW3atkGIFerYx3v8hJ1mEoiihk0KqEkRjVeU42N+im8ZU5cFrcma08bG1RMRmSlxVB3bE4iDB5ls2dzHD8P7uyEmeQzZbJVLfTWmIEqRNhGoDnuNgIJER8FiZ2UbfpT3En05YAyvro1shXzwtGXThFZv3NmIhCZy9AQZDwNxBrugZqprxvMIlEgl7oVsexp/JEldoVESDCW8lQeWPRJ/a2SrhRiwn/e+GjOYP5ihGDtVZ1quAnVO2wUw3ADiu1+NKl9i9GJaOBu79oWiwrf4f/uhnPAkzuCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ns7yXApjNzw68k2vxHh/3oBG6f8suEGqwf/pfzBi+yA=; b=AZCP82UUqWxA3ZeJ/G5iqGswgWV9/OR62+21NLopZHZFxS22OUs9IeClhEN3KYiuUgUSvmJ65C5FUNpHkGL0fIsjsIVeAJd9ATTRSneFi2R0hf2+hkc+eyLJxRj4pMRH2w1BA9mxjlarbnOdVSs6NCd9rpsr74djcBm7JSa4pA/+dpmsNav083mlUk7Z0hDtTsDhgQoyHSOqVm10Ljt6yObn5ycfV/Bl7OGRQ3J+u1HhcjH41wUpo/gq2R/2lFz4pOZMp00Ff8800GOpi22ExptGqwq2cR3wLd9Z6Y4+YkI4AYr2XF1fgbqw6GddnnNe5vZ0WRL1RVnEJiiJmCMcaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA6PR04MB11949.eurprd04.prod.outlook.com (2603:10a6:102:514::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:49 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:49 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:55 +0800 Subject: [PATCH v4 10/12] remoteproc: imx_dsp_rproc: Simplify IMX_RPROC_RESET_CONTROLLER switch case Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-10-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA6PR04MB11949:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f037da0-8206-4211-f58c-08de27234c33 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MzZzNnVxSDdWUHArOUZJY2FTY0lJVDVxM09jSktHNTNEelBUUG4rUWJDYldv?= =?utf-8?B?VndvRDA0S2oveFNWQUlWQStqbW04SEw4MGJJL3llYWozM3dUTXJHN05TV0Vn?= =?utf-8?B?TmptZ0wyRjNkWFFSdC9ZMWVSOWloU1BmSXpUSGJ3UEhEYlFQdUprd3ZCclNh?= =?utf-8?B?UTVuaFZKc2NKSTRXb0FINnFsNFB2UGNsSEFJdTZUNExCV3doQ3lQK09xcDFi?= =?utf-8?B?N04wMXZqdm9aZTErVXY1QXljYnVtZFZsblNVeUFJZTZwb0czWENFV3ZQVzMw?= =?utf-8?B?U00zaTl4SnJpUWZUNEtBSk5JTFhCYjdJRlFWQVJCc3dvTHlZbngvK21PSnQ2?= =?utf-8?B?dCtVT05Oc0J1YWxkQXlILzN0MFB2c3U4YndRUlp6R3dMNC9TYjYxSmFyeDNX?= =?utf-8?B?R1d3bU90OW1ERE52OFJZMll4RXQrUGtsYU8rd2c3L2dtd3o4TDYyTDl4V1Np?= =?utf-8?B?Z3VoYSsySFhOdU1ON3NGTlAyOHVQMDV1Sitjc1VqNFNOZXUvV2VoT1VrZ1NH?= =?utf-8?B?aU4zeVl2c2haNElISWdzclhtYUwxaS9uNHFXem1lV2dnMUg2Y0FtR2NCSklR?= =?utf-8?B?Wm9DbWEraVYyMGNSZGVtWEM2eXpOYWUrQ0xxYWozWmR3UU11YmNyd2tDWFR4?= =?utf-8?B?Y3lpVmtsd0VIR2lTQWNFVlhJS01LY05IRDl5Y3M2R2xCNVlvRktrVzV2WTNO?= =?utf-8?B?ZEtERkZKbGN0MWptdnhmQUJsVlVLaDYvdjBZaE9ZUDVXYy9scm5zQzlqTFAr?= =?utf-8?B?SWF1RXRTNWMwKzl6ZDNJTkFPdlY3TDd6QW1GT1BkcXVHOFZzYWFLdDRCYnlw?= =?utf-8?B?bTl2WVNzYTViM0ZJWTdxajFCN3FxcmtEUnl5MTczVXUyVnBYOHNIMzlyL3ZH?= =?utf-8?B?cXorVzRGWThRM00yZktXVm8yOHRjeVY5SDY5eEpIZXdVY0hqVlpYajUrT3Br?= =?utf-8?B?L3M4bG9Ca1o0UFRROUJmME5wa1FkTUpzanZWM3BpbFMvQkx0by9mVUtnTkRs?= =?utf-8?B?cUdLNndOTjlZcGtrTnptUnZNWnRPUVlUZG85UHpCem5hZE1tV0dnOUxMeWlt?= =?utf-8?B?NFI2ekl3MWRRN1k0Sm9BOFFZcnpydk9yWU5wbXlsQ1Z4SzRJc3RxN250R1My?= =?utf-8?B?ejJtRGJJc3dqWVFiL0pOWmFsbkRpYjlXME9aelNmSmRBdEZDSVYrMXhaVmNx?= =?utf-8?B?T3c0bVJ6aHE2czVtMmU4SmMzNHZZb1J2ZVBhbGRIN3Q3V2pZSjRoVmRqanVP?= =?utf-8?B?N2FsaW5uRFdxUVk0VUpTeWkxK1dGUEpEN2haNWRCQTdGd01qV0tsN0dCS2hr?= =?utf-8?B?NDZWK2xaL1hiUlNMZnZmckpKVEZOQWpWcjl3dWFuQUNELzdWYjROU3BPQ3JC?= =?utf-8?B?K1JUM3FiWXpKM1BCellJOVk0Mng2TDVidXNNQzkvMVcwdDkzSWt2dTkzSHRm?= =?utf-8?B?U05qbFp1c1pLWnVDSjFmVWVNUjQxUUMzRktOYWg5V05aWjBHMFh4VG16ajFP?= =?utf-8?B?VFFDbUtqZFFsa1lFN1NDWTRKeVBNS2cwN2ttendPQ285VGRYMWpzdlBtbjVi?= =?utf-8?B?SUxTRFoydTNWZTF5aUZxdGk2UEl4RTZWQlpzcW1mdzR4YVd2UUtpRDVLRGNB?= =?utf-8?B?bE40L0U3STRscy9MSGtwZWJhWmhVRmJHdGRZbXZhdGhWcXM5K2s0N3gvQ3dP?= =?utf-8?B?U21LeWR2RVlwNkk5WlU4alFOV1lWdlVqMlZaUlRNdUJhK2NBSDlVdDkwdUdz?= =?utf-8?B?UDNVUzl3Tis5NlFpZ1o1QmlwMFJBejNaR2hHRnBSOGNNcGVnTnh4L0MreElV?= =?utf-8?B?Q1JnVXVGNVdRVDhGNEZ1MVhFRWR6SnZmRlp1L2lFWG8xVCtuSXJVeEQzMENU?= =?utf-8?B?YTFHb01mY3Erdk9ZS3hOTjVheU45TFNCcDNZaXNWQjF1UHRsWG1LYUNXenpo?= =?utf-8?B?cVYwQkRqenhUZW5BdkJueWN4M2dtZE5wNk1rWjMraEsvcUxrMTJYcnYvbnBV?= =?utf-8?B?MUpKMnJFREdtYXBNSE5qTXdrYWN0ckYxcGJsQUJ2eVZYNnhRdm4waitMdThu?= =?utf-8?B?eGtEVmFUT1lDL0gwcGF6YlVwRUZTQVFwc2Yrdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UTZVM2VOVnNZVFlRS0Y4OU4zS01yMmtpNm1uSHl2NXBlSkJqVERXRGxEVWlU?= =?utf-8?B?YVJDY0tRV0VJU1htOCtBMC95TGtLTVVDYjlRSW1NYmFlVFlxNDdPN0FzRnE1?= =?utf-8?B?RXh3WkJneHhScTkvbHdlMEtIQW8wS3FYQTZ4NkhTdXJ2RDNIUWsrc3gyaVU3?= =?utf-8?B?bEJwQ1BCNVZLc29mUjJLWkpzWWo4M0FNYUNTREROQ1ZlR1lTN1pld2UyYUJq?= =?utf-8?B?UGhCa3d0MFhuK2JONGFmS0Vqc25lQ3hObjVIYlpaR0p1dU5aVE02VEpwNjhj?= =?utf-8?B?ZlEyNXpseWpMbXpTUERVZEk0bjRuY1lwZ1hMYjQ2NllXM3hETmZPelV6Ry9N?= =?utf-8?B?SzZ6a1NFL2FtZEx4V2RjYXlEc3BuVDJaVGVXUWZnT2d4VjJ0R0F1RFpPK0dI?= =?utf-8?B?aU5PZ0Uxb0RCUHNEbGFoTi9iUmVibU5tcEwxaEFHZkRnVFdvOHlJTUJScm5Y?= =?utf-8?B?RVg4SEJvMjM4UGp2MiszTitkTDFONW9GbGpMb3N3NHYrNFYxUWVkcUpwdUxu?= =?utf-8?B?MFE4WDk0ZnMyY0p0ektKL2FaZDFCeXp6OElUNngvbHRJNVpwbGVxNWRzQlBH?= =?utf-8?B?NFV0Ylo3VUpWTVl5NHI0SkF0WjdwUVpURE40cXRjSUZPZ1JLUkRpZ3Nzc2RI?= =?utf-8?B?V1JWNmdLN1VaU28zbkNSNDRnS1NDcXlCMC9VdzJjQjhMdm8xY29jc2ovZThr?= =?utf-8?B?cXl5TDNnVSs3M2Frc29oYkR6NkVWUDZWZlFIbkx2RHhQSDRUbGl1dExnMkQ5?= =?utf-8?B?eExCSWJyZ2pCcUdmck1yc0l6S2MyTjcreStYNWpEbmt1eStMNVBBOTl3L01B?= =?utf-8?B?M2xmaTVxTUw3NXdGN3c5dFpMdHVic2dpVlZhdGtxMk9jQkJyK1lrODV1TWFB?= =?utf-8?B?dlhqSjgwYTBDV2lkSlU1REhmMkJIMk5HQnFxd1UxR0hleDQ3K2o0UlFDL1Ji?= =?utf-8?B?Y01NVURQQnVIdUx0MzVPQWloUURVTU9abUk0amREbHBFVEM4NjRrbnZETHBy?= =?utf-8?B?d1IvODNjMWpkVFZCRFJxZGh6dVl3MFBsc0wzazBiRFplTGpKYWxhNDlZMThU?= =?utf-8?B?ZGtlTjdPRTE0ZmpaK05GOXVSVGNLdE5sT2g3SFd1emtwVUpxamxJMzBFMzBI?= =?utf-8?B?VERaWDlkVEdJV0luR3Ezb3d2SVUvS3pTYjdSQ0l5Z0RLUjlzUlV1MlB3VG5O?= =?utf-8?B?dWJpdmlITS9QYnhPMnYzbGtPVFJzb0pDY05ObmxUTmFKS09HT1JKVUovdU8r?= =?utf-8?B?NWh4OE5uVUFNWml1VUp5ZEh5S1hGdlQ3S0VjY041WnBZTGJJK1lQNkkyc1o3?= =?utf-8?B?NkhmOTZkemhsaURDK2N2bk1rWWF3dmJ5OXNBVGlmMHpmajlXa1Yxb2hQUlRU?= =?utf-8?B?MkozZDJWSkdEaUFFWktNM3FkUnBmYlBvcGY0Vk04QUtqQ2tnTDUyTi9GSklJ?= =?utf-8?B?YWducXViVDY5aEprVjV5cnRWaDlUK2tCa2tmRWxCS05qWkFJaXBxVGJrYkor?= =?utf-8?B?K25venlYUURscXQ2c1R6OWUvWEtDSjQ3blhVeXFNSzNoa2Fmc2htaDczbnVH?= =?utf-8?B?UlBPQmw5aTBRYWpCeDQ1WDNNTkoyUU9obnFYTHVjRktCeXNXR2p3akFyVUZD?= =?utf-8?B?TFBYRUhTQTJJR2pVWnZIOE5VQTVleW5hQnVWNnI1bDNHM0lkU0FpR1BNVEdY?= =?utf-8?B?amdSa1FSWk5iNVZmZkt5UlFpTVZoWXl6dU1GSFJCdjE2bE9sdzZQT0RBYS8r?= =?utf-8?B?RlBqa3FoWFV5WUN1Vjl0NXNDbXhtTVhnRllRQzlVY2I3VVpCbTRvc3o1aEJR?= =?utf-8?B?dWI0TWJ2UnRqc1FObjBvR29kc0c1enpiRWNyVHc5WVhYQjU5UFdacWFybjNs?= =?utf-8?B?TGlkR1ZzanVLWHU3dVpEc0pyVDdKc1hRV2tlMGp4WSsxU29IOFA1b1JhanV6?= =?utf-8?B?YktVVEZaSENYUDVyRUFzOXlRTmZwb21LeXA1OVBpd0VabGw5aVRNcTFvSTNx?= =?utf-8?B?QW1sR3B3UnlxUGlmSmdRK3o2UnRUbUVXc1RMV1p6ZDFVQjZ5SkEwMzh6MUp3?= =?utf-8?B?WGlTVk1MaFE4YUVqL2pwZ0RuNEpmaTJmTkZ6WEdYSGEvRERVTUExY2ZaYVVr?= =?utf-8?Q?BGyhkUhnyAGW0C3Ozf75ux8eg?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f037da0-8206-4211-f58c-08de27234c33 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:49.1408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZmIII9Hxr6g5yQe+bI+kB9UkwqB89UPj06bBZ+ei04QCBAGmPGFIiA6RUGpOhxBHaR246GAVZojzuauHoVc4Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR04MB11949 From: Peng Fan Introduce imx_dsp_rproc_reset_ctr_{start, stop, detect_mode}() helper functions for i.MX variants using IMX_RPROC_RESET_CONTROLLER to manage remote processors. Allows the removal of the IMX_RPROC_RESET_CONTROLLER switch-case blocks from imx_dsp_rproc_[start,stop,detect_mode](), resulting in cleaner and more maintainable code. No functional changes. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 69 +++++++++++++++++++++-------------= ---- drivers/remoteproc/imx_rproc.h | 2 -- 2 files changed, 38 insertions(+), 33 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 91d041c15ac19f527f48c8189421f71fb7c9745e..6237e8db2eff759c2b7fcce5fb4= a44e4ebaec8cf 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -346,6 +346,13 @@ static int imx_dsp_rproc_mmio_start(struct rproc *rpro= c) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_start); } =20 +static int imx_dsp_rproc_reset_ctrl_start(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_deassert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_start(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -374,13 +381,7 @@ static int imx_dsp_rproc_start(struct rproc *rproc) goto start_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_deassert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 start_ret: if (ret) @@ -399,6 +400,13 @@ static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) return regmap_update_bits(priv->regmap, dcfg->src_reg, dcfg->src_mask, dc= fg->src_stop); } =20 +static int imx_dsp_rproc_reset_ctrl_stop(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + + return reset_control_assert(priv->run_stall); +} + static int imx_dsp_rproc_scu_api_stop(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -428,13 +436,7 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) goto stop_ret; } =20 - switch (dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - ret =3D reset_control_assert(priv->run_stall); - break; - default: - return -EOPNOTSUPP; - } + return -EOPNOTSUPP; =20 stop_ret: if (ret) @@ -1057,6 +1059,20 @@ static int imx_dsp_rproc_mmio_detect_mode(struct rpr= oc *rproc) return 0; } =20 +static int imx_dsp_rproc_reset_ctrl_detect_mode(struct rproc *rproc) +{ + struct imx_dsp_rproc *priv =3D rproc->priv; + struct device *dev =3D rproc->dev.parent; + + priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); + if (IS_ERR(priv->run_stall)) { + dev_err(dev, "Failed to get DSP runstall reset control\n"); + return PTR_ERR(priv->run_stall); + } + + return 0; +} + static int imx_dsp_rproc_scu_api_detect_mode(struct rproc *rproc) { struct imx_dsp_rproc *priv =3D rproc->priv; @@ -1080,26 +1096,11 @@ static int imx_dsp_rproc_detect_mode(struct imx_dsp= _rproc *priv) { const struct imx_dsp_rproc_dcfg *dsp_dcfg =3D priv->dsp_dcfg; const struct imx_rproc_dcfg *dcfg =3D dsp_dcfg->dcfg; - struct device *dev =3D priv->rproc->dev.parent; - int ret =3D 0; =20 if (dcfg->ops && dcfg->ops->detect_mode) return dcfg->ops->detect_mode(priv->rproc); =20 - switch (dsp_dcfg->dcfg->method) { - case IMX_RPROC_RESET_CONTROLLER: - priv->run_stall =3D devm_reset_control_get_exclusive(dev, "runstall"); - if (IS_ERR(priv->run_stall)) { - dev_err(dev, "Failed to get DSP runstall reset control\n"); - return PTR_ERR(priv->run_stall); - } - break; - default: - ret =3D -EOPNOTSUPP; - break; - } - - return ret; + return -EOPNOTSUPP; } =20 static const char *imx_dsp_clks_names[DSP_RPROC_CLK_MAX] =3D { @@ -1324,6 +1325,12 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc= _ops_mmio =3D { .detect_mode =3D imx_dsp_rproc_mmio_detect_mode, }; =20 +static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_reset_ctrl =3D { + .start =3D imx_dsp_rproc_reset_ctrl_start, + .stop =3D imx_dsp_rproc_reset_ctrl_stop, + .detect_mode =3D imx_dsp_rproc_reset_ctrl_detect_mode, +}; + static const struct imx_rproc_plat_ops imx_dsp_rproc_ops_scu_api =3D { .start =3D imx_dsp_rproc_scu_api_start, .stop =3D imx_dsp_rproc_scu_api_stop, @@ -1334,7 +1341,7 @@ static const struct imx_rproc_plat_ops imx_dsp_rproc_= ops_scu_api =3D { static const struct imx_rproc_dcfg dsp_rproc_cfg_imx8mp =3D { .att =3D imx_dsp_rproc_att_imx8mp, .att_size =3D ARRAY_SIZE(imx_dsp_rproc_att_imx8mp), - .method =3D IMX_RPROC_RESET_CONTROLLER, + .ops =3D &imx_dsp_rproc_ops_reset_ctrl, }; =20 static const struct imx_dsp_rproc_dcfg imx_dsp_rproc_cfg_imx8mp =3D { diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index a6b4625e8be76c6eb6a5d8ef45eb5f3aec5fe375..6a7359f05178a937d02b027fe41= 66319068bd65c 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -20,8 +20,6 @@ enum imx_rproc_method { IMX_RPROC_NONE, /* Through ARM SMCCC */ IMX_RPROC_SMC, - /* Through Reset Controller API */ - IMX_RPROC_RESET_CONTROLLER, }; =20 /* dcfg flags */ --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011005.outbound.protection.outlook.com [52.101.65.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75C612FFFAD; Wed, 19 Nov 2025 04:22:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526178; cv=fail; b=coPVZ888tAgcdG4bADrPBMrcbe95F8eiZw+OQBM+aif4rpjug+2GOK2LxW9+CefhcxheoIdEJD2Df5C6LbW46Bu+l/oVzl+H7CKoBeB5+Gz00nk6cJh6O4o87Q4PCgAmcVEJUQrlv0qU1jgiJE4Z+E1BwCS2BBxlZ51ditzVO6o= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526178; c=relaxed/simple; bh=4ldojY5cbA5QTgMwmZhrQ2AkuXq2EsuQ+u386sZaC7k=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=ibHG5tEqu/mM99E0FOv8NDC6dEHZevB9Uz3mGtMrIU5LlL+CbqzkckprPP+xOSUlMbBXuiqBTybP5vGyBBC8QxG8KLFQTBtiTa91pu3C6LjTdkffN/rFZ9kdJMC13GKCUb9uzDFgZ6ZB3Znqpvl088zIvNsvoWezvF8+cGMULpU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=lMCVPuTe; arc=fail smtp.client-ip=52.101.65.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="lMCVPuTe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qkK3x2Ai85qnYixKIgfuNCiVkyH8IAQF/ZZH8hx4+rA933ZXcR0wB9tUPrYQFSJpkVAENiHhSy+8hH+YKHY5A17Angz/mFIfaC2acTNCSq8ch8svt7vOdsi4Pil/e6HoKYMda5QqKaql2Ig/oaanCr+o1NUpJP1t/RChS4LdrR+bKAQx57DR0FMFrb2QZFED1JkeLfXywUG69XZCfbVjLYEe+MQPumoUSXvA7oi/kfJ5nnxyMKLAYUWMK+CpUqYqN6PicwmZ8DhYmU+HnAZDyGIsPT5YYlaYjBbZGV2vwK63Ta6R77ULk3rfcU5NO6G8yCQsQV6d97Zm4eH7byWcNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kb+SY690DYKf0CLrvSE0AwsB4nvBKz6s5cvUli4Vkfs=; b=uuL3l5EwTCnoLYQf1e0Gi0KKj24aJ0aHNmiYtAkZ0Wr+xnD/uA8qOXs6MWXSGxRoCGrMoKXJXoXTx3uxRYyIQwubJrrJFFX9qvzyfHyZmXru/qXX+pD7HrCcAKRh1t3tayXvb8ZVcQ78sNGLuXo4374dgPC1qZq+WUp28V5tlGIeHtofkajxHF/VawtgfuM/g7TJpPxt4A++K3vG6COPLipbHxCc+pA8Nt7k/xYUplRAcgd/JFlO0EGcB3biNkN41YSBu5KV4Xproathe4FH/l+7mUTOeqFZBqpbnv6cgZ0IBsn91CtJQvnSA7xHFTB9V1rllq1NRDkVWesi8H3WXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kb+SY690DYKf0CLrvSE0AwsB4nvBKz6s5cvUli4Vkfs=; b=lMCVPuTe0RDbDWctVqc7vIyVX9nKbyPRTtpo77gM4Qt9eHFY3sRulBEuYR97BJh1M1FmtRBdsOMYBXOu1t2MUgDLk4OSECMISEuh60ryihM0xxGvMVJKyUbKhYh9WgRhc8A+Lbnaj4nkWehfcl5D/UUYpWWLD+BpPM65b5mf4xYjlGfg1v+/SQVrcPhLIBcfxC4qK6fkxU/xZvpdRFIO3M4F9rt+lr2+lWKPn+Kuf8b5n6uxy4bMMwozOUFa9Hf4FcuKzA1EONRCKJcDffmXIewZRSjd/TULK4mjbZsBpizCWiDNmK9uXIZAwsSdHFKUU60GE5+2thUgXwTdH5S8ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA6PR04MB11949.eurprd04.prod.outlook.com (2603:10a6:102:514::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:54 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:54 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:56 +0800 Subject: [PATCH v4 11/12] remoteproc: imx_rproc: Remove enum imx_rproc_method Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-11-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA6PR04MB11949:EE_ X-MS-Office365-Filtering-Correlation-Id: 70c0a162-2a01-4848-d8b3-08de27234f09 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ZnFIRk5pSENqUm1raDNlNE4weWoxc2tMK0pDVjhaRjZpUWVNS0llSG4xaFdw?= =?utf-8?B?TDQ1NHVVVm1CU0laYTNGSVNyVGFESXUzMnJrOHRQckxBNGNnUEdaMlVhOTE4?= =?utf-8?B?Qi9ibjJBZWp5UUU2ZlhCN0VRL0R3dUZyZWZkVU43dHN5My9FcDlkMVRhYk01?= =?utf-8?B?cEl5YTYxSzEraW1hNC9TL2hYaXRZdG5FNTRONXdKdG10VTgyQmtWMVBoN3FF?= =?utf-8?B?NHVHNndKR2JkYUFGYlVFa3lqTjVqTHgwTzNRZ2FkeTJ0MG95eXVGNzB4OXg4?= =?utf-8?B?OHlqWExnRjJTaW1PdXVQR2xUTDErdTU0aWR6YWlsTkFDSjFCTGY5OXd2WCtH?= =?utf-8?B?TlNPY2cyblZXT3lIdnZhUFE5OWJkVzZQSDFPSnNMdFFuam5iVm9zejBWRVZL?= =?utf-8?B?TWVFRWtxMDZITjR3dVVUd0JOQXhPT3d0d1ZHa2U0c3Izb1RGb3VnUkhZR0U1?= =?utf-8?B?Vi96YWczdzRxcFYvQmF1Ujl6Snhtc1RSUFhXT1ZaSmpva2hWQnhubDBuRGtt?= =?utf-8?B?Q2lVYU80SkFLWHpQamJ4NXlMS0FyclFDMWFDZ0h0ZGZNdVRabGd1UWNDZDNZ?= =?utf-8?B?NjJNa3hxd2ljY3ZrdVhwR0k3S3lBek15VUtsUlFISDVsTGowUURpb01nSXJO?= =?utf-8?B?NTVxR01VcStCWmVUblB6eTR4QnJaemVjenBnU2ZPRGFkSHY5WHRseWV3aUZV?= =?utf-8?B?QTFPN1NZOEprbDM0RHM1K2ttT1Y3RTIzc1UxT2gyMDVQSzVkY1I3SDNzWEs5?= =?utf-8?B?Z0ZKOEhIUW5YUzYrKzM4WHhBUWt4clpFYTB1eWVaeVFmRjFIb1U0K243OVVu?= =?utf-8?B?U1l1MWRpc1VjTmdMV1czSWdIWmt0RGliUFdTN2Zici84TzR4RmZNQmZQWTRT?= =?utf-8?B?THNpZUpkaWpvbEd4VTlxTEdBbU1KUUhCeEtjUGZDNHJHVUNQdmRrZ2tCaERF?= =?utf-8?B?WW9BSytJeUtLS1BuS2U0ckJHUmoyMWNJVm1JeWF4V2dDK281ZncvVGJYaDBU?= =?utf-8?B?WkFJSkxacGpPZ2xZdHA2NjBScnpxRVQxS3ZsbDBtMGJEQ1RsOVlBdHdwUzEv?= =?utf-8?B?T1Q2cUJGZU50VkNFcHZkZ1JGVTgycVZwN3cyTy9ka3FRWkxGZGVWL0RQQ1pF?= =?utf-8?B?aHd1QVVWTlJEMU00QkNIRUFnTTkwMFJ1ZUx5b3dLelJITmFHMGpkZ3A3TmZl?= =?utf-8?B?S2JrZS8rbWx3dTljK2NBVnNWdDMwVGJZMTZvZk9FRVkvODZtUThDMXgvNjAz?= =?utf-8?B?eFlMaXczdWN0eHBIVUcvRFUwbTNSMWNPSVFwN2VUVXEyMWgyUDRWcHlxdmFn?= =?utf-8?B?TENNMkV1RmtlMnRINGJDbVVWZDVQT1pjNXVrUW5WWjJGdUt4Q3AxeGhNNXlV?= =?utf-8?B?TmtFSXdEbTNRNHJCaXdjTkkwU3JJZ3B3Zi9UZ1pNcFVMQUl2K2hoMm05ZUV0?= =?utf-8?B?c1prRUEvMFRwWkRwZGxFclgxUDN3djcxcjJNa093ejhYSHlhUGpzakxNU3Nu?= =?utf-8?B?NGh3OG9MbGE3ZW1PTEtZcTRKTkMvVC9zZC9Za215aTB6WjNuMmNIT3JKdG5T?= =?utf-8?B?WExYbS9CY1BpUTR3S1ZIbEhqNmtiV1pRSkdJVmhKZEdWOEFqOUxnR1crRXZZ?= =?utf-8?B?M3gvcEpUQ1dYQTdWeGU1Q3FyZG0wSEF2dTd5L08velZrb04xaG13L2xFcDVV?= =?utf-8?B?NS9sNkwvdUJMZi9lUWdRK29tQUNnQVJVUFplZjZESyt5NVhWSXpvYUNGcE0r?= =?utf-8?B?T1Q4TktqWk5CcUs4VktFbEtSN3VaalpUbzdlWTg3TmNMWVEzem42ZW1reG1P?= =?utf-8?B?UFdNbE4xSVdxNlY3dVB5RlAvblZibEkxOW1ydTZDU0U3V2puRVVjbElvaW1l?= =?utf-8?B?cWN2RXowenF4MEZTVDR5dnJTQnh5ZVQzUENmTHRJRWV3bmM2S3pSQmMzRWxv?= =?utf-8?B?ZG5PRytCV3c4S3dDOUJxcUpMOXFuUzdiS1FVSlFrL3ZKTkVSc1dhbzNXcG5U?= =?utf-8?B?WFJBRDl5bjJLOXowWXlmcCtLVW5NU25ibys5elFmN3hUUURjRThQa1oza010?= =?utf-8?B?SGZzZ05RY0ZFbm52ZTNjM2l4ektzaVZ4YXVCdz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWd1RkV2WlZRVjcwMkRnOWNxZmN4azJtaWtHVkl2WFl3eDA2TGNnN2hjdnI0?= =?utf-8?B?SkFXTzhuVFdQWnJ5alJMOEtPcmJjUFM1MFdmUnBwWGhYaHkyVG5KYkFwZWlZ?= =?utf-8?B?YWxBaWlQck11anNsQkp6MEhWZXk3dGp6dnNBaVNpQXBoYWo5RHBOMlYvU3lZ?= =?utf-8?B?cnpnbEl5MUlmUUlZays4bEJwV0N2ZmpJSGhtU1I4aW9DalJtc0RMNzRjRDAr?= =?utf-8?B?aTlLc3krVmk3eVlCQWRjMFA5Skp3cEhLZytrUWIzdnR0VFhhQzZsd1lSc1RS?= =?utf-8?B?QmJ4YmdtcjUvbDFDcW1jcDhUTldSYjh5d1lzcXhXRnJSTzVObEtEMGMvZk9w?= =?utf-8?B?cUp5cEpyZ3htUTk1bnF3MWFBZFd5N2RMSmhtZ3Vtdis4YjhoOVZGOUFFMWdQ?= =?utf-8?B?MXQwWU9kZ0dHN2RWcWNHZ3pFYjBDUU5pNmwwYWJCTU1jZHhiRTBJSXlVdEdm?= =?utf-8?B?TU9CbERWSVpYRHFhRWcyZjZ0bm1CWGRIUGhObzJ0b2I1c1ZUVVlRMTNwRmVM?= =?utf-8?B?cWY1aDhpaG5vbDdkR2NudlQyc29WdTJEZnBzNERDdEVDSjBYQmNuOWFQTk5a?= =?utf-8?B?WkF4Tk9wOXdIN2VOUXdIUFdiTUoyVENIMmJMdVV4czlHVlAvZEpxTlFjTXpJ?= =?utf-8?B?c2Z4ZXhaRFE4eWdUZzZLYmNlZmZKMlFtdmY5Zlk1bXZzbC9QMlp6WGJKaE1v?= =?utf-8?B?a2xuVTA2MnFxME5mMGg5S2Niczh1bVRtRnpZeFk3RE12VlBpajNOSDRQZi9E?= =?utf-8?B?aVFoZlQveE9rRzNEOGdrdU5ab0tVNWxuYmltU01VQzcvUnVzTUQrbmp3NFk3?= =?utf-8?B?a2FtMmU4QVp5T0UvMjdlbzdVemR0RkxsMjNjQkFOcVBiUzdxdDRtdUtzRU5X?= =?utf-8?B?TzJtWDlna05rckVvTmg5K1pDb0poSm1kVmhQSHdhSGoyeHlzelBsWWcxbFFZ?= =?utf-8?B?Y0FUeksvNUsrMnRab3JvQlBLRUo4RzF0eTAyS2hKQkxJL3dpOWdMZEREakRn?= =?utf-8?B?WGNnS0lKenB4QXdMRHhjMHRPZ0p3ejRMVnl5S0NOVjRBZ25HMldNQldRaW1C?= =?utf-8?B?a2lBbGxDYzYya2ZmNmFqeXN5VUNsMmIxR1NRZWNSTTVzRm1wcXlwdkRlSEUx?= =?utf-8?B?bWRxQnkwN1NDNGlVTmk1TWlhUjVxWVczNVNNbG9yOHF3RHUyYmdhMDZFTCtX?= =?utf-8?B?VGdmbm5UMDh6eTJpSWJBT3pmbWUyYk9HYUcyR3pvMGI5T2lFRXZTWFNsSTUw?= =?utf-8?B?S0Jpd1ovQUo2dms2anEzT3RRRFhQTzQ0YnhuaU1QVEY2L0s1UFN2ZjJMZGpM?= =?utf-8?B?S0hHb0lNSUdKQ2FyMDhHM3poNnZEVzQ4SmVrT0NueWJNdWxzSmFBYUJ0WHNx?= =?utf-8?B?cmdrT2hNamhOYjBXcE1LZEFTQWlONmJVNVQ1QjFxM0U4WlVMWjVKTjdiSlZi?= =?utf-8?B?Zzh5M25wODJicXpEZTFnYnZyNDg5OVpjZXJPRDFzeEUyRnhWV1IweGd2bisr?= =?utf-8?B?TVhLc3JhQWJUaDZKQzNWazM4VWRzM3FHYjJvcDFVamdLdmFmRmowL0R5aW1x?= =?utf-8?B?bHI0K0pSMUNxUmhxVHdEQStyWGpUYUVjSHlyV3BpeGEzejF1ZXhSQWFPWm5m?= =?utf-8?B?YnFCTFNwN1N5czhzZTRTdUk4dEVXMTNIQXVwM0ZNMElGZkNZcklML05QL3hS?= =?utf-8?B?a0xmeksvV2cyMnNtLzdDZTN5NU1ZdEtGSFNqOWpLVjdpcEtKa1EySUlwai9G?= =?utf-8?B?dk9ZZEZkazlEU2N0cTRZbFlXbDhHZGFMN282SXEydmdqdG9qVzBIY1hiYmsx?= =?utf-8?B?S0x3QUVQSFo0SmhUQ1l3L1B1SURob3MyRXVxV3RpWlVVamJDTFdtVVlqK0xQ?= =?utf-8?B?RTA5T2MyUXFHK3gvZSt0OTNLenBWQzVzbHRRdXZ3K3gzNmREMmdtS3ExYXBl?= =?utf-8?B?YjArYWJvM0hMVktIY0YrMFAvRVdLK3lYVENYaTVXTG9KNGs1UG1GODV1ZFJq?= =?utf-8?B?N1E4Q09FemErYkdkdG04bHRMTzF2OWFJcVpZWFg4SzYvZTc1aTJrbDJJeW56?= =?utf-8?B?R29ieTI3cEdPTnNDWEZvN3ZYWEdpaDFzTlNzZ2lTQm5vRmhtNjVqTURzVVh1?= =?utf-8?Q?OAHP8ljbHjyscEcwokSVw67cA?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70c0a162-2a01-4848-d8b3-08de27234f09 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:54.0467 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H6URVXC057H7GqOn2HMlC8on9kWi0z17b4KqYkO/XyFJ23Kz2HEzPo3AgSsuvumxNgA7E8n/w8MO23SKxtJdCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR04MB11949 From: Peng Fan There is no user of enum imx_rproc_method after moved to ops based method. Remove it. Reviewed-by: Frank Li Reviewed-by: Daniel Baluta Reviewed-by: Shengjiu Wang Reviewed-by: Iuliana Prodan Tested-by: Iuliana Prodan Signed-off-by: Peng Fan --- drivers/remoteproc/imx_rproc.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h index 6a7359f05178a937d02b027fe4166319068bd65c..1b2d9f4d6d19dcdc215be97f7e2= ab3488281916a 100644 --- a/drivers/remoteproc/imx_rproc.h +++ b/drivers/remoteproc/imx_rproc.h @@ -15,13 +15,6 @@ struct imx_rproc_att { int flags; }; =20 -/* Remote core start/stop method */ -enum imx_rproc_method { - IMX_RPROC_NONE, - /* Through ARM SMCCC */ - IMX_RPROC_SMC, -}; - /* dcfg flags */ #define IMX_RPROC_NEED_SYSTEM_OFF BIT(0) #define IMX_RPROC_NEED_CLKS BIT(1) @@ -42,7 +35,6 @@ struct imx_rproc_dcfg { u32 gpr_wait; const struct imx_rproc_att *att; size_t att_size; - enum imx_rproc_method method; u32 flags; const struct imx_rproc_plat_ops *ops; }; --=20 2.37.1 From nobody Tue Dec 2 02:37:43 2025 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11011004.outbound.protection.outlook.com [52.101.65.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A50A2FC876; Wed, 19 Nov 2025 04:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526183; cv=fail; b=nLB2oGk57Cxd9Bo5a7V8/qkUtrS6tHxyVGDBUrIz5kktdw+tHNmKFEX2I1TMEPRF+vgVfrhcaxCY0k0Vjs5PhFKr/7iJpEACIgwcRgl0Bo0S+PwVsjPdcNuHPAiKZs5e28P9WzB2Pr4gc/Dr9/hlGRbqrOFpK63It/DtPspavuM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763526183; c=relaxed/simple; bh=KrCLyg/JqaCL9FjEZh4T2cLlinWB39DljJBhG5CxloE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=TLc8Fr4RkVf2N/7U2MmpJv+13VHSKPDpxXDzZq1TGyd/iFP3Vt/OV0sO5IcaqScJlB6Bz9KZeoY3xKuwkeWnnhIcbp9YlguzBwthq66rrLt70p5/W/aJ3IjHoIrDslmz1n9g6+qmFDRPcrCqid07GHZNlD1tv23shCovqyIcrzA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=iW6/DEFP; arc=fail smtp.client-ip=52.101.65.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="iW6/DEFP" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qhONiUr2ohIGvWWX34PldHgzmqw5XHnatTJgVF5UEzJVhvt8siS5jI5tB53kgfig8errMQWWTIEnWaAkkZYyp2E4bJL2E2u8NuByA6kkU8Dd1HgKhPYsFFzodoKgtzlApFaQUqJWL3urSsTMTCsxyQWopKStHc3qQPt3+gVI7mS7iDGlYTfT4lY3bbIeLWx7XzhIjojgdJWn6BlI/xrGmFzzC6TPLsVdI4Bzj0G9e0TrRfEDLx7pjmQFwoFGkgJaRjMvla+cCIVG+FmyuRyx/jBpyQfJ1ojTj46Dc8mPh6BB1CSHF/TjeHq5o30PkqtfkZiD6lpPqEtkmgjGyhffLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LX5uT/c2Zgz7ZUJnFOmxEGM43TSo3lG9Hkv5DZaWEdY=; b=b5aTIBetxh7WeqKpXRT0q5Ay3Kw3APWsH/mf01yItyR6OPotQQ+3gzdodncWdbkjjwU9bkh363KKaZkvrcNIKu0PhzhSuO3F+UJDw0FslqQSVd5WunQey79L25k0oJYcWSmKUOc2CLCaC2cubnx4XV+p835yFjQT0VGxGva8DxiHUsm4AVH7Bl/qkPVHGVUB/u+sC5Cstnj7UjB/yLJdBB4gHUmgPmzqxXMbIE2nGIgvijWjiYErx2ewH2xsMxBwq/CahVAsyzH4l3IR15ja6EbqFh1suo28rtpJe4k9WpjE4B/mzOBJ5RseeKnwKhzK8NlH6CZ9UGljZ0KeUiIEog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LX5uT/c2Zgz7ZUJnFOmxEGM43TSo3lG9Hkv5DZaWEdY=; b=iW6/DEFPr9YYBOOZqxdP9uPduNc9OGJ4rww4/Ii+Bo0lGd4gmGn4HYwmyHdkk1actV2jauBT9y9dbtU/OTIeYj534FR+0jBU2eRtgv7v99bu2N796PtLN2vwOszOgtSrd0wFCU99kTgM4IOQV94NtPan7p8wgmfFF5WxnFRqs4tp97KGZ23By4vdHXhJBGQJgqsh9LBEF3kCQOzwwSEiUw5d78PxnIsSwVgwIrVeikIaiFPxt6R0jlnswy3NYfHkr8FGbd2koX7tpd1l5FbwLLrZGWze+cnCFMe8abnykTGqP+GY3aIpowVxts+wBwatkDblroSkE6ZY4IB0TMKQ3w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA6PR04MB11949.eurprd04.prod.outlook.com (2603:10a6:102:514::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 19 Nov 2025 04:22:58 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%4]) with mapi id 15.20.9320.013; Wed, 19 Nov 2025 04:22:58 +0000 From: "Peng Fan (OSS)" Date: Wed, 19 Nov 2025 12:21:57 +0800 Subject: [PATCH v4 12/12] remoteproc: imx_dsp_rproc: simplify start/stop error handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251119-imx-dsp-2025-11-19-v4-12-adafd342d07b@nxp.com> References: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> In-Reply-To: <20251119-imx-dsp-2025-11-19-v4-0-adafd342d07b@nxp.com> To: Bjorn Andersson , Mathieu Poirier , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , Daniel Baluta , Shengjiu Wang , Iuliana Prodan Cc: linux-remoteproc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-ClientProxiedBy: SI1PR02CA0005.apcprd02.prod.outlook.com (2603:1096:4:1f7::13) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA6PR04MB11949:EE_ X-MS-Office365-Filtering-Correlation-Id: 2d683cd4-03ac-4f08-6e4d-08de27235204 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|19092799006|366016|52116014|7416014|376014|921020|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eGVTTUYxSW13RWkvY2h3ZzVqQWRjekRaSCsrUG1KK3RZRnk1OTZkLytxUktz?= =?utf-8?B?ODdRU2dHTEUrQXRYYmVyZCt0TzBuTDFaQnFkaS9HN3VZTUkvdUdCT2pEN0xH?= =?utf-8?B?bjJZdDVxd2hIM1JlQ3ZxbjRwdTNRQVN4bExnL0dJOE9jbmZsT09SVDI3TkE0?= =?utf-8?B?YzR0RElBbkJ3TEc5ditaMjhRVUJpdmpzZ0dmYTc0TFpBK3JkSWRWQzM3Tndu?= =?utf-8?B?WXlLK3BZeFNFQUtCc2ZnS3lUY1NUeERrYUxTNE01U1cvcUZkV0xvQi9iWlZR?= =?utf-8?B?dmt2ZmtPYnQ5MnFjcmpDeDdtWFVNZlArRGN3eFplZk5yMWVjT3drV2ZPL0ZC?= =?utf-8?B?YTJ2dUdteU9kVi9iV2VUYkZ2ei9PcW5uQ3VBM0NhYW9WYWlKR1ZCUW1lVlhE?= =?utf-8?B?NFNpR0FoNnh4cGlWMEswZ045WWFkSzNTVGxoallKYzUxNk5ITTIvNjVRckVM?= =?utf-8?B?RXZLbHFQMklsUXZHYks2YnozYmJ2YkxkbXdDb0RkQjk5VlNUZjFlWHJuVytn?= =?utf-8?B?czhzYnFmYjdWV1BUYWRack5ZYmc4VjNKQmxtSE15SUcvWDUwM1VYc1Ztdmho?= =?utf-8?B?TE9pdG14aGRKTTByQkdKTnZCVkdnZ1RvSFhDampLbEJNM3lzZXdPQ0J2WEZ5?= =?utf-8?B?VS9zQXpaNFh1RlQvYnZ5TUFlUHBvZEV0SkFna1BkT2prR3lRa3VGK0tnLzRj?= =?utf-8?B?SGhCVlZuT2FmVFFCVGVDb0xBR0xINmJicXBaZytoY0hzQUp4cW8xQ1dCWWdG?= =?utf-8?B?ajRWc3VLNVpWUGFFd3RqRlBIK21DSVp4dHdYdmttMWRNaSsrbGxDR0JOWVAz?= =?utf-8?B?MkhZYUwwT2Q1RTJFRUoxWE9EVElSYUFFZ1Q3STlrWFdXL05aWHcyQXJzazRB?= =?utf-8?B?SHFKM1phMHpuV3czK1FEa3A2MytsYnd2dncyU0gwazBqWlBqQmRIanJoTEdy?= =?utf-8?B?cjFDM0s0MmZ0WmpCMm9PemhOL3lpcGlQN2l4clVQKzBiYjZXL1J2RE83WUY2?= =?utf-8?B?N2F1NDVlNWp1Qi9sc3Fkd0x0ZzU4VTdlL2FaUzNNdEExdy9pRDdqL0U0Zmcz?= =?utf-8?B?V3RTVi9DQUVGQ29RMmNmTGlHTjR6OXMzenNOSjZqNkp5dG10Z1pLY1JZSVJk?= =?utf-8?B?TUt4ZmFFU3BwbDQ1UllsQ0laeDR3RHZBelVlaWM2bDFHWm9VayswenlvMmhB?= =?utf-8?B?VUFhTGNTTkZnL0Z2dXUreXBGb0ZrNStSa294Qi90TDhURGtWZjB0K1ZkMDZ3?= =?utf-8?B?dHo3ck1ieExubHVzdVhkYkljd2Jhc1ZaZHBuOXdtTUh3RnB0VmRZSC9xUWkr?= =?utf-8?B?TXRQSUxnUkUxZkVnS3U5NkNuelJnSDJDRncyMGU2cDhIU1ZzcVU5ZTFmbkdX?= =?utf-8?B?STlVUDN4bW92Y0YvVHV6YjUwU2NhMys3QkRvWHU2MWZOak52UzdsSDJEMlB4?= =?utf-8?B?dUJFdmFZQ2c1ZnMwcEJSYWlmVGZnQjIxcVp6ZE9OQkpOQlRxc1Y4SzVFbGxO?= =?utf-8?B?cFN0Q2wxK2Q5UmIwY0dYNkFRUVZaZ0ZGZFp5RWliSG5UdkVZcTc5MmhzY21k?= =?utf-8?B?ZXMzREp4RzE1YmpiWWp2OGx2bjhrRGNoa0lqV3IrajZzOFZ0c0dhcU4wVUxa?= =?utf-8?B?bktyM2VCR3lKZU00eXYybFJ1OEljeFI0Nms2eW9OekY3VUxmSktWa24xZVJt?= =?utf-8?B?UnI5aEpKK3R5UVRoQmlGdjMza2hoVGdFZ3c4cU5Ddm9laEozOVBWTVYvMmRs?= =?utf-8?B?THJHV25XSkhmMFRyVXdJZElmV29md1dsRitNY2R4K3g4UkpqOWd1TGowOFZo?= =?utf-8?B?aS9VU1ZhQ1hqK0MwcEMxbkFGclhGaXQ0dS8rSjJzcTdLeTk1T1V4eHRmZGIv?= =?utf-8?B?UGtXL3B6Ykc5Z1lKNHFxdDJocU9vL01BZVhnRjNlSlpZNGtFVllFbnpzOHNQ?= =?utf-8?B?OTJ4c0JSSVF0SHFLd2s0RUNUZ2ZIRXExRlFNeGUzdE1mZTQ1MWYydXY0RFMy?= =?utf-8?B?QkFuNFBQOERaSmRvTDk4SlFndFp1SUVtZFloVkFrZk1CS0JkbHcyTXpob2pD?= =?utf-8?B?dlJ5QUdyUjF0NVgzRDA4SEdXMFYzanlxQ3dtZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(19092799006)(366016)(52116014)(7416014)(376014)(921020)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm5mZ1hVZ1F4aFNzaUJaRjJkeW9jbWxjRks2TXYrTjhic1lMRG9iN0hybE1W?= =?utf-8?B?RGtXeG1EQVh4MHgrbHNkbzY3bEJxMVhvRzcxcTFWbFNsNFlvM2RnMTlERU1E?= =?utf-8?B?MlNpazIzcHF6U0paUDE3b3JoWXRKWE5oQ3FpWnpFREJ6c1BSdWt6T2xNbzhv?= =?utf-8?B?N3ZqVmFFU3R3L0lQQTN2MnZRNDdqREhmUG8yRWxmclBkYU5NMlZsdlFzUDQ3?= =?utf-8?B?UUYyWlorRnQraE0wTFh3Q3c2QS96V3FTNnpubCtzNnN5SWEvR1lrOTF5Nkw4?= =?utf-8?B?RHo0Q2hSV1hSS0UwOGJCS2ZPZHU4bks2a0Fsb0poRlRPdEpsQ0JCbEl1OThu?= =?utf-8?B?WS8rZ2VMSi9yeXB3eU1kQ0VxemxPZG80QXZMejRjcGMrc2x3dEMvczZKTy9a?= =?utf-8?B?SGwzdEFSZFFhYmwwd1lQRHVzUTdZV2M4REdsMXN3UDgyWjl3dTlwUTlQNUNQ?= =?utf-8?B?d1BRc1JoL1d4Mm4xSUhFclloVE0ybUwvRnJHUDR1OS9NZ3Q0dUJVMjVaZTZy?= =?utf-8?B?VHErUDVvUmgvcUZZek1QUk9lT1NYWUFQWFJyTXFma1NxZEFmWHI2RXRZT0w2?= =?utf-8?B?c2k3MWlTbmlJdXhhcWo4UDBJUDFIYUphS0lGQW9NN2VmSllraXVCS3l0dmFw?= =?utf-8?B?NnBYUCtHME9DT0FMcWE3MXBNckkxOFNjZkFLMHBTZ2UyQlBaNXJNY1poS3Rz?= =?utf-8?B?Vm9nYmZSR1dVUWpkb0wycXJGcUZ2SEh6ZTcxRzIxeGVHSi9JRyttWWlQc0RR?= =?utf-8?B?TFhnRjd1WXlRdHgxU2NlZ0o1Y2dUcWlFQ0lIdUh1TDR1SmlvcS8vQVZxTWZD?= =?utf-8?B?QThmQUpGRVJQWUUrMVp4THJWcGlmOTVOZ1Z1NUtibElJYmZXbkQ4ZmxuWXZW?= =?utf-8?B?SUxTcitZemNlTEtUUkl6cFFENER3NjYwQVhLajlXS2JHZWNPRHlaRDZGZ1Qw?= =?utf-8?B?enVFUVlXc2RLN2crL1ZtUEFrYXF5bUtMampZSnVpRkFkblpHTmJrSWJORVJk?= =?utf-8?B?b21DTjllMC9jTjkraFgybkdwKy84cGVJSEpkREZadWNicS9aUWYrREdkVW9j?= =?utf-8?B?MiszakRlRTFrMkVWeDg5a3E4amxJdkttTGNpTGw4WVRKZnRTNUIwYlhFakZU?= =?utf-8?B?T3ZJTGtRNkdxUmtMZEV0dU5qZGE1Y3ZhUDNJa0UzZXFHU25NOVZ2VmR1MTlW?= =?utf-8?B?NWVrdXEwUEFvbkpjeFFoQnc2ZHBhWWt5R0xLZzNNMWxsUjlIMHEzQmdNMUZQ?= =?utf-8?B?TVlFZkxoN083T0FrbkxUY0VnblpxUFB5VUIybGZ0UUFyb2JZclR3ZDROVW9S?= =?utf-8?B?MENQejVsNXVsRzNrSFQ0c21BWVAySXVEOC9ZSmhSYU5FbmZZWGtQQWdjKzdS?= =?utf-8?B?VHVIQjN2and0ZXRDQzVVQnE4V2JkbGE5M2w4VFpzSmhhQ3pYUGM2Zysyc1Ft?= =?utf-8?B?WnllYUxZeDJuNDF0U3B2MEd4NTI4SzB4WWhCMTAwMVVXTnd5SFZWV0ZHcGw1?= =?utf-8?B?dVBDRWx1RUl1NnZjRG1IWEpMMndQTGxsdlpGTGd3U0pVRlNCa0xaUGJ3MFBm?= =?utf-8?B?SVNQOHVFL0JERldnMHRLU1R1bEIyTXI3K3pnZVVLYmxxd2RyTmtRNHFudFNn?= =?utf-8?B?ZHRibWl2VTBhKzJrOXQzMkkwYyttVzFoU2JDTmdQQSt4Y2tuMStzSVlEMGRn?= =?utf-8?B?QnhLRk81Qml3dXdYaHRrQ0lORkFiMjJnZis1RmNNRklBak1iNlhTZDdPdVVY?= =?utf-8?B?RGJaSXlvYk5WK05COG81THZLM2RnYVVhWjR2Ri9rYzNxazNlcFR5VmZ2blJY?= =?utf-8?B?bW1rQ2E4eklRY3B3VE9KQUY0TUNaL2QvNE5XSzdhcGVaWnNDTm41d3VWc2lH?= =?utf-8?B?bjJ5T3dINWcxdE1RS0R3aGwzWkdTdTM1ajltMllWSDJrTlBweE9uSjFlcm10?= =?utf-8?B?NkR5Z1hjZWFQaTlabVBIVjBaVlBrK3JJREExWFZUSllzN0Ftd1RlTmhoQmRV?= =?utf-8?B?MjNPZ0VidEJvd25vVlIyaHFuR1k4N29ZTml5SnpCcmN4eVR6OWMvdkpKbFY5?= =?utf-8?B?R1llUmR1TkZReFRWckdGaWN1SkFVTnNGZVNWdXBEMnR3Y0dUUG43UWpZNmZh?= =?utf-8?Q?OL4VW88PDtdcDV8lUU9JbXw3c?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d683cd4-03ac-4f08-6e4d-08de27235204 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Nov 2025 04:22:58.8270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JcfQxJGz3Gd0ByAcVaD43gSrOkajWVjvGOBUMcX1jK0FSPG6dWbbVmoSNIpVz9REpS4xDD/Xua6yJafDnDss4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR04MB11949 From: Peng Fan Replace goto-based error handling with early return pattern in imx_dsp_rproc_{start,stop}() functions, and simplify if-else logic. No functional changes, only code structure improvements for better maintainability. Signed-off-by: Peng Fan --- drivers/remoteproc/imx_dsp_rproc.c | 39 ++++++++++++++++++----------------= ---- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_ds= p_rproc.c index 6237e8db2eff759c2b7fcce5fb4a44e4ebaec8cf..1a1438823e7fc0a65ba15142abd= d97e59692801c 100644 --- a/drivers/remoteproc/imx_dsp_rproc.c +++ b/drivers/remoteproc/imx_dsp_rproc.c @@ -376,20 +376,19 @@ static int imx_dsp_rproc_start(struct rproc *rproc) struct device *dev =3D rproc->dev.parent; int ret; =20 - if (dcfg->ops && dcfg->ops->start) { - ret =3D dcfg->ops->start(rproc); - goto start_ret; - } - - return -EOPNOTSUPP; + if (!dcfg->ops || !dcfg->ops->start) + return -EOPNOTSUPP; =20 -start_ret: - if (ret) + ret =3D dcfg->ops->start(rproc); + if (ret) { dev_err(dev, "Failed to enable remote core!\n"); - else if (priv->flags & WAIT_FW_READY) + return ret; + } + + if (priv->flags & WAIT_FW_READY) return imx_dsp_rproc_ready(rproc); =20 - return ret; + return 0; } =20 static int imx_dsp_rproc_mmio_stop(struct rproc *rproc) @@ -431,20 +430,18 @@ static int imx_dsp_rproc_stop(struct rproc *rproc) return 0; } =20 - if (dcfg->ops && dcfg->ops->stop) { - ret =3D dcfg->ops->stop(rproc); - goto stop_ret; - } - - return -EOPNOTSUPP; + if (!dcfg->ops || !dcfg->ops->stop) + return -EOPNOTSUPP; =20 -stop_ret: - if (ret) + ret =3D dcfg->ops->stop(rproc); + if (ret) { dev_err(dev, "Failed to stop remote core\n"); - else - priv->flags &=3D ~REMOTE_IS_READY; + return ret; + } =20 - return ret; + priv->flags &=3D ~REMOTE_IS_READY; + + return 0; } =20 /** --=20 2.37.1