From nobody Tue Dec 2 02:42:12 2025 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9513532ED2C for ; Tue, 18 Nov 2025 20:19:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497152; cv=none; b=iXWjgClI/dosOwH4ivZgxXKSVzNFQv7IgpogQb7wuNqh8Z9nvX5UQpuWGeyd9/sglBG6irYwB9srE0ATVBqT35dGH8PvOBGxTtaTf/nj7gRuHK7OaBCs5TBDQKgOAysGzlmbtIouKLB558QSstkrWcH4rWwr9q+avmczFCOIZ/U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497152; c=relaxed/simple; bh=GxSXQ2amDOG4FkT5XNtoxuLSkWQE6mQ+WPifrmssYic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EQ7LmY6CEiqWFeVO7ZlnPqEvwHxYNejU5W1Idkly2HpsM0LN26cptT3V25nvE+u6NGCWjpl/Y6HtHgVq2oqt4wLilLdC/duRUz4PZyv/hnGDk1NQ47PZLVxn2r8lzLnpu71DyMaMD4Ar53vBOzsz6VQsCxjX8JF0AaBY+ueVx7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VAfUwXq5; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VAfUwXq5" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-949031532f9so8518339f.0 for ; Tue, 18 Nov 2025 12:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763497148; x=1764101948; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M25T8tvP10BpQGqTu5Zj5kHgkTLLNAK2ADT59hdkhbg=; b=VAfUwXq5B/VTdLI1ZPVRcSFBfIUnYKvpSeNpdbn4Ug9vvPdVkZFiSM0OayYmuStUSr UjvoWFNWpmvxxStJxUarOeZ23eHIfoa+lnNp65Z6ZG/b7eliXZmZsHW0AnBLvoterLmh JCUBdIZWfBsOKXabMLv68FXEGyaFquU4Xhzn+1O3rusJihWPbJ6OPWGFRkVN7ARDfb4z wzYPzqpm3JKvnBn94PkEPg9ErrQ3hko80gntkO0xfst06Q+0W4AfDoHN34HJq0peJXbd 7qo/u84QLei2yccYeDWuv+ebnaNvc8RgfynZ78YT5D4B/EBUr9/DvJkjkQa34n+IwJiL //OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763497148; x=1764101948; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M25T8tvP10BpQGqTu5Zj5kHgkTLLNAK2ADT59hdkhbg=; b=DbBwOOPengbvqFLogwDBOEjIqUMvJCSvlbE6aG0hqyx7DLl6SAaMqXvSL6bcmdy32b Y432vxVGUo20sWhq0uAyM7IFy1/mF3IvWH0CuV69fvj9Zec6ryb8y0gsUSp3pDmxCkeh Qo1mruihrSzJYIx1m4bL9g328CzTjk+sEH77U1G4EHSYm4k6bFKtAhTSkqFwOW+0kbJ8 GamUl1giGcO4OiQ9VZODAORr/v41Q1fSd3g5AkstbYm/80y3Xj6TZ0hZob9yNqiEbQwq J/vfkSZX0XVs5IZ9f68bQPgu28+Tt9GTeZWM+3RW5azxYD/V7GS3lG2AlXMAPTIJZFsU Xq7Q== X-Gm-Message-State: AOJu0YzJekJMD/RoAwMy22jQBLQ/8i0Y+b840Yvfy5mtmd6IctKBWTpu IMNdWm9sMdhwtb8wnu07GMGD2KAt0zf5Li90EOWrhRyP+bnkWjAU2pESJJM63Gri X-Gm-Gg: ASbGncs6vnraJkTLEDqvUMGksspAQGLPm6aDXsGFAm8x7gLrOhe8ztVnsTRP1JPY+GS cqQWG+f0Oa+2K6vu51cSGK35NJOXMcB5uQi+y4cXv/nve7I6V/ZdwsYuIT3OMwzAlSgmZCzNLcw I/eDQHfD6tb+XJNqjstgh74uhYCvwzLFyOXDJmpgZhAKcNhfHcQ6f5oP8V8mGaWE3HEXLK4XcH4 7BjUiwU/ZrjZNMtTB+WWwk/SuLP9pmzyaIUny7ybQZTPzOvQLmQ6er0x3JDxF2aoYbaOQ99+rDi 69MRJduhYXzyBqJEfH5k3sWiGNLZEttoGfSPzeProIzZ4QyOtIgMQ7Ew9HR2LgfnqeCL8KSebAC TdAp4bFzPlzjH3Ov+rw0SOCTDO6h9yKOpnlEmEwQAjVDuDESrG+/+poi93qKOps32kOzJCiT4m/ HTzWAohM93NVG5zQy8pbRzz+gaaX3/nyrn7AJtdC+wlesVc3W5pSK0Aev/b6MshQw5C24= X-Google-Smtp-Source: AGHT+IGW4D0lXSlWs3TmDsGRLwaEvoluKtRmCX47T4Nwd4L5+oUFwNMTUyue7S+to7ix3wowc8R8jQ== X-Received: by 2002:a05:6602:2ccb:b0:948:7255:e2b5 with SMTP id ca18e2360f4ac-9492b85c431mr17183639f.4.1763497148452; Tue, 18 Nov 2025 12:19:08 -0800 (PST) Received: from godzilla.raven-morpho.ts.net (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id ca18e2360f4ac-948fd4c273bsm419823939f.18.2025.11.18.12.19.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 12:19:07 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, jbaron@akamai.com Cc: ukaszb@chromium.org, louis.chauvet@bootlin.com, Jim Cromie Subject: [PATCH v6 07/31] dyndbg: make ddebug_class_param union members same size Date: Tue, 18 Nov 2025 13:18:17 -0700 Message-ID: <20251118201842.1447666-8-jim.cromie@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251118201842.1447666-1-jim.cromie@gmail.com> References: <20251118201842.1447666-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" struct ddebug_class_param keeps a ref to the state-storage of the param; make both class-types use the same unsigned long storage type. ISTM this is simpler and safer; it avoids an irrelevant difference, and if 2 users somehow get class-type mixed up (or refer to the wrong union member), at least they will both see the same value. Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- include/linux/dynamic_debug.h | 2 +- lib/dynamic_debug.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index 98a36e2f94b6..4b7c3b997657 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -103,7 +103,7 @@ struct _ddebug_info { struct ddebug_class_param { union { unsigned long *bits; - unsigned int *lvl; + unsigned long *lvl; }; char flags[8]; const struct ddebug_class_map *map; diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index cb171088850c..d2ff203d0873 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -810,7 +810,7 @@ int param_get_dyndbg_classes(char *buffer, const struct= kernel_param *kp) =20 case DD_CLASS_TYPE_LEVEL_NAMES: case DD_CLASS_TYPE_LEVEL_NUM: - return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl); + return scnprintf(buffer, PAGE_SIZE, "%ld\n", *dcp->lvl); default: return -1; } --=20 2.51.1