From nobody Tue Dec 2 02:42:11 2025 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9054354ADB for ; Tue, 18 Nov 2025 20:19:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497154; cv=none; b=e8Rt3dHYSgybwvYGNjlpeoSiZZJ0bGybEiYQnbWqS/LPWtN72AoMOAJ2Fk5d82R3jpW/D16NYOz4dkniObZ1uN+QlrDvgJjptMH2mVIJVpNX31M4qjje52+Jd+zm3CmQXJlBHCPfAP3gIqFwWQ/kT2+3PRD8ZsfQEphthEHKN6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763497154; c=relaxed/simple; bh=IKKkKAyatfB9M+fl1u2RpSwZxVl5vqsyH+by9N75zYw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LuPHOcHkiREg3rxUFxwQ03HAm7xwVSFQrfBjnhML9HxTptJpKJBRSyWJKjIUHrcN7QPjTHdZKl/svDxN7Y7JY2g7IA2fPNjyZXiRm4WZH7nNtrxxGuE76EUqPyOj3Wp/Zc69Cg7WjUFkhEu/vQEuWgbgU7JJHALZkpVcsgJi8yw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q78W13Cr; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q78W13Cr" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-88703c873d5so216691339f.3 for ; Tue, 18 Nov 2025 12:19:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763497152; x=1764101952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HugTGWvRZIP85YVvSycVedsiX938Xu07Q7rlJ5dV9Ug=; b=Q78W13Cr50rCrztaXnbX2ZC63rq9pD8te7QzYdp5AK+eAWeAZyc/HAfhcE3VtKVyjd GdUaIw2y4oCM0qPy3U9EHC2jLHaoNSNU054wThguu0uEfN3C0koGIesMWORQLvRx/rz7 a4cAZ8+VeLik0d13HYkvbXTMnTff3Mb6roqddqTe7LCp4xjURScXkslykheOeWGUaD8w A9mz/+fm76sRNBcCwVUJTUbKMCnjpumg2gxKAY1cDUxbyMyyameWWxVaaJZuh1y9alTD 4zqGqVEuPgfsAPCnH4g9hnsiuQdN0fMDNqAdtH2UuUww7C7BvyecnnOGq75zdRUDS+Pn kv+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763497152; x=1764101952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HugTGWvRZIP85YVvSycVedsiX938Xu07Q7rlJ5dV9Ug=; b=azp1ulD61iebRDO0wnG/FOzn8Mukt84VVaAXrT0J9x1ReezRoU9NvGAIJ/h6qrhv+/ twkDFAohDMPceAQHPgOArh2ppzmDMFSjIn6nf+kqNsGukF6XI5BhZa1oCkydttPy5qgu +hyirYPBebtEDlkpk9sQ3rrD/uy7nqHiWG8C7/ckTKYBOZoA6BUngsy/Z57RYXNOBk/B h5eliWx9zF47tu8MRcAe+RHqrPh6qup6y8tBiuENTylABhJ3FAIRpYIaO/9+Tw4AtwGT xMp9p/3hSWTYDDzkPJew3KoINIhAbyTiyoALODVvPt1z71ouee94PHYfGFs0nwipdJWE v2Xg== X-Gm-Message-State: AOJu0YyB3Kx09pHVOdblM3Gozjp5K5neuS63C9ApDoHKk6HIl3vqStb6 R1f5YEp0kinBaSZELlx0oWbYrMTCUhVAn4UXwmRhEuKv5vm9vMY8RZmvn8qgpMek X-Gm-Gg: ASbGncu8LFqo0aCubRBK8BAq2pr+hx/Fewq0IpJZ4cxi8LS6NYareIUp5Xj1IJWO0nN eLjTlq2Io6whobky/0GDwqM9Ku129KXgU0ediIbc7fOA41iBcFp02n1a0sVh4QeJVqSjfh/3f2p UZSv6faBVqRwXHHpPdhe1WKIcgNlkrIp/E17exHNeOZXfnS2A2+D1hewmusHctWHKHR3+lp5Pa2 1GrCBX2KaSTTEjybKaSj37Td5Zx2FLrx7cjbU+Grkh3wNCC0nnorVCugoXubkDjqAoqLVI7j0gX pgf5Ao3sH8zvriLWQKg7vn7nz9CunLfEv/UXXIMFt9b381WzsQPK21SMLyA4hC1jg3ejy6QBiVZ //kyHFsVSV0npgFDb1o18sIY/luIq+b67ZlmsnKlZpm67rG2quYP8TdkwAuaPe3zt6eo1shSlMC 4vo3JHWAOv8Dm99vgYV941GqZ0jtvqKLO9opS5a5vRkHFeqLwg7iaR7KYmOA1sO/mLS8nNPGWGA iHryUZYYewbBHWE X-Google-Smtp-Source: AGHT+IECWQbKajGsqhe9QxBChIn5TDnSeh/Y4LdT/nK7CygIVpJSPa9upZN/tzTEvHgyVA3Qskpj5w== X-Received: by 2002:a05:6602:6406:b0:949:d7:734b with SMTP id ca18e2360f4ac-94900d77599mr1197783939f.13.1763497151646; Tue, 18 Nov 2025 12:19:11 -0800 (PST) Received: from godzilla.raven-morpho.ts.net (c-98-38-17-99.hsd1.co.comcast.net. [98.38.17.99]) by smtp.googlemail.com with ESMTPSA id ca18e2360f4ac-948fd4c273bsm419823939f.18.2025.11.18.12.19.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 12:19:11 -0800 (PST) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, gregkh@linuxfoundation.org, jbaron@akamai.com Cc: ukaszb@chromium.org, louis.chauvet@bootlin.com, Jim Cromie Subject: [PATCH v6 10/31] dyndbg: reduce verbose/debug clutter Date: Tue, 18 Nov 2025 13:18:20 -0700 Message-ID: <20251118201842.1447666-11-jim.cromie@gmail.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251118201842.1447666-1-jim.cromie@gmail.com> References: <20251118201842.1447666-1-jim.cromie@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" currently, for verbose=3D3, these are logged (blank lines for clarity): dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' dyndbg: flags=3D0x1 dyndbg: *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: parsed: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0 c= lass=3D... dyndbg: no matches for query dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs That is excessive, so this patch: - shrinks 3 lines of 2nd stanza to single line - drops 1st 2 lines of 3rd stanza 3rd line is like 1st, with result, not procedure. 2nd line is just status, retold in 4th, with more info. New output: dyndbg: query 0: "class DRM_UT_CORE +p" mod:* dyndbg: split into words: "class" "DRM_UT_CORE" "+p" dyndbg: op=3D'+' flags=3D0x1 *flagsp=3D0x1 *maskp=3D0xffffffff dyndbg: no-match: func=3D"" file=3D"" module=3D"" format=3D"" lineno=3D0-0= class=3D... dyndbg: processed 1 queries, with 0 matches, 0 errs Also reduce verbose=3D3 messages in ddebug_add_module When modprobing a module, dyndbg currently logs/says "add-module", and then "skipping" if the module has no prdbgs. Instead just check 1st and return quietly. no functional change Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet --- -v2 squash several verbose cleanups together --- lib/dynamic_debug.c | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 21c1db7e8705..1db2f627237a 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -275,9 +275,6 @@ static int ddebug_change(const struct ddebug_query *que= ry, } mutex_unlock(&ddebug_lock); =20 - if (!nfound && verbose) - pr_info("no matches for query\n"); - return nfound; } =20 @@ -510,7 +507,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) pr_err("bad flag-op %c, at start of %s\n", *str, str); return -EINVAL; } - v3pr_info("op=3D'%c'\n", op); =20 for (; *str ; ++str) { for (i =3D ARRAY_SIZE(opt_array) - 1; i >=3D 0; i--) { @@ -524,7 +520,6 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) return -EINVAL; } } - v3pr_info("flags=3D0x%x\n", modifiers->flags); =20 /* calculate final flags, mask based upon op */ switch (op) { @@ -540,7 +535,7 @@ static int ddebug_parse_flags(const char *str, struct f= lag_settings *modifiers) modifiers->flags =3D 0; break; } - v3pr_info("*flagsp=3D0x%x *maskp=3D0x%x\n", modifiers->flags, modifiers->= mask); + v3pr_info("op=3D'%c' flags=3D0x%x maskp=3D0x%x\n", op, modifiers->flags, = modifiers->mask); =20 return 0; } @@ -550,7 +545,7 @@ static int ddebug_exec_query(char *query_string, const = char *modname) struct flag_settings modifiers =3D {}; struct ddebug_query query =3D {}; #define MAXWORDS 9 - int nwords, nfound; + int nwords; char *words[MAXWORDS]; =20 nwords =3D ddebug_tokenize(query_string, words, MAXWORDS); @@ -568,10 +563,7 @@ static int ddebug_exec_query(char *query_string, const= char *modname) return -EINVAL; } /* actually go and implement the change */ - nfound =3D ddebug_change(&query, &modifiers); - vpr_info_dq(&query, nfound ? "applied" : "no-match"); - - return nfound; + return ddebug_change(&query, &modifiers); } =20 /* handle multiple queries in query string, continue on error, return @@ -1245,11 +1237,10 @@ static int ddebug_add_module(struct _ddebug_info *d= i, const char *modname) { struct ddebug_table *dt; =20 - v3pr_info("add-module: %s.%d sites\n", modname, di->num_descs); - if (!di->num_descs) { - v3pr_info(" skip %s\n", modname); + if (!di->num_descs) return 0; - } + + v3pr_info("add-module: %s %d sites\n", modname, di->num_descs); =20 dt =3D kzalloc(sizeof(*dt), GFP_KERNEL); if (dt =3D=3D NULL) { --=20 2.51.1