From nobody Tue Dec 2 02:43:00 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010027.outbound.protection.outlook.com [52.101.193.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE8C534D91F; Tue, 18 Nov 2025 14:07:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474828; cv=fail; b=Kn1Px6tMDUmBn+KRK2KCFm7qk1V+nNkZs3ChnDHdlORP21LAsZSepVb4uf55Ur8cSTC/Ci+n3+ymK1mmsxegBXnKizXrCmWYtz0hP93vbG0CpNc6lUCjhBEk/7FbF75B2u6l8XCwoIgNzVc2b/Y2QAiFkjPp4E3ywiZ/k6J+8ls= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474828; c=relaxed/simple; bh=5KviH5TX5TXDrOh1xK54HGlfQmnwlsXiGvaREQfTr4E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mirtU0MHAC9jKXeIQHMKqb7PZOUyJFsi9GxaeVs4Pliwvjt3rpxRoRdkC72EMSFIJUZfkBRmK8Q8TwYzcJ5fWkik14incPUvUcBYNhBzqVf5hWs5a1ytufBUocInlnxpNBS4eSfoz1EV5QhggLevyfb21nPbHZaZC9s6nJgj8Lo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bcLBloCM; arc=fail smtp.client-ip=52.101.193.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bcLBloCM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l1CfsdZgdwcjJ5xnc/2oyEloPBAui/a0ZVWJCkWvdF2hvGjwuYa7QCnn/S6DM9iKY+bUW/rOcCiFRlr0NRRk46U+2Q9nb6G/b6DJ9Nd4m2XrSb+0qBmEI3+WoIeZq2SsYP5hTNidfscGwn0B8bvmQhs73ZvMLq4QBQHCn9lE6KUrGCSWooa0BQDu31xRmk3nliv4TDiIDYFw78KUbPbRHs5ylThDuolMQCDeTBGgswT5KQxMA1ToVNRccGbWJfq+CRSEn3OcF11wDKW+dY/uqG4a0HbiwLGHlw04kFdMqX6apsSYFNKuNRmrjgImtkkjUeauPF+5VqYOei8n0RXpEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OrkGSN8CDfa1ksEgZ4dSdggsOVy1ZCo8TYmGwqMg7w0=; b=EfSvBOAMJEeDde0LjIPfa6N919GZL7bdreFEiLdWDaeix5YB6RSrMm93H68Q2GJLtOm1Xmf9/sDlO4KyhVXkdJD98PpnHwCR++3s2JZjiRT7u4jEPVVUSXdrTaod+2HgrLzsO4tc20tkfhwcsJBSpM+9xSV14w7yOFx5rBadeKGIeUk2qeL4i08CbdwKfxKrCK2iCXCAY3Um7q9jLLdVYs12QVVAiDiJ8lUO+qOQwjMPMzpUu4IzcxIWy6YHajZkU9qG5UAON/srHubeEcuoLBw89fabqNgReTb1wJG+Y+DcxgihLILUiqUxNq0ChEGNxEtZ2zg12NNZgNi+iCFMXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OrkGSN8CDfa1ksEgZ4dSdggsOVy1ZCo8TYmGwqMg7w0=; b=bcLBloCMs8IQioLRWf3CxPqrbhaKagu4IQfqTqIG4WpKKK2SqrYR/qphM9Axdzvd6N6ZkiVtTersw/9Dh4NJIELn3QyzKsyOSTX2BiQQjHqv6X9oBRfo4ZOXM7eGO/AAg4eM+APojVBq8uw0rLhZPM30C+Bls89CdWsUL2ZKxfZhTR8F+4Rhw8GqIhHycqYz6xWy42mE6uvyIHq2o+C/wi062p8Lou62iqGr4aRZfUGd/ANPsS62v1yTaS66Cbh/pW+0ecWaqAtRtBF2/OjjGbHgSAQP2sgyJIP5nSTCCiZoxE0vGHbiMt9F9MgWMPoyiZcJRSx6ySamfkml9QKU5A== Received: from PH2PEPF0000384C.namprd17.prod.outlook.com (2603:10b6:518:1::70) by MW6PR12MB8958.namprd12.prod.outlook.com (2603:10b6:303:240::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Tue, 18 Nov 2025 14:07:03 +0000 Received: from CY4PEPF0000EE32.namprd05.prod.outlook.com (2a01:111:f403:f912::2) by PH2PEPF0000384C.outlook.office365.com (2603:1036:903:48::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Tue, 18 Nov 2025 14:07:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE32.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:02 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:06:41 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:06:41 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:06:37 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 1/6] i2c: tegra: Do not configure DMA if not supported Date: Tue, 18 Nov 2025 19:36:15 +0530 Message-ID: <20251118140620.549-2-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE32:EE_|MW6PR12MB8958:EE_ X-MS-Office365-Filtering-Correlation-Id: e36b7b86-1524-4830-b527-08de26abbf5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?drJE4VD3fWQBy57Iow9NuQ2lxTd0dacz0AstozyXVHBV9sM/XJqhlGszkQuz?= =?us-ascii?Q?6oEPZVxf4wjTykqU/grCPS8NNLUGq5baGIIFDPkGiNgYZRnmXq7DBF9Ruoix?= =?us-ascii?Q?bqkZMl4t0z/+gnmLISEeAf9ri5yRbFZeYQLj5+K7Mw9SOBADlC+aHUxlbE2W?= =?us-ascii?Q?LNJyof6pANcDORk0Qp+MCjoIcAUVzdMhZDqsRcSh3c58gp8DrIrGoXdp0v4u?= =?us-ascii?Q?YeGH13zG8DIzR2aTqvuxcDk61YPwtrUo1sKleI7uhmSIT9l4PI9BS2I5zuc9?= =?us-ascii?Q?UWOthGyqbZobk+sVEKeunbk/heNFYAgsz/ywmbkIxh9NCGQT3TWcIa1LbISq?= =?us-ascii?Q?5ze6/vnWt/vIvXmcRkrEieSvaiIlmZSYhpgN29Yp1rh5k9QjzP45pFV83U3r?= =?us-ascii?Q?bSQ8ZlWmXcVbrpnWZ38eXz5wl9yR3f0QaGde+ognMFEOMjCeUjgNQsEuXLhm?= =?us-ascii?Q?Csa/TEJVEoez0Esqbu/o32b2ITojBg+j0BR/0Ud/bKZ42ojU0v0kywNRhZdI?= =?us-ascii?Q?3o17Sbfs4qMkstNS6PDOtTJOwyrztI09pwTQuY8UnmBgj7I8dMugsmuNwkkq?= =?us-ascii?Q?q7zKoH8NSnT2+pyI6RIsPcVvoLuVJMVsC+VTruGQ3BylsPKaFBERL4Fw7jnV?= =?us-ascii?Q?dcugEPZktCwwfiEZsIsEYLoq7NOopaHaM3FulOCy+YFUMCHsEBQtEmry7U4j?= =?us-ascii?Q?gN2usqw0BgCB+QBb6gXkNwKYoQbe6PCFnQJ3r30187gy6xHGy6WxRz+zV65/?= =?us-ascii?Q?pbilg9EBCOGJhofn4R0ERw22NKhzYX6qhxa24PKxHLXnCwDsceLrtwkMJcn4?= =?us-ascii?Q?vuIIaKnJBJJY3ogRkjJgS2gRxhR1sAG6KXn/LRa7ycdfTc4CQj+1M3R/IwMi?= =?us-ascii?Q?i+N/CG060zNReVqUVuhSwP9ceecBlLtxXSwe/5IH6NNPKh8wbX63Mvhi28nX?= =?us-ascii?Q?Ubpx8KDkokLoXV2HmHH0yM2MBzoCMoFyarRzWRsFEZLjkIPw+aH+82+nClJr?= =?us-ascii?Q?4H4G5IOnA6Xfhm5HubUJ1rvdCS7dOmbRgdmmZtnNyDDGXhm8V7yadBqWJyXv?= =?us-ascii?Q?8O0uV000BWSIQTnEQQEk7mEa//e9T5DOetrGegN0M6IF+lAfkn4sT6MeNSxm?= =?us-ascii?Q?RqYYQEN4By0KxHV0rKgbCQEnXp4TMs+LKeRUp6ByouW0ohChQBElwldICajR?= =?us-ascii?Q?//E5r9nro7L+j7uOHkd2IPpntTBjDRwEKlGKzKSe8/fmRI4orMNneKTp+su0?= =?us-ascii?Q?ykeAVmv9jBKjFrrxtKa169aVCTuoEKr0/GYPbM6kg2RwSeGHG+MH+qA/Ksqd?= =?us-ascii?Q?1LCFG/v+lfPrFhNddvmn51V/43j2iljxGvxonnxwzqjH7qllM3j4+RJHQ9mR?= =?us-ascii?Q?Cd6pjCWfrsaoWZOwSQWiWDv7McKzc9DJJq5yAFhZfj/xmTrvegKg0PBrrXlb?= =?us-ascii?Q?4ysYQF4MpqDIpzzngXO9k9id8WLZKF94ykEd1HobUPWe91w4xjCXSfVok1qJ?= =?us-ascii?Q?N7S7kX/KB65Qf1E7GAlwoe1Hte1EuR4PU5EAC7hKuaf3JgU6qNSEwwCmJ/5k?= =?us-ascii?Q?Hb0P2w3J59tTtHHYQak=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:02.3777 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e36b7b86-1524-4830-b527-08de26abbf5a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE32.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8958 Content-Type: text/plain; charset="utf-8" From: Kartik Rajput On Tegra264, not all I2C controllers have the necessary interface to GPC DMA, this causes failures when function tegra_i2c_init_dma() is called. Ensure that "dmas" device-tree property is present before initializing DMA in function tegra_i2c_init_dma(). Signed-off-by: Kartik Rajput Reviewed-by: Jon Hunter Acked-by: Thierry Reding --- v4 -> v9: * Moved the condition down to have all dma checks together. v2 -> v4: * Add debug print if DMA is not supported by the I2C controller. v1 -> v2: * Update commit message to clarify that some I2C controllers may not have the necessary interface to GPC DMA. --- drivers/i2c/busses/i2c-tegra.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index e533460bccc3..bd26b232ffb3 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -449,6 +449,11 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2= c_dev) if (IS_VI(i2c_dev)) return 0; =20 + if (!of_property_present(i2c_dev->dev->of_node, "dmas")) { + dev_dbg(i2c_dev->dev, "DMA not available, falling back to PIO\n"); + return 0; + } + if (i2c_dev->hw->has_apb_dma) { if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) { dev_dbg(i2c_dev->dev, "APB DMA support not enabled\n"); --=20 2.50.1 From nobody Tue Dec 2 02:43:00 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013001.outbound.protection.outlook.com [40.107.201.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEAF2F998A; Tue, 18 Nov 2025 14:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474834; cv=fail; b=C6fwAurCNfmQAS5zhAGBsCD1bHpoanDmE7Vz6++2xRry6gRqK0oEO70h8Y3GQ88g6T2HEyTAHadOil3rndQY3mbYnzjQ/CN7mAN0NTN8bS9cvvrcFkL9BthCljmPA/f3acM26N4zFE07NcfZhLkke1Owucihr6SWJ467QjRlMHU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474834; c=relaxed/simple; bh=aYVGvmrVuGHYwT36Esw9CSlEuegTN+6kUDfou7WrnK8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FFstJ3yDqJnMvS5fiwvwohw+/lTJi27ZJxMa6vkVLT853yw35hEePXAVZKqrfOq3vhYPgrGg0gPD1BiwMi25W0PYVneeW0cyrsDN2ds9qqPtwFBpXJEGqbCzFMzHaiINNRXTBBzExKxsyJrKIy0H9DxHdTcatYlwj1QwDblGkyY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=XnJrcNmp; arc=fail smtp.client-ip=40.107.201.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="XnJrcNmp" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uUAE/7y++8iWOEUVU8Wbpbd4Wny6K/vkl8xLu1ykjdNTTaNtCHjhK1QA3O8LbHwPsufFioruC8kXWX+JrdmOX03XU4+Jb+lWbtlljmNXzCA/1o31mtA3E/9CMZySI4PFPwUfRV4tTTDOHR6lFX9ccm/wdvBofxw6R7o1q9U6WxAlZ6RtpAgTqAr6VP+pxMUNQ175FA03gkJ0+CYD3yCspBQ7LTcz3jZLVtmTSYVvJSvcG75lmA0HF+Bz/MIgfkFUPnMAHR3UVyHpajxEZYqE8Vhwt8yXPHf8WCEpwK/LJ+amXlgoFPoJl7X3y3RZKJ87HBl8A1cWsMq98UjSkp5B0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4GTF1qzVgXXkL1W0mW7t8iS9cdfQZtmnCvO3o+eFOEA=; b=ucU02SPTLCIiKCE1G/b8FlRkGTX/t5BQqAVpdBIkFoGyRH7JqEads3yDmqsW6wQyncFVt/nSiZz1XYMdsNxfV6XaWkZWUKP9rIdL1p/sJGVRCFu95xYEGvbXs+/8YhmgnEf2tYOXTywPcOt6BuVprZ4fEVBlilDMt4Cs3QyA93vVfXg2g6g4oroSBOCXmiTKVXM7cdo7vJ8zk7OuZ0/Y/fH8Vtmo+3XH9I7qo2N5yCIq5ntB5gXRTsEvq6B4IN9UwiyT2WC1B3AkWTrkdCYNShSbmJIacwtpSZvyVqi87d5CTb+0IXyfN15FasTYJU4THq/97CceJ41Rjf4O/4L17A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4GTF1qzVgXXkL1W0mW7t8iS9cdfQZtmnCvO3o+eFOEA=; b=XnJrcNmp4lx2ulDoAOMAlXC+ZDK8w1hkLR0O60RxKSVzRXK2tRn5XG+p1FxPuqikNxEYQZqIig59+cDXEUsfISHsOVK12q19tbbCcXU/nK844BH9POsUA2cfZAoQ8th+kEGLwrsB+jatgFmA8ED9hWUHihDCYUoSSUI4JCJvgzGx6INbZpM/7mTtG53Zpfw5T6Gq3NrodbH4INbEmJ9uQlyIn4fXTlGYVsTEPQv0sww04EM57CxfY6zWmHqN3KUwxBMi0oGkUuNKv12H50L6hhBIipd8k4jq3rAkfF68MI5zWDW0Fnuoxw/wIxuMpPFqCykakDG0OnPtORyZ+d/TzQ== Received: from DS7PR03CA0321.namprd03.prod.outlook.com (2603:10b6:8:2b::6) by SJ2PR12MB9210.namprd12.prod.outlook.com (2603:10b6:a03:561::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Tue, 18 Nov 2025 14:07:06 +0000 Received: from CY4PEPF0000EE36.namprd05.prod.outlook.com (2603:10b6:8:2b:cafe::3b) by DS7PR03CA0321.outlook.office365.com (2603:10b6:8:2b::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.22 via Frontend Transport; Tue, 18 Nov 2025 14:07:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE36.mail.protection.outlook.com (10.167.242.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:05 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:06:48 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:06:47 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:06:44 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 2/6] i2c: tegra: Use separate variables for fast and fastplus Date: Tue, 18 Nov 2025 19:36:16 +0530 Message-ID: <20251118140620.549-3-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE36:EE_|SJ2PR12MB9210:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ec95162-a107-4de1-6417-08de26abc129 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PRAhR7eWmaBRy0vtemzQpSQ27Dclf6xrCLOll6n29nLLRPjjKG/UG6TTIlAF?= =?us-ascii?Q?FsTqNn36a71DnNn/uo5AaiD+Kqvmkb1mt1CO70lfxlzwUWUlXOzL/O30Fwgx?= =?us-ascii?Q?GHge5Sp7yyj6qR3F+iNcwuUkUX/29lrT2dM36J2CkpyHdZamDU4a6cqs3ciL?= =?us-ascii?Q?I4vq/E2JWhNnT8//gEhVgByQBmfXJOAUAsv7Svoznojcl0B6ApM83gG3a5jS?= =?us-ascii?Q?PbI+R8DfJsbu4ngnA6UXmhG49lnd/w52TJfcVDSKDA4z7zO/PMDAHO995rHJ?= =?us-ascii?Q?HpgGZzL7H50kdTPk+lHxeDILdLrjvqKJ3mUWU8j8oP7LU3FA1VTdAVFCoCNB?= =?us-ascii?Q?hc7uzx04HGJojp82SK+F5ukVIWTWWvVZXMWTHKU5tPHMZgELRrBdkDWcZ6cz?= =?us-ascii?Q?wAugVoLXX0FQvc7sanIu5usisq9o0hGwEaRjtoY6Z73hoDyBkmqyy3mhH9Lz?= =?us-ascii?Q?YIhCC0LIzuseWgyqrAICGtQe93MmhWdBQD5D9sj6janLIqmZlmdTjB91rjJI?= =?us-ascii?Q?TwJ/zq9g5ehRng0cTDCcjGPTMVzaWyUnwaBi+CxfKeDnUNz+VYoE/2EFyE/+?= =?us-ascii?Q?sjPdV8uu5TVoFXJwBT+NzbAf1nTsNtfeVibU/ZRIBSnjHHDJPhBtQu7idIIg?= =?us-ascii?Q?wd5XziH/MxlBT4K/W1dCHEKfI+7ejA+myzFW08fV5xUxiSbrEJuydIzazK+a?= =?us-ascii?Q?+T0jN3Hw5K+bxZnPhG4Bq7X3uWo0IxvUu+CtORFcjdOBMGQlEvx1KU8ioM2A?= =?us-ascii?Q?NH4UXfDCJjuyQtk0LcZYeUTY4+v9tOLoH5tiKFV7UIvxyrrQB1nihGmY6gSm?= =?us-ascii?Q?wY6R5qG6+jJtit7uCUvFxM17bUmDBFXm76UpJ7mOttGH1mwU2ZahCdhfDWtK?= =?us-ascii?Q?hzHPbke9FiGaDX7wa/OgQu6YQdT9+lXhzOycjamlZBiecldSRRCpQaKSFahS?= =?us-ascii?Q?21gY4V1aQEzyrZDOsptKTLBDl0OOOI7239CXBjkbrNTWYNbjmFR9MoUFs9qJ?= =?us-ascii?Q?s+Y6I5NtIFMB7eWV+D51giqT9Fh4kUAlVQKPwx5E9WVSw/c6blZsjWKzYFP4?= =?us-ascii?Q?ID3BcBVMtWVu4dMW1ENo2YTI4SnS6RbVC1VL/9NaOo4uAhTtYYRVchRAxPmv?= =?us-ascii?Q?nfu0pXCKArhTbvQcWRFKiMJTV0STeajEKECBvCwyKBERK3FEMLuS7nKKW8Aw?= =?us-ascii?Q?XXhtZjxtLCxStMkcDc9YoQuBMwBOJiwl+YB6TdpkyzR4NaxXc3ecK847k4ud?= =?us-ascii?Q?2i2y6NumZ9LNFRoVx47wCiyX9gp6ZhMaPu/BAQoDrEWoaVPZmmK3boCWLw/q?= =?us-ascii?Q?cx8dxuynxGQ2i0370YzGGJXHfIyGhNMEp7LzDeSPXW24UPydh+Q+5oG+h1Dx?= =?us-ascii?Q?IZ7nhXQJV6RbXnsHOWCV4r7dTIUI7SrYGKKbekbnxUAcPjwcLHzxPVhnTkh1?= =?us-ascii?Q?ugbhNNbO5RqNfn1rXLJqjwWlBRxt91JhYWnWxoUL/k/Usbl+XbeYf2RJyyzS?= =?us-ascii?Q?cNGa0V7QKbbTf7k1fAiReYToTELW72TjsIg7RbQo/uNqCEZuSYPZNGwETS+I?= =?us-ascii?Q?kWnnn5tEvADen/ba0Mo=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:05.3999 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ec95162-a107-4de1-6417-08de26abc129 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE36.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9210 Content-Type: text/plain; charset="utf-8" The current implementation uses a single value of THIGH, TLOW and setup hold time for both fast and fastplus. But these values can be different for each speed mode and should be using separate variables. Split the variables used for fast and fast plus mode. Signed-off-by: Akhil R Reviewed-by: Jon Hunter Acked-by: Thierry Reding --- drivers/i2c/busses/i2c-tegra.c | 119 ++++++++++++++++++++------------- 1 file changed, 73 insertions(+), 46 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index bd26b232ffb3..c0382c9a0430 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -196,12 +196,16 @@ enum msg_end_type { * @has_apb_dma: Support of APBDMA on corresponding Tegra chip. * @tlow_std_mode: Low period of the clock in standard mode. * @thigh_std_mode: High period of the clock in standard mode. - * @tlow_fast_fastplus_mode: Low period of the clock in fast/fast-plus mod= es. - * @thigh_fast_fastplus_mode: High period of the clock in fast/fast-plus m= odes. + * @tlow_fast_mode: Low period of the clock in fast mode. + * @thigh_fast_mode: High period of the clock in fast mode. + * @tlow_fastplus_mode: Low period of the clock in fast-plus mode. + * @thigh_fastplus_mode: High period of the clock in fast-plus mode. * @setup_hold_time_std_mode: Setup and hold time for start and stop condi= tions * in standard mode. - * @setup_hold_time_fast_fast_plus_mode: Setup and hold time for start and= stop - * conditions in fast/fast-plus modes. + * @setup_hold_time_fast_mode: Setup and hold time for start and stop + * conditions in fast mode. + * @setup_hold_time_fastplus_mode: Setup and hold time for start and stop + * conditions in fast-plus mode. * @setup_hold_time_hs_mode: Setup and hold time for start and stop condit= ions * in HS mode. * @has_interface_timing_reg: Has interface timing register to program the= tuned @@ -224,10 +228,13 @@ struct tegra_i2c_hw_feature { bool has_apb_dma; u32 tlow_std_mode; u32 thigh_std_mode; - u32 tlow_fast_fastplus_mode; - u32 thigh_fast_fastplus_mode; + u32 tlow_fast_mode; + u32 thigh_fast_mode; + u32 tlow_fastplus_mode; + u32 thigh_fastplus_mode; u32 setup_hold_time_std_mode; - u32 setup_hold_time_fast_fast_plus_mode; + u32 setup_hold_time_fast_mode; + u32 setup_hold_time_fastplus_mode; u32 setup_hold_time_hs_mode; bool has_interface_timing_reg; }; @@ -677,25 +684,21 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_d= ev) if (IS_VI(i2c_dev)) tegra_i2c_vi_init(i2c_dev); =20 - switch (t->bus_freq_hz) { - case I2C_MAX_STANDARD_MODE_FREQ + 1 ... I2C_MAX_FAST_MODE_PLUS_FREQ: - default: - tlow =3D i2c_dev->hw->tlow_fast_fastplus_mode; - thigh =3D i2c_dev->hw->thigh_fast_fastplus_mode; - tsu_thd =3D i2c_dev->hw->setup_hold_time_fast_fast_plus_mode; - - if (t->bus_freq_hz > I2C_MAX_FAST_MODE_FREQ) - non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_plus_mode; - else - non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_mode; - break; - - case 0 ... I2C_MAX_STANDARD_MODE_FREQ: + if (t->bus_freq_hz <=3D I2C_MAX_STANDARD_MODE_FREQ) { tlow =3D i2c_dev->hw->tlow_std_mode; thigh =3D i2c_dev->hw->thigh_std_mode; tsu_thd =3D i2c_dev->hw->setup_hold_time_std_mode; non_hs_mode =3D i2c_dev->hw->clk_divisor_std_mode; - break; + } else if (t->bus_freq_hz <=3D I2C_MAX_FAST_MODE_FREQ) { + tlow =3D i2c_dev->hw->tlow_fast_mode; + thigh =3D i2c_dev->hw->thigh_fast_mode; + tsu_thd =3D i2c_dev->hw->setup_hold_time_fast_mode; + non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_mode; + } else { + tlow =3D i2c_dev->hw->tlow_fastplus_mode; + thigh =3D i2c_dev->hw->thigh_fastplus_mode; + tsu_thd =3D i2c_dev->hw->setup_hold_time_fastplus_mode; + non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_plus_mode; } =20 /* make sure clock divisor programmed correctly */ @@ -1496,10 +1499,13 @@ static const struct tegra_i2c_hw_feature tegra20_i2= c_hw =3D { .has_apb_dma =3D true, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x2, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x0, - .setup_hold_time_fast_fast_plus_mode =3D 0x0, + .setup_hold_time_fast_mode =3D 0x0, + .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, }; @@ -1521,10 +1527,13 @@ static const struct tegra_i2c_hw_feature tegra30_i2= c_hw =3D { .has_apb_dma =3D true, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x2, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x0, - .setup_hold_time_fast_fast_plus_mode =3D 0x0, + .setup_hold_time_fast_mode =3D 0x0, + .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, }; @@ -1546,10 +1555,13 @@ static const struct tegra_i2c_hw_feature tegra114_i= 2c_hw =3D { .has_apb_dma =3D true, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x2, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x0, - .setup_hold_time_fast_fast_plus_mode =3D 0x0, + .setup_hold_time_fast_mode =3D 0x0, + .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, }; @@ -1571,10 +1583,13 @@ static const struct tegra_i2c_hw_feature tegra124_i= 2c_hw =3D { .has_apb_dma =3D true, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x2, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x0, - .setup_hold_time_fast_fast_plus_mode =3D 0x0, + .setup_hold_time_fast_mode =3D 0x0, + .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D true, }; @@ -1596,10 +1611,13 @@ static const struct tegra_i2c_hw_feature tegra210_i= 2c_hw =3D { .has_apb_dma =3D true, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x2, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0, - .setup_hold_time_fast_fast_plus_mode =3D 0, + .setup_hold_time_fast_mode =3D 0, + .setup_hold_time_fastplus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, }; @@ -1621,10 +1639,13 @@ static const struct tegra_i2c_hw_feature tegra186_i= 2c_hw =3D { .has_apb_dma =3D false, .tlow_std_mode =3D 0x4, .thigh_std_mode =3D 0x3, - .tlow_fast_fastplus_mode =3D 0x4, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0, - .setup_hold_time_fast_fast_plus_mode =3D 0, + .setup_hold_time_fast_mode =3D 0, + .setup_hold_time_fastplus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, }; @@ -1646,10 +1667,13 @@ static const struct tegra_i2c_hw_feature tegra194_i= 2c_hw =3D { .has_apb_dma =3D false, .tlow_std_mode =3D 0x8, .thigh_std_mode =3D 0x7, - .tlow_fast_fastplus_mode =3D 0x2, - .thigh_fast_fastplus_mode =3D 0x2, + .tlow_fast_mode =3D 0x2, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x2, + .thigh_fastplus_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x08080808, - .setup_hold_time_fast_fast_plus_mode =3D 0x02020202, + .setup_hold_time_fast_mode =3D 0x02020202, + .setup_hold_time_fastplus_mode =3D 0x02020202, .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, }; @@ -1671,10 +1695,13 @@ static const struct tegra_i2c_hw_feature tegra256_i= 2c_hw =3D { .has_apb_dma =3D false, .tlow_std_mode =3D 0x8, .thigh_std_mode =3D 0x7, - .tlow_fast_fastplus_mode =3D 0x3, - .thigh_fast_fastplus_mode =3D 0x3, + .tlow_fast_mode =3D 0x3, + .thigh_fast_mode =3D 0x3, + .tlow_fastplus_mode =3D 0x3, + .thigh_fastplus_mode =3D 0x3, .setup_hold_time_std_mode =3D 0x08080808, - .setup_hold_time_fast_fast_plus_mode =3D 0x02020202, + .setup_hold_time_fast_mode =3D 0x02020202, + .setup_hold_time_fastplus_mode =3D 0x02020202, .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, }; --=20 2.50.1 From nobody Tue Dec 2 02:43:00 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013022.outbound.protection.outlook.com [40.93.201.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92D034FF78; Tue, 18 Nov 2025 14:07:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.22 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474865; cv=fail; b=FM/kP68MEPOGf4/hz/OiXr4PaBjszk571A+r5Jysw8aSEGUa8kdnp04fvbmd/RsS+ZMemYOHiAXqZQqoVeLg66ZcgcaOXqLvVF5n1AxTcg131nVs/G+SPHj0DP3gvt409a8BMtcYlY6LpcIK1ho3X7JM0oIClSFkkVhHmE7oIhg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474865; c=relaxed/simple; bh=rByUIxJvPq7lf8Ha560i5IiXwltO/Fa0CQkmTVdwilc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TiXMH80wbtRYHMFmFCaPpAJ6fct9Hkm02ZkIGjZcbICB2NAfE2DblZsxv55DDH0U7oVYCIZUyBdFzNb/WLK8XCVTG6MXTtaT3FE+9T+2s9MqZz1u+3Tnqw7s4RrNrwy/YiXIrT9PYo8ycGJkMhGmkSlyEj+pm0bnEqBXZEBM3kk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=AoW3WoKR; arc=fail smtp.client-ip=40.93.201.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="AoW3WoKR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CBY4YVcxx0IsO4CNBAElex9G0k+UXB104Sr2fOxasIwfikj6XQ2lw2dsnM/PiMBKOoe5mVqbwYzshclTmFpWzKVrLswU5xkRgTjFTsxw2eb7Rtf+gMRxthlNgk5AWGkhmY/T9pLQqpSoTXIbUwbDzpQIAebOeQHQbKO6BnS9obJk3VoU1F1OLA0OUy4oLuPyaX1PTGTktTuzegMcq13vwN+XKs4KgoPACY9ZOgoz7ie06lSvGHpsbd9ZIKwynlE68njPIPv68D0Q5ZHIjhcjj5vXqUYp4rZosQLwJUO+9k/YevHyMy3ni/cnQ3jnPCjP4tWEqhL9S2mPg7+La96jaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7meLqHP7G8QXYNuP7u4QjEVzgIfcMB+sCRJ6KwOYC8A=; b=Oc+hhVOws3ooABIb8XHx5Ot3KS+ZrMqTEseg+dyuFqzSStrmQd1ngXpvl1/cHB5PMR2GcJ/dPwSBANJZehXxWh4dWS8DKonGZq5VQ4ZDruuxUHM53bU9OarHVaPKOdnEHcR3qY6XUs5qqq/PN242j4k7W73g7j1lr4s6rOM4tkTjlDchs7x00Zsjt6HMjtzZ2Fq/HQJQ3ZgbWJwJCVh/xUFo94hZOGhvBTpBFCw1Q00LFiBjt+0prhOvDXcQdLsmdywUqBoO6iqfZ8O4L3lTB//ni9jdNX/GFIxC1BCjUPv3gxcnGhrS3dRXaCEK5jxk7Rwo4POd+ZJ+q7Fj27xjDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7meLqHP7G8QXYNuP7u4QjEVzgIfcMB+sCRJ6KwOYC8A=; b=AoW3WoKRPB6YfxEf97Q2qU6K3vSuKQj/S+a2PLZnOGAhK3WGvcUHx2c/UZly43xsENgnJ0NVwPIXIBN3W4Ms0naOdVlHM70xUmw6QdgaIwX+q3fZRi8I9hHzVgol50Bmivc6qtELVW1zjmhtLKxQdsTUMvqsepyA7hLJNakOnNUEr5X7yNQ69dj8xQh2gxxcE5LaJVQYmcY0Ld2G034YWFq6243+mFjemoIjklG8pV1Um3SnbfzRgwtQFBN2/Tk1iBrTZ/mbSpS8zvXDL9B7ia0XitIaMNIEc6ozHQyQ8mn3v+CzrnL5Eic6IW+dTiHh8YDZw4Gzuygs1BVwFdDVNQ== Received: from CY5PR15CA0223.namprd15.prod.outlook.com (2603:10b6:930:88::9) by LV5PR12MB9803.namprd12.prod.outlook.com (2603:10b6:408:306::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Tue, 18 Nov 2025 14:07:38 +0000 Received: from CY4PEPF0000EE33.namprd05.prod.outlook.com (2603:10b6:930:88:cafe::e5) by CY5PR15CA0223.outlook.office365.com (2603:10b6:930:88::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Tue, 18 Nov 2025 14:07:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CY4PEPF0000EE33.mail.protection.outlook.com (10.167.242.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:16 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:15 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:07:12 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 3/6] i2c: tegra: Update Tegra256 timing parameters Date: Tue, 18 Nov 2025 19:36:17 +0530 Message-ID: <20251118140620.549-4-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE33:EE_|LV5PR12MB9803:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d9006b2-bf03-4a7d-f0f1-08de26abd2da X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?plwcOFgoXAaUq0334i+qvVNfDaoy4acpJRjEmLUL3Mf3RJxpNdZ64B2J6q0q?= =?us-ascii?Q?rg8lAPSRpTGRl8MAabJSyyHYRL4BcNSnMgaY3YPLfGO/huuEg4vbsAiySz3f?= =?us-ascii?Q?hmZYz8PqQwkr4sZcIXJGtE2VA+7gTtgxxZxySe1J5dBwK03ssnEPNiuA710W?= =?us-ascii?Q?t2bxPBvx3SxfPeYcqshfzeDc/YLbCTHQaiL1pgtSbmbGaWkDdqXwBhitzeQX?= =?us-ascii?Q?f9HpZa4NUGoZ1Up8legwUEeC3rN1L2WRvvmy4elrvgRmBRyXDUQ8EETASde0?= =?us-ascii?Q?DpuaYPYf4n62Xu1bScD7B0mHMQluuWrlqsQapqvL4sl9KNqPg3K2gKgkTB2T?= =?us-ascii?Q?XtRemoheJ+oXiu2lmeNTVy5YT9sAWdsjpFqOYUh5KheqERrANc11V9FefUsz?= =?us-ascii?Q?8wo+6XYVIrZOpFMyuf7ogM8V6M/H9FeIosHO1OS29lPFaY0ZAp4dmk5rHmUn?= =?us-ascii?Q?k7mBTRnzSerBlZTKjuZbEceQSUdObGiLIvJ9TS6lWOiJ2KAqig+hLV7Nou3m?= =?us-ascii?Q?VaJf4dvwoRHuXceIaerkzVVMs9EoysyYYJPWgh/Bdsv1J4RmRMZngeDQXxuW?= =?us-ascii?Q?YO2+lN2/eax/89I3FQBS1zfUgyygx8V10VSr20tpJGitdWa9FCOKUsNZVUKg?= =?us-ascii?Q?HN5ybj7r5dR9TLIJ4ComkOl4YO07Hfazf7jxT7ODDxolwsdOrG0fMa/Zm3D2?= =?us-ascii?Q?EvnVwpn8HUy+Uu5G+07DGpvpWTFIb0CJM7Q37qZOpNWrViRUlRHnO7jnQRzV?= =?us-ascii?Q?gVTx8JNQN9e5voqN+SngKmyhLX+wckF79ZtbIVsO1VF0ZX3l/lYop20V4oKM?= =?us-ascii?Q?NIYQK1kxirSbzs4+SQuUAp7wyxqWky82jUuuY0EeA1pcbpbHsjWhvkrXVRpe?= =?us-ascii?Q?4ZVAVZwD9sl6vrbwi/FCqhTkB380rKW1p2fyUAqbr5/rD/TDqDXubWvIWOdf?= =?us-ascii?Q?vs1KQYvuzKNBkdMRK/mZaNAS9xvYsEK4Mjb5COjB1fTSQvRupGSqlPWUxCD2?= =?us-ascii?Q?F79xTvBJgDTMsF6y3RK+XHELPKsDD2NYhcZhM5ahs+T5mCygtm2Ph9aMcKhn?= =?us-ascii?Q?vu3avTXFToqntfUfPS38nNpE5tQIXl0VKPAFFasXzcIH8yu66rPmNirIsdGa?= =?us-ascii?Q?NCyptrLjcn8huJGDqdQr3D94SeaOSWjj3Ygm1poRxud/B7so3rZXR5urhuYl?= =?us-ascii?Q?vbEocJcUnC/TWuOX1kJlS4138oB4VtGmpjMreT7OqHVi62W/8TkRUTKnimMY?= =?us-ascii?Q?WbJprjHZCKvlrSA0YaG02iFaamnQQXDfKPsf3SqQC4nH3qG7eJ+ykv/KWtGq?= =?us-ascii?Q?Sxzw2XEw40YX/NNtm929EE4BV1agtQ+7SW4nUiWB3cUyBZTPZXEBMASNuHqR?= =?us-ascii?Q?Ju4llGrc+6zl4E46ScopCXvx704bo295FRmA4asY6RpgXanHsKZhw/ePsYkZ?= =?us-ascii?Q?IGKGWvg3tF170TbL6+bLOAnDINNXa/UsYxLeZDi8N1ila2Za36s7i0fW8GUB?= =?us-ascii?Q?lGg0oa/S+u9hyAbT1vsMTSjQ3fCilpd9c46p/n05j6UWOlYXAiA+HYPGwf1F?= =?us-ascii?Q?Hoder1OHjpFJMD+r9YM=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:35.0908 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d9006b2-bf03-4a7d-f0f1-08de26abd2da X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE33.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV5PR12MB9803 Content-Type: text/plain; charset="utf-8" Update the timing parameters of Tegra256 so that the signals are complaint with the I2C specification for SCL low time. Signed-off-by: Akhil R Reviewed-by: Jon Hunter Acked-by: Thierry Reding --- drivers/i2c/busses/i2c-tegra.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index c0382c9a0430..470d0d32d571 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1684,7 +1684,7 @@ static const struct tegra_i2c_hw_feature tegra256_i2c= _hw =3D { .clk_divisor_hs_mode =3D 7, .clk_divisor_std_mode =3D 0x7a, .clk_divisor_fast_mode =3D 0x40, - .clk_divisor_fast_plus_mode =3D 0x19, + .clk_divisor_fast_plus_mode =3D 0x14, .has_config_load_reg =3D true, .has_multi_master_mode =3D true, .has_slcg_override_reg =3D true, @@ -1695,14 +1695,13 @@ static const struct tegra_i2c_hw_feature tegra256_i= 2c_hw =3D { .has_apb_dma =3D false, .tlow_std_mode =3D 0x8, .thigh_std_mode =3D 0x7, - .tlow_fast_mode =3D 0x3, - .thigh_fast_mode =3D 0x3, - .tlow_fastplus_mode =3D 0x3, - .thigh_fastplus_mode =3D 0x3, + .tlow_fast_mode =3D 0x4, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x4, + .thigh_fastplus_mode =3D 0x4, .setup_hold_time_std_mode =3D 0x08080808, - .setup_hold_time_fast_mode =3D 0x02020202, - .setup_hold_time_fastplus_mode =3D 0x02020202, - .setup_hold_time_hs_mode =3D 0x090909, + .setup_hold_time_fast_mode =3D 0x04010101, + .setup_hold_time_fastplus_mode =3D 0x04020202, .has_interface_timing_reg =3D true, }; =20 --=20 2.50.1 From nobody Tue Dec 2 02:43:00 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013015.outbound.protection.outlook.com [40.107.201.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E34625D53C; Tue, 18 Nov 2025 14:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.15 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474873; cv=fail; b=YEO6+ZG7CCW9XJmqK84uSA7fnErm5D+ggCP/x9K2ANF7OTdNOUafnMPs3ICmKPl6WqUDz+ypdaJF467oS1WZ2tT8izscadgLmaxoJk0+GhGn7lSjbboqxseTugi9uRdwhIzk5PMCYBVHYDLlcS+sHV8R4g9qemsStHvpfv+OLMw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474873; c=relaxed/simple; bh=saK2icSUBH2bMgkDPMNEVUFy2rmyPM5ByhLGIA4WaMI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m4e5aiZPQpIYQlkoDNawWKbqUHD9QANKF6iY+DS8ir5GVXJgfB2Wy5Ey3OiWbXECSjQF/LiMLUjl0o5Q8Qbn+JVxqG3RIzeLHIiNjfOou26XpevpU6e1mmY595B07rBejlgs4T5EyV0sShepMI0PAW8BJAVK93oOCb1wn0Zv7dI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QP8KJe/k; arc=fail smtp.client-ip=40.107.201.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QP8KJe/k" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iQgYeGeozzDRi1e27yOvqMHC4eY9bcs9F2baehHQ6Xk81aWy1OoKjJwV3rVqPuKciAgk5YNnU5WhP3e0qYFAAhHuyjZTgZxq650Aamtcyzn5e9EBYLKjLyi4pZSXoqN4I09dHJQCxBaXhIU3BvuCpX/OeIuKWWz9Ma0ptGnDplTzfNz8QIRy03UEzjj5tU0zK3NfO//EDAVHPEi0fZ7PxVfcvsByC2lNa52UbfdxI4b/5Vucj1Hq1slPLkyR2haMtzySJrnIYMOiMSJwUOgwEHcbRUJRrtpcUFkj5amaZ13kFNAbxGM9r0M59A5nRw/UqZfZZtCjrbNUcY0+5t6W+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rqJgGeb8psysB1P5j245bvwnlFLymkN6h7hZq5H7K7A=; b=Af68Ld1bX+07YZE+azIlq6j/gheNSK0DEu4AuuEWAZVAe0p6RpJUiOiJMPBThu2qbiG95aYTUpKY1OPZgvFqD+j1IRM7CRAfSWbAVwXZb7RnNI2Sir4m8d0Dp3MG1T0tm5pF3aSxwNWV9OLIQbWY2v7c5CH84vQQqNx8VShKMBaKOOSvTe0jJE0TqXjPlSryC+NN3nL5fPvb9YLmZ/KUfoONZtdkpAs0CI3VOAjn364Y0qJZ8pxcmZbKZthHXKO1CmSCvp4XxEYcxQgTrGSTGw37DQxHaZFlwb61i1kZWzwFCGRycoAlEYhVVGeJkJ/J3BdG5e35wFfPxvrghQvr7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rqJgGeb8psysB1P5j245bvwnlFLymkN6h7hZq5H7K7A=; b=QP8KJe/kieMMnrq3HJBWbN0yiXewGosnErTi1WPFfbQhl9v5C5Zr8O1apCcXwN7igs8RqsfB+k2gfzwrhVcLEAl3E0Aud7kCVfRxvx9Y9Np1m5AlI9QZ7kcC3FrL/o45MgVsjpmSFsUelqsbQDKm13Unr3a+OelnF1iudPLCyAstOKucchFHdXKDAgv5e0g9EsrC+zJsvTVBKcNzntecSVC1al3yvcw/IOBSZyYli9Cd5PRk6+zN2aX66RYzzW0bYOdD9jwGNZkxPkkX8tm1YkXXyW8A0xB/o4Hrkr/6DvBet8KHhUOKhfcT/A1aLHyIIBEtF1FT0A2LQP8ZJQD7RA== Received: from BYAPR21CA0020.namprd21.prod.outlook.com (2603:10b6:a03:114::30) by MN0PR12MB6079.namprd12.prod.outlook.com (2603:10b6:208:3c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.18; Tue, 18 Nov 2025 14:07:44 +0000 Received: from SJ5PEPF00000207.namprd05.prod.outlook.com (2603:10b6:a03:114:cafe::de) by BYAPR21CA0020.outlook.office365.com (2603:10b6:a03:114::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9366.2 via Frontend Transport; Tue, 18 Nov 2025 14:07:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000207.mail.protection.outlook.com (10.167.244.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:43 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:25 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:24 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:07:20 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 4/6] i2c: tegra: Add HS mode support Date: Tue, 18 Nov 2025 19:36:18 +0530 Message-ID: <20251118140620.549-5-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000207:EE_|MN0PR12MB6079:EE_ X-MS-Office365-Filtering-Correlation-Id: 154b2375-4e11-49fd-a54a-08de26abd817 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?uKnjKelJKDNvAMl+QcgM3npYoDRfmwyyX2fUbc1K7Z1b0KB/EwvCgYAVix6m?= =?us-ascii?Q?43oXD/6QT+ER4AOZdhoCZaQSU/PXGvTFd1EWWQRd6E74ievRz8no0auSPfUt?= =?us-ascii?Q?DgXLbqOXOdFd8SYM4mmZPToy/EUbD/2BbFYCpZVeIoKnw9Zg7+pdLgJZC2Tr?= =?us-ascii?Q?hXD+7yfaPt6Dc2ezr4/9alsS9E4FUc346yVo2nzZbgfXadEfQuLD0OnOuVpP?= =?us-ascii?Q?zbroESUlCWPL3CZ2ftGuCSfcBnT2/ZxPuQ/DXe0/CaTcy4t/CKzkTIQoA8ve?= =?us-ascii?Q?eq5RLr+tO0rA/p5V1gIgXNTRoq9YVw6vMfVOMy+k3kdwsT8wN6Rlt2LG9+dw?= =?us-ascii?Q?u4zAaDPSgmh4VjsH4dzLG2jB5eWNhq7d08uCjKwO8VZn/kl/9cI0YtWz6Dat?= =?us-ascii?Q?09Mq81b5s+g2Pk1zirbUpdfa17xSgePDaeUMWokn7AQJQzUvUp7GvEgEFm5P?= =?us-ascii?Q?HVvuT+Z5pBcSS3HKytETK8tXCwoUgCFw7aMZX9vbk02gdUk1ZujNjFChJj6Y?= =?us-ascii?Q?JBkbK+u2k38m90gTvDwdPH97vieDWRgmdbiTL/k6coyr80uW3ab+E5lTyYcL?= =?us-ascii?Q?i1Eta1w7YUE3nEvCCnQj6V0E2S0APUGrbQCmnUwNTwdlW0lIDOYMe2/cFM4q?= =?us-ascii?Q?4yeLTVTLBIJOzbl7mJClREXr7DVDfvHYB6BR0UGMobk7e27LlGyWoDJ+/Q0V?= =?us-ascii?Q?KXxXMGxpWBahWMGR/47sb6qn/eVu8/MCxjdJ3m2i7TTLYuzn6eOg6U/DJkOm?= =?us-ascii?Q?/b7pEYVPAu7wnd10/8gYXAiBwvVMXr6456EozfMcFX0XDRPlBsPt6QiXa69P?= =?us-ascii?Q?5svMKvAnIDN0fWCaKu22UH7mqVTlBQWWGKNbRV20uStci4nL1pBGtEk2DPnJ?= =?us-ascii?Q?EF0GjexIkqT1gSBbd0IUFM9TJ6mM+48xA0rJIJUnswZRYQd95+2b1W+8/Zdx?= =?us-ascii?Q?Vky+Nsiomm7iVby8piFl4PKQqZ/hII7utUKjc2rEZLyNCS4wxw5MUYMQYi+/?= =?us-ascii?Q?YpoS7CJy+omdEgHXM91mCvg0RfOKfdSBOsiCRruxGb4yOYKYaqhFsbesEkjS?= =?us-ascii?Q?Sn7XH/kEfZFEQKUWosg3fC1OS8wjVNaPo4VhLJo4joygxdZ4bhhAcUGt+bmV?= =?us-ascii?Q?bnCh8V5vUP1cbCKVksUBCNShhLFIz0+A+rwYwSj9+fqhBHMuFfZgbZFlaQ/B?= =?us-ascii?Q?wF3NSnHBT7Ho1vnIhLg/hCixEaJCucKBOne4NZ11NPyfBKy+0HyQs/vzVBJy?= =?us-ascii?Q?jpT3mfXIMut2qe70pokuSAL+BdJYs8N8QL9V2oQZ1P4/D3UDcCS3EoxS228+?= =?us-ascii?Q?8JtSSe+wh3qs6QHzSNVzSINSdwyD3l04DUR5VQs3dS4YAcftfIkDbmnfYjbi?= =?us-ascii?Q?8vFaFu265RMCpod1YIWdlYDfkwu1/ktHEjHo9nc1QSPGBOwgY886/5VD7UKh?= =?us-ascii?Q?a6MRqod1y4l1qpEy642ULd2MTDJ80BnIPMWu1Ui2vPZan4g6PVTg3Hg9Bfrr?= =?us-ascii?Q?ettD151j5KaXkzk7mpQIkRI6JbZn8B2ZtVn0C+MPUzsiPyqC4ZXFVGmHE/Xi?= =?us-ascii?Q?fguDAimp65I4XywlxOIVHF+dWra+sAQ6nM41KwxY?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:43.8450 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 154b2375-4e11-49fd-a54a-08de26abd817 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000207.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6079 Content-Type: text/plain; charset="utf-8" Add support for High Speed (HS) mode transfers for Tegra194 and later chips. While HS mode has been documented in the technical reference manuals since Tegra20, the hardware implementation appears to be broken on all chips prior to Tegra194. When HS mode is not supported, set the frequency to FM+ instead. Signed-off-by: Akhil R Signed-off-by: Kartik Rajput Acked-by: Thierry Reding Reviewed-by: Jon Hunter --- v12 ->v13: * Update has_hs_mode_support to enable_hs_mode_support * Update the commit description v11 -> v12: * Update bus_freq_hz to max supported freq and updates to accomodate the changes from Patch 2/6. v10 -> v11: * Update the if condition as per the comments received on: https://lore.kernel.org/linux-tegra/20251110080502.865953-1-kkart= ik@nvidia.com/T/#t v9 -> v10: * Change switch block to an if-else block. v5 -> v9: * In the switch block, handle the case when hs mode is not supported. Also update it to use Fast mode for master code byte as per the I2C spec for HS mode. v3 -> v5: * Set has_hs_mode_support to false for unsupported SoCs. v2 -> v3: * Document tlow_hs_mode and thigh_hs_mode. v1 -> v2: * Document has_hs_mode_support. * Add a check to set the frequency to fastmode+ if the device does not support HS mode but the requested frequency is more than fastmode+. --- drivers/i2c/busses/i2c-tegra.c | 59 ++++++++++++++++++++++++++++++++-- 1 file changed, 57 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 470d0d32d571..b2fe8add895b 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -85,6 +85,7 @@ #define PACKET_HEADER0_PROTOCOL GENMASK(7, 4) #define PACKET_HEADER0_PROTOCOL_I2C 1 =20 +#define I2C_HEADER_HS_MODE BIT(22) #define I2C_HEADER_CONT_ON_NAK BIT(21) #define I2C_HEADER_READ BIT(19) #define I2C_HEADER_10BIT_ADDR BIT(18) @@ -200,6 +201,8 @@ enum msg_end_type { * @thigh_fast_mode: High period of the clock in fast mode. * @tlow_fastplus_mode: Low period of the clock in fast-plus mode. * @thigh_fastplus_mode: High period of the clock in fast-plus mode. + * @tlow_hs_mode: Low period of the clock in HS mode. + * @thigh_hs_mode: High period of the clock in HS mode. * @setup_hold_time_std_mode: Setup and hold time for start and stop condi= tions * in standard mode. * @setup_hold_time_fast_mode: Setup and hold time for start and stop @@ -210,6 +213,7 @@ enum msg_end_type { * in HS mode. * @has_interface_timing_reg: Has interface timing register to program the= tuned * timing settings. + * @enable_hs_mode_support: Enable support for high speed (HS) mode transf= ers. */ struct tegra_i2c_hw_feature { bool has_continue_xfer_support; @@ -232,11 +236,14 @@ struct tegra_i2c_hw_feature { u32 thigh_fast_mode; u32 tlow_fastplus_mode; u32 thigh_fastplus_mode; + u32 tlow_hs_mode; + u32 thigh_hs_mode; u32 setup_hold_time_std_mode; u32 setup_hold_time_fast_mode; u32 setup_hold_time_fastplus_mode; u32 setup_hold_time_hs_mode; bool has_interface_timing_reg; + bool enable_hs_mode_support; }; =20 /** @@ -646,6 +653,7 @@ static int tegra_i2c_master_reset(struct tegra_i2c_dev = *i2c_dev) static int tegra_i2c_init(struct tegra_i2c_dev *i2c_dev) { u32 val, clk_divisor, clk_multiplier, tsu_thd, tlow, thigh, non_hs_mode; + u32 max_bus_freq_hz; struct i2c_timings *t =3D &i2c_dev->timings; int err; =20 @@ -684,6 +692,14 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_de= v) if (IS_VI(i2c_dev)) tegra_i2c_vi_init(i2c_dev); =20 + if (i2c_dev->hw->enable_hs_mode_support) + max_bus_freq_hz =3D I2C_MAX_HIGH_SPEED_MODE_FREQ; + else + max_bus_freq_hz =3D I2C_MAX_FAST_MODE_PLUS_FREQ; + + if (WARN_ON(t->bus_freq_hz > max_bus_freq_hz)) + t->bus_freq_hz =3D max_bus_freq_hz; + if (t->bus_freq_hz <=3D I2C_MAX_STANDARD_MODE_FREQ) { tlow =3D i2c_dev->hw->tlow_std_mode; thigh =3D i2c_dev->hw->thigh_std_mode; @@ -694,11 +710,22 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_d= ev) thigh =3D i2c_dev->hw->thigh_fast_mode; tsu_thd =3D i2c_dev->hw->setup_hold_time_fast_mode; non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_mode; - } else { + } else if (t->bus_freq_hz <=3D I2C_MAX_FAST_MODE_PLUS_FREQ) { tlow =3D i2c_dev->hw->tlow_fastplus_mode; thigh =3D i2c_dev->hw->thigh_fastplus_mode; tsu_thd =3D i2c_dev->hw->setup_hold_time_fastplus_mode; non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_plus_mode; + } else { + /* + * When using HS mode, i.e. when the bus frequency is greater than fast = plus mode, + * the non-hs timing registers will be used for sending the master code = byte for + * transition to HS mode. Configure the non-hs timing registers for Fast= Mode to + * send the master code byte at 400kHz. + */ + tlow =3D i2c_dev->hw->tlow_fast_mode; + thigh =3D i2c_dev->hw->thigh_fast_mode; + tsu_thd =3D i2c_dev->hw->setup_hold_time_fast_mode; + non_hs_mode =3D i2c_dev->hw->clk_divisor_fast_mode; } =20 /* make sure clock divisor programmed correctly */ @@ -720,6 +747,18 @@ static int tegra_i2c_init(struct tegra_i2c_dev *i2c_de= v) if (i2c_dev->hw->has_interface_timing_reg && tsu_thd) i2c_writel(i2c_dev, tsu_thd, I2C_INTERFACE_TIMING_1); =20 + /* Write HS mode registers. These will get used only for HS mode*/ + if (i2c_dev->hw->enable_hs_mode_support) { + tlow =3D i2c_dev->hw->tlow_hs_mode; + thigh =3D i2c_dev->hw->thigh_hs_mode; + tsu_thd =3D i2c_dev->hw->setup_hold_time_hs_mode; + + val =3D FIELD_PREP(I2C_HS_INTERFACE_TIMING_THIGH, thigh) | + FIELD_PREP(I2C_HS_INTERFACE_TIMING_TLOW, tlow); + i2c_writel(i2c_dev, val, I2C_HS_INTERFACE_TIMING_0); + i2c_writel(i2c_dev, tsu_thd, I2C_HS_INTERFACE_TIMING_1); + } + clk_multiplier =3D (tlow + thigh + 2) * (non_hs_mode + 1); =20 err =3D clk_set_rate(i2c_dev->div_clk, @@ -1217,6 +1256,9 @@ static void tegra_i2c_push_packet_header(struct tegra= _i2c_dev *i2c_dev, if (msg->flags & I2C_M_RD) packet_header |=3D I2C_HEADER_READ; =20 + if (i2c_dev->timings.bus_freq_hz > I2C_MAX_FAST_MODE_PLUS_FREQ) + packet_header |=3D I2C_HEADER_HS_MODE; + if (i2c_dev->dma_mode && !i2c_dev->msg_read) *dma_buf++ =3D packet_header; else @@ -1508,6 +1550,7 @@ static const struct tegra_i2c_hw_feature tegra20_i2c_= hw =3D { .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra30_i2c_hw =3D { @@ -1536,6 +1579,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_= hw =3D { .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra114_i2c_hw =3D { @@ -1564,6 +1608,7 @@ static const struct tegra_i2c_hw_feature tegra114_i2c= _hw =3D { .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra124_i2c_hw =3D { @@ -1592,6 +1637,7 @@ static const struct tegra_i2c_hw_feature tegra124_i2c= _hw =3D { .setup_hold_time_fastplus_mode =3D 0x0, .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra210_i2c_hw =3D { @@ -1620,6 +1666,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c= _hw =3D { .setup_hold_time_fastplus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra186_i2c_hw =3D { @@ -1648,6 +1695,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c= _hw =3D { .setup_hold_time_fastplus_mode =3D 0, .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra194_i2c_hw =3D { @@ -1671,17 +1719,20 @@ static const struct tegra_i2c_hw_feature tegra194_i= 2c_hw =3D { .thigh_fast_mode =3D 0x2, .tlow_fastplus_mode =3D 0x2, .thigh_fastplus_mode =3D 0x2, + .tlow_hs_mode =3D 0x8, + .thigh_hs_mode =3D 0x3, .setup_hold_time_std_mode =3D 0x08080808, .setup_hold_time_fast_mode =3D 0x02020202, .setup_hold_time_fastplus_mode =3D 0x02020202, .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D true, }; =20 static const struct tegra_i2c_hw_feature tegra256_i2c_hw =3D { .has_continue_xfer_support =3D true, .has_per_pkt_xfer_complete_irq =3D true, - .clk_divisor_hs_mode =3D 7, + .clk_divisor_hs_mode =3D 9, .clk_divisor_std_mode =3D 0x7a, .clk_divisor_fast_mode =3D 0x40, .clk_divisor_fast_plus_mode =3D 0x14, @@ -1699,10 +1750,14 @@ static const struct tegra_i2c_hw_feature tegra256_i= 2c_hw =3D { .thigh_fast_mode =3D 0x2, .tlow_fastplus_mode =3D 0x4, .thigh_fastplus_mode =3D 0x4, + .tlow_hs_mode =3D 0x3, + .thigh_hs_mode =3D 0x2, .setup_hold_time_std_mode =3D 0x08080808, .setup_hold_time_fast_mode =3D 0x04010101, .setup_hold_time_fastplus_mode =3D 0x04020202, + .setup_hold_time_hs_mode =3D 0x030303, .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D true, }; =20 static const struct of_device_id tegra_i2c_of_match[] =3D { --=20 2.50.1 From nobody Tue Dec 2 02:43:00 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010017.outbound.protection.outlook.com [52.101.193.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE2E35A135; Tue, 18 Nov 2025 14:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.17 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474876; cv=fail; b=b6sd7I6q5kPS9jVz0oVwSeYkPLj/nNX5XJSuHt7xyI7uRsEISN7caoxBORh52PlAEqoTVPAvF1arvAo2+royfxhPUMoBx3x0luq8UBSS5i7SvG+2uO+KX00hkkpNC47RC2hw3Gw487pBy70uUKH6JCEF2S8lGSmOBCZpjI2LYzU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474876; c=relaxed/simple; bh=V2vWTB/gNnzE+H/bagNXVf7yLkSMAm/Zc9Ae7Jp/ti0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Il8yfSOwdPtS3vDcVvHD+dKtZ6CwOaOENIwubNsGyF/FmGPCX/DcDm4GKuJ8GAihGU3uwOFL8ChloGO+C7e5rCt+BE0EpJ/Dc0BE+xl9fMGFGX3yr77ZE7DNHZ8yOxBEGq7RRR1zfwkqMs+a5+ERtSmq5tJ4S3RT2AcMIDK9qTM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fUZihiv6; arc=fail smtp.client-ip=52.101.193.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fUZihiv6" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EEr5KRdjIw4cS/ym3kLzpBzU3sLXTlcYmx0qNDLl7U5qdmoKXyztmNqHYq/YrMEATuxt0yUpLOM2r5cleQfCJkTVmcm83HYaCkWWEuETR0eOTQi+pMTBOz1Ybdck3ssZgZzKjYjmROiaDMJKOPRYBthesRhEupKMTY5FbkXPOG0fmuHTSl5LehELwARgs9tlVQSgo/1CekA2cphxY4Cy8wBSCkBCNhfatOokoM55p59WF0S7F7trE8GH/fo9TpF1zSvfmUE0sdpdf5c+c5nyH6zxH2UqUZLg9NELWzxz8wuEZiYt0P6SwcQ+vieOi3VwkQ+vgX1y1pJIFXexFUjJ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nWpoHKong/aFqIjeiHu1NgO4HJViEp5/t0TPfrtcCkg=; b=KtobfHe7NPy0lDhIyPKfLknMnfGJloyh3AVrrkT6/49G1yVo/B7Jm34aOS36hfVTnKhBXNYQ2LZ5KG++Ediojnm9q+iBrSrsZtiODCCa3HBRi+dfDijSRWVRJI/f5L4INPBxK4Cxb5gCT1srmQ5RKttJExSXEQW4+Q/8/Sa69dWwV7e6Y+GxElc/5JeGCP+pD2Qg1L416DeAVF0v6CEszplGbScp+SfmyUJ33A0/2nByNbM0tusdXYl4fxv40hHxZHsdEh2OjO2xG6WkeWbOLSUN3O3Ya4Ad4ADMAu7Zyfd8med75n4ZnMX/Gk/6RlEG8EK1zAEFou70HzMNdRW+hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nWpoHKong/aFqIjeiHu1NgO4HJViEp5/t0TPfrtcCkg=; b=fUZihiv6o8I0Gyo9gtwBamHNqu65zvpE7gzSt2o0SnJA+6NtWsIZCtJR/NsyA69hl38zcgsAb4LSvjLOyQd2i/7sXq5KddByBp6cgKo1qNqZPJ0U7xi8+jej0a3MSyhqgPeA177O53LYAVIEEfrwRM1mDBovVIJZCg3LIiPbFBpWRb57bt3ANc7ndGVM4rchnicmFnbMlkIwErC4KEJ/nAhY2E93JNj7ijgrTJW2ViWCq7PT0IOkkYR1KAv7E08+pLuMgJ4wyskDWJ+8CPuOiSd402X4RV+dnZ7AnYo9KbhvNc8SDWZuuu/T/LWcIPkfBxKBhoQo+QDUYMHBw1mJkQ== Received: from SJ0PR13CA0081.namprd13.prod.outlook.com (2603:10b6:a03:2c4::26) by PH7PR12MB8154.namprd12.prod.outlook.com (2603:10b6:510:2b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Tue, 18 Nov 2025 14:07:51 +0000 Received: from SJ5PEPF00000205.namprd05.prod.outlook.com (2603:10b6:a03:2c4:cafe::f) by SJ0PR13CA0081.outlook.office365.com (2603:10b6:a03:2c4::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Tue, 18 Nov 2025 14:07:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000205.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:50 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:30 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:30 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:07:26 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 5/6] i2c: tegra: Add support for SW mutex register Date: Tue, 18 Nov 2025 19:36:19 +0530 Message-ID: <20251118140620.549-6-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000205:EE_|PH7PR12MB8154:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f9a096c-f8d2-4a84-7774-08de26abdc39 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5tWmHOc/KR6UeNyIdkCceqTQjQoREPfl6LBPEc0W+aBpYWU/kGxgoe8ixFTo?= =?us-ascii?Q?CtIRyHQQcFLRY20TiAdAJmWcuTP/V9n52mrZZyI2yZemGuBD8cnEQaEMOTQO?= =?us-ascii?Q?ziFFa+igZT0f8UX/38e+o1G2bRP/5XicbizGu847aUxGZvoEHy6USJPrz7mn?= =?us-ascii?Q?A04+WufjJPIdv/HT/gEA9fGeuVKX2p8TU1w/vfXZhFd6bzRH+G9AOVDnYf2Y?= =?us-ascii?Q?CUKFzR1hGRLYEUwldix8qOXzIEfLC3B/6x66s7dx5ExN3vzEmXCL/STraX2/?= =?us-ascii?Q?yMHquQqWKqI1eKOZfE33lvePr1WYqHIdfxauQ0JoAPX99tMF1KQrD/cb67MH?= =?us-ascii?Q?Lt13wSV2DmVLPzA+984zA2ibeXi/OTFqUuGgXRTifhqmRKJlaWSFrwclUgAE?= =?us-ascii?Q?NpPxugb3l7uH3l0XkxRYwiH81GQ7Fauc7usj1ilzFvp7JI5hLGiRMpl32xLS?= =?us-ascii?Q?EuchWEVyMp2gcKEnrSG+ueAJ0yBiORyyVQB/Pw16bzi1T+gCwEiH4rHshKFY?= =?us-ascii?Q?cIJolVQqPaln+MNIGCeYIPghWzN9G1fEq00avfUE3SAFg5+5xNQoJhYfnwL9?= =?us-ascii?Q?L+2YM13S0+hZ967etdY0iBEX1mfR1CNHnNbAXAuHdzlAudD7h9+gwdrz4Dll?= =?us-ascii?Q?9sPdMY9tgzb/6zWBahOQHT/7LNMyVUPCmfVwo6+rDuWYSJlcRRcsJl5pz0f+?= =?us-ascii?Q?bM4zcnam9PxmDbZkpBLrVjjBRG37SvfnbeOAvaJt/56NC99n6mJoX2kBnYFT?= =?us-ascii?Q?g9pEP9BAEjqUVciSUAUhGI9k154ue+rsLqNUjXCJLim58FNwqrRa/L04X1UN?= =?us-ascii?Q?fxc0nZ2W0r0bPDJLR2lL4w51JLVsTNmTbW8xEl5ON1f7bEMvWL3+sOl3zgeS?= =?us-ascii?Q?ELhxZ0Ke5YOFsKJM0q+oM+tmZHWXwy4khSGsyiATDyVnF5+8Pb9aTNJ4U2aY?= =?us-ascii?Q?yF03cHU/OnLZdNw0hs01TX/l2sWAB7QxSOIa35VOkkTek/ZvHRIoDzCIfzL0?= =?us-ascii?Q?PL6qQa23ZUILKiTtqokceq16sO9UsqYydxDttC4doyXTOGwXQOYqMl8Pv3UM?= =?us-ascii?Q?VTsXQD6OubtclXCEjicdf82OFpcK/0XUbIypUBI0v3vJbutDhq+rU63j9My1?= =?us-ascii?Q?1eB9Ii8v7jM1/YAd0prso4dWriKx5GVdpMimg7CXjUXUP/L+ggTlZMimMurN?= =?us-ascii?Q?FRUANrc71fhDOM7WLKGyrP3hg28BWv+09GqITrMBn4H878mKCX3a8v8FJfcM?= =?us-ascii?Q?rD9oklyHWJKqRRoMhVaHA3ywYkRTbg89GeUfi59dTJL/PO7dXylCH10MkFDh?= =?us-ascii?Q?I5cFZ4FOuVVPhtux7woleZGef46U/gHub2GDnil7n2AZtM8ghm4qMBZ34Kby?= =?us-ascii?Q?vEW8o4goErhQ8ggv3RGYB1eTRCYznuCGL96X1ph9/mSjppTqrwTbQ4MfLMEE?= =?us-ascii?Q?YyMTqb/w4nfeIGnMnwtcuAnhEx4iet77K9acSWXD4geQ61f4m7UUe5wvJz5M?= =?us-ascii?Q?lVLRaRKfiyMcBYJ5TGzHgC71fITtx9OeGoMGqwECXgdH/B4NgW/zUmsjJAbC?= =?us-ascii?Q?IRyP16orjL8sS+VkOl0=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:50.7945 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0f9a096c-f8d2-4a84-7774-08de26abdc39 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000205.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8154 Content-Type: text/plain; charset="utf-8" From: Kartik Rajput Add support for SW mutex register introduced in Tegra264 to provide an option to share the interface between multiple firmwares and/or VMs. This involves following steps: - A firmware/OS writes its unique ID to the mutex REQUEST field. - Ownership is established when reading the GRANT field returns the same ID. - If GRANT shows a different non-zero ID, the firmware/OS retries until timeout. - After completing access, it releases the mutex by writing 0. However, the hardware does not ensure any protection based on the values. The driver/firmware should honor the peer who already holds the mutex. Signed-off-by: Kartik Rajput Signed-off-by: Akhil R Reviewed-by: Jon Hunter Acked-by: Thierry Reding --- v7 -> v8: * Use `bool` instead of `int` for `locked` variable in tegra_i2c_mutex_lock() function. v6 -> v7: * Return bool from tegra_i2c_mutex_acquired() and tegra_i2c_mutex_trylock() functions. * Move `has_mutex` check inside tegra_i2c_mutex_lock/unlock functions. * Remove redundant empty line added in tegra_i2c_xfer() in v6. * Fix pm_runtime_put() not getting called if mutex unlock fails. * In tegra_i2c_mutex_lock() simplify the logic to check if the mutex is acquired or not by checking the value of `ret` variable. * Update commit message to describe the functioning of SW mutex feature. v4 -> v6: * Guard tegra_i2c_mutex_lock() and tegra_i2c_mutex_unlock() to ensure that they are called on platforms which support SW mutex. v3 -> v4: * Update timeout logic of tegra_i2c_mutex_lock() to use read_poll_timeout APIs for improving timeout logic. * Add tegra_i2c_mutex_acquired() to check if mutex is acquired or not. * Rename I2C_SW_MUTEX_ID as I2C_SW_MUTEX_ID_CCPLEX. * Function tegra_i2c_poll_register() was moved unnecessarily, it has now been moved to its original location. * Use tegra_i2c_mutex_lock/unlock APIs in the tegra_i2c_xfer() function. This ensures proper propagation of error in case mutex lock fails. Please note that as the function tegra_i2c_xfer() is already guarded by the bus lock operation there is no need of additional lock for the tegra_i2c_mutex_lock/unlock APIs. v2 -> v3: * Update tegra_i2c_mutex_trylock and tegra_i2c_mutex_unlock to use readl and writel APIs instead of i2c_readl and i2c_writel which use relaxed APIs. * Use dev_warn instead of WARN_ON if mutex lock/unlock fails. v1 -> v2: * Fixed typos. * Fix tegra_i2c_mutex_lock() logic. * Add a timeout in tegra_i2c_mutex_lock() instead of polling for mutex indefinitely. --- drivers/i2c/busses/i2c-tegra.c | 93 ++++++++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index b2fe8add895b..51af857d44d6 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -137,6 +137,14 @@ =20 #define I2C_MASTER_RESET_CNTRL 0x0a8 =20 +#define I2C_SW_MUTEX 0x0ec +#define I2C_SW_MUTEX_REQUEST GENMASK(3, 0) +#define I2C_SW_MUTEX_GRANT GENMASK(7, 4) +#define I2C_SW_MUTEX_ID_CCPLEX 9 + +/* SW mutex acquire timeout value in microseconds. */ +#define I2C_SW_MUTEX_TIMEOUT_US (25 * USEC_PER_MSEC) + /* configuration load timeout in microseconds */ #define I2C_CONFIG_LOAD_TIMEOUT 1000000 =20 @@ -214,6 +222,7 @@ enum msg_end_type { * @has_interface_timing_reg: Has interface timing register to program the= tuned * timing settings. * @enable_hs_mode_support: Enable support for high speed (HS) mode transf= ers. + * @has_mutex: Has mutex register for mutual exclusion with other firmware= s or VMs. */ struct tegra_i2c_hw_feature { bool has_continue_xfer_support; @@ -244,6 +253,7 @@ struct tegra_i2c_hw_feature { u32 setup_hold_time_hs_mode; bool has_interface_timing_reg; bool enable_hs_mode_support; + bool has_mutex; }; =20 /** @@ -388,6 +398,76 @@ static void i2c_readsl(struct tegra_i2c_dev *i2c_dev, = void *data, readsl(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev, reg), data, len); } =20 +static bool tegra_i2c_mutex_acquired(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + val =3D readl(i2c_dev->base + reg); + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + + return id =3D=3D I2C_SW_MUTEX_ID_CCPLEX; +} + +static bool tegra_i2c_mutex_trylock(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + val =3D readl(i2c_dev->base + reg); + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + if (id !=3D 0 && id !=3D I2C_SW_MUTEX_ID_CCPLEX) + return false; + + val =3D FIELD_PREP(I2C_SW_MUTEX_REQUEST, I2C_SW_MUTEX_ID_CCPLEX); + writel(val, i2c_dev->base + reg); + + return tegra_i2c_mutex_acquired(i2c_dev); +} + +static int tegra_i2c_mutex_lock(struct tegra_i2c_dev *i2c_dev) +{ + bool locked; + int ret; + + if (!i2c_dev->hw->has_mutex) + return 0; + + if (i2c_dev->atomic_mode) + ret =3D read_poll_timeout_atomic(tegra_i2c_mutex_trylock, locked, locked, + USEC_PER_MSEC, I2C_SW_MUTEX_TIMEOUT_US, + false, i2c_dev); + else + ret =3D read_poll_timeout(tegra_i2c_mutex_trylock, locked, locked, USEC_= PER_MSEC, + I2C_SW_MUTEX_TIMEOUT_US, false, i2c_dev); + + if (ret) + dev_warn(i2c_dev->dev, "failed to acquire mutex\n"); + + return ret; +} + +static int tegra_i2c_mutex_unlock(struct tegra_i2c_dev *i2c_dev) +{ + unsigned int reg =3D tegra_i2c_reg_addr(i2c_dev, I2C_SW_MUTEX); + u32 val, id; + + if (!i2c_dev->hw->has_mutex) + return 0; + + val =3D readl(i2c_dev->base + reg); + + id =3D FIELD_GET(I2C_SW_MUTEX_GRANT, val); + if (id && id !=3D I2C_SW_MUTEX_ID_CCPLEX) { + dev_warn(i2c_dev->dev, "unable to unlock mutex, mutex is owned by: %u\n"= , id); + return -EPERM; + } + + writel(0, i2c_dev->base + reg); + + return 0; +} + static void tegra_i2c_mask_irq(struct tegra_i2c_dev *i2c_dev, u32 mask) { u32 int_mask; @@ -1443,6 +1523,10 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, = struct i2c_msg msgs[], return ret; } =20 + ret =3D tegra_i2c_mutex_lock(i2c_dev); + if (ret) + return ret; + for (i =3D 0; i < num; i++) { enum msg_end_type end_type =3D MSG_END_STOP; =20 @@ -1472,6 +1556,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, s= truct i2c_msg msgs[], break; } =20 + ret =3D tegra_i2c_mutex_unlock(i2c_dev); pm_runtime_put(i2c_dev->dev); =20 return ret ?: i; @@ -1551,6 +1636,7 @@ static const struct tegra_i2c_hw_feature tegra20_i2c_= hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra30_i2c_hw =3D { @@ -1580,6 +1666,7 @@ static const struct tegra_i2c_hw_feature tegra30_i2c_= hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra114_i2c_hw =3D { @@ -1609,6 +1696,7 @@ static const struct tegra_i2c_hw_feature tegra114_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D false, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra124_i2c_hw =3D { @@ -1638,6 +1726,7 @@ static const struct tegra_i2c_hw_feature tegra124_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x0, .has_interface_timing_reg =3D true, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra210_i2c_hw =3D { @@ -1667,6 +1756,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra186_i2c_hw =3D { @@ -1696,6 +1786,7 @@ static const struct tegra_i2c_hw_feature tegra186_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0, .has_interface_timing_reg =3D true, .enable_hs_mode_support =3D false, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra194_i2c_hw =3D { @@ -1727,6 +1818,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x090909, .has_interface_timing_reg =3D true, .enable_hs_mode_support =3D true, + .has_mutex =3D false, }; =20 static const struct tegra_i2c_hw_feature tegra256_i2c_hw =3D { @@ -1758,6 +1850,7 @@ static const struct tegra_i2c_hw_feature tegra256_i2c= _hw =3D { .setup_hold_time_hs_mode =3D 0x030303, .has_interface_timing_reg =3D true, .enable_hs_mode_support =3D true, + .has_mutex =3D true, }; =20 static const struct of_device_id tegra_i2c_of_match[] =3D { --=20 2.50.1 From nobody Tue Dec 2 02:43:00 2025 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011058.outbound.protection.outlook.com [40.107.208.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B53F35A943; Tue, 18 Nov 2025 14:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.58 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474880; cv=fail; b=polavNv7+CxvuowskPUaV71uFXv9AWa3oEUHk4/f0y5ol7xlTkVrDCgAJ4SCL8eGGCoAr/ke4A9Xt5BIW3MnuHD2QI3mLOxg30vdgThJZMC4mlZ5+t3z6rya3+nqQoGRm6+mBID9K5u/A+D+PUEC74TUDvRvNtO+qiCJ/oHlkfo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474880; c=relaxed/simple; bh=jF6iFangv8G8VyLVQql5nEHz4n316Id/0Fft0BD/66E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nqf8CwkqeUukXUbza/vBdGbCQkjSg81E5SJfFei1hGT0iIKMU0uVA0CSqqjNXfq/5BoYzb7Jq1bRqca/yO17mfyXAcunw4Zq/2yLNSZA3hseK63MfPvmcYKJATQjK59opLMTNLULyYhL0kaOzzux5ou+eudlGvmnLzKz0IufjZE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VTabbOaC; arc=fail smtp.client-ip=40.107.208.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VTabbOaC" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DeASzysxk9OUxauzgf6RIElvIvB3S8smNEfr158MjaC/N4phhxdl1cbsKEgAnaGRSaGVEh0euNfJ3N1lGOrUP4S+deok2nBz4mNRdi2Zud+wzUGSrFlR4h+IHvWaxJlqOKxNzpd1nuJhb8vysiHmlqC7JOZhfE0STPogZq+45JOgcBXTf0WMU0X3N+CsHDE6fEOsTiwDxMG06iIgEl/8eyZmnTFhnsbp5PqU0CUr33KfTGNZW2+putag6Ne7muswdHViDqHCN4czAGRMahnIGPzoBkyB5Fcn4ELbzlx8ncKJgsyjENE9IPDILz8lmrNCR9Wo8/t/YxZz1ZcG29Yoyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jixEFeJSSx9hJDAdaTFKvCuIvaBIj0p3fYnyDFAG0s0=; b=bjTeF7zTr58+YXF4/p3+YpccqetxqVgYaF1B08qpCb99WWxInEty71V8KvG2yWrRDzWeaug+l1g1E5Bps6chfRuSZo0r0uEKLa9a6CiTSQOvnyirKXuiMRR1fXj4MndKXgGfB/P2DDwdjyARifRnHJ1wiGg9+X/QDC57Xw3MLg/fUMKNbH5Cv0/ihEVqLKV9wLBTmwXnbp5leBXN7dofQP38WegrHENVArthyetjRMNu3oIpWATocVepfkc0+bzWcOXy6Qg3roJapNANHavIKJSHFbgzvyBLvvpAQpy8gYd/9XWkzfwSlMfUcoYqaOduENIsS8xYDni4nUYzhLLEUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jixEFeJSSx9hJDAdaTFKvCuIvaBIj0p3fYnyDFAG0s0=; b=VTabbOaCF+FvnaXkuJWlhMnCBEL45mK/4gHxXawWdGyIut2Bk27KOjDgmcuCNAXYsaglj03rsn3IsGGb2b81qPbJfX1rJGsUbawkCbArSxJE81dcnVoDktwm3R2te4PVuIaGRI46TdnaNRZalo9212oNQ0kYTumXyAL7Jsdrrzzkapq9cZ4vQiMG5mCxxTuvzQalcX0ta3uRPJU4o2VkRrmHdtzyQ7wiwAlIssedOalJJnPLcR82r8cVJgG5W5NRATyeniTyVsToZiG3MOTC9lRpowEqY4W5ue02B59pQhbkRsyQ/SzfWsf5Rt6MJZ3qQXFICIvaAnyfglpHwho4DA== Received: from BY1P220CA0025.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::12) by IA1PR12MB8079.namprd12.prod.outlook.com (2603:10b6:208:3fb::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.22; Tue, 18 Nov 2025 14:07:54 +0000 Received: from SJ5PEPF00000206.namprd05.prod.outlook.com (2603:10b6:a03:5c3:cafe::7e) by BY1P220CA0025.outlook.office365.com (2603:10b6:a03:5c3::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9343.10 via Frontend Transport; Tue, 18 Nov 2025 14:07:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000206.mail.protection.outlook.com (10.167.244.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Tue, 18 Nov 2025 14:07:53 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:36 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Tue, 18 Nov 2025 06:07:36 -0800 Received: from BUILDSERVER-IO-L4T.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Tue, 18 Nov 2025 06:07:32 -0800 From: Akhil R To: , , , , , , , , CC: , , , Subject: [PATCH v13 6/6] i2c: tegra: Add Tegra264 support Date: Tue, 18 Nov 2025 19:36:20 +0530 Message-ID: <20251118140620.549-7-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251118140620.549-1-akhilrajeev@nvidia.com> References: <20251118140620.549-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000206:EE_|IA1PR12MB8079:EE_ X-MS-Office365-Filtering-Correlation-Id: 91c1ba48-5eac-4215-d9bf-08de26abddfb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|36860700013|82310400026|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?33n0FFVpd3hsI3AVFY+cZuQFjZa9ZUIAh4vPwg+gC87+vJqWlbLeCNZeFwTk?= =?us-ascii?Q?h2u4eZg++cs1VKgJJU8R1h/vr8iyBn5JcNTnS/Pu70Q59I0kehQGoFWyiB+/?= =?us-ascii?Q?PAtMQGlVx2Fg1ep9gXyBveXFAzu9HlnvRAHGVufxYtkHFoUj8wtq56HGa4/S?= =?us-ascii?Q?sXM3XwJstJuthbRDDJ2GBI09DUpMKVLv8EICCzqfbX6/j98+tYJErNS/Q7+f?= =?us-ascii?Q?peCHQSgZ4XeEiNOILpykRqoYgcWTpSCkHMi+WeDo5jfTe8fqyI5P2ozd6hnv?= =?us-ascii?Q?b57OAkRTTpeSu3vIGzrBXYdAgFIP7g0HnRj9FuT86wv48hdYgcJj4+XSmaxQ?= =?us-ascii?Q?MKbAZqlrJ9sDI6jLcKzgoEWXhng+F1QrXZTAZMcRYaOV4BMEmQGob/D+p9SY?= =?us-ascii?Q?K60Hjrm39nQwKqa//cyzJXGhTaf+pKSdg3nGbpkFcmuHbDubH4uQpda4I+yW?= =?us-ascii?Q?mqrRpY5jj4+zOlxd/wsYcX2HlzOgN1N2Nk+u+6+pUbMI3GfZiSzgr09Q/MDl?= =?us-ascii?Q?9lr67hq/SQbCMhcYdJjLLGrHEsJTioCE6LrDT4jziasHJxrXqHMcv3IjPY+k?= =?us-ascii?Q?vWhNOl0spVEQvDYxjVBh/IcpfCVp1QqGI3fFEC/TGj2wTV1G/+k7px6TAxU6?= =?us-ascii?Q?0KnycMZx3tREAwKsJ9S6Dp3QXaEXk1gHc1xuzDn8jjCQD/FvaPWSHty40K9B?= =?us-ascii?Q?GuecAcbv79yMIZIgfvAA5sCY/BTi27CcUjBjH8wYVK6cnM1sQ5W5qqaTA4nK?= =?us-ascii?Q?uaB/0R9ilPsmaWjTfsRCCENXqqz97YgJ3JH9+wqhdqtG3TdlRYOls9/8V3FT?= =?us-ascii?Q?eXFlzcMUOJmDrawKZWFhyoKiVmrdna4klesZ2ntf+rCUPhI6wFJcSLkpc7kG?= =?us-ascii?Q?MDArLfyjnOWBEsbCIAXPjvoTIyq4aQhQl5ekfxV1mpChlWrSfGWFatr/B9lD?= =?us-ascii?Q?1vxTzv5xOzdmtSRZBm1FDYvPuDsmzTxbgkmjTUruogdgqqi5J2E7JqfgejqX?= =?us-ascii?Q?WNXZgbdYkGvRf5JvngILoP8mrMIOO/Li//jQGvQU4YhhJK7SskMSjcd2TeoB?= =?us-ascii?Q?8hhFMeWZSJ7hISleMopSBi61yYI4tWaJeWc3VhY+6gSPZyl/7K1NCccnAyUz?= =?us-ascii?Q?b6nAoET7+FOxPLvgWu/4PdWgyMO9Sk8A168wUHmvHVuBkr6L2cWyJvsOy+Vw?= =?us-ascii?Q?yxtu7EIRqsUgS1PxvxiGyuobMfEdPdXvYQKxFvDTYotCBfDVzCBbe+eWpfSY?= =?us-ascii?Q?q21/2w6gPjADQVv2qfxhm8sv9hQIU/bBl2ctGtgnXmRQ00AqDGkMtn/xXVHv?= =?us-ascii?Q?KiFx0TSuOa6AK2SSLEIs05YKZppI35zKxfnS1nJDemyflPG/mpJqv7ubsPGW?= =?us-ascii?Q?M9nvS5vIQBCP1rM9qdjsTsiXVZ3qhdtsg2gfcDRZhwIjRG3GfAbdERCydPue?= =?us-ascii?Q?Lj8G+hcYTkt0n7BQ63M/7tB2ECCnSvRgzqrwWhAZDtEl5v6puwKnRdE75gZt?= =?us-ascii?Q?DhhqfGZIznDA0crvi8wFVk5K+BuI+f9unKhvNiyrkfR9qom8xnw9+F1S9y5v?= =?us-ascii?Q?vV5KJGaVd2wED18doI4=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(36860700013)(82310400026)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2025 14:07:53.7473 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91c1ba48-5eac-4215-d9bf-08de26abddfb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000206.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8079 Content-Type: text/plain; charset="utf-8" Add support for Tegra264 SoC which supports 17 generic I2C controllers, two of which are in the AON (always-on) partition of the SoC. In addition to the features supported by Tegra194 it also supports a SW mutex register to allow sharing the same I2C instance across multiple firmware. Signed-off-by: Akhil R Signed-off-by: Kartik Rajput Reviewed-by: Jon Hunter Acked-by: Thierry Reding --- v4 -> v10: * Set has_mst_reset =3D true for Tegra264. v1 -> v4: * Update commit message to mention the SW mutex feature available on Tegra264. --- drivers/i2c/busses/i2c-tegra.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index 51af857d44d6..0638ccdef313 100644 --- a/drivers/i2c/busses/i2c-tegra.c +++ b/drivers/i2c/busses/i2c-tegra.c @@ -1853,7 +1853,40 @@ static const struct tegra_i2c_hw_feature tegra256_i2= c_hw =3D { .has_mutex =3D true, }; =20 +static const struct tegra_i2c_hw_feature tegra264_i2c_hw =3D { + .has_continue_xfer_support =3D true, + .has_per_pkt_xfer_complete_irq =3D true, + .clk_divisor_hs_mode =3D 1, + .clk_divisor_std_mode =3D 0x1d, + .clk_divisor_fast_mode =3D 0x15, + .clk_divisor_fast_plus_mode =3D 0x8, + .has_config_load_reg =3D true, + .has_multi_master_mode =3D true, + .has_slcg_override_reg =3D true, + .has_mst_fifo =3D true, + .has_mst_reset =3D true, + .quirks =3D &tegra194_i2c_quirks, + .supports_bus_clear =3D true, + .has_apb_dma =3D false, + .tlow_std_mode =3D 0x8, + .thigh_std_mode =3D 0x7, + .tlow_fast_mode =3D 0x2, + .thigh_fast_mode =3D 0x2, + .tlow_fastplus_mode =3D 0x2, + .thigh_fastplus_mode =3D 0x2, + .tlow_hs_mode =3D 0x4, + .thigh_hs_mode =3D 0x2, + .setup_hold_time_std_mode =3D 0x08080808, + .setup_hold_time_fast_mode =3D 0x02020202, + .setup_hold_time_fastplus_mode =3D 0x02020202, + .setup_hold_time_hs_mode =3D 0x090909, + .has_interface_timing_reg =3D true, + .enable_hs_mode_support =3D true, + .has_mutex =3D true, +}; + static const struct of_device_id tegra_i2c_of_match[] =3D { + { .compatible =3D "nvidia,tegra264-i2c", .data =3D &tegra264_i2c_hw, }, { .compatible =3D "nvidia,tegra256-i2c", .data =3D &tegra256_i2c_hw, }, { .compatible =3D "nvidia,tegra194-i2c", .data =3D &tegra194_i2c_hw, }, { .compatible =3D "nvidia,tegra186-i2c", .data =3D &tegra186_i2c_hw, }, --=20 2.50.1