From nobody Tue Dec 2 02:43:44 2025 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7418A1E1E12 for ; Tue, 18 Nov 2025 12:16:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763468165; cv=none; b=erGM6L91U4Z774xgBIWWjZ7TJq/D2ZhncYR93ipqyHXeNg+Mui+JVi0oWRvicvrwH1HJQorzY8wM2rrvqNUr6hH/rK+X8J5JdkoH4qLuiBBwRl5eCLWnjwI9JJYV1TFmoYPd0fXDKJXzfhsY/fn+ek29rt9QZLk+fgrKfKUa9kg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763468165; c=relaxed/simple; bh=JZ57bn/gCq3D5ZZS97JJneV8GXQ9eB/shkz/PtDV0fc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oUZwfKtO162N+d7X9SqRiuOQWr1Vr5enaOW6VE4cZc6kkJn5tUmfh6sORurtUHjwJIdqfk8XeDc7PmysW1XTHNwglXeXRwfKxmJyDo+qdfND6wTArkPW4/fWHWjKTVGSTn0zphLjfinJcfm+ywtK8AAtCYU5A/3VPFDjZuNrAQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-03 (Coremail) with SMTP id rQCowAAHl9l8YxxpDkgwAQ--.24922S2; Tue, 18 Nov 2025 20:15:56 +0800 (CST) From: Haotian Zhang To: lee@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haotian Zhang Subject: [PATCH] mfd: mt6397-irq: Fix missing irq_domain_remove() in error path Date: Tue, 18 Nov 2025 20:15:00 +0800 Message-ID: <20251118121500.605-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAHl9l8YxxpDkgwAQ--.24922S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GFW7Cry3tF1xtFy5Gw1fCrg_yoWDJrg_ur Wvgwn3uw10gFn3Cw4xtr43ZrWI9r1DWrs2kF4Iy3W3t3W7Krn7Zrn0vr9rJry7u3y7CF9x JFs8Xr4aywn7CjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbs8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_ Jw1lc2xSY4AK67AK6ryUMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI 8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AK xVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI 8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280 aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43 ZEXa7VUjBHq3UUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwkKA2kcPpZrnAAAst Content-Type: text/plain; charset="utf-8" If devm_request_threaded_irq() fails after irq_domain_create_linear() succeeds in mt6397_irq_init(), the function returns without removing the created IRQ domain, leading to a resource leak. Call irq_domain_remove() in the error path after a successful irq_domain_create_linear() to properly release the IRQ domain. Fixes: a4872e80ce7d ("mfd: mt6397: Extract IRQ related code from core drive= r") Signed-off-by: Haotian Zhang --- drivers/mfd/mt6397-irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mt6397-irq.c b/drivers/mfd/mt6397-irq.c index 0e463026c5a9..5d2e5459f744 100644 --- a/drivers/mfd/mt6397-irq.c +++ b/drivers/mfd/mt6397-irq.c @@ -229,6 +229,7 @@ int mt6397_irq_init(struct mt6397_chip *chip) if (ret) { dev_err(chip->dev, "failed to register irq=3D%d; err: %d\n", chip->irq, ret); + irq_domain_remove(chip->irq_domain); return ret; } =20 --=20 2.50.1.windows.1