From nobody Tue Dec 2 02:42:38 2025 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F04C350A1A for ; Tue, 18 Nov 2025 12:15:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763468108; cv=none; b=tKJZ7E72t+U5r0AxZnolBkP7QqzD/beTEhEseqnTBCUMEnkUuDTx5POmP8JFKMs3SLXvXd+6GhgA9YzBtK3+FbI64CD/FUOa+iI8eQ4ig51vms5c8RGp4vSiVE9GfS79oQLJAApgqvoEHcZId//xKEf12weGYRnSxzexo4b2FkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763468108; c=relaxed/simple; bh=IbLbeylsRsWW+W/N9Ju6uTWMrKRRP3SLY4Ik3UTaFjg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=beRS4mVvm/Mw9Lj7diqYywI+WLyhNUl6jg+0TotDexGQI8PbVdTFnuc/QbyrIQSbSK3Kh4RrNKUl7sv4DkYHVa2mR7+aXDjSqrPPd41Wgl73GY4DozT+r0aaRinBoybWWOs7jhcPHajqQWhKx/z33wjV5qHlO4ODMy5kZZvTGxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-03 (Coremail) with SMTP id rQCowAAXpdc1YxxplUAwAQ--.30158S2; Tue, 18 Nov 2025 20:14:47 +0800 (CST) From: Haotian Zhang To: lee@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Haotian Zhang Subject: [PATCH] mfd: mt6358-irq: Fix missing irq_domain_remove() in error path Date: Tue, 18 Nov 2025 20:14:27 +0800 Message-ID: <20251118121427.583-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAXpdc1YxxplUAwAQ--.30158S2 X-Coremail-Antispam: 1UD129KBjvdXoW7GFWxtry3KrW7Cr1rXr1rtFb_yoWftwb_CF yvqrnxuw1UJF1akw1Iqr43urWq9r4kWFnFkFs2y3W3GFy7Kwn2vrn0vr97Kr47C3y7CFsx WFZ0qrW3Ar1fCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_ Jw1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxV WUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI 7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r 1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUf8nOUUUUU= X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCREKA2kcPhU0EgABso Content-Type: text/plain; charset="utf-8" If devm_request_threaded_irq() fails after irq_domain_add_linear() succeeds in mt6358_irq_init(), the function returns without removing the created IRQ domain, leading to a resource leak. Call irq_domain_remove() in the error path after a successful irq_domain_add_linear() to properly release the IRQ domain. Fixes: 2b91c28f2abd ("mfd: Add support for the MediaTek MT6358 PMIC") Signed-off-by: Haotian Zhang --- drivers/mfd/mt6358-irq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c index f467b00d2366..74cf20843044 100644 --- a/drivers/mfd/mt6358-irq.c +++ b/drivers/mfd/mt6358-irq.c @@ -285,6 +285,7 @@ int mt6358_irq_init(struct mt6397_chip *chip) if (ret) { dev_err(chip->dev, "Failed to register IRQ=3D%d, ret=3D%d\n", chip->irq, ret); + irq_domain_remove(chip->irq_domain); return ret; } =20 --=20 2.50.1.windows.1