From nobody Tue Dec 2 02:51:16 2025 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19E9334B19C for ; Tue, 18 Nov 2025 11:02:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763463726; cv=none; b=ts484F8ixDcnfaP1eN2ssPyknX6zwCDTIfjx0xi7QLCUTG5o1SKbxoYbbQguouvmftOV4heG3wULW5YOOncdQJ59QeN7wks0v8edduy/2LKUXLMN8rFnX2YLcM4K0YNSRMza4M8dsj7PvRgV5bB4EyYHFbCCVR6c8AzRClhSqp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763463726; c=relaxed/simple; bh=ZLqtKS+TT2YY7t3tdStGNlse2YmCDrfsUjFBUTVx5W0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iNtPb8s5e8oY9ywunQInFWMRW0o7MUvHAE0+Ja/GM5qEauNaF+ROdW9+DBASXtCd/ayVfM8kj9AkCG/8tbyS4hYGVtVoLheR9S2yjeCs5VS86Z2zVFrJRyUH7yliP3HwiXwCf09jRjM8AP0rSxbsbiYoUHmFO/QFXoiITetDY8k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XbVf/uWo; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XbVf/uWo" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-29806bd47b5so34293165ad.3 for ; Tue, 18 Nov 2025 03:02:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763463723; x=1764068523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=na4DhkN/5BRqSU3K/p/l3xB54l4eKEIWl6YEImlS290=; b=XbVf/uWoxvfzx8vYnf/Qqxsv0Tun4FduszrWow2JyyuXD0PHR7r4SjMm1KJP24MqTc RUZZuqbpDmle9HeITIO1C+H4DSRzj9OWtuTkgGkkwmYbB0dajOtQzYc1GkVj1sernwxL gEcG3oPXCTLjGW7nX1Rv/tFGPcs38b/McMfJhmEPXUR5VONXmfdpush07ALgOGnq78L1 8h9JlE2iBAgQgWfoF2jnu7U8QkQODOFd6SP68Non6drGNmej7+I/xzt9FqjHkmpWsSo7 lZaa1Nr70EgOK4B1bz8HgFW6MzY7nzn939hbc5Uy4Dx0IHzHUTgqQI9WmNuKDRKt75EH k33A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763463723; x=1764068523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=na4DhkN/5BRqSU3K/p/l3xB54l4eKEIWl6YEImlS290=; b=k7od7dtv1P4UVJmVKYXiqFYc7J8ZTRw1EECjYot2ZIs2b8I4D67biPFzl5GxpyikVs Kw6uQTdpA9yKrf/Mw+pAEUKWpoOVqL7lQQEa3xEptcq/Sa6wGY8KLuUVFKyVSaQuBPkg ixcWtFpV4Oiy5suPLjkora/DXHWNNmyIE8oRJjJSeJTnF25/ABGLbZt7Utnfn/3+BfN8 Hcbbk5M4BWKG9LwJUEFDcu9NkjsNLnFgwrOjbj5mLaK7xy8ElLAj/gb0hoHi2phfKV8h LPOTuP+E46dXyB8Mo78NVQ3ZjtwM6AfYrqd9AysxELcBq4xSmypUIh38C+l1I4jRq39I dJkA== X-Forwarded-Encrypted: i=1; AJvYcCWm9bWPhaNfXHA3mYQPK6EV/YE3GVHjwIikHjnqTWjHwCU+WKJzhkbxMiHAl4WgZqGo2J1aVGOh+frLEn8=@vger.kernel.org X-Gm-Message-State: AOJu0YzANJOkeQvz5zoyxJzPixw7fcjxyHrWnuINzTq5yHGUdOaxMvF+ UXq5HwdjB+qu0//+b8ey2DIERtA+TvhBlYoxW+JrDCBKLxdnJ4UeGhqX X-Gm-Gg: ASbGncsfbfo9alBjjqz+3nSCYk1lMK0V3WxvoL1mYLL4d5PfYoArR3Ni1VGfWSM0BZG u1ZvluprT4AAhLdlWZwQDKHBBOoOdc6I146+1qtMw8n9MAre96n/tFvvk820Ta74YaZeVN2yyR/ bbiHGQWaq21uImPf5F5lm6CvRywHSooSZzB8geKsweHsaEDWiJ544x7Yhuf0F8l1abNRxyANAO3 nKz8kCf5rg0iqMqprdss+vdS4H0uA6DOxiQJukK604ZR62hATtcJqigelePJB4P7E89RIOoVdLI s9ao6lK9zKtL2WJX3DJnwkXBX8ES+1Tnm7r+g29LkTB/t95jQPzg9sJ4Vwy2F07c4sgkfUiUman 5HeDqaG0+Iw3X/RAtI7uVdiPrPUbAFpJa3sbkP8RvGz+1SOSrsTO5ZeqCOV9mhMh0TTULySU0sv UmignHt1ZGgFVpkrvvtnOjOSAD X-Google-Smtp-Source: AGHT+IE6YrPAVjfDpiLLsFnYKJeDdAmdTRc9703k5Np/K4dcdP4WFnn2nsey6vdWdlf/71DWDVaJWQ== X-Received: by 2002:a17:903:178e:b0:298:1013:b8d8 with SMTP id d9443c01a7336-2986a76a111mr166893485ad.57.1763463723279; Tue, 18 Nov 2025 03:02:03 -0800 (PST) Received: from rahul-mintos.ban-spse ([165.204.156.251]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c241f89sm168012035ad.28.2025.11.18.03.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 03:02:03 -0800 (PST) From: Rahul Kumar To: liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rk0006818@gmail.com Subject: [PATCH v2 3/3] drm/komeda: Convert logging in d71_dev.c to drm_* with drm_device parameter Date: Tue, 18 Nov 2025 16:29:34 +0530 Message-ID: <20251118105934.748955-4-rk0006818@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251118105934.748955-1-rk0006818@gmail.com> References: <20251118105934.748955-1-rk0006818@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace DRM_DEBUG() and DRM_ERROR() calls in drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c with the drm_dbg() and drm_err() helpers in functions where a drm_device parameter is available. The drm_*() logging macros require a struct drm_device * parameter, which allows the DRM core to prefix log messages with the device instance. This improves debugging clarity when multiple Komeda or other DRM devices are present. Logging in early hardware probing functions such as d71_identify() is intentionally left unchanged because they do not have access to a drm_device pointer at that stage of initialization. This conversion follows the DRM TODO entry: "Convert logging to drm_* functions with drm_device parameter". Signed-off-by: Rahul Kumar --- Changes since v1: - Fixed incorrect use of dev_get_drvdata(): it returns struct komeda_drv *, not struct komeda_kms_dev *, as pointed out by Liviu Dudau. - Updated DRM device pointer retrieval to use drv->kms. - Combined both changes into a 0/3 series. Link to v1: https://lore.kernel.org/all/aRdT1qscQqO7-U6h@e110455-lin.cambridge.arm.com/ --- .../gpu/drm/arm/display/komeda/d71/d71_dev.c | 24 +++++++++++++------ 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu= /drm/arm/display/komeda/d71/d71_dev.c index 80973975bfdb..39c51bbe2bb9 100644 --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c @@ -9,6 +9,7 @@ #include #include "d71_dev.h" #include "malidp_io.h" +#include "komeda_drv.h" =20 static u64 get_lpu_event(struct d71_pipeline *d71_pipeline) { @@ -348,6 +349,9 @@ static void d71_cleanup(struct komeda_dev *mdev) =20 static int d71_enum_resources(struct komeda_dev *mdev) { + struct komeda_drv *drv =3D dev_get_drvdata(mdev->dev); + struct komeda_kms_dev *kms =3D drv->kms; + struct drm_device *drm =3D &kms->base; struct d71_dev *d71; struct komeda_pipeline *pipe; struct block_header blk; @@ -366,7 +370,7 @@ static int d71_enum_resources(struct komeda_dev *mdev) =20 err =3D d71_reset(d71); if (err) { - DRM_ERROR("Fail to reset d71 device.\n"); + drm_err(drm, "Fail to reset d71 device.\n"); goto err_cleanup; } =20 @@ -376,8 +380,8 @@ static int d71_enum_resources(struct komeda_dev *mdev) d71->num_pipelines =3D (value >> 8) & 0x7; =20 if (d71->num_pipelines > D71_MAX_PIPELINE) { - DRM_ERROR("d71 supports %d pipelines, but got: %d.\n", - D71_MAX_PIPELINE, d71->num_pipelines); + drm_err(drm, "d71 supports %d pipelines, but got: %d.\n", + D71_MAX_PIPELINE, d71->num_pipelines); err =3D -EINVAL; goto err_cleanup; } @@ -455,8 +459,8 @@ static int d71_enum_resources(struct komeda_dev *mdev) offset +=3D D71_BLOCK_SIZE; } =20 - DRM_DEBUG("total %d (out of %d) blocks are found.\n", - i, d71->num_blocks); + drm_dbg(drm, "total %d (out of %d) blocks are found.\n", + i, d71->num_blocks); =20 return 0; =20 @@ -555,6 +559,9 @@ static void d71_init_fmt_tbl(struct komeda_dev *mdev) =20 static int d71_connect_iommu(struct komeda_dev *mdev) { + struct komeda_drv *drv =3D dev_get_drvdata(mdev->dev); + struct komeda_kms_dev *kms =3D drv->kms; + struct drm_device *drm =3D &kms->base; struct d71_dev *d71 =3D mdev->chip_data; u32 __iomem *reg =3D d71->gcu_addr; u32 check_bits =3D (d71->num_pipelines =3D=3D 2) ? @@ -569,7 +576,7 @@ static int d71_connect_iommu(struct komeda_dev *mdev) ret =3D dp_wait_cond(has_bits(check_bits, malidp_read32(reg, BLK_STATUS)), 100, 1000, 1000); if (ret < 0) { - DRM_ERROR("timed out connecting to TCU!\n"); + drm_err(drm, "timed out connecting to TCU!\n"); malidp_write32_mask(reg, BLK_CONTROL, 0x7, INACTIVE_MODE); return ret; } @@ -582,6 +589,9 @@ static int d71_connect_iommu(struct komeda_dev *mdev) =20 static int d71_disconnect_iommu(struct komeda_dev *mdev) { + struct komeda_drv *drv =3D dev_get_drvdata(mdev->dev); + struct komeda_kms_dev *kms =3D drv->kms; + struct drm_device *drm =3D &kms->base; struct d71_dev *d71 =3D mdev->chip_data; u32 __iomem *reg =3D d71->gcu_addr; u32 check_bits =3D (d71->num_pipelines =3D=3D 2) ? @@ -593,7 +603,7 @@ static int d71_disconnect_iommu(struct komeda_dev *mdev) ret =3D dp_wait_cond(((malidp_read32(reg, BLK_STATUS) & check_bits) =3D= =3D 0), 100, 1000, 1000); if (ret < 0) { - DRM_ERROR("timed out disconnecting from TCU!\n"); + drm_err(drm, "timed out disconnecting from TCU!\n"); malidp_write32_mask(reg, BLK_CONTROL, 0x7, INACTIVE_MODE); } =20 --=20 2.43.0