From nobody Tue Dec 2 02:43:39 2025 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D58630F522 for ; Tue, 18 Nov 2025 09:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763457190; cv=none; b=QL0554o+NSCnoQl9bUNBCagJB/M6oE3t/b4jvlapDmPaE54lsm2GUSQXX/lcg1UEMUNTX0pEP35v+TkTjGA1F6dAgLaacj112glS0slnFtek8ve8dkV8xrjjgjURP+EQ/JFI9f1NGkZQykjhLSAYKI6wB0DdESmDW2vnMGgxA2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763457190; c=relaxed/simple; bh=SdqlTpbJJyHy0CnqZckFC0G6Xe2xBCQUl7hLQuseWzw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=vFKFwqRVMpNOZZ6GCwVrea9HSwOicHuzft2N7QfCxWIIix04KorNmL4jyzeRkiWACpu1hW/gnxlw7c1PMcm8D51/fhSrMVs1MbWu8EiVRV4VA5XB2YqkOS7G/i+Q7j12QJSai/Hxkl1kfyPNotFsl6NwZoPqS7cG2Hj4w3xVR5c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X9Q+GWs2; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X9Q+GWs2" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7b8e49d8b35so5967983b3a.3 for ; Tue, 18 Nov 2025 01:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763457183; x=1764061983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JFkOpeDn2jRMncnbRni6Etd02PIBihHP7ylWcxC9j6Q=; b=X9Q+GWs2L009mwZPy6IOjfaRQycjcX9fjfXcwbrJ4DbWPjN15DiP3EY9uktdfC2IDt PIr4Dng+xI6hK6gnhFyAUS0m4cg07q7Plmxjm8ku9/7nrEolsQN8KOGdKJIlNEKIjMzq T7Y1sxnhuB0b+kaM4q/I6VV6CieuK32pKiGKl+5R8lc4ERDG8iAGOqXBlhSFv7vGKBkC aWJBu1LO0Inv2SYz9tpWbLvyvq3I93/I46GIai2jNKRvuHbUpjPLWSAU+DkNtZ689B+h K7TZ9RUsTdkuFRjhAwiO36SekdhCEUXt98eEkY/u+dq3c4/3LLFFas4/otX6mtQYUf7a w7YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763457183; x=1764061983; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JFkOpeDn2jRMncnbRni6Etd02PIBihHP7ylWcxC9j6Q=; b=hgeqGkRwu9uOGP3aDHEIBqhrcdANPtlxSACV84VjlO/TjtJ5e5lJpMOw/BtkVQ+oyF oMQ0yaVkePPWinCnmoNuT2k0RJghnVUAiig+SyYXwtsBrRKcseNnrf/6Y9HBuhNlIH5p zJH8XNAiUiUie5Ri3vVhkaQ6Y2fsKqzjPWmCJuz6tOS8zlE4P6ugXNPufNcGxEAuIOUN JHf8JVjc2YDwPGwNWFLOu5/fP2CBf+rEE4CUdldt92k4dVuEv2Sgc+NHwA3L6r0jHTJT x0gCqJ9qtMSEPfAIwq39gY6VvZSSi6is3fx4kuaj6oO+5MStJtDgtpHtn00oqrfBIeoM gvsA== X-Forwarded-Encrypted: i=1; AJvYcCX2fhDOTFzENwFuPjsPuKgVQJoPS080OyccBJ3bWqUz5ewmagyAe/j0XlsUgD1G4wZ7UfSIuzZMQVaTEzI=@vger.kernel.org X-Gm-Message-State: AOJu0YwfpfcI3jO93WPyED0A4bCbKCqiookp0fZ2SiGZhSEPfAJSLRY5 vcViJUHD+sWrNJTJb77vPXBrJgO/PElacx+Rf3e6jozOLIbIGzPfNjPH X-Gm-Gg: ASbGncu6mrHlif3J8c8n1i/H4ThfrpNNBzWMFaYVQe5hQtw0z7fVibSWimEf18cZvL8 YkFk10i5tW3tDSZnDggARXRMg/wvBfUWkhqJczIPDgd2e9DXj31fc/bJYbNHryH+fFfGUQPce6P UOIbuFBBAI/3CY12Y5avjvP3T/T10VQ/GKUdu6g4t0mauXelHF8Jup49AVkzUz1BTFsbVc77pCk zr9vC03bP8V/JI7GglFk3/KlVOmbLReL0FY+mTMXk/rwG1FZ6NE+hX0IS4BQ0w5j1G2go2h7u2R TX5qTI+Odc+yEMnFTKsC6+Z5jCjm7t8MtiqYlPifc+BTxnrEeCEoTLcpGm9etO4nW2HVgnqyZxI ocT5TdU49k5umaAVXXoyGMg1IUr5J8OY1X5ftNrQ51dcBFs1/1SgipQvm0Gv3dFRG5NqizR4CKs I3Mzfxfv0= X-Google-Smtp-Source: AGHT+IELD+mUOOmyAzNfNMxNVLo7AvHaGl4tLct5UR4tcQdGQzNqWRjSuqIa9bQ6MpfLRzKhYDaiyA== X-Received: by 2002:a05:6a20:6a03:b0:334:a180:b7ac with SMTP id adf61e73a8af0-35ba1c93579mr19863554637.39.1763457183358; Tue, 18 Nov 2025 01:13:03 -0800 (PST) Received: from d.home.mmyangfl.tk ([45.32.227.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9251ca3e9sm15913459b3a.29.2025.11.18.01.13.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 01:13:02 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: dsa: yt921x: Fix MIB attribute table Date: Tue, 18 Nov 2025 17:12:33 +0800 Message-ID: <20251118091237.2208994-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are holes in the MIB field I didn't notice, leading to wrong statistics after stress tests. Signed-off-by: David Yang --- drivers/net/dsa/yt921x.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 944988e29127..97fc6085f4d0 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -56,13 +56,13 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { =20 MIB_DESC(1, 0x30, NULL), /* RxPktSz1024To1518 */ MIB_DESC(1, 0x34, NULL), /* RxPktSz1519ToMax */ - MIB_DESC(2, 0x38, NULL), /* RxGoodBytes */ - /* 0x3c */ + /* 0x38 unused */ + MIB_DESC(2, 0x3c, NULL), /* RxGoodBytes */ =20 - MIB_DESC(2, 0x40, "RxBadBytes"), - /* 0x44 */ - MIB_DESC(2, 0x48, NULL), /* RxOverSzErr */ - /* 0x4c */ + /* 0x40 */ + MIB_DESC(2, 0x44, "RxBadBytes"), + /* 0x48 */ + MIB_DESC(1, 0x4c, NULL), /* RxOverSzErr */ =20 MIB_DESC(1, 0x50, NULL), /* RxDropped */ MIB_DESC(1, 0x54, NULL), /* TxBroadcast */ @@ -79,10 +79,10 @@ static const struct yt921x_mib_desc yt921x_mib_descs[] = =3D { MIB_DESC(1, 0x78, NULL), /* TxPktSz1024To1518 */ MIB_DESC(1, 0x7c, NULL), /* TxPktSz1519ToMax */ =20 - MIB_DESC(2, 0x80, NULL), /* TxGoodBytes */ - /* 0x84 */ - MIB_DESC(2, 0x88, NULL), /* TxCollision */ - /* 0x8c */ + /* 0x80 unused */ + MIB_DESC(2, 0x84, NULL), /* TxGoodBytes */ + /* 0x88 */ + MIB_DESC(1, 0x8c, NULL), /* TxCollision */ =20 MIB_DESC(1, 0x90, NULL), /* TxExcessiveCollistion */ MIB_DESC(1, 0x94, NULL), /* TxMultipleCollision */ @@ -705,7 +705,7 @@ static int yt921x_read_mib(struct yt921x_priv *priv, in= t port) res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; - val =3D ((u64)val0 << 32) | val1; + val =3D ((u64)val1 << 32) | val0; } =20 WRITE_ONCE(*valp, val); --=20 2.51.0