From nobody Tue Dec 2 02:57:43 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B0B301499 for ; Tue, 18 Nov 2025 07:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763451023; cv=none; b=mxWxvrWnBn5rfWud0HNEe8VjXrQ7qG5C9Y73Q9ipV+dR6T0yCAsk9CZgiwqsZ8Ef7XfgFrKII1DwaqcViwfp5nEsFAzuybtq7skZR15+oz3QFFjDYr75/VYsKA7sTQzTGGSiK9hUBE+grUEgEkfoo5B6ntnSEmi3mYh8G0DTtN4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763451023; c=relaxed/simple; bh=nwoSFbvg2ufteXXIxITw7M1VYLp8Ig+96/yh4XFs01c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ulDFPsGJm3JktFNDWvikcmLNKR/8SPkyQ03X65qHDwhmGTiz9oOhbS4XUtFRxKN3xcSDfgKNczwR9j/ORW2jO0XQh6OaGwDb8pKKhjHrQ9veSg9Q/LNePW8SJKYuWxwvrR3gpTQ3GrspyVc6ASL3nsbW/N0Irx779+9dgtxjxLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nemYsUte; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nemYsUte" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-29555415c5fso59310515ad.1 for ; Mon, 17 Nov 2025 23:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763451021; x=1764055821; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oLeikw5PJ/qN7DZHExYRK+yLqtuCtzgt/wbA4Xek4OA=; b=nemYsUteqpz0D21I+F9lJ/fGGDu4C2K6QdJi89Ao4tfILBNwg7kcKHCr4EZi6TKggD jjqJY8If/0fMJsy5gNay7RL53HIK5Ejn7bDxko5EzKZ+i7mSw+EMR+GpKxBu9xT8A+cr IVHb/s2JhdFfbYNS2M3kl2GP4OOTiZpJu/5Qk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763451021; x=1764055821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oLeikw5PJ/qN7DZHExYRK+yLqtuCtzgt/wbA4Xek4OA=; b=JJbpZj+5Ui2HWN//24YzoOjrqxqCNddVjRC/KMXFPYRG4wZskKLVPXgl/K6cxmIJFE hC8Nsig8M1JEL3e/kDQ2IW8EAWen4wSNyqEJYmzJDvXbHMNfLvbASsQcDRW/5y4hXRaT kaumpzJ1RWrV0QwwxedlpAnIje5oLm+kuNk8LNBcc6PJ11+prqeiOJtiLbqrscCPvNGa +RGMptY0p9PLzz98tTL2ZkiEkU8RS/+qjnLbU/zrMXOTSptEpmDxJGBBGoREtfprQCgO kF/D72B2zOdM9iACwmXzYC2JCdpW8iMLgOmfeLZONi2To/fZTVN5VqKMNFhqCWp5RkP6 Tlcg== X-Forwarded-Encrypted: i=1; AJvYcCWae4EMoQqWCFfmUuO6tJeO0/BzFe+Ez5vZKPYAfuozSVMb2v21QWg4B9vXG5VGBAN/LvuHRJHrD7jETEk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw48duoV5FhNmWQGDHsn3wCUWAeoAdkLW49Ll/kbe7OO4yOh08j KKs2N2CUiZrftGpUNtkFew8Zok9MF7rdMFHlR3XLWz9MNcIK064moAQNeR1GtQb+EA== X-Gm-Gg: ASbGncsJCmJNaqy2dpTdmepjTB1Qije3T1Pif1rHEQF+U4gOI4Lrbcm6ILMMqccfTU4 WEcH8L9ir1z2edeTesRzPdT5um5rjyh/zkedgEYPyZhdBz6+Bw0dU7hNxqmNy2MmIkdZkYgt/1G bpCIRasImFz6NBAHPGiKzCEEF8hbax1xM90qGdooHYXFnbxRDyNC9X50GfQ3+Cc02coHdYKaQOH 3t5aU3lK4VsZHP3gc1I2Rl5BzD/sEHxqjBZQOqWr06XkdSPlG/KO6LxhLHovprAVNDlBWOk+D6C dwmemCY0/Ext+dY7He6OTMvJypkRVp2LbJxsXpywKOh7whPJWwF6deySbcs/T+vh9/r1WuFUszO MqGh6/8vqDdFpmRwP8AfDsmsDBda4dPNxyftuBmVhktt8u8RTGsmAmfnpGGPVkNMISmOydKrCre m1j6XXYcQL0Mj7h1XRQmXda7hRs/RqfRUOIhqcNw== X-Google-Smtp-Source: AGHT+IFPr244P47pEFismSmInv5GHAI8P7iTWZDuNYFcomfeTvjtA6iKN1AEqAASeGrUa+CcERTWXw== X-Received: by 2002:a17:903:41d1:b0:295:7f1d:b02d with SMTP id d9443c01a7336-2986a6da8a4mr198877365ad.22.1763451021561; Mon, 17 Nov 2025 23:30:21 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:beba:22fc:d89b:ce14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2568ccsm163926215ad.50.2025.11.17.23.30.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 23:30:21 -0800 (PST) From: Sergey Senozhatsky To: Andrew Morton Cc: Minchan Kim , Yuwen Chen , Richard Chang , Brian Geffon , Fengyu Lian , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, Sergey Senozhatsky Subject: [PATCHv4 3/6] zram: take write lock in wb limit store handlers Date: Tue, 18 Nov 2025 16:29:57 +0900 Message-ID: <20251118073000.1928107-4-senozhatsky@chromium.org> X-Mailer: git-send-email 2.52.0.rc1.455.g30608eb744-goog In-Reply-To: <20251118073000.1928107-1-senozhatsky@chromium.org> References: <20251118073000.1928107-1-senozhatsky@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Write device attrs handlers should take write zram init_lock. While at it, fixup coding styles. Signed-off-by: Sergey Senozhatsky --- drivers/block/zram/zram_drv.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index be39fe04b9b1..073a12132cb3 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -519,7 +519,8 @@ struct zram_wb_req { }; =20 static ssize_t writeback_limit_enable_store(struct device *dev, - struct device_attribute *attr, const char *buf, size_t len) + struct device_attribute *attr, + const char *buf, size_t len) { struct zram *zram =3D dev_to_zram(dev); u64 val; @@ -528,18 +529,19 @@ static ssize_t writeback_limit_enable_store(struct de= vice *dev, if (kstrtoull(buf, 10, &val)) return ret; =20 - down_read(&zram->init_lock); + down_write(&zram->init_lock); spin_lock(&zram->wb_limit_lock); zram->wb_limit_enable =3D val; spin_unlock(&zram->wb_limit_lock); - up_read(&zram->init_lock); + up_write(&zram->init_lock); ret =3D len; =20 return ret; } =20 static ssize_t writeback_limit_enable_show(struct device *dev, - struct device_attribute *attr, char *buf) + struct device_attribute *attr, + char *buf) { bool val; struct zram *zram =3D dev_to_zram(dev); @@ -554,7 +556,8 @@ static ssize_t writeback_limit_enable_show(struct devic= e *dev, } =20 static ssize_t writeback_limit_store(struct device *dev, - struct device_attribute *attr, const char *buf, size_t len) + struct device_attribute *attr, + const char *buf, size_t len) { struct zram *zram =3D dev_to_zram(dev); u64 val; @@ -563,11 +566,11 @@ static ssize_t writeback_limit_store(struct device *d= ev, if (kstrtoull(buf, 10, &val)) return ret; =20 - down_read(&zram->init_lock); + down_write(&zram->init_lock); spin_lock(&zram->wb_limit_lock); zram->bd_wb_limit =3D val; spin_unlock(&zram->wb_limit_lock); - up_read(&zram->init_lock); + up_write(&zram->init_lock); ret =3D len; =20 return ret; --=20 2.52.0.rc1.455.g30608eb744-goog