From nobody Tue Dec 2 02:59:09 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75D9B308F3B for ; Mon, 17 Nov 2025 23:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763423548; cv=none; b=hiB9qxsFdq22bIpD1rbVGMwisXIBqr4JPb6Sm/RSJLC7TxBl8iuNMc1XOWEIUmez6FURrcEqwZhuMguYhU5l/cOo/jqq9/wV+hwyvNpLAeuvsM2qgVQtw2goBGURQERcY42mh64wCZwok3QKISFmvzPBLAdhYgcdJ8EMzuo71N8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763423548; c=relaxed/simple; bh=dIOwX9G/bnHkpO+u+K2WCU5k3EZnJIIE/FI3gW8sb58=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZLGnHrgNqeAfb1Ru92YziaN4r4qmrZ0KA0o/TPNHknXNVZofOW6HE4qVECNrkfiaJk3kgYvfjE7YuHkEPVcy+3TJzIdFCYLIcX3IQVzqX4+1/E3cXFW3hwK3NlEKgS26/nja2o8wPJ498BVm6eac1NwOQV4G2ByrzZUCaJNZRx8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=IuePNmMz; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="IuePNmMz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1763423544; bh=dIOwX9G/bnHkpO+u+K2WCU5k3EZnJIIE/FI3gW8sb58=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=IuePNmMzQ3tCwvsz+dDnjvkQF9cS/tX2c3nEN2IRp/vb6zjUDvDTaN/gsSSjTkQ+K Lx9NWNYtxwU1TP+VxHWI9HPgxeFjgdCoJ9xNOBkmL3oZ0l5vcmNQFY83pUyWAxicqC GC+lVBhsXt5M1xK97+iWEd49KM8LVUgpmM4kJmL5az1Cmlo7SZxDK1u4G/Rsx0+/Xi JPNgxU0Lo6dtw/iWH006DjNczyAQhJTy9fAqJrcKWIK4xG3/7v65/RynelegBdEqwI eX/MHvZgOVOjTe43vCTlh7VIJuzoOkMTHk9T/Q18sCmG7jrycQBBwkBRabUJrtn+Eo m0RygKFP/rzGg== Received: from localhost (unknown [82.79.138.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9A44917E13D0; Tue, 18 Nov 2025 00:52:24 +0100 (CET) From: Cristian Ciocaltea Date: Tue, 18 Nov 2025 01:52:01 +0200 Subject: [PATCH v3 3/4] drm/vkms: Support setting custom background color Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-rk3588-bgcolor-v3-3-a2cc909428ea@collabora.com> References: <20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com> In-Reply-To: <20251118-rk3588-bgcolor-v3-0-a2cc909428ea@collabora.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org X-Mailer: b4 0.14.3 Make use of the BACKGROUND_COLOR CRTC property when filling the background during blending. It already defaults to solid black. Since the internal representation of the pixel color in VKMS relies on 16 bits of precision, use the newly introduced DRM_ARGB64_GET{R|G|B}() helpers to access the individual components of the background color property, which is compliant with DRM_FORMAT_ARGB16161616. It's worth noting the alpha component is ignored, hence non-opaque background colors are not supported. Signed-off-by: Cristian Ciocaltea --- drivers/gpu/drm/vkms/vkms_composer.c | 10 ++++++++-- drivers/gpu/drm/vkms/vkms_crtc.c | 3 +++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vk= ms_composer.c index c1ab12a44621..19e73817bf78 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -373,8 +373,14 @@ static void blend(struct vkms_writeback_job *wb, { struct vkms_plane_state **plane =3D crtc_state->active_planes; u32 n_active_planes =3D crtc_state->num_active_planes; - - const struct pixel_argb_u16 background_color =3D { .a =3D 0xffff }; + u64 bgcolor =3D crtc_state->base.background_color; + + const struct pixel_argb_u16 background_color =3D { + .a =3D 0xffff, + .r =3D DRM_ARGB64_GETR(bgcolor), + .g =3D DRM_ARGB64_GETG(bgcolor), + .b =3D DRM_ARGB64_GETB(bgcolor), + }; =20 int crtc_y_limit =3D crtc_state->base.mode.vdisplay; int crtc_x_limit =3D crtc_state->base.mode.hdisplay; diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_c= rtc.c index 9a7db1d51022..2514c367f710 100644 --- a/drivers/gpu/drm/vkms/vkms_crtc.c +++ b/drivers/gpu/drm/vkms/vkms_crtc.c @@ -4,6 +4,7 @@ =20 #include #include +#include #include #include #include @@ -228,6 +229,8 @@ struct vkms_output *vkms_crtc_init(struct drm_device *d= ev, struct drm_plane *pri =20 drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE); =20 + drm_crtc_attach_background_color_property(crtc); + spin_lock_init(&vkms_out->lock); spin_lock_init(&vkms_out->composer_lock); =20 --=20 2.51.2