From nobody Tue Dec 2 02:49:49 2025 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9390B2BFC9B; Tue, 18 Nov 2025 06:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.22.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446108; cv=none; b=a0hu7J3JBHj1cQKAgvgHvVj0ebqcnxhWYyJoVgy6o12+Beam7b7CWcx6zaDVgtuRKxZnqz33NIh5ofL1OMJQ38g0YQT25FNkIYcdb8aN3fUVMNhoBP6YTGEsplPXC1BclLyjh2NkhtPS/1XQdEb86oK+W8aMmLPuYd8bww7nYF4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446108; c=relaxed/simple; bh=gPxYVslgi88YMLvAgERRgcz+mantyYYzqxsNkcykFBw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aksKTV22eA220ImUG+lO37AhWRuAqiUT2huNR73lyLIrea1Wim5vk8Hw37QGim6mLrb1VuZBAPxX2kxqxaM7Jr7AWzPNu5KHndxOgH24nBCxteVyAIlKfGhZvTcLIgmUl1phMM581/0kwMxjxOS0ewuydn/95rnmFE2bv5CK1hU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=hqnglU6h; arc=none smtp.client-ip=54.207.22.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="hqnglU6h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1763446097; bh=m50PmW5dDDYChaztc3fkVN38HyaUp3na8TY3fBqU6h8=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=hqnglU6hCzkLvTnn5PCzB3pNf++vY2QdMDmeBJcBkjDSyHsgyGDnC0w/0aLO9qHBh 1dC4QaU4buERxerV1ULBETHhGTWWZhj8/LDMC/d+w6uZaOZR5fUFhYBiQLZGfP8UTv lOSEn4Nz25ueIOVqFLdRmh/q0SCWksOeKRkoJU7s= X-QQ-mid: zesmtpsz6t1763446093td642820b X-QQ-Originating-IP: k9j4w9DNWP09numopPS+U4ivHgK45PYkGx1xhok8DXM= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Nov 2025 14:08:10 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 8174621585258903689 EX-QQ-RecipientCnt: 13 From: Troy Mitchell Date: Tue, 18 Nov 2025 14:08:05 +0800 Subject: [PATCH v3 1/4] i2c: spacemit: configure ILCR for accurate SCL frequency Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-p1-kconfig-fix-v3-1-8839c5ac5db3@linux.spacemit.com> References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> In-Reply-To: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> To: Lee Jones , Yixun Lan , Alex Elder , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Troy Mitchell X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763446086; l=10890; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=gPxYVslgi88YMLvAgERRgcz+mantyYYzqxsNkcykFBw=; b=LTn6Nbq3SZ9QMLDywXOLC9OAU17X9ZJMLKA8i+/Z+yr6ykNBvAhYC+2/Ks5Ojb5gmMrHTl1Jz fDKqVX28k8+Cg95wpaApDFvfQ9ssDE/y2WUnSZDh5Unbg4luy4OxCCk X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: NafyJWIkf4MPiLqk+exutbgY8l+lOv7O9tHFvOHyawavxxQJgFiFHd1h S0IzXCFARteNxpi7A0Ny8TVTFEjby556scSFwdDP0esVeIZw1ZlJqfoiGYWMOhvVbluxfS2 TDzfD3nohRxsDvzLWDpAuHGEdgUDYHYRiraX1/MnN+UdY+E97CdlIIhs8jjQ9jUV11oil7J TiLXuCKndRkFTfn7jHZXctRviz7DI1ZxHWd6edUtI7e62SHVbB5iYhd6sKcLA9EkIfdBeep pXGyG7vSjDv6v0+FazjWpiAyLeyAFQrm72Doo1LFqWh5+HjDN1+eeT25WdqDcSd26279GxX HqtjbDpH9//LhQkMEahgRhQj+DdDloUgWlACTjDYT5jSdF+8wvRfx0OWEiROAgtu/LgwITV 6YnPMU/li5LCZDRNI4KkfVvnnJ8L8ndcLbS74cA9iYXvE38Dtvus1TENmPcSoF7dSXV2Qdc JEfMede/6lHgZ3yeD8anqQICb4+Rfd74U2PAoCVcdF3XlHBfppWVsy3+G+4/cWMp0eSQSAj 7HBTWfiPS3eyR/omEyLdN34gBNa/ITuXz56mR3ZMor/1ZaJvSgX7WSz+OYymxGGLDZhE6tR 42Z3Veab9FgPuPEDzUXvvNJZEI1KkG0BM4ktmtGUJHUfi+jgsCMvbowXDicJVZkni/8zGh6 SGPAIYIWFXBwUlYo9qne+JVwt5Y9NBWa7XduBAV5WCN5gSdqVtzPy+wJK9QCi8IQxArHjNp tHxOYWWA0hE4+A1nYvqcJusrABdDmVXsclehqrCfsEW7cbFMeusU2tWuORypqqmDv7PKiXz /ZBiscth2f/dxBrEW8Cy6jSB05Byajrz1e88XN4BG6hOQxFdUdQ1yQawiodtI+VCjrC1ea8 nu3cY7Z9YK++m1iy8Nw3HDcqwkrsdu6plfV+bHTRqXEZ9/36E3QFlTwK4o+MIyPQ+QGEVr6 SyMSDjQupY5XXyGzEOr5ygjsxj4gDZ1qNXX26r37wpAmT2AqzEnMoZwCpjCsb00r8r5zd/6 KxoyqqZdxPxg3cT0bT2f7QkmDlkkAtdKKf5mv7m6goWYq6sBoWcU2AUk8U+BdWMXh03jlbA JJQ5kyY+sYsSNKFwZMPlEry7OGtrQyrpi7aXpAb+AcTNA4XPFUjgJo15Cqxq0SjfqFBGOQ7 S59BzqRxW/VlC/k= X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= X-QQ-RECHKSPAM: 0 The SpacemiT I2C controller's SCL (Serial Clock Line) frequency for master mode operations is determined by the ILCR (I2C Load Count Register). Previously, the driver relied on the hardware's reset default values for this register. The hardware's default ILCR values (SLV=3D0x156, FLV=3D0x5d) yield SCL frequencies lower than intended. For example, with the default 31.5 MHz input clock, these default settings result in an SCL frequency of approximately 93 kHz (standard mode) when targeting 100 kHz, and approximately 338 kHz (fast mode) when targeting 400 kHz. These frequencies are below the 100 kHz/400 kHz nominal speeds. This patch integrates the SCL frequency management into the Common Clock Framework (CCF). Specifically, the ILCR register, which acts as a frequency divider for the SCL clock, is now registered as a managed clock (scl_clk) within the CCF. This patch also cleans up unnecessary whitespace in the included header files. Reviewed-by: Yixun Lan Link: https://lore.kernel.org/all/176244506110.1925720.10807118665958896958= .b4-ty@kernel.org/ [1] Signed-off-by: Troy Mitchell --- This patch was affected by the P1 Kconfig, which caused the maintainer to revert it. The current commit is a direct cherry-pick and reserves the original change= log. This note is to clarify for anyone who sees the cover letter marked as v2 while the changelog entries reach v4. --- Changelog in v4: - initialize clk_init_data with {} so that init.flags is implicitly set to 0 - minor cleanup and style fixes for better readability - remove unused spacemit_i2c_scl_clk_exclusive_put() cleanup callback - replace clk_set_rate_exclusive()/clk_rate_exclusive_put() pair with clk_s= et_rate() - simplify LCR LV field macros by using FIELD_GET/FIELD_MAX helpers - Link to v3: https://lore.kernel.org/all/20250814-k1-i2c-ilcr-v3-1-317723e= 74bcd@linux.spacemit.com/ Changelog in v3: - use MASK macro in `recalc_rate` function - rename clock name - Link to v2: https://lore.kernel.org/r/20250718-k1-i2c-ilcr-v2-1-b4c68f13d= cb1@linux.spacemit.com Changelog in v2: - Align line breaks. - Check `lv` in `clk_set_rate` function. - Force fast mode when SCL frequency is illegal or unavailable. - Change "linux/bits.h" to - Kconfig: Add dependency on CCF. - Link to v1: https://lore.kernel.org/all/20250710-k1-i2c-ilcr-v1-1-188d1f4= 60c7d@linux.spacemit.com/ --- drivers/i2c/busses/Kconfig | 2 +- drivers/i2c/busses/i2c-k1.c | 159 ++++++++++++++++++++++++++++++++++++++++= ---- 2 files changed, 146 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index fd81e49638aaa161ae264a722e9e06adc7914cda..fedf5d31f9035b73a27a7f8a764= bf5c26975d0e1 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -798,7 +798,7 @@ config I2C_JZ4780 config I2C_K1 tristate "SpacemiT K1 I2C adapter" depends on ARCH_SPACEMIT || COMPILE_TEST - depends on OF + depends on OF && COMMON_CLK help This option enables support for the I2C interface on the SpacemiT K1 platform. diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c index 6b918770e612e098b8ad17418f420d87c94df166..e38a0ba71734ca602854c85672d= cb61423453515 100644 --- a/drivers/i2c/busses/i2c-k1.c +++ b/drivers/i2c/busses/i2c-k1.c @@ -4,18 +4,21 @@ */ =20 #include - #include - #include - #include - #include - #include - #include +#include +#include +#include +#include +#include +#include +#include +#include =20 /* spacemit i2c registers */ #define SPACEMIT_ICR 0x0 /* Control register */ #define SPACEMIT_ISR 0x4 /* Status register */ #define SPACEMIT_IDBR 0xc /* Data buffer register */ #define SPACEMIT_IRCR 0x18 /* Reset cycle counter */ +#define SPACEMIT_ILCR 0x10 /* Load Count Register */ #define SPACEMIT_IBMR 0x1c /* Bus monitor register */ =20 /* SPACEMIT_ICR register fields */ @@ -87,6 +90,13 @@ #define SPACEMIT_BMR_SDA BIT(0) /* SDA line level */ #define SPACEMIT_BMR_SCL BIT(1) /* SCL line level */ =20 +#define SPACEMIT_LCR_LV_STANDARD_SHIFT 0 +#define SPACEMIT_LCR_LV_FAST_SHIFT 9 +#define SPACEMIT_LCR_LV_STANDARD_MASK GENMASK(8, 0) +#define SPACEMIT_LCR_LV_FAST_MASK GENMASK(17, 9) +#define SPACEMIT_LCR_LV_STANDARD_MAX_VALUE FIELD_MAX(SPACEMIT_LCR_LV_STAND= ARD_MASK) +#define SPACEMIT_LCR_LV_FAST_MAX_VALUE FIELD_MAX(SPACEMIT_LCR_LV_FAST_MAS= K) + /* i2c bus recover timeout: us */ #define SPACEMIT_I2C_BUS_BUSY_TIMEOUT 100000 =20 @@ -104,11 +114,20 @@ enum spacemit_i2c_state { SPACEMIT_STATE_WRITE, }; =20 +enum spacemit_i2c_mode { + SPACEMIT_MODE_STANDARD, + SPACEMIT_MODE_FAST +}; + /* i2c-spacemit driver's main struct */ struct spacemit_i2c_dev { struct device *dev; struct i2c_adapter adapt; =20 + struct clk_hw scl_clk_hw; + struct clk *scl_clk; + enum spacemit_i2c_mode mode; + /* hardware resources */ void __iomem *base; int irq; @@ -129,6 +148,79 @@ struct spacemit_i2c_dev { u32 status; }; =20 +static void spacemit_i2c_scl_clk_disable_unprepare(void *data) +{ + struct spacemit_i2c_dev *i2c =3D data; + + clk_disable_unprepare(i2c->scl_clk); +} + +static int spacemit_i2c_clk_set_rate(struct clk_hw *hw, unsigned long rate, + unsigned long parent_rate) +{ + struct spacemit_i2c_dev *i2c =3D container_of(hw, struct spacemit_i2c_dev= , scl_clk_hw); + u32 lv, lcr, mask, shift, max_lv; + + lv =3D DIV_ROUND_UP(parent_rate, rate); + + if (i2c->mode =3D=3D SPACEMIT_MODE_STANDARD) { + mask =3D SPACEMIT_LCR_LV_STANDARD_MASK; + shift =3D SPACEMIT_LCR_LV_STANDARD_SHIFT; + max_lv =3D SPACEMIT_LCR_LV_STANDARD_MAX_VALUE; + } else if (i2c->mode =3D=3D SPACEMIT_MODE_FAST) { + mask =3D SPACEMIT_LCR_LV_FAST_MASK; + shift =3D SPACEMIT_LCR_LV_FAST_SHIFT; + max_lv =3D SPACEMIT_LCR_LV_FAST_MAX_VALUE; + } + + if (!lv || lv > max_lv) { + dev_err(i2c->dev, "set scl clock failed: lv 0x%x", lv); + return -EINVAL; + } + + lcr =3D readl(i2c->base + SPACEMIT_ILCR); + lcr &=3D ~mask; + lcr |=3D lv << shift; + writel(lcr, i2c->base + SPACEMIT_ILCR); + + return 0; +} + +static long spacemit_i2c_clk_round_rate(struct clk_hw *hw, unsigned long r= ate, + unsigned long *parent_rate) +{ + u32 lv, freq; + + lv =3D DIV_ROUND_UP(*parent_rate, rate); + freq =3D DIV_ROUND_UP(*parent_rate, lv); + + return freq; +} + +static unsigned long spacemit_i2c_clk_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct spacemit_i2c_dev *i2c =3D container_of(hw, struct spacemit_i2c_dev= , scl_clk_hw); + u32 lcr, lv =3D 0; + + lcr =3D readl(i2c->base + SPACEMIT_ILCR); + + if (i2c->mode =3D=3D SPACEMIT_MODE_STANDARD) + lv =3D FIELD_GET(SPACEMIT_LCR_LV_STANDARD_MASK, lcr); + else if (i2c->mode =3D=3D SPACEMIT_MODE_FAST) + lv =3D FIELD_GET(SPACEMIT_LCR_LV_FAST_MASK, lcr); + else + return 0; + + return DIV_ROUND_UP(parent_rate, lv); +} + +static const struct clk_ops spacemit_i2c_clk_ops =3D { + .set_rate =3D spacemit_i2c_clk_set_rate, + .round_rate =3D spacemit_i2c_clk_round_rate, + .recalc_rate =3D spacemit_i2c_clk_recalc_rate, +}; + static void spacemit_i2c_enable(struct spacemit_i2c_dev *i2c) { u32 val; @@ -147,6 +239,26 @@ static void spacemit_i2c_disable(struct spacemit_i2c_d= ev *i2c) writel(val, i2c->base + SPACEMIT_ICR); } =20 +static struct clk *spacemit_i2c_register_scl_clk(struct spacemit_i2c_dev *= i2c, + struct clk *parent) +{ + struct clk_init_data init =3D {}; + char name[32]; + + snprintf(name, sizeof(name), "%s_scl_clk", dev_name(i2c->dev)); + + init.name =3D name; + init.ops =3D &spacemit_i2c_clk_ops; + init.parent_data =3D (struct clk_parent_data[]) { + { .fw_name =3D "func" }, + }; + init.num_parents =3D 1; + + i2c->scl_clk_hw.init =3D &init; + + return devm_clk_register(i2c->dev, &i2c->scl_clk_hw); +} + static void spacemit_i2c_reset(struct spacemit_i2c_dev *i2c) { writel(SPACEMIT_CR_UR, i2c->base + SPACEMIT_ICR); @@ -246,7 +358,7 @@ static void spacemit_i2c_init(struct spacemit_i2c_dev *= i2c) */ val |=3D SPACEMIT_CR_DRFIE; =20 - if (i2c->clock_freq =3D=3D SPACEMIT_I2C_MAX_FAST_MODE_FREQ) + if (i2c->mode =3D=3D SPACEMIT_MODE_FAST) val |=3D SPACEMIT_CR_MODE_FAST; =20 /* disable response to general call */ @@ -538,14 +650,15 @@ static int spacemit_i2c_probe(struct platform_device = *pdev) dev_warn(dev, "failed to read clock-frequency property: %d\n", ret); =20 /* For now, this driver doesn't support high-speed. */ - if (!i2c->clock_freq || i2c->clock_freq > SPACEMIT_I2C_MAX_FAST_MODE_FREQ= ) { - dev_warn(dev, "unsupported clock frequency %u; using %u\n", - i2c->clock_freq, SPACEMIT_I2C_MAX_FAST_MODE_FREQ); + if (i2c->clock_freq > SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ && + i2c->clock_freq <=3D SPACEMIT_I2C_MAX_FAST_MODE_FREQ) { + i2c->mode =3D SPACEMIT_MODE_FAST; + } else if (i2c->clock_freq && i2c->clock_freq <=3D SPACEMIT_I2C_MAX_STAND= ARD_MODE_FREQ) { + i2c->mode =3D SPACEMIT_MODE_STANDARD; + } else { + dev_warn(i2c->dev, "invalid clock-frequency, fallback to fast mode"); + i2c->mode =3D SPACEMIT_MODE_FAST; i2c->clock_freq =3D SPACEMIT_I2C_MAX_FAST_MODE_FREQ; - } else if (i2c->clock_freq < SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ) { - dev_warn(dev, "unsupported clock frequency %u; using %u\n", - i2c->clock_freq, SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ); - i2c->clock_freq =3D SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ; } =20 i2c->dev =3D &pdev->dev; @@ -567,10 +680,28 @@ static int spacemit_i2c_probe(struct platform_device = *pdev) if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "failed to enable func clock"); =20 + i2c->scl_clk =3D spacemit_i2c_register_scl_clk(i2c, clk); + if (IS_ERR(i2c->scl_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->scl_clk), + "failed to register scl clock\n"); + clk =3D devm_clk_get_enabled(dev, "bus"); if (IS_ERR(clk)) return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock"); =20 + ret =3D clk_set_rate(i2c->scl_clk, i2c->clock_freq); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to set rate for SCL clock"= ); + + ret =3D clk_prepare_enable(i2c->scl_clk); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to prepare and enable cloc= k"); + + ret =3D devm_add_action_or_reset(dev, spacemit_i2c_scl_clk_disable_unprep= are, i2c); + if (ret) + return dev_err_probe(&pdev->dev, ret, + "failed to register cleanup action for clk disable and unprepare"= ); + spacemit_i2c_reset(i2c); =20 i2c_set_adapdata(&i2c->adapt, i2c); --=20 2.51.2 From nobody Tue Dec 2 02:49:49 2025 Received: from smtpbg151.qq.com (smtpbg151.qq.com [18.169.211.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC07C2D97BF; Tue, 18 Nov 2025 06:08:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=18.169.211.239 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446107; cv=none; b=aaY1J+ZcYt1YGZK4Qx/HYEVjfZHnBIF0AYY2UG6czVhdLi+15tYN+MnBrNrJhIN4VMG8BVVjqrsgv/SE3ojQ33dMgT+llQxU3dDYfS4xij8bVIc5nLXNh5MeSXVmDKH9znKVJHX2Vy/zo8NfL2b34kfmYxAmGpxgFAwI6VC64sE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446107; c=relaxed/simple; bh=O0ET+73GNcMNM8GQ0vp3eFlX8NnqDIXFIkI/j57BfWg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SpqdOEloP4cQV5e6xjQhjC3djIZS8yRRdo09OIRTppVGsYJaJTMiYwPHsPgGXqTQr6nQhPswxCrQ+b84WW7O7XhkmphnWN94PohqKBBiqiWKVeDrXa+UNOSk9bqL6EKiDDFpxsiMW1yjMz5ypLQMfZnsOEjeJghypeEKFvrfgKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=KQyn/yF6; arc=none smtp.client-ip=18.169.211.239 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="KQyn/yF6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1763446100; bh=JJKnbCzCyE56DvqtMiAuAzvsyxWj4Xmfmgz9svZYVl4=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=KQyn/yF6cWq9fag7e+i1IrnHgR9ZXKeb35IFTKgAdmcYMlVtfTf2wwGDfNmWYi3+M +JouLoJqnemU2Uqg+9bJ70NnTVbLFyS7Z/8Q4twLpfQKM5ajsgbjUhn+oHScGEJQAH uhmkFbQfEhaLB/uMzWX9ibd/z+mWLu95jckhHUxg= X-QQ-mid: zesmtpsz7t1763446097tc170ed18 X-QQ-Originating-IP: +LNcdJjd9qMKIjgg15SU0g3IP6WZkqv8aPItSsa9TDo= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Nov 2025 14:08:14 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 13402662488646973170 EX-QQ-RecipientCnt: 13 From: Troy Mitchell Date: Tue, 18 Nov 2025 14:08:06 +0800 Subject: [PATCH v3 2/4] rtc: spacemit: MFD_SPACEMIT_P1 as dependencies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-p1-kconfig-fix-v3-2-8839c5ac5db3@linux.spacemit.com> References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> In-Reply-To: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> To: Lee Jones , Yixun Lan , Alex Elder , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Troy Mitchell X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763446086; l=1318; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=O0ET+73GNcMNM8GQ0vp3eFlX8NnqDIXFIkI/j57BfWg=; b=8TEiAdqEhKkZALZLUbMI/ZvkEHwHrPeyfyMYKZDiS5r2HzeKYowHaOrTl+gWievKRuNoS24WU enNBKW94GzLBQtnqIVyyDffebqQOWxnQgKLUPEoazPiHoQkJ6tuWtuP X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: NuGHm3DxUDaEqXUNtUz4jWsjOXPYt/cWCcQ9JbgEZsMKEqv5jOHGR/A3 DK2FEANFXWYLqU5IlL50YosnOu3ny7PEJraaeIIfaxGyfI+3eOmMYLz4GiO/7NZh8x2wKM1 Jb+CQ6p2PVxb0y82GUGR8O56ra4PlhZVGICLVTLkQrO7RJpGCWLhd4n3UjInDJ0kA4fI+Wr LaEHzQ0ya+peaFu4bJQlTtrBK83Jn6Qr4EjSyj3DfRoipjU1xVMF6FTyWPWbgLxKOFoZFUy 8t5SnrXj2wU/5AvCtXqwKaLjgm7sKfRcqKFjG9Fb+Y/rSZRBEESFeRv4WuBsaR18NsD8/nQ X3dOfjqcuLbScNjR74Z8RkVJiF6wFEAUYsg6KT62AMOvabrzg7585UnSqMyNtolDy5ASEoh Do22kjIUaZ1heSauShLYqIV3Du6ViLITsTR+uTKDanoLmlSQC6hyHXOvT5v467kWjVGES1Y sXZ3oviGJfLp2o6le406cw18uyQ5FnWtyxWVfLVaYmFMSYa9UnQl+ekBn3RV+gOSkH4YAP6 RrM1ZKEGvqnL9dHgxtrILCcdWLsIq8xLCAACbUCV2+WItXJ9bIBN1UcpDFI/D/FgHqh0Yfx C01qQSw62B7RMq1lXbgdPhsGlir2sMFBsoCtjp5cJNaU57KlOrdDQh7EMK4Z4X2wDRbMeGI JeAT9I5jUBt8S7tTyWCKJOS5KfBAy3Gxljq9o23j+L4l52E1LHC1KPDvY1PTYPobpg2/RhB 5U7VCfsXJZFez+742hdeuJm8a4zisOsCwBXNJWLzJeKMoE3CNgeW4kYaOuED2nLxU4qfIBF 3OFxWp8LrbQgzKQZXCPuMPhSlkHgfZkRhDRqcmf8206hQe6dznZ6YXD6C5ZFp5HtYLRhg6g JlzOBE8E3PxmOU1rBKEroNA39825jBctYSve0+glv0N7Uue/+HgTbRKUbe9LiEH7i/iLCAm 0bzyyIILwjVo5zMj3vc++sRvi4ZFXA4FvVbXkOhXERACPRsa16PILE+6nnOyad6rf0U9iLh BG2DUTgCCvexmicN7K30SkCD5dovVNFpi1b4MIFWRoGL7j2oJOhDbfpUNiTX58lbNpJv4VO djdBlcE8fRvaYQBQ64HC2rEQvbvMVxmqdGKE1UQN2vuF0Sop1g8PM1iRPY1+i0i51hGVSLo lOZKUnSo805uStY= X-QQ-XMRINFO: MSVp+SPm3vtS1Vd6Y4Mggwc= X-QQ-RECHKSPAM: 0 RTC_DRV_SPACEMIT_P1 is a subdevice of P1 and should depend on MFD_SPACEMIT_P1 rather than selecting it directly. Using 'select' does not always respect the parent's dependencies, so 'depends on' is the safer and more correct choice. Additionally, the default value depends on MFD_SPACEMIT_P1 rather than ARCH_SPACEMIT. Signed-off-by: Troy Mitchell Acked-by: Alex Elder --- Changelog in v3: - modify commit message - change default value from ARCH_SPACEMIT to MFD_SPACEMIT_P1 - Link to v2: https://lore.kernel.org/all/20251027-p1-kconfig-fix-v2-3-4968= 8f30bae8@linux.spacemit.com/ --- drivers/rtc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig index 2933c41c77c88e60df721fe65b9c8afb995ae51e..b392e6d096ed077e841a2e68b70= d8b80d9ad1cde 100644 --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -409,8 +409,8 @@ config RTC_DRV_MAX77686 config RTC_DRV_SPACEMIT_P1 tristate "SpacemiT P1 RTC" depends on ARCH_SPACEMIT || COMPILE_TEST - select MFD_SPACEMIT_P1 - default ARCH_SPACEMIT + depends on MFD_SPACEMIT_P1 + default MFD_SPACEMIT_P1 help Enable support for the RTC function in the SpacemiT P1 PMIC. This driver can also be built as a module, which will be called --=20 2.51.2 From nobody Tue Dec 2 02:49:49 2025 Received: from smtpbgsg2.qq.com (smtpbgsg2.qq.com [54.254.200.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFA82D7DE3; Tue, 18 Nov 2025 06:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.254.200.128 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446111; cv=none; b=d1gxDjdum4EIckYKQIMQwxpx0nLaJNik/O65ucW5ChZXX1Bh82B6+Vu43r/ZREgXjuYaWIyU03TM+mbxI++rO7dyLj8AhM2pHhJVqiugoGpWyvVOPAixCfoYTqemTIW8OZWxw5rGYJdCpk2dtu6xMZ34QEf36olZuu5y+pWDigM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446111; c=relaxed/simple; bh=yls6h80hLZJlTac4LUpPcWzxMBYeSjdLpDtBb4EbJJg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dQ1XezfOdSCPC4esOhuB5Qm6ia838P2Pf1MDsv0zN/Thn7WjcdaQbgnVm0QpgNFG6BmcV3Xd2c4AwZcICBXx/RNdw1J6ioDHKq4LlJaAViUCKvV+//BB+03ElSJUm7DaaeY1zM4yHTH+vPcy2nzJRpNYtJgSy5Q0OW4TFzcr9M8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=F2+PgoNh; arc=none smtp.client-ip=54.254.200.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="F2+PgoNh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1763446104; bh=/R28j+sip2o0AzX0gvsfJgIDgUWL+CJ2iEXc2U7oVtU=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=F2+PgoNhtlvjmdd3cR5q4vYuuRa89ah9ifHpktOLRmNLc5pT0gtKEgE9OQ320uF2r LdNG3NSSRJPA9lc5phvs/HVEm7hZreVj111bQCAgU1Rc4ugRpyQ+B71R0gxODtY39h X9QuCQN/bpsRlbdNo4NwRi3TIdmtj1WZueDQcHIg= X-QQ-mid: zesmtpsz3t1763446100t30a9d698 X-QQ-Originating-IP: HMfRSA0C3/bJASptnEPMikXz27CdD8G3z4bOnI6LNzQ= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Nov 2025 14:08:18 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 16781449544636721918 EX-QQ-RecipientCnt: 13 From: Troy Mitchell Date: Tue, 18 Nov 2025 14:08:07 +0800 Subject: [PATCH v3 3/4] regulator: spacemit: MFD_SPACEMIT_P1 as dependencies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-p1-kconfig-fix-v3-3-8839c5ac5db3@linux.spacemit.com> References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> In-Reply-To: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> To: Lee Jones , Yixun Lan , Alex Elder , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Troy Mitchell X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763446086; l=1532; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=yls6h80hLZJlTac4LUpPcWzxMBYeSjdLpDtBb4EbJJg=; b=dr7NO2Rl2NS1SRL2NLicVgng+DpAuuG3iyX3P85oi8i6vmNxhMmIi1rQq0P1D0+kuhXx+lQm1 Y6KrtgHoA7wBd6WvY2Hv+xJl6oQIKUsPtdxrlgjcjgrFughsSecOqyB X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: OSVdtdr3pQUVVvFBu3XbEIhV+RJcOSON5Wsy5pTZtkzszhkQRcA/+tQq YX4vgCAvlHN4J/n3jz1rMX8jbVSesrZUMkSeY+Uf1fN9Qx3zasYmUZk5cDX+1Ilm03R9mFt tCKHex/XGh8wKv5YRTi2SV6/elBJKPH6QUbshvSToJxGMAbxdfiVIrM2ztYrgleqyBzp49m K/1odnumCs+EGXadd/CBXp/EQwfidK0A8T3WfHIigFJrEBkIY8eMUCQNe6VN2ZUtoZTLEqF HX1Q3TEg/0P0zbJ80S48lmWxSP5dciiniOK1d0917GG6ISRBbBylIp21jDFR/obKgEJvxpR kvcVMQ9F198obSqJra6p+rio0fCQHcaf8FSLUFotOzOLfr9h/dd+B9yGwgddj0pD40adnj+ Xgpz+Gafc+puERBrpZHGCIJ2aTwXLFQ9iz6DJAtnn4BKyl51FbMju8Gxmf1sjSmYSUI/AXY WkTrTgviEiy7BPB9qCF9cTRpe78LbOu6lhK7GoQJQOHgMmMxlZrLvEeirNMu0NRmt9Iwc/8 EidHrK3D6Ye2p6vhr6vGotMSc4/XqLyO9ES5Pz+7KARfO3LO+akGj9WVuG1i02QLru4d+W2 norAie3/JUK9izgJB0+s+iw76/csyjR8pzT6kFOOvcQvnoN7dSn1O6NCcSoZvTY+WLN4IBG WPmMnbTcuDm2mymEtxY6heWVp7BMb39p9/LYBYut/r62MZyeKxOA4fKi92Dy7yVPU2A0T36 xVbh6J9G1zuoPKy1tNs0W5+2A+n9/aO/rctp42WVPGbcTMQmLoYxf158DOQBSKLVNJ1h0i6 oUH5xzXSS/0ehdI7V1yRxJnOEM4WM16Wk0FmYGcd5VruJttlA+Q4f1a80NQDYrFDvZ1TBel fE8kM5FzFcypP2P1rIS+h6+Yw1bYkysmLtSdtyaFz8ZADo/vyaJ0qqTITQSNnu5WZinSym6 1Cdyy4zT6nedoabl57aa72E4Sct468tw7G8Ejd28FnfSR0Kn8xfiFgHMPuoVa+rztu/qsR+ 9Ubk4BHjwd12fGrk8zfgwfnHcCPelkkEw00aY/K+4CQWtQdyt5A9dCwR+H5aDXEFpFeSYhk iZHyJezN8KL3SNCTx4cRYaB9SNVdNeq/OjadiYOoM/4616eOLQboAM4fbCOu4I+IA== X-QQ-XMRINFO: OWPUhxQsoeAVDbp3OJHYyFg= X-QQ-RECHKSPAM: 0 REGULATOR_SPACEMIT_P1 is a subdevice of P1 and should depend on MFD_SPACEMIT_P1 rather than selecting it directly. Using 'select' does not always respect the parent's dependencies, so 'depends on' is the safer and more correct choice. Since MFD_SPACEMIT_P1 already depends on I2C_K1, the dependency in REGULATOR_SPACEMIT_P1 is now redundant. Additionally, the default value depends on MFD_SPACEMIT_P1 rather than ARCH_SPACEMIT. Acked-by: Mark Brown Signed-off-by: Troy Mitchell Acked-by: Alex Elder --- Changelog in v3: - modify commit message - change default value from ARCH_SPACEMIT to MFD_SPACEMIT_P1 - Link to v2: https://lore.kernel.org/all/20251027-p1-kconfig-fix-v2-4-4968= 8f30bae8@linux.spacemit.com/ --- drivers/regulator/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index d84f3d054c59d86d91d859808aa73a3b609d16d0..e2cbbb90500189a1c4282511b8d= 7141301cae1f0 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -1455,9 +1455,8 @@ config REGULATOR_SLG51000 config REGULATOR_SPACEMIT_P1 tristate "SpacemiT P1 regulators" depends on ARCH_SPACEMIT || COMPILE_TEST - depends on I2C - select MFD_SPACEMIT_P1 - default ARCH_SPACEMIT + depends on MFD_SPACEMIT_P1 + default MFD_SPACEMIT_P1 help Enable support for regulators implemented by the SpacemiT P1 power controller. The P1 implements 6 high-efficiency buck --=20 2.51.2 From nobody Tue Dec 2 02:49:49 2025 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C8992DEA98; Tue, 18 Nov 2025 06:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.22.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446117; cv=none; b=l/vGVDqoIu8lX2NCtrM0s9yVna+6gfs0CLDg1J8jsHok5zQLSEw9MA1rCqk7LMeqOnddFCs8uLRqWkkgvAt/qO+hZohHehKUqC7lPz7XOzYI+vc5Skb3r2KlxVMNv8tQExUeBI2I7zY0WAnTRdWzCRmSI1kiTsTE1mHo/cH4o3I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763446117; c=relaxed/simple; bh=j2fkzlbQiDyQooNa5vCLtsRPai/03HAnd8cejpZGxhQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=txKlZ7ztgT5WkTgPPejRbpVzqix62jdznJSM4vldSi5xhRsKOslba/xPNCw/06hIsV0FKNpeGb9kw79ohXkkvFxmV0ePQfWDS+bUzgFvhKI6TQiJ7yBWL8AiuLPMYCo4anZipOx8q8YrDNYYpeeMRJFDsIekvY8cWP/9tDHv7Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com; spf=none smtp.mailfrom=linux.spacemit.com; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b=cu/ayut1; arc=none smtp.client-ip=54.207.22.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.spacemit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.spacemit.com header.i=@linux.spacemit.com header.b="cu/ayut1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com; s=mxsw2412; t=1763446108; bh=Fn+Ep3pNFHiTcymXP7LxnNNnuuTk/661XN/Li/c3sCc=; h=From:Date:Subject:MIME-Version:Message-Id:To; b=cu/ayut1tBJ7GDdoQ3GJSYNXRDBAex5Zj6HOY8c3hpqha2K5XulcVZpdOdwwm9Fa/ N//jykes2mvqrR3rpSSvm/CTzaPqDSOjT5HyAT5D63tKkZHkNMzdHC0Q7MBMAO7rf9 NPe7K1GgWXGcMk+ve0xHrRXQfwwtd7R9yMEBZv5I= X-QQ-mid: esmtpsz17t1763446104t31bd25e6 X-QQ-Originating-IP: nIxd1ZNdKRzG+bXQuhHb5znGp5EUKBmLDWISygy7lWI= Received: from = ( [120.237.158.181]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 18 Nov 2025 14:08:22 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 835651233922569180 EX-QQ-RecipientCnt: 13 From: Troy Mitchell Date: Tue, 18 Nov 2025 14:08:08 +0800 Subject: [PATCH v3 4/4] mfd: simple-mfd-i2c: add default value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-p1-kconfig-fix-v3-4-8839c5ac5db3@linux.spacemit.com> References: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> In-Reply-To: <20251118-p1-kconfig-fix-v3-0-8839c5ac5db3@linux.spacemit.com> To: Lee Jones , Yixun Lan , Alex Elder , Andi Shyti , Alexandre Belloni , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Troy Mitchell X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763446086; l=740; i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id; bh=j2fkzlbQiDyQooNa5vCLtsRPai/03HAnd8cejpZGxhQ=; b=B/MhDWZhHagWY5LtxDsv1ceREB517kF3qq6Bhc4kb4wymUOZhda5qc7oQVAD98qehTYZkNU7D pheaHRfMXcJB0lcKvThrUqlCpR/TT1ofan42KM4ImD/hOWtCfRlOuZq X-Developer-Key: i=troy.mitchell@linux.spacemit.com; a=ed25519; pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc= X-QQ-SENDSIZE: 520 Feedback-ID: esmtpsz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0 X-QQ-XMAILINFO: Oex01RfMxfHezK4+ruocZCCJv92kXrUZsCNBE71uBsWV91gVnnPyt5zX JlZTKjO5N6KJHDbFbQbxzQ9/AQBamdGiZ4PbaJkZjt/GkL3jtolZ41RtK3+U5jJwSv0+BCl GOBivTnrYkFMWgPImZ7FjXLdItHHHP5b3m+sRq+oPBVaywp8tRIrIdBA3m2vWmL1H4+yUzo bm+M3tzgra+F44Hn7EZhl6btiFbodFcFSobqzBfxyZrrjUpjhoj4BOlXBV7EmXYvcNdgpFi 8RYXpg+iNiLCMUd0j18LJj7G8dSfHlLQVi7H+MxRFUlnRTJ5jJ/nXWPV88cggaZ1yYBJs79 NlUsuHlvAvZpMz/vdZmMNCIFUvOy8cKXCMEOLrxy0FRXlA8cAiyiio+LH55m5/8Nr6nv86C TpLkkGP0/jES4wgYk6pmemX3cZhUFqslH/6d5RhRhU85SeXIeXqyKhaX3lVrznee4RURPnv 1w7qmt3A4m8cYB7pacfISvgzIU2jn/VVpG48Kta46OQDmJmf2HEHuJlhweYSU9Jq4ewbn/0 L6pdNpcOcse0zGHcP3S1Ez8HCdol/GvSY/mSLXh8PAaKHNJvHGxJzhJ8nIFrLNH/ulvNSkf lUJwPtpwdpjm/RFEHTiFIOs0sBx52wwAYyaFlO3UJSs9VKIER8ajgx+iELPaT/f6nffhWGP SphtixZbRYmEjZm7IeCZ49yfDPecH4I7li4L6VViBfo1HlJooxl0DN3Rw7SKups25bE16Ix ReklMLR09KO376qn1U+XycEjSdqNzLdJmyZesWr73QWLu4WB7UZWB6kbEwBIpN2JDbbfQi8 2DucpCD2tN3fpqyY4gzhGMo0nJ5KCn2S26U05OaoaeiTYjEhmFoumlLdb7rErY0bY4aARdi 9MFhVMm0gI/txW+G/PZDUDpV4eJt0dLhh//Qji+w6j6dPyqE6/yN4j8yKBqDVMMRYOBrZr3 i8CYiKOUINmxIo6Pk3lkdA4w5RCuEGh2afx0iemnoUpNEG74fiwa08DMV0AnrUh8wNK/RAL zdZlPcZ3iFhJ/0c8vshDAoJXB/H0uURK8yH78IXhR15g+s2NV2AYAWQGx2lYaGJWIBhbzup ptpodnl+oLv9FgKE1nSTuM= X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= X-QQ-RECHKSPAM: 0 The default value of the P1 sub-device depends on the value of P1, so P1 should have a default value here. Signed-off-by: Troy Mitchell Acked-by: Alex Elder --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..b0f109b3acc40b074e4d0178e12= 3437495853496 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -1260,6 +1260,7 @@ config MFD_SPACEMIT_P1 depends on I2C select I2C_K1 select MFD_SIMPLE_MFD_I2C + default ARCH_SPACEMIT help This option supports the I2C-based SpacemiT P1 PMIC, which contains regulators, a power switch, GPIOs, an RTC, and more. --=20 2.51.2