From nobody Tue Dec 2 02:52:44 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C89035A95A for ; Tue, 18 Nov 2025 13:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; cv=none; b=RIyi6GSr906w7zrOGBpTnP/I8zW7Rm2s4atBWhgCJmAenBObnO+e+YUDS1DzImknXTGYUHfdyBmR0dT4REiuu+b3XL0aCLei2ajpvcYrohjefNwm5D+DG3V72h7JUqN85qShBcUmln+rkA23CXd1qf1rAJjQQfRaXGIn8oasUrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; c=relaxed/simple; bh=gyjJc742Xp7x3M1wMCcAQq2+Hzs2mbWAJ0525DJRzCk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QRMOtMi/v2AzjaD5YFpaf2O4AtbrtZGSEEL0DRGrSYLjJulTLXCk35uALBkhSEcrIA2jWQB4ERMJfQMMAoPQicJoV4DmrutVTN0+H44pCXa7fcvJu2ThcwSpMIP7c5IV+GILjUhoBpPn5juHlFxn9mK9dWZQX8RqgL29L+njjxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YetKHdA6; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YetKHdA6" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42bb288c1bfso2172140f8f.2 for ; Tue, 18 Nov 2025 05:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474181; x=1764078981; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yKYlMIfAWjT0Z4v8dS+9AJxviT6d1hSBxbFdrwjdNQA=; b=YetKHdA6GH0FOfwx9gjwTTdvxpDpycsbuDIqzcNHt6H8q+azTd1y9RDDcYHVjgXTg5 4Ql1hz1z5Mez8WQA4XWHkQGqwE2rgkZX7bSpHNbsVkG1B1/6bzyGhu+KxizNZujzZ2cU Se511FBVsHA6nsEtSahMaids1ISA/9Ky4eXK/b1YP/dQORKkXg26irOVvnfWds3KQglV 7ySkimkP4GZMhHVpOYKuxuxjSv9sw0CXl409Z7yS85PJoTiLLP+JLVybJP4lSabWeuY1 K+Lvsp3enDeVl7k6u0QAdWSjoeT0U18DtDBmLMgptSMnmcDQDUM9Uth5k+MPLGWLDrMV bBow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474181; x=1764078981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yKYlMIfAWjT0Z4v8dS+9AJxviT6d1hSBxbFdrwjdNQA=; b=CQmDY/Gn76PtDfkdIHTxg58A78bTrEWIfez7G0v8ujnmhuGNp8rPI/96KyhUBLv817 SNJ9pYLr4vPBnguLdMAsduEbDbDQYFZ+HDkEUUXRGz9riUBs24BXlImfF16GymWqyQJB 1nRV6hRRRa56potwvTOUi9r17AUkKXBcJ6wJyC1gdSPtKB0An5TdXMESEjjfOx7MSIzv LFKx1g7fIkvYGPNeziyBKTWmdrxRI4xVLnLMrrMbQzC3f0nZbzZb5lo4GjNGcV/QjDcp MUJ/0xc8zThy+uzLdJ1/qYo6uktP5mJSc/RwjpxnvMnOr8V2lZz4eSn1gUBe8a3nFdLf mY8w== X-Forwarded-Encrypted: i=1; AJvYcCVL/SJ/J3xlAWTpMyCP7GY+b9nSTNkYNnU3kCUUKtuCbG+sRU4jMUMYs9Sutdn0KtDMa9+MNbqe/COxdNU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzti9CMYUxwoFZiBUBZtrhzVxBnhYybfOAzo6t1guT+6dZ2c0YY vxAM6w1rWXtwRtxuNOios665tE1vwCGeUc2fM/yTmiFpOuHPPKr9q6Yi4/DCEei2swU= X-Gm-Gg: ASbGncu3XbJlEVI3Qyl+KdtcA7oYXo9dcKr+0O7vBbMVTnWJOdpdxDOyIBopho7FJYO V2hPD5Ddu14yae97bYB1pQzEdFeN2NjwC+VHAzt4NjY63aeKFruOIlRA0HqqRerIFIg9mJTKYoi IS/MALOlfDvwI5dci/U6nWO96dvVcjavGWvUVTPLnNYUVR+sqsZ1CYFWLJy8SQOJpVe1drPDuP0 Cx3SgnWEu6H7ma7OXHTuLlBppyyo7VvVEn71DlVPyGLqfFGZG0z5bLokvCFYhF/mRjowzSCfNP6 MDANpuvuaTSMQFMbYmIFNZHuKI7SrW7U8hzGw7rO/3gcwDXboJcvlNWFZHpo+68/NqbIkG/eyHt vIK3S72Er6hQbtSbJG4l8MRz93TCF2ouaPC7ggqOff7gjxf30b1uLUrvF9IOGXm8DbcwKClKKoY D2eZwBZvvF7gwwVJ6K+BW8qZQoYIYf5/a7in+BJGdYg2Am9gpPWQgEjaHXScrKoI3ErY8ZfDAYO F4L1A== X-Google-Smtp-Source: AGHT+IFLEPtny/4M/qrsELeJqriFmtfSC8sisj+iye0XhMUpxvpy0r10rHp5Vjj+6+CEqyh5vAEHSA== X-Received: by 2002:a05:6000:186e:b0:429:cbba:b246 with SMTP id ffacd0b85a97d-42b592dccc4mr15022527f8f.0.1763474180971; Tue, 18 Nov 2025 05:56:20 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:20 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:11 +0000 Subject: [PATCH v2 4/7] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-4-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=3298; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=gyjJc742Xp7x3M1wMCcAQq2+Hzs2mbWAJ0525DJRzCk=; b=Dkbia94LbiSf/CBO+A1kJVBcYCRosgXFGkXFNUhm+Xo18ZKD9i0afT0aoz5prjd2k8c8oWq+O tEsgaKaT06PDq+XRCKwTR2CS+JpUmPQ00PQ9Th9PlQNtlhuRbjlUreJ X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Use dev_err_probe() to benefit of the standardized format of the error code (e.g. "ENODEV" instead of -19), to get meanigful error messages, and for more compact error paths. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index db73dfad4e1b4fb001cb653bc8caf8aa08d85f2d..e7dbe1bc45d6af58527125f512c= 0ff22c03a9629 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -87,8 +87,8 @@ static const char *product_id_to_soc_id(unsigned int prod= uct_id) return NULL; } =20 -static int exynos_chipid_get_chipid_info(struct regmap *regmap, - const struct exynos_chipid_variant *data, +static int exynos_chipid_get_chipid_info(struct device *dev, + struct regmap *regmap, const struct exynos_chipid_variant *data, struct exynos_chipid_info *soc_info) { int ret; @@ -96,7 +96,7 @@ static int exynos_chipid_get_chipid_info(struct regmap *r= egmap, =20 ret =3D regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 if (data->sub_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) { @@ -108,7 +108,8 @@ static int exynos_chipid_get_chipid_info(struct regmap = *regmap, =20 ret =3D regmap_read(regmap, data->sub_rev_reg, &val2); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, + "failed to read sub revision\n"); =20 if (data->main_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) /* gs101 case */ @@ -163,7 +164,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) =20 drv_data =3D of_device_get_match_data(dev); if (!drv_data) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "failed to get match data\n"); =20 if (drv_data->efuse) { struct clk *clk; @@ -180,10 +182,11 @@ static int exynos_chipid_probe(struct platform_device= *pdev) } else { regmap =3D device_node_to_regmap(dev->of_node); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get regmap\n"); } =20 - ret =3D exynos_chipid_get_chipid_info(regmap, drv_data, &soc_info); + ret =3D exynos_chipid_get_chipid_info(dev, regmap, drv_data, &soc_info); if (ret < 0) return ret; =20 @@ -202,15 +205,14 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (!soc_dev_attr->revision) return -ENOMEM; soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); - if (!soc_dev_attr->soc_id) { - pr_err("Unknown SoC\n"); - return -ENODEV; - } + if (!soc_dev_attr->soc_id) + return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 /* please note that the actual registration will be deferred */ soc_dev =3D soc_device_register(soc_dev_attr); if (IS_ERR(soc_dev)) - return PTR_ERR(soc_dev); + return dev_err_probe(dev, PTR_ERR(soc_dev), + "failed to register to the soc interface\n"); =20 ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, soc_dev); --=20 2.52.0.rc1.455.g30608eb744-goog