From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB71A35F8BC for ; Tue, 18 Nov 2025 13:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474184; cv=none; b=Q70slz78JPwzWMku5phNxR2hYka/NBa54EFLvJZc8cxjBHhoSiyB525cvOxpnWIAPnNBbGundrVrndIdm915n+I+gyecz2QMOZjVOuXoS16580pgLcivJ6UZjCbfK4O5cB08FuWK7QCjrf82m3JYK/90dDBgBIzottgZLiZbB9Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474184; c=relaxed/simple; bh=hE9pu4zL09R2VnRw1hPAh8QPybkRzkJsjvziTMQK6lI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BsjM30WVTVKQYIaYfQv0GAFN4QOgT4mSGtaRoJxecivDaiEgCND8rUGY2uNwSBrc8dMQPvCEOzUuHm49iWBTWJhA0nGDqnSa5lfk2gcCCtTkr+zjiRmFc5bii6zW+jeeCzgwzCULE8vUeYdeOtkrMfjF+PlKBwbrl08FBQzHzBg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VKrjRJrt; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VKrjRJrt" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42b32a5494dso3296669f8f.2 for ; Tue, 18 Nov 2025 05:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474179; x=1764078979; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mT9D4mxJaHrktugW+TtOKGoZWS1UVqUBb8i2CtMbCwk=; b=VKrjRJrt4E9ve7xMjcOl8HIgloLsJ0YzmKJcLmkQV6YYWaZWxGS/TiQ17OdTcc+l3j K65ygQ+BME2B1U8WvzXaDLoJka1ly+l0Kjhk0XwAc6FBdJ3r8Desy7y0NDFgIqcDDXkD LzgPknmB/Kvn/8tO1W//gLbXC7qTZhnSMERlx8OfRAhrDPIyvrcrffSd+kKMn2DVP979 MEqylFkib95L1JsEKkInG/Ixe+gFST+a8W3M1e+Dkd6vVW9tHEDfMBI7T+cgpROA9MCE DXhCltDo20bZBE+uJPkhffpyvNBiivvqkmpNUC/jLDHbOJelIZU1VF01RAgmsWEfEGcO 5n3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474179; x=1764078979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mT9D4mxJaHrktugW+TtOKGoZWS1UVqUBb8i2CtMbCwk=; b=vaZSaZ/rNbYYXoyyCDd0dJpCkvx4IUx1+d64MskulCRRWrO6WvsK3ifv9G82w8XbxE t6DTgV0pH22CsurpImVzr1bTrXC5GB+lcEQ+TbW8bbCqk36nnwb6rwtyMvUvq85zm1jm bsTie7guz3s6V9zv3zWlJjzq1FN3nfl0sRmX8fqzm1FhcpGWx62DZE4jNLBEJ7uNU9gg +I2umbzSnFvzds/DpusX8qOk87pxj0uRDjzloOaVZzr4fEi23qpMrFG/P+BAXBYik2Yq vn8wllLPEA1t8dR2PWGm9KopK2K+h1wwEjTiELQvkcqsTcI8d+TdBMpNXmHq6GkPqK1N iCiA== X-Forwarded-Encrypted: i=1; AJvYcCVJngpJVrQJ3ZInyktJCFPVt/TrmSSxage+lrPXC5bHK9rwh0vQJAnkmF23zDtxlEKb78m+Ps69m6+JUyo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx34CvB/Yd6kpxLF8yuvd4TaJsIRRCPIgiPhVmRbutiby4OQ43q YLFr7phAm/z4OrCIlrdP5tZDgEKy0REf0mStT5VQKKB5MKHd1F/p/ngmUDvUPdvsHvA= X-Gm-Gg: ASbGncso/GE30WvUrMEaon1pH1fXBKnTaffuAgwjw6H4W5pZ+ZYvHb3Xs9HwOx9Pv5Q xNVgHl3kCOiZ30UerdjBkOFjA+rq1K9wype0SBE72Ba+bh+h6cYxDjg1gZ6M4jKRwJ2q2af2QI+ FddIuuQPk71xWJctXDDZSgBTi6FjKlFKmrwjJLj2P8iPTABB4kqNo8jtFUoeRLsR0sClhWouuuA 4lrNELP6J2W+KfqLQUkRxCS5s56WdsbI8CY0aWYwGY5ZixmCiNrDECcl7cnOccHCRmPexdybF15 bJwrZSOY6r1Nfsc0Yt6oNhTjWRIrHQYx80rkRNABEABd4MgrLMUVhaXSNXqd6LVKQuQfoKhnKDt 2r9keECxk1Z4kmGFg2Jd+hLOP48fD8uBWxM8ocilN1f3cN+KsB/uklcYVKkmSZZWodyllrZ0roT JC0Imos84GBk0UlX9BoCPPLgZh+Jj2AH237mUh9ZJS18qIiDl4jg1tqEGoKOSKRt+nd8PnWF/rL KLiXw== X-Google-Smtp-Source: AGHT+IFSeYnPbCw3tis4yQRZI08iOt4XrwHVQj4yd7amd2aPdf7DLT9bDe6bDLKPiGXs0lIp0USpvw== X-Received: by 2002:a05:6000:430e:b0:429:c4bb:fbd6 with SMTP id ffacd0b85a97d-42b5936c4a2mr14623335f8f.31.1763474178959; Tue, 18 Nov 2025 05:56:18 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:18 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:08 +0000 Subject: [PATCH v2 1/7] dt-bindings: nvmem: add google,gs101-otp Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-1-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=2105; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=hE9pu4zL09R2VnRw1hPAh8QPybkRzkJsjvziTMQK6lI=; b=rOjp9fByKIiYv2zyDGDmfAh5uHoPJlkPj+pJH/Wo7/4XVrDXytSpx2NxMD3/6YvsMTnrew6jU MLbn/+h0vuFCoeJHn589V0xkn5CgCijQecUkHEOp3AFcz3Urq6cHgrN X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add binding for the OTP controller found on Google GS101. Reviewed-by: Andr=C3=A9 Draszik Reviewed-by: Krzysztof Kozlowski Signed-off-by: Tudor Ambarus --- .../bindings/nvmem/google,gs101-otp.yaml | 56 ++++++++++++++++++= ++++ 1 file changed, 56 insertions(+) diff --git a/Documentation/devicetree/bindings/nvmem/google,gs101-otp.yaml = b/Documentation/devicetree/bindings/nvmem/google,gs101-otp.yaml new file mode 100644 index 0000000000000000000000000000000000000000..8ed65e906a2a1b0c216a09c9444= f87af61090b81 --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/google,gs101-otp.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/google,gs101-otp.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Google GS101 OTP Controller + +maintainers: + - Tudor Ambarus + +description: | + OTP controller drives a NVMEM memory where system or user specific data + can be stored. The OTP controller register space is of interest as well + because it contains dedicated registers where it stores the Product ID + and the Chip ID (apart other things like TMU or ASV info). + +allOf: + - $ref: nvmem.yaml# + +properties: + compatible: + items: + - const: google,gs101-otp + + clocks: + maxItems: 1 + + interrupts: + maxItems: 1 + + reg: + maxItems: 1 + + power-domains: + maxItems: 1 + +required: + - compatible + - reg + - clocks + - interrupts + +unevaluatedProperties: false + +examples: + - | + #include + #include + + efuse@10000000 { + compatible =3D "google,gs101-otp"; + reg =3D <0x10000000 0xf084>; + clocks =3D <&cmu_misc CLK_GOUT_MISC_OTP_CON_TOP_PCLK>; + interrupts =3D ; + }; --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CEE34CFD5 for ; Tue, 18 Nov 2025 13:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474184; cv=none; b=hzc/78YZm7e42bql7I8WiP+DwS+5PtCRN3TAqt+loBo0Wvj/IDlQXsIH0EcN18V/eKCdv2zQp0BXcE6TYGABG10G0Tfo4SXJPiSnZql0ykyodoAuln8LAIVNYuMq20nK3p0EnQNUL3CzsbAT7eIoA3QXWK5yxvzvIvtdWnwULxw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474184; c=relaxed/simple; bh=p4ZObKdORDPs9HTtQcCqfM4Dt9UYXjFKiNvgoGM8eUg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ugtvXIgutF57y8uBkdQSoxaW6DheLYWbHAdk4fJXiIw+0UxPS+a61y+VagK1FWWDnzeHOwigsZRQLdMKbLssngStpQRoN2fDEvJZXAgZ7MXmRe5tko+M1Rejuhv0RYBhoYDmTPfJqdfa8Bx3BRRvle7/exBn3t/AgKDgN/mL2Bg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zM6rHLZY; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zM6rHLZY" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-42bb288c17bso1872094f8f.2 for ; Tue, 18 Nov 2025 05:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474180; x=1764078980; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=krmSxhstA40QKaUa91FcpQEPCxCXSSQwFp3fjsLx65I=; b=zM6rHLZY42U0K358T59xoH768cxkOmmY1lQbDvVMQvRHehvPlB6fA5c8GfbWFBY3CB /tKSnhthWZZm73KV0T5FRzWJPNUkJ1dY7h9vmib+hVvnhc9/o/z6nFFvKYrSTr1Yup8J CGStt44AMfl/7p/4WUT/ZL1vc/nAafQEpxz31TLwCUsE2F6EvKMVogQjzoI6/hG4xWx4 uW2ttszgNNQWJz9Pr4TiqBw89AFkHHnZOKcpUASKlTAi+Tl+cCykVoxVZb4+3C2xQhtT zCDkk+eikDAdwrQYCNmB9hTI58lPVO4qcaMuKo1I3bitDKiTfiBG2GXX6WcIgaw6RWz5 g3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474180; x=1764078980; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=krmSxhstA40QKaUa91FcpQEPCxCXSSQwFp3fjsLx65I=; b=lCWn5q/cGciFj+vx57ONcFQ23z7WvcGNHJDmgSvt/TRLIa7Zyw83CH2LgQQK6LUSxX Xjj3iYsBKZ+eDd2ojmdIBIhuyapJOokSAYQXbPMNUwCziMJZlbpNP0JciOY0wmTN1574 IOnce6ER7f9Tw9RtaPxRxomp1UiOoeN4/UPmqA46ilwD6UX4/ij68nIDL9qwzYiXTUZk zPXm5gFHAbrlpUKYuYi/IOs52D6gqgEHdJvG0tDszF18F+ILYnywBImp/aZSSBLXAxAj S4hP9HBEcs9/QoiqS8U+VPKOzYuUilPJEWfhC9WGLMhd+EbjIoYWOdz1eE2QI5NvFn+E of+g== X-Forwarded-Encrypted: i=1; AJvYcCXtetMbusc+82nUxjQ5hGMSFiZre92YCm/+cIhh4awz1Sdkj1i32qwrff0QeVoG9IuF1i/H1ERgX3PDO4s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7KQxtaaIjNQ0MOy9vZESgEupM1mCWmlESiwipTVZLVRgJc7lf gT5sRieN+Mwy0tJTVDuC6qqgfx1ikDBxXLaa1HU/RvsqsxltH+V5QJHl15Fd4mnPLHQ= X-Gm-Gg: ASbGncvLDfS3EcRBkUWiNVjCtsoQQfyA/++rZyFRTPKAjd4tLTCut5E+fGlYtKM4gCX fJTKBXXoJZF2OEiG/6AoFc/h6a4mihf96qAPZuxRfeTXD/AGlitBD/U21UWcST1VJZn/zaeLj1a 6+3nsj2DpCQIa+151ZI0EflIwZbP23HUuAs4QYxQAU5yr5Ol9JNAnhrqDNcux26VTnNm4RY+Tj/ iG8a17X6irYRZyyCRe+p5Sg3DRCASam3qr963vzB2qAewx4ExS3W9tGDaVzmpOrtKu8kzpgNFE2 fdCm6qklUR3B38uthLoMHkdwqNMlOKp6CI5GvrtC2N1lmtwoxl1qPTTcgZEn1RShDEZ/Xhc2MMr FarD/hUKOt4mSvu7O/FPn1bfCXryBoH1wLaIjvd4wpyLBCL4rnL6Hz94yD7czvvxTlk1I/VvFKR zG7pzn5uzLs7GcWTfylgc6lI+PD/sWnh3NUNoo9BR+U3F5cLDvOzZQRs6qm8jb7GSZEAZDD5ioO cZAlQ== X-Google-Smtp-Source: AGHT+IFAvpSIo5Boh9uZGNRz1jnPH4zVkRyDa+XU94Z/sZjJKjAL+c0xF0VcYKBmnlzP3uQx4J36ZQ== X-Received: by 2002:a05:6000:2dc8:b0:429:d40e:fa40 with SMTP id ffacd0b85a97d-42b5937324cmr15236841f8f.45.1763474179646; Tue, 18 Nov 2025 05:56:19 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:19 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:09 +0000 Subject: [PATCH v2 2/7] soc: samsung: exynos-chipid: add google,gs101-otp support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-2-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=5916; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=p4ZObKdORDPs9HTtQcCqfM4Dt9UYXjFKiNvgoGM8eUg=; b=LgZlOadmjkQB7OdfDpvgPkVbF7pYjTLOuPDsVJbWNZP7uMGPhhsOLuzdntKh28msuquJ/TRVv i0HyigF3mGIALH+Q3JnnxQb5bAsptf+gjuhHFJ+IHOd9/Zjx4XEZM4w X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= GS101 is different (but also e850 and autov9 I assume) from the SoCs that are currently handled by the exynos-chipid driver because the chip ID info is part of the OTP registers. GS101 OTP has a clock, an interrupt line, a register space (that contains product and chip ID, TMU data, ASV, etc) and a 32Kbit memory space that can be read/program/locked with specific commands. On GS101 the "ChipID block" is just an abstraction, it's not a physical device. When the power-on sequence progresses, the OTP chipid values are loaded to the OTP registers. Add the GS101 chip ID support. The support is intentionally added in the exynos-chipid driver, and not in a dedicated Exynos OTP driver, because we estimate that there will not be any OTP consumers in the kernel other than the chip ID/SoC interface. The downstream GS101 drivers confirm this supposition. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 86 ++++++++++++++++++++++++++++++++-= ---- 1 file changed, 75 insertions(+), 11 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index d3b4b5508e0c808ee9f7b0039073ef57915d60fc..8904ffdaf9a6f6d069cc6af18a2= 4dd00a2780892 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -13,8 +13,11 @@ */ =20 #include +#include #include -#include +#include +#include +#include #include #include #include @@ -27,9 +30,11 @@ #include "exynos-asv.h" =20 struct exynos_chipid_variant { - unsigned int rev_reg; /* revision register offset */ + unsigned int main_rev_reg; /* main revision register offset */ + unsigned int sub_rev_reg; /* sub revision register offset */ unsigned int main_rev_shift; /* main revision offset in rev_reg */ unsigned int sub_rev_shift; /* sub revision offset in rev_reg */ + bool efuse; }; =20 struct exynos_chipid_info { @@ -68,6 +73,8 @@ static const struct exynos_soc_id { { "EXYNOS990", 0xE9830000 }, { "EXYNOSAUTOV9", 0xAAA80000 }, { "EXYNOSAUTOV920", 0x0A920000 }, + /* Compatible with: google,gs101-otp */ + { "GS101", 0x9845000 }, }; =20 static const char *product_id_to_soc_id(unsigned int product_id) @@ -92,18 +99,52 @@ static int exynos_chipid_get_chipid_info(struct regmap = *regmap, return ret; soc_info->product_id =3D val & EXYNOS_MASK; =20 - if (data->rev_reg !=3D EXYNOS_CHIPID_REG_PRO_ID) { - ret =3D regmap_read(regmap, data->rev_reg, &val); + if (data->sub_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) { + /* exynos4210 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + } else { + unsigned int val2; + + ret =3D regmap_read(regmap, data->sub_rev_reg, &val2); if (ret < 0) return ret; + + if (data->main_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) + /* gs101 case */ + main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + else + /* exynos850 case */ + main_rev =3D (val2 >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; + + sub_rev =3D (val2 >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; } - main_rev =3D (val >> data->main_rev_shift) & EXYNOS_REV_PART_MASK; - sub_rev =3D (val >> data->sub_rev_shift) & EXYNOS_REV_PART_MASK; + soc_info->revision =3D (main_rev << EXYNOS_REV_PART_SHIFT) | sub_rev; =20 return 0; } =20 +static struct regmap *exynos_chipid_get_efuse_regmap(struct platform_devic= e *pdev) +{ + struct resource *res; + void __iomem *base; + + base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(base)) + return ERR_CAST(base); + + const struct regmap_config reg_config =3D { + .reg_bits =3D 32, + .reg_stride =3D 4, + .val_bits =3D 32, + .use_relaxed_mmio =3D true, + .max_register =3D (resource_size(res) - reg_config.reg_stride), + }; + + return devm_regmap_init_mmio(&pdev->dev, base, ®_config); +} + static int exynos_chipid_probe(struct platform_device *pdev) { const struct exynos_chipid_variant *drv_data; @@ -119,9 +160,23 @@ static int exynos_chipid_probe(struct platform_device = *pdev) if (!drv_data) return -EINVAL; =20 - regmap =3D device_node_to_regmap(dev->of_node); - if (IS_ERR(regmap)) - return PTR_ERR(regmap); + if (drv_data->efuse) { + struct clk *clk; + + regmap =3D exynos_chipid_get_efuse_regmap(pdev); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get efuse regmap\n"); + + clk =3D devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get clock\n"); + } else { + regmap =3D device_node_to_regmap(dev->of_node); + if (IS_ERR(regmap)) + return PTR_ERR(regmap); + } =20 ret =3D exynos_chipid_get_chipid_info(regmap, drv_data, &soc_info); if (ret < 0) @@ -177,19 +232,28 @@ static void exynos_chipid_remove(struct platform_devi= ce *pdev) } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { - .rev_reg =3D 0x0, .main_rev_shift =3D 4, .sub_rev_shift =3D 0, }; =20 static const struct exynos_chipid_variant exynos850_chipid_drv_data =3D { - .rev_reg =3D 0x10, + .main_rev_reg =3D 0x10, + .sub_rev_reg =3D 0x10, .main_rev_shift =3D 20, .sub_rev_shift =3D 16, }; =20 +static const struct exynos_chipid_variant gs101_chipid_drv_data =3D { + .sub_rev_reg =3D 0x10, + .sub_rev_shift =3D 16, + .efuse =3D true, +}; + static const struct of_device_id exynos_chipid_of_device_ids[] =3D { { + .compatible =3D "google,gs101-otp", + .data =3D &gs101_chipid_drv_data, + }, { .compatible =3D "samsung,exynos4210-chipid", .data =3D &exynos4210_chipid_drv_data, }, { --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B95835A959 for ; Tue, 18 Nov 2025 13:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; cv=none; b=u1ZAw4dsvLQcLtS050MdW5KB7xrGVeJx/9Ev0MfPuW8VQy11C4XMRt1GpnqLQ4w839H47kkffqwYeT/BOf+UIyCWc7NSWzBRbDLpYIDGdBkEDG2HmKQjoWs4zfy7teCuRdQQYwPyV6ShQurLkz7xbBwpBGxsmZu01g368Pc1jLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; c=relaxed/simple; bh=AYey41JluNvIXnVAMYRQRudvFDMHByFQlXtTmWlf5rA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Aa/RjeNhoBjBYJ82e/tUrixlJRAjwfPaePPOj8r5fT455Mtc0W4gNfMzMHyYFhiH3Nxn7a5u/UqDMT1d88fNTKJXeVc2aJgI4C3P6Y7rGoOskL9mQWmqsoYCYdHVJCjA8OCtCrZjMeSDegGx/QftcnrHxRP6zk4Ym/SPdx1m4gw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EVkDV6lu; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EVkDV6lu" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42bb288c17bso1872102f8f.2 for ; Tue, 18 Nov 2025 05:56:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474180; x=1764078980; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mGSZdccmXWk8F5qnJeoPtGkKc8FpBWygh4CtyjO0Ar4=; b=EVkDV6luUWBcOPU+pXGUG01wxqRMSbPZQF9P0X9GWC5icPHQqaoQE+woPEx7O6+vdF UdX08d2RWtkGertFxWzbcAokaufgbpKb1LECFW4F9TTUnSICPphy79O4SYv96AVAROjQ b7sYWiBYbard1ot5ptdcuHoSmHkabarbSDNPFzt/4DZa1u7Vl3c8olDRdYYHJokX75Hn j8Vf86Dv/GRgso3zmT8PtfsO9VLC7ULVtG933LtePkuc5mOAuaZyKj/Yu9Bpy5HJoozS 5XJLHLT8IgCEKkOhVgs8xWotHAzZ3uTI6IadGmchtPY2PZBOg3MDWwAjG2O6NOZjAQRm SvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474180; x=1764078980; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mGSZdccmXWk8F5qnJeoPtGkKc8FpBWygh4CtyjO0Ar4=; b=WjewkkaoZDJTMAJFPBZjP0QdnQlfEkAEiGQYhyFvwO+nFffrT8RmQArG7Ol2BaISqH CqwO+1qQ4bJV/UhvIHSjEhX/lBVDzmNqHxDUA2ENaT5fo2/wEVWGYZIoz5haUkTPdiN9 SY71kwrItxS8KfNkay9S140Kp2HDw18jtOAphLgt84CAimd/xngojcEGNreMDCCVRSxd nsGFUVR1XdL8JyUjo3DjD0c7cVENu9imv6BIulptUMl56LSSr97Psi2Us6iBZ/NfzAXj +3adjJOj1PSHpT8NFI7q70DMriz5extVALRbNz6y5/S53YiCGS2vCpYdJhUX2Xyy9uok iqwQ== X-Forwarded-Encrypted: i=1; AJvYcCWsSfUN/TU+B7vOxj/rWHOYbGSS51RUzMBMgfJBnILuT0ESdYcbNecSNFAHxXSEfFK1pTF4X2hpmrfz6/Y=@vger.kernel.org X-Gm-Message-State: AOJu0YxSy5ZZJCQviWIbYyYdwD2yrqzLUc6MlApXidIB4ohhbG5IrnWc gO8PHkDVUo6vTIAKvwJuSk22GEast/zgw09gG7bDGChCxvufCb6BZqiLKwbo1RSiAAc= X-Gm-Gg: ASbGncv4GRy23vhqmN0mzFn16wSriU1FZzXamFT0C/9jq5Zy85/JU9cB0Zga1piDyqU bKekP+PTFD5t6+ib+lMCqpAjNwwQIFpkiOU1eLa/geySbHZfvZPPVA/FCNO3titFBYw78Jq+mMl f9ViY/IkJKz6Rj9k0Rftu87Gcm7SwYltXYdhETeTM+i957N+8nN1z4JHunJGdiGetPwrZ6PuT7v gXKdGF570SSCP9MQBavWj1tpoorKEdeFPuepuFHih2cNc6VHqBpEAi8yaLxr8UPcfR0EkZGSKTG EuGFQgJe91jlH0tdq9GofoPBtsrcY2rDJ7XzgXu53WD+R1jSRMKX+ewvwYiwAzOeHkfGjFubV0v e53iVrj0eafModOCTSOf66VZr5ETTR6l9eRJciBKee6M7b1pP4RZsqJ08IGTfAkQyjxGe/6IZUT 8tXCEJCK8B4JPPKcnizuNh2oXscTUm1N/LHXMrheLkKC4yHQgJaAk9J7C8VmsSy046Pf9srWKF0 p41Mw== X-Google-Smtp-Source: AGHT+IGJOqGPGMa/xpFl50AjeI6gLPwIWReT5xV4tI/TQp6aNhxWJYaCSsA7r2uIJZrDLJkG2ExunA== X-Received: by 2002:a05:6000:2509:b0:42b:4803:75e8 with SMTP id ffacd0b85a97d-42b5937335fmr16390114f8f.43.1763474180302; Tue, 18 Nov 2025 05:56:20 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:19 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:10 +0000 Subject: [PATCH v2 3/7] soc: samsung: exynos-chipid: use devm action to unregister soc device Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-3-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=2261; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=AYey41JluNvIXnVAMYRQRudvFDMHByFQlXtTmWlf5rA=; b=/BoUySuXF+LzGbF8Xi0BjukaCLCcgm542pIxGyPIv9c71vz9fpN2QT6L/bYOX6wdCuHw/i8BZ CmaqZLVmv3sDkYpUE5IuVIAml7k3WYlIgKtBidL/6Exyw7Ub0FBh/46 X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Simplify the unwinding of the soc device by using a devm action. Add the action before the exynos_asv_init() to avoid an explicit call to soc_device_unregister(). Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 27 +++++++++++---------------- 1 file changed, 11 insertions(+), 16 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 8904ffdaf9a6f6d069cc6af18a24dd00a2780892..db73dfad4e1b4fb001cb653bc8c= af8aa08d85f2d 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -145,6 +145,11 @@ static struct regmap *exynos_chipid_get_efuse_regmap(s= truct platform_device *pde return devm_regmap_init_mmio(&pdev->dev, base, ®_config); } =20 +static void exynos_chipid_unregister_soc(void *data) +{ + soc_device_unregister(data); +} + static int exynos_chipid_probe(struct platform_device *pdev) { const struct exynos_chipid_variant *drv_data; @@ -207,28 +212,19 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (IS_ERR(soc_dev)) return PTR_ERR(soc_dev); =20 - ret =3D exynos_asv_init(dev, regmap); + ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, + soc_dev); if (ret) - goto err; + return dev_err_probe(dev, ret, "failed to add devm action\n"); =20 - platform_set_drvdata(pdev, soc_dev); + ret =3D exynos_asv_init(dev, regmap); + if (ret) + return ret; =20 dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); =20 return 0; - -err: - soc_device_unregister(soc_dev); - - return ret; -} - -static void exynos_chipid_remove(struct platform_device *pdev) -{ - struct soc_device *soc_dev =3D platform_get_drvdata(pdev); - - soc_device_unregister(soc_dev); } =20 static const struct exynos_chipid_variant exynos4210_chipid_drv_data =3D { @@ -270,7 +266,6 @@ static struct platform_driver exynos_chipid_driver =3D { .of_match_table =3D exynos_chipid_of_device_ids, }, .probe =3D exynos_chipid_probe, - .remove =3D exynos_chipid_remove, }; module_platform_driver(exynos_chipid_driver); =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C89035A95A for ; Tue, 18 Nov 2025 13:56:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; cv=none; b=RIyi6GSr906w7zrOGBpTnP/I8zW7Rm2s4atBWhgCJmAenBObnO+e+YUDS1DzImknXTGYUHfdyBmR0dT4REiuu+b3XL0aCLei2ajpvcYrohjefNwm5D+DG3V72h7JUqN85qShBcUmln+rkA23CXd1qf1rAJjQQfRaXGIn8oasUrE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474185; c=relaxed/simple; bh=gyjJc742Xp7x3M1wMCcAQq2+Hzs2mbWAJ0525DJRzCk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QRMOtMi/v2AzjaD5YFpaf2O4AtbrtZGSEEL0DRGrSYLjJulTLXCk35uALBkhSEcrIA2jWQB4ERMJfQMMAoPQicJoV4DmrutVTN0+H44pCXa7fcvJu2ThcwSpMIP7c5IV+GILjUhoBpPn5juHlFxn9mK9dWZQX8RqgL29L+njjxU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YetKHdA6; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YetKHdA6" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-42bb288c1bfso2172140f8f.2 for ; Tue, 18 Nov 2025 05:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474181; x=1764078981; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yKYlMIfAWjT0Z4v8dS+9AJxviT6d1hSBxbFdrwjdNQA=; b=YetKHdA6GH0FOfwx9gjwTTdvxpDpycsbuDIqzcNHt6H8q+azTd1y9RDDcYHVjgXTg5 4Ql1hz1z5Mez8WQA4XWHkQGqwE2rgkZX7bSpHNbsVkG1B1/6bzyGhu+KxizNZujzZ2cU Se511FBVsHA6nsEtSahMaids1ISA/9Ky4eXK/b1YP/dQORKkXg26irOVvnfWds3KQglV 7ySkimkP4GZMhHVpOYKuxuxjSv9sw0CXl409Z7yS85PJoTiLLP+JLVybJP4lSabWeuY1 K+Lvsp3enDeVl7k6u0QAdWSjoeT0U18DtDBmLMgptSMnmcDQDUM9Uth5k+MPLGWLDrMV bBow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474181; x=1764078981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=yKYlMIfAWjT0Z4v8dS+9AJxviT6d1hSBxbFdrwjdNQA=; b=CQmDY/Gn76PtDfkdIHTxg58A78bTrEWIfez7G0v8ujnmhuGNp8rPI/96KyhUBLv817 SNJ9pYLr4vPBnguLdMAsduEbDbDQYFZ+HDkEUUXRGz9riUBs24BXlImfF16GymWqyQJB 1nRV6hRRRa56potwvTOUi9r17AUkKXBcJ6wJyC1gdSPtKB0An5TdXMESEjjfOx7MSIzv LFKx1g7fIkvYGPNeziyBKTWmdrxRI4xVLnLMrrMbQzC3f0nZbzZb5lo4GjNGcV/QjDcp MUJ/0xc8zThy+uzLdJ1/qYo6uktP5mJSc/RwjpxnvMnOr8V2lZz4eSn1gUBe8a3nFdLf mY8w== X-Forwarded-Encrypted: i=1; AJvYcCVL/SJ/J3xlAWTpMyCP7GY+b9nSTNkYNnU3kCUUKtuCbG+sRU4jMUMYs9Sutdn0KtDMa9+MNbqe/COxdNU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzti9CMYUxwoFZiBUBZtrhzVxBnhYybfOAzo6t1guT+6dZ2c0YY vxAM6w1rWXtwRtxuNOios665tE1vwCGeUc2fM/yTmiFpOuHPPKr9q6Yi4/DCEei2swU= X-Gm-Gg: ASbGncu3XbJlEVI3Qyl+KdtcA7oYXo9dcKr+0O7vBbMVTnWJOdpdxDOyIBopho7FJYO V2hPD5Ddu14yae97bYB1pQzEdFeN2NjwC+VHAzt4NjY63aeKFruOIlRA0HqqRerIFIg9mJTKYoi IS/MALOlfDvwI5dci/U6nWO96dvVcjavGWvUVTPLnNYUVR+sqsZ1CYFWLJy8SQOJpVe1drPDuP0 Cx3SgnWEu6H7ma7OXHTuLlBppyyo7VvVEn71DlVPyGLqfFGZG0z5bLokvCFYhF/mRjowzSCfNP6 MDANpuvuaTSMQFMbYmIFNZHuKI7SrW7U8hzGw7rO/3gcwDXboJcvlNWFZHpo+68/NqbIkG/eyHt vIK3S72Er6hQbtSbJG4l8MRz93TCF2ouaPC7ggqOff7gjxf30b1uLUrvF9IOGXm8DbcwKClKKoY D2eZwBZvvF7gwwVJ6K+BW8qZQoYIYf5/a7in+BJGdYg2Am9gpPWQgEjaHXScrKoI3ErY8ZfDAYO F4L1A== X-Google-Smtp-Source: AGHT+IFLEPtny/4M/qrsELeJqriFmtfSC8sisj+iye0XhMUpxvpy0r10rHp5Vjj+6+CEqyh5vAEHSA== X-Received: by 2002:a05:6000:186e:b0:429:cbba:b246 with SMTP id ffacd0b85a97d-42b592dccc4mr15022527f8f.0.1763474180971; Tue, 18 Nov 2025 05:56:20 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:20 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:11 +0000 Subject: [PATCH v2 4/7] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-4-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=3298; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=gyjJc742Xp7x3M1wMCcAQq2+Hzs2mbWAJ0525DJRzCk=; b=Dkbia94LbiSf/CBO+A1kJVBcYCRosgXFGkXFNUhm+Xo18ZKD9i0afT0aoz5prjd2k8c8oWq+O tEsgaKaT06PDq+XRCKwTR2CS+JpUmPQ00PQ9Th9PlQNtlhuRbjlUreJ X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Use dev_err_probe() to benefit of the standardized format of the error code (e.g. "ENODEV" instead of -19), to get meanigful error messages, and for more compact error paths. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index db73dfad4e1b4fb001cb653bc8caf8aa08d85f2d..e7dbe1bc45d6af58527125f512c= 0ff22c03a9629 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -87,8 +87,8 @@ static const char *product_id_to_soc_id(unsigned int prod= uct_id) return NULL; } =20 -static int exynos_chipid_get_chipid_info(struct regmap *regmap, - const struct exynos_chipid_variant *data, +static int exynos_chipid_get_chipid_info(struct device *dev, + struct regmap *regmap, const struct exynos_chipid_variant *data, struct exynos_chipid_info *soc_info) { int ret; @@ -96,7 +96,7 @@ static int exynos_chipid_get_chipid_info(struct regmap *r= egmap, =20 ret =3D regmap_read(regmap, EXYNOS_CHIPID_REG_PRO_ID, &val); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, "failed to read Product ID\n"); soc_info->product_id =3D val & EXYNOS_MASK; =20 if (data->sub_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) { @@ -108,7 +108,8 @@ static int exynos_chipid_get_chipid_info(struct regmap = *regmap, =20 ret =3D regmap_read(regmap, data->sub_rev_reg, &val2); if (ret < 0) - return ret; + return dev_err_probe(dev, ret, + "failed to read sub revision\n"); =20 if (data->main_rev_reg =3D=3D EXYNOS_CHIPID_REG_PRO_ID) /* gs101 case */ @@ -163,7 +164,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) =20 drv_data =3D of_device_get_match_data(dev); if (!drv_data) - return -EINVAL; + return dev_err_probe(dev, -EINVAL, + "failed to get match data\n"); =20 if (drv_data->efuse) { struct clk *clk; @@ -180,10 +182,11 @@ static int exynos_chipid_probe(struct platform_device= *pdev) } else { regmap =3D device_node_to_regmap(dev->of_node); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(dev, PTR_ERR(regmap), + "failed to get regmap\n"); } =20 - ret =3D exynos_chipid_get_chipid_info(regmap, drv_data, &soc_info); + ret =3D exynos_chipid_get_chipid_info(dev, regmap, drv_data, &soc_info); if (ret < 0) return ret; =20 @@ -202,15 +205,14 @@ static int exynos_chipid_probe(struct platform_device= *pdev) if (!soc_dev_attr->revision) return -ENOMEM; soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); - if (!soc_dev_attr->soc_id) { - pr_err("Unknown SoC\n"); - return -ENODEV; - } + if (!soc_dev_attr->soc_id) + return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 /* please note that the actual registration will be deferred */ soc_dev =3D soc_device_register(soc_dev_attr); if (IS_ERR(soc_dev)) - return PTR_ERR(soc_dev); + return dev_err_probe(dev, PTR_ERR(soc_dev), + "failed to register to the soc interface\n"); =20 ret =3D devm_add_action_or_reset(dev, exynos_chipid_unregister_soc, soc_dev); --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59B5C35F8DC for ; Tue, 18 Nov 2025 13:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474186; cv=none; b=TsO+5RcdeG4ZpFfpATdDYrK8cM9hNI/Lo9q5YZXmYiD+2p/UWkqq68qSKM8u7NO5KggetIrzLhV+E9oml2o1wxmtvgReFwqB7F1jg1yzitVeRPjfQGBFk/k04U7hlf/uVj9B+gBbg+mC45wA1rNGr4rzZl+WtsvDrLxY6Cj1irw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474186; c=relaxed/simple; bh=pz2vFfFg816pMsi1tjWB3WxH9y8mdbvU/JiEbCPeYpo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sOu/Ew7rC8QayLlFq7Bz6rS2QQzTf+jAjsggZDjdPrfkNlDDqi2LcA7eV5k/lrhMI1Zahn6HTShjehF7W9axmtL9t/oKxzdNirqoBNRDoasj4PBw4VAmQGW9fPuUnhrhGKtrvEfzn9I+UA5XBL0bEJM5vhVmmOXYsbecP9I9mnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yycJiRTQ; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yycJiRTQ" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-42b47f662a0so3186193f8f.0 for ; Tue, 18 Nov 2025 05:56:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474182; x=1764078982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3gwKtEZS9ATY9MzLxT6ci8qfNsIOwy9wsbqfh/IjTRA=; b=yycJiRTQGrd7iaJAk2A1oZoTStUecZrnRSxr6lKZemKVgE3Jy2W+aH9tNYsqzTxRaw JbAo7kuNALUojEFEqpc5MupSg05PyO6RaER43CHLKfUG3ZZoOjAqkZpdUhSQWTiobLS4 X0QcuARxWCB1ENfshU33/t6CsG3dJSA/fnMdXOiwW9tCN5PKWyD5yFuv869iFwbo4wHo 4Y6836ED5UtEnIMfIZuQclQVnUe+BrU/M4cIdS0Vr7GKl/wi1fSfhkQAk8L5BAEbjU01 zX/B8Rm9bA3FolGvL2UjG8Ln/lv4jUfyc01dyHCtHIMcI5H3+dBn8reyu6+jfbp5rcqz 6y5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474182; x=1764078982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=3gwKtEZS9ATY9MzLxT6ci8qfNsIOwy9wsbqfh/IjTRA=; b=gWs7VO0pmj1omkC2IQOoVpvj/uWakdTIvKu6TLT1+1ExMvY7BAERhWrKYcxRva0qE3 GjoSl+oifXwXmR9lZU8IzG4yV3WoInRmVu1cxypA5JJ6mkzQqVmupDd2Mw+OGybnkh/H iipzCkmLUGIk2ZAHDYcZ3O21GFwKxlresyf+I/Bq6MdNBeYQwRz13Q80h0O5iDodRXEk eBAEASlUWq4ZLqagD8BHiWnjC9pZrkSHRFCwlzQ2G1GD9PoI11fn78z2u7JwQamn/wqy mmqFLwarhWCDXTDxP5gOLwV0FbN2x8cKz2eEWEk812gW4bz8RU+l+dabZ3BQFHP50qvQ 9m4w== X-Forwarded-Encrypted: i=1; AJvYcCVrzfmYNclKCK43+Z6Xvc8wctcW4cO2sEXFiDzBCyHRRo5vEsmWoGaPJEPbySSWPjy+l6+/xpk93icCQig=@vger.kernel.org X-Gm-Message-State: AOJu0YzL1MDm3mfaMFhwzlsXHACTZSbeuQ2ac2DWLrfo34p2hoMCeAkf 6OLeqeX+EAhzVnsElKiUtuMMewLz/JO24/aVaxhJ+eQyncXXLvYvAIEd0MHqM6c1cDI= X-Gm-Gg: ASbGncsBICouL3/pjU4vTze9zA8SoqD1b76mEIQscVdlHlMA5nBCFbeihwYt6MQHKb7 l8lLYqJLmEkaX6vyC0NzRsnRI6KuRBomfGCgNYyOYIdFAMmQKGHfYy5YCgHWULNa+d5IoJIeTEF 6bvHyLxo3Eh10euI24GD/WkLJU/5Jvsnu8bbCaR2H5E0+GGzrq+xfLWspvBhDGSKd5/CwHkcSyu XWZOB2zBmpJ1e+jCOMVHBiX1yaow4/D4Z5P3FXDp4vmBaU9D1ZDq1WgYM4uPlu1HJaEvptZjp4E HNN2CxJUoeG1zvLcXaK+1JfQyQ3IEDjHKjs2CwD5FFPBtgiFPNplp7SrRCjlEnNmEgu7v+u1RS/ /jkP0jPk+N5cKqmiDiGq2jYCyhYqowW5QXksp34Kx87o6/HWCXMZseHqaF9icGELfzld0FN1qbJ LgSeCjAjgBrIb6anb6Khd/UpN7m3WhxXHlGKCiDpyRwKAN5R49SXJc96w0mZYTxPDayqHB8RmNu rGnIg== X-Google-Smtp-Source: AGHT+IFa8oKgKktdspxmJlkG4/viJN34IUfCpO+WsyI4R07URExLBajDeg8RAjbULRVDTx5x7IMutw== X-Received: by 2002:a5d:584a:0:b0:425:86da:325f with SMTP id ffacd0b85a97d-42ca8cd213cmr3206208f8f.27.1763474181596; Tue, 18 Nov 2025 05:56:21 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:21 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:12 +0000 Subject: [PATCH v2 5/7] soc: samsung: exynos-chipid: rename method Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-5-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=1394; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=pz2vFfFg816pMsi1tjWB3WxH9y8mdbvU/JiEbCPeYpo=; b=wh9h+nJ2m38labT5RhsxjuLGzrUVsY6uL+fQUguC27NBHoTBMpaM1lMG18cS30VkIg8IBfNdw 8Bp6rNoERAVBlMoO6MNx4mWs7Y7PSqel07YFbs2s2TXzaQRhQaL3WaF X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= s/product_id_to_soc_id/exynos_product_id_to_name. Prepend exynos_ to avoid name space pollution. The method translates the product id to a name, rename the method to make that clear. While touching the code where it is called, add a blank line for readability purposes. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index e7dbe1bc45d6af58527125f512c0ff22c03a9629..7ed7f44b6ae5357b71fee3994e4= a4265aa870d41 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -77,7 +77,7 @@ static const struct exynos_soc_id { { "GS101", 0x9845000 }, }; =20 -static const char *product_id_to_soc_id(unsigned int product_id) +static const char *exynos_product_id_to_name(unsigned int product_id) { int i; =20 @@ -204,7 +204,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) soc_info.revision); if (!soc_dev_attr->revision) return -ENOMEM; - soc_dev_attr->soc_id =3D product_id_to_soc_id(soc_info.product_id); + + soc_dev_attr->soc_id =3D exynos_product_id_to_name(soc_info.product_id); if (!soc_dev_attr->soc_id) return dev_err_probe(dev, -ENODEV, "Unknown SoC\n"); =20 --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84EA6361DAA for ; Tue, 18 Nov 2025 13:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474187; cv=none; b=Q2/njh2MvkJ6a8HWmlXnjgHFRbgNca0hHef+HHgU17K4kxWnUi7YjY+OmAe2dQwTC6z/oSp731JLL1mRwzac7AHjmWHR5uWGD0EaVV1EajyWTr1NyVC9F3T2EETjBqNAwIc+CB4FqGoZZkIGbSZG1t+Hx2fjfzYpsluVcIuAU7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474187; c=relaxed/simple; bh=TAfEcJT+KP/gybnFuuKe3YB9Vr01lZOY0yg12JjdBGk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=j3/xgwFL3EjgPA709amjlW7InOLJuNLJmjf/fuxsx41UwZfGE/de+2z5nLM3hpYZTxUErzV0aZGFrS5eiIPQu2eFNbhyT2ne03dE5adPBAnwblHR9EaSLzaoi4/r/9kQbZz3uJML8GJFnNQUcTYXTU8jePPekIzjjJsD1HI8pdk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zjkt0vKt; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zjkt0vKt" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-42b3ac40ae4so3350699f8f.0 for ; Tue, 18 Nov 2025 05:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474182; x=1764078982; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FdDgG0OEtr9VDO6FlrjC0lVVwasyx4VrXjolMp7eFK4=; b=zjkt0vKt/lzBxvLlAIzxTj5aQXMQeLFW5fAMmPBjUTgMlkMlj4nW66sv2bPWbQn5si u01S7i+E/gYRbNXcxXtZGKGUVK4mI9SLi+AIGx+16iYsNRG3nDDPKIVlXPj2rn/M6exH JrVNRdEEfh/6IjevOB/8DI6K3AvoAa2uh70pJWV8idL3C3qVkwnj+MFelUyohQq42/Qc MXwUnOw01pxMNMKp9x/tVj0Stj8P+UYijF/21iozL95dwgR+inQteCxtBHH+cJtgj/of o5ur+LUu89Ms9c1flA1kDeMWih2qJREEhP14aaYaz/ZGtxkeSyw+mySCLBEMgEt8IX2m FsdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474182; x=1764078982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=FdDgG0OEtr9VDO6FlrjC0lVVwasyx4VrXjolMp7eFK4=; b=KyAB4ve6qQwToFqjiuh99Gd+wCxYH9mMnLbIFgVeWjfQ9X5LphHXujdR4QG2IBxFez mDMnH9aP10KER0cxer000HrlOKQlkKDQONoBkC0WbYudkNmQzdHJ16doRqTfbMopuM69 C7Kbx2s5cm6RpbJbrHIhbRbS2anQp3dAO+7/0H5U0QPxxVia3rjgldnI+FXNJygUV0cJ 5bOPtqxRyUm9JsW4mZ7lOiyqdIJNpR0pH3UbtI/l1eP8bdC6YKZaglWK9P2SOUC8Bp36 0Se1CJ+4qSRxXL6EGLEHDhSrnhPPlc35CyFSCicYYmGsUXV6jYfaWM6C52QlUPLELWsl /neA== X-Forwarded-Encrypted: i=1; AJvYcCXc37ADvaGWbNZ5wM7CwWn1JgJAlGUev48YXkWKvPaATczZpayPVnnLQ4goDfZFrjSLMWhqBrkFcFX2sxg=@vger.kernel.org X-Gm-Message-State: AOJu0YxByyCJW5WRjm2ID35fwi8J9Y2ILNASeTFyib/X3LnqL0a4btdt RB1FcQWqYRvm3BQrg25z7/jTG2eJrLSdrlZU8Noo3AZJvNgg6z994pTfQveD9tv5sug= X-Gm-Gg: ASbGncv7zpp4sj5/yGyrXXH2sbuJtBwZBT5UjB1fHYX3oeWplpHhe9DwuHX7o8uc3QE 3SvIX8AKVAZsWX9uL1yqq4Nhmrtyt3Y5W2F9IWOhjuNAjZS27PKZ8E8wpt5qJrt8Je3cDIl48zj SugGbX2S/fKgY2z4pETAaoSxipWUVPS00cIsPT6IZ/9l4y9svBhCS5fPbterWWyyXHy9WBZC6ij Dedy7lTJPiKxb3WsVuR0nJUMzwEW+SOjd9OIb96ECJPU6R9w1vWdC1Jq07+nozvgoXnRmqgA7x5 jG6TQc4tqHxEUWa7jZny+F97oICrKnAmaupo48Ki8vAmHcbyKdW9YcrDzW8G3aXghXkLlgVUeX1 TTjOiTpQjcrJLVBPMOf2k8d/AC0/07DPHNxjWH18/mbTUplC+oIf+bqfWRoNP/fTZq06+b6sdfg 6TI6IZCLaOAiBsxZhrmfcqNVdjhvRhepiCTNbMlUi2z3HL2ycfwT8HfWNRgIjXv7YWTYuJ9MxRS FT9hA== X-Google-Smtp-Source: AGHT+IGfMObgF/k6EWKW7rlaiPXKOVwaG77gXtBdH9U/El9uEDye1QZpAt3VR8koJaZq1/x7ozt+1g== X-Received: by 2002:a5d:5f49:0:b0:42b:36f4:cd21 with SMTP id ffacd0b85a97d-42b593742e7mr15653326f8f.40.1763474182223; Tue, 18 Nov 2025 05:56:22 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:21 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:13 +0000 Subject: [PATCH v2 6/7] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-6-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=1017; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=TAfEcJT+KP/gybnFuuKe3YB9Vr01lZOY0yg12JjdBGk=; b=acfWU97bc9wGkUoK1rXcht5oTK4PtuVsKYgoVLSw2tRBT55ufu6Iai72t/xeAp1NwaT3i31gN wHgEFrsKmGkCnjVfQYW1FIDIJ4bVWlqAyFGVpGVfPJsZKyXYU23iwUX X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= The SoC information is exposed to userspace using the standard soc interface. Downgrade to dev_dbg to stop polluting the console log. Signed-off-by: Tudor Ambarus --- drivers/soc/samsung/exynos-chipid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/samsung/exynos-chipid.c b/drivers/soc/samsung/exyn= os-chipid.c index 7ed7f44b6ae5357b71fee3994e4a4265aa870d41..e1b939e526cea9b2069da6e37a1= a16950ce5ac44 100644 --- a/drivers/soc/samsung/exynos-chipid.c +++ b/drivers/soc/samsung/exynos-chipid.c @@ -224,8 +224,8 @@ static int exynos_chipid_probe(struct platform_device *= pdev) if (ret) return ret; =20 - dev_info(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", - soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); + dev_dbg(dev, "Exynos: CPU[%s] PRO_ID[0x%x] REV[0x%x] Detected\n", + soc_dev_attr->soc_id, soc_info.product_id, soc_info.revision); =20 return 0; } --=20 2.52.0.rc1.455.g30608eb744-goog From nobody Tue Dec 2 02:43:44 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 563B535F8A2 for ; Tue, 18 Nov 2025 13:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474188; cv=none; b=NevvLCSSC9dBE3g0ETpcx+uVGnX4OotJzr184wVhPBkMuwBvkLgTSJBwLu0YrPj8sAIkgCk9V4zuwnt4TAfbVqf+mIqkX2DIu2zj6Zffph8uG5zlQbe3GAgfJXPc6Z/FypdpUW/E9wURjXFC7sfMBMbxLzaSHOMh0dzvrmgvpSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763474188; c=relaxed/simple; bh=bpikWqcBMsiIMl/jbWq2QmBbah7xAa4FAfmzSq15MIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=C3ko2KR7hDrm0bP5zO3ctOFFy3t3T3q3D4sryzvyuPWZYbzGjeSX99BQRviGlUQ8QYJIjPFxqVOEfFLRfVHUlhxmi7k2CFCkHESyAXfi4EV9u1Xk8rM+DMD2VZGPI6QmElFBUODZ3XcBCrsmt4K5d0L1kUEYZHHJO76tronn+gU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Z0af4GzS; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z0af4GzS" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-42b32a5494dso3296706f8f.2 for ; Tue, 18 Nov 2025 05:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763474183; x=1764078983; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=A/NH+ihGTI+pHubvmXFI57IU6F78/DwM75gJfoYXgOw=; b=Z0af4GzSfgWhcD+p4/nJUxlG7WTRimOgYFd/FeaXyJmbZt8wOmgi5xvGyQOz0hXEBc 5c+Y+yFPcvluuy3H7ANN8SBfxRoJ4BiIhwK3Wsdsqe9dIbRWyMaowwxC0q0DOCs4hsyS QZX+rgd4pGfW1OyiyCzD9DU3T5ApXPfQ49R7vjk+rmWlwuQBFMIdHLzRRVtTpt+jT7gR avK79shS4MTW+7m571H+khtis2sBsxMC+8hHBHJ1wp+WVGl9CogLWcQgh5q45Plf/DX9 BOrC18oQKmlzs6C0+andAfpjADzbB4cDKGboLYTb05vr5LbqHBGX8dd7kT6wmYFf0S67 +lVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763474183; x=1764078983; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A/NH+ihGTI+pHubvmXFI57IU6F78/DwM75gJfoYXgOw=; b=Z3EBgnTJP/3j3ie0K8IcFDG4DO8itRSsTooQBkSO+s1b0tonk5lQPfZSn73gxP2gQg rUtfOF9FD+vz1Mx4yuTAvqQ1BVetMK/PtaoTp7oCKX8Y4oqXi5Gt3AXcArrXOOaTGFD7 +IXSnlwv8oaOjY3wYlHigLY4td1ngl0YWNlGto/5U8ThbNSke1j3+fpcpbJaa1Z/qCZv 7L2YUdAUZ5WvsA2cckrU1afsh8vbfgr+ddqnXVyfPfC5D1s8yVWoog3VEB0SHEcLbtVf QltkouDctoEAhKvFrT7QIJQmQNA71oxWswkAxsDKOPzy22bfPtJLWumhaeWBD1CvK24y 05/Q== X-Forwarded-Encrypted: i=1; AJvYcCUwXLfCHjLkX6zk1clySAsP+g5vwA7ZqyEG4eVzh7miNRNXeSVPNYqXP5sVq0SHa0J8yw9BW1n8y8gZicc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8jVRzTDhIj1HyJUUjd5BFH/pEHLOIcZrfF85UYtbvQ5Rs7Dhl 9zxCpy60cY8hhSaYCNITXymWVz7UTZ0m+dysKPvsaJDqvTk640M32/KPfp2OzT91nTk= X-Gm-Gg: ASbGncsulLw9KikDVr9IG3DiFGNYFXsBi8lGk83sEj+CYFh+L8DUAgEtDrNcbjuhqGi JYArDmCUcMmlvrskEh+AafYZd+UPvM9uNSezMPwLVmSAnHF5AvSL4zfj2IolIVRLZfvkfWqDNSm JpLl78n8IXFnc2YsqB8h7/XGrxq7m8l2QghT6LWHoyB11Hyg3JlGAnRJB+31VZ5ZjgytJanXT7w lVM5s78nRedJAtz33c7vCbUIWQJjkkM+mKHAamdrXRhP16Cea02lfUT+gwgCTPcCPmFYJQ9Cq1P PUiY895LMSrJ+fkUh1+pYQbW9Ur5SHdYkjKu8ZAa6IeMuF4YwhVKuxh94lxky7Xgmyr+Ucaht/4 VUhJy+RaNBKAbLA23Of+0jEQCCdowAuvKTjWZ7J1zkwHc0fhitG7qAjwSZQfxcEv1JXG+ThtItf bE3bgPAGI8nHad8HoO4tLqS4Y/IYgG2Sv/vTwDi9wY2eI3w9rfDwxnkq7dQ2FsvyToqK09uP6KC smcbA== X-Google-Smtp-Source: AGHT+IHMTuoXSa5b/I85TLgO75MjoFjkVVohZVJUHjTj4z9Z02iCD1czvc9CTvoOMfIKnhdLi+Ctxg== X-Received: by 2002:a05:6000:644:b0:42b:3e20:f1b2 with SMTP id ffacd0b85a97d-42b593246d6mr13598497f8f.4.1763474182903; Tue, 18 Nov 2025 05:56:22 -0800 (PST) Received: from ta2.c.googlers.com (17.83.155.104.bc.googleusercontent.com. [104.155.83.17]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae16sm32728666f8f.3.2025.11.18.05.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Nov 2025 05:56:22 -0800 (PST) From: Tudor Ambarus Date: Tue, 18 Nov 2025 13:56:14 +0000 Subject: [PATCH v2 7/7] arm64: dts: exynos: gs101: add OTP node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251118-gs101-chipid-v2-7-e9f1e7460e35@linaro.org> References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> In-Reply-To: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: Krzysztof Kozlowski , semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Tudor Ambarus X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763474177; l=968; i=tudor.ambarus@linaro.org; s=20241212; h=from:subject:message-id; bh=bpikWqcBMsiIMl/jbWq2QmBbah7xAa4FAfmzSq15MIU=; b=sGizZvDLkNesCQsmcBtCebaKnu3wBtFVyhLh+rpTbGIRZoAB8h0gn5q//8UvrhTXEduaucJCA N2W+Mx34ojOCfvhbdAC7Lo9YW+xVqqJ32Y5MBNgEch+eIaSOLRmNfoE X-Developer-Key: i=tudor.ambarus@linaro.org; a=ed25519; pk=uQzE0NXo3dIjeowMTOPCpIiPHEz12IA/MbyzrZVh9WI= Add the OTP controller node. Signed-off-by: Tudor Ambarus --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot= /dts/exynos/google/gs101.dtsi index d06d1d05f36408137a8acd98e43d48ea7d4f4292..4be983d4e291b3afe3530fbea01= 63f70c1a74671 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -571,6 +571,13 @@ soc: soc@0 { #size-cells =3D <1>; ranges =3D <0x0 0x0 0x0 0x40000000>; =20 + efuse@10000000 { + compatible =3D "google,gs101-otp"; + reg =3D <0x10000000 0xf084>; + clocks =3D <&cmu_misc CLK_GOUT_MISC_OTP_CON_TOP_PCLK>; + interrupts =3D ; + }; + cmu_misc: clock-controller@10010000 { compatible =3D "google,gs101-cmu-misc"; reg =3D <0x10010000 0x10000>; --=20 2.52.0.rc1.455.g30608eb744-goog