From nobody Tue Dec 2 02:58:23 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA7334D39A for ; Mon, 17 Nov 2025 22:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419620; cv=none; b=oTKdDJJVlJt2qfel6Ep/YQtm7wFJRVWVNDyCmH1Q7ZN/i4X4kJveKZSQre9oqyfveWLE0jwg5QDQGXTL/RhdgcRlrsgolkXqW3y4gYBAfvRvhcvhNvJ/ccgvdDbfcWhXHTv2WCScbd2Q1EenNCDCLDh6iF9R6ahfTGu3v2lqbbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419620; c=relaxed/simple; bh=jA/ZHBrEKOSQVARcGtVcJs40DXIXWEQr9YcWzhSwWyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ntTPB/V6SJ+68TemPyLC9Z4+CwxNPFCi0JBjJ8ftKfm0w4ivwToykqNokbQhB6faz8Wnlw05wnQBz7ACeNoj2obSRutuJ4uzTCknTLiyultCi2tprfH+1exSz7NReaJ5peHSCmWcvwLHztRMvblfcSmfxyLHq4384X8DNRXq//U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EZHig/C0; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZHig/C0" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b72bf7e703fso805848966b.2 for ; Mon, 17 Nov 2025 14:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763419617; x=1764024417; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kvi8PD7ux6OLYIZX+/H0obhuKo5+FvClrvPgKMpP5Nk=; b=EZHig/C0PhAb0ljNeDdkNanY6rPpOe748w8t9EqH/H6SqV3xAuSV54IkKgsA3TcPSw BgQwqZGo0bClxloM2kMaPdoUP9xWHSNozN78/Z0JlhLfS56VGcJ/5zCZt5Kj0EEpcC0B GLrlgPSL+HAlbxi/tUyJTUVkuM1Yb9R0v3fz6eRIWNQQiPjm5Jg8jZkSkS8a64MhIcmR e4K35Hgrv/twZ74t9ySJwDk6vxDhInV465IpIhSGzjP3p9DKKi0lwe+qk7SISIwQsJes Ftc8yMx/mmk+TZXHXHE3xe7pQ+TyE2BczxwhIQ4zPFh/0pJCAyw3+THPCEVDQP4BYFW2 JdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763419617; x=1764024417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Kvi8PD7ux6OLYIZX+/H0obhuKo5+FvClrvPgKMpP5Nk=; b=hfy3q0t4/6+08GTYt1Wt3165dfQaaifzzULcuzSXiYQq7glVqf7GVmEnHBjoAPNMIk JGIAVrdXydMTHpwvn8ZaytHe3YSacwWVw1LBpB8bxd8c0WVHTNyW8LdR5QG0Hbp956Al CeAL9UMP8X0D85/89i5CXyK6FyuXyqI5Hgj1s5KKIdWhkMhVxTekBrOvrm6SWAl749F/ BDN0UjVc+A0h4qEfgNQXbRqSIntRqO9ppYl0jzo0gc92pnMzey5fBk2nSMh4EAwplMLd cko2Di5XwUwwIi50BLB0K/feRtZCjfz7yDvj7TavFFqCugQgdbazgV4+K6FZAwJejbAi 7Stg== X-Forwarded-Encrypted: i=1; AJvYcCX64Zx6OKGxxtGiyoRbXGG0ic07pH/HWpQGLGFXyCmDoS83f6gjeMedIvMJdnEu6QqW8EvEGvGLBDyvcq4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc0TH9nd4ezgAjSbBCKtBayR0ZJnU5MD+ZrIjWtlgMsfjzfVKv xo1OKFNOsfcCzeReNp8rr7QudKSmbSvvplXL3Yd+BnX16vTsQ58Ma5E= X-Gm-Gg: ASbGncsfWXc2NTuPZOSHJeSWc7FI39MdLl5kuKzh7IZ6DfasMIxbX0IBuM1zLfupiPY rqxPCI4IteQJCQ/AUZw2w6otfxvLDBimN8vPzs8la3xCw7zt0YS0e2kZ4s08kO/schDlGJzUYgc vIIysIrtImlULOpG9VOcWGwF48jwFxAC+x24Hn66OR5i6XXzsEsGUWScfZTr6bm+5WrolXBlXki 1/aH2tTPBYs68lHrGAO+Mfo1jBl3qwgGxvEI+qqYjlNGS9VeFJO7QlgHHYNyoBZWoYm4jGuSmpl uPNYS/qx7MPOyEj+O+UPoojLOGvipfuwqwSO6oGnwLfY5Nus7E/io0NmbebWaD56WH1cbqWIupq haHbpmiRFewDVyyA02W71dlBV00H5HR2HW2wVMik16wZsH6ceyCT0hns7y33zgB0uTmBbxliwmP 81lQx7P8A6DwZledVfJYmCGFmPTE1zcnLfQ6RQpVmyXhMY6E8bdbIuZK7x3zjC2KUW/h9m X-Google-Smtp-Source: AGHT+IES8z9W/ZUewPDopCjp1qbQPjkzW7d/3SgBKJxsPR6cY33LGwmeBi3Hmms3epl6sy2024347A== X-Received: by 2002:a17:906:fe43:b0:b75:8b9f:de3a with SMTP id a640c23a62f3a-b758b9fe481mr127507866b.59.1763419616710; Mon, 17 Nov 2025 14:46:56 -0800 (PST) Received: from localhost ([2a02:810d:4a94:b300:232f:6d66:f093:4e68]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b734fed9e9fsm1179130666b.69.2025.11.17.14.46.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 14:46:56 -0800 (PST) From: Florian Fuchs To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , Florian Fuchs Subject: [PATCH 2/3] mtd: maps: vmu-flash: Fix fault in unaligned fixup Date: Mon, 17 Nov 2025 23:44:07 +0100 Message-ID: <20251117224408.498449-3-fuchsfl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117224408.498449-1-fuchsfl@gmail.com> References: <20251117224408.498449-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use kcalloc() / kzalloc() to allocate the memcard structs, instead of kmalloc() / kmalloc_array() to prevent access to uninitialized data. This fixes runtime error: Fault in unaligned fixup: 0000 [#1] at mtd_get_fact_prot_info. Signed-off-by: Florian Fuchs --- drivers/mtd/maps/vmu-flash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 53019d313db7..d0793f1b0fac 100644 --- a/drivers/mtd/maps/vmu-flash.c +++ b/drivers/mtd/maps/vmu-flash.c @@ -609,7 +609,7 @@ static int vmu_connect(struct maple_device *mdev) =20 basic_flash_data =3D be32_to_cpu(mdev->devinfo.function_data[c - 1]); =20 - card =3D kmalloc(sizeof(struct memcard), GFP_KERNEL); + card =3D kzalloc(sizeof(struct memcard), GFP_KERNEL); if (!card) { error =3D -ENOMEM; goto fail_nomem; @@ -627,14 +627,14 @@ static int vmu_connect(struct maple_device *mdev) * Not sure there are actually any multi-partition devices in the * real world, but the hardware supports them, so, so will we */ - card->parts =3D kmalloc_array(card->partitions, sizeof(struct vmupart), + card->parts =3D kcalloc(card->partitions, sizeof(struct vmupart), GFP_KERNEL); if (!card->parts) { error =3D -ENOMEM; goto fail_partitions; } =20 - card->mtd =3D kmalloc_array(card->partitions, sizeof(struct mtd_info), + card->mtd =3D kcalloc(card->partitions, sizeof(struct mtd_info), GFP_KERNEL); if (!card->mtd) { error =3D -ENOMEM; --=20 2.43.0