From nobody Tue Dec 2 02:52:28 2025 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D9CB20C00A for ; Mon, 17 Nov 2025 22:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419617; cv=none; b=WZ+pcpGriPuzyldbkQqh+1JGxrGiCQmmGuNaS12BbOjPtmuw79VN7FZ5D61te2embFGjjc7o5H3UcKnJC6BrCyarULtWcxLw1sUBShkWpPiSPKtg++I9R6Lca0GOxEPGbu3hx5tmXav2Ehtd7Y6Wt0M55LoVM6fQMKO0c8viPPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419617; c=relaxed/simple; bh=U80ZMZgaS9Ii1A+REvrTDtWQulgxMTiROYJNr9LAoYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gSXBIwv4cCOAYVdviviykFp4HCKcBJ3VdPhTlf/dXlZiQyAnoRPZlEFJlnVjadt7Y7enY9E5RxvVnmSLVqvCpwQrpOVOTpJyopifN0xsA4WGbcgBIg0mEJrIedofcnbOSg1+Lf5orjvMjmwIc/oTHBeDFO/JVUEXjY3EUfjme6o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nECZm54M; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nECZm54M" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-6418738efa0so8398624a12.1 for ; Mon, 17 Nov 2025 14:46:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763419613; x=1764024413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TqjVzwOXi9ucrAfreZQkaGIBXDLGjw4pTmj1sbX0vDU=; b=nECZm54MlCvpeA8UEE4gHy/BAz5opc6zGEBizWJ/K6b5UrRW50cEXOSPUqJXjybxAu MGrsNEk4B++QLgVSVjL8Yu9izgG8Kd+/yxrOuisSaG45WFJ93X8PCBWlgpfssO2pUNJI KOVWfxgf07d7P6YMqPFYJXrekZiROuDwhIFGoNZQ00GFZGb1/cvW4h1ytHTjXP5em0k/ 8F7418NcIHUSWghAA0yKqwsibuZnUn9pooWl2KJvhFgDbONKwWO9EBOzOywFyzFm2jRM M+PYeRQz8T520XxQ73NKWfsCshWPsNh2md22RajjBTIvFJUhwcICU+2v9tanKRMmopcu joLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763419613; x=1764024413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TqjVzwOXi9ucrAfreZQkaGIBXDLGjw4pTmj1sbX0vDU=; b=Hd2pyiun2BbJvCWzKvmZK3Vn+iAAcmNi5jv5XxA0b8M2fWzvnBo70AsF/q7uIP6juV e2urR7/6crRlry5GRUhytcnvIZLtBhA+x1ByIIOWfT2WjROHrSNS7VdYSy4t+RPeU1KG 9EkzQN6gjzjQ0M3L+cYW7u6wffxykO09OpQomiovDQP8bvrJWlbh/mLXWmBzoac/vcGA jAm8/dP0otZtgmzqrXob7ocIbQQajUXWnTmHaVAmMzq3fgkOVJ746q46BpTO9YCpgPSy XC7XskBJ5pDlbp05DXsHYz0TRGi+oF4tYuvHZK5JlXwfuzxu6CKt7vcM6mIrSrKzptiZ 5mQA== X-Forwarded-Encrypted: i=1; AJvYcCW/ehz2xxYssZw95Q3WedTFVlda1mgAJX+2g5Ubc6xGR5cLVv02aSulQeUqppvl3oiozO+wBUm8wjNSSBA=@vger.kernel.org X-Gm-Message-State: AOJu0YwySXbB4ZrkNsv0wXZwQJIbkUXqmPBM/tA7JeTt9xac9TU2O0DJ w1rueDD61vwoMW1ofYrBWJhhlzLOEqLzYO7fsBvtItKkPinR1jU/IvA= X-Gm-Gg: ASbGncvDnyAlh0UH2pRStDqyRXT0+vyPcmjOtvILo6dilg3i9KHdJNmZ8TugJ9lkDzC q4B4a1JC0UPJ1l/Tb+AoS0jRvAqqitmkQ+UBo2ipmRpnqfKgVDklfO00PJtFE9TprWMPBHIGy6G CZe4axnsWc59W/BZ2EMypHbhCddNLaCDAEjrVxCCblwoo2u8Kn7cAV2TNlNCP/Tj06wEgr+J8hS qbB2NfZQQvScMRtHZ/gxBczdIe+kdpxFSTEMq4A/cb5p+bxLTl7XEUAmWvIhYYAhjDAJpVfBjNv 0XJdtwWuBauFT6otLdxyyW8zC3Icukk74McSB73D3cZPJDRfJ89OlKsQwKvCTPrTwwtMQFy3LL7 JVGWDcS9Dpezk51HOPIbwcy154icbBHhC2HLDN9miDjWMVKVJ0X8dCTVIu0IIjlugCSjmWvssSX c4f/Ee95EYDAvUzONBdo3CQyAcWqMWci/dpwFCcOgRMkxglpv6tYuYjTAitYdNMldBGy3b X-Google-Smtp-Source: AGHT+IFChHkH3iNr7D3j5wYleR6fkrjGzcNRvIh5kZKRQIF53XrPXDvKUvIepBMOQl9Opng3Ft+0MA== X-Received: by 2002:a05:6402:27d3:b0:640:fb13:6b8 with SMTP id 4fb4d7f45d1cf-64350e76054mr14056228a12.22.1763419613498; Mon, 17 Nov 2025 14:46:53 -0800 (PST) Received: from localhost ([2a02:810d:4a94:b300:232f:6d66:f093:4e68]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6433a497fc5sm11215357a12.22.2025.11.17.14.46.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 14:46:53 -0800 (PST) From: Florian Fuchs To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , Florian Fuchs Subject: [PATCH 1/3] sh: maple: Fix build error due to missing include of linux/device.h Date: Mon, 17 Nov 2025 23:44:06 +0100 Message-ID: <20251117224408.498449-2-fuchsfl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117224408.498449-1-fuchsfl@gmail.com> References: <20251117224408.498449-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 313162d0b838 ("device.h: audit and cleanup users in main include dir") removed the include of linux/device.h. Revert this, as linux/maple.h embeds struct device via struct maple_device, which requires the definition. Otherwise results in build error: field 'dev' has incomplete type. Fixes: 313162d0b838 ("device.h: audit and cleanup users in main include dir= ") Signed-off-by: Florian Fuchs --- include/linux/maple.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/maple.h b/include/linux/maple.h index 3be4e567473c..22f2930251ed 100644 --- a/include/linux/maple.h +++ b/include/linux/maple.h @@ -2,10 +2,9 @@ #ifndef __LINUX_MAPLE_H #define __LINUX_MAPLE_H =20 +#include #include =20 -struct device; - /* Maple Bus command and response codes */ enum maple_code { MAPLE_RESPONSE_FILEERR =3D -5, base-commit: 97315e7c901a1de60e8ca9b11e0e96d0f9253e18 --=20 2.43.0 From nobody Tue Dec 2 02:52:28 2025 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DA7334D39A for ; Mon, 17 Nov 2025 22:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419620; cv=none; b=oTKdDJJVlJt2qfel6Ep/YQtm7wFJRVWVNDyCmH1Q7ZN/i4X4kJveKZSQre9oqyfveWLE0jwg5QDQGXTL/RhdgcRlrsgolkXqW3y4gYBAfvRvhcvhNvJ/ccgvdDbfcWhXHTv2WCScbd2Q1EenNCDCLDh6iF9R6ahfTGu3v2lqbbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419620; c=relaxed/simple; bh=jA/ZHBrEKOSQVARcGtVcJs40DXIXWEQr9YcWzhSwWyY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ntTPB/V6SJ+68TemPyLC9Z4+CwxNPFCi0JBjJ8ftKfm0w4ivwToykqNokbQhB6faz8Wnlw05wnQBz7ACeNoj2obSRutuJ4uzTCknTLiyultCi2tprfH+1exSz7NReaJ5peHSCmWcvwLHztRMvblfcSmfxyLHq4384X8DNRXq//U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EZHig/C0; arc=none smtp.client-ip=209.85.218.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZHig/C0" Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-b72bf7e703fso805848966b.2 for ; Mon, 17 Nov 2025 14:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763419617; x=1764024417; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Kvi8PD7ux6OLYIZX+/H0obhuKo5+FvClrvPgKMpP5Nk=; b=EZHig/C0PhAb0ljNeDdkNanY6rPpOe748w8t9EqH/H6SqV3xAuSV54IkKgsA3TcPSw BgQwqZGo0bClxloM2kMaPdoUP9xWHSNozN78/Z0JlhLfS56VGcJ/5zCZt5Kj0EEpcC0B GLrlgPSL+HAlbxi/tUyJTUVkuM1Yb9R0v3fz6eRIWNQQiPjm5Jg8jZkSkS8a64MhIcmR e4K35Hgrv/twZ74t9ySJwDk6vxDhInV465IpIhSGzjP3p9DKKi0lwe+qk7SISIwQsJes Ftc8yMx/mmk+TZXHXHE3xe7pQ+TyE2BczxwhIQ4zPFh/0pJCAyw3+THPCEVDQP4BYFW2 JdMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763419617; x=1764024417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Kvi8PD7ux6OLYIZX+/H0obhuKo5+FvClrvPgKMpP5Nk=; b=hfy3q0t4/6+08GTYt1Wt3165dfQaaifzzULcuzSXiYQq7glVqf7GVmEnHBjoAPNMIk JGIAVrdXydMTHpwvn8ZaytHe3YSacwWVw1LBpB8bxd8c0WVHTNyW8LdR5QG0Hbp956Al CeAL9UMP8X0D85/89i5CXyK6FyuXyqI5Hgj1s5KKIdWhkMhVxTekBrOvrm6SWAl749F/ BDN0UjVc+A0h4qEfgNQXbRqSIntRqO9ppYl0jzo0gc92pnMzey5fBk2nSMh4EAwplMLd cko2Di5XwUwwIi50BLB0K/feRtZCjfz7yDvj7TavFFqCugQgdbazgV4+K6FZAwJejbAi 7Stg== X-Forwarded-Encrypted: i=1; AJvYcCX64Zx6OKGxxtGiyoRbXGG0ic07pH/HWpQGLGFXyCmDoS83f6gjeMedIvMJdnEu6QqW8EvEGvGLBDyvcq4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxc0TH9nd4ezgAjSbBCKtBayR0ZJnU5MD+ZrIjWtlgMsfjzfVKv xo1OKFNOsfcCzeReNp8rr7QudKSmbSvvplXL3Yd+BnX16vTsQ58Ma5E= X-Gm-Gg: ASbGncsfWXc2NTuPZOSHJeSWc7FI39MdLl5kuKzh7IZ6DfasMIxbX0IBuM1zLfupiPY rqxPCI4IteQJCQ/AUZw2w6otfxvLDBimN8vPzs8la3xCw7zt0YS0e2kZ4s08kO/schDlGJzUYgc vIIysIrtImlULOpG9VOcWGwF48jwFxAC+x24Hn66OR5i6XXzsEsGUWScfZTr6bm+5WrolXBlXki 1/aH2tTPBYs68lHrGAO+Mfo1jBl3qwgGxvEI+qqYjlNGS9VeFJO7QlgHHYNyoBZWoYm4jGuSmpl uPNYS/qx7MPOyEj+O+UPoojLOGvipfuwqwSO6oGnwLfY5Nus7E/io0NmbebWaD56WH1cbqWIupq haHbpmiRFewDVyyA02W71dlBV00H5HR2HW2wVMik16wZsH6ceyCT0hns7y33zgB0uTmBbxliwmP 81lQx7P8A6DwZledVfJYmCGFmPTE1zcnLfQ6RQpVmyXhMY6E8bdbIuZK7x3zjC2KUW/h9m X-Google-Smtp-Source: AGHT+IES8z9W/ZUewPDopCjp1qbQPjkzW7d/3SgBKJxsPR6cY33LGwmeBi3Hmms3epl6sy2024347A== X-Received: by 2002:a17:906:fe43:b0:b75:8b9f:de3a with SMTP id a640c23a62f3a-b758b9fe481mr127507866b.59.1763419616710; Mon, 17 Nov 2025 14:46:56 -0800 (PST) Received: from localhost ([2a02:810d:4a94:b300:232f:6d66:f093:4e68]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-b734fed9e9fsm1179130666b.69.2025.11.17.14.46.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 14:46:56 -0800 (PST) From: Florian Fuchs To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , Florian Fuchs Subject: [PATCH 2/3] mtd: maps: vmu-flash: Fix fault in unaligned fixup Date: Mon, 17 Nov 2025 23:44:07 +0100 Message-ID: <20251117224408.498449-3-fuchsfl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117224408.498449-1-fuchsfl@gmail.com> References: <20251117224408.498449-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use kcalloc() / kzalloc() to allocate the memcard structs, instead of kmalloc() / kmalloc_array() to prevent access to uninitialized data. This fixes runtime error: Fault in unaligned fixup: 0000 [#1] at mtd_get_fact_prot_info. Signed-off-by: Florian Fuchs --- drivers/mtd/maps/vmu-flash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 53019d313db7..d0793f1b0fac 100644 --- a/drivers/mtd/maps/vmu-flash.c +++ b/drivers/mtd/maps/vmu-flash.c @@ -609,7 +609,7 @@ static int vmu_connect(struct maple_device *mdev) =20 basic_flash_data =3D be32_to_cpu(mdev->devinfo.function_data[c - 1]); =20 - card =3D kmalloc(sizeof(struct memcard), GFP_KERNEL); + card =3D kzalloc(sizeof(struct memcard), GFP_KERNEL); if (!card) { error =3D -ENOMEM; goto fail_nomem; @@ -627,14 +627,14 @@ static int vmu_connect(struct maple_device *mdev) * Not sure there are actually any multi-partition devices in the * real world, but the hardware supports them, so, so will we */ - card->parts =3D kmalloc_array(card->partitions, sizeof(struct vmupart), + card->parts =3D kcalloc(card->partitions, sizeof(struct vmupart), GFP_KERNEL); if (!card->parts) { error =3D -ENOMEM; goto fail_partitions; } =20 - card->mtd =3D kmalloc_array(card->partitions, sizeof(struct mtd_info), + card->mtd =3D kcalloc(card->partitions, sizeof(struct mtd_info), GFP_KERNEL); if (!card->mtd) { error =3D -ENOMEM; --=20 2.43.0 From nobody Tue Dec 2 02:52:28 2025 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B583A34D4D9 for ; Mon, 17 Nov 2025 22:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419622; cv=none; b=g50HkQ3TdaGrIMReUqA6n2eDBFGrMv2x/RBxOUESb4pnS+ePWFr1CdxPhoY7Tnh0pS0VlTawwoxOZg+fkXDCO4wGtD28u9hGixz9vJkrQicHwI3udOPj3S3YhbcYbby+rLOZN61h5rC2KBmUc5Lqj4c68MLsxVRAicUoMQL/4Us= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763419622; c=relaxed/simple; bh=Vo1e5ZJD9+i5l9smL/5/CWY0zd/SOXTtrKOJeMgZx5k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ubLgHQK11vl0dV+sC8M9ktyr27U87zJXWCS6g8fSljjndVW/lO8aIaHV9qyMolOqFX2lsFiH+h59l52ybYb3H03IzzWU7R9zGgrDYixZBKY6dxST3ChWQZyAfDkwa/HAjd7SaMCyP2ow3UwIGuvMx4fETpuFv3XW8D0j+z8XceA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OR6EVG4+; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OR6EVG4+" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-640a3317b89so7317907a12.0 for ; Mon, 17 Nov 2025 14:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763419619; x=1764024419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OZBEUgm+GfP83woXXSnlop5bPmXXmwitxEZB0Co3Scs=; b=OR6EVG4+5TcL25nE178MeQ6chZ+qIkYQf+J9zXURe15P3gC+h2igMAdvnGDc10WlHV bf8Q4p0jBcFjmQ+ZLBeoDCkaQg95nI4A7yZnQ6rZU+INfNKKPBdxLZQdCPzl6nPmg+Vj nqlLRTOUC90KIqSuixwVD+YBRhPWQjOpcVjRWqe0lLsgBCnLVdjrnnV2JpX7gusd9Uxs wXxnIZjjmM3fgT0lIIcPteOAhHrKrDS/nvjiKSJysmpbkpK1orNt3qM5RJ4ByvVkga6M d+Ta5KgAZNrYkZEqiNC/y9UaSgVFjB8IA08bq1WQG0pbd7I11QNX1qIEtf9givbBveMb ldFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763419619; x=1764024419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OZBEUgm+GfP83woXXSnlop5bPmXXmwitxEZB0Co3Scs=; b=R/KLlxxuay9/TxInZOYh7jMXy+21CLgV7dUMZCePDbcCd+Aq1rLG3yOZT493YusK3F zaPkIb6vv4ivRQJy+xUyXofPmZusLJuRBEahIFNYR0VWbbiuXTZU5Tp52X2+FxKpJiUy ZKvddbDvegn6sKeuHC+YvvB5VEtLPkl/TX5MPBmx9LYjqe8WJl4CNyJ2GwA2VSnGaKNi skxv4+Kb+Wo8URvCAwsLYeDUAbXX0mwLcaC+I7CKoZyyELO+P2eU7QjUN/kM/9YN75qU uDYwVAFQF1lITtUgFKhSCoc1aka1raBNXvv7AGrVGZLNKvtVyfBHH73H9OfkTvbSE7Cn E6eA== X-Forwarded-Encrypted: i=1; AJvYcCWxhexI5Q7Ml4bnpr67BcHFr5KnY5uD9ASV5upqgzbGyzKYIC3TBoZXvOkNxNX68KjPQwYSqpxUBka9rWk=@vger.kernel.org X-Gm-Message-State: AOJu0YwraN6Uy5HgQVbR2Zpyiz2DbTgvD/a7V9ais5ivAQ6946of6CJp fAWx6W+gXEJ9E+8OWYPwSKtpI7+Dit2UjcOVmP0et7rbQvUM9EZf4Mo= X-Gm-Gg: ASbGncvmiHZ6rT2xXBYWAiDMSMk9SXjG9B84W6pxifd8MjWFnjZtrBZTIKdAiEsFSdi rQLIESLb1zB3lp7ItaCk3zRPDswGpXGIjC4DoJizRtaMroZ5wmzXsYPBFPteClvjMhUK962ttTM Iprhx7NE1YIvWyFImM2VBdkUMs/d6v/fkRdK+BZd6O6SSXG+4sExuNN6EmGrpBqXDqBbjqYb3mX YhEjvXvNtIXjgKblT0Aoq1QXw1PCcC6u/ipKskaserWYRzov685rnxYrYHvL3/ZPXLC5SVdqsTl qsivlgCXlc6yLFnEaubnVbgFhIYkQzFk/JTuL6aloqkVvuEB5bsWCEdrjMiaV1r+0J0UDXGX5q7 +yJck+yAF2JHg3/a4bhBbQSR+94V6rc8X50C7HH+r+PQLBrDjZPOSP8UOZGczjUMxwYgDOGYSco zVpTANyvRF7+1zyeiWcMiZCyuUoHOIQEIYBSVsjLg6jFbejAqDwXyKQFliPoqTwr47PKBc X-Google-Smtp-Source: AGHT+IH+cYgqyvs7Qy6c3BSCmA/lPzyceCw0kIG0eoKMVO8g31/I9hU7/tJT0mouZCkwTjjQu1aLWw== X-Received: by 2002:a05:6402:1eca:b0:640:c394:5c7 with SMTP id 4fb4d7f45d1cf-64350e2042dmr13039417a12.11.1763419618871; Mon, 17 Nov 2025 14:46:58 -0800 (PST) Received: from localhost ([2a02:810d:4a94:b300:232f:6d66:f093:4e68]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-6433a4cbd18sm11061900a12.35.2025.11.17.14.46.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 14:46:58 -0800 (PST) From: Florian Fuchs To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , Florian Fuchs Subject: [PATCH 3/3] mtd: maps: vmu-flash: Fix NULL pointer dereference in initialization Date: Mon, 17 Nov 2025 23:44:08 +0100 Message-ID: <20251117224408.498449-4-fuchsfl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117224408.498449-1-fuchsfl@gmail.com> References: <20251117224408.498449-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The mtd_info contains a struct device, which must be linked to its parent. Without this, the initialization of the MTD fails with a NULL pointer dereference. Signed-off-by: Florian Fuchs --- drivers/mtd/maps/vmu-flash.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index d0793f1b0fac..153ba6f8f769 100644 --- a/drivers/mtd/maps/vmu-flash.c +++ b/drivers/mtd/maps/vmu-flash.c @@ -547,6 +547,7 @@ static void vmu_queryblocks(struct mapleq *mq) mpart->partition =3D card->partition; mtd_cur->priv =3D mpart; mtd_cur->owner =3D THIS_MODULE; + mtd_cur->dev.parent =3D &mdev->dev; =20 pcache =3D kzalloc(sizeof(struct vmu_cache), GFP_KERNEL); if (!pcache) --=20 2.43.0