From nobody Tue Dec 2 02:51:11 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E1A280037 for ; Mon, 17 Nov 2025 22:35:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763418923; cv=none; b=TD698IVfKALU6hvBF6dDNd741rkNsOxqbjDkip9rBru8WtElnOYil1awiRY+eCvDwBOpzssnjA/DzfB8/SHB9ZhphNrZ+MB8NziGzMCUORScbRcvv2/PdIJoA3fP4gBn0YXE3ySNa3rLKyfF5iXkLMaa51XNJ/LcO7Ht/hLwgFE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763418923; c=relaxed/simple; bh=oGtexn4m4+/9rjdY4N/CCX3LUXXjxq7mDh8Xf+jaA30=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZIZ9zX0BmP3bOZnrNa3Zz2kdzqtdYzNmwlj0aWTeOnmZyjbnBsbUeDlzUklTh5sxUIxwDpYIGFf8h+0n6Q4R6MfLdtYq0/inCL+4FZVAEvHwzuyCUpatesi4V7huFvT8cvQhPkvyDWEuCB/3TdqlPDKm62lhZ4MUtfVc5uwtB6Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fcDd11eu; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fcDd11eu" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-64088c6b309so7747467a12.0 for ; Mon, 17 Nov 2025 14:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763418920; x=1764023720; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bt0FMPe4Qa6sEYYxJmZwi44mFWT2CwJlUvRkRKRBNv4=; b=fcDd11eu4G4i/BEZjmLyZnXmbv+PvP80niMy0r7dvo9difIhbMraeMbLW/FjS+vUFJ Mx986/gX6cI2wwVQqKv2TXxaJ23GVYY/SjfGQqdy4nZpuWAY4NK145oAHdG10okaGpKe mc4COPPYcwKZFKUkGyMhEn6QbUfaiU7JdePj5kNoUH+iiKRZzVQIOImewgkx3mQM4gg6 AluP9cLlBystZOXACiLwzog8breQPRu8xUgmDQji9mIXkdOx92j6VIV2glnsKaZKioTv FntIcNCqaws+r51laCY+9OvLsP/T/yvBjtivQzaz2kyA7TsNgklpHvQ+tTg5AXh2ejYe I+mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763418920; x=1764023720; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bt0FMPe4Qa6sEYYxJmZwi44mFWT2CwJlUvRkRKRBNv4=; b=DSjU+UY9BcPckER14CgKiGDR4j3S801T+3AvshWQQH8kg3rwZs+n+0LscgqtBkA38G dfDKJuyGzAE4sN9A7VGdsxJ0P+eQGuGuQQXmUpp8T9sFpAk2Z1bBFIy6IF/4ECyRRUIP 4+3MABuQbhqP7522IC64McC6Fde4qrkAGD3vGQwm06LEAMyvMe9dR2wR2Yexb+18dTqv lcVFGbfwHAPhdfXIVMnxrR9Vq/eR0fGdXf1x/rIXAD+XqOGz9nUyXLJxLgGXhY0/zCtq 73Gk1e+p8EK2x//nJG6r4H1kP+/hwzKLwNI4bbnQqToTlwpe/dWDKQ6vRc/9+k40gpTq kTKA== X-Forwarded-Encrypted: i=1; AJvYcCVzWqZOQms7t52yPxUtx5LoM/YHG8dNG2DQBTenDTDUyq0Xy9/kCKhF0VEVtFqCEqgPYpYf96EtROAhMss=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6eGGlUVVhveZx+qbP63eFkZbJQe+mpdSeV5NzF1o2NkTnYT43 7SrXuztcr6FXr8mrUrZSWTMxikT1QVraqjDytzAv/EqsRj32iubqlAWj X-Gm-Gg: ASbGncs8WCXw3ia+KmvM6jSjHsV+tgcBk4jVkmA57tGCcY97EmGDTYdW9uwFeTrjQuE eNeZuexZWPuF7mekRDCcAinteOZ92l3R7dPC9k1leAx0qrR6D0kH7ssJLvp0yBf74RE1Cp62IQV PbGOgs16jSxq5av0Z0yPGjeLjd5Kv4RmffGMdZmV6YodQIKCmDjDmP8uFGirYU3LiBFc/62c51C T3AS6GctdSZ+uRPFiUlJS2+wTeVT4KJmjniWr/Cy1nC6ai047zoam3SKHPWm9aMRV5YafTk5fW6 tYLGISNt8Nw/QXFbKUZ+Qmj3DCLveRAhECFEgHdUn4X7cViPhXMOJQihyVkDJkigKDb+lQgU2jx c4NFc4rI90sllLmMacrKCIy7Bej1j2Deqhxp2NJaKvij/r9sSuOXomElV7OX6IH+p45HViuzdkn AH X-Google-Smtp-Source: AGHT+IELFS6lvG4mnDClLXFQxCFcVvQotosVXxtJ9lksxQKVeVZ8zurwvbwRqKhRihu00ocg3gqWQg== X-Received: by 2002:a05:6402:520b:b0:640:eea7:c95b with SMTP id 4fb4d7f45d1cf-64350e04610mr11137593a12.6.1763418919862; Mon, 17 Nov 2025 14:35:19 -0800 (PST) Received: from eray-kasa.. ([2a02:4e0:2d08:f72:eb64:1d0d:5855:afe7]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6433a4b2615sm11103469a12.32.2025.11.17.14.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 14:35:19 -0800 (PST) From: Ahmet Eray Karadag To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, skhan@linuxfoundation.org, Ahmet Eray Karadag , syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com, Albin Babu Varghese Subject: [PATCH v2] ocfs2: Invalidate inode if i_mode is zero after block read Date: Tue, 18 Nov 2025 01:35:07 +0300 Message-ID: <20251117223506.299511-2-eraykrdg1@gmail.com> In-Reply-To: <20251108120133.37443-3-eraykrdg1@gmail.com> References: <20251108120133.37443-3-eraykrdg1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A panic occurs in ocfs2_unlink due to WARN_ON(inode->i_nlink =3D=3D 0) when handling a corrupted inode with i_mode=3D0 and i_nlink=3D0 in memory. This "zombie" inode is created because ocfs2_read_locked_inode proceeds even after ocfs2_validate_inode_block successfully validates a block that structurally looks okay (passes checksum, signature etc.) but contains semantically invalid data (specifically i_mode=3D0). The current validation function doesn't check for i_mode being zero. This results in an in-memory inode with i_mode=3D0 being added to the VFS cache, which later triggers the panic during unlink. Prevent this by adding an explicit check for (i_mode =3D=3D 0, i_nlink =3D= =3D 0, non-orphan) within ocfs2_validate_inode_block. If the check is true, return -EFSCORRUPT= ED to signal corruption. This causes the caller (ocfs2_read_locked_inode) to invoke make_bad_inode(), correctly preventing the zombie inode from entering the cache. Reported-by: syzbot+55c40ae8a0e5f3659f2b@syzkaller.appspotmail.com Fixes: https://syzkaller.appspot.com/bug?extid=3D55c40ae8a0e5f3659f2b Co-developed-by: Albin Babu Varghese Signed-off-by: Albin Babu Varghese Signed-off-by: Ahmet Eray Karadag Previous link: https://lore.kernel.org/all/20251022222752.46758-2-eraykrdg1= @gmail.com/T/ --- v2: - Only checking either i_links_count =3D=3D 0 or i_mode =3D=3D 0 - Not performing le16_to_cpu() anymore - Tested with ocfs2-test --- fs/ocfs2/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 14bf440ea4df..6641caa45292 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1456,6 +1456,13 @@ int ocfs2_validate_inode_block(struct super_block *s= b, goto bail; } =20 + if (!di->i_links_count || !di->i_mode) { + mlog(ML_ERROR, "Invalid dinode #%llu: " + "Corrupt state (nlink=3D0 or mode=3D0,) detected!\n", + (unsigned long long)bh->b_blocknr); + rc =3D -EFSCORRUPTED; + goto bail; + } /* * Errors after here are fatal. */ --=20 2.43.0