From nobody Tue Dec 2 03:00:13 2025 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010054.outbound.protection.outlook.com [52.101.193.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A2432A3C6 for ; Mon, 17 Nov 2025 18:56:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.54 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405817; cv=fail; b=fhm5K5EmGtphymUWm1ttpMDzaeJ7rW9/YSN6Q9aj2e9yRNBUWP11VKoLpRsOg5nSl2XLJh2hn8kKGq6lzIQTvO/FsSao1B2W7LAO1NcoZfrQ9IDZkS9ilk7+7WQHKSyWp0/UPHqjiH4aWjW2eIE349bDmgQVN0kguYrcQYqtO5Q= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405817; c=relaxed/simple; bh=oSo1IszCfUM8PoDCqzrK8P+C/xpzpNNWT4nqJ1YsMbQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bL7eM4C2msp+W8CBo54C2b4w3uObMfZ1Mo2roHnGvaGtW4azCABrGyM3l+h++uGYzeV0sLvLnCzDiaI0kaEdKwDv4kvv2eoxRpN97bBNPS2tDJwbO1KRvGzbVPp8M0T/5Cepubu4CVT17bRiIB8OCNHNsatq9k1q1w+JZeTbE1g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ombpvE8+; arc=fail smtp.client-ip=52.101.193.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ombpvE8+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nxOAvwEvpwanrB5TxkiRzazM/C0AQu+p4BPI6WQhvW4sFa0zuJFNOaBsuew3h46V1kWwEmZ9jY5u19Wc5Ufr1PfXBLWhtq5QiB7onCbPJSmFthRvZ0c1NKOh7PfqmjQqZsTEGLYKYisF+ZpWQy0yJhfb7JsMUmp5vRqcWOLXQgTjqNR6a7CI+PvtLrtZs++/j7Q5Z/nypu5EAos0R4tKQdIHYNoLagYLTQnIUmdyJIgnRfeS+IbvbeBj623qHWe7Je8il9gEeTm84CAE8QSahrPMUR0ef3qTiTJZA8xB7wWoGMNuGKRCsxtvy2hVx5J48l8Xr14aj8a6MWD+yMopmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8TlzZ2Ad8rvboEFa9Q7K7AbMdZWelIMho5m8afF0kgM=; b=ALQNd5KRnJSytP7xLENUoHvSwld3e8ydfxZoJ7G2VMMpzN/HdzWRRLb1nbZVqADOjGs+2mtcHY3scgliuGt2X1xpYnlFKfSVQvwfjCGb3MuLoskxPU5IIGDUCHh5L9RLeQGcgsNb6220+Ei1YZSePCWD/6Y6HqHuxGexHzB/dmwes9/+XgGOy3NTaQ7f3jWNGcOp3b9ZkExyL5ppfGUUWPIMGo0IMSQPhK7vAvNqplAwm+d6dbyTtw5Z5JQdezjVYEMtM2PhbYoVwL+Z3p2YyeJ0kQNOqkGFoxkBlvRcNLxFlnjxFuH2j+AXJy3TXs23RQs4d5cEwaBdeht+aPoeqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8TlzZ2Ad8rvboEFa9Q7K7AbMdZWelIMho5m8afF0kgM=; b=ombpvE8+OUPnyE7lNqwcJCDZmg54bfg/MZo+PEuFbZBzHDHyViYRo6JKDcTPzu4iijK+x8M7lcmEqfJdoH2NlYeWsx6Xd+RUlPQ4zcBZndUTfa0rL1Ph87i1DjkY/4uru+zqrBiRXH0QsYeH7u7Qjiwv8q15FtA4vs4ZQy7x2yI= Received: from SJ0PR03CA0045.namprd03.prod.outlook.com (2603:10b6:a03:33e::20) by DM4PR12MB6640.namprd12.prod.outlook.com (2603:10b6:8:8f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.17; Mon, 17 Nov 2025 18:56:47 +0000 Received: from CO1PEPF000066ED.namprd05.prod.outlook.com (2603:10b6:a03:33e:cafe::a3) by SJ0PR03CA0045.outlook.office365.com (2603:10b6:a03:33e::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9320.22 via Frontend Transport; Mon, 17 Nov 2025 18:56:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CO1PEPF000066ED.mail.protection.outlook.com (10.167.249.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.9 via Frontend Transport; Mon, 17 Nov 2025 18:56:46 +0000 Received: from BLRKPRNAYAK.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 17 Nov 2025 10:56:40 -0800 From: K Prateek Nayak To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , John Stultz , "Johannes Weiner" , Suren Baghdasaryan , CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak Subject: [PATCH 2/5] sched/psi: Prepend "0x" to format specifiers when printing PSI flags Date: Mon, 17 Nov 2025 18:55:47 +0000 Message-ID: <20251117185550.365156-3-kprateek.nayak@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251117185550.365156-1-kprateek.nayak@amd.com> References: <20251117185550.365156-1-kprateek.nayak@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066ED:EE_|DM4PR12MB6640:EE_ X-MS-Office365-Filtering-Correlation-Id: 7272e493-f906-4c29-5795-08de260b0e92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|7416014|1800799024|36860700013|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mFp0JD8dAsND2T1LrkW6/HjN2Y2Aq0QlJucKCxv05V+c51rJcV/nx7hoMyAT?= =?us-ascii?Q?REKheh41v7YMNbQm754T4GODlsBqt5wu9mgZQAzqMLeCnAqAPqlawkdFw1QF?= =?us-ascii?Q?JtUcckmxqvARJrtQ3tu+xU+PqQB8gBwSAmJr4u9KQgHAFRAkSNeC9hYjBOC9?= =?us-ascii?Q?8W0aBd6ODzNkIb0bAO8GMSZ0slG26kMQmmG21fbGp96Q8A4esvAXlQxJoRFX?= =?us-ascii?Q?PNwduf4kLGSrGPU0ifP8cnxKoKeT2FklsXmdDpwceE8lhAIRMSa4kePEv6vF?= =?us-ascii?Q?TT6QH136UIoCjqEaG+oiSz1QUQ6UcsfmDZKNxjLbAQC0IKLWH6Av9q7NZr1g?= =?us-ascii?Q?rz8K7iGysBelj+AN5zLHRTjS88jmHmDgUemZpV1YSEZUoJD/C6gztmHWT+Ud?= =?us-ascii?Q?G029bEAS2BSSfusEZxpju53b5fNhZFVuAtsN0Qdbk8sDYtm5HcYc5g48oW3H?= =?us-ascii?Q?FKKedPoRUt/VP8eyfmmtjAwjM25ujJPr6GrsoDkpR7GUDrknfwkgrdl3nbi7?= =?us-ascii?Q?kvppNWnCFTJcyyZd+ch3y5hL2cTkAuY4Z144PnTmnUrokkrCkUY+GsYFs+Go?= =?us-ascii?Q?EYZ1vXY4gJM4+bKaf3dEkNcfGzzoq+Mk71NtmXqrM/nmy+ESuCkrEsfv490l?= =?us-ascii?Q?wdNFjo2c/erL/hlMOteKdMjjiwBgeopVtgo8Gq3vHGX3idp+TgjJqAbGAiiB?= =?us-ascii?Q?f0rLEk9EBFCm70wQPqzJ9hkGS1k+reHziwSzSZ+FS4hLMGm4GB36Fb9kEpGB?= =?us-ascii?Q?z3JOjZLFlKR/Zb2a9zeauXB1k/A/Hi2WHkYfeyKACBkr9EICJiWoIiIoGU0g?= =?us-ascii?Q?mxcdBtjTLLQoHxO04c3li32AYH3EGtkScw7PFIpj3Re1F9PO6EQgJaWQTCZ2?= =?us-ascii?Q?yWGLFA12UfjU4/oQpb85VbfO7nW9EVutjqiGc+R+xdjXS4VUvf20MmSVYpBB?= =?us-ascii?Q?zSWEW/eZoHhPLSfFf44P8Y/QccvQCko4a1wYghuzEIAgxyxk1KUyg0WPB1xU?= =?us-ascii?Q?a71VA+GVWdLKZJDdun7h5qMvPS79xLzuhfao1SRLS0ktIRx8uMs5msoJxmS0?= =?us-ascii?Q?FRV4hSHkbQ3r+Xlr8QAedfXvAEVMlQGxpGQKDHs+VKPJ0bDMdr3knAg+OXaS?= =?us-ascii?Q?x0wo3CAEfLZSI+Fjr0Gv1t9oZy5LFMdT9ii+WqzYY2ec/3qgyeizjWk0gx+1?= =?us-ascii?Q?QkLHcaJyUjb3wN1heMEpy8ml7/hhBvND2S0EkiFtwAWO4IxnO+64tud2IKjr?= =?us-ascii?Q?kvUb7srOFKUxwup2v7czUh2+s1uDgy+7xSyRZ+WBusktWYs+zFfwdElRTp/4?= =?us-ascii?Q?fM3uMsGz/Q19YeyFBNw8axImuAcgWFiu5kUjRau+VEUlEFsEnQtZ2XSEUN+Q?= =?us-ascii?Q?Yhmi8Q8axFPVLHcTPFtZIFoHz56Uv2pjhODBM+s0bTMmNFXkzGSF9T9ZEW/D?= =?us-ascii?Q?ca1BWih4geCF3rQodtBhtcnU7x+hjJ3Yqhmb408Ji0KqGw8/ryWHt/eCOcjK?= =?us-ascii?Q?gKAP7GF7Wi3OOCQYH/CH2SUfCMfA1I4B2ga4Q7xMf//ycM5hAxJ+Q+sgn52+?= =?us-ascii?Q?m5Er2FEQMOQ4Mh6wQlg=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(7416014)(1800799024)(36860700013)(376014);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2025 18:56:46.2820 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7272e493-f906-4c29-5795-08de260b0e92 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066ED.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6640 Content-Type: text/plain; charset="utf-8" It is not immediately clear that the PSI flags, the set, and the clear bits printed in PSI warnings are hexadecimal values. Prepend "0x" to format specifiers to make it clear. Since "kernel/sched" uses "0x%x" as opposed to "%#x" when printing hexadecimal values, the same was followed to keep consistency. Signed-off-by: K Prateek Nayak Reviewed-by: John Stultz --- kernel/sched/psi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 59fdb7ebbf22..b031608c02ce 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -830,7 +830,7 @@ static void psi_group_change(struct psi_group *group, i= nt cpu, if (groupc->tasks[t]) { groupc->tasks[t]--; } else if (!psi_bug) { - printk_deferred(KERN_ERR "psi: task underflow! cpu=3D%d t=3D%d tasks=3D= [%u %u %u %u] clear=3D%x set=3D%x\n", + printk_deferred(KERN_ERR "psi: task underflow! cpu=3D%d t=3D%d tasks=3D= [%u %u %u %u] clear=3D0x%x set=3D0x%x\n", cpu, t, groupc->tasks[0], groupc->tasks[1], groupc->tasks[2], groupc->tasks[3], clear, set); @@ -896,7 +896,7 @@ static void psi_flags_change(struct task_struct *task, = int clear, int set) if (((task->psi_flags & set) || (task->psi_flags & clear) !=3D clear) && !psi_bug) { - printk_deferred(KERN_ERR "psi: inconsistent task state! task=3D%d:%s cpu= =3D%d psi_flags=3D%x clear=3D%x set=3D%x\n", + printk_deferred(KERN_ERR "psi: inconsistent task state! task=3D%d:%s cpu= =3D%d psi_flags=3D0x%x clear=3D0x%x set=3D0x%x\n", task->pid, task->comm, task_cpu(task), task->psi_flags, clear, set); psi_bug =3D 1; --=20 2.34.1