From nobody Tue Dec 2 02:58:22 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5D7F33DED1 for ; Mon, 17 Nov 2025 18:54:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405691; cv=none; b=gq3Ov2m0eYmoxlqRCT0hf9xrFRLbTrbR4fc71JboZQN75U0UEpP0jsPQxrQdUYyoWtgFhfsBN2j7OzufJBeByco0TRm9iKJ+SKX3hf+J3iJ/6lCALb4VRzRjGfY1vD6jWzao/DWoczqI5Iu4p7mwDl40PXrFUwttBYsDGEZBdqM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763405691; c=relaxed/simple; bh=KZNGCErladIv7DUjLnlytiY04Zips/SMhtaQ8kxPwp0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bq5iFaD31rkMLLApJKoijKR7vV4gUavrwCRHIL1IIQb2rd+2Cv3g3GLNpI3uOBMtLNMZHP2oVHa/rz3f4kKXGG1b6L1eum7Z6ouatST8Wb1ZPDT3/pJvUwnEojyEFgIhV2DLxIjd7Zp8OUPaGAG1hyJj72qHW/N47sKSBeYF4oY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KEjPyLoo; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KEjPyLoo" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763405688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o/91aqlMG90jMVYPWMYCXSLUYrI0o0P8LIA3DXEBJJo=; b=KEjPyLoolyE7lmbuMrW8BWERgAb/+o6lu4dYEP8mlxrE8BUzb5/L1dB89auV6/dELL7/Pd er0TKaQ1+MHKInuIyavjMHUrONMrj8doQgr0E1FVPqsGfa38/OJAUQptT6gYqAzqYcQ2GK EwwG30U4vc6e60zsBD+pJac4SUiGN9c= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-rw7XQ3AoO8GbsHSx7CCgmg-1; Mon, 17 Nov 2025 13:54:45 -0500 X-MC-Unique: rw7XQ3AoO8GbsHSx7CCgmg-1 X-Mimecast-MFC-AGG-ID: rw7XQ3AoO8GbsHSx7CCgmg_1763405684 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 464D1195608E; Mon, 17 Nov 2025 18:54:44 +0000 (UTC) Received: from wcosta-thinkpadt14gen4.rmtbr.csb (unknown [10.22.81.153]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D4035180049F; Mon, 17 Nov 2025 18:54:39 +0000 (UTC) From: Wander Lairson Costa To: Steven Rostedt , Wander Lairson Costa , Tomas Glozar , Ivan Pravdin , Crystal Wood , John Kacur , Costa Shulyupin , Tiezhu Yang , linux-trace-kernel@vger.kernel.org (open list:Real-time Linux Analysis (RTLA) tools), linux-kernel@vger.kernel.org (open list), bpf@vger.kernel.org (open list:BPF [MISC]:Keyword:(?:\b|_)bpf(?:\b|_)) Subject: [rtla 03/13] rtla: Introduce for_each_action() helper Date: Mon, 17 Nov 2025 15:41:10 -0300 Message-ID: <20251117184409.42831-4-wander@redhat.com> In-Reply-To: <20251117184409.42831-1-wander@redhat.com> References: <20251117184409.42831-1-wander@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" The for loop to iterate over the list of actions is used in more than one place. To avoid code duplication and improve readability, introduce a for_each_action() helper macro. Replace the open-coded for loops with the new helper. Signed-off-by: Wander Lairson Costa --- tools/tracing/rtla/src/actions.c | 6 ++++-- tools/tracing/rtla/src/actions.h | 5 +++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/tracing/rtla/src/actions.c b/tools/tracing/rtla/src/acti= ons.c index 696dd1ed98d9a..efa17290926da 100644 --- a/tools/tracing/rtla/src/actions.c +++ b/tools/tracing/rtla/src/actions.c @@ -35,7 +35,9 @@ void actions_destroy(struct actions *self) { /* Free any action-specific data */ - for (struct action *action =3D self->list; action < self->list + self->le= n; action++) { + struct action *action; + + for_each_action(self, action) { if (action->type =3D=3D ACTION_SHELL) free(action->command); if (action->type =3D=3D ACTION_TRACE_OUTPUT) @@ -241,7 +243,7 @@ actions_perform(struct actions *self) int pid, retval; const struct action *action; =20 - for (action =3D self->list; action < self->list + self->len; action++) { + for_each_action(self, action) { switch (action->type) { case ACTION_TRACE_OUTPUT: retval =3D save_trace_to_file(self->trace_output_inst, action->trace_ou= tput); diff --git a/tools/tracing/rtla/src/actions.h b/tools/tracing/rtla/src/acti= ons.h index 439bcc58ac93a..9b9df57a0cb34 100644 --- a/tools/tracing/rtla/src/actions.h +++ b/tools/tracing/rtla/src/actions.h @@ -42,6 +42,11 @@ struct actions { struct tracefs_instance *trace_output_inst; }; =20 +#define for_each_action(actions, action) \ + for ((action) =3D (actions)->list; \ + (action) < (actions)->list + (actions)->len; \ + (action)++) + int actions_init(struct actions *self); void actions_destroy(struct actions *self); int actions_add_trace_output(struct actions *self, const char *trace_outpu= t); --=20 2.51.1