From nobody Mon Feb 9 10:24:47 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74418273D84 for ; Mon, 17 Nov 2025 18:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403062; cv=none; b=bY/xYj+Oo/jlqyrvy1XeFYj8zb4SvM+lasFqvNMsirG4C3psziE6DzhBPeyx3YWD6CJMd5c3ldqC9yDmlv6cLJP4QY68bLzf/+N8/wX2GOFOrgeP7VI4t3F0T9vR20+P6DstFERw7tcK9da7W84QD/faG1zIX8927DOla0aMgfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403062; c=relaxed/simple; bh=dtx1yHWHEbSK/c8GNo1HpXQJQvD4eT8Atord9bhcDCc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cWSTxj9sX6a5y6AikOpy9YK0Q8ZhxJcoJlcKlS6c1QtHoI2ixBQSThWBMPqlIY1CcwT//ZyTBZwF1cFFGVMz7gVix468GXF40WIpb8vY929MH8TT8j+RdlEI0Ot/mYDrs4xYY4BBcZgNAW87JJzxmYT4SQo6BWcx4C38oalFaV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fpckg3XJ; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fpckg3XJ" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2958db8ae4fso42678555ad.2 for ; Mon, 17 Nov 2025 10:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763403060; x=1764007860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gazcyDKCqVDM4NaE88dT10YpQkqHH5/XsZTj015pVas=; b=fpckg3XJpcCOD+UP4Qoai2osjLmgpeAdSvZaRSjB3+rwqdK922TXKdI8X++t0cdmyq +vWiJ+/Xg1qT4SXuBMx/6pxTtUU0BOudjQ7/V3AfIYLkI2kA8AmuPBgcus+llWGXuzZ5 SWYz8WS1FCmQDb+o+bTw8HOzUwub9mSCcEEkrBwuK8QhA4ecAh+LRgz2B73jo1jNTiOB emzBAx0tKajnD0ByulekXMRtSB0wL+xQJYWylaHCo1FSfU5br9ZujrNfdyPrwgKWRCzd gwT1y0tFZcUB8T2TLlQLLbsD5eVznW5gHGTgZKBbOX71PBzNW4lR1Vp1dHBCXahYy1h4 EOrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403060; x=1764007860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gazcyDKCqVDM4NaE88dT10YpQkqHH5/XsZTj015pVas=; b=gFTpYKXkQXFXDekI/Sr9e4BQUUOl8dEhDHznA5+v/+FEfbnmEOUdCC9+tqlbIhVRjY +CEUlgx8T0Gf5qw+B83Tnt4OW8eedJ37DILt+YT8B3m05vQWGBSWvZJ62LhiVd0LzhyS MuTupqc4S8+tPbKhOfDGyB789MYaHHk+E77dNBf7o78apf1J4gp86T3rkCRA9rBGM4gT W3KZ6iNrCph18TiEURkN31iKlivkBj8Re2vQnKlAStBbOT6ytZTtvKIT4JktmDsUCyat O/5UPqT2asyWODAyh2RyJppdjBVyE8zdT7o9mlSwsTcmSwiHLCjfjpQRlVljt9zv0xv0 pK8A== X-Forwarded-Encrypted: i=1; AJvYcCVhe2TEOkYBBTQXqhITNRqnPZGbBzc1y8//LRLIX1XdrxqubqfU7CxgXwPU38V/HTuUEKmSUla1x+ZUqTA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3RLDriWLhwhm2x5JZztkeUJMGbXwPzc7CySv3Kqs3TP/HFWIl Vq2yQC+plHVTcoHhpLmMnbrxHWRpkBDaNN1WJpR3UHGsr0h+GTvcbPwd X-Gm-Gg: ASbGnctiJxsWijUG2UhBsRLfgKOvLLTMVVIGEv3vE7uvY1U78/yALMCFf/rSs2tMFJ9 I8e4xvNN6Z9C9QRHpCX4gz/t6HMk+q8KqDi8WbobiB07kL6ii+L4hqFOCh2Nc7AORKM8HEpjiGj BDdbibvd1UwOJmIpbVGEAe2FLmHDKSPLqj7qaxGhmGcrWQ6QpyRL7ko1uZ6R9B2979h+lkiprK0 HxmC2W7GBaD2JK66KeD/6ZLRtXH8BPo0M5FbUID1v6Xdb24UMYU0RzBct/lsKsjllJ7TE1Gio0j xao4cO62ejlb0OOIxYcnoudM8jengRbUcXo1mRHA1AvoFweREL072p2HldbYp6sqQFE+0K/7BsZ ezuakF8yJDFveGtBTYMr31LMrE3ycDJAAQNoVCq96xq4rqRCyQFqx7gKUEvMB3mhFF3sJJso8VS 5iHjWZsgIIDWlR0UFMCJU= X-Google-Smtp-Source: AGHT+IEH430mBOahI/CtVHCqRSIqCGq9hYMzLu8e8nwRDN0slBe2X4NbiY309RgQgf9w07IlP9p0SA== X-Received: by 2002:a17:903:ac7:b0:295:557e:746a with SMTP id d9443c01a7336-2986a6d04femr131798225ad.13.1763403059763; Mon, 17 Nov 2025 10:10:59 -0800 (PST) Received: from rockpi-5b ([45.112.0.172]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c245ecdsm147237955ad.32.2025.11.17.10.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 10:10:59 -0800 (PST) From: Anand Moon To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-rockchip@lists.infradead.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 5/5] PCI: rockchip: Fix Linkwidth Control Register offset for Retrain Link Date: Mon, 17 Nov 2025 23:40:13 +0530 Message-ID: <20251117181023.482138-6-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251117181023.482138-1-linux.amoon@gmail.com> References: <20251117181023.482138-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per 17.6.7.1.21 Linkwidth Control Register (PCIE_RC_CONFIG_LWC) reside at offset 0x50 within the Root Complex (RC) configuration space, not at the offset of the PCI Express Capability List (0xc0). Following changes corrects the register offset to use PCIE_RC_CONFIG_LWC (0x50) to configure Retrain link. Signed-off-by: Anand Moon --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++-- drivers/pci/controller/pcie-rockchip.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index b3c9b9cbeb8d..aae3def64bf0 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -338,9 +338,9 @@ static int rockchip_pcie_host_init_port(struct rockchip= _pcie *rockchip) status &=3D ~PCI_EXP_LNKCTL2_TLS; status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LC2 + PCI_EXP_LNKCT= L2); - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LWC + PCI_EXP_LNK= CTL); status |=3D PCI_EXP_LNKCTL_RL; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LWC + PCI_EXP_LNKCT= L); =20 err =3D readl_poll_timeout(rockchip->apb_base + PCIE_CORE_CTRL, status, PCIE_LINK_IS_GEN2(status), 20, diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index a83ce7787466..5bcaef7bba4c 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -160,6 +160,7 @@ #define PCIE_RC_CONFIG_DC (PCIE_RC_CONFIG_BASE + 0xc8) #define PCIE_RC_CONFIG_LC (PCIE_RC_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_SR (PCIE_RC_CONFIG_BASE + 0xd4) +#define PCIE_RC_CONFIG_LWC (PCIE_RC_CONFIG_BASE + 0x50) #define PCIE_RC_CONFIG_LC2 (PCIE_RC_CONFIG_BASE + 0xf0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) --=20 2.50.1