From nobody Mon Feb 9 15:07:25 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBE8A3148DD for ; Mon, 17 Nov 2025 18:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403057; cv=none; b=rfusDGuk9IWqhoC7yJAMhinfKMcxBzBbzeBZ0+Mkuylmujic3S2F2ewvxk3jju48qoasRtk7CgkLYcq7s7k2dvVrQ5JWz6jFWmDAs93FqTGTNpjHIR6UCWKWkVMTTrGmzV4q5h9oAFB5SlFbdh+ibu9gvJJpsjaZK5UMTyX/8R0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403057; c=relaxed/simple; bh=qq+FPtm/d1QsehqCCXel+Z953y6JYcKkrKX8vLhpquA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n1OFE8N85W7YVyLTLYLZiqZPqBG3tmFofits5J1FQC0YyWWsKf3cVN5fPj3RhWhAXLm+gkfMm20VQ0iJG/CRvGmePxEyIsMtb+WE9254kk/xcCUt6tgEwZr5V+ERnrxYrIHcnCXGWim0bRdT1fquRYEjit9XAAv4VS/rtvvc4jU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DBFytu/F; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DBFytu/F" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-297dc3e299bso44907175ad.1 for ; Mon, 17 Nov 2025 10:10:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763403054; x=1764007854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ec1PASGse1c+caWp4ium+eJ62vTRL+jpVdDXW6vSJlU=; b=DBFytu/FgqUtYwrvYYQ01/6bSh+OeOoltP1QBTYbh04ltVqGhQLG1Afv0Qv9KJXRJZ CIFovhcIEEbSiJkTFD6U4xFjV0j2E4N9ehDhO75a0DEuAVVUYfbM3PQ6EmFidlZDCjWx KKTSh5OtTwLcbEp3koMTlmPsyEpVp9VJbGcSw+0hYWaJRq46nXdPFS8oM9UcX8OaA8FI 7XaHnKQZeKwLmp7XB2rXzYeKNrJf6pFpplDErfmX5D9/bcsiTY3jA9tTynaa52XDeYew dGLAS6ZV22TSnphKAYvipSOxsJ2/mNZkxsZiHJwz+JKoxcg8i0BnRXRGp+RRsD11qpfE Ch3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403054; x=1764007854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ec1PASGse1c+caWp4ium+eJ62vTRL+jpVdDXW6vSJlU=; b=xD9vcrTr5owipalE7yDvZNCISOGM/kWKnuV0CC4MXX/8zsn6tmYhd8Zy2FghUylBJc lasvB7vJjQ7Wa+pwaKtTXD4fW7brD239bFl8iPwoJ1ekhvlZRdWw4b7OzQiHxaPcqtkW 8TJLyBGhTts3AhwX0Wt63i4hk5kCJPVtBqxiBKxzr+F7QBU2pIR7fmW73K8fqKI9q8Sy VsdC9ex034MBzpJ/rZ8BtPyutsvHAig0xw1GDTdTzdMRmnhlKSx19vD+HGGiJsYbjdIF 6ZeBFtKhJctJY1AemdXLH2DJFWmEW3I6dqDvZ9MHi7j7tbfmVZF69FB6RFL9b9Sn5+UB +3TA== X-Forwarded-Encrypted: i=1; AJvYcCVE5Ce5X4FiA47yQjgcmyjmQq4LBWhDAw0/83ejgjz4njTbOmeHEjYtYztrwYNa7PZo2MlS7kONoM66QTE=@vger.kernel.org X-Gm-Message-State: AOJu0YypV4e9hXoqGKWvbR2zBPkRuLwoNaQN1fGmMwjy4ja1TtqKJu9z dOrKRtAWEPUWJKLuwdbH3wOQA4r2qsN5IEhJETqCkksCKUANdsqJAqH2 X-Gm-Gg: ASbGncseqe+7KvhHiSiwg0xwBSzlxisdstn2FpH4wFGXdMhU61NgSW2X4HRUMh8jld8 yjZoaFcLSDMiqXLnFszl0OgjWgyOS6qNHKWJylll2ccBlSAhutz65/AnefSz0wK7ftA9GEB/wI0 m9/2LctavkJxcvnu84RBx4Q+Jygv7N837jamQJaSxt2zJMpHcEKn1uPiH06scODwJDkCzISRVh6 MY5+wU35s6hw/0ZB9n6XeF3IxjferzvcRGZIemIddtUQKbORbz6fWtGJSVYLKfqoTqekcI1lOwp 5EADwixo2XJ4pVUwMUEG5MBJFcIzNCp/w5wSS+dq/IPakgp7+ZbQNJSre1IyXiSaASpfTavuAd7 HU/quZKqsyOhGgETr6TAGj7q+1uN51sSi3nQZw5AOntDgadhAUNEoMarvvHp5CHNXLHTtxR1EYq tnBLPwy4Dq5YkiYz4yRiQ= X-Google-Smtp-Source: AGHT+IEUX7gdiNGyBxK7nkjr4GlpB56cu5CyrGhTV6Ssy/ycoKGnwri45m/PO64RRMTu5afoMBqkIg== X-Received: by 2002:a17:902:f792:b0:299:e041:ecf6 with SMTP id d9443c01a7336-299e041f532mr74992515ad.40.1763403054096; Mon, 17 Nov 2025 10:10:54 -0800 (PST) Received: from rockpi-5b ([45.112.0.172]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c245ecdsm147237955ad.32.2025.11.17.10.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 10:10:53 -0800 (PST) From: Anand Moon To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-rockchip@lists.infradead.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 4/5] PCI: rockchip: Fix Link Control and Status Register 2 for target link speed Date: Mon, 17 Nov 2025 23:40:12 +0530 Message-ID: <20251117181023.482138-5-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251117181023.482138-1-linux.amoon@gmail.com> References: <20251117181023.482138-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per 17.6.4.5.11 Link Control and Status Register 2 (PCIE_RC_CONFIG_LC2) reside at offset 0xf0 within the Root Complex (RC) configuration space, not at the offset of the PCI Express Capability List (0xc0). Following changes corrects the register offset to use PCIE_RC_CONFIG_LC2 (0xf0) to configure target like speed. Signed-off-by: Anand Moon --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++-- drivers/pci/controller/pcie-rockchip.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index d77403bbb81d..b3c9b9cbeb8d 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -334,10 +334,10 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) * Enable retrain for gen2. This should be configured only after * gen1 finished. */ - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL2); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_LC2 + PCI_EXP_LNK= CTL2); status &=3D ~PCI_EXP_LNKCTL2_TLS; status |=3D PCI_EXP_LNKCTL2_TLS_5_0GT; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= 2); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_LC2 + PCI_EXP_LNKCT= L2); status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_LNKC= TL); status |=3D PCI_EXP_LNKCTL_RL; rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCTL= ); diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 4ba07ff3a3cf..a83ce7787466 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -160,6 +160,7 @@ #define PCIE_RC_CONFIG_DC (PCIE_RC_CONFIG_BASE + 0xc8) #define PCIE_RC_CONFIG_LC (PCIE_RC_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_SR (PCIE_RC_CONFIG_BASE + 0xd4) +#define PCIE_RC_CONFIG_LC2 (PCIE_RC_CONFIG_BASE + 0xf0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.50.1