From nobody Mon Feb 9 15:07:26 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F1330B520 for ; Mon, 17 Nov 2025 18:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403050; cv=none; b=isfMqQ+5ygN9mbrRY/vnFDrQ+xsWm53PvDelMgag8H2M3LFxwl6j5atV802C70VB0/RW9rAbP2C8ggEfE8eGFDrb13+HmbT4CNQOHd/ZZXhnJzGqbfVpD9v0K8de+MBPrz6K4QIxWlUt5zzMKbM7syDfT9JqQZQ05U99cFLmPVI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403050; c=relaxed/simple; bh=tg+W7M8VKqn8W0/lY9mb1alVFak+w1PTvw1bgrtSemY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y+OUY/+bi0TF3V6/M7gtjP7rOk3OkUx+XOKpqH1uqlW13KmxV97OKF2W/qsg9yWMwYr6DkS3ElAX8W+tg7asGqZepNb9wVkeBHIgFNGI9/YdQiANskWtR3I4FEW59Y+EHTJzlqnny/hoPcwrE+Vwygo5Cj3aBNu8YVvfc6U127c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HxiFY47C; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HxiFY47C" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-297e239baecso51058435ad.1 for ; Mon, 17 Nov 2025 10:10:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763403048; x=1764007848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JVLSWaWwsAp3+Eeor9R4CziFFyAk8nsobOp1lA8YjmQ=; b=HxiFY47ChLcM3AhJPpeRzYwjmGrNvOLLUmS9DyLlCgx5V00a5QE5AnDv/l5wffP/qn FWd1EwzNhoYyOfxxAyjQRFpXkusJX1Ka9J0CUbe3sOOkofnLitpW0peKFZ5u6DZDoY5o e5P3U8fWvbwmiM8yBjXYXW+bMdy5IOq/sRH4kG9hUm5rDFYfFgfqWwwEDPoVzKNkr/ce qIp2W6SY51RH8EwWRRXPA0f54D6cRIvg0ZkLNmnMbNpcMVdhBMj1fxO2v80TSGjoyAl7 5peWWzfahS97ily2nYsOccoKtBgRf0Zp60C5sGMC3HT9povRZIPr4PTFW85TIXvp2eYr 0XGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403048; x=1764007848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JVLSWaWwsAp3+Eeor9R4CziFFyAk8nsobOp1lA8YjmQ=; b=dhhmJX3VgFGFRzGHK5FIAxSqGZhZhaoQaz5AJpGyAl+pzpya8EgaNlRL0QrOfMnUpG 52p7tqCNpdBTklRlWPTDVSCJCv/WJ9P1OZoQrzPOWB8FRq4JcJPsWfEvwp8/mrr+mIew eDSyzP8fGE7PbofnciBDUmYrRh0ci2n0F3ElRxVDP0fzpU4dnUfCF9ztl9C6Agq8Ab7X hUB7cBXR5pzyZ4LzrHHlUz2bxgJB97W5t8O3a9g9Q9PATb69TPoHj8rrvUeBKlaocj6w VlBGpMyyPyhgt2Tj9xFHb7lE/ktwgf57uK0A5KPoP1NyL83tsQO/uuVkcWNRdlaQSLEj rDMQ== X-Forwarded-Encrypted: i=1; AJvYcCX2+NvJKJHrFyKxXXQlCofzNIhUJ5lvgLBf00JUK3dvgvS8T/G4Jll0mp6IUOrUsNqKCqxhsFDh77FxzTA=@vger.kernel.org X-Gm-Message-State: AOJu0YyooMODSJe5L7ZLtGkCXWNFEQpbXyYDRJPJZSsDTXGnv2G86Oo4 BNkRnDf2noM9dBQRir0HKFcPvVmYotCQAvyGcIGL0zVtZgkEz9KiIwC3 X-Gm-Gg: ASbGncsnxeQEHfn0C025/8fKrIELW0JHalzsz5LZCnhlyQOZv7laajwboax3TpgM0FG SFgUBVAfD+lHh2lwUDcPbaKFQfMoU3o/z9QNKioUFfgkHQTDxrTUNjQ033A1EVW/6AxSGWsu32F WGshiRxYpb6EYMgPJ3zdse5v134faQGxPVxGWjSEc+NaqbbXHZqtbVgTzwovXjdue9lRmoUOXtU 53dWnBLN4wGFHhSA7RKFnTf0hCYpHb8FZQdJ0QjZ6qpT0Vjvs4q4wB2bOQtnFkzMSoyL6d2B3Nv 1cyKMsQM6GxNtT09aogC3Ik4MTdBa9KLkV43vMbVMLDFkUCDbB292sYxgko4waF4W/6pa9okFEz 7lLwrHheR2x1IYFCcvSRlR9Ui8sH5M+EZM4c+WH10Gcfdf2igdsiuLmoyoeNMmQmCdmfXpeXG7H hGkItH38+lEtTSJ51fomw= X-Google-Smtp-Source: AGHT+IFUr6w+luRVnOQpM4WmiMJo7zQ/XIZfnSsFQLDG58hBrdFqWOCIG0FqA/4JweD+fOt7hbYKag== X-Received: by 2002:a17:903:120a:b0:298:45e5:54a4 with SMTP id d9443c01a7336-299f54f8517mr2495885ad.1.1763403048271; Mon, 17 Nov 2025 10:10:48 -0800 (PST) Received: from rockpi-5b ([45.112.0.172]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c245ecdsm147237955ad.32.2025.11.17.10.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 10:10:47 -0800 (PST) From: Anand Moon To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-rockchip@lists.infradead.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 3/5] PCI: rockchip: Fix Slot Capability Register offset for slot power limit Date: Mon, 17 Nov 2025 23:40:11 +0530 Message-ID: <20251117181023.482138-4-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251117181023.482138-1-linux.amoon@gmail.com> References: <20251117181023.482138-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per 17.6.6.1.32 Slot Capability Register (PCIE_RC_CONFIG_SR) reside at offset 0xd4 within the Root Complex (RC) configuration space, not at the offset of the PCI Express Capability List (0xc0). Following changes corrects the register offset to use PCIE_RC_CONFIG_SR (0xd4) to configure Slot Power Limit value. Signed-off-by: Anand Moon --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++-- drivers/pci/controller/pcie-rockchip.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index d51780f4a254..d77403bbb81d 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -271,10 +271,10 @@ static void rockchip_pcie_set_power_limit(struct rock= chip_pcie *rockchip) power =3D power / 10; } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCA= P); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_SR + PCI_EXP_DEVCA= P); status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_VAL, power); status |=3D FIELD_PREP(PCI_EXP_DEVCAP_PWR_SCL, scale); - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCAP); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_SR + PCI_EXP_DEVCAP); } =20 /** diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index c0ec6c32ea16..4ba07ff3a3cf 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -159,6 +159,7 @@ #define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) #define PCIE_RC_CONFIG_DC (PCIE_RC_CONFIG_BASE + 0xc8) #define PCIE_RC_CONFIG_LC (PCIE_RC_CONFIG_BASE + 0xd0) +#define PCIE_RC_CONFIG_SR (PCIE_RC_CONFIG_BASE + 0xd4) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) #define PCIE_RC_CONFIG_THP_CAP_NEXT_MASK GENMASK(31, 20) --=20 2.50.1