From nobody Mon Feb 9 15:07:26 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2871C31196F for ; Mon, 17 Nov 2025 18:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403044; cv=none; b=DsYAHcQzhQGXo31l0foD1Yke8cxBOrLp9u8UvRCsLmvY8NuXg3w0wk4qx0ybvdWs1na6lVBYxdkZmiRsH/q4nceSfdPa6zEZo8XkmYCxJ7NCxp6kEngqk3XT5cUjMyfq9t84tCGcReaX+mE0XuZjV/Qd89ggArurcKX1rZmwUjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763403044; c=relaxed/simple; bh=8FLrRgdCqSoWhuh1HthXwgdAsewLqdyV4yFxFtG7lc0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EDMXUA+Ot2lzKBXCYGW1ML3/0Qi7JLuPnt4S/Bo5xLm72gnpYypB8ihXMQnWbMIwJ9rsCPNNvbxwGy0Ox/uff3cA68fEfjs5UpYe+mrbFFNh0NbeW+S4h5vOJN/2T4jPMgp5ZjcyWWNa/6tmlya/bw6k71+GQd7fmn3egIsn/4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gLVHa+xl; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gLVHa+xl" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-297e239baecso51057285ad.1 for ; Mon, 17 Nov 2025 10:10:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763403042; x=1764007842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HiyfD9o81mhFVe2IXX22fSEtB3j8hw+9RtRzlWaHF9U=; b=gLVHa+xlWhsUIdswBmEdOiCLbL5CNwN7DGLn38vbvn2+BggJgSaBhLRupxotYaXCpU M1xYnBsnDcVZ3riqbEDy6FwNAVYaLvjPW73zPsYR3N5SxBqROZ2/zpBVssQb+Zkf5hPQ vAeZUi3xxFmTJoO4SBBmm3Aw6F0UyTLkcXNWElh2TpISL5rcgeiF9lAPsjLUJy2MPgB7 uYicwZVjVjH7FxfpWZ6/ZIWB1ND4jrPA2PFKv3RQ8JxcjJfyGNlP8OSxheVzs5V7Nk1p 0DRcpPGmUbseXzjijLXTmv1VttL03sVMp2CB+smeQrEHXI41geSbdkTVDqXjnKUauGT8 qxnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763403042; x=1764007842; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HiyfD9o81mhFVe2IXX22fSEtB3j8hw+9RtRzlWaHF9U=; b=Ph7gBTxsRXDr3qh/fWMOr4vNOH1Y8WR/n/4yNaoKpFL1/spVqsHiKWhrn1RuE0uXSM qirfcEEBDKK/bCtTlX4KIt8ZTHaShVM8HogHbgJhMD4nGc1Qna8Cz8PK5GJXWBAjf8Jv DoU34Cj9bqjI3hzyRbCcPL+6EbZ7LSAkiULqTDa8aLsdxu9zSU8tgOoNz4DjQlCcVzap 7xcZdRDcGxHbDwVY8twk9Te2oMAORhXG0iZdjIhFfl0D/mMDGnmMRbMNr52ngo3fN8jm dZ79r4+t2WDblvJ5jjWWxxq2EvEgn1qAflzikIg8Eg1P6aDjyU9T/Qra9JszIg66QD8n IFjg== X-Forwarded-Encrypted: i=1; AJvYcCWzqnXInUrn0KfhgZFCJFT14Ru0EwA8YTVdwYGRXGgYO8kbQYwW9NojamiVJ1KraGUhutxFlU5bYnHGY+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwNb7cpzn1Fe0xPHBBzyphU2yAd2cgYb1qomnsMmAacrl1+0OMP lJve78pObXRtztx0h4BEBnswwMPH0JUy5/O+osjk1+2PYch7R6soaCtU X-Gm-Gg: ASbGncvlTkAwCSCVrLEAoU1IDKKyPY9Q35FNknMVqzBV2aMADxCQLLDDl5H/ANH+7LE Hw9zsM4iH6X4ktmyucbjou4+z9QWSkYRu25d1z2mjDUxMf//oS+Wv1bdUaCeXZP/VJxDfj0+b18 28RMpp7zyIKFYnayR6pxG+9uDngrzikoHbGSRyMjUt7TA9OTCr7JRCgpg5WHy+QyjZ7u06KTAkl llhRb5d2y67fMGrrJKhJZl7whWTW9ujkyfIo4Z9YFjaAo2WSTGaLlGNLr5M8QPR8xYP7vaai9ph H5D5NILIz9FHSOoG5AfhzWrYRPbtZlgoEiFlt/2JNnRGMIvDW4gCIfzr/GmFGumaiQXQkNA5cKn ndZ4jVbN1s4HNdX/2pnAJ0Fohg9CUj4+QDY3OcJy5buBvjZUvaY5ju/a+eTi6FLAn++iqdLdcQa uG3LmJ6oG2 X-Google-Smtp-Source: AGHT+IEuH/QkCta7rSFSTx6mLuh1Na7bJwzHG+M7fE+y1+6A8oUVr+VmAtfVcXC0t4C1FaCf1X60/g== X-Received: by 2002:a17:903:4b30:b0:25c:43f7:7e40 with SMTP id d9443c01a7336-299f5512becmr2969585ad.10.1763403042469; Mon, 17 Nov 2025 10:10:42 -0800 (PST) Received: from rockpi-5b ([45.112.0.172]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c245ecdsm147237955ad.32.2025.11.17.10.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 10:10:41 -0800 (PST) From: Anand Moon To: Shawn Lin , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , linux-pci@vger.kernel.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-rockchip@lists.infradead.org (open list:PCIE DRIVER FOR ROCKCHIP), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Rockchip SoC support), linux-kernel@vger.kernel.org (open list) Cc: Anand Moon Subject: [RFC v1 2/5] PCI: rockchip: Fix Device Control register offset for Max payload size Date: Mon, 17 Nov 2025 23:40:10 +0530 Message-ID: <20251117181023.482138-3-linux.amoon@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251117181023.482138-1-linux.amoon@gmail.com> References: <20251117181023.482138-1-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As per 17.6.6.1.29 PCI Express Device Capabilities Register (PCIE_RC_CONFIG_DC) reside at offset 0xc8 within the Root Complex (RC) configuration space, not at the offset of the PCI Express Capability List (0xc0). Following changes corrects the register offset to use PCIE_RC_CONFIG_DC (0xc8) to configure Max Payload Size. Signed-off-by: Anand Moon --- drivers/pci/controller/pcie-rockchip-host.c | 4 ++-- drivers/pci/controller/pcie-rockchip.h | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/pcie-rockchip-host.c b/drivers/pci/cont= roller/pcie-rockchip-host.c index f0de5b2590c4..d51780f4a254 100644 --- a/drivers/pci/controller/pcie-rockchip-host.c +++ b/drivers/pci/controller/pcie-rockchip-host.c @@ -382,10 +382,10 @@ static int rockchip_pcie_host_init_port(struct rockch= ip_pcie *rockchip) rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_LNKCAP= ); } =20 - status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCT= L); + status =3D rockchip_pcie_read(rockchip, PCIE_RC_CONFIG_DC + PCI_EXP_DEVCT= L); status &=3D ~PCI_EXP_DEVCTL_PAYLOAD; status |=3D PCI_EXP_DEVCTL_PAYLOAD_256B; - rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_CR + PCI_EXP_DEVCTL); + rockchip_pcie_write(rockchip, status, PCIE_RC_CONFIG_DC + PCI_EXP_DEVCTL); =20 return 0; err_power_off_phy: diff --git a/drivers/pci/controller/pcie-rockchip.h b/drivers/pci/controlle= r/pcie-rockchip.h index 5d8a3ae38599..c0ec6c32ea16 100644 --- a/drivers/pci/controller/pcie-rockchip.h +++ b/drivers/pci/controller/pcie-rockchip.h @@ -157,6 +157,7 @@ #define PCIE_EP_CONFIG_LCS (PCIE_EP_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_RID_CCR (PCIE_RC_CONFIG_BASE + 0x08) #define PCIE_RC_CONFIG_CR (PCIE_RC_CONFIG_BASE + 0xc0) +#define PCIE_RC_CONFIG_DC (PCIE_RC_CONFIG_BASE + 0xc8) #define PCIE_RC_CONFIG_LC (PCIE_RC_CONFIG_BASE + 0xd0) #define PCIE_RC_CONFIG_L1_SUBSTATE_CTRL2 (PCIE_RC_CONFIG_BASE + 0x90c) #define PCIE_RC_CONFIG_THP_CAP (PCIE_RC_CONFIG_BASE + 0x274) --=20 2.50.1