From nobody Tue Dec 2 03:02:38 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9A92C3259; Mon, 17 Nov 2025 16:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763396005; cv=none; b=da/Bd1sZhmrJlTTzG8qNpK9bJhzpmgb0MCgESR8Q0YPlnc7cLIxv5YeCIHVmliXUufsQYlAWLB0wA1GO3Ujtep3YWF65G1ewiuomylqSouzEPSjsct6ZuVlo20annbVzpYN5WVi9Bn9aC27EnLd1NWy9Evkks9nbrNBy8rfyv0g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763396005; c=relaxed/simple; bh=5jhp2qvO0rHVrq0HKmOWaRqTDSDSkNCr3jjIIuXsGzQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PqSkBBbjPLkoiPbagUdSsUvawqTWDabNOIRRiPUUsqbp2oGfm2lCPkWG1dMmmeY7R50lXwdVGtf9gEo/ZK27TSx1TiTVQzm1RLD7oKB/HM5v5HzELgJLetRabd2zcDpe4bvH1IJVIl5JH93LohRUGcPk86ryNPcvaD1M7OeiBpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OfCIpUhl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OfCIpUhl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 120A9C2BCB1; Mon, 17 Nov 2025 16:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763396005; bh=5jhp2qvO0rHVrq0HKmOWaRqTDSDSkNCr3jjIIuXsGzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OfCIpUhld0WTnUFtatmt7+0DZ7alHoRi4w1T/9y/nJCOqhH2F3dIxyoAFK1IaJ/i6 xdWTmgkNi90QwTx3LEorB8OiMETlsOw3Jo8yPP7WcfKk/mJ6i9MG6MbL/2Lg+bBP+B f2o4HxZTmySciGOMfKEC5ZnDF5YYJQx1ZbuAiufsMPpBKiSEKxTm7YyOzW2fJ2x9IP qacT39tDHvlK4BnB3SlNSYUhIZSiq1fF3FJOem5fGjKlcOHtBfIasClivrE0f27EH3 j6E3FL/cUaeDTY1RO5PTXewJTO9FUinkOPWi4z8wWuIo3y72XFrawWmwvDFuxuviWU RVddu56CzTyRw== Received: from johan by xi.lan with local (Exim 4.98.2) (envelope-from ) id 1vL1r1-000000002o3-0Y6X; Mon, 17 Nov 2025 17:13:23 +0100 From: Johan Hovold To: Vinod Koul Cc: Ludovic Desroches , Viresh Kumar , Andy Shevchenko , Vinicius Costa Gomes , Dave Jiang , Vladimir Zapolskiy , Piotr Wojtaszczyk , =?UTF-8?q?Am=C3=A9lie=20Delaunay?= , Maxime Coquelin , Alexandre Torgue , Peter Ujfalusi , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org, Pierre-Yves MORDRET Subject: [PATCH 09/15] dmaengine: stm32: dmamux: fix device leak on route allocation Date: Mon, 17 Nov 2025 17:12:52 +0100 Message-ID: <20251117161258.10679-11-johan@kernel.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251117161258.10679-1-johan@kernel.org> References: <20251117161258.10679-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make sure to drop the reference taken when looking up the DMA mux platform device during route allocation. Note that holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference. Fixes: df7e762db5f6 ("dmaengine: Add STM32 DMAMUX driver") Cc: stable@vger.kernel.org # 4.15 Cc: Pierre-Yves MORDRET Signed-off-by: Johan Hovold Reviewed-by: Amelie Delaunay --- drivers/dma/stm32/stm32-dmamux.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/stm32/stm32-dmamux.c b/drivers/dma/stm32/stm32-dma= mux.c index 8d77e2a7939a..791179760782 100644 --- a/drivers/dma/stm32/stm32-dmamux.c +++ b/drivers/dma/stm32/stm32-dmamux.c @@ -90,23 +90,25 @@ static void *stm32_dmamux_route_allocate(struct of_phan= dle_args *dma_spec, struct stm32_dmamux_data *dmamux =3D platform_get_drvdata(pdev); struct stm32_dmamux *mux; u32 i, min, max; - int ret; + int ret =3D -EINVAL; unsigned long flags; =20 if (dma_spec->args_count !=3D 3) { dev_err(&pdev->dev, "invalid number of dma mux args\n"); - return ERR_PTR(-EINVAL); + goto err_put_pdev; } =20 if (dma_spec->args[0] > dmamux->dmamux_requests) { dev_err(&pdev->dev, "invalid mux request number: %d\n", dma_spec->args[0]); - return ERR_PTR(-EINVAL); + goto err_put_pdev; } =20 mux =3D kzalloc(sizeof(*mux), GFP_KERNEL); - if (!mux) - return ERR_PTR(-ENOMEM); + if (!mux) { + ret =3D -ENOMEM; + goto err_put_pdev; + } =20 spin_lock_irqsave(&dmamux->lock, flags); mux->chan_id =3D find_first_zero_bit(dmamux->dma_inuse, @@ -133,7 +135,6 @@ static void *stm32_dmamux_route_allocate(struct of_phan= dle_args *dma_spec, dma_spec->np =3D of_parse_phandle(ofdma->of_node, "dma-masters", i - 1); if (!dma_spec->np) { dev_err(&pdev->dev, "can't get dma master\n"); - ret =3D -EINVAL; goto error; } =20 @@ -160,6 +161,8 @@ static void *stm32_dmamux_route_allocate(struct of_phan= dle_args *dma_spec, dev_dbg(&pdev->dev, "Mapping DMAMUX(%u) to DMA%u(%u)\n", mux->request, mux->master, mux->chan_id); =20 + put_device(&pdev->dev); + return mux; =20 error: @@ -167,6 +170,9 @@ static void *stm32_dmamux_route_allocate(struct of_phan= dle_args *dma_spec, =20 error_chan_id: kfree(mux); +err_put_pdev: + put_device(&pdev->dev); + return ERR_PTR(ret); } =20 --=20 2.51.0