From nobody Tue Dec 2 02:51:12 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852372BFC70 for ; Mon, 17 Nov 2025 16:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763395411; cv=none; b=p4uHQuCskzjqZ85YmMqFoWGIP1X1gMoG9UENhGL6q0iCkanHDUPKMrSajP67QdoOh3uIReDCnUakHMutB3hUOG3fCZ6MmYfbAIdIEzf8Ev0h1D/W+3kCR/sHW3WoD4kMMTGTXufCvhnwphVMPvJKps+TVUuBEPNO8nwssV3aYXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763395411; c=relaxed/simple; bh=fgJ0oKsC9Wor3hmAIYuRl3neqoNHP68eMnlZ9qGuNDk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=KB4vZg3RCZxJCDNPrfp3nrC32uY1FPnEpfF+rCfCTxJFZU2iW24l2Bda1lbDzT0RLFfD8ZptBmX/5ckXTVcYwfQJ3QN3b6MUyu8D28R6QjaHWVmIkCvbNJ8PB5p1+4AMNDd1Ou4JFaLXsYSTsaEatRliYD7OoxoTqQtCLCRik4M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in; spf=none smtp.mailfrom=ee.vjti.ac.in; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b=HqMRB6OI; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=ee.vjti.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=vjti.ac.in header.i=@vjti.ac.in header.b="HqMRB6OI" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7b8e49d8b35so5073986b3a.3 for ; Mon, 17 Nov 2025 08:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vjti.ac.in; s=google; t=1763395408; x=1764000208; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MzuQNBYv7NArFgr3nI31Kpsin1xb7tC1caQ516ufUgk=; b=HqMRB6OIEe39S3SLPVPoMz3m9f5uBQm11HTw6MJ7JDylqp38S+J1CtKlBqLT853qSQ +4CbdW6g58ikjW3dQ/dxdFFHhILhmgJ1/62c3hkjW9+Hq7LRAG6FTYNI8B2pQpmscLRM SjIRyRPnaU8lqYul4mU0zPF8aXqsgL1TGvSV0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763395408; x=1764000208; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MzuQNBYv7NArFgr3nI31Kpsin1xb7tC1caQ516ufUgk=; b=TvdU7JdCH7ATusnlksdr5/YtZe5ulIlamEU2R5dj9xsAo31h6Ieeus6N1IyMxUZLQy aU8s41iz+KtjRg8s9/g4gzjj664I+KDkJaFmYnj9pf1iFFtFa3yAzBHmvHTOo6r5uHkP pY3vOMJs00q7JGa+AL9yubOO1IDfq8ffSJWQPFZki/fSLP0SMYy6jg8JotTd5hz3oso2 RlMVUqiCSOia2aGWEn0vgpAFnvz6xpsO78/IGpJIEYastPI82twWYYU9SIpZcwHSKS3W pSkFR4nGcIwJ0ZXq/mi9JmbNgg8FAisEkXg0nli2GiLiul4ssOMG0Hmg2uIny1U3fcpH NuSA== X-Forwarded-Encrypted: i=1; AJvYcCUD2yWyzeYSgYh8p4PhNhzs2q7bZFJAYVf7KrfoYeEi5Ucnp1V6RK6ru8MuhjhvjxYFwxydzstu7EromOY=@vger.kernel.org X-Gm-Message-State: AOJu0YzQQSZaHVNFBVruotNATSAEYMzal0IUy3R0pkiRLg/HYyFEZp67 YZzzH7v3y0jxA4S/ZeOEQjf+EoFLzMSGrtU/ao7Xxckxba7Lv9K2rqu2gJLaM2VHOYw= X-Gm-Gg: ASbGncuoQitDUJmQkx6hXeM7ZKgkh0oeXnYnhXEJ4FsR278boHSCQkUIBmtEzcYJ4xF uow1fJZ81rksSCCpFsLQuW16r6RQFKbKIg8Y3AGJ0tr+2bbEcta0ziR1/sp63AQil4hOhLtja9b emzOfF+FrTk5onHlt73LV/X69w505pb4SNsumhDtDufc2FF9dib57smqQHaknV3WFkDFcp9aqkz wiz7eEgnkyaYe13P8P7k4lpW+SOMbijzNRBCmH0FO8kzsPeYtnHMy87rhYfmhu7Vo2WqAIl/I73 839y+RCYbVA4nabyv+juikiv/BTgZzfZjhbhMNm8vfVSLNcy8GA61deGMKWBdu1Tna2f8bOeoR+ Wxx+O+rOvq0X/Goe11wiI/yqtQowvMuh//HXyznlxYRWWli97g4MdTQjR526ik6mCDLpdkxXcDZ yjhKUkLJDDVSaYF3ijsGLsAhcQngXK2hiW36525LNsQvte/w== X-Google-Smtp-Source: AGHT+IGzL0bWnsq4FmPBdu27yCBxXs0Itdf427kC3rxQ/PwsLSeCU9RA55OJf17K9TLaawcbXmCoXg== X-Received: by 2002:a05:6a00:3cc8:b0:7a2:8529:259 with SMTP id d2e1a72fcca58-7ba39b918e8mr13828046b3a.9.1763395407352; Mon, 17 Nov 2025 08:03:27 -0800 (PST) Received: from ranegod-HP-ENVY-x360-Convertible-13-bd0xxx.. ([2405:201:31:d869:b34f:a9d1:b2ea:512f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9251c9a50sm13561566b3a.27.2025.11.17.08.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 08:03:26 -0800 (PST) From: ssrane_b23@ee.vjti.ac.in X-Google-Original-From: ssranevjti@gmail.com To: aahringo@redhat.com, teigland@redhat.com Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, david.hunter.linux@gmail.com, khalid@kernel.org, Shaurya Rane Subject: [PATCH] fs/dlm: use list_add_tail() instead of open-coding list insertion Date: Mon, 17 Nov 2025 21:33:17 +0530 Message-Id: <20251117160317.127978-1-ssranevjti@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shaurya Rane Replace the manual list pointer manipulation in add_ordered_member() with the standard list_add_tail() helper. The original code explicitly updated ->prev and ->next pointers to insert @newlist before @tmp, which is exactly what list_add_tail(newlist, tmp) provides. Using the list macro improves readability, removes a source of potential pointer bugs, and satisfies the existing FIXME requesting conversion to the list helpers. No functional change in the ordering logic for DLM members. Signed-off-by: Shaurya Rane --- fs/dlm/member.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/dlm/member.c b/fs/dlm/member.c index c0f557a80a75..c1b5598997b7 100644 --- a/fs/dlm/member.c +++ b/fs/dlm/member.c @@ -299,11 +299,7 @@ static void add_ordered_member(struct dlm_ls *ls, stru= ct dlm_member *new) if (!memb) list_add_tail(newlist, head); else { - /* FIXME: can use list macro here */ - newlist->prev =3D tmp->prev; - newlist->next =3D tmp; - tmp->prev->next =3D newlist; - tmp->prev =3D newlist; + list_add_tail(newlist, tmp); } } =20 --=20 2.34.1