From nobody Tue Dec 2 02:59:30 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E117338907; Mon, 17 Nov 2025 13:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763387381; cv=none; b=j7RfZUtY88jhcIWjHRxCUjjkRtFSUCxlRavbr6apL+AgYbWQ3PGZD6UvTY+l/J0DQaYoJuDuPOaxFPWsUrn8UPmVzmqbhQbpicFDwMQc0GsTeFe4EmB7CsxaSmDwIFoyUd6honNEvobmRM9vSWDxqXbZGbz+pNEK9QTyfpE8NG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763387381; c=relaxed/simple; bh=0Ce9YnAWCsx1/ujnSaNP62oIpLu+i25K2eyzY16YVt0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CSTkhvyILdRVDEuwN4M/MhiNHDxpLecLARv6N3b8p24TpKmLWi28UarNxHaS1tAPis1mIyWWIpW6y6bKvXjtSFEX4DfJPkwtjVSUh1ULTEFtToVtk5god9QkAN5f4FXkx1JWRMskfk7cXr2Du8+2vpAuGFw/It5EVTMpwqFqb08= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=n5KbFhJA; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="n5KbFhJA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763387380; x=1794923380; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0Ce9YnAWCsx1/ujnSaNP62oIpLu+i25K2eyzY16YVt0=; b=n5KbFhJAlRjO9QYSjEaO8lQKn2RXJFhCPk8HpcJ0STFMfxhuutSacaKd MHnXDFlIR7K2eLYrbms0lRiELtqeSvMTn5UbEEWljLnLMZVmiA7Q/oP+G 97ZkhIvQbBPnIQKrNlt74AiXc+fabrkZl+NOLG5JZzTtLgQ2K8/BsqhPK oCSee1FK3UD4E1hVYZLlKTh0oWFNG7CMyA4kl3rzI2JIT03NmIkeZhfQ/ TwQHRRROSm4AieHPxm87eXgXTSeyND2XLsa2Rz6LLKXftkBz2fgY0hoP6 YNNUmKbIStd3SW5z3/lWz5IGc52E6nSDa/SU3z5blNQyIujdPfzMq8Zqs g==; X-CSE-ConnectionGUID: gYdhe5iZRfqXsleS1fSAmw== X-CSE-MsgGUID: 7Szu+7YQSsGAXScLg5ts8g== X-IronPort-AV: E=McAfee;i="6800,10657,11616"; a="76846156" X-IronPort-AV: E=Sophos;i="6.19,311,1754982000"; d="scan'208";a="76846156" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2025 05:49:40 -0800 X-CSE-ConnectionGUID: nNUeO9DSRfSbTgvX+Fmxqw== X-CSE-MsgGUID: rL64JX27TOyEVVuVAUgoVA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,311,1754982000"; d="scan'208";a="190115733" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by fmviesa007.fm.intel.com with ESMTP; 17 Nov 2025 05:49:35 -0800 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id E347737E39; Mon, 17 Nov 2025 13:49:32 +0000 (GMT) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Cc: aleksander.lobakin@intel.com, sridhar.samudrala@intel.com, "Singhai, Anjali" , Michal Swiatkowski , Larysa Zaremba , "Fijalkowski, Maciej" , Emil Tantilov , Madhu Chittim , Josh Hay , "Keller, Jacob E" , jayaprakash.shanmugam@intel.com, natalia.wochtman@intel.com, Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Richard Cochran , Przemek Kitszel , Andrew Lunn , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Aleksandr Loktionov Subject: [PATCH iwl-next v5 11/15] idpf: print a debug message and bail in case of non-event ctlq message Date: Mon, 17 Nov 2025 14:48:51 +0100 Message-ID: <20251117134912.18566-12-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20251117134912.18566-1-larysa.zaremba@intel.com> References: <20251117134912.18566-1-larysa.zaremba@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Unlike previous internal idpf ctlq implementation, idpf calls the default message handler for all received messages that do not have a matching xn transaction, not only for VIRTCHNL2_OP_EVENT. This leads to many error messages printing garbage, because the parsing expected a valid event message, but got e.g. a delayed response for a timed-out transaction. The information about timed-out transactions and otherwise unhandleable messages can still be valuable for developers, so print the information with dynamic debug and exit the function, so the following functions can parse valid events in peace. Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Kubiak Signed-off-by: Larysa Zaremba --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/= ethernet/intel/idpf/idpf_virtchnl.c index 1099a44314ea..521d90d80e1f 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -84,6 +84,13 @@ void idpf_recv_event_msg(struct libie_ctlq_ctx *ctx, u32 event; =20 adapter =3D container_of(ctx, struct idpf_adapter, ctlq_ctx); + if (ctlq_msg->chnl_opcode !=3D VIRTCHNL2_OP_EVENT) { + dev_dbg(&adapter->pdev->dev, + "Unhandled message with opcode %u from CP\n", + ctlq_msg->chnl_opcode); + goto free_rx_buf; + } + if (payload_size < sizeof(*v2e)) { dev_err_ratelimited(&adapter->pdev->dev, "Failed to receive valid payloa= d for event msg (op %d len %d)\n", ctlq_msg->chnl_opcode, --=20 2.47.0