From nobody Tue Dec 2 03:02:49 2025 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361B4333723 for ; Mon, 17 Nov 2025 20:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763410462; cv=none; b=KQk8UC4GTfFDfXi9y7cjCsAaipyDYyfaxgPQ2Ir89dQ7BrUfIc5gATFqNZE26lDrEgjuc+GsEinLNObhgknMQgM9terfe5GzNeFcrG2TA+cYXPf1ewBE44S45QBIhF4xGE3GSG/fQRYAxzayCKV7ukbY4dLzGlzQhrFOmVZeMhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763410462; c=relaxed/simple; bh=tUilLqPF6SzmbypUvh0pDDtsvnGuYdJyG0lrVm8dnvk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CcZjAtaTZO2o8rnRJwLJgmTxLF9HLB1lCKnlpJDW3VXBSrPfrgK7zqzZcsOF7m/ugaKHMexqsVsqq3TigGCpx8+yA3ZKcODUcHpIQoZfEBk3SOgabBSHGCaJwJB0hqnIuIkxCu6URUSxNvMlJ4KIVrR6Ufz3ncKZvGUAlk1E6k8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mCccB1o5; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mCccB1o5" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-594270ec7f9so4374207e87.3 for ; Mon, 17 Nov 2025 12:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1763410458; x=1764015258; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=llhisBgVyW1mIvqEoq3wSr5faLynyoEF2VocpfmN4uM=; b=mCccB1o51CQH+KJEzMmYdNVTo8nFFHL60Dd5l29qbcJ/o4tCe+RDzlgoqZE/bISq29 DZBi0hh8TdKDwvBAp8rdEuyKL3MuZaWT9FoyTcH3lNeYQ/M/bmBwPIR21Imko/RfnI3s +FQwA7QqTErZoCdDiDl/zusMzDXSofaKv636c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763410458; x=1764015258; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=llhisBgVyW1mIvqEoq3wSr5faLynyoEF2VocpfmN4uM=; b=FBMTKJ6JYLOfTfavhl2q6RqA1pQkQxJ0fyN+jWFPrH9N7fA5BK00snKHi7kUWnG/Lv XNm1J9fivCyTxPt1kaYABNXzbGaNgYXYFUx2a0CQBCzMm1aydF2nXI0sQkmZZdK0eWd0 W1UtQGp7NxQSo8HOSMI4QYgvyu6DSO7ZhAHbijg9zRuEifTSS4RFZ4bBr9xCujgjazA6 ZdSFEM27i8zce+2Yx6p00j17qp1n/X1f4KJ9eyyOztPBcZj/5LGlftGtcnZYF3vhyLc5 SUgcGbEKqQ2EziwuQ6+vxp8ti53ACjxfOPmMEAstlDDtVoFiR7/UMWx4bkDhRzh0ZB13 cAmw== X-Forwarded-Encrypted: i=1; AJvYcCVGeZeJl4hVEoiQT/CDAN3Dhl4jPs65iCMX/NQXJ2SveLSN2gT6Mrg5p3tdarqQKAZG8PG//zBTSaIhf5Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyyH7ByIIQAVlqdheZIu7f1Ra4/OP+Ptsf03AFbZgOIRipIJhwZ buMplwxSHQD3UHBmvabqEV56juU5H+Y8/jtTNJvoVLY6SiaX5EqahZ+Ijo64J0T91g== X-Gm-Gg: ASbGncsiydtChsxqJhD/nZun5cZPBPMZX6joD50mIaiSkJIr26CpYJ6ZC3JASLoMIVX vZa/NRKb3hhW1s2f/N8APqqjyYAH3hKmEY4JIqqWQxWWcPGKbfkXBrpXaZI2zx/EY2IHp+pfzdx 420m/AoJpxk5faz0/Oo7UZBcGxJc+yIUyvnXUUsOFmpPkuZtWTYLCdJ6ZeE9e4yNnjvsWHfbmU4 3CjlZDPgCI7FdOMjcSndSBwAdQDWr80l1P4nFJW/rGTK7mzPoGf2kFFpgWTZNQOnWCmom6m7T9v PMEv5qP5jivlJcLfBT7u1yOD8yA2Dnq5jxcPdrWaIAmFKFe2eJ+kCTH/tlu2rznki1Xn14uH2Zg 54ZssXanGNDqtgCoRd/pExiOF9xPa3Fg1T2HZDXiC/ivpA/68NhruY8eB42FqHtvg/ntW8BBC8N hq3eH8lhrCgnQaupqO/u1Jdpk8nh2o7lvW6AB/OaUD1u24tnAUIEzO0RRAbwKQ872HYuAyemAp X-Google-Smtp-Source: AGHT+IHqA/rZVuUUTwCH7FDfVPsb0ar2Z5rIxo0AI3uwDk5VfFJ6s5EDzJh5I1/3N26JtJcj3MUnfg== X-Received: by 2002:a05:6512:1289:b0:594:4fee:c1db with SMTP id 2adb3069b0e04-595841f99b7mr4455750e87.43.1763410458288; Mon, 17 Nov 2025 12:14:18 -0800 (PST) Received: from ribalda.c.googlers.com (80.38.88.34.bc.googleusercontent.com. [34.88.38.80]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-595804003a4sm3413302e87.59.2025.11.17.12.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 12:14:17 -0800 (PST) From: Ricardo Ribalda Date: Mon, 17 Nov 2025 20:14:16 +0000 Subject: [PATCH 1/4] media: uvcvideo: Remove nodrop parameter Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251117-uvcdynctrl-v1-1-aed70eadf3d8@chromium.org> References: <20251117-uvcdynctrl-v1-0-aed70eadf3d8@chromium.org> In-Reply-To: <20251117-uvcdynctrl-v1-0-aed70eadf3d8@chromium.org> To: Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Greg Kroah-Hartman Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 We announced the deprecation intentions one year ago in the commit commit 40ed9e9b2808 ("media: uvcvideo: Announce the user our deprecation intentions"). We have not hear any complains, lets remove the nodrop parameter. Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart --- drivers/media/usb/uvc/uvc_driver.c | 19 ------------------- drivers/media/usb/uvc/uvc_queue.c | 25 ------------------------- drivers/media/usb/uvc/uvcvideo.h | 1 - 3 files changed, 45 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc= _driver.c index ee4f54d6834962414979a046afc59c5036455124..71563d8f4bcf581694ccd4b665f= f52b629caa0b6 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -32,7 +32,6 @@ =20 unsigned int uvc_clock_param =3D CLOCK_MONOTONIC; unsigned int uvc_hw_timestamps_param; -unsigned int uvc_no_drop_param =3D 1; static unsigned int uvc_quirks_param =3D -1; unsigned int uvc_dbg_param; unsigned int uvc_timeout_param =3D UVC_CTRL_STREAMING_TIMEOUT; @@ -2468,24 +2467,6 @@ MODULE_PARM_DESC(clock, "Video buffers timestamp clo= ck"); module_param_named(hwtimestamps, uvc_hw_timestamps_param, uint, 0644); MODULE_PARM_DESC(hwtimestamps, "Use hardware timestamps"); =20 -static int param_set_nodrop(const char *val, const struct kernel_param *kp) -{ - pr_warn_once("uvcvideo: " - DEPRECATED - "nodrop parameter will be eventually removed.\n"); - return param_set_bool(val, kp); -} - -static const struct kernel_param_ops param_ops_nodrop =3D { - .set =3D param_set_nodrop, - .get =3D param_get_uint, -}; - -param_check_uint(nodrop, &uvc_no_drop_param); -module_param_cb(nodrop, ¶m_ops_nodrop, &uvc_no_drop_param, 0644); -__MODULE_PARM_TYPE(nodrop, "uint"); -MODULE_PARM_DESC(nodrop, "Don't drop incomplete frames"); - module_param_named(quirks, uvc_quirks_param, uint, 0644); MODULE_PARM_DESC(quirks, "Forced device quirks"); module_param_named(trace, uvc_dbg_param, uint, 0644); diff --git a/drivers/media/usb/uvc/uvc_queue.c b/drivers/media/usb/uvc/uvc_= queue.c index 790184c9843d211d34fa7d66801631d5a07450bd..3bc54456b4d98ed50b1ea250ce8= 501e67141e1ef 100644 --- a/drivers/media/usb/uvc/uvc_queue.c +++ b/drivers/media/usb/uvc/uvc_queue.c @@ -331,34 +331,9 @@ struct uvc_buffer *uvc_queue_get_current_buffer(struct= uvc_video_queue *queue) return nextbuf; } =20 -/* - * uvc_queue_buffer_requeue: Requeue a buffer on our internal irqqueue - * - * Reuse a buffer through our internal queue without the need to 'prepare'. - * The buffer will be returned to userspace through the uvc_buffer_queue c= all if - * the device has been disconnected. - */ -static void uvc_queue_buffer_requeue(struct uvc_video_queue *queue, - struct uvc_buffer *buf) -{ - buf->error =3D 0; - buf->state =3D UVC_BUF_STATE_QUEUED; - buf->bytesused =3D 0; - vb2_set_plane_payload(&buf->buf.vb2_buf, 0, 0); - - uvc_buffer_queue(&buf->buf.vb2_buf); -} - static void uvc_queue_buffer_complete(struct kref *ref) { struct uvc_buffer *buf =3D container_of(ref, struct uvc_buffer, ref); - struct vb2_buffer *vb =3D &buf->buf.vb2_buf; - struct uvc_video_queue *queue =3D vb2_get_drv_priv(vb->vb2_queue); - - if (buf->error && !uvc_no_drop_param) { - uvc_queue_buffer_requeue(queue, buf); - return; - } =20 buf->state =3D buf->error ? UVC_BUF_STATE_ERROR : UVC_BUF_STATE_DONE; vb2_set_plane_payload(&buf->buf.vb2_buf, 0, buf->bytesused); diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index ed7bad31f75ca474c1037d666d5310c78dd764df..9a86d7f1f6ea022dace87614030= bf0fde0d260f0 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -659,7 +659,6 @@ static inline struct uvc_fh *to_uvc_fh(struct file *fil= p) #define UVC_WARN_XU_GET_RES 2 =20 extern unsigned int uvc_clock_param; -extern unsigned int uvc_no_drop_param; extern unsigned int uvc_dbg_param; extern unsigned int uvc_timeout_param; extern unsigned int uvc_hw_timestamps_param; --=20 2.52.0.rc1.455.g30608eb744-goog