From nobody Tue Dec 2 02:51:46 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA17A2877C3 for ; Mon, 17 Nov 2025 16:23:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763396583; cv=none; b=fba7cbIAalAdDw89sl2EYaXjwAKWnkEw3PzjNlJrWsUNoTuv01etXm/RG3L/QZZIeuXLFxY4/cwAaobMlUKprMBg9+6o1Vm9RtzCtO2SGtY4UyRbtUu2Ln8RQ9CoU5o4JixkaHtI/GS7OlodJri09qw5htnjLK5XOR4vrN1DAJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763396583; c=relaxed/simple; bh=GRv+OgmZqr9WuANHSfZbS1DVJRHeOc4x/LMiQstDn6A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Jt4PQAucRulu1EnS1vdQLcELeY0LYWvfqprqnLDdkDx/kZu+EzFPd8OQuKbqinkXK+2Fwo5U8EjkJinAleXECwHIIcoKP+XE/C/skuwVY0Xh7/wjbudEE1Lnq7afO63Q3xcPQGwmmxca3FwfVdFGQeACANVnkX2R1JvI5fpx4lM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=COZz9BkX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SXT4idqW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="COZz9BkX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SXT4idqW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AHB3Yap3517210 for ; Mon, 17 Nov 2025 16:23:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=GEDPf0dSRA/rIzrOWNr3jG W8qWLig0SWtECgPvdVTyY=; b=COZz9BkXb9rf1XTzfE9LoixR0PeRSoDVhPethN RbS+9v66pe8d+PVPrqExinNHR6a9/9gfxQ3dILAo/Csl0HY9d2vmdwkpncEHuX29 fm7nm9MIhHAcUFdih/9c63ibERLHQTTTkObt3m7UXm2nyZwgi6VEzDRl2YK/eOo1 ClqXPtkxAvyyciUk9Chg1btUKH0qNKqB655458CSmTEdaGCvtyAic+74/KSsmt7x rCe9Ee+YFrO6IOmH42+/hjbBzOCYVTJY6KTmqb2fWPeaKeDAzQKwko1aRME5SZrV mJWhOmTzIjMHLtAOJrab1hH5/DJ5zvuQqOhEYENOtkcb5veQ== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ag2gg8wnn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 16:23:01 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b993eb2701bso4496049a12.0 for ; Mon, 17 Nov 2025 08:23:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763396580; x=1764001380; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=GEDPf0dSRA/rIzrOWNr3jGW8qWLig0SWtECgPvdVTyY=; b=SXT4idqWz78kFDbW2rk4NVV2D+A4CjTveO0Vw20orKXafpiKJRfBDTybO+7w27U33/ ft2Kr6Pr3oknNCI+QTtOxiaymmTpa5zou9GicfaT5+EaatC2uoxdR3iKwnqEPVgLiGYN Z8Sn45soixGKg4bvQ2mYy2AByIUz+Kg4vBWf9Zdswq8CZhDsSJOcam53YbN0//3n0awL bMMPIe9alUm9y7uZCZKwCtaYaxR9Fsrv+yQtf2j5Vf6VMRvik1oPgz/Y5Enj2pTheAsx f0sHFzaXJUYipO0BuRn+jDyHmUrd0tOSkJ3VUleQJ4vU51JQt/Vwaqc6pVoK+Gwo1v0v uBSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763396580; x=1764001380; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GEDPf0dSRA/rIzrOWNr3jGW8qWLig0SWtECgPvdVTyY=; b=q49DRlF/ydO2/xTlwB/Qw6crzT8gviRfD8a3QvSYoRk6hJQGjxoV0aEDz7oxxXD7M1 ONGsE6GOKXzi7zaFmTm0sl5niQM+yMYLAb7KYG2sArH8FO7TxsvzmcxX4VatYiZspY+s CTmBCIUG1/qR8/ld9cWq1xYNB4/zu2H6+rc4DBjSLN6qZwGm7Yr7vyJzsUIReDWRkX2i oulzA6H66WFm5daL88EIvvyuUcSdOikHy9ZOqT8C3XGOweOUBWTXH4rtkNTqXRNQv58G gaDCWZdgNGc43oycuLkqHj1aBdj3AlSW6ypsBQhvGw6m6hpqv4YBjIk0afGMmiinwwcU FgTQ== X-Forwarded-Encrypted: i=1; AJvYcCVaJsKc4neSIGdUe/JQfTqCqs7m7B4KKxgJlxt6g+Tr5ODjkIjxcfci5f4/vJ5Lq71AaL3yhIuTeDxq6E8=@vger.kernel.org X-Gm-Message-State: AOJu0YzDzHSt1K2APLkXZS9fp2rZ/4zT7l8s/ANgbPRDR1VmQKhEreym xiYLe+JmAGO/1QvJ2ojBZeoFfSwkjhvlvt9bMMOZff6URnf2bUKMl+yG7My5n5SCjT6XKzjPnbJ m2cnwbYnWiukR9o6MEeH47mX774aopjSC4B0rtAm6k33ObC2jhMDNZNr9n3QlGkH6Miw= X-Gm-Gg: ASbGncsTwwmMTkzL5tspiXpeT2K9JJddpv5ETNVwCnCDghGH9qbo/5zNFqInhyMiGuP c7I4ZhEOYrCXeteRLjyvBS5CfN6NfvfnffAMTmv/BNNLhKaYJ2cQh7llBotylbDMIo1wR6uvSzX zZhC5DHwXvt2b57tsxLi0WzuZNHEkIg3PQFLPC6BICXKW1m/lkcdJwepUHeZY0JriCTgBeRmM9O fDz+f4eG2fngBVuJTmOuggb8xy4p4RJLzoK+EoEE4wz65/U2WYx6b+fAJ24BVi6UgEj5/3jLByg M+i1I4lXDijjVca2ObB4QPZ5iYypAiHEXhS3eOHeiJEQiyZt6SLuwoRhfC5iE2tRQAs90y3Oklw L+ttExxh4Dc4U9B1YGw5fda0LwGJ1TCN4kmNVVWl5Rl4ffjpvIXciHP/nMYiMFBVmPNjXxXtjes HrUlJZStVg/GXqG0ncv5Mmb4NHHZXcU8zik3Yo524oeCqk X-Received: by 2002:a05:6a20:3d1c:b0:35d:a2c1:3a15 with SMTP id adf61e73a8af0-35da2c1d84bmr7148497637.4.1763396580184; Mon, 17 Nov 2025 08:23:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFrg7dqfCrgKZXmPVFE3NO5SL+fBj0OTKre8wGliG58Y4pfYy8rM9Mxl8+upv1WZYREN74UOw== X-Received: by 2002:a05:6a20:3d1c:b0:35d:a2c1:3a15 with SMTP id adf61e73a8af0-35da2c1d84bmr7148468637.4.1763396579661; Mon, 17 Nov 2025 08:22:59 -0800 (PST) Received: from hu-kathirav-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7bf4d30e1a3sm4110357b3a.36.2025.11.17.08.22.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 08:22:59 -0800 (PST) From: Kathiravan Thirumoorthy Date: Mon, 17 Nov 2025 21:52:55 +0530 Subject: [PATCH] firmware: qcom: scm: Use __cleanup() for device_node pointers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251117-scm_cleanup_of_node_put-v1-1-307d36d6b849@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAN5LG2kC/x3MQQqAIBBA0avErBMaoaKuEiFlYw2UimYE0d2Tl m/x/wORAlOEvngg0MWRnc3AsgC9TXYlwUs2yErWiNiKqA+ld5ps8soZZd1CyqdTNLrDWmIz42w g1z6Q4fs/D+P7fmWDYalpAAAA X-Change-ID: 20251117-scm_cleanup_of_node_put-6c915216b1bf To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Kathiravan Thirumoorthy X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763396577; l=1891; i=kathiravan.thirumoorthy@oss.qualcomm.com; s=20230906; h=from:subject:message-id; bh=GRv+OgmZqr9WuANHSfZbS1DVJRHeOc4x/LMiQstDn6A=; b=V9Z+NdtQXcFuXacpGaORPdwmnDmXq6O9IaOimWLTgx1wsj5LkZCSXdB+KXRReDKQ/eCwILEly G4BVsNkMH1FCi1eXUYfuYXOEcCsq6LNj3kyltmFP0vACWf4Vhx2SglH X-Developer-Key: i=kathiravan.thirumoorthy@oss.qualcomm.com; a=ed25519; pk=xWsR7pL6ch+vdZ9MoFGEaP61JUaRf0XaZYWztbQsIiM= X-Proofpoint-GUID: Cd_bEOiy7NkAxucBfAQ5o803tr5V1eDu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDEzOSBTYWx0ZWRfX5sMAWcXjIWK6 3PcBmFszn6z7E284e1hBMEmJIQYnjBE9fhK9l63gqFrW6U/NNtBmJdwozx7ztiq0kRAxt/H8oP7 JC2HusKswN+tD1kJLEk++nOALF+KoyHw7mzdV3RF+/KSiwIvTq/L7ZdzrV9vTa5qoSOQbpWGRw7 LhjL6wXJOrjfqqOVmIsEyNt03AmnQ+b0+VkzMSZE2cxIPlu+STfm6/AzDrcy5Fezzy10jEqmFWV wxtHIZTg7rgmzjfC72jaDqlmBwq+j4HR8AbglLIcbSTpmDX7zokwVW4d43y2WVAT+SvIViWKRkC ALgmKcwOP+fLSPhUL7Ong6JGL5/WKl+JkK6L/tBCffSpPgmy11v5lBIwClRETrgP9sWjgkKGGJg EZ6P1OsDnlVKNrQu4+HKSG6quKkpcQ== X-Authority-Analysis: v=2.4 cv=Cryys34D c=1 sm=1 tr=0 ts=691b4be5 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=N6yGlkIinVOkEIgh37gA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: Cd_bEOiy7NkAxucBfAQ5o803tr5V1eDu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_03,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170139 Make use of the __cleanup() attribute for device_node pointers to simplify resource management and remove explicit of_node_put() calls. Signed-off-by: Kathiravan Thirumoorthy Reviewed-by: Dmitry Baryshkov --- drivers/firmware/qcom/qcom_scm.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index e777b7cb9b127944fe112f453cae9cbc40c06cae..7c1fffa8e7ad48b294b90e7e63f= 726d0ba7d55e1 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -1746,7 +1746,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_gpu_init_regs); =20 static int qcom_scm_find_dload_address(struct device *dev, u64 *addr) { - struct device_node *tcsr; + struct device_node *tcsr __free(device_node) =3D NULL; struct device_node *np =3D dev->of_node; struct resource res; u32 offset; @@ -1757,7 +1757,6 @@ static int qcom_scm_find_dload_address(struct device = *dev, u64 *addr) return 0; =20 ret =3D of_address_to_resource(tcsr, 0, &res); - of_node_put(tcsr); if (ret) return ret; =20 @@ -2020,17 +2019,12 @@ static const struct of_device_id qcom_scm_qseecom_a= llowlist[] __maybe_unused =3D { =20 static bool qcom_scm_qseecom_machine_is_allowed(void) { - struct device_node *np; - bool match; + struct device_node *np __free(device_node) =3D of_find_node_by_path("/"); =20 - np =3D of_find_node_by_path("/"); if (!np) return false; =20 - match =3D of_match_node(qcom_scm_qseecom_allowlist, np); - of_node_put(np); - - return match; + return of_match_node(qcom_scm_qseecom_allowlist, np); } =20 static void qcom_scm_qseecom_free(void *data) --- base-commit: 0c1c7a6a83feaf2cf182c52983ffe330ffb50280 change-id: 20251117-scm_cleanup_of_node_put-6c915216b1bf Best regards, --=20 Kathiravan Thirumoorthy