From nobody Tue Dec 2 03:00:10 2025 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45BEC1DF27D for ; Mon, 17 Nov 2025 13:06:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763384769; cv=none; b=Z8VCwyeY7OasCUqMg1ZnH8aUYZlkr2uwd9Otal4E9/NELHeYt05y9jU8ctsYSHo/H6txZgAos17qXIv+TaYJdyMoMwHrUwmg8/rFQyrkWJvO1nEvJx8+5f/ByOoFMBL4oreO2uOaE70DnwSv2OB/HHIB1/Tx0T5urvOa2Ucbtf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763384769; c=relaxed/simple; bh=dtd0+nF+bp/Pfk/d35cPc0tB+EATqNkUgd8y1OCFLQI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BdWnHbfHcpXMVcnr5Ky7kY9/G+KcIM2fgAO5qN2v39mmDvkW++mQNi+gIq2UhcWIU1ujAQznsuQ2yPfhgvjBJ2H58TUZlaOEggKBgI7NhDhtmPuj/aAD+PqvkDXc1FTX2/a77V3sFCQK7RuOj006yyAEkpEwrJDhuqVnoRN0hoA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=F0S1WWiS; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="F0S1WWiS" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id 6E6D71A1B7A; Mon, 17 Nov 2025 13:06:05 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 43A0D606B9; Mon, 17 Nov 2025 13:06:05 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 168D310371C1B; Mon, 17 Nov 2025 14:06:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763384764; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=dwsKotiDEJnhW0UR2k6JPDo93YR2yL0iASSN9Mxocl0=; b=F0S1WWiSxYq0ajYh4BY6fctSMuRPpLkAKAQucYCY3NX4tuh+wqCA33EV86iKwggVwVH15T iedFB9vdLgvZdB4SjAaecM9GAwc2c2ms0xoUdziEq4zilSaBr0q1wJRmGetrqDIgnwY95f Dnv60NoX7myqq9TH2weDpDZ/BwFOl52DPltNFY3S0S0QFV7Gqcmvz++EoA3XuNbpMAG9qG SvYNsQ5cNCl4srPwLmOPXgDDgOVaV2N1UEUs7AePcfYAz1d7E821yw/Xotxcr8MkI6fDvB 2o77gRDumERUPAQpt6tzqH9n+i8YKQK8jNhaY/0CResb+/wgS2zLBqDFAu6jxA== From: "Bastien Curutchet (Schneider Electric)" Date: Mon, 17 Nov 2025 14:05:43 +0100 Subject: [PATCH net v4 2/5] net: dsa: microchip: ptp: Fix checks on irq_find_mapping() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251117-ksz-fix-v4-2-13e1da58a492@bootlin.com> References: <20251117-ksz-fix-v4-0-13e1da58a492@bootlin.com> In-Reply-To: <20251117-ksz-fix-v4-0-13e1da58a492@bootlin.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Arun Ramadoss Cc: Pascal Eberhard , =?utf-8?q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Bastien Curutchet (Schneider Electric)" X-Mailer: b4 0.14.2 X-Last-TLS-Session-Version: TLSv1.3 irq_find_mapping() returns a positive IRQ number or 0 if no IRQ is found but it never returns a negative value. However, during the PTP IRQ setup, we verify that its returned value isn't negative. Fix the irq_find_mapping() check to enter the error path when 0 is returned. Return -EINVAL in such case. Fixes: cc13ab18b201 ("net: dsa: microchip: ptp: enable interrupt for timest= amping") Reviewed-by: Andrew Lunn Signed-off-by: Bastien Curutchet (Schneider Electric) --- drivers/net/dsa/microchip/ksz_ptp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_ptp.c b/drivers/net/dsa/microchi= p/ksz_ptp.c index 35fc21b1ee48a47daa278573bfe8749c7b42c731..c8bfbe5e2157323ecf29149d190= 7b77e689aa221 100644 --- a/drivers/net/dsa/microchip/ksz_ptp.c +++ b/drivers/net/dsa/microchip/ksz_ptp.c @@ -1139,8 +1139,8 @@ int ksz_ptp_irq_setup(struct dsa_switch *ds, u8 p) irq_create_mapping(ptpirq->domain, irq); =20 ptpirq->irq_num =3D irq_find_mapping(port->pirq.domain, PORT_SRC_PTP_INT); - if (ptpirq->irq_num < 0) { - ret =3D ptpirq->irq_num; + if (!ptpirq->irq_num) { + ret =3D -EINVAL; goto out; } =20 --=20 2.51.1