From nobody Tue Dec 2 03:00:10 2025 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A1F32E6AB; Mon, 17 Nov 2025 13:06:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763384767; cv=none; b=X/8DELWW0hyZ88YC6xEQnYtwZuOhiAUzixngVv5E8f0/jcwIn3cQRafVaQRpRzHtnnmyVMMO834e3enYUj00enzT3ZHN1czQTiXRCH8MfcgeBF/yGzOR0sItuqPU9iTqA82v6mbLVHkDw5lZb5lv/b7T0c9zBQwf+Xm8uGgC+n4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763384767; c=relaxed/simple; bh=Z+tuxarBHcRf03hexaRUPHmiKA1sZNeRDUlTYTEkTIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aPT8VkDI/IfdoyUHIoAhe9QoOBCm4ZXUpD0FEQkk23b7oMvHlpClk8Eo59u4v3+tMCwC/zkORW7dSKqt5j7cyiPk75mzP9KWvfZAHv0ovoelMCzzn3MWlmF6jnj8Xp/erocE/1gCiUGP/Zdgw96hz9QgdpUUrTNjvadAG6mvU8Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=tTbcMzAI; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="tTbcMzAI" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C382A1A1B79; Mon, 17 Nov 2025 13:06:03 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 997B5606B9; Mon, 17 Nov 2025 13:06:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 74CB010371D32; Mon, 17 Nov 2025 14:06:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1763384762; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=CvnWrT3thpWNlYlyOwUMzAwg6Afa8Xa8RrmUZcVmlZ8=; b=tTbcMzAIimDwj+5GmnWQtvaBulYfZ9JtQsE43Pdod3tbZDWueebeSDP0/npF1pvDkzas6E LPeqCPKQk9AQ5QFXlKivaphtVC9yKF1JQhNy1bJGToNmhk2gWj8YVx1zc/9rlYQavkAo0w U05+Os/E9jsdYD/E7MbSEKoSFbh48oOxvbHsOVrgE3ng6nfgGjikhOv/lCsQyVOHnJ5x9b xejMZMQWofjDingQTCt6GYwmeWFD2vbkJnM0mflTF2eP9QSiGD47TKyB0iF2n1RCzbeF8J hyz1igeZFbyIBIqg75S1qPs7Vcw+fWVTuAl5ZFT7BIJcfBT3I8gEECGkGtljTw== From: "Bastien Curutchet (Schneider Electric)" Date: Mon, 17 Nov 2025 14:05:42 +0100 Subject: [PATCH net v4 1/5] net: dsa: microchip: common: Fix checks on irq_find_mapping() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251117-ksz-fix-v4-1-13e1da58a492@bootlin.com> References: <20251117-ksz-fix-v4-0-13e1da58a492@bootlin.com> In-Reply-To: <20251117-ksz-fix-v4-0-13e1da58a492@bootlin.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran , Arun Ramadoss Cc: Pascal Eberhard , =?utf-8?q?Miqu=C3=A8l_Raynal?= , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Bastien Curutchet (Schneider Electric)" X-Mailer: b4 0.14.2 X-Last-TLS-Session-Version: TLSv1.3 irq_find_mapping() returns a positive IRQ number or 0 if no IRQ is found but it never returns a negative value. However, on each irq_find_mapping() call, we verify that the returned value isn't negative. Fix the irq_find_mapping() checks to enter error paths when 0 is returned. Return -EINVAL in such cases. Fixes: c9cd961c0d43 ("net: dsa: microchip: lan937x: add interrupt support f= or port phy link") Reviewed-by: Andrew Lunn Signed-off-by: Bastien Curutchet (Schneider Electric) --- drivers/net/dsa/microchip/ksz_common.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index 2251ab23859b93a4f8af30a7d9c209ca64121408..c724f5af5d98bf3ff784e36393d= d5b3fa7b37c13 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -2584,8 +2584,8 @@ static int ksz_irq_phy_setup(struct ksz_device *dev) =20 irq =3D irq_find_mapping(dev->ports[port].pirq.domain, PORT_SRC_PHY_INT); - if (irq < 0) { - ret =3D irq; + if (!irq) { + ret =3D -EINVAL; goto out; } ds->user_mii_bus->irq[phy] =3D irq; @@ -2949,8 +2949,8 @@ static int ksz_pirq_setup(struct ksz_device *dev, u8 = p) snprintf(pirq->name, sizeof(pirq->name), "port_irq-%d", p); =20 pirq->irq_num =3D irq_find_mapping(dev->girq.domain, p); - if (pirq->irq_num < 0) - return pirq->irq_num; + if (!pirq->irq_num) + return -EINVAL; =20 return ksz_irq_common_setup(dev, pirq); } --=20 2.51.1