From nobody Tue May 26 17:10:07 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1DF330DED4 for ; Mon, 17 Nov 2025 04:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763355105; cv=none; b=n66g868WvVuT+eoFXbfpQg3A6pt2mnn46loQ3zNNYsmZAT42UmpSXQ7M1uyNq4AcI3KnfO0qjC7e2qkA2KdCF5SMOFB2PwPqGDAZjJOMyPhL0B8ii5s8OANLAAkToztg0rjalZqy/NWHnKQv3t4AueMfBt6vdstfcLRqyLQjl04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763355105; c=relaxed/simple; bh=knnJGoJD2i+Kk5EF5Jxn55PSS4tA+N31y52aSSy4OPo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HtdFI69lGJ6oIBlN7jizR3a6nrBTXd6825U0uVtLRj7a4HzA7QdUF9VDKCZeH73A6imkz+iw3/Lr5Cr5io4Eh6IP5MqUs6WzFjLNT9sGwFHCNA5XYnFgkpqBVJHu7zeT0n+tdzP+aZd6JE6JwnMLuTQkDmQroc34uIlmNjXwbgk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OKyk+l6R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TIabqL3T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OKyk+l6R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TIabqL3T" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AH4oGbM2911347 for ; Mon, 17 Nov 2025 04:51:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6jmBsZ5qHd+zs7d9+EtVIo+ndIwQKivV4VR1k136ncA=; b=OKyk+l6REK9oqAFh eZ2IsHoKtUMIlWHyqJf2pNKUXI318OwntRrv47b/vUbFVHnTWUjfdmJRTZThk4Ix vFZ5bKFyZdvF39yCAJWtBsnbffbKrIk4RsmSmQYslqmWKcjDa/KuYH/Jqtek9po7 36I0pewg2h+znHARKXAugunbyRL/Ve3z84QYFIhW0DLl+2U1PcV7IcRYVQpgNTOc LB3OaLlsLPzy6x8fjH8fDMSNJSFSjxVAbcgQiALFEq5El5DNyXpMBG/lt8MNFNG+ b3F4v6FWMVvb5xHUERU0kTRQ76e38HBrJglqzXW6FzO5hOgOQ2tm+16vKBFxu60o N86zPg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4aejgcbbkb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 17 Nov 2025 04:51:42 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2980ef53fc5so55965985ad.1 for ; Sun, 16 Nov 2025 20:51:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763355102; x=1763959902; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6jmBsZ5qHd+zs7d9+EtVIo+ndIwQKivV4VR1k136ncA=; b=TIabqL3T37qdNTexQq8X8ExlU+tc+F+RXIOpwu4AuiQltggM9uqhrK3xeoOdhiOMWp DoxTKVIR75ap1e4qii215FmPo5kBlm66ETMfnFQkNVjy0Vi5e8ilqNSqyh9XlkOGgfOI iEwKpdAr4I0/mwTPPf7JNHDcvWG1ukgGYNMTTt6xKoLS5aUQuJAgmd2hl25o+PgNVT7D +YK+nyIJRm8sa5Xn9dj71miUzJSAphKryHSEH3MykJTb0aB2Ek2ebVn2OR9iKrklLEIf UMCIi3kCrnCZpvp/liuLCA9Papie63GFPDnXEqIyroeALJtliXEIqSfL05vHPTLDknRH ZnTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763355102; x=1763959902; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6jmBsZ5qHd+zs7d9+EtVIo+ndIwQKivV4VR1k136ncA=; b=sByMttbU10TRurKcUMTL7RuTcq019TZ8DgfO4VwMzJBEaNVI4WnBaeO9XQPGr3C6eX pK8qMVTT61+1weypy0BMy82rYpWHbWi0OP17cMoIn0UhvCp/z/LvbOPfM2cyRT6n/azy S63W1KOFrnC5WUNpFyNnvr+Zt8G8nv0uzjlY8JjndibwawIaPpzvGm83yRLCgjhAdvLm p+lSq2zE6E83WrF09Gq19KH0ncF+EDStl0VyT+h7xBPrZS+8Tg0GVXN1TZEjPlSkj2UU 6He62LdMmkQdN0TAbiOiV4F9VyB6TlJEXamlKA7sIQ/EXYgzqqvvCJ2MsYr8TNdDB3Ln eZXg== X-Forwarded-Encrypted: i=1; AJvYcCWLlKfMcvPY9Z9Qwk4aUIqcGCP3t1Bkxws5roOy7DPslSzuObLSm3fZXo5oM37H4JUMEbVwNmrzgLgesic=@vger.kernel.org X-Gm-Message-State: AOJu0YzXVebipu666vgzhSwSrx0j89u5C2kZdVyhKNoJW/YIqIJslKya th+w+TJ4YsVbP2RRCOaW/sq0Bx5EdI+HKlfBl+o5+tqSiu97eW1BLAbxNLBuJdxpE6J6OOP8fDJ XjHCyhsZtJYJt3GrbDqfxXEkHZ7nEj33l5E1if9dn6j6Z3XLVlHkQ57O95fANsohxBgVpEH3SiN Y= X-Gm-Gg: ASbGncvvuwK2BuyIErJAnjlMUU7ziwjcfHCkXHokdAVF72G2ZeQ1jwpxyjLu14AHUiz UkAjVhBdqkHMLmgEvz+TUNLggu1XtkGiDFbfHbIx8YJkzzZnidwgUubTnCqKH0mYCQdiiiDdgun +IPtujBKmIZYAI6vChmFMQt36MJpdV46tcAf0CaqI2PEbVQr2B0n44nRIgHLyNECJF1ke8EcsXG YcG/493JtpHtgBsz4vyit+S5t6JOEUCaP42W+NN2pBsUdr8OLTk43Uxn/pKwFTjAI0pQYzYEO1C dFESKBln9tGkUCYRWBhzX3+U1LtD9OjcDtTsSBfBSfjvXrnTCty0oEm5Q8QTlcPgL9v3kLPss2r n9ty+EhZj1SaOvPaJjMl9bT3aqYmetgmBHu7iCSDl+tteB2WMSAy6XhVeNlDf1g9EU1filr+j6H tgc68U9EA+1HwvjHOQR5/eS/54smnbgtJXZgzHM673iWMG X-Received: by 2002:a17:902:f70c:b0:295:62d:5004 with SMTP id d9443c01a7336-2986a6f0a62mr127784315ad.26.1763355102135; Sun, 16 Nov 2025 20:51:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqr4NCffHT67TNw0ZnuOKYyRPUhFfKBTye6e2kIWZgOyInYwiJH+0M1oZPOZ5QI9V4axpFSQ== X-Received: by 2002:a17:902:f70c:b0:295:62d:5004 with SMTP id d9443c01a7336-2986a6f0a62mr127784165ad.26.1763355101697; Sun, 16 Nov 2025 20:51:41 -0800 (PST) Received: from hu-kathirav-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c2346dasm124187105ad.7.2025.11.16.20.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 20:51:41 -0800 (PST) From: Kathiravan Thirumoorthy Date: Mon, 17 Nov 2025 10:21:27 +0530 Subject: [PATCH 08/10] soc: qcom: smsm: Use __cleanup() for device_node pointers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251117-cleanup_node_put-v1-8-5f107071d171@oss.qualcomm.com> References: <20251117-cleanup_node_put-v1-0-5f107071d171@oss.qualcomm.com> In-Reply-To: <20251117-cleanup_node_put-v1-0-5f107071d171@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Kathiravan Thirumoorthy X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1763355082; l=2159; i=kathiravan.thirumoorthy@oss.qualcomm.com; s=20230906; h=from:subject:message-id; bh=knnJGoJD2i+Kk5EF5Jxn55PSS4tA+N31y52aSSy4OPo=; b=vouki9aUfASvCriSxosjgdft8yEH0fGKVKLuJNg0xBwLl3I/hL9HM1jyzfPQNpyYysmIi3qjB Q07t7Su3SHlAaguPM9CZD59b8tpFB4mo2tND1R+rl10Po64eV+MDAXd X-Developer-Key: i=kathiravan.thirumoorthy@oss.qualcomm.com; a=ed25519; pk=xWsR7pL6ch+vdZ9MoFGEaP61JUaRf0XaZYWztbQsIiM= X-Proofpoint-ORIG-GUID: WO111Jc7fMGUw5k6PzucOx9Mtvl064kA X-Proofpoint-GUID: WO111Jc7fMGUw5k6PzucOx9Mtvl064kA X-Authority-Analysis: v=2.4 cv=PJECOPqC c=1 sm=1 tr=0 ts=691aa9de cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=3qeLEZgXne52oc-3IkMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE3MDAzOCBTYWx0ZWRfX32ecB7FUGYYw GaP0B+AYuJ2rekRcjB5KHFUjFXzojKKqotRklWUpx8saMXhwQ4itg12jy0TFItm4Jdb7T15vaBS shItwamv2GUNd8lG4oXTc+lY8LjryXVlZKQS7qK3SkiD2wFJvJvEAP7KckwG82OMxiK2Mg/nrPF xSgu2WaHA4zDEiCIJhXfmx5EL/YXoQjrxum9hmJrsFPsHPYVz0ofK0FbU5cmiyNG5OkrTawKGAu 8nWar8v0YCgwsUzMTjBQapOqK82udrJ8zXeBTLCmeC7FD9ZIGXBExwT2Mhr5jpo7vosiP1tJQ0q WpAjudkRxVnKR5h3anYgGRI6lwAdBBQzIK3paG80yqtqh0BmzQiiqTgi+vR1Xd8Spo8SVv3yVpc +AGYEs9JYSV2WKuAWy3w5irfg+yVPA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_02,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 impostorscore=0 suspectscore=0 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511170038 Apply the __cleanup() attribute to device_node pointers to simplify resource management and remove explicit of_node_put() calls. Signed-off-by: Kathiravan Thirumoorthy Reviewed-by: Konrad Dybcio --- drivers/soc/qcom/smsm.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/soc/qcom/smsm.c b/drivers/soc/qcom/smsm.c index 021e9d1f61dc5200514c5a239d52be97f7e82825..5600712f9185bba8c82da431cfb= 9f21f1bc44761 100644 --- a/drivers/soc/qcom/smsm.c +++ b/drivers/soc/qcom/smsm.c @@ -397,7 +397,7 @@ static int smsm_parse_mbox(struct qcom_smsm *smsm, unsi= gned int host_id) */ static int smsm_parse_ipc(struct qcom_smsm *smsm, unsigned host_id) { - struct device_node *syscon; + struct device_node *syscon __free(device_node) =3D NULL; struct device_node *node =3D smsm->dev->of_node; struct smsm_host *host =3D &smsm->hosts[host_id]; char key[16]; @@ -409,7 +409,6 @@ static int smsm_parse_ipc(struct qcom_smsm *smsm, unsig= ned host_id) return 0; =20 host->ipc_regmap =3D syscon_node_to_regmap(syscon); - of_node_put(syscon); if (IS_ERR(host->ipc_regmap)) return PTR_ERR(host->ipc_regmap); =20 @@ -509,8 +508,8 @@ static int smsm_get_size_info(struct qcom_smsm *smsm) =20 static int qcom_smsm_probe(struct platform_device *pdev) { - struct device_node *local_node; - struct device_node *node; + struct device_node *local_node __free(device_node) =3D NULL; + struct device_node *node __free(device_node) =3D NULL; struct smsm_entry *entry; struct qcom_smsm *smsm; u32 *intr_mask; @@ -640,12 +639,10 @@ static int qcom_smsm_probe(struct platform_device *pd= ev) } =20 platform_set_drvdata(pdev, smsm); - of_node_put(local_node); =20 return 0; =20 unwind_interfaces: - of_node_put(node); for (id =3D 0; id < smsm->num_entries; id++) if (smsm->entries[id].domain) irq_domain_remove(smsm->entries[id].domain); @@ -655,7 +652,6 @@ static int qcom_smsm_probe(struct platform_device *pdev) for (id =3D 0; id < smsm->num_hosts; id++) mbox_free_channel(smsm->hosts[id].mbox_chan); =20 - of_node_put(local_node); return ret; } =20 --=20 2.34.1