From nobody Sun Feb 8 07:14:42 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BCB73BB40 for ; Sun, 16 Nov 2025 02:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763260051; cv=none; b=iOp4VlbWWG/10X399wKbkgpU+MgZeAIflTkPC8vmspWLcEhNiExXhrzSglPuGEkWLs/eg3foJWfOIXvZf/mBCjrTzvVnUmZe/1fY5DPnXPhJhXWjotRVQ3oD7CC892BtPgmDg6u1p/6OhF6UTF2YoakZt0O6xDJYzNYTv7mMU4g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763260051; c=relaxed/simple; bh=HeUkJojjgy8x+9+W2n//VkrvHV0zGjUVIl4jJ5gb4Kk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MHJ8m+PEmvbqDlhfes9+vzkYnW/INEroA81+GYk3wrJpzmz8heRncipYwaTde5nnyKr3TEb6gsW/g9s7wDrGntDF3wtWc1pbxVIgYfn5uVCaONVAWxIZx/aPsqXImNd0myKylsk9wIoOFAiumiMRzva4Irp2OkOLd2yxMKJ2ckI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dzX/BknE; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dzX/BknE" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-42b3c5defb2so2166186f8f.2 for ; Sat, 15 Nov 2025 18:27:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763260048; x=1763864848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kQHTaaCZSuYsO96UdJunWUIQb8utCVV4zfJ0o3NYY/0=; b=dzX/BknELDlXypOkf/NVT265QBtQ0vFYhxRsmMom/s1NQ5ECJehnQ2jwxQ44Y/l2Lu u2S+w1aoSaz7f0/I2sAaQ+LyVKOXoSNVyTtlW0esXbJK4M1s/WeSk4DIdLlkKrwPeEeZ lsLhI+/qqMo3udc+6z++LoATkM/hANiaRQIGuealP9IaEf0X89+5uA590AoWpq1J9kn9 kVv/MP7vEiZhl1MlW47R0znWg2RsTxWccpk0yi18xnYIfmLC1KxMMKK4I5Djx30t5HO/ LO123FuvwCyJTUGzWFC8EIpjRprwTedY4v8yYj4/XW4xMoNpsY4ucCT+vurkiHgHNOt0 OOgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763260048; x=1763864848; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kQHTaaCZSuYsO96UdJunWUIQb8utCVV4zfJ0o3NYY/0=; b=TEEkC9hIQ21zu5tP5shAtz2WFQZ/nkobW5+zvFpJ5lEBmrFDIvhnrA+9xG821/LcP1 VrSXOSHnq3W+jAGTFhsbOqvJGrzysxRkiMXEA81XKQEJ4SdNMvb+PedjT4wetV1EQNVq xudIQAWOMz+fxzPTGJV+coNVaHBDvfHYIfUTaQM03i2tjARG8kQEK3fcKWQvSFAmQtFI LkXK5EDpxcIlZZkw285n07JwJdvQloqDYTGIIRvqnLrYEWxV4AILrF1Vy6e8nOekJKgC Pfo0Wj9B5DWdMuHq5ybOFwH2xRQr+c7Nb+8wNI6HuyXiCsQq/BN6fNtxsWGQzQq4RCpV H/7Q== X-Forwarded-Encrypted: i=1; AJvYcCUoOiHCo8t1PulOBqp6F1Uc0W+Di5mxyE7c1uywL+aGhgVT2QANCadc578q/L76Aron1pBC7H75yxXmP/E=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr2SuoBSU31sxLH5ggwBtbkA/9fas1L4S/A1A7qyLOVDS0soDO sUUElCF8pOrCshDh9RX2ppQI1HkTZuwIdP+IWVEtHrIaPFFU7htOh3uC X-Gm-Gg: ASbGncuoYGWZJ1OHYZSf9AllECxhQQu5qVFyjk//4xhnu/LNWufj0iymNWmUJfypO5k 8gLFR3mk9Vkdb1lFdqEoyUqFMjLsBbC6ntmtBMOBZQARvkHgLoEgfTt7HirgD0Pggikl6OlR4Zg MlysicHicpWyoj6PEHFTIuSXlvTVk8Pt+QYmBqH/Wo22WmaNy0NiNo9lF5QMMJKMB+m3oNBL5Et Awb/MuHO+5MQq7sXiFCa7qT+9ZDwB/dwZXkF/nGkpgye2hHTA6XO1TrriRIqiqkL55UsQ4lAm6I R+HCd0QBnQI8MF7E9s0TqzKhFULDFRDFBvhDcyGXoUwUIkPI/v+1CN7feYKce0vnmWMYfSmQYvo 43vNHNXT4Ti7TFkKChhRfiATv4EMLBGiFEQAXJ6DPGDq7rKlL36fNd4qeR2b1ii59Fo29cV/yWj ofTzRsJaKafNAWBmDGuw== X-Google-Smtp-Source: AGHT+IHnVi5ps4m0awDqDegGNwiLqoqub0TaFKEwUQHgJbapVBZLNKrRY2nowbQjtaJ2Z1Ma1OCukw== X-Received: by 2002:a5d:5f47:0:b0:42b:3825:2ac8 with SMTP id ffacd0b85a97d-42b5939ce2emr6911403f8f.59.1763260047788; Sat, 15 Nov 2025 18:27:27 -0800 (PST) Received: from ekhafagy-ROG-Strix.. ([197.46.78.60]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e7ae47sm18198368f8f.4.2025.11.15.18.27.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 18:27:27 -0800 (PST) From: Eslam Khafagy To: roderick.colenbrander@sony.com, jikos@kernel.org, bentiss@kernel.org, max@enpas.org Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, eslam.medhat1993@gmail.com, syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com Subject: [PATCH v2] HID: memory leak in dualshock4_get_calibration_data Date: Sun, 16 Nov 2025 04:27:23 +0200 Message-ID: <20251116022723.29857-1-eslam.medhat1993@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" function dualshock4_get_calibration_data allocates memory to pointer buf. however the function may exit prematurely due to transfer_failure in this case it does not handle freeing memory. this patch handles memory deallocation at exit. Reported-by: syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com Tested-by: syzbot+4f5f81e1456a1f645bf8@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/691560c4.a70a0220.3124cb.0019.GAE@googl= e.com/T/ Fixes: 947992c7fa9e0 ("HID: playstation: DS4: Fix calibration workaround fo= r clone devices") Cc: stable@vger.kernel.org Signed-off-by: Eslam Khafagy Reviewed-by: Max Staudt --- v2: * Adding tag "Cc: stable@vger.kernel.org" v1: https://lore.kernel.org/all/20251115022323.1395726-1-eslam.medhat1993@g= mail.com/ --- drivers/hid/hid-playstation.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index 63f6eb9030d1..fef81b7e27c1 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -1992,9 +1992,6 @@ static int dualshock4_get_calibration_data(struct dua= lshock4 *ds4) acc_z_plus =3D get_unaligned_le16(&buf[31]); acc_z_minus =3D get_unaligned_le16(&buf[33]); =20 - /* Done parsing the buffer, so let's free it. */ - kfree(buf); - /* * Set gyroscope calibration and normalization parameters. * Data values will be normalized to 1/DS4_GYRO_RES_PER_DEG_S degree/s. @@ -2041,6 +2038,10 @@ static int dualshock4_get_calibration_data(struct du= alshock4 *ds4) ds4->accel_calib_data[2].sens_denom =3D range_2g; =20 transfer_failed: + /* First free buf if still allocated */ + if(buf) + kfree(buf); + /* * Sanity check gyro calibration data. This is needed to prevent crashes * during report handling of virtual, clone or broken devices not impleme= nting --=20 2.43.0