From nobody Mon Feb 9 05:14:24 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB68F4FA for ; Sun, 16 Nov 2025 14:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763303154; cv=none; b=MvB5G9xulQqlM6jMbJIyolyxW3uVGMi+XNKbw+/xMAU/dZi0NLIykChlamEwMlqj++hIiiEs55lmfTSch7QHMUzSXSSdBALC5+/1zxxUGBMXqLzQafqj/jRLldYY8hdj1r1noJ7P0TntkQOqPoO3kCvVUXX1tinzEzH2mQsttYc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763303154; c=relaxed/simple; bh=svasl/wUQN/RjV7OV9NFW7xHupHnh3s+RY74FYkdgjQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qDDOrtThYW/aMRz84Jo8lo40/MZ51lCXgUwvKThCxnlaFqsrx4jWWldg3zLBM/rY4byY7nqqZHcgFIcZmYdXKJkWG9eJueCQoAhM3MovKIXOciZxu8EjLf4UPBdncP6o9MeWtRsTSNb31OXF7fFkq+Ky7QRQJR32mwc7BZrkIJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gsXDSDWh; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gsXDSDWh" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7bf0ad0cb87so327478b3a.2 for ; Sun, 16 Nov 2025 06:25:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763303152; x=1763907952; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=tUgNXd3WaS1ZX53qlrUJ1wb/vOmJJkr1sOtoI8YSqyA=; b=gsXDSDWh7adetDlXAitm2T4aJ29fdxYNOhABCd8/MLWTBD6TQ7z3uGR1EFJ8fxCimH HAEj3zxyWJ7/wT0KtJqWLEe6c3fcSvUcZauCD9OTUdTIMNmmegwrrabdS7ywIe1ZKzZw 5H3E7Eei2iR26FdWPLYv00zPwk4ZmVd9BMUCw8PYxrDp6gojCmzj+p6fuEYMV8CLnnmz lCpP/qz4fZ2lUXYAPhYCk2Tqvl259DmnyaKWQQb1ABWALUBspqx9SvhX2pxu9fqbhFUv 7ZTJoP3oGxQRVReL3aROh/ykbs8MCVqP9uczLHTeb3cqXmc1cvgeGeXcgQ7XGGJt63E3 qPrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763303152; x=1763907952; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tUgNXd3WaS1ZX53qlrUJ1wb/vOmJJkr1sOtoI8YSqyA=; b=s5ZOB7AuoHmoZI1HvLzx/C/xse79QC9GhLj3ci3kW9unyoAaTR1eeYoNyCJzNo2znc ShWzlCak2SEea7P1bccLgiL0vbfZrq1BVPfhPz92UDDIXRLkB2o5CkykU8PXlVLYqPOd 3ljzCO6p1v53b8weSQI3wBiO7+F1Xs9s8zsWaqzCndZ2oyQ3VLZqDfe9mOmXK6Ds5+tj QOUmSVhz2jfruOVA2Fj26vRf8vPXlt684uyLo6gRwv89YnbB6DMlKtrPnegPw9Tl/GjN K+tnC3XO909EFELxPab8ZedtfnNPH5JygtkEX+ScUNMyzbQakpDk4u19/lkjSaMKQ9dM 1DfQ== X-Forwarded-Encrypted: i=1; AJvYcCWL+sQ4AtVAAlER+9vtcv9cdaIurqCj0MFTuKigL8ZZBqgCIWG+3pnyWDjwJoxZE+3/iAlcL2rJLp8/5pA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfk3mpDBgeWagmVmSK7AaGkYkqwREjxOja6lcR0VTSi8TpzNK/ oYBRAQB5v5fOI7PDJ691KA3p41BQuUveEU8vqIOvKed5iNCz3fzTLfSZ X-Gm-Gg: ASbGncsiNItE3zq6sRu47u7jZ+HcxDJHsbnv8CIvMuqa83lgraLt3KyNzQOEI5QrUxS seh6K/qdam48X3W3DIA0GSjvoZOtLC2xzVk4ezq1sr6Uk+Gqg8ZyPkwE33Cvef5LSbeFqeNpJqs vKgNm0Dn72bKuuSMtv0A2Lhl/T4d6zTdxX1G49vrSOgA7ekYuAgO9INaeZHN7gYAwk0JjMe+/52 BbZN6Sw9kRLX+OavUOSfMkJwnTDtKAfAHocvzoiUXb9F5qmxcinAC/gt0S1iW+X0+Ahlqv9P4jM I213iZZdafuTbXJ8U5S9gnZfy9lgbyGDonQvKKw+UY7T4marCduWKWgvtELbDLdSJjK3BiGj4uh iqWr3P++9mYvkX6nqWWQzXSQWF4htpKtak3asfDsjHJjojMl1dqIxZGJDep3Zxuv7+sQp/H1/fN Y7whkIb4+V/N+MWhvN4Rk= X-Google-Smtp-Source: AGHT+IGY5ayl7KbSv9wQLmeiIVuYvNbLWrQzA1wPRGTb9zHhR5PNgGo6VMzNJZgxWiIx01WZ6pvuig== X-Received: by 2002:a05:6a20:4327:b0:35d:5d40:6d84 with SMTP id adf61e73a8af0-35d5d40748fmr6518187637.5.1763303151880; Sun, 16 Nov 2025 06:25:51 -0800 (PST) Received: from aheev.home ([106.215.173.137]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc365da0191sm9689168a12.0.2025.11.16.06.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 16 Nov 2025 06:25:51 -0800 (PST) From: Ally Heev Date: Sun, 16 Nov 2025 19:55:44 +0530 Subject: [PATCH v2] powerpc: 82xx: fix uninitialized pointers with free attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251116-aheev-uninitialized-free-attr-km82xx-v2-1-4307e2b5300d@gmail.com> X-B4-Tracking: v=1; b=H4sIAOfeGWkC/5XNQQ6CMBCF4auQrh3TFkRx5T0Mi9IOMBFa09YGJ dzdyg1c/m/xvpUF9ISBXYuVeUwUyNkc8lAwPSo7IJDJzSSXJyF4BWpETPCyZCmSmuiDBnqPCCp GD4/5IpcFONeV7s66NHXD8tXTY0/Lztzb3COF6Px7V5P4rX8CSYCAhpcd1k0vtaluw6xoOmo3s 3bbti+6rZLy2AAAAA== X-Change-ID: 20251104-aheev-uninitialized-free-attr-km82xx-00c4cb7c3d69 To: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Krzysztof Kozlowski Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Dan Carpenter , Ally Heev X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1635; i=allyheev@gmail.com; h=from:subject:message-id; bh=svasl/wUQN/RjV7OV9NFW7xHupHnh3s+RY74FYkdgjQ=; b=owGbwMvMwCU2zXbRFfvr1TKMp9WSGDIl773+JeK3k5VdYdfi38k/sh19Xb78y27LffNotar45 /0eQScyO0pZGMS4GGTFFFkYRaX89DZJTYg7nPQNZg4rE8gQBi5OAZjI6pMM/1Nm8TwzevK9m+PZ LW3fx5++7nuarHl0xvmtz6c7hS7IZTdiZFhSseQQc7rYkj21tY/ebnr9eJ083wKH+I32kbpeAZH 1b3gA X-Developer-Key: i=allyheev@gmail.com; a=openpgp; fpr=01151A4E2EB21A905EC362F6963DA2D43FD77B1C Uninitialized pointers with `__free` attribute can cause undefined behavior as the memory allocated to the pointer is freed automatically when the pointer goes out of scope. powerpc/km82xx doesn't have any bugs related to this as of now, but, it is better to initialize and assign pointers with `__free` attribute in one statement to ensure proper scope-based cleanup Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aPiG_F5EBQUjZqsl@stanley.mountain/ Signed-off-by: Ally Heev Reviewed-by: Christophe Leroy (CS GROUP) Reviewed-by: Krzysztof Kozlowski --- Changes in v2: - updated commit description - Link to v1: https://lore.kernel.org/r/20251104-aheev-uninitialized-free-a= ttr-km82xx-v1-1-903be69f2cd4@gmail.com --- arch/powerpc/platforms/82xx/km82xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/82xx/km82xx.c b/arch/powerpc/platforms/= 82xx/km82xx.c index 99f0f0f4187672614f4f8ad46ab7906f7ad8078b..4ad223525e893c0de15540db2b2= c4d239d6d841e 100644 --- a/arch/powerpc/platforms/82xx/km82xx.c +++ b/arch/powerpc/platforms/82xx/km82xx.c @@ -27,8 +27,8 @@ =20 static void __init km82xx_pic_init(void) { - struct device_node *np __free(device_node); - np =3D of_find_compatible_node(NULL, NULL, "fsl,pq2-pic"); + struct device_node *np __free(device_node) =3D of_find_compatible_node(NU= LL, + NULL, "fsl,pq2-pic"); =20 if (!np) { pr_err("PIC init: can not find cpm-pic node\n"); --- base-commit: c9cfc122f03711a5124b4aafab3211cf4d35a2ac change-id: 20251104-aheev-uninitialized-free-attr-km82xx-00c4cb7c3d69 Best regards, --=20 Ally Heev