From nobody Sun Feb 8 01:38:24 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8736F14A60C for ; Sat, 15 Nov 2025 14:48:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763218131; cv=none; b=TYcGeHHQBGZjxq2nPtGbfD6xJSHDQlbmyMoUgZ5Q3aY3umSFbWx1zcoDkwnqFytvJ2OSTyNNAnDj9nJfkRk/scV8FFDndRAQeQHoyCePiaK2+g0zdDj9qDfCFtA1ziUm65dhuqrV4zof2V5mxrsKNE29vBMQuphpdH/CoKHb4F0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763218131; c=relaxed/simple; bh=NZH79oJQrUr0+yLUGXyMSbz2UGtduLS0AKXdFUHNmfs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hqTUX6oHBdsxFlvRZjwWqUAAhYtgEOn+X/WYcsdIJdb2iNrgaDo5KlfuzNrvVLzaHAlE1utBqYpiaO+ox6V/W6yWe8IBe0yTD87IQEDFSav5MgQGNN6ACOCXFAvRl37N+A4LDPKCPnnl98Gl99MMi5PB5XCRWbIVHSOfNc4JSvQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BcTQ6xjT; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BcTQ6xjT" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7bac5b906bcso180867b3a.3 for ; Sat, 15 Nov 2025 06:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763218129; x=1763822929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Eblm4oH8WMKHd2tfTsYGfp0Iegef7142gb8GNo8dgAM=; b=BcTQ6xjTMx83ipuCQjbXHesHqtNHc2mzHQcCsbJdroB3ZUkrHKKPnWumQk+TA/LnFe lQM/cW7NOCutIm7bGSk/yUigzvA22swD+MqHRtwaAPJfYZRrSUwam5Ta1omFpx59BXsW IdvEQHh5wZ4ULKMhFQEnFsMGnM4QoZvs9clcH8bR5UXlJ23Bvv94fXkG+1JwKoMaJIAz sZBUdbnanDHXn6L8N2459cLxJUSmLrW/WSEkP05bNZSM+xzz+IC4anFvC59XeksFOgDH ePuL2kHVr/vD9NPkY5cem4jHTlRfFBVNDhbZ89KFwhuZtYUopRghK8uGA7FYjkN+Qbj0 Nmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763218129; x=1763822929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Eblm4oH8WMKHd2tfTsYGfp0Iegef7142gb8GNo8dgAM=; b=Pbz7aD3cAnWIQ2HjixJpuwhRjGXzAhjcuADavThDx6i1fV6bJQhy7TeLmChT/tGwAd WW27YqBqXZJLMHwslu+uVTACw1wTDwyYOOTO+EguzISLiwmNHrj7m0Vt4tiB0uqGZpKD PcM5b+gaA0wF+BDpOsIjbAvGkB2MkgYIeGHY8Ch8tc3crEaaEeond8X4E0JUijxLbByE 8a6acvBVI2jms4kyWHflm3SmE3lLZ28GwtQrLQW3rxU26ju+GQF9Kn709B2xtaWQDaGL TAcbvLkotB/xwlpP248I7xX7PzqQ95fvyPeFxZIubK8cHjjv22lMqQtIgEQc0MRNRMsP sKeg== X-Forwarded-Encrypted: i=1; AJvYcCWRpRGp7UxrZFqLm7EUQZ6GmeIDR8+ul6fYUv+B2KoTDSDpZKPqz1rCZ0efrXGDIRflrZABK2Ts1JojtIA=@vger.kernel.org X-Gm-Message-State: AOJu0Yyryhwan8ovrIy0vHBDZZPvUpeAQj4h8My5yQPm/X0BZAWez2y0 a1LqMfNJudF6/QSLc3LUzd1mDtyg/sFsx5pTV4vtu8+ilu0ky3Pp0qRs X-Gm-Gg: ASbGncvOAeHm8mU4pu//yWxtlddmoKJ23oL5jTbSGAc4RNjSvclzq/j0Vf/jUsJvwqP OSEKnzI7sIrU3Fcua7DzO9fT2MjeD+X8Lou65kOMhLTC1BRk+K5NNuP/zspzzqZl2yYvstcTP89 g3p5K6ytUBbYwHkbPwwToJ5xZtgBnyfg/3uenhJ3KuklsD61vJL4CRC/Gg90h7rLgy7MEjKcJ2S NW6ok4UAYz977ERz78YYM/bw6S7BlK+vGK1r7DUgtTFsjqhTewtwPBuWlLbDuhKgqxy5/M04zwO Oamtn+2ogz5xR55Q6bOO8on0Q9epzmHQIGv3RGGYz7861yy+XtUJ22Cqi+zbzcQ5oDOhm0g3Zj1 KPedJZzFq1KW9sbFxczNDwaBhjSV+VRkhrUtbuCfajD0ozUvuEcpuXOrBs3h1aNkJu/piMfspcX yAN3nc1Eg2MmCuxtv2SVpqqgRblm5/eZfiGDd+SfS4aN8g7J/kF/iP+K/pgQIPZGM5RdnfSDGIb kUBwWXIWr4= X-Google-Smtp-Source: AGHT+IEFPRicWDHAlwZaQ/FpL1TsXLtWQwGVzqmxdM7jo4UhyoPLcjUWPuif+VXkEX1VRD7+udJK9Q== X-Received: by 2002:a17:902:d483:b0:295:54cd:d2e2 with SMTP id d9443c01a7336-2986a5edceemr42293645ad.0.1763218128806; Sat, 15 Nov 2025 06:48:48 -0800 (PST) Received: from poi.localdomain (KD118158218050.ppp-bb.dion.ne.jp. [118.158.218.50]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c25a688sm88392485ad.49.2025.11.15.06.48.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 06:48:48 -0800 (PST) From: Qianchang Zhao To: Namjae Jeon , Steve French Cc: gregkh@linuxfoundation.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Zhitong Liu , Qianchang Zhao , stable@vger.kernel.org Subject: [PATCH v2] ksmbd: vfs_cache: avoid integer overflow in inode_hash() Date: Sat, 15 Nov 2025 23:48:36 +0900 Message-Id: <20251115144836.555128-1-pioooooooooip@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" inode_hash() currently mixes a hash value with the super_block pointer using an unbounded multiplication: tmp =3D (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) / L1_CACHE_BYTES; On 64-bit kernels this multiplication can overflow and wrap in unsigned long arithmetic. While this is not a memory-safety issue, it is an unbounded integer operation and weakens the mixing properties of the hash. Replace the pointer*hash multiply with hash_long() over a mixed value (hashval ^ (unsigned long)sb) and keep the existing shift/mask. This removes the overflow source and reuses the standard hash helper already used in other kernel code. This is an integer wraparound / robustness issue (CWE-190/CWE-407), not a memory-safety bug. Reported-by: Qianchang Zhao Reported-by: Zhitong Liu Cc: stable@vger.kernel.org Signed-off-by: Qianchang Zhao --- fs/smb/server/vfs_cache.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c index dfed6fce8..a62ea5aae 100644 --- a/fs/smb/server/vfs_cache.c +++ b/fs/smb/server/vfs_cache.c @@ -10,6 +10,7 @@ #include #include #include +#include =20 #include "glob.h" #include "vfs_cache.h" @@ -65,12 +66,8 @@ static void fd_limit_close(void) =20 static unsigned long inode_hash(struct super_block *sb, unsigned long hash= val) { - unsigned long tmp; - - tmp =3D (hashval * (unsigned long)sb) ^ (GOLDEN_RATIO_PRIME + hashval) / - L1_CACHE_BYTES; - tmp =3D tmp ^ ((tmp ^ GOLDEN_RATIO_PRIME) >> inode_hash_shift); - return tmp & inode_hash_mask; + unsigned long mixed =3D hashval ^ (unsigned long)sb; + return hash_long(mixed, inode_hash_shift) & inode_hash_mask; } =20 static struct ksmbd_inode *__ksmbd_inode_lookup(struct dentry *de) --=20 2.34.1