From nobody Mon Feb 9 02:13:19 2026 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D055E2FBE12 for ; Sat, 15 Nov 2025 14:14:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763216064; cv=none; b=PiJCjKQKtWV+YjAsWXv3rz0rYj38motbkh5V6rdLC0ZCv5PKtMpahu4pxXUV0JJ37OEi9A8jf4RfYqb96spzKUVpkqq0BJOSUyOtnLwSPu2HujbqmkIBERweyFgdAhjpjxjzaNsHOIFErGYpHojg1hK6QXzGasjTE+frhulJdE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763216064; c=relaxed/simple; bh=JeJ/r3r6p1NeXChaBCcLY3ZUFPlKr1ccZPRTLmbzSzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zlu0lnvzOlzYYsEt8CIFFCSdHTACHSt49RjsZL+RsCttWkzlnElLjMpEScquAFaoSRPobZdTyl2/tOIiEfg2mcdMNfWKlrn+LpozeWlQIjm8GnVdD53tR5bSIWZPOUrZXkdhAJoCnaIKecEQ6TJYStzpIVxPazyD695Pyly3V3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m0MSamV7; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m0MSamV7" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-b736cd741c1so254703466b.0 for ; Sat, 15 Nov 2025 06:14:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763216060; x=1763820860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pVbw8sqfmsGsfsXTGzKu/do/A1FF7lGaLVG/hAhMlcM=; b=m0MSamV7drvxla8xUISyjT4ZkpIIu2IC1y9dUDnIOwk3Ub9L9Ivds7BzCdcszrhtfW QHjbLySE4uNHlCYKyDQzp6Otya9rb9aMewukEz06wcKJQ+Ck2I16uW2Mn9CUTZLhhDOy CK5UjjU1UAaeFVHCLjAruefEgEVxB507BqerQky6iSViGOAx/uv9XyLQCLr5IpzTWR7Q C2fRDGwbuPFH1rDkRIOPNnEIX0lhCaRtw0x/dxgTD1H/DORgzBfEMJ5QBNSCV3jiZ4ZY dH+nXtHHCrxIiCpTGiOMRqAyncN/w76n+Fqup/drm5W74pR7hha8dVEsI80pXxL6NCMu 5M7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763216060; x=1763820860; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pVbw8sqfmsGsfsXTGzKu/do/A1FF7lGaLVG/hAhMlcM=; b=VGlEsU67ATKLw50K1FEQ65eh9IPqEb4/eSr47ysF6Sd9pxvKFcxkB4LejQwXP1tVyg PhERXS9IVgnuhiX8ee5tjC2t3nOiAYrv3Aawlveul5eEEyns3SBY2RSv/y8ENVKFc13U prcbbdMN3NOpVvSOztRcwraUimDFUptiXBU4+xnrC1c0ctyxqnXq4BAiGv7j5WtnQGI9 MLi5+IAznb+Zz7kKwPmvRgM+koV8U4b0HKCji85tiMLWoPvegnSVg/qGtSUp8nBL8GWv RETU2Cor4r++uNoi4CwrT69RIwUQygeI+3WPZ+hI796Y9w5FhVw58JZeVlOSH6fOdeu7 oa6A== X-Forwarded-Encrypted: i=1; AJvYcCXMBqBONFed4FYNrN81AWtSXtxxD+EtbFPulVNCm4iPzUtLeaPKHnz/60DW0oB9ZWc/VtWmbgHHDug/EsE=@vger.kernel.org X-Gm-Message-State: AOJu0YzcU1x0rIHayoYys48oKr0w8ZN+yMIR4u0w1Jklg/jlcS5GOD9W rYO2f9I0gYCI/zLrO4MCMkzy/mGtIz50fjTdBEFqGLLeSOceaiPyqMXJ X-Gm-Gg: ASbGnctq2moPze4D/fssoq0UUe0QYyrie+hLYPAnaiJ3U/nyy/dewgwsjuew4sWYDz3 SpjgDqV+M7YuPSvOzfWgg7AWKyl9RHeI0JGnVOP4Dt3cQSLQj0xaH/++kgiMX9QMHV4txjIpCDk dueMi1JSXBIwgMyDL/E6TXpBtapDqj5759zXz0HFMSjFXaPZKS5CfAFxFw8S4pySkdYMaDo34mN ON79aQOABZ4EHDnHrZMa+YbrENqyhJ13E4MFMBI/+WLwooW3LM0oJEcoWAOqK8of3heL3qhoZp5 fNsM078SKVqlN57N4QIbkF1EObLOZ1dvvUPRlR29cHx6AtJZp+B3fB1v54mLBiJ7QNFSJ+Dx02J D2vC8QFfrKstv2MVe5orjJPlRAEx2JSEsJZdaHQ05kAUcmxFLloks/cwiaYt8oznItSQrpRGsY+ ZmxeC9OFAqd13t+J9PF2hBw+p1ep8bkqen+wwspZmQpInUPQ== X-Google-Smtp-Source: AGHT+IGbU8DEm/CCSleW/Yu4/6wA0uutVsxsCUAngp8FeQ9xWSzPAIlK7ahdDPBbaS4CEF2iCochtA== X-Received: by 2002:a17:906:d9b:b0:b73:68b3:bd2f with SMTP id a640c23a62f3a-b7368b3c0fdmr502509366b.40.1763216060152; Sat, 15 Nov 2025 06:14:20 -0800 (PST) Received: from jernej-laptop (178-79-73-218.dynamic.telemach.net. [178.79.73.218]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fda933fsm606189866b.56.2025.11.15.06.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Nov 2025 06:14:19 -0800 (PST) From: Jernej Skrabec To: wens@csie.org, samuel@sholland.org Cc: mripard@kernel.org, maarten.lankhorst@linux.intel.com, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Jernej Skrabec Subject: [PATCH 5/7] drm/sun4i: Add planes driver Date: Sat, 15 Nov 2025 15:13:45 +0100 Message-ID: <20251115141347.13087-6-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251115141347.13087-1-jernej.skrabec@gmail.com> References: <20251115141347.13087-1-jernej.skrabec@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This driver serves just as planes sharing manager, needed for Display Engine 3.3 and newer. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/Kconfig | 8 + drivers/gpu/drm/sun4i/Makefile | 1 + drivers/gpu/drm/sun4i/sun50i_planes.c | 205 ++++++++++++++++++++++++++ drivers/gpu/drm/sun4i/sun50i_planes.h | 43 ++++++ 4 files changed, 257 insertions(+) create mode 100644 drivers/gpu/drm/sun4i/sun50i_planes.c create mode 100644 drivers/gpu/drm/sun4i/sun50i_planes.h diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig index b56ba00aabca..946dd7606094 100644 --- a/drivers/gpu/drm/sun4i/Kconfig +++ b/drivers/gpu/drm/sun4i/Kconfig @@ -85,4 +85,12 @@ config DRM_SUN8I_TCON_TOP TCON TOP is responsible for configuring display pipeline for HDMI, TVE and LCD. =20 +config DRM_SUN50I_PLANES + tristate + default DRM_SUN4I if DRM_SUN8I_MIXER!=3Dn + help + Chose this option if you have an Allwinner Soc with the + Display Engine 3.3 or newer. Planes are shared resource + between multiple mixers. + endif diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makefile index bad7497a0d11..03f002abef15 100644 --- a/drivers/gpu/drm/sun4i/Makefile +++ b/drivers/gpu/drm/sun4i/Makefile @@ -38,3 +38,4 @@ obj-$(CONFIG_DRM_SUN6I_DSI) +=3D sun6i_mipi_dsi.o obj-$(CONFIG_DRM_SUN8I_DW_HDMI) +=3D sun8i-drm-hdmi.o obj-$(CONFIG_DRM_SUN8I_MIXER) +=3D sun8i-mixer.o obj-$(CONFIG_DRM_SUN8I_TCON_TOP) +=3D sun8i_tcon_top.o +obj-$(CONFIG_DRM_SUN50I_PLANES) +=3D sun50i_planes.o diff --git a/drivers/gpu/drm/sun4i/sun50i_planes.c b/drivers/gpu/drm/sun4i/= sun50i_planes.c new file mode 100644 index 000000000000..a99c01122990 --- /dev/null +++ b/drivers/gpu/drm/sun4i/sun50i_planes.c @@ -0,0 +1,205 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* Copyright (c) 2025 Jernej Skrabec */ + +#include +#include +#include +#include +#include +#include +#include + +#include "sun50i_planes.h" +#include "sun8i_ui_layer.h" +#include "sun8i_vi_layer.h" + +static bool sun50i_planes_node_is_planes(struct device_node *node) +{ + return !!of_match_node(sun50i_planes_of_table, node); +} + +struct drm_plane ** +sun50i_planes_setup(struct device *dev, struct drm_device *drm, + unsigned int mixer) +{ + struct sun50i_planes *planes =3D dev_get_drvdata(dev); + const struct sun50i_planes_quirks *quirks; + struct drm_plane **drm_planes; + const struct default_map *map; + unsigned int i; + + if (!sun50i_planes_node_is_planes(dev->of_node)) { + dev_err(dev, "Device is not planes driver!\n"); + return NULL; + } + + if (!planes) { + dev_err(dev, "Planes driver is not loaded yet!\n"); + return NULL; + } + + if (mixer > 1) { + dev_err(dev, "Mixer index is too high!\n"); + return NULL; + } + + quirks =3D planes->quirks; + map =3D &quirks->def_map[mixer]; + + drm_planes =3D devm_kcalloc(drm->dev, map->num_ch + 1, + sizeof(*drm_planes), GFP_KERNEL); + if (!drm_planes) + return ERR_PTR(-ENOMEM); + + for (i =3D 0; i < map->num_ch; i++) { + unsigned int phy_ch =3D map->map[i]; + struct sun8i_layer *layer; + enum drm_plane_type type; + + if ((i =3D=3D 0 && map->num_ch =3D=3D 1) || i =3D=3D 1) + type =3D DRM_PLANE_TYPE_PRIMARY; + else + type =3D DRM_PLANE_TYPE_OVERLAY; + + if (phy_ch < UI_PLANE_OFFSET) + layer =3D sun8i_vi_layer_init_one(drm, type, planes->regs, + i, phy_ch, map->num_ch, + &quirks->cfg); + else + layer =3D sun8i_ui_layer_init_one(drm, type, planes->regs, + i, phy_ch, map->num_ch, + &quirks->cfg); + + if (IS_ERR(layer)) { + dev_err(drm->dev, + "Couldn't initialize DRM plane\n"); + return ERR_CAST(layer); + } + + drm_planes[i] =3D &layer->plane; + } + + return drm_planes; +} +EXPORT_SYMBOL(sun50i_planes_setup); + +static void sun50i_planes_init_mapping(struct sun50i_planes *planes) +{ + const struct sun50i_planes_quirks *quirks =3D planes->quirks; + unsigned int i, j; + u32 mapping; + + mapping =3D 0; + for (j =3D 0; j < MAX_DISP; j++) + for (i =3D 0; i < quirks->def_map[j].num_ch; i++) { + unsigned int ch =3D quirks->def_map[j].map[i]; + + if (ch < UI_PLANE_OFFSET) + mapping |=3D j << (ch * 2); + else + mapping |=3D j << ((ch - UI_PLANE_OFFSET) * 2 + 16); + } + regmap_write(planes->mapping, SUNXI_DE33_DE_CHN2CORE_MUX_REG, mapping); + + for (j =3D 0; j < MAX_DISP; j++) { + mapping =3D 0; + for (i =3D 0; i < quirks->def_map[j].num_ch; i++) { + unsigned int ch =3D quirks->def_map[j].map[i]; + + if (ch >=3D UI_PLANE_OFFSET) + ch +=3D 2; + + mapping |=3D ch << (i * 4); + } + regmap_write(planes->mapping, SUNXI_DE33_DE_PORT02CHN_MUX_REG + j * 4, m= apping); + } +} + +static const struct regmap_config sun50i_planes_regmap_config =3D { + .name =3D "planes", + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + .max_register =3D 0x17fffc, +}; + +static int sun50i_planes_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct sun50i_planes *planes; + void __iomem *regs; + + planes =3D devm_kzalloc(dev, sizeof(*planes), GFP_KERNEL); + if (!planes) + return -ENOMEM; + + planes->quirks =3D of_device_get_match_data(&pdev->dev); + if (!planes->quirks) + return dev_err_probe(dev, -EINVAL, "Unable to get quirks\n"); + + planes->mapping =3D syscon_regmap_lookup_by_phandle(dev->of_node, + "allwinner,plane-mapping"); + if (IS_ERR(planes->mapping)) + return dev_err_probe(dev, PTR_ERR(planes->mapping), + "Unable to get mapping\n"); + + regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(regs)) + return PTR_ERR(regs); + + planes->regs =3D devm_regmap_init_mmio(dev, regs, &sun50i_planes_regmap_c= onfig); + if (IS_ERR(planes->regs)) + return PTR_ERR(planes->regs); + + dev_set_drvdata(dev, planes); + + sun50i_planes_init_mapping(planes); + + return 0; +} + +static const struct sun50i_planes_quirks sun50i_h616_planes_quirks =3D { + .def_map =3D { + { + .map =3D {0, 6, 7}, + .num_ch =3D 3, + }, + { + .map =3D {1, 2, 8}, + .num_ch =3D 3, + }, + }, + .cfg =3D { + .de_type =3D SUN8I_MIXER_DE33, + /* + * TODO: All planes support scaling, but driver needs + * improvements to properly support it. + */ + .scaler_mask =3D 0, + .scanline_yuv =3D 4096, + }, +}; + +/* sun4i_drv uses this list to check if a device node is a plane */ +const struct of_device_id sun50i_planes_of_table[] =3D { + { + .compatible =3D "allwinner,sun50i-h616-de33-planes", + .data =3D &sun50i_h616_planes_quirks + }, + { } +}; +MODULE_DEVICE_TABLE(of, sun50i_planes_of_table); +EXPORT_SYMBOL(sun50i_planes_of_table); + +static struct platform_driver sun50i_planes_platform_driver =3D { + .probe =3D sun50i_planes_probe, + .driver =3D { + .name =3D "sun50i-planes", + .of_match_table =3D sun50i_planes_of_table, + }, +}; +module_platform_driver(sun50i_planes_platform_driver); + +MODULE_AUTHOR("Jernej Skrabec "); +MODULE_DESCRIPTION("Allwinner DE33 planes driver"); +MODULE_LICENSE("GPL"); diff --git a/drivers/gpu/drm/sun4i/sun50i_planes.h b/drivers/gpu/drm/sun4i/= sun50i_planes.h new file mode 100644 index 000000000000..446feaeb03fc --- /dev/null +++ b/drivers/gpu/drm/sun4i/sun50i_planes.h @@ -0,0 +1,43 @@ +/* SPDX-License-Identifier: GPL-2.0+ */ +/* Copyright (c) 2025 Jernej Skrabec */ + +#ifndef _SUN50I_PLANES_H_ +#define _SUN50I_PLANES_H_ + +#include +#include + +#include "sun8i_mixer.h" + +/* mapping registers, located in clock register space */ +#define SUNXI_DE33_DE_CHN2CORE_MUX_REG 0x24 +#define SUNXI_DE33_DE_PORT02CHN_MUX_REG 0x28 +#define SUNXI_DE33_DE_PORT12CHN_MUX_REG 0x2c + +#define MAX_DISP 2 +#define MAX_CHANNELS 8 +#define UI_PLANE_OFFSET 6 + +struct default_map { + unsigned int map[MAX_CHANNELS]; + unsigned int num_ch; +}; + +struct sun50i_planes_quirks { + struct default_map def_map[MAX_DISP]; + struct sun8i_layer_cfg cfg; +}; + +struct sun50i_planes { + struct regmap *regs; + struct regmap *mapping; + const struct sun50i_planes_quirks *quirks; +}; + +extern const struct of_device_id sun50i_planes_of_table[]; + +struct drm_plane ** +sun50i_planes_setup(struct device *dev, struct drm_device *drm, + unsigned int mixer); + +#endif /* _SUN50I_PLANES_H_ */ --=20 2.51.2