From nobody Sun Feb 8 11:26:41 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A2BA2F530A for ; Sat, 15 Nov 2025 14:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763215757; cv=none; b=mw/IlVZsoh0WRwFuUmo4j4f7vLNcAU/A5cMBFTqQBDdzOMg0LJomh15dmra6jmxuQ+cf2tiW4VT6CIt2AZy5NxbPZwmOH5mJmLjc/CIG+CrANQbsbowu/Cmc5OByCgn8wtwZozwVyeMOYS2Qdw5AxG6vjxHNJ5PeaSHIykrEgKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763215757; c=relaxed/simple; bh=U1imZqAOzucoubOP8HAnl0jgyb0CJHci3SamgjNwAf4=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=HjBPJbIPPIAwpjuFpCpxNwamRLu5LRFQvYI+WSE/lzHrvU2JVMhFZzOxRvuGcKbUXNIjFXAyJQuFWe3gXkCGsyKHRQ2UjfpK5a1EXEooJKZeui3ZBEUvf9Gf3ERoD/VsIY3CJjtnYeNJRLLB6aRGTVpoGzwlIAjGACe6vunw2nI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S0qvR1uA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S0qvR1uA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D778AC19425; Sat, 15 Nov 2025 14:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763215756; bh=U1imZqAOzucoubOP8HAnl0jgyb0CJHci3SamgjNwAf4=; h=Date:From:To:Cc:Subject:References:From; b=S0qvR1uAecdWcopp6u4Qodo4uas3fHBejvbyRoMjsu1ZhZiM4r9Boct46oOZRZMT3 578jECwNfcJQe6hn3ClOJpTEQViI2NP2TS3yurjheywDQp9fDpM0pthImUR+JKcgTE cEyxRiWltADRJUxeb0qwM22KEqm/Jt46Wuh9P8B7X8C4R3XYN5vy5RqpdXYX0zhFpa PSpHO7oAMklRzjE2AICi7B5nVDXg3xs+r5N/jaku+wtjUpKDxPN24HAprN7tbdnbD0 7J9SW1FXerhUpbSKwXDRZ/ktSVSXW00hLi0dL26NC92hfLwl9W/XORgVrPUHh43qj9 qkgo7scbloqcg== Received: from rostedt by gandalf with local (Exim 4.98.2) (envelope-from ) id 1vKGy9-00000002Aum-1By0; Sat, 15 Nov 2025 09:09:37 -0500 Message-ID: <20251115140937.144515988@kernel.org> User-Agent: quilt/0.68 Date: Sat, 15 Nov 2025 09:09:15 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton Subject: [for-next][PATCH 5/5] tracing: Convert function graph set_flags() to use a switch() statement References: <20251115140910.386662473@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Steven Rostedt Currently the set_flags() of the function graph tracer has a bunch of: if (bit =3D=3D FLAG1) { [..] } if (bit =3D=3D FLAG2) { [..] } To clean it up a bit, convert it over to a switch statement. Cc: Masami Hiramatsu Cc: Mark Rutland Cc: Mathieu Desnoyers Cc: Andrew Morton Link: https://patch.msgid.link/20251114192319.117123664@kernel.org Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace_functions_graph.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_func= tions_graph.c index 12315eb65925..44d5dc5031e2 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -1664,7 +1664,8 @@ func_graph_set_flag(struct trace_array *tr, u32 old_f= lags, u32 bit, int set) if (!!set =3D=3D !!(tr->current_trace_flags->val & bit)) return 0; =20 - if (bit =3D=3D TRACE_GRAPH_SLEEP_TIME) { + switch (bit) { + case TRACE_GRAPH_SLEEP_TIME: if (set) { fgraph_no_sleep_time--; if (WARN_ON_ONCE(fgraph_no_sleep_time < 0)) @@ -1672,19 +1673,20 @@ func_graph_set_flag(struct trace_array *tr, u32 old= _flags, u32 bit, int set) } else { fgraph_no_sleep_time++; } - } + break; =20 - if (bit =3D=3D TRACE_GRAPH_PRINT_IRQS) { + case TRACE_GRAPH_PRINT_IRQS: if (set) ftrace_graph_skip_irqs--; else ftrace_graph_skip_irqs++; if (WARN_ON_ONCE(ftrace_graph_skip_irqs < 0)) ftrace_graph_skip_irqs =3D 0; - } + break; =20 - if (bit =3D=3D TRACE_GRAPH_ARGS) + case TRACE_GRAPH_ARGS: return ftrace_graph_trace_args(tr, set); + } =20 return 0; } --=20 2.51.0