From nobody Fri Dec 19 14:34:39 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010006.outbound.protection.outlook.com [40.93.198.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 806C31991B6; Sat, 15 Nov 2025 01:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168971; cv=fail; b=jbm2PtQAnAkPFgkbOdWsRQnW25KKqoK6qgQfJPUAXf2xJHGwJZVYuACyF6IH/ddFBN30tJoA8yrUHDjKqfdzwPPfiHiRmLX2XLX229/pdvudpNtqBqFeSo8XQWPazF7mE8Xi0+ct6cS8CTOootyPDiyL3jl1wARaNmsz2k2hJLw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168971; c=relaxed/simple; bh=fEFEeNz+lZT0ZOVxsVpDHsnmPNoTqpbpGT0PECVPG8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=sAg2zzV2MwdNNwR6bEPE8DRqgr5z3YAoE8HfpGfyYnAxLdG1paiegrlSRmP9YcVgJcXV54x+rmsbBn2mRtSk8r93RDp7qbUnO8aslkOug1rTczTB1t6ddG3CibZKXSmgp/Ayj/SenXkkdWfEZM0aUaqy/gPpvk0W8pbnVDWi9bE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=r4iH/lYM; arc=fail smtp.client-ip=40.93.198.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="r4iH/lYM" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tjIMMrCla3Td3Ngz0h/x1fWRoP2HyGIQtY+EYnD096BB18PZN6BBDqPTLMwfrIrrBfG624CdOmGppHNI7xgG4dXhkhibcr3R4EMm+LSFDuUAYVBnLyB3qLY3q8+Sr2TsQgLqsmZkA2rtDwglod7byjA9NKwcKvIG3UEERULsVOfsXXtLTCn5SXta++e6vkK0+CZTAUYea+BLCkWDCE63BjLcPBm5bc9lo5E52gKn9lCsm3za4mvBFnPoph2YFIA8brqSKNxEWvPI8n/8ROC2tTLPe1YxNqFcsk3Hma6phRKRsWFpNuv4C622dF+UN0jv/29NGjZal9u67y/SbgxbEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XaoTIO5B5/izh7QUqiKmRZYvzLCtnWTbvqhlVW3pW9U=; b=iwqIeu9QMDtC8KGPmPagAiEStHISVTJVmTJeU+5cdKYY80CBoBI6CEVYFM5xwcjWM1nl8MeBctb9V3ZKDjUuQ5ByfmhLvEyJFglI8ujWvu4W4xsEGI0dlYhBVbCnGENUAXMUYZ9X21hRblVO9pdVxXIBNPPVrmQgQ+PXaMPpG6vRYvBFXDltclYqzMvWFj+lHIn/Ih073qRqH2WpiBZmTQcotzYDOEjtdrPAj1k41+0fpIyBToyQ/ceFV/14YfHEvJvQnSeYoyK46VV3McDC+7F31ZCrg7V4+I83GM0lg9/5LAM6Nf9ZmqtskjiEepW5TqsJT+m6halw2bkDVH1e8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XaoTIO5B5/izh7QUqiKmRZYvzLCtnWTbvqhlVW3pW9U=; b=r4iH/lYMvW0DTc9OVzp+WYkdg1uE/r0DoggLhhu6mFF6x5npxdH4WpXU3N17Z6BdIY0vrhy5XSZ0fbA7++sGVNNqupkVF6ApVf7+KbK54If99NJYYhAAg+paG+stmS/tFWAI4rOgu9vYTS2z0Rax1cCLX2ptYmCUurOPqG7R4jDg7V0PKN9ZgadzTOanWS3TgEnmm0hbTVBn3PfdMge1YP6LjVY79D+QNhr3jKwSGHIa8mcqQonVP6yUwIjzdiXbWgUOcRKDjDZslfyAGi0slbffb2CtEWBTCRG2KcES18e01UgxSRKxqLC/IYKKUn8emU9Rod6zTuOTp6tjrGnVEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by DM4PR12MB7645.namprd12.prod.outlook.com (2603:10b6:8:107::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.18; Sat, 15 Nov 2025 01:09:27 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb%7]) with mapi id 15.20.9320.013; Sat, 15 Nov 2025 01:09:27 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v9 1/4] gpu: nova-core: prepare Spec and Revision types for boot0/boot42 Date: Fri, 14 Nov 2025 17:09:19 -0800 Message-ID: <20251115010923.1192144-2-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251115010923.1192144-1-jhubbard@nvidia.com> References: <20251115010923.1192144-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0097.namprd13.prod.outlook.com (2603:10b6:a03:2c5::12) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|DM4PR12MB7645:EE_ X-MS-Office365-Filtering-Correlation-Id: 434c29de-7f6b-42f7-d87b-08de23e39f22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5yUTyDnwD1I1uWitjXmdKIWgVspCLWzH7yPqrXPFA7xqb7R/CL48fpJzbmC+?= =?us-ascii?Q?gc86UH8Yba3u6A5SDAHP+adDIdgd0uwS++XSI80/X+zWTiLccGFCrqnZxsZz?= =?us-ascii?Q?6YR3HlHHcjN3/eOCnUfIqew4OPqEWDT+9duL0xWabZ9lcGb0eXvI/nJKZudf?= =?us-ascii?Q?RQi4pvlM0xfjFelNKU5HdnMe7wXPexJo/XwalTOjYoLj0fxKZ6G8DcU0noLw?= =?us-ascii?Q?c6B4PJiNSBz9qplMlpHXGb+Q2fKXcGWK3di5Tip8sfJQ6k4KHrKJ1Hx2/HSp?= =?us-ascii?Q?DErO5zxIWg4A92YCGSnnQAEBX7G9K0CE4ke5ardCyHULoKcqhU8O5nKcewZM?= =?us-ascii?Q?kdVVE368Uubvf1K5szQiMcir7yiOpCYeNWYKGpGa/MJp9hncFfuoJFfWaP0Q?= =?us-ascii?Q?BAqwAz19evvrVW364S4KO8c7e0qdFSLGjxFyYhYlWNH+nvmN4CIc5c9aAf8L?= =?us-ascii?Q?jHRqXJqqMs6PGlVR6hW19XnLaqv86CqGrCRoxW//S8EcikQeoR6t6+5C8sZN?= =?us-ascii?Q?ealBCAz4O2Evlk2NsPAB2jXLHGWE3XOanhFp+Qet7KqoGh70S6729vOsKF60?= =?us-ascii?Q?4MQl+ELICDvKYFE3wyc6x3YfeySB2EP+8zxHYw6t3pqZEBKSe8A9UmkTwF6B?= =?us-ascii?Q?T6MWX0zfTt48pJYn+3MsuSOKygstPEg3/VqVHtvExgu9S7htvcHt0GnMuF0m?= =?us-ascii?Q?ZbyooJQUy46BgbAQWzQ7wZOVQVNRGya6chAY+vPAZWDxKaZIODvPlPyI0fuo?= =?us-ascii?Q?ICxZQ6UkOTlYrHrZcnw36kzSjQbe7DSMzDt/9obAcMW9FjK2kfKloCaBPGqV?= =?us-ascii?Q?K6NEeF1YuyDS6iSwFWoeGWbuUQVjOJrPCbz4wjz7ixne9F61nphdryf39FER?= =?us-ascii?Q?gd9vkyYfUv1heiCpMt9egt+ARLyoaHMcHFrS6uN91ITp3uvbmpB5S3TChVee?= =?us-ascii?Q?08SJrK8eD3foHHKL0SpVdqiOikAAVmf5nEsAwmW1KY6qaogZBPa62Cuh28cQ?= =?us-ascii?Q?umBzBT36juw0lp94+Y6DSPUdD6TZoh/kyh1InjUQG1lV2ey9M5J0iMoMKeFo?= =?us-ascii?Q?3mOqg5rzmOyfi8UajmOfE1N8xY/Fxui6wmLDnKWmGH+h/Yii+e/jdt20q4L5?= =?us-ascii?Q?qmZ0D3w1nB1nNF/7nSb/s3vRkpgeCg5GCDa2WH7US1Mp9/m0jUUThs/iDU1I?= =?us-ascii?Q?8as6q8zzo2FLTODSUPLZHEX9rARpJJoZ4Eh2/c5aPt1EIX1DssRjBGDT9SED?= =?us-ascii?Q?JbAm3CuT++n6zb+/YTBOhRwvd5eirMhnUR5zmlrzpikaB9ViMBTftbR2GtGm?= =?us-ascii?Q?sdqmFFgRqZA42aXN6OPqegD/GQHE3Kqv/qiWmy7C+UveWHJRtFhpLOEnVU3J?= =?us-ascii?Q?H00s9lfnQz4NmZsTIXjLER6DokO2TNBlKoFSQBuCOrxSVOc917bCjFfYSN6b?= =?us-ascii?Q?Q1eFqQAWJ+KSvmUff5B5ljW/nAyeA3Sj?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6agX0lNOYit6jD1BxBlVemkHcUYwRw9it1bSydC0L7DUWWK75D89UMTw4OcF?= =?us-ascii?Q?1h+K4DfY2oqjJ+h5bTa6YauDvRbKnLZA86O3tvpnvXTo56ypUaDiM4M9KINc?= =?us-ascii?Q?xJsGfLtUOOAnnkk3xuo1l7J+kUaKMODnDYRMk9WoXzI4jxhEtegElSRZWFzH?= =?us-ascii?Q?cAq+VVjojbLnf0RXnrTvedkuy4FIRZ0BIfQRV6exlUkcWTP09CeGHPTsJl0f?= =?us-ascii?Q?jN2uLiAcNP9N3dhhHcb6oQ0lnh70/vqyyPB8UjEPRtlenXfrMnfLAT8kO10y?= =?us-ascii?Q?TqW12ZQIbzFE47ZO4BP5pLG3zu5KmDN501SciGDHSo/H7JfPFKdimMH/HsoW?= =?us-ascii?Q?+FN3diVz42i+D0H8Vd8QwqGWjylZQWyqhf5kTMLun01yPzMF4umaB2sLnURS?= =?us-ascii?Q?KUgQwh6ZFKi3nn3ZPyP5HsdMB4cmmkf/ygrAplE+g2xSiYsUNeV04ASeA2gD?= =?us-ascii?Q?Win614i4My2E1MTsLdQMMx34ealg2IlAFg8pu4NsjNialolFCgAesvhgjYIX?= =?us-ascii?Q?ehto1PWJqAyjjDAj9msbxkru3t4hUIhEEbi2GC057eoVR52bKDYVxc7fZwTQ?= =?us-ascii?Q?r/GnBSQobPNNVj2VvNWYM/u7TvHExeD3CW/T5r/5ScyVEZwxutVn4XTU7Zzl?= =?us-ascii?Q?kNE+XkUZOWH3L30rmWgkxmSL1rhxmboEL5UwU+9f94EcVLReE1fk6FUqys3/?= =?us-ascii?Q?+8n0ZSjpl3z/vDFd0mOCAKDJiq6UPFgzUQ5D0GucDt5IOl2BrXxzIfSJ0w61?= =?us-ascii?Q?1Pgw30X4XHDB54lkn7eDPRbmR0QmXUj99OXWd0iL9Jz9aoWnY22rtamim2Zi?= =?us-ascii?Q?3Vs+AtECPwSzUIFacvaicS07xUF2qEZc7aIt7iFwt+EatJsdwbsccQw4yoBd?= =?us-ascii?Q?TYcwDz30sWfku+c8xJOB1n+n7K8Y1J6jlqphFadhwfAGSVZNoEiBh9iyJdmc?= =?us-ascii?Q?nG11ff6ezFVgkn80pppfTWxzhkmdYZ3ZdEtcV9LvNzk4kyJ0KrijCX1eK3k1?= =?us-ascii?Q?PyPFloqV8tcZryyJcw7pb89rd49FfcvyLEc6E4v78JRnRApuhKabJpy5INym?= =?us-ascii?Q?k06hVMiIiwpIpZq2Sn0KrbvagsyWU1GePZ7nJ171sts28R3mUJu4ik+NnKH5?= =?us-ascii?Q?eJXragKeVEr3R2NKKTNe0Q3W8S8QP45VFlyMBNTBuw/zAm7/Nv+/5p1gTMS6?= =?us-ascii?Q?HodrSgOPadURblAeQ8+3ma3OdCQwm/VROcUxkLV4rrvZc/KzfJYZGhidmzpB?= =?us-ascii?Q?lQgcqjlNbCj4avZnMjEELxHEGFl4h9IMznRGYPoKE51IeUj6SjjuXwp5PmkF?= =?us-ascii?Q?yMQCg7H5Eo3wEc9xwFmQEp4SEOwQE7VddP+Hdc32WkAuFMpCkaND9y48Qz7o?= =?us-ascii?Q?XvfMVAtn42E3zDRL6zEwr+qFin2+oftFi4fpZF5vAo1OYdJCxnpLKOJgVAQm?= =?us-ascii?Q?gPKkMj4IS05LfrepTIPflrEsTz9w0jshzELS8YcBKQITr3K5U2au+08zfhvr?= =?us-ascii?Q?5ird2fSpuxTNXIwRmdg/+0VIzfPg3efvsptxMeIACeT7k2fltXAsk/0lWw3s?= =?us-ascii?Q?8xZ0TBwoxIdgIlSX+UvSdpj6CUyH6MRofKh4WRAF?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 434c29de-7f6b-42f7-d87b-08de23e39f22 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2025 01:09:26.9313 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ELD6PPTpxl0OBWVo7EpV2LPJKbTZAciO11yE1KffRCIUZex9G6EQrKtAHsWNl4WEjFZiQdmaeVvG6M913Qtygg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7645 Content-Type: text/plain; charset="utf-8" Allow a both Revision and Spec to be constructed directly from a NV_PMC_BOOT_0 register. Also, slightly enhance the comment about Spec, to be more precise. Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Reviewed-by: Joel Fernandes Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index dfeba9d5d8f6..57c20d1e7274 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -147,8 +147,8 @@ pub(crate) struct Revision { minor: u8, } =20 -impl Revision { - fn from_boot0(boot0: regs::NV_PMC_BOOT_0) -> Self { +impl From for Revision { + fn from(boot0: regs::NV_PMC_BOOT_0) -> Self { Self { major: boot0.major_revision(), minor: boot0.minor_revision(), @@ -162,10 +162,9 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resu= lt { } } =20 -/// Structure holding the metadata of the GPU. +/// Structure holding a basic description of the GPU: `Chipset` and `Revis= ion`. pub(crate) struct Spec { chipset: Chipset, - /// The revision of the chipset. revision: Revision, } =20 @@ -173,9 +172,17 @@ impl Spec { fn new(bar: &Bar0) -> Result { let boot0 =3D regs::NV_PMC_BOOT_0::read(bar); =20 + Spec::try_from(boot0) + } +} + +impl TryFrom for Spec { + type Error =3D Error; + + fn try_from(boot0: regs::NV_PMC_BOOT_0) -> Result { Ok(Self { chipset: boot0.chipset()?, - revision: Revision::from_boot0(boot0), + revision: boot0.into(), }) } } --=20 2.51.2 From nobody Fri Dec 19 14:34:39 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010006.outbound.protection.outlook.com [40.93.198.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 210441C3BF7; Sat, 15 Nov 2025 01:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168973; cv=fail; b=UXFjq8ROxGnWqwf547dFa3PM9HHfW3Ki8Sinz2rWCzYXV7yyQ/merjaYhrFnEGXMWagAeBclf1VV4N8pE29T9OBvjwpSiHf3naiqAgofKCMJFoh+dY7k6fZRJfG+IwHqNXz/yftYuUFVT1/I6a3M9Gdfd7Vj+cYhKeJEcXJsOrk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168973; c=relaxed/simple; bh=T++hhDlqS6NuDeq87kvuKKenclaG4X0Ww04iLEtLLUg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=XBR4b/qqvNKHareF+MvxpbkbhiQY5m9WN4LyvRoXKSEzsF5bsIXIIHRNopzE77qs7FMiUE8TfQ2O1Ac0rKiUqPfGhD9O8gy17+x1a14B3hrHSybCl2z9zXc4xHZknht5ObWbo7VYCOM3chq4wrXMEGNBgotziYdpA6KbgwGMHZY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=VB7g4EwQ; arc=fail smtp.client-ip=40.93.198.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="VB7g4EwQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sSlfJ25ojxMN4yd4j4JheSqFhXvBEsaxc1+0UqfZr7+udPl6oRa52G73ADHyeKV7tSCxg1OaeomnWk4QNN+zPybaU8noPqW4W7nSoCIz4NE4qw3j7ReDcjBuLBjYJ+rVTh1OqW1Y5ouW96brT3Waf8i10+KeujxhyA1Isva0vhSJk0awyQxrrdoiFt0jH0w9OQrPnbLB6A3q9IorMZ3rO10FdqhLXySha6wGJyw6ETyXCx3m2h8iFdvoQkCAUvJ6Va4mYatXnmn9His62M+FAs4YKpf7ITOYHclhIED5wTlusMy8sze67AA03KfhTLhWKOjm19hJYJqVrhRbPzBzPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r0F23LPxvpmwNp3kKYQSwA2OyjDovWJ7mR5q4Fag9Ks=; b=xhBbOWsfF35vOuB5vjCDFgcFfnc755YxSRjT8zsyFSartMnpTXX3oZYFSttwQTjFbqB7B24ZBaojD3m2ZkeBxpKdXgAFXG1bQmssfg/iMTBXrvLOozpQPDDOQfuvi7IimQf5geW6OTUKYnEUzcyEzDBOwFWziypnm0YsslBthLcDKPqltEiGPB5awMLeoTFHU9dlEhqOFGDN7+lzKp2SIT+yu3pAn5C/2YRWwpp9im1ukFHfJpQz6kEanAqNLrqVzhItWbkNCxelyb055hSVrSxpcf9aNbSf3h3O99Nksvce6/Tux265GhmzUGcj7fmP38PNTUCYXEHyqbr0LHo5iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0F23LPxvpmwNp3kKYQSwA2OyjDovWJ7mR5q4Fag9Ks=; b=VB7g4EwQcYdES/AHoJ6dkjImAJmrl/TM8lGeCE+A19A+myKIVgMpxZr7mLLWyYku4BbVlKo+wA6cA6lEMP/BBKCaG8KRBSTditZbxJvCDCe3n6xeTHysyAWNmzbqgOeUVh8P6EUgkrroWIvEgtJT6T5Dwy/p4rBoICYYPHXQREZUOqSJ+lgPfBBmhqo+QpRIPEcxmk/2AYpzarbKhvNk877eG7PSocs/6By75R417IdMHI7dtiVsUDpOKq5sbaydutEw8H1C4aMPEUNKRp9jz/toXE5w7aez/lhdbJwqhatdW+k1VeqxP+L+Xa1Y4TOODMBArg46ueBO+jBAkxlkKA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by DM4PR12MB7645.namprd12.prod.outlook.com (2603:10b6:8:107::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.18; Sat, 15 Nov 2025 01:09:28 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb%7]) with mapi id 15.20.9320.013; Sat, 15 Nov 2025 01:09:28 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v9 2/4] gpu: nova-core: make Architecture behave as a u8 type Date: Fri, 14 Nov 2025 17:09:20 -0800 Message-ID: <20251115010923.1192144-3-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251115010923.1192144-1-jhubbard@nvidia.com> References: <20251115010923.1192144-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY3PR05CA0019.namprd05.prod.outlook.com (2603:10b6:a03:254::24) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|DM4PR12MB7645:EE_ X-MS-Office365-Filtering-Correlation-Id: 84f8c66e-c4aa-447a-f14a-08de23e39ff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FeyeK2q/+hFWLIgSJhdUbadAIhigTBloizD28HXuZOtEbMbz6Dd+e66KX/ao?= =?us-ascii?Q?ZqBJDQFvRoOH1CjDSg7mjyE14lfhAzO1mi5+sEzkbzv7zNHGGuvtsiEFhVo6?= =?us-ascii?Q?UOcEgiy9Eeffw76dfjg3vwuI0X0q06yXKpxkgRAehuOxK7/APSE37f9QAaoc?= =?us-ascii?Q?fTMF+lONdBPYJxyVeTEdduD2idJBdRY4N5qe1GOrwzoy5krvA3Tfpge6zwyp?= =?us-ascii?Q?ru+BxPZNgBJI+q9g2wrFJvYWJ/Z9YYaY9kz5xghKT1x6lC00888HiYuOJMqw?= =?us-ascii?Q?UdczpovhQSLuUgDuplnBe2ZRoDGP2+6RkciyAx+kySTyZIMTu5oZ/GAz/rZu?= =?us-ascii?Q?U+hI72OncHo54+GBYq3dMyLR0k9+u6ku1yvlGSl60Qqfv+KEsv5NbVMoeV+M?= =?us-ascii?Q?lJjI3i85XMu7P+ILaARWOdedBXKUSddexSix4K8gRZbyGv9wYvD5zO3/2gYt?= =?us-ascii?Q?dpxa0r7w+Whl7Ajy46NHksf2D+ZGlLsiViAOGhHw4V1e7Fzb+o1XUZCX09Qc?= =?us-ascii?Q?6bxpn28mFjVi4D9aXZ9huo5FxCsUOwODqF6mEibxjxEetwj92dVy+kEnLkSM?= =?us-ascii?Q?SM1IQAzGPJ0MZ+CcTfhF058c1EHMjiMiXRDn0XCHnD0cwDvxZOcZ3bJHMcLj?= =?us-ascii?Q?b9smS1bWr8p9ce1SdR1UNPZjMGt4A8mXozY7fc4+mYbZsS76LqaVuDhWkBLQ?= =?us-ascii?Q?/Bk4evlhk3hT8RWrhQ0ZCo2aCgzeRpnwsH7StGKdv5n9Bl2dON9ObqkNP6hu?= =?us-ascii?Q?K9ON4zE5t2qh0MWlfFCr+V+g8PwIwpdjGKCia8+wNG+9RE08SqxV2S0vRTgI?= =?us-ascii?Q?rz6NAzHLrqwrfMqR9q7ZWOnPqCgUTj9bWGOkXQ8l8Mym6AZJFY0upWaDZiQR?= =?us-ascii?Q?p1FdF7ncRAXvYz/ShgYw6oPjxu7lujGY0pVpLHd41qyoTRO6PhnMVB+27kgs?= =?us-ascii?Q?TsyjYGmpMMVMUt5GCcbwk5/QwaPi4U8NSeXz3yTgAeq5LLXWCNJDpGzo+a0B?= =?us-ascii?Q?utzbp2w1e6hdPFXod3WCHrU/vAuJAH1OowiIzH0OC2f+lESiXSV5CLfO/LJ+?= =?us-ascii?Q?tA7WDh3qo3sZMbcahLPns9jSGObcbIcI8ufAirllUNK6UI+bXIBxUmNzYxWP?= =?us-ascii?Q?55ps+bJvGTSBQz0Qs/UNj4iqUy6uawg/v47zSU9ZafrgcoLLVPqgvQahppmZ?= =?us-ascii?Q?wFeBEZUoGyOaiYd37haahRKdprS/faypfAnELB/Ajd6cjCLsXZG3hKMFcqxz?= =?us-ascii?Q?wITT6eiUjWzJmNBkIOMmfP+1Sfshn0JBDpMosNsYb3Rl83kRann2WBEzvKnD?= =?us-ascii?Q?7qcH/2wF6ilkFRcmOm9i98/8t06k3Elw5tcgEpzXlBOwjKWpsQHJd3w1t978?= =?us-ascii?Q?dx21TJdIukRpL14fUF0r2ZuYhfQpc6eHZDP2/SJ3O3A4Nfvr+qgjiS34EqAV?= =?us-ascii?Q?+QqEAyGM/8GbJhiCNXAc0TGubNm9V3AM?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5KKe8e1QUYCxTTYOyEGz0TkECakdbVqIKfxWVAzYR1VvSBQ5AzYxj4wzdjUs?= =?us-ascii?Q?b5yHbHuEBc5h6Ka2XGYy+ArZVXSeXrnJZq/Td7LDy2FJsFmO7KJ0yViPihYM?= =?us-ascii?Q?Rhf+TvYQ2YEYao+p7ISO5feKP82frj7Wmv2KFElWAWxz+n/UOGGPR+85bVUz?= =?us-ascii?Q?kUpXygcrBeVhGamKb0kAZUyEEc5RS4B/5nkYW539FsSe7oCrJE2N3Fn9xsGJ?= =?us-ascii?Q?2Uy6hlVE/8+8L0tiQIW055jVNpL4IThJPofM92DS3x75eks/SSsSEcbBZ+3C?= =?us-ascii?Q?NLxVjdsUK6WcAMl8ocecSxwtLppbMldw94kb+PWFO4PvrsIl/3gvE8Cv1oX1?= =?us-ascii?Q?lQyGvUUUAzg66nb1UvW6naRp6VXWEKGujprk0l2qnje1x6jdafGencyMG96i?= =?us-ascii?Q?kCz3axb4XkU8IdRCVHig+mjh+dt05MiLnhgGWTliV8uUXN6mHbTc+JlaSqbL?= =?us-ascii?Q?LnCvcTJ86Q/yfnMLnUc7f5opllHuyxlwiK+SGUMtDF0v4F60EkxrhqOf+JKq?= =?us-ascii?Q?/MctuaWDRZeChga167zeq8gXcUOXthX/vb0cE/XywH1qmEbyk1NV++SDQRDy?= =?us-ascii?Q?YpOUsgLtauuQBed/5YlBAxcOepo3Asdd8+cLGyyr1TFlFZxB+eWjGwwYww7Z?= =?us-ascii?Q?DGn9tP5X0qH2i8x2bfmTh9yF8YuzSVmtA0PFJoqO/qpqFq9Shxien6txwP7M?= =?us-ascii?Q?+c6PQP3JQQfEPLuBTMR9c3jyeN0Rhrt/KOvuIHJsEq1yRxNV09rv4DCBuSRx?= =?us-ascii?Q?BYzapaP3LcBRUxkXHBQEtMwN7t374p8juYBsmH6f1QabXb5eCmT+sQOgCF+W?= =?us-ascii?Q?XBX8z8NI4DDKZ3aFRd3kEo0ccuL15xFZSmEzlNPS+DxSUahTXELj3BX5rrs5?= =?us-ascii?Q?z5aabu4HznfCk+xPNb/ve4i+yoa5bhZj+SUtlH/c4x1g3eLacsiDYRWNryCk?= =?us-ascii?Q?JLCoMFOCBZjmJD+qYIVsFI32ba9cRjn2OFNcjfssnSMf2UWe4SfAqgcPDrNa?= =?us-ascii?Q?9Rn38HEOAffrm6C5/WegLz8NZHd+qb5F63c67eQjiDvDsf/YYj06T96frZRt?= =?us-ascii?Q?IorLjg2FQNJ0D3iQcBou4mW62t6ydbB27IsXgcK7EWvaUQh5cYJLLDX8uUFj?= =?us-ascii?Q?bhBFq9rCr4FXCzlLf/aYf0fcWGKWOwB1iXgaHC+eFnJYTWtn6H9N/3VTCX/N?= =?us-ascii?Q?8nLGDbwRUPTU/Q2reuNr1Sn8iVobo6u1nDDvhHX2QnsDOBu7eyhR6re1/JWa?= =?us-ascii?Q?ZpoO5oQlze+ncHv5WzJF0p5UEEOiYKOr0vkYbBaigsMn/eCBr/IgVzd+UjhR?= =?us-ascii?Q?SjnoHj7UF+vi4jh3tL1PF5Nfi/ckKsP2kEeSo7ZDcQ9/gkPBNWB022mL0lNq?= =?us-ascii?Q?HKR49d6FjQ1WuUb8PmVVtpsoNocMv/iyKbl5gvrgJeZB1YbObQXwU8AGCVJd?= =?us-ascii?Q?siM/orvmloeteUkP4lNuVaZlGVC0oba+rY1SSP5s8JIJhLIBV+Cbl6il0Uyv?= =?us-ascii?Q?czAT3jtAw9Qzl8taZrFjx+xQExIXCOo+ORFiwEH6+8X815JpA0LaT7nBGZkl?= =?us-ascii?Q?XRsDz+gBaMxOxzivwtF7IfTx+xWY+UCR6Su8Qg7H?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84f8c66e-c4aa-447a-f14a-08de23e39ff3 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2025 01:09:28.3174 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qbMgvDz91e3eJSCZ0aupgDcFf44VBe1k4K1/4HF7VvKzVWpIP3sx70EoCFgcuGVpEa3vbcHCqwb77A3IBLGbXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7645 Content-Type: text/plain; charset="utf-8" This allows Architecture to be passed into register!() and bitfield!() macro calls. That in turn requires a default implementation for Architecture. This simplifies transforming BOOT0 (and later, BOOT42) register values into GPU architectures. Cc: Danilo Krummrich Cc: Timur Tabi Suggested-by: Alexandre Courbot Reviewed-by: Joel Fernandes Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 57c20d1e7274..88a6d7af9f37 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -122,8 +122,14 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resu= lt { } =20 /// Enum representation of the GPU generation. -#[derive(fmt::Debug)] +/// +/// TODO: remove the `Default` trait implementation, and the `#[default]` +/// attribute, once the register!() macro (which creates Architecture item= s) no +/// longer requires it for read-only fields. +#[derive(fmt::Debug, Default, Copy, Clone)] +#[repr(u8)] pub(crate) enum Architecture { + #[default] Turing =3D 0x16, Ampere =3D 0x17, Ada =3D 0x19, @@ -142,6 +148,13 @@ fn try_from(value: u8) -> Result { } } =20 +impl From for u8 { + fn from(value: Architecture) -> Self { + // CAST: `Architecture` is `repr(u8)`, so this cast is always loss= less. + value as u8 + } +} + pub(crate) struct Revision { major: u8, minor: u8, --=20 2.51.2 From nobody Fri Dec 19 14:34:39 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010006.outbound.protection.outlook.com [40.93.198.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B05251DE894; Sat, 15 Nov 2025 01:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168975; cv=fail; b=gN4QgCXgKD+H62M7zAXMJWDvlOjO1TObNbUwZU/8tsVCsKDHKIotLYVBJ0UizUs2ZrTx71fY82Dc3IL280pfNI+6i5xBdCQ7yepo9ZvLSQm3XcpqPtJwTT+WqzcSbes1eQhfUM6EjaEnF0eFD0Lu3mv1ztQjjzLxe6mCpRKTymY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168975; c=relaxed/simple; bh=VE82iuP/vvrXjDAv/+BNWFTYN/WSHIir/SIZrH2sqdw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=X37h3vWFAVWK7KZEfTOi/mrrgdSgW/tCHSaP4cP1x/6XMUHRU64W9U8bZZszdx/Yv2MkzBQPnzcImRscWrqgfKSTAKJvk/JemsMs484aOC/pzU5TgURMwld4RWghWE2eNW9IGn+HR2SPUfREWqnnPZOfSkBxmBDIRX/xtZ71Mfk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WXKTriLj; arc=fail smtp.client-ip=40.93.198.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WXKTriLj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ohLsShd8tJq/0j/QXptujVmQ7DgZQf0P/oM6CqBVLQ4EHitf2ypwq7YznEDI5GzxKXsy+yT4w2q5z3eof/1VC1y1nRxUsgDeRXwL7skiEvfoNPJbLqsPecWbU6RfYXu8dcoviB7k34Om6LlscsbFhN+1LyCnCCc+Du3q+0/XyZ5/S9SVqS3cgiKPlL6Gpktir+DlCTt5fVYfD1E12TGGs7T6U8loWnOsdeNdbnIao8sLWunRRYdvAMrHvFhlz5s3Zm+FdQBAK2UH6z/AFxKnUAjD8WNJw8IE6GqpszcyGgCWh5i2FbPqtSHzmWM9SZrbrNCBjtCuLNcHg4Cb4yRbTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FHJ0NAlhhUW6X+ut3rPCiAc6VeeN3F0nLm71bNdkFOs=; b=sG16qOruQ4Q45x0eCXS3pdpvD4tpURCXMTyimld9Ppf3+RLM1btd9LCXH4jZ12lLKQrgSZD/IxQOo3S6Y+9901SOwj8gFHom9aWrT9ORIa1zhG4sLcbQXkeqtJViWTO2olXmSNVT8YtE1wPAhSn8J+kkXc1xvLB4MzuyDUj6/jv0JZ1+9p18Nd9veDMYomdYNEwZmUpSzDQRD4KqsfNEz2ha7Riiw7b+JzeatH0CXv1G8BpXCqGBfmOI52iuyObXGvQOdGAzv2eiNQ0T4nMO0ZGLqushWvQPLvr8iong0aM9JTWso3ClrdVKm1+tGaiWLKCFaPHcdTh1BRCeufqukA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHJ0NAlhhUW6X+ut3rPCiAc6VeeN3F0nLm71bNdkFOs=; b=WXKTriLjSDqTdX61f7lHRbAI/n3edRAG3Tn6IpYoocXIkcLia1bdoeXYlaCxzmr3x3u45ZbnDxBJougaeQY2qD4et0A1pcY8gbLIJmqwurhBgUZvzW44kb8HRR+k3uJojCZ7YpVPRn0extsyRq7AQd8o2xJAE53b7349uXzFblxcMBlBlSnZ3I9BQ4UYgaej8F3T1wFHPUxs4pJoXPhz+AaHAYDNDKR7r/LqN1EUENou7XaZMV0piWt/YqXd5hUfvioVAq+DPbG3KjPMJlUt86msstHDTyWC3ugtRbocUQhVetbU/QJfUUGVzOPxhy+WPCD2cfzy3vGVOZ4kxu2zQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by DM4PR12MB7645.namprd12.prod.outlook.com (2603:10b6:8:107::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.18; Sat, 15 Nov 2025 01:09:30 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb%7]) with mapi id 15.20.9320.013; Sat, 15 Nov 2025 01:09:30 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v9 3/4] gpu: nova-core: add boot42 support for next-gen GPUs Date: Fri, 14 Nov 2025 17:09:21 -0800 Message-ID: <20251115010923.1192144-4-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251115010923.1192144-1-jhubbard@nvidia.com> References: <20251115010923.1192144-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0124.namprd13.prod.outlook.com (2603:10b6:a03:2c6::9) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|DM4PR12MB7645:EE_ X-MS-Office365-Filtering-Correlation-Id: a55099be-f125-4cfb-3878-08de23e3a0f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?sHxuDJc5Q18NjPQAJ/DDr2KD5UlBS++2lO98BiFqu7Ds37JXofO+uV8uE3AQ?= =?us-ascii?Q?f+3oyyUB+3UXPfMabmAj5bilYuI3jQrFh0rJ+MIxM5ZXQarksyEIl6aQc0sG?= =?us-ascii?Q?EmX3f0yGtGkcQvGXiO04ZeZcsNcntdDdXrhgQ6+idJr0v7mOr2Ehe1GkqB3Q?= =?us-ascii?Q?b45ERUsfuCY8SI2TVyC3xtxAkzBnOaoZuF92GyC/SqMgxIbUKqaje+pn80u6?= =?us-ascii?Q?gxcOHdtfD9cQXpJ8k3swqn4TMhIS08Kr7eawZEkNOlYfiM03p5OMrSAarLKN?= =?us-ascii?Q?n72hQ5xvxri3aLUpTyBKGcLofnTTjBXJ3yxjVf/GZhdENu311nZnHmQYDaEW?= =?us-ascii?Q?makPb+9ne5tU284SwLX7A16WeZvzUmgYlSMuK3bUtH3/fkjf9w2nVoNZnVz0?= =?us-ascii?Q?uKVOfMtMB5e87ZUqlVAoX2GdRQ3UBSYrrjF0ZAOggrxEZLeCk6CIQfiaJiS2?= =?us-ascii?Q?7mzJAuqyxhquUJMEznA/PKpLM7TewAmwVzwHuBtm4DWzhkv6sep4VjrcI/zS?= =?us-ascii?Q?tqDeiSQrSjOv7TysucrbFOaRuIRL/02Hifc5/Nb56dH5MA4hSH3M/pVTBXmZ?= =?us-ascii?Q?79LeHc5iqrJPwA6sN+Jlqb7EpEGzKRZdcKg6ix43R2tAePc/zPNwF5KyWauQ?= =?us-ascii?Q?cJvVmwOrmZuZxrDXDDs5JI9vTv28/qL7pCyYEH2sJ3MWcanP0d+2Fr9Av6cx?= =?us-ascii?Q?a4bPinTvWiZ1Fq8HIfy2p/5MAFs2pRH/BNN7SMa7u6m4FlzR1J3OTlubibK1?= =?us-ascii?Q?7xAdk2P9bOqr48TBl6L5RXCdfIEqepDxgHSYpJw6Q/Q8clWAy0/E3ms1X+uM?= =?us-ascii?Q?Xb+8p6Zfqr7buPcx+H26951dHj9ybhy/vqnwesW4ciZ8HaB26CfTDVltE7rJ?= =?us-ascii?Q?TYoXLxzZF1UhscOOgg5VPU+FJACmCMZ/Jm6rsJmIiVC63Ed4IKS5TwBFmu5R?= =?us-ascii?Q?4TJsY7dXcdv0QzTOeCazIA6qEtbpTdHej+vEfaC0yOaDmVss760NPaFj3U6e?= =?us-ascii?Q?mXO2wOEsXc8/oVo5D0pUVXS97c2rHOezg3X6FxDktqDtTnZV8obpZRr2tsZ1?= =?us-ascii?Q?xKgf6+AaGP3bk0jOSxSxP59obWNWvOKEtMleNMtypQXE7ZmUSf7TCS3yMfCq?= =?us-ascii?Q?L9a9rRq9JtaxMQ1Lr0Q+k/Oj09HhbIOqltXYGUsPlaZb0D8/d5dIv3WGmRDb?= =?us-ascii?Q?Fa/Kbj5HdqXCeEwVrkYGygpSE2v0FyMG6A99ERYgEGm8tNwcAevmUwfAmj73?= =?us-ascii?Q?HrQ0y9MmG3YaO3v0rrmUyBXr9a1Ygnl5eh+DQzS7BjmKYbOcfvg2UQqCcW55?= =?us-ascii?Q?pUpdaniodzQXbZ65RabFeMx9OKahsfzmr9L1sB/81DV//t9c9OTo6+np7zpI?= =?us-ascii?Q?WGGYKVh8lY95CB5Qeh7/sema/XbaQZnjhvjKaolxBxpIbiPtTW2/rXxC1Rq1?= =?us-ascii?Q?0jzYDZGQuou3kXfMv3jn8sUG2TsH36AN?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PjDf+l4HwovzLGhGhNByPfjhJPs3Z1azPxXFNWrAvm2hQ9K4T+Rgb92GE3Qg?= =?us-ascii?Q?wVMaknxcSXGeK14GH6RQaOtBb5+zl/mH6qOphGGAvgEzkerh1tSPjZtO5+dj?= =?us-ascii?Q?aTfzA/+4iU6LbyG1kFk5fhbqsjxC9IzXnF/kNSnTBLNS4y2PZ9vVBTmA289m?= =?us-ascii?Q?3PXVrO1yi9QrHh7kROBTligtASfrlf6a9nH5/02O6/cQ/dQ+7KCuoTrz4Ezu?= =?us-ascii?Q?oCUd/AY2kQAk4NPNWP1aXjE0wKht77W/g6mUzIjFBACGv8RcCMphf2GFZSOo?= =?us-ascii?Q?rXdeggdcYTG6q+tje78VxJJ9Y6pXs6V9l78fMe+AiudQtMp4+p5QGcU5Vfam?= =?us-ascii?Q?GiTJw7Y+l2yUF2UlKgit7kcpBae3e/MifnFC8z0eQmANezUlUUqFYXhIACTM?= =?us-ascii?Q?8wrH3YDID0jVsGDuKCTAo7BnUpXme0zDw+x23lkb2SAB3JlU4x8T8es9zu+4?= =?us-ascii?Q?T8UODR/1GWf0HSyx/x1jyBuH17+N/XrokY8+uQoXTP27Vxqrd7rMmGf+54BX?= =?us-ascii?Q?qA+TfKA2hSgZ17K+6HyT0l1lpEYUWcyDFMmZwirJyYwqTtHnjldUXh3tU9p7?= =?us-ascii?Q?eq0me+YdWx2P3FBzLtwwfNnewY7SBBGhEZhavM7lUeo8G2Q1KNDey+kI33zp?= =?us-ascii?Q?Ww0q/D5SmJq8iI8eeg7S1lknZdu772sYxAAy/5z7jV6oANYYl3vTR5UqIQiS?= =?us-ascii?Q?z9mlczyg71CLHmXthfb5gKEgm66SaZ3VvQ9WjjPkgwkfA42P2R2iD8BR4Uu7?= =?us-ascii?Q?vZCaPHGp9bYyiDNfQt9rA5w9bA1ywMmKGPgsVP7GteIeX1huhgFHLAIgt5B/?= =?us-ascii?Q?rD8yDvoDNb3/msN+jbpFnmSNRUjYra9OD5Y0T715NXPLgKWD30sQekSyXv4z?= =?us-ascii?Q?T8/UFArCxqW0pEnOuMLVlNPx53d96z3gpCKKZkz4SrhFslYb/QB4Dbn6clQG?= =?us-ascii?Q?8LzMjg04dJa9gRNgpPt5PtdLdlNZAO1c8ubQ8OTrOgg4efI22wsD1Ue6EAiV?= =?us-ascii?Q?pmwyIllLaioMPsEvFVYtvwccEX626mF9Iij3JelfYhB8Yp5/ht2QYyjn2FC3?= =?us-ascii?Q?lduLklw475rKntDh1qtN+UOINaP9Iex1+e2JTPtfAoIC/lapmEGG54w/ah8O?= =?us-ascii?Q?VnOTaAKyJwYVcBlFq7YXNd8ktUYyu9LnbBx5a7X7aeHl/o4lPJ+CxgrCrNl7?= =?us-ascii?Q?oeUuOw9TTiwAkDvNRtT4UyNaQ9yLyfu682rCDNZoU67NBQZwJptDTjbHF0JR?= =?us-ascii?Q?xJm8wsvRJENgij/DfqCc3iRDlBa1DgEZX/fNGahqzJTKOQfog2Cno0BW2r+P?= =?us-ascii?Q?cpJdsFKbhzbcYEA+YWnffn78eXb2wvPnMNBCm1GLDTTvPZyhHndZD5SyEwWz?= =?us-ascii?Q?cgE0ZpezS0adfsIGPv+Iv0AqKLcVM7b9/2bGfyvYDlWHvKta12N+zk9kJuR3?= =?us-ascii?Q?MFvYw9jr9VPHGTkNDKiw4StEkYccHrqzA1YUykzDsMbQTyw9NJSismqnzvFH?= =?us-ascii?Q?ADR6LivTHQKpGhK/qg/pk6zGpMMbSPGZUCaLSvukcWLAAW4w+8tr3Wmoe+dF?= =?us-ascii?Q?I9xYoGjK6S0yxXcGZvuFXrgNau2zgdZ2+U5qsm/7?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a55099be-f125-4cfb-3878-08de23e3a0f7 X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2025 01:09:29.9847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gi7wNmfFZFs4DaTEZmegVzZMRTMrHCp9OZ4Wnqj+68lZoi72f0zZfTNRQHnYvqvlV6lveJIRcGaOlyEhLu3zvA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7645 Content-Type: text/plain; charset="utf-8" NVIDIA GPUs are moving away from using NV_PMC_BOOT_0 to contain architecture and revision details, and will instead use NV_PMC_BOOT_42 in the future. NV_PMC_BOOT_0 will contain a specific set of values that will mean "go read NV_PMC_BOOT_42 instead". Change the selection logic in Nova so that it will claim Turing and later GPUs. This will work for the foreseeable future, without any further code changes here, because all NVIDIA GPUs are considered, from the oldest supported on Linux (NV04), through the future GPUs. Add some comment documentation to explain, chronologically, how boot0 and boot42 change with the GPU eras, and how that affects the selection logic. Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Reviewed-by: Joel Fernandes Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 41 ++++++++++++++++++++++++++++++----- drivers/gpu/nova-core/regs.rs | 21 +++++++++++++----- 2 files changed, 52 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 88a6d7af9f37..8e04628ca3d9 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -169,6 +169,15 @@ fn from(boot0: regs::NV_PMC_BOOT_0) -> Self { } } =20 +impl From for Revision { + fn from(boot0: regs::NV_PMC_BOOT_42) -> Self { + Self { + major: boot0.major_revision(), + minor: boot0.minor_revision(), + } + } +} + impl fmt::Display for Revision { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { write!(f, "{:x}.{:x}", self.major, self.minor) @@ -183,19 +192,41 @@ pub(crate) struct Spec { =20 impl Spec { fn new(bar: &Bar0) -> Result { + // Some brief notes about boot0 and boot42, in chronological order: + // + // NV04 through NV50: + // + // Not supported by Nova. boot0 is necessary and sufficient to = identify these GPUs. + // boot42 may not even exist on some of these GPUs. + // + // Fermi through Volta: + // + // Not supported by Nova. boot0 is still sufficient to identif= y these GPUs, but boot42 + // is also guaranteed to be both present and accurate. + // + // Turing and later: + // + // Supported by Nova. Identified by first checking boot0 to en= sure that the GPU is not + // from an earlier (pre-Fermi) era, and then using boot42 to p= recisely identify the GPU. + // Somewhere in the Rubin timeframe, boot0 will no longer have= space to add new GPU IDs. + let boot0 =3D regs::NV_PMC_BOOT_0::read(bar); =20 - Spec::try_from(boot0) + if boot0.is_older_than_fermi() { + return Err(ENODEV); + } + + Spec::try_from(regs::NV_PMC_BOOT_42::read(bar)) } } =20 -impl TryFrom for Spec { +impl TryFrom for Spec { type Error =3D Error; =20 - fn try_from(boot0: regs::NV_PMC_BOOT_0) -> Result { + fn try_from(boot42: regs::NV_PMC_BOOT_42) -> Result { Ok(Self { - chipset: boot0.chipset()?, - revision: boot0.into(), + chipset: boot42.chipset()?, + revision: boot42.into(), }) } } diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 274e53a1a44d..c6e2e08c754b 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -40,13 +40,24 @@ }); =20 impl NV_PMC_BOOT_0 { - /// Combines `architecture_0` and `architecture_1` to obtain the archi= tecture of the chip. - pub(crate) fn architecture(self) -> Result { - Architecture::try_from( - self.architecture_0() | (self.architecture_1() << Self::ARCHIT= ECTURE_0_RANGE.len()), - ) + pub(crate) fn is_older_than_fermi(self) -> bool { + // From https://github.com/NVIDIA/open-gpu-doc/tree/master/manuals= : + const NV_PMC_BOOT_0_ARCHITECTURE_GF100: u8 =3D 0xc; + + // Older chips left arch1 zeroed out. That, combined with an arch0= value that is less than + // GF100, means "older than Fermi". + self.architecture_1() =3D=3D 0 && self.architecture_0() < NV_PMC_B= OOT_0_ARCHITECTURE_GF100 } +} + +register!(NV_PMC_BOOT_42 @ 0x00000a00, "Extended architecture information"= { + 15:12 minor_revision as u8, "Minor revision of the chip"; + 19:16 major_revision as u8, "Major revision of the chip"; + 23:20 implementation as u8, "Implementation version of the architect= ure"; + 29:24 architecture as u8 ?=3D> Architecture, "Architecture value"; +}); =20 +impl NV_PMC_BOOT_42 { /// Combines `architecture` and `implementation` to obtain a code uniq= ue to the chipset. pub(crate) fn chipset(self) -> Result { self.architecture() --=20 2.51.2 From nobody Fri Dec 19 14:34:39 2025 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010006.outbound.protection.outlook.com [40.93.198.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 605FC1F17E8; Sat, 15 Nov 2025 01:09:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168979; cv=fail; b=M9nZkkEt5Kvl+qkuT5O0b/bHsCSjl7jeflIxxSzc9goVV+ymVxp94po46sWrnDIByGrpP7M/YniYiOH20SIqp9Z9SGzTGdNPIy6CMQXnh56VaNaEOucuV5yps/vhdS76Leq6hotjBuiABds9MaTCjgb7Iisv67SbygBD9q2A0JQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763168979; c=relaxed/simple; bh=75CTzjg0y4ivq3OOJzkzFbnif8vQsMh/STW14LzbVtQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=HktC2OWm/uwNbquJlBNraXYocNBzcIVsyTeuPmDIf+CoJj76y0hIMPXj1BuhbmwgzCKCVZUsHrVmen9J8TbPC1p5JvLvcLywN+ikUiJ3t4G7q33nEXZ+m0H0VDSQjvR0qAqM6Y5zTDMXqXS/ZaFfUerGVJ9a+PX7RZBqIrGzRDU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PLJVIQy1; arc=fail smtp.client-ip=40.93.198.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PLJVIQy1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sMi0fvuCfqVZHu5lRHiYIkKq0cIcR1J3S06Sk5AK9OIgvzm8IE7v1AYxY9IOOb8/ArBpoj/A8cpTmVcPoO/pQ3t8gwJ8hygigTV3PJsWiBKxBqBkDAt9p+9D7pSacRg7nx/0qd49sWM0aW5xoxe/D/NZ75KkVgza1DdIj0Bb9nWwzh0B1qFGfoS4XkNoUHoaOxEnXwgHOmmwtsWz3SWmuErbL7NKtFm29g/ojiYtEnwRurkiMlJb65PRnmwhYuFijg1vo7LLRunM3f6gb+0FJaLWKssLcuP7xsnjB30FC2XZnJnNlW0WXb2jPyfjdtK1y04LtNyvhArohfQJp8Sg8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/TCl+lbCGtlONGF5EKWGglO7xxFhuEQEbWNkDyDXE7g=; b=IATolukmLJfmFb6+YJfXxaf1Bz6Dxp2LLBhucFbnLg5CYnj0p/kjdji8i8HYLOF1njEnYvwETxRHz+U1gEwcSUtRWwzgIhU6V3aE1xFQMHX5lKgewk8HjpfooVpnfw6sWGiJhooj4DSN7r58o13+H0iNcj8W8LFd8yy6e6OaLJ9BTsGwu/r5s9+Q3CQu2Bo+xDcHeWL5qXeC9mb2DoKIuNMERqHjA5FObLfZE72ydHXgzuEarAN2RXYaarYOKkoONZSUtheU3LyhHEbNmcKWHSCKCRgH1a1Xk9Aq1vPlRFguFJXEcQQxRG3uK7lDusQ3TkZ/Lv8KBiz2/dgpDXnvlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/TCl+lbCGtlONGF5EKWGglO7xxFhuEQEbWNkDyDXE7g=; b=PLJVIQy1VeLRm2M6BkR5F/VfxRpcIC3nr5Mglk8xm19iiuXqFeehiQ5BbMYxmgqZRwDUMbkecAsh7egli747PHUj6/EuVbwU8q5/8x4Z+Ah5WPyLDkBFyfrpuZoEgQ7J2zgL/c98hF+g0f3jDiO++9VHICWY9jLVHf3eGsLV9nVHRnwejkfmiu0M4NHHHNEjQ+3k3lUtNcYnoRYPz8OFMd9Q83TEnootZyLz6ulee7oaz4cs+j7IdTAvPHlhgHJv0u+w+tScqhe04Vip4WmC7cinv0Me2ODRtJnQ6q/J6YpJkL6SvrgZR8snjwSqe433dYKQa59wh+aKoCVAP2jvcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) by DM4PR12MB7645.namprd12.prod.outlook.com (2603:10b6:8:107::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.18; Sat, 15 Nov 2025 01:09:31 +0000 Received: from DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb]) by DM3PR12MB9416.namprd12.prod.outlook.com ([fe80::d622:b3e9:bfe1:26bb%7]) with mapi id 15.20.9320.013; Sat, 15 Nov 2025 01:09:31 +0000 From: John Hubbard To: Danilo Krummrich Cc: Alexandre Courbot , Joel Fernandes , Timur Tabi , Alistair Popple , Edwin Peer , Zhi Wang , David Airlie , Simona Vetter , Bjorn Helgaas , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org, LKML , John Hubbard Subject: [PATCH v9 4/4] gpu: nova-core: provide a clear error report for unsupported GPUs Date: Fri, 14 Nov 2025 17:09:22 -0800 Message-ID: <20251115010923.1192144-5-jhubbard@nvidia.com> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251115010923.1192144-1-jhubbard@nvidia.com> References: <20251115010923.1192144-1-jhubbard@nvidia.com> X-NVConfidentiality: public Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR13CA0113.namprd13.prod.outlook.com (2603:10b6:a03:2c5::28) To DM3PR12MB9416.namprd12.prod.outlook.com (2603:10b6:0:4b::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3PR12MB9416:EE_|DM4PR12MB7645:EE_ X-MS-Office365-Filtering-Correlation-Id: 24f109ae-c4da-4a8a-45fe-08de23e3a1dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?H1QYvOERqX61KcT1gw2mrk2cJJd8EaBSAxPS5a8u/98ZalXVlSDZaR29nMJ/?= =?us-ascii?Q?KCizKvIU7yn+EnD13BKsF5MrNxwhEscMAbGWlVEnpQWAwwo066ztRtpIm+sX?= =?us-ascii?Q?1BlAaXOYXcrZ4NrVPd2c3LOUuTTljz8HfZ8RrxnejkE2joxvQ7l9PtX0glq+?= =?us-ascii?Q?A6ARm4qPJ7BGBD6hsVHMDHuWwlgAoKpuChzDVOa8IcjKogWoEWecRdu7sOpN?= =?us-ascii?Q?8QkgKbb8w/UZg3Vn1yjXkCQoWUkusp25bAlAvgK4iucRQRWf9O8A5LpXDh3n?= =?us-ascii?Q?VebCyB2F5pRUCSXnTa5n23zg2LSxO04NskJlKYtnJFSZaSRHBtdJArwAxFIh?= =?us-ascii?Q?FDATFn0NgzwDP7v9kmO6KHgNlpYQSVjxLcKz++hnCQZ+90+xw6MgvFGRx3V8?= =?us-ascii?Q?KFHU93p+6Jp1Q8T6ZK+k4SOXSnwEtkLlJ6QuLdpU7AcPusE7aFz5IKVeSP0R?= =?us-ascii?Q?0yo6bD4YAMRI1T6kl9npfpjussvk660w+W1auWnbqZtrqUzOafnUz3xDGyw6?= =?us-ascii?Q?nxTex46tKr3qM4npDgr+xpEKLRyZG+IGsekvnsrkvx4e3p7JvQQHgYHhqfR9?= =?us-ascii?Q?+xWxn0cR115qaMK4dYC8doAHqN13szaCuK/r4x2KDiOSr/QdIZmi4Aatmry5?= =?us-ascii?Q?f38AuHNOxS43R5/Ib7rQvLLoWzVNBMiQPoUlsgyofjYnVo1a1tzhMjX7hTN6?= =?us-ascii?Q?5nTUhG2GfHXd5qOilKlabSDJWbS2rEP9YsHeo8cCZSLU3y8ng20OQX/qWJfe?= =?us-ascii?Q?BuqsVbCvZ2Gn6CudbEjrpLxDtrAXf0jNa8quj7ZvuITcHrMX7UWtROt/U7G+?= =?us-ascii?Q?RP4zvcC1H8Br4sckpa+xUKXDxTfVecDFqiKp6psFjB0LkjpcpYHnKiVEqgq9?= =?us-ascii?Q?N6B+KC6ygF7NQ3tkGM3FtWdsuFK+OAai+DajTdbZa7QIRwRx4yUD+r/8jnqf?= =?us-ascii?Q?fpWiK/rB5I1yFj6mh+1PPqFFFglly06ByzbNE40kYr55S4PM9NcAnzSFwsEV?= =?us-ascii?Q?oWg4FQQN8vQ6WUGb88S0lZTbgdHRVqFPLUCc6MIyp9GqtwpA5hK6QjDQuFDe?= =?us-ascii?Q?Glayl2xdOLTgYhbxkAJ7eWKtjP3djd0IGiU3ZIwPj/y9uiai8JkGMJwomOHq?= =?us-ascii?Q?2ypfg925CWf58p67DXGToQrh+8BzqvqoT4EDoWw2OONncnjQmdU1SeOVmM50?= =?us-ascii?Q?H6HanMjyKnpvTexl2UEXlBul4tYnsHvUepuAtkOqNWeLAFDKePq0rfav/F2t?= =?us-ascii?Q?cUKTIXOgCRo04ZjDLo7tJcfmTwza9BM/xh2DJEoyKZ17zJUggYSxMH0Evsrh?= =?us-ascii?Q?j29JB1wJwl0X0hYeogZ5XbBWi4f6xOFBxbGp7XGlbVnv3uxX8AUd/SINnsK8?= =?us-ascii?Q?4d6lw8tTqsgRKEg05MMTtjGkQV4OuBgynpVPoeRFaAWGu1uzhpSOK5HpSkOk?= =?us-ascii?Q?3/gs4sQ4xqbQhUzsh+TiSKc70iVJwBso?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM3PR12MB9416.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?utDzca5PM/+/ab9Lz2NLc7yqNKs5YbSduJgBdspqT7+iRCT2TJHQVNiI+wys?= =?us-ascii?Q?u0VNnFN0k+pM734ZZ/9qOCZl7WW2cbmZJKVleJnPypQg/tpOU0/L87GLLkBO?= =?us-ascii?Q?qbK6wl7keLWrlSZKiCel57ku+IBfpUMJOExKANKb/F2vF3Ww5aDp23HRFEMP?= =?us-ascii?Q?uu2AMAoteLfxuG62yCcZft0D+RTpje+YE7b54sCSWemEdCa4A3o+XAq59gxJ?= =?us-ascii?Q?ytNAbcRw6Xp+LI2JRmByTk8E4/ebKRcJhPIdoTonjFdKgj+9/XGISBzE99j7?= =?us-ascii?Q?Izx7NN7GmU35N13EV6RbLJQm9afZZdUsSX0SWrDV3QQ1p4d2nZkF9JfJDMNB?= =?us-ascii?Q?SdScqkfxUaYLgpdht76boon//LoB2/qXas0n5Cfcw9aBmZE+0jHcc2DKDFVM?= =?us-ascii?Q?ADckUI0iDh7OH5r1Kjiuf5+d8f4EPyOmbdjzffJJ4PGGqiYxeAYwNp1C6fM1?= =?us-ascii?Q?JWwBfwkFGpsjZoXuMQTrii5+5oa0rEe5rLQsX3FudIeSdfv6DD1eJpO6bv6C?= =?us-ascii?Q?DGDTgjSdBDyprGnHWt28sgNE96ek3AW7Ecou3YmBOJlmwYJyvcc32+HOchq8?= =?us-ascii?Q?gC9tRGVuXXL8A5wdnrsh8RC1/iMoCauk5Hnx+rjwCIgW6FMk/kae2LF4ZDRs?= =?us-ascii?Q?brPHiAml3/GkTGqvXsIM+QwBIAPtEA5X0Odo6UA7Gwq0Uu3781VFEM9YJO9W?= =?us-ascii?Q?eTh3ZvGQgb7DCo2quMUhc69TUT9fscWoCGL5uSexhTO+KE+fSdkDYFgJvtkx?= =?us-ascii?Q?Q9kfbVyxTC+5Jnf5brQFqTOBkTdd+/tqEZOYCPVBTdsTZ5188d2kE0/NWtqr?= =?us-ascii?Q?fNSU2kcMHBYQ3z0xorw1bKrD1ZH1uC7Q1qhNYgb+diLq5UO7tv39+/4N3f+i?= =?us-ascii?Q?NMsYUbWGmG4Ge3aCUK7xP5uRYgpos/zus8HSyyEX22xFs0U7Fv+99r0ZO06j?= =?us-ascii?Q?tjSmmEX4p36M0IUquJxNpX+o6r78Y4SDBAdGLtXb1OFFf7LchNdzzYUnhr7A?= =?us-ascii?Q?p+MH4qbpK5kT6G76AJdNnkR8/mE8dkjaKWl+lN02mUw5iEM75+xASq5LNTd2?= =?us-ascii?Q?EOCnRueG1ym5wc6rOCW9tMEA/M9gJOVsFFnFZ4uYLoXFMuJZ76tI87tdAcm2?= =?us-ascii?Q?i4kIq6lZSRNLvQYCh+WMhpvBb2/jI/Fbi5Z7orA+YmSjTUZJqQonB0PqUyfd?= =?us-ascii?Q?NTcOYtg8/nyyKhIqu3lb6giC+iUyDNqGsN6omGw4aFA4GUxHO8Yrk+RlC5OS?= =?us-ascii?Q?gXRijN8cBryaxyby3sXuC2IGGTOICaOEFntQ7A+k9mv6EYhPeyKfeKqL/opL?= =?us-ascii?Q?eXv2B1ikl26WwiCke/XW1ZTMPuvAx9JCZ4LOyyoYOrq4+SS3fXnTBBzC0eIV?= =?us-ascii?Q?3FhfppVcJW3hren3rqBObDDhyqGZpq8OvCT16gOKN5d2vWEzm1d3Mky+SOd0?= =?us-ascii?Q?ydU4z/D9QK4pjlQ5iEitLOp7FS7G0kIXLR1mPEL9DxkiAWJzn/Acgp86J/gG?= =?us-ascii?Q?hNs+CpTLOqNnIFZO9X9MsRB9Rs0qv5KZT6v9fu95I2bXAYMCVkGaSkPYUUL7?= =?us-ascii?Q?lvKdgkuKcXP5S0DHeOtJBB5qyyB6ssxkdqHe6tQ+?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24f109ae-c4da-4a8a-45fe-08de23e3a1dc X-MS-Exchange-CrossTenant-AuthSource: DM3PR12MB9416.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2025 01:09:31.5340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LXv2e2uQ2G1PCJz8FVb1l5tEFWdI4nM1e248dJmZxUWG43RW+stqM51+R5Q+wCyrmw4SkjyF6S1uw5nfbnhBEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7645 Content-Type: text/plain; charset="utf-8" Pass in a PCI device to Spec::new(), and provide a Display implementation for boot42, in order to provide a clear, concise report of what happened: the driver read NV_PMC_BOOT42, and found that the GPU is not supported. For very old GPUs (older than Fermi), the driver still returns ENOTSUPP, but it does so without a driver-specific dmesg report. That is exactly appropriate, because if such a GPU is installed, it can only be supported by Nouveau. And if so, the user is not helped by additional error messages from Nova. Here's the full dmesg output for a Blackwell (not yet supported) GPU: NovaCore 0000:01:00.0: Probe Nova Core GPU driver. NovaCore 0000:01:00.0: Unsupported chipset: boot42 =3D 0x1b2a1000 (architec= ture 0x1b, implementation 0x2) NovaCore 0000:01:00.0: probe with driver NovaCore failed with error -524 Cc: Alexandre Courbot Cc: Danilo Krummrich Cc: Timur Tabi Cc: Joel Fernandes Signed-off-by: John Hubbard --- drivers/gpu/nova-core/gpu.rs | 9 ++++++--- drivers/gpu/nova-core/regs.rs | 18 ++++++++++++++++++ 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 8e04628ca3d9..2bbc084e2095 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -191,7 +191,7 @@ pub(crate) struct Spec { } =20 impl Spec { - fn new(bar: &Bar0) -> Result { + fn new(dev: &device::Device, bar: &Bar0) -> Result { // Some brief notes about boot0 and boot42, in chronological order: // // NV04 through NV50: @@ -216,7 +216,10 @@ fn new(bar: &Bar0) -> Result { return Err(ENODEV); } =20 - Spec::try_from(regs::NV_PMC_BOOT_42::read(bar)) + let boot42 =3D regs::NV_PMC_BOOT_42::read(bar); + Spec::try_from(boot42).inspect_err(|_| { + dev_err!(dev, "Unsupported chipset: {}\n", boot42); + }) } } =20 @@ -268,7 +271,7 @@ pub(crate) fn new<'a>( bar: &'a Bar0, ) -> impl PinInit + 'a { try_pin_init!(Self { - spec: Spec::new(bar).inspect(|spec| { + spec: Spec::new(pdev.as_ref(), bar).inspect(|spec| { dev_info!(pdev.as_ref(),"NVIDIA ({})\n", spec); })?, =20 diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index c6e2e08c754b..a53b013f2eca 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -67,6 +67,24 @@ pub(crate) fn chipset(self) -> Result { }) .and_then(Chipset::try_from) } + + /// Returns the raw architecture value from the register. + fn architecture_raw(self) -> u8 { + ((self.0 >> Self::ARCHITECTURE_RANGE.start()) & ((1 << Self::ARCHI= TECTURE_RANGE.len()) - 1)) + as u8 + } +} + +impl kernel::fmt::Display for NV_PMC_BOOT_42 { + fn fmt(&self, f: &mut kernel::fmt::Formatter<'_>) -> kernel::fmt::Resu= lt { + write!( + f, + "boot42 =3D 0x{:08x} (architecture 0x{:x}, implementation 0x{:= x})", + self.0, + self.architecture_raw(), + self.implementation() + ) + } } =20 // PBUS --=20 2.51.2