From nobody Sun Feb 8 05:19:47 2026 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD855335061 for ; Fri, 14 Nov 2025 16:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138406; cv=none; b=dIWQsvkoz5joEznEq0HByheAKH1kW8VcI0Bc/DwyOndMcfvmygM+53O2V4Y1uex2rxsTTey3r+PcCY83Go6gK9GH5IAZHTBc5+dG5+xEx8SZnuRXcaX2FMoAadle7K/Q/naTbslu6nuSDetM9ZJUqimldJfATesPcpDP0NigM5M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763138406; c=relaxed/simple; bh=0q1LSTNcWfhRhxo9wwTNWh/KOxbev5bnQ/8Wdz5tUuc=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=ipA80qB/BfX4HdTph5Nawh7Da/3PfJXn0ddnlse/btIvN0nLzggxWfa2AhhYgNdydV8OnKACjVdL2G+/ZnXekKXWqlEXyVrK1wI+46A6Kzymuh3CLWy1RBBqguhlKk/6zNKLtLAivuGOFY6PrlAghglp0cACvhW5gYdjvggLyh8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=BRh4zlpJ; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BRh4zlpJ" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-29557f43d56so29657175ad.3 for ; Fri, 14 Nov 2025 08:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1763138404; x=1763743204; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=KTMohZMjF0LmDk1TElNZL5EIXiLhl+OzBkAAJL2pM6g=; b=BRh4zlpJopspjWt6Vg+B0nyV00QWz0NKlvl+yTS9I1lY2E6wqTP2VrDJrjr9PXoqFx rTmQCuQaIqTFcPMR9Roce2REf0Y1VVjamgISEcQ/P3Bic6aES02FSJlJUa68iQzbYOmh WtGbezadAnt/7NGXtVqboqDVLzBJWGouceGc5QSrLWYvf/6OV+t3HhcaRPTvJ/Wvc6lV MbJ3UwENrv3cEnNp/qlX/1jnWeAgVYw3cUoGbAmeIBQ8Trfn7eTfGu3L5Le3mBFAEkqa 5Aw9tZAalPbRFi/XXEvg0JCtQRahpUGzrNaKd3Ye7h3rDXjmMXIJJ/gzdRzLAHtDLvvD oYwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763138404; x=1763743204; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KTMohZMjF0LmDk1TElNZL5EIXiLhl+OzBkAAJL2pM6g=; b=EmnFJQkrsAKyM3jYGrOtqUBPKShAU+3ILY5PRp/o8J+1dJOEfjOgl04TWt1Bd8ZRV2 Q2Aco7SIDKVongYNlwRtmDGFr6UwmH+dKbxSZi1RhAJWf2ruKckAKBUiQLGU0xqfEbbf gGPSKQ5yrzHYLKHFFZmKa9t1CtXs3Hp7pG2x+aG+lnjT1OnTL57IKR2dyYEAFzibE2Hb syq3FW6JeRRGLz9s+g3hv6XBcd/tKSMppYTz0OrI2sLFTu7bfQIuILizgmwHhZVymUYx o922mBW26qLhPbPNQoSm4MNG+P1+VrltB8mrKZ/lHZAmJDs3ZHn4Tw00EfjraYPAy2EE /neg== X-Forwarded-Encrypted: i=1; AJvYcCWQw1hBunp6miWscgYkaddS1QNQeshp0Cpp3iqcAxDX9kgPFk2MfyieGhY3f/nQpJKpRH+2dJMMSLYWnvM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7sV0VwoucalqUu9VvXwnbPCABOUq9Oo6iPaaXrwxlMTA/Puif 9TdDwa/+HW2cXQ/g+NqQKIr1VHSsuIlx/4Qr9PjgVPyJ5erv3ZRgq5EdbdBKdVLGBSj0T6PvWmo V4Y2Csg== X-Google-Smtp-Source: AGHT+IGA7G1A0VmYSd0Eo9Xq1AOJbGmNJ/+oU6KUlAGTk5vw5hoj9x9MGGqCLYmTDTDqmV0H8SYZbnqUSqQ= X-Received: from pjwo13.prod.google.com ([2002:a17:90a:d24d:b0:33b:c211:1fa9]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:f647:b0:298:42ba:c422 with SMTP id d9443c01a7336-2986a73303amr42123035ad.31.1763138404137; Fri, 14 Nov 2025 08:40:04 -0800 (PST) Reply-To: Sean Christopherson Date: Fri, 14 Nov 2025 08:40:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.rc1.455.g30608eb744-goog Message-ID: <20251114164001.1791718-1-seanjc@google.com> Subject: [PATCH] KVM: selftests: Use GUEST_ASSERT_EQ() to check exit codes in Hyper-V SVM test From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Yosry Ahmed Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use GUEST_ASSERT_EQ() instead of GUEST_ASSERT(x =3D=3D SVM_EXIT_) in = the Hyper-V SVM test so that the test prints the actual vs. expected values on failure. E.g. instead of printing: vmcb->control.exit_code =3D=3D SVM_EXIT_VMMCALL print: 0x7c !=3D 0x81 (vmcb->control.exit_code !=3D SVM_EXIT_VMMCALL) Cc: Yosry Ahmed Signed-off-by: Sean Christopherson Reviewed-by: Yosry Ahmed --- .../testing/selftests/kvm/x86/hyperv_svm_test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/kvm/x86/hyperv_svm_test.c b/tools/test= ing/selftests/kvm/x86/hyperv_svm_test.c index 0ddb63229bcb..7fb988df5f55 100644 --- a/tools/testing/selftests/kvm/x86/hyperv_svm_test.c +++ b/tools/testing/selftests/kvm/x86/hyperv_svm_test.c @@ -94,7 +94,7 @@ static void __attribute__((__flatten__)) guest_code(struc= t svm_test_data *svm, =20 GUEST_SYNC(2); run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_VMMCALL); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_VMMCALL); GUEST_SYNC(4); vmcb->save.rip +=3D 3; =20 @@ -102,13 +102,13 @@ static void __attribute__((__flatten__)) guest_code(s= truct svm_test_data *svm, vmcb->control.intercept |=3D 1ULL << INTERCEPT_MSR_PROT; __set_bit(2 * (MSR_FS_BASE & 0x1fff), svm->msr + 0x800); run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_MSR); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_MSR); vmcb->save.rip +=3D 2; /* rdmsr */ =20 /* Enable enlightened MSR bitmap */ hve->hv_enlightenments_control.msr_bitmap =3D 1; run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_MSR); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_MSR); vmcb->save.rip +=3D 2; /* rdmsr */ =20 /* Intercept RDMSR 0xc0000101 without telling KVM about it */ @@ -117,13 +117,13 @@ static void __attribute__((__flatten__)) guest_code(s= truct svm_test_data *svm, vmcb->control.clean |=3D HV_VMCB_NESTED_ENLIGHTENMENTS; run_guest(vmcb, svm->vmcb_gpa); /* Make sure we don't see SVM_EXIT_MSR here so eMSR bitmap works */ - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_VMMCALL); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_VMMCALL); vmcb->save.rip +=3D 3; /* vmcall */ =20 /* Now tell KVM we've changed MSR-Bitmap */ vmcb->control.clean &=3D ~HV_VMCB_NESTED_ENLIGHTENMENTS; run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_MSR); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_MSR); vmcb->save.rip +=3D 2; /* rdmsr */ =20 =20 @@ -132,16 +132,16 @@ static void __attribute__((__flatten__)) guest_code(s= truct svm_test_data *svm, * no VMCALL exit expected. */ run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_MSR); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_MSR); vmcb->save.rip +=3D 2; /* rdmsr */ /* Enable synthetic vmexit */ *(u32 *)(hv_pages->partition_assist) =3D 1; run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D HV_SVM_EXITCODE_ENL); + GUEST_ASSERT_EQ(vmcb->control.exit_code, HV_SVM_EXITCODE_ENL); GUEST_ASSERT(vmcb->control.exit_info_1 =3D=3D HV_SVM_ENL_EXITCODE_TRAP_AF= TER_FLUSH); =20 run_guest(vmcb, svm->vmcb_gpa); - GUEST_ASSERT(vmcb->control.exit_code =3D=3D SVM_EXIT_VMMCALL); + GUEST_ASSERT_EQ(vmcb->control.exit_code, SVM_EXIT_VMMCALL); GUEST_SYNC(6); =20 GUEST_DONE(); base-commit: 16ec4fb4ac95d878b879192d280db2baeec43272 --=20 2.52.0.rc1.455.g30608eb744-goog